- 17 Apr, 2018 40 commits
-
-
Rob Buis authored
Serialize border-image inline style by implementing the serializing logic for it in StylePropertySerializer::GetPropertyValue. Bug: 825568 Change-Id: Ibaa18dadc41bb7aa735ab5e1384615b5d2270a2c Reviewed-on: https://chromium-review.googlesource.com/990721 Commit-Queue: Rob Buis <rob.buis@samsung.com> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#551310}
-
Roman Sorokin authored
Moved calling to D-Bus service out of EnrollmentScreenHandler into EnrollmentScreen. Needed because EnrollmentScreen implements ActiveDirectoryJoinDelegate. Future CL will use that to provide dm token to D-Bus service and to use configuration seed coming from DM server. BUG=chromium:829361,chromium:809914 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I606d974e3461c802b37ff88ec0658f910a3953f5 Reviewed-on: https://chromium-review.googlesource.com/1004954 Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#551309}
-
Hans Wennborg authored
The previous DCHECK was comparing the pointer values, not the strings. Bug: 833807 Change-Id: I0e63eda10838de481c51630f8932b41537a76847 Reviewed-on: https://chromium-review.googlesource.com/1013525 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#551308}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/778a1cdf05f1..888a7065b4ba $ git log 778a1cdf0..888a7065b --date=short --no-merges --format='%ad %ae %s' 2018-04-16 ihf chromeos_config: reorganize caroline CQ/PFQ. Created with: roll-dep src/third_party/chromite The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ife1a4d5087a457c3c19d3a9f7d29c0c8696f3ee1 Reviewed-on: https://chromium-review.googlesource.com/1014940Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551307}
-
Rune Lillesveen authored
TBR=fukino@chromium.org Bug: 833795 Change-Id: I105312fb6b0de0e2db8fad25b4463109e747e9e5 Reviewed-on: https://chromium-review.googlesource.com/1013942Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#551306}
-
Finnur Thorarinsson authored
from the Display status and make it informational only (not abort the call). Bug: 734095 Change-Id: Id55c2c32a077d27ae06b11ee36241df5ee5a8318 Reviewed-on: https://chromium-review.googlesource.com/1007278 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#551305}
-
agrieve authored
This reverts commit dbd17728. Reason for revert: Broke supersize Original change's description: > Supersize: Tweak variable name (no behavior change) > > Addressing review comments from TBR'ed: > dd5d5a01 > > Change-Id: Ic181c0da49f82031bf842ce69a05d14144dd92f8 > Reviewed-on: https://chromium-review.googlesource.com/1014293 > Reviewed-by: Samuel Huang <huangs@chromium.org> > Commit-Queue: Samuel Huang <huangs@chromium.org> > Commit-Queue: agrieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551073} TBR=huangs@chromium.org,agrieve@chromium.org Change-Id: I52a434cad48f795075eaab834e9c039294e988d5 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1014976Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#551304}
-
Christos Froussios authored
When we update parts of the key of existing credentials, we need the pre-update data. We take this data from the password store, as found in |best_matches|. Sometimes, the updated credential is not in the matches. This CL fixes a crash from https://chromium-review.googlesource.com/c/chromium/src/+/941522 where we presumed that the credentials are always in the matches. Bug: 833171, 817750 Change-Id: Id2aae19b307d65c3527cdf9a6c80703dc6bfeb34 Reviewed-on: https://chromium-review.googlesource.com/1012848 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#551303}
-
Gauthier Ambard authored
This CL removes the unseen state (in the tools menu button in the toolbar) when the UI Refresh flag is enabled. Bug: 828367, 831134 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4446d5b4f2565f256e4fedb829a77e93295b0d00 Reviewed-on: https://chromium-review.googlesource.com/1014092Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#551302}
-
Max Morin authored
The Origin is now looked up in the browser, so passing the origin is unnecessary. This is a followup to https://chromium-review.googlesource.com/c/chromium/src/+/1010424. Also fix some lint. Bug: 653871,721732 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I681dd754d71e1fe87e94f514428e1b3bea7aa736 Reviewed-on: https://chromium-review.googlesource.com/1012114 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#551301}
-
https://skia.googlesource.com/skia.git/+log/b460320a96df..eedecc6046b2 $ git log b460320a9..eedecc604 --date=short --no-merges --format='%ad %ae %s' 2018-04-17 angle-skia-autoroll Roll third_party/externals/angle2/ a4fa9c278..08b9e046c (6 commits) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I24a36d8cf7a95a7f8b3db51444be07e19e601b3c Reviewed-on: https://chromium-review.googlesource.com/1014542Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551300}
-
jdoerrie authored
This change fixes a bug in U2fSign, where under certain circumstances an end iterator was dereferenced. Bug: 833398 Change-Id: I9194a966b01fbe9da6e51e50645f7f301e0d59e5 Reviewed-on: https://chromium-review.googlesource.com/1013484 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#551299}
-
Ramin Halavati authored
Tests are added to compare outputs of traffic_annotation_auditor using different parameters. Bug: 690323 Change-Id: I69bc0234310020e2e92ecdd25c90f543f9b99459 Reviewed-on: https://chromium-review.googlesource.com/960143 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#551298}
-
Harald Alvestrand authored
This is needed to return error codes to the Blink layer. Bug: 589455 Change-Id: I698325ae7960121174af1b345f438e716fd0d099 Reviewed-on: https://chromium-review.googlesource.com/1013521Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
-
Shuo Weng authored
Bug: 833214 Change-Id: I5552bdca37a2e3e20a039b9a0ca316f4480b1217 Reviewed-on: https://chromium-review.googlesource.com/1010055 Commit-Queue: Shuo Weng <shuow@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#551296}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3b0840b3. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15693 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: If9b8527313ca74fadb7945751dcdecc335208264 Reviewed-on: https://chromium-review.googlesource.com/1014731 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#551295}
-
Maksim Ivanov authored
The new policy gates the decision whether the client certificate based user data protection should be used for users signing in via SAML. For example, this allows to configure the smart card sign in, with the smart card being the first factor of the user authentication. * By default, the implementation-defined behavior will be used, which currently is a synonym to password-based authentication and cached data protection. * When the "client certificate" type is configured via this policy, the client certificates chosen by a login app and the corresponding keys are used for authenticating users and protecting the cached data. Bug: 826417 Test: unit_tests --gtest_filter=DeviceSettingsProviderTest.SamlLoginAuthenticationType Change-Id: I634d39f6b7f14457d292d9ce88eeb458a7e28014 Reviewed-on: https://chromium-review.googlesource.com/983960Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#551294}
-
Mark Cogan authored
This CL removes the obsolete-after-iOS8 LayoutOptionForRTLSupport() utility method. Since that was the major use case for many of the "option" variants of AddConstraint methods, they were converted to the fewer-parameter version, and other obsolete variants were also cleaned up. Bug: 637247 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I961204c1620d354b2c3c3461baa65a8d903e8c5b Reviewed-on: https://chromium-review.googlesource.com/1013569 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#551293}
-
chrome://reset-passwordRune Lillesveen authored
This reverts commit 21f70497. Reason for revert: Linux CFI detected a bad type cast in ChromePasswordProtectionServiceBrowserTest See: https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_CFI%2F7224%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FChromePasswordProtectionServiceBrowserTest.VerifyIsPasswordReuseProtectionConfigured%2F0 Original change's description: > Add a static chrome://reset-password page > > Chrome will open a tab with chrome://reset-password if the user reuses > their protected enterprise password on other sites that are not allowed > by enterprise policy. > chrome://reset-password will only show if password protection related > enterprise policy settings are properly set. Otherwise, user will see > ERR_INVALID_URL. > > The new icon in ui/webui/resources/cr_elements/icons.html is copied from > /chrome/browser/resources/settings/icons.html > > Bug: 824501 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I8d648f0484e0c569ddbed048114a90471e4eea25 > Reviewed-on: https://chromium-review.googlesource.com/996565 > Commit-Queue: Jialiu Lin <jialiul@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Nathan Parker <nparker@chromium.org> > Reviewed-by: Varun Khaneja <vakh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551195} TBR=stevenjb@chromium.org,calamity@chromium.org,nparker@chromium.org,vakh@chromium.org,jialiul@chromium.org Change-Id: I36544eabdd6e8822c15e37e68166e06452dfe57f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 824501 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1014091Reviewed-by:
-
Pavol Marko authored
Sync to the newest server-side version. Bug: none Change-Id: I5c93a8d5569e9079c1738014a632a63538136249 Reviewed-on: https://chromium-review.googlesource.com/1014110Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#551291}
-
Ioana Pandele authored
Currently, the password manager doesn't autofill forms with prefilled values in the username field in order to preserve existing information. This CL changes the behavior to autofill in cases where the prefilled username value is part of a list of known placeholders. Bug:832622 Change-Id: I9178eac0e609655c61e5e1caf35d083414e14b8b Reviewed-on: https://chromium-review.googlesource.com/1007723Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#551290}
-
Rune Lillesveen authored
This reverts commit 042ae97b. Reason for revert: roll caused multiple chromium bots to start failing Original change's description: > Roll src/third_party/angle/ aa8b3982a..08b9e046c (2 commits) > > https://chromium.googlesource.com/angle/angle.git/+log/aa8b3982aeeb..08b9e046c1b6 > > $ git log aa8b3982a..08b9e046c --date=short --no-merges --format='%ad %ae %s' > 2018-04-16 jmadill Vulkan: Disable warning in Mock ICD. > 2018-04-16 tobine Roll (2/2) to latest LVL as of 4/16/18 > > Created with: > roll-dep src/third_party/angle > > > The AutoRoll server is located here: https://angle-chromium-roll.skia.org > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > TBR=jmadill@chromium.org > > No-Try: True > Change-Id: I34309b2c8fc6f4d49ba465929378687aaaa181a1 > Reviewed-on: https://chromium-review.googlesource.com/1014671 > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#551232} TBR=jmadill@chromium.org,angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Change-Id: Ic6b5936a64210a40c6a2288fcbbed2a0e4bb1bf4 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1013940Reviewed-by:
-
Marc Treib authored
This was fun because these tests used account_id, gaia_id, and email more or less interchangably, which doesn't work well with IdentityManager (or with sanity). This CL cleans this up and clearly differentiates the three. Bug: 825190 Change-Id: Ibdebb6d295f84ef15dd2864819c98fb1274ab63c Reviewed-on: https://chromium-review.googlesource.com/1010423Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#551288}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b08b074b..73d9591f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Id49af88a70994dfa7122db0185d2dd494dad8549 Reviewed-on: https://chromium-review.googlesource.com/1014728Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#551287}
-
Gauthier Ambard authored
This CL changes the layout of the toolbar buttons. The tab switcher is now always on the trailing side, and the bookmarks button is only visible on iPad. Bug: 831151 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I903e4b702439c23a01e2cf4ef8e2edecae11fdf4 Reviewed-on: https://chromium-review.googlesource.com/1013558 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/745ac35bed03..778a1cdf05f1 $ git log 745ac35be..778a1cdf0 --date=short --no-merges --format='%ad %ae %s' 2018-04-13 khmel arc: Add packing SDK tools to uprev Android container. Created with: roll-dep src/third_party/chromite The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I65d06f12292b58732e710ca3c8d7b8da6bbc5c3a Reviewed-on: https://chromium-review.googlesource.com/1014742Reviewed-by:
-
Rune Lillesveen authored
This reverts commit 499570b6. Reason for revert: Caused failures in browser_tests debug builds for two tests: CrExtensionsItemsTest.ClickableItems CrExtensionsItemsTest.FailedReloadFiresLoadError Original change's description: > MD Extensions - A11y: Announce when an extension has been updated. > > Bug: 27175 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I2fed4c16cf0406ea5361413840fe5ab2f5968f69 > Reviewed-on: https://chromium-review.googlesource.com/1003056 > Commit-Queue: Hector Carmona <hcarmona@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551142} TBR=rdevlin.cronin@chromium.org,hcarmona@chromium.org Change-Id: I8f6e654c798127a3a77d0cb2a107443aa8465686 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 27175 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1012850Reviewed-by:
-
Luciano Pacheco authored
This button is <paper-button> in contrast to other buttons that are just <button> so the style wasn't applying to it. Add "menu-button" CSS class to all buttons within div.dialog-header so they can share similar style. Bug: 687077 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1426891c17f734e8d4ce81cdec48c23cdefcbbdd Reviewed-on: https://chromium-review.googlesource.com/1013844Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#551283}
-
Mitsuru Oshima authored
BUG=833456 TEST=none Change-Id: I9d01f94670a406ea7b30b4c232775dc76ad4a48c Reviewed-on: https://chromium-review.googlesource.com/1013272 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#551282}
-
Jonas Olsson authored
Bug: chromium:672469 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I33a9e06feddf52699c47a8d64e17eca8ed797bf6 Reviewed-on: https://chromium-review.googlesource.com/1013460 Commit-Queue: Jonas Olsson <jonasolsson@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#551281}
-
Marc Treib authored
This CL migrates LocalDiscoveryUITest from the old SigninManager + OAuth2TokenService to the new IdentityManager. TBR=vitalybuka@chromium.org (reviewed by @google.com account) Bug: 825190, 798408 Change-Id: If301de8524ee22c52dc4a4a0a0918c941d449226 Reviewed-on: https://chromium-review.googlesource.com/1012105 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@google.com> Cr-Commit-Position: refs/heads/master@{#551280}
-
Noel Gordon authored
Postpone the creation of the FilesApp component extensions AudioPlayer FileManager, Gallery, and VideoPlayer in browser testing. Not doing so leads to systemic browser test failures (flakiness) per the bugs. Fix: prepare test resources first, load the component extensions, then start testing. Failure was the component extensions were active before the file resources needed by the tests were ready, causing flake-fails when the component extensions tried to access those resources. Bug: 831074, 804413, 829310 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie794bac638f48c3855e0c1f1609e59aa615c31dd Reviewed-on: https://chromium-review.googlesource.com/1013823 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Tomasz Mikolajewski <mtomasz@chromium.org> Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#551279}
-
Gauthier Ambard authored
This CL changes the omnibox button's background to match the browsing mode (incognito or normal). Bug: 829769 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I052e1228332121e7e75b1b781dabd7c4e6c3083b Reviewed-on: https://chromium-review.googlesource.com/1012840Reviewed-by:
-
Brian Osman authored
skcms will replace SkICC and some other pieces of Skia's colorspace API. Change-Id: I25615bce2963689eae26b41bc66532aa1a6e1daf Reviewed-on: https://chromium-review.googlesource.com/1014368Reviewed-by:
Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#551277}
-
Kenichi Ishibashi authored
This test is failing regardless S13nServiceWorker is enabled or not. We already have an entry in TestExpectation for this test so we can remove the entry from FlagExpectations. I ran the test 100 times (--iteration=10 and --repeat-each=10) and confirmed that the test isn't flaky. Bug: 715640 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I3ef85639001e2f01bc469ac771e479d816c3ea77 Reviewed-on: https://chromium-review.googlesource.com/1013675Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#551276}
-
Jeremy Roman authored
This is now allowed across the Blink API, and also removes the need to write manual "delete this;" code. Change-Id: If5224aac68d6c96b7c6f7014580955e4922ea0bd Reviewed-on: https://chromium-review.googlesource.com/1013062 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#551275}
-
Gauthier Ambard authored
This CL adds a new activity to the activity menu (share menu) to have allow bookmarking the current page. Bug: 829324 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If03dedc18b3f514bf54b75a8508dad3bd4c3bf84 Reviewed-on: https://chromium-review.googlesource.com/1012067Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#551274}
-
Ramin Halavati authored
Network traffic annotations summary has a minory format typo which is corrected. Change-Id: I5830be957859e056ec9aa6dac6f0c1f8f2507b44 TBR: dullweber@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1013490 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#551273}
-
Gauthier Ambard authored
This CL changes the way the toolbar button associated with a popup menu is spotlighted. It reduces the alpha of the buttons. This is used to reduce the alpha of the background of the omnibox button to prevent confusion between the spotlighted button and the omnibox button. It also changes the color of the spotlight in incognito, making it white instead of dark. Bug: 817752, 832076 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iee6797945df2e9ec65464ca0393789eb3b581e71 Reviewed-on: https://chromium-review.googlesource.com/1014124Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#551272}
-
Gauthier Ambard authored
This CL changes the CRWWebViewScrollViewProxy such as it is now persisting the value of the properties even after setting a new ScrollView. Bug: 831519 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I776c7983df536d5bed9c03a826998413b8a6d246 Reviewed-on: https://chromium-review.googlesource.com/1013520Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#551271}
-
