Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 10 Mar, 2020 38 commits
  3. 09 Mar, 2020 2 commits
    • S. Ganesh's avatar
      Reland "Better registry cleanup in InstallServiceWorkItemTest." · 0b6c41a8
      S. Ganesh authored 
      This reverts commit b99538b3.

Reason for revert: The original CL 2092939 was not the cause of the flaky failures, so reverting the revert.

Original change's description:
> Revert "Better registry cleanup in InstallServiceWorkItemTest."
> 
> This reverts commit b256ed1f.
> 
> Reason for revert: I'm hoping reverting this and your other patch will fix the flake. Bug is here: https://bugs.chromium.org/p/chromium/issues/detail?id=1059314
> 
> Original change's description:
> > Better registry cleanup in InstallServiceWorkItemTest.
> > 
> > mini_installer_tests ChromeUserLevel and ChromeUserLevelUpdate are
> > failing with the following error:
> > 
> > AssertionError: In state 'chrome_user_installed_not_inuse', Registry key
> > HKEY_LOCAL_MACHINE\Software\Chromium exists.
> > 
> > This is most likely due to the change I made in change 2086353 to delete
> > a value instead of the key.
> > 
> > Now the test will delete the key if the test is the one that created the
> > key in the first place.
> > 
> > Bug: 1059314
> > Change-Id: I2b85e1f4c979c52a41aebb41c4951b60cf58a50a
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092939
> > Commit-Queue: Greg Thompson <grt@chromium.org>
> > Reviewed-by: Greg Thompson <grt@chromium.org>
> > Auto-Submit: S. Ganesh <ganesh@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#748062}
> 
> TBR=ganesh@chromium.org,grt@chromium.org
> 
> Change-Id: I875c730322f5bc4cc9fdfa8b5497e26f2b8b81da
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1059314
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095201
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#748256}

TBR=sky@chromium.org,ganesh@chromium.org,grt@chromium.org

Change-Id: Ia53b0dae159068f44137e0e8d597d3dd9c2f0428
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1059314
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095766Reviewed-by: default avatarS. Ganesh <ganesh@chromium.org>
Commit-Queue: S. Ganesh <ganesh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748415}
      0b6c41a8
    • S. Ganesh's avatar
      Reland "Fix InstallServiceWorkItemTest deletes Chrome key under ClientState." · df91c37e
      S. Ganesh authored 
      This reverts commit 9e13a828.

Reason for revert: The original CL 2086353 was not the cause of the flaky failures, so reverting the revert.

Original change's description:
> Revert "Fix InstallServiceWorkItemTest deletes Chrome key under ClientState."
> 
> This reverts commit ea173bd3.
> 
> Reason for revert: Still seeing failure of mini_installertests. Hoping this will fix the flake. Bug is https://bugs.chromium.org/p/chromium/issues/detail?id=1059314
> 
> Original change's description:
> > Fix InstallServiceWorkItemTest deletes Chrome key under ClientState.
> > 
> > Greg discovered that InstallServiceWorkItemTest.Do_ServiceName will
> > create Google\Update\ClientState\{8A69D345-D564-463c-AFF1-A69D9E530F96}
> > if it does not exist and then delete it. If the test is run on a
> > development machine, it will corrupt the stable Chrome install.
> > 
> > Bug: 1057233
> > Change-Id: I5e71c6ab9776f376dcffe0a415bfb084baec8e26
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086353
> > Auto-Submit: S. Ganesh <ganesh@chromium.org>
> > Reviewed-by: Greg Thompson <grt@chromium.org>
> > Commit-Queue: Greg Thompson <grt@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#746738}
> 
> TBR=ganesh@chromium.org,grt@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 1057233
> Change-Id: I57c3d50264dcf433a123e2802f04a70af8742935
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094466
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#748270}

TBR=sky@chromium.org,ganesh@chromium.org,grt@chromium.org

Change-Id: I561963764eae05901f083b9c235cce165e623b9d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1057233
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095956Reviewed-by: default avatarS. Ganesh <ganesh@chromium.org>
Commit-Queue: S. Ganesh <ganesh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748414}
      df91c37e