- 20 Sep, 2018 40 commits
-
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/109aa6d0f673..dd92aa594625 git log 109aa6d0f673..dd92aa594625 --date=short --no-merges --format='%ad %ae %s' 2018-09-20 thestig@chromium.org Fix misc lint errors and other cleanups. Created with: gclient setdep -r src/third_party/pdfium@dd92aa594625 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I810c9319884a00aea8b64b4ef440ea5e3cd87183 Reviewed-on: https://chromium-review.googlesource.com/1235841Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592790}
-
Sean Gilhuly authored
Remember the last call to SetOutputIsSecure, and apply the information when the compositor is configured, or if the gpu process crashes. Bug: 882519 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Id212aaae3b2c164575c1d8e92e93e623bd182d69 Reviewed-on: https://chromium-review.googlesource.com/1225290 Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#592789}
-
Anders Hartvoll Ruud authored
R=futhark@chromium.org Bug: 641877 Change-Id: I0b4dc43b29f7e30dbc3eab89f22ffa5505e6a333 Reviewed-on: https://chromium-review.googlesource.com/1235999 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#592788}
-
Anders Hartvoll Ruud authored
This Options object will soon need to carry information that ValueForCustomProperty needs to act upon. Specifically, it needs to know whether the resolved CSSVariableData should be stored on the ComputedStyle before returning. Also, since the Options object is now available here, let ValueForCustomProperty return nullptr if a variable is disallowed. This avoids an extra PropertyRegistation lookup at one of the callsites. R=futhark@chromium.org Bug: 641877 Change-Id: I85f51ff23d23ab404f6fc133e2017f70dd5aea03 Reviewed-on: https://chromium-review.googlesource.com/1235721 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by:
-
Etienne Pierre-Doray authored
Original CL intention was: This CL uses ScopedBlockingCall to mark blocking calls in /chromeos/binder. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=satorux@chromium.org Bug: 874080 Change-Id: Ia8c04385530dbaefee972c8ebffc46c1ec627aa3 Reviewed-on: https://chromium-review.googlesource.com/1191246 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#592786}
-
Kyoko Muto authored
In this CL, we reuse hashset that control all the assigned slots in the shadowroot for each node, added previous CL. Thanks to the hashset we can find the assigned slot for each node in O(1) order, instead of searching all the slot for each shadow root when we call slot change event. We will improve this implementation in another CL. Result of perftests: https://pinpoint-dot-chromeperf.appspot.com/job/151f9a47640000 Previous implementation CL: crrev.com/c/1179555 See design doc at https://docs.google.com/document/d/1n2iDNkI5bF4B5eefxa0SRSyS_RVchvTNSqezvA4PyF4/edit?usp=sharing Bug: 869308 Change-Id: I96fc4c50d9083eca199c7849db0097e73436983d Reviewed-on: https://chromium-review.googlesource.com/1201513 Commit-Queue: Kyoko Muto <kymuto@google.com> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#592785}
-
Anders Hartvoll Ruud authored
In the near future, it will be necessary for ValueForCustomProperty to return a CSSVariableData which may not be stored elsewhere. This is because we need to do a "non-destructive" pre-resolve of registered custom properties that are used before high priority properties are applied. R=futhark@chromium.org Bug: 641877 Change-Id: Idb1ab4ba7aae77187a4fd86877a0246e56fc82a4 Reviewed-on: https://chromium-review.googlesource.com/1235936Reviewed-by:
-
Dave Tapuska authored
Using the appropriate type gets rid of a checked cast and a truncation. BUG=879657 Change-Id: I30e6aa1f28ebcd6e245a95a8662a212e72986829 Reviewed-on: https://chromium-review.googlesource.com/1234016 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#592783}
-
Justin Cohen authored
Bug: 807330 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I988192d63f2189524b86c5ccd40f64fe42aebf40 Reviewed-on: https://chromium-review.googlesource.com/1228515 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#592782}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ecfe498c1a1a..a6fb5c9cdd1b Created with: gclient setdep -r src-internal@a6fb5c9cdd1b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic06aaab2918f506b88ea657707e4b4b3cc8c84f9 Reviewed-on: https://chromium-review.googlesource.com/1235840Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592781}
-
Stephane Zermatten authored
This change reads the original intent, looks for parameters that are meant for Autofill Assistant and allow scripts to check these in preconditions. Bug: 806868 Change-Id: I8bd6b51cf281d1f21ce2ccf6128b7345290cab0a Reviewed-on: https://chromium-review.googlesource.com/1225696 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#592780}
-
Gemene Narcis authored
This CL allows cleaning of blacklisted duplicates for iOS platform. Bug: 862930 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I44e9fb90181781c261760ac0d933f8917b7d2910 Reviewed-on: https://chromium-review.googlesource.com/1233234Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Narcis Gemene <gemene@google.com> Cr-Commit-Position: refs/heads/master@{#592779}
-
Nico Weber authored
This reverts commit f6a8902e. Reason for revert: relanding with lto for android disabled until things are sorted out. Original change's description: > Revert "Roll clang 340925:342523." > > This reverts commit 34893e97. > > Reason for revert: New failures on Android in computeKnownBits(), looks like an LTO problem. http://crbug.com/887272 > > Original change's description: > > Roll clang 340925:342523. > > > > Ran `tools/clang/scripts/upload_revision.py 342523`. > > > > Bug: 880827 > > Change-Id: I8f747ab4a2de74a0f0b4b5a201d37e111f323077 > > Reviewed-on: https://chromium-review.googlesource.com/1232590 > > Reviewed-by: Reid Kleckner <rnk@chromium.org> > > Commit-Queue: Nico Weber <thakis@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#592531} > > TBR=thakis@chromium.org,hans@chromium.org,rnk@chromium.org > > Change-Id: Idee414178ab15058aa080f670585cee81e0f8ac5 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 880827 > Reviewed-on: https://chromium-review.googlesource.com/1236003 > Reviewed-by: Egor Pasko <pasko@chromium.org> > Commit-Queue: Egor Pasko <pasko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592765} TBR=pasko@chromium.org,thakis@chromium.org,hans@chromium.org,rnk@chromium.org Change-Id: I26ea97e83cfebcec0670e79683fe0db7f993c1a7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 880827 Reviewed-on: https://chromium-review.googlesource.com/1236174 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#592778}
-
Yuki Awano authored
- Touch events come in screen pixel. We need to use in screen pixel conversion here as the comment in the file says. that touch exploration works correctly on the touch controller. Bug: 887222 Test: Enable spoken feedback on touch controller of CfM unit. Confirm Change-Id: Ic7a83eb5d9c4690b41a184ab85d5421e0468934e Reviewed-on: https://chromium-review.googlesource.com/1235489 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#592777}
-
Charles Zhao authored
Both tests fail because the proto serialization is not deterministic. Change-Id: I3b99faa03c55b3333c1d03e05258985e6f8ddaa5 Bug: 884140 Change-Id: I3b99faa03c55b3333c1d03e05258985e6f8ddaa5 Reviewed-on: https://chromium-review.googlesource.com/1233096 Commit-Queue: Charles . <charleszhao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#592776}
-
Mikel Astiz authored
This is a mitigation to what are believed to be bugs in the bridges, which may forget to appropriately report local deletions to the processor, leading to orphan sync metadata. We have recently instrumented a UMA metric ("Sync.ModelTypeOrphanMetadata") to assess the severity of the issue, and the collected data suggests that the problem is not specific to a single datatype. While we investigate each bridge individually, a reasonable workaround is to let the processor remove the orphaned metadata and untrack the entity. Bugs in the bridges should still be surfaced by the aforementioned UMA metric, although absolute numbers should tend to be smaller after this patch, because issues will get fixed after emitting the metric once. Bug: 875671,871733 Change-Id: Ieb06692f46739d73ce6f04115c25e14198ade1dd Reviewed-on: https://chromium-review.googlesource.com/1233676 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#592775}
-
Mohamed Amir Yosef authored
This CL adds the functionality to store the ids of lazy subscriptions in SharedPeferences. Later CL will consume this information to decide whether the FCM message should be deferred until there are visible activities or not. Bug: 882887 Change-Id: Ic28dbfeb2b77020cd9b5e02b79f055e477d55aed Reviewed-on: https://chromium-review.googlesource.com/1221532Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#592774}
-
Matthew Cary authored
android_build_tools/art was recently added, and pulls in several binaries that should be ignored by git. TBR: agrieve@chromium.org Change-Id: I2fb97c175707225237acbee80f4c01cdb0cdad44 Reviewed-on: https://chromium-review.googlesource.com/1235726Reviewed-by:
Matthew Cary <mattcary@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#592773}
-
Mathias Carlen authored
R=gogerald@chromium.org Bug: 806868 Change-Id: I7515c9fb448b9324b81dec958e0c212192741188 Reviewed-on: https://chromium-review.googlesource.com/1228059 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
-
Jan Krcal authored
This CL makes a cleanup in autofill sync unit-test, reducing code duplication and getting rid of custom fakes that can be mocked in one line. It also renames another existing fake to achieve more consistency in naming (w.r.t. gmock). This CL precedes a change in the AutofillWebDataBackend interface, making it easier to implement. Bug: 853688 Change-Id: Iaf9ec6151caa77e9b81297f50c061835443cfadd Reviewed-on: https://chromium-review.googlesource.com/1235716Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#592771}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1b8671f08f41..ecfe498c1a1a Created with: gclient setdep -r src-internal@ecfe498c1a1a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8bb96b3b8e967bfc07accec533508d1478486a7e Reviewed-on: https://chromium-review.googlesource.com/1235839Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ee002e61857b..207cfdfbd889 git log ee002e61857b..207cfdfbd889 --date=short --no-merges --format='%ad %ae %s' 2018-09-20 artit@webrtc.org Added support of getting coverage on mac Created with: gclient setdep -r src/third_party/webrtc@207cfdfbd889 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:844647 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I392429d4014348877087de19a4812632cbad9f38 Reviewed-on: https://chromium-review.googlesource.com/1235837Reviewed-by:
-
Thomas Tangl authored
Apparently creating a new image out of a bitmap leads to crashes in |Image::ToImageSkia|. This CL removes the conversion between images inside PrepareAvatarImage() to speculatively fix the issue. See bug report for details. Bug: 882330 Change-Id: Ifd7df91f5933ce0159ce223bf61fd9dcfac9356d Reviewed-on: https://chromium-review.googlesource.com/1228194 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8495ffe55979..985f6fe58181 git log 8495ffe55979..985f6fe58181 --date=short --no-merges --format='%ad %ae %s' 2018-09-20 anthonyalridge@google.com Handle inputs with zero range for plots. Created with: gclient setdep -r src/third_party/catapult@985f6fe58181 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:866423 TBR=sullivan@chromium.org Change-Id: I80ec2cd27533b784f212a413532c4a7ee39e820f Reviewed-on: https://chromium-review.googlesource.com/1235838Reviewed-by:
-
Stuart Langley authored
This will always append the "supportsTeamDrives=true" parameters to drive query strings, so lots of mechanical test related changes to update the expected query string. Change-Id: Ic98c558f74195dc27550af5a06aab78fdb413e57 Reviewed-on: https://chromium-review.googlesource.com/1235454Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#592766}
-
Egor Pasko authored
This reverts commit 34893e97. Reason for revert: New failures on Android in computeKnownBits(), looks like an LTO problem. http://crbug.com/887272 Original change's description: > Roll clang 340925:342523. > > Ran `tools/clang/scripts/upload_revision.py 342523`. > > Bug: 880827 > Change-Id: I8f747ab4a2de74a0f0b4b5a201d37e111f323077 > Reviewed-on: https://chromium-review.googlesource.com/1232590 > Reviewed-by: Reid Kleckner <rnk@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592531} TBR=thakis@chromium.org,hans@chromium.org,rnk@chromium.org Change-Id: Idee414178ab15058aa080f670585cee81e0f8ac5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 880827 Reviewed-on: https://chromium-review.googlesource.com/1236003Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#592765}
-
Florian Mayer authored
Change-Id: I764fcf0f349d5c78f8029408530f783ae9301b76 Reviewed-on: https://chromium-review.googlesource.com/1235934 Commit-Queue: Primiano Tucci <primiano@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#592764}
-
Balazs Engedy authored
Bug: 885165 Change-Id: I207457e481ef89ffcf0d91ee530cea2d3c33649a Reviewed-on: https://chromium-review.googlesource.com/1230675 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
This CL removes the TabHistory popup code as it was only used pre-UI Refresh. Bug: 800266 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I140bbed84ef69efb81c67130186ec72cca684961 Reviewed-on: https://chromium-review.googlesource.com/1233853 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#592762}
-
Marc Treib authored
This moves a bunch of helper functions around secondary account support from single_client_secondary_account_sync_test.cc into their own files. This is in preparation for adding more integration tests that will make use of these. Bug: 885211 Change-Id: I1f30b2425951933f6f9251f35c4aafb7e1cdb663 Reviewed-on: https://chromium-review.googlesource.com/1233704Reviewed-by:
-
Jdragon authored
This change fix settings css to access expand and delete icons. As a Result, cookies with long names can be deleted. Bug: 871639 Change-Id: Ic3c090d8593ea78b61be656a316b49e240fe6b42 Reviewed-on: https://chromium-review.googlesource.com/1202362 Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#592760}
-
Xi Cheng authored
This makes NotificationTemplateBuilder own a WeakPtr rather than a raw pointer to NotificationImageRetainer, which helps with tracking potential memory issues. Bug: 884224 Change-Id: I229ffd187ccd9b424987ab1473b240f898c06023 Reviewed-on: https://chromium-review.googlesource.com/1227717Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#592759}
-
Xi Cheng authored
This CL also cleans up the headers. Bug: 886957 Change-Id: I0d63484a7b2e96be64bc9e83f9350ca4ad7ffe41 Reviewed-on: https://chromium-review.googlesource.com/1234266Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
-
Xi Cheng authored
Bug: 886957 Change-Id: I734a8858b2538aaf6b146ce6c209ab4718ff278c Reviewed-on: https://chromium-review.googlesource.com/1235132Reviewed-by:
-
Yuki Shiino authored
This is a follow-up of https://crrev.com/c/1226893 and moves eventlistener-with-remote-context.html to WPT. The test content is conceptually the same. Bug: 883643, 886588 Change-Id: I7c941e162a076d9cbb7abc1d259ff98742a14517 Reviewed-on: https://chromium-review.googlesource.com/1235774Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#592756}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c3c2848bbfe9..1b8671f08f41 Created with: gclient setdep -r src-internal@1b8671f08f41 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I7081744ee44f57d8926933c3892d082b44e6d224 Reviewed-on: https://chromium-review.googlesource.com/1235835Reviewed-by:
-
Vaclav Brozek authored
https://crrev.com/c/1230064 added a comment pointing out the dependency between autofill::kDefaultPasswordLength and the autofill server code. However, the detail was mostly given in the CL commit message instead of the comment itself. This CL attempts to bring more of the information into the comment to spare going through "git blame" in the future. Bug: 846694 Change-Id: I0db135e31da59a5c6bacba7c2de602a7581166b5 Reviewed-on: https://chromium-review.googlesource.com/1235574Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#592754}
-
Keishi Hattori authored
We want to remove the distinction between DISALLOW_NEW and DISALLOW_NEW_EXCEPT_PLACEMENT_NEW by merging them together. Implementation wise this will be identical to the old DISALLOW_NEW_EXCEPT_PLACEMENT_NEW but we will rename it to DISALLOW_NEW as it is shorter. The new DISALLOW_NEW classes can be allocated on stack, as part objects, and inline in collection backings (i.e. everywhere except on-heap). Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7ec0d39d9dd991bf7157bd459bc659c5e011e229 Reviewed-on: https://chromium-review.googlesource.com/1212214 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#592753}
-
Matthew Cary authored
long_running:tools:gmail-foreground and long_running:tools:gmail-background fail consistently during orderfile profiling. Blacklisting them will let us run another benchmark instead. Bug: 758566 Change-Id: I504e522c5f7d809838bcefc8168eb3a284d4ed1a Reviewed-on: https://chromium-review.googlesource.com/1235713Reviewed-by:
-
Fan Yang authored
R=rch@chromium.org Change-Id: Ibbfe8b365f3c57b89e189150e8d579a633622e16 Reviewed-on: https://chromium-review.googlesource.com/1234230Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Fan Yang <fayang@chromium.org> Cr-Commit-Position: refs/heads/master@{#592751}
-
