GitLab

This is a mechanical execution of tools/git/mass-rename.py.

BUG=937018

Change-Id: Idf6f45d4507106e17137c577496e909b3aafc765
Reviewed-on: https://chromium-review.googlesource.com/c/1496234Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636662}

This CL moves web_feature.mojom in public/platform to
public/mojom/web_feature and updates paths for web_feature.mojom.

It also moves PRESUBMIT.py for web_feature.mojom to
public/mojom/web_feature.

Bug: 919393
Change-Id: I1d22645fdd081a81bf18a85511d208c2e7b0bf7a
Reviewed-on: https://chromium-review.googlesource.com/c/1488487
Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636661}

Remove FetchContext::DidLoadResource and move the operations in it
to DispatchDidFinishLoading and DispatchDidFail.

This leads to code duplication but I think this change is overall a
good change because:
 - DidLoadResource is called only twice. Repeating yourself twice is
   not that bad.
 - DidLoadResource is confusing; Whether that precedes or succeeds
   DispatchDidFinishLoading, whether it should be called in
   DispatchDidFail, etc.

Previously FetchContext::DispatchDidFinishLoading and DispatchDidFail
were called before Resource::Finish, but now they are called after
Resource::Finish. That affected a few devtools tests because some tests
finished as soon as resource loading finishes and some error messages
got missing with the new semantics. This CL delays test completion a
bit in order to keep the expectations.

Bug: 914739
Change-Id: I5245dca240ebc7496d1de51909d458a6ed5a61d2
Reviewed-on: https://chromium-review.googlesource.com/c/1474887
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636660}

According to the plan to replace |const LocalFrame*| arguement with |const Document&|,
|ExecutionContext*|, or |DocumentLoader*| in UseCounter::Count(), this CL
replaces all uses of UseCounter::Count(const LocalFrame*) with
UseCounter::Count(const Document&) in frame directory.

Bug: 936187
Change-Id: I41f03b9908258881d4a1d932defb7e42e2deae9a
Reviewed-on: https://chromium-review.googlesource.com/c/1491060Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#636659}

Adds and removes strikes under the following conditions:
User closes LocalCardMigrationDialog: Add 3 strikes
User closes LocalCardMigrationBubble: Add 2 strikes
User adds new local card: Remove up to 2 strikes (keep strike count > 0)
User de-selected some local cards during migration: Add 3 strikes

And don't offer local card migration if strike limit has been reached.


Bug: 884817
Change-Id: I9853e2b5d1a1692fd47650aa6598f4d6df27a27c
Reviewed-on: https://chromium-review.googlesource.com/c/1474689Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Anne Lim <annelim@google.com>
Cr-Commit-Position: refs/heads/master@{#636658}

The Finch configs for the Quota Expansion experiment were updated to
use groups that better suited our experiment.  This change rectifies the
disconnect between the field trial testing config which is a prequisite
to moving an experiment into the beta channel.

Change-Id: I469ff653bac1a6634c762a7c49ac6e75bb7ce7ea
Reviewed-on: https://chromium-review.googlesource.com/c/1492672
Commit-Queue: Jarryd Goodman <jarrydg@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636657}

Bug: 	930708
Change-Id: I0848524c1d637bd83cf40ddf2ac0402033ee1d5c
Reviewed-on: https://chromium-review.googlesource.com/c/1484496
Commit-Queue: Yann Dago <ydago@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636656}

This CL updates DialogPresenterDelegate's
dialogPresenterDelegateIsPresenting property to follow delegate naming
guidelines.  Additionally, rather than storing this value as a property,
this CL updates the implementation to calculate on the fly whether BVC
or any of its children are modally presenting a UIViewController.

Bug: 893660
TEST: Follow repro steps in c#0 on crbug.com/893660
Change-Id: Id75e4e72bac6365d47caed11317c8a6a11a08dbc
Reviewed-on: https://chromium-review.googlesource.com/c/1492364
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636655}

Reland #2 Note:
{
  Previously (re-)landed:
  https://crrev.com/b37e23cbd52ba447ab89c6d18f4ea0ecdc3fa5c0
  Reverted:
  https://crrev.com/a9aa35a2fb904074cddb4e2d889217a899177721

  More leaky tests. Though we now resolve gesture callbacks at the end
  of the test, the callback may come in after the test.

  This re-land fixes the leaky tests by finishing the
  test only once the gesture is completed. Previously landed CL uploaded
  as PS1, fixed in PS2.

  NOTE TO SHERIFF:
  If this is causing issues on the leak bots, please ping me or disble
  the test rather than reverting, if possible.
}

This CL makes synthetic input - the kind used in web tests and
telemetry (e.g. gpuBenchmarking.scrollBy) - wait until a CompositorFrame
has been submitted by the renderer and displayed by the display
compositor before resolving the completion callback. This means client
code that wants to wait until any observable side-effects of this input
is visible to further input need only wait on the gesture's completion
callback.

To give a motivating example: suppose we wish to write a test that
scrolls an out-of-process iframe into view and clicks on a button in the
frame. The code might look something like this:

gpuBenchmarking.smoothScroll(1000, () => {
  gpuBenchmarking.tap(0, 0);
});

This code contains a race today. The callback for smoothScroll is
invoked as soon as the ScrollEnd is received in the renderer. However,
until a new compositor frame is submitted from the renderer, the tap
may occur against stale hit testing geometry. This is a major source of
flakiness in our tests.

This CL fixes the problem by forcing the renderer to perform a full
redraw at the end of each gesture. The redraw produces a compositor
frame and we invoke the callback once the compositor frame is displayed.
We do this by reusing the RequestPresentation mechanism in RenderWidget.
RequestPresentation required two modifications to work in web tests
which use a single thread proxy with no scheduler:

 - LayerTreeHost::Composite needs to check the forced redraw flag to
   determine whether we need to raster, otherwise it won't produce a
   frame
 - RequestPresentation must request a main frame since there's no
   scheduler to perform the commit, which is what SetNeedsForcedRedraw
   requests.

The timing change exposed an issue in the
overlay-play-button-tap-to-hide.html test so this CL also cleans that
test up to listen to the animation changes in media controls properly.

Finally, it's possible we may get input in a RenderWidget that's not
currently displayed. e.g. A click event sent via ChromeDriver causes a
TouchStart followed by a TouchEnd. The TouchStart causes a window.open
which opens and focuses a new tab. The TouchEnd then happens on the
background tab. In this case, we should resolve the callback rather than
waiting on a CompositorFrame that'll never come. See ChromeDriver test
testNetworkConnectionTypeIsAppliedToAllTabs for an example of this.


TBR=dtapuska@chromium.org,nzolghadr@chromium.org,samans@chromium.org,peter@chromium.org

Bug: 902446
Change-Id: I0f818168b3f36070f72369a072e7f5eac64eb77c
Reviewed-on: https://chromium-review.googlesource.com/c/1496244
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636654}

Logic for max size is now consistent with animation/dragging.
Animation correctly plays if drag does not end at exact size.

This is not a complete fix for extensions dragging.

Bug: 916209
Change-Id: Iccb0d11bbe540a16edec0720105d272e091cf43d
Reviewed-on: https://chromium-review.googlesource.com/c/1492049
Commit-Queue: Dana Fried <dfried@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636653}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a365aff3ed0b..fe5a160336aa


Created with:
  gclient setdep -r src-internal@fe5a160336aa

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I2487c44442221abbe2e4e57a4aeade55f71e8bf8
Reviewed-on: https://chromium-review.googlesource.com/c/1495960Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#636652}

Prior to macOS 10.13.2, the only way to check for TouchID was to check
for the ability to evaluate the LAPolicyDeviceOwnerAuthenticationWithBiometrics
policy. 10.13.2 introduced a more granular check for LABiometryTypeTouchID.

This PR ensures on systems after macOS 10.13.2 that we check for this specific
biometry, and fall back to to the old check if we do not have access to this new enum.

R=martinkr@google.com

Bug: N/A
Change-Id: I3a3d2d332547b09cf3c6e062709ed06b6e1a052d
Reviewed-on: https://chromium-review.googlesource.com/c/1487811Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#636651}

Per UX request, increasing the dropdown min-width.

Bug: 936914
Change-Id: I7a8f12ad9489337d65d369502ce0bb0bdedfcf7c
Reviewed-on: https://chromium-review.googlesource.com/c/1495040
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636650}

Screenshots: https://imgur.com/a/juHC3Fz

R=dpapad@chromium.org
BUG=936977

Change-Id: Ibef2af96df3599b79d3c94e979f8039a2cea42f0
Reviewed-on: https://chromium-review.googlesource.com/c/1496295
Commit-Queue: Dan Beam <dbeam@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Auto-Submit: Dan Beam <dbeam@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636649}

Adds a crash key so we can identify oom intervention related crashes.

Bug: None
Change-Id: I96722ec0af4362aa42536d119f92c06084cd9012
Reviewed-on: https://chromium-review.googlesource.com/c/1484396
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuzu Saijo <yuzus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636648}

Using wpt-import in Chromium 932fdb31.
With Chromium commits locally applied on WPT:
68d5240e "[ChromeDriver] Set key modifiers with mouse actions"
a6d9cfda "[WPT] Changes to generated files by CL 1476144"
4665f96b "RestrictDeviceSensorEventsToSecureContexts by default."
03505df6 "[Origin Policy] Implement error reporting via Reporting API"
2c455f7b "Move outputContext from XRSession to XRRenderState"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
rego@igalia.com:
  external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests

NOAUTOREVERT=true
TBR=lukebjerring

No-Export: true
Change-Id: I4657b21944de6dfc1a0f35c8aa408e0dc4684260
Reviewed-on: https://chromium-review.googlesource.com/c/1495746Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#636647}

BUG=930203
TEST=passes cq
TBR=tguilbert

Change-Id: I05eae1e344cbeabc48b12aca6cac64b2ea87c9e5
Reviewed-on: https://chromium-review.googlesource.com/c/1493161Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636646}

NetworkPortalDetectorImpl uses a raw pointer to the
SystemNetworkContextManager's URLLoaderFactory, which will be invalid
if mojo pipe runs into any issues. This CL makes it use a
SahredURLLoaderFactory instead, which will handle failures
automatically.

Bug: 936625
Change-Id: I2ea71ef6cc46440f66349729e16cc2558ef145b1
Reviewed-on: https://chromium-review.googlesource.com/c/1495748Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636645}

This is a temporary solution until we implement a Fuchsia version of
CastSysInfo. The only downside to using the dummy is that the strings,
such as serial number, model, build, etc are all faked out.

Bug: internal b/126768956
Test: CQ
Change-Id: I3364d87c57d7f40dbe2d1e80b19bb2f02532512b
Reviewed-on: https://chromium-review.googlesource.com/c/1496419Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Auto-Submit: Aidan Wolter <awolter@chromium.org>
Commit-Queue: Aidan Wolter <awolter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636644}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/00b1f1e2a50e..14a41b316425


git log 00b1f1e2a50e..14a41b316425 --date=short --no-merges --format='%ad %ae %s'
2019-02-28 dgarrett@google.com cbuildbot_launch: Wipe out the paygen subdir every build.


Created with:
  gclient setdep -r src/third_party/chromite@14a41b316425

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@chromium.org

Change-Id: I3d5e22db1376cf1b09627f757bc322a4137b6b79
Reviewed-on: https://chromium-review.googlesource.com/c/1495959Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#636643}

For pre-CompositeAfterPaint, we let subpixel accumulation propagate
through isolation to keep consistent with legacy compositing code.

For ComposteAfterPaint, we discard subpixel accumulation at
isolation.

Change-Id: Id9460dbb3c7c89931c38119e75f044b9079f3de8
Reviewed-on: https://chromium-review.googlesource.com/c/1488020Reviewed-by: vmpstr <vmpstr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636642}

- unsigned short / unsigned -> uint16_t.
- USHRT_MAX -> std::numeric_limits<uint16_t>::max()
- Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types

Bug: 929986
Change-Id: If80935d74042f4f8e50275d0ec17832e19ae7046
Reviewed-on: https://chromium-review.googlesource.com/c/1490367
Commit-Queue: Miyoung Shin <myid.shin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636641}

The dimming layer is a extra fullscreen quad that we do not need to
draw. Remove it and dim the wallpaper instead.

Does a minor refactoring and moves some code from wallpaper view to
wallpaper controller to watch overview/tablet changes. Exposes wallpaper
view so we can schedule paints outside. Also fixes a bug with the
wallpaper preview being dimmed in tablet mode.

Next we should be removing the whole shield widget.

Test: manual
Bug: 774690, 917902
Change-Id: I303762e3180de9f82f1d0b1398305f7c7f9e0837
Reviewed-on: https://chromium-review.googlesource.com/c/1481899Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636640}

https://chromium.googlesource.com/angle/angle.git/+log/5de69e91bd93..5546fb4fdd85


git log 5de69e91bd93..5546fb4fdd85 --date=short --no-merges --format='%ad %ae %s'
2019-02-28 tobine@google.com Vulkan:Adding custom pool allocator
2019-02-28 shrekshao@google.com Use string literal style for shader string in WebGLCompatibilityTest
2019-02-28 shrekshao@google.com add ext_float_blend feature and test
2019-02-28 ynovikov@chromium.org Require VK_EXT_queue_family_foreign for EGL_ANDROID_image_native_buffer support


Created with:
  gclient setdep -r src/third_party/angle@5546fb4fdd85

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:None,chromium:930993,chromium:857138
TBR=ynovikov@chromium.org

Change-Id: I84a19167fd94228ccf5aaa4b32ff738ee59c6219
Reviewed-on: https://chromium-review.googlesource.com/c/1496374Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#636639}

Add setTabletModeEnabled() private Autotest JS API.

It is needed for certain ChromeOS tests that need to switch/to
TabletMode without restarting Chrome. And using dbus PowerManager signal
is not reliable.

misc: added missing #include<> in tablet_mode_controller.cc reported by
      git cl lint

TEST=Tested with browser_test'test that is included in this CL.
     Manually tested on DUT by calling JS API manually.
BUG=chromium:931767

Change-Id: I25e888cba38c08188ec21475d3530ad3090bbcd3
Reviewed-on: https://chromium-review.googlesource.com/c/1470937
Commit-Queue: Ricardo Quesada <ricardoq@chromium.org>
Auto-Submit: Ricardo Quesada <ricardoq@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Mitsuru Oshima (OOO til 3/4) <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636638}

R=drubery

Bug: 933065
Change-Id: If5b7c41875f36f53c217607c2270688c4af3cad9
Reviewed-on: https://chromium-review.googlesource.com/c/1496298
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Nathan Parker <nparker@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Nathan Parker <nparker@chromium.org>
Auto-Submit: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636637}

It's always InlineType::kBlock.

Bug: 934651
Change-Id: I12090136c066387c004e09de63d0286daac12f9f
Reviewed-on: https://chromium-review.googlesource.com/c/1485126
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636636}

It is only used with mus. This also makes the class name match the file
name.

Also fix the build file so it only compiles when mus is enabled.

TBR=msw@chromium.org

Bug: none
Change-Id: I93dbc1a14051208bb0d5964fe68ec4d22201d2ce
Reviewed-on: https://chromium-review.googlesource.com/c/1495812Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Auto-Submit: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636635}

Since M59, this URL simply forwards to chrome://extensions. This CL
removes the redirect.

reached" page.

Bug: None
Test: Visit chrome://extensions-frame, should see "This site can’t be
Change-Id: Iff52fdf5cfbd6e945b1565945f786e77591edfce
Reviewed-on: https://chromium-review.googlesource.com/c/1495864Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636634}

The |kTopViewInset| window property can change during overview.
Particularly, the Settings window behaves that way if overview starts
during transition to tablet mode as another window carries over from
clamshell snapped state to tablet split view. Now, when the
|kTopViewInset| window property changes, consistent with existing
behavior for bounds changes, the visual appearance of overview shall
generally be corrected at the expense of interrupting animation effects.
The one exception is if the |kTopViewInset| window property changes
while overview is being prepared. In this case, still consistent with
existing behavior for bounds changes, nothing shall be done, because
when the overview preparation has been completed, overview will look
right anyway.

Test: ash_unittests OverviewSessionTest.TopViewInsetChangeDuringOverview
Bug: 932816
Change-Id: I482d5ce5c24ff40ccc28e898ae3668f6831b71bd
Reviewed-on: https://chromium-review.googlesource.com/c/1495444
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636633}

Information about the HID report descriptor, including a hierarchical
representation of the described collections and reports, will be made
available through the WebHID API. This CL adds information about input,
output, and feature reports contained within a collection, as well as a
list of the children of the collection.

BUG=890096

Change-Id: I7d40fef222baf9456dda0920ee88550ca02ff41f
Reviewed-on: https://chromium-review.googlesource.com/c/1381263
Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636632}

# Dependency already existed, this is just a mechanical code relocation.
TBR=vakh@chromium.org

Bug: 933884
Change-Id: Iea4dad10d14698a681a5e90038313d1c3fe1683e
Reviewed-on: https://chromium-review.googlesource.com/c/1491908Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636631}

Bug: 905419
Change-Id: I8b1980ff1ea6fdce686f9fd7de71058efc1ec6a0
Reviewed-on: https://chromium-review.googlesource.com/c/1490406
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Auto-Submit: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636630}

This CL implements TabGroupModelFilter, but it's not used in anywhere
yet.

Bug: 934557
Change-Id: I3f25fc913aa9f76aa8b5f393c6c59b6e082681a3
Reviewed-on: https://chromium-review.googlesource.com/c/1480721Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636629}

Histograms are extended to M90, since it will be useful to track request
latency and feature utilization over a long timeframe. Also picked a
milestone whose feature freeze avoids holidays.

Bug: 930908, 930909, 930913, 930921
Change-Id: I5caecf78a64fead656f1b059a841eafa68f99764
Reviewed-on: https://chromium-review.googlesource.com/c/1490435Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Ramya Nagarajan <ramyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636628}

https://i.imgur.com/BAXJzRC.png

Bug: 924176
Change-Id: I4328752370dafa3c00d178b0b28a3320e26b071d
Reviewed-on: https://chromium-review.googlesource.com/c/1490053
Commit-Queue: John Lee <johntlee@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636627}

These functions receive parameters of type long, and those were not being checked
in case they were receiving infinity or other not-long values.
Added EnforceRange in the idl to ensure those functions are receiving valid longs.
Removing the expected on the WPT tests to stop ignoring these failures.
Changing a fast test that was testing the original throw behavior.

Bug: 934841, 934839, 934837
Change-Id: Iaa95d3c5ed9ac545472ff72e9ef4b535d22cbedf
Reviewed-on: https://chromium-review.googlesource.com/c/1494798
Commit-Queue: Juanmi Huertas <juanmihd@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636626}

This saves 192 bytes [*] of stack space per in-flow layout recursion.

[*] Linux 64bit release.

Bug: 930637
Change-Id: Ib4531d031312d97023c5e14ef40b8f25684ae29c
Reviewed-on: https://chromium-review.googlesource.com/c/1489421Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636625}

AppCache will also need to share the same key used to pad CacheStorage.

This CL also updates the singleton key's implementation from
base::LazyInstance to base::NoDestructor.

Bug: 918293
Change-Id: I792d700a445dc1bfa408564401288e6bd56918b2
Reviewed-on: https://chromium-review.googlesource.com/c/1490951Reviewed-by: Ben Kelly <wanderview@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Staphany Park <staphany@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636624}

Bug: 936504
Change-Id: I98436eb82c64fe5b3b6ba1a9d39176317883026a
Reviewed-on: https://chromium-review.googlesource.com/c/1496239
Commit-Queue: Kevin Strohbehn <ginko@google.com>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Auto-Submit: Kevin Strohbehn <ginko@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636623}