- 31 Dec, 2020 24 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fb35201abbd0..2ec7d750992a 2020-12-30 penghuang@chromium.org Disable null backend on Android 2020-12-30 jdarpinian@chromium.org iOS sRGB mipmap generation is broken too If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1161513 Tbr: jonahr@google.com Change-Id: I7f7fa6d36cd9f0036c846d711fe3aa532690c5e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607719Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839844}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I75fd6c9f578bf5f30099b63250476de994ef573f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607713Reviewed-by:
-
Patti authored
Change-Id: Ie9af12d8acd48f0de80e621db4954651ff8e4d88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607249 Auto-Submit: Patti <patricialor@chromium.org> Reviewed-by:
Zain Afzal <zafzal@google.com> Commit-Queue: Zain Afzal <zafzal@google.com> Cr-Commit-Position: refs/heads/master@{#839842}
-
Bruce Dawson authored
The documentation for NOINLINE says to put it before the return type and this may be important for some compilers. If nothing else it is good for consistency. This change should have no behavioral effect. Change-Id: I5378d10232e9d79f8e76369e118cf917361e955e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606661 Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#839841}
-
Kuo Jen Wei authored
Fix tab navigation order in responsive layout for ensuring all icons can be traversed in clockwise order. Bug: b/175744785 Test: Manually with tab navigation and chromevox in ltr and rtl language. Change-Id: I74d1244fb74c43233fee831c565a4cf6dd018e03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602970 Commit-Queue: Inker Kuo <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Inker Kuo <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#839840}
-
Andrew Grieve authored
Chrome can have an extra one compared to Monochrome due to desugar_jdk_libs=true. Bug: 1162491 Change-Id: I955fbc2055ea196b3aa498ae954c8d43480b5f40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605648 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#839839}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1609351142-4bcda9a45834f5931e4d67a63f18aec167e5f993.profdata to chrome-mac-master-1609372329-7cb34e4f2695283de7eea6ef08cead60b8c4becd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iab785b144f8551f82fd35d56490b505f5671bd0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607717Reviewed-by:
-
David Munro authored
Bug: None Test: CQ Change-Id: I7e715de5931011d230a439d1afa878a3064b9f62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606872Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#839837}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/88ae79312726..a11f91974ca7 2020-12-31 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia1f6bff55b22668d221f4cf64a02e1197bba8d79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607865Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1609351142-315cd693e0e48f1df55c05a88c4395bf724b17db.profdata to chrome-win64-master-1609361865-c7c8c8a3ffa8f736876f78155e475b67d6d386be.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3ef3f51218709c1b5ba45db1114a2d49ab1bd7c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607711Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ia1258fce4440c8154e377d136367107b635ba4d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607550Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839834}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1609351142-dd1a26699eab924687a810625409dd4ac7df6d3b.profdata to chrome-linux-master-1609372329-6c57567941675f1c19fbc828c410a1ef4771ee52.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6f26e89d5ee089b17c3befd3717f8639a9b6b9b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607716Reviewed-by:
-
David Black authored
This CL enables holding space for guest mode but redirects service creation to be associated with the original (non-incognito) profile. Bug: 1161717 Change-Id: I8328f861e13fbdf863ff27463a23929eeb88f31a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606291 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#839832}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/11c7d845479b..ee38a0f82fc3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tluk@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: tluk@google.com Change-Id: Iaecf9ebc90769c6eab6dd5adca16449ec49800f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607804Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839831}
-
Toni Barzic authored
BUG=b:176112565 Change-Id: Ieda1931f76ace56e7696806d57f1ac4c7e5a068e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605280Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#839830}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ide9649f7a6376b22410edacbfafcde503a52d973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607784Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839829}
-
Adam Langley authored
AOA is a fallback for caBLEv2 but, currently, it appears in the transport selection dialog and in the drop-down menu. This change filters it out. BUG=1002262 Change-Id: I2009a3cd49638266307ff50b31700498f85e3454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587502Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#839828}
-
yiyix authored
Function TexImageHelperImageData assumes that the imagedata always has format uint8_t and color space srgb. This cl make it compatible with format uint8, uint16 and float32 and colorspace srgb, p3 and rec2020. Bug: 1115317 Change-Id: I515415eef901ce8e7e41fd4702f436f6749745a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599089 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#839827}
-
Tom Anderson authored
BUG=None R=sky Change-Id: I57b0d24ec4fbee446add3bf6eb888616efe6fd31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600437Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#839826}
-
Azeem Arshad authored
This CL fixes issue with PIN/PUK unlock dialogs where the number of retries remaining is shown incorrectly. This was caused by an explicit check that was carried over from an older error string where retry counts were not displayed prior to first API call. Bug: 1161265 Change-Id: I4983002b52f97bd39e2089a09b3da6715981ec49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605994Reviewed-by:
-
Peng Huang authored
The GPU hangs on vkDestroySwapchain() is because a Xserver bug after resuming from hibernate. When the bug happens, Xserver will never return any pixmaps which were sent to Xserver for presenting with the PresentIdleNotify event. But the Vulkan swapchian thread created by the MESA driver is blocking on xcb_wait_for_special_event() call. This call will not return until a PresentIdleNotify event is received. vkDestroySwapchainKHR() will join the swapchian thread. So it causes the hang. Workaround the problem by not calling vkDestroySwapchainKHR(), if the problem is detected. Bug: 1130495 Change-Id: Idbdb18614133c2a9c461c0174c15ee013ef84155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595839 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/938399865e72..fb35201abbd0 2020-12-30 jonahr@google.com GL: Expose NV_framebuffer_blit for ES2 contexts when available If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1157057 Tbr: jonahr@google.com Change-Id: I9c8708f64b7ef3de6994d4d0775956b594c19059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607067Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6d4577bc5208..b8aa5f2e2a1c 2020-12-30 egdaniel@google.com Fix vulkan compile for VK_NULL_HANDLE. 2020-12-30 brianosman@google.com Remove use of do-while loops from particle examples 2020-12-30 egdaniel@google.com Add support for manually loading vk resolve in msaa with extra subpass. 2020-12-30 johnstiles@google.com Implement scalar `refract` intrinsic in Metal. 2020-12-30 johnstiles@google.com Implement scalar `reflect` intrinsic in Metal. 2020-12-30 johnstiles@google.com Broaden intrinsic tests to cover more input types. 2020-12-30 egdaniel@google.com Pass in more explicit params to GrVkPipeline Create. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: djsollen@google.com Change-Id: Ia4bf21f8dd92b2ee1507ef7840487d07aec13db3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607705Reviewed-by:
-
Abigail Klein authored
Change-Id: Ia97c827d7a7f519917877402f6bd34164eb2edc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605355Reviewed-by:
Josiah Krutz <josiahk@google.com> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#839821}
-
- 30 Dec, 2020 16 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3b3a5d369325..88ae79312726 2020-12-30 michael.liao@microsoft.com [Applications]: Fixing CSS in Manifest view and Indexed DB Views If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1162027 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic5622b6c117caf59d3adfde009c711a3ee0a54f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607684Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1609329117-9938a84a48434b95d67019e9514046042b514404.profdata to chrome-win64-master-1609351142-315cd693e0e48f1df55c05a88c4395bf724b17db.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I8d82ad68146d476f49cae2757638419c0aaeda19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607578Reviewed-by:
-
Chris Cunningham authored
This defensive fix until MediaSession owners return from vacation. Reverting is challenging given the long string of CLs. GetMediaPlayerRemote(player_id) is crashing for failing to find the remote with that ID. The stack shows the call coming from MediaSessionController, which should have the same lifetime as its associated mojo::Remote<media::mojom::MediaPlayer>. So far, I have not found how those lifetimes are getting out of sync. Ownership looks like this (read -> as "owns", MWCO as MediaWebContentsObserver): MWCO -> MediaSessionControllersManager -> map<MediaPlayerId, MediaSessionController(s)> MWCO -> map<MediaPlayerId, mojo::Remote<media::mojom::MediaPlayer>> I've combed through all the places where MWCO removes from its map of MediaPlayer remotes, and looked for a failure to call MediaSessionControllersManger::OnEnd(Id) to remove the associated MediaSessionController. There are 3 cases where we remove from the map... 1. MediaWebContentsObserver::RenderFrameDeleted() 2. MediaWebContentsObserver::WebContentsDestroyed() 3. media_player_remotes_[player_id].set_disconnect_handler(base::BindOnce(... The only case where I don't see a call to MediaSessionControllersManager is #2. But that shouldn't matter since MWCO's destructor is called shortly (synchronously) after WebContentsDestroyed(). Its destructor will tear down the MediaSessionControllersManager. The defensive fix does not address the root lifetime issue. It is probably the case that the MediaSessionControllers are being leaked. Bug: 1161551, 1039252 Change-Id: I85337eae106d8b56b7d48fc9759702dc579855ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607579 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#839818}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f86cf4c2de2f..5d2bf19be865 2020-12-30 danilchap@webrtc.org Fix data race on destruction in Audio Video sync tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic82039e52ef6e7879581073225cccd861e432759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607704Reviewed-by:
-
Justin DeWitt authored
Tbr: bialpio@chromium.org Bug: 1153305 Change-Id: I20476991fdfa7c91328122b5f5be5402574fb00c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607402Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#839816}
-
Emily Stark authored
Simplified domain display was supposed to be disabled for non-https/https URLs. However, the code was previously using a parsing function that "hid" these schemes by actually parsing the inner URL when one of these schemes is in use. This CL fixes this by using Parse() instead of ParseForEmphasizeComponents(), and adds a test. Bug: 1147900 Change-Id: Id2535286768eb264c074ae90371f52aef3f6d01f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607669Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#839815}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3b39cefc6195..364205c70ed1 2020-12-30 ehmaldonado@google.com [depot_tools] Migrate metadata to DIR_METADATA. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: I58b7b026bf1b0aec080887a9765af9fc2ad292b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607646Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I9e0b0702e27d617c48b1ac664afa9490941852a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607581Reviewed-by:
-
Abigail Klein authored
Clears caption bubble text after the inactivity timeout. Also, prevents a final transcription received after the bubble has no activity from setting text. This fixes a bug where the bubble disappeared after inactivity, and then the speech service sent a final transcription after several seconds of no audio, which caused the bubble to reappear. Bug: 1055150 Change-Id: I3a0df495c73df0273e925847671f351b61afcd51 AX-Relnotes: N/A (feature not launched) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598622 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I2c3f99d21972a0196720753a8dcfa53e9a4aef86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607583Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I61fb15a4906ca7700cb3dde4e15babbd81575907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605879Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839810}
-
Curt Clemens authored
The contact visibility page was updating the visibility pref and making an api request to sync the allowed contacts list every time the controls on the page were pressed/toggled. This CL instead saves the page state once when the page closes. Fixed: 1131269 Change-Id: Iaf6e5138b029450df083179994cba7f67ee0f5c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606716 Commit-Queue: Curt Clemens <cclem@google.com> Reviewed-by:
-
Christopher Cameron authored
Add comments clarify the reason that the DrawQuadList is not cleared by the CALayer overlay processor (the RenderPassDrawQuads are sill referenced). Add a TODO for the place to add the underlay processor. Bug: 1152849 Change-Id: Iaf58b2c4ebbadf29c40ed76660069f9d0932a995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587949 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#839808}
-
Clark DuVall authored
This reverts commit c2bd53d8. Reason for revert: This seems to have caused the crash in crbug.com/1143321 to happen again. Original change's description: > Remove custom library resolver for feed libraries > > This was needed because the libraries were in the feed module, but have > now been moved to the base module. This will hopefully fix a crash > loading the libs on some devices. > > Bug: 1160654 > Change-Id: Ie33114d6f5963325c096dea9f60e029d7d40e19e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606187 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#839654} TBR=agrieve@chromium.org,cduvall@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I2f8353a58a6200c9a8ee5475c3b1798c5b4e0f22 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1160654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607672Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#839807}
-
Sky Malice authored
This change removes the default [re]seting of This change is needed because CCTs with policy CCTToSDialogEnabled skips the FRE. This flow doesn't accept the ToS, and doesn't overwrite to the PRIVACY_METRICS_REPORTING pref. But very early in the FRE startup/flow, this pref is blindly written with the default (true), and that value is persisted forward for the CCT skip, when really we want the value to be false. The theory here is that we didn't actually need to set this pref. It seems to have been initially written to seed the checkbox state, see https://crrev.com/978653002 , but that changed when the default flipped in https://crrev.com/2275513003 . See associated bug for more details. This change also removes the temporary hack added in https://crrev.com/c/2416885 to support CCTs that skip the ToS. Bug: 1128955 Change-Id: I9cbb9e3db2eeb9278519759b955c7976584c0e78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416932Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#839806}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I0fbca7753d75bc685b1dd5da33ebcc54590adbd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607582Reviewed-by:
-
