- 29 Jan, 2020 40 commits
-
-
Raphael Kubo da Costa authored
This should allow FindIt to set the right component when filing bugs for flaky tests, and setting WPT-NOTIFY to true in OWNERS also automatically files new bugs if a test starts failing after a WPT import. The code in blinkpy handling WPT-NOTIFY only parses a subset of the syntax of an OWNERS file that does not include file:// entries, so manually add a few people rather than pointing to content/browser/native_file_system/OWNERS. Change-Id: I539040bf18648981da0fd2c56ff4032633ac2349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027448 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#736485}
-
chrome://autofill-internals/Christoph Schwering authored
This commit adds checkboxes to filter the types of log events displayed in chrome://autofill-internals/, an auto-scrolling mechanism, and visual markers in order to aid with visually processing the logs. NOTRY=true To skip android-binary-size bot due to a bug (crbug.com/1045024). Other try-bots have passed. Change-Id: I64db7aa5055757ef80f1981a659be76d7fa37291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017354 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#736484}
-
Fabrice de Gans-Riberi authored
It is now necessary to parse the 'archive' entry from images.json, since some of the images listed are not built. Bug: fuchsia:44352 Change-Id: I849d389df4ef032acf724a9948ed3d975dae5f05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028115Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#736483}
-
Tricia Crichton authored
Python tests show increased flakiness caused by command timeouts after reducing the timeout to 10 seconds. Increasing to 30 seconds to reduce timeouts Bug: 1045241 Change-Id: I0f564f564155c294ac3e041518096b88a705f94c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028174Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#736482}
-
haozhe authored
The current code doesn't catch the case where non_interpolatable_value is null for the interpolation_list. This patch add a protection for this situation. Bug: 1039733 Change-Id: I442a56e4984285dfe524dcd669fae9f4da0a7f94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011167 Commit-Queue: Hao Sheng <haozhes@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#736481}
-
Charlie Reis authored
This is no longer necessary now that we track RenderFrameProxyHosts. This CL also cleans up many other references to "swapped out." Bug: 1015882 Change-Id: Ib5391d360460540945891232c5eca0701fce138f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022350 Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#736480}
-
Sadrul Habib Chowdhury authored
BUG=none R=xidachen@chromium.org Change-Id: I821d77ecb5c79405ddbbb2a020f5a90214fef3ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028113Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/99d6d8115b37..740ed473dcba git log 99d6d8115b37..740ed473dcba --date=short --first-parent --format='%ad %ae %s' 2020-01-29 jianj@google.com Add 444 support for vp9 decoder wrapper. 2020-01-29 mbonadei@webrtc.org Revert "Adds trial to use correct overhead calculation in pacer." Created with: gclient setdep -r src/third_party/webrtc@740ed473dcba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I7ab8a7c14ca2d5e478060c924d76ca6a77cf09d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028018Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736478}
-
jongdeok.kim authored
This CL makes not to perform heavyweight theme change on full screen mode on Windows. On full screen mode, HWNDMessageHandler does not try to update views by calling PerformDwmTransition(). Bug: 1002480 Change-Id: I8d40bd47dca0f1247cb77b4354ead4b9e44848a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016769 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#736477}
-
Tobias Sargeant authored
PlatformServiceBridge.java is compiled twice into two jars for internal builds, and combining the jars is smart enough to remove the duplicate, but cannot do the same for any inner classes. Therefore we must introduce an explicit adapter class to perform the same function. Bug: 1046782 Change-Id: I2a933ced5fa051271f42571eaffea8671a6fb094 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027810Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#736476}
-
Yi Gu authored
This test is flaky on Linux and Win as well: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyUwsSBUZsYWtlIkhjaHJvbWl1bUB1bml0X3Rlc3RzQFRvb2xiYXJBY3Rpb25WaWV3VW5pdFRlc3QuQmFzaWNUb29sYmFyQWN0aW9uVmlld1Rlc3QM TBR=rdevlin.cronin@chromium.org Bug: 1042220 Change-Id: Ia414f828e4f172c1e7cc03cb8fe8af034b172870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028119Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736475}
-
Yi Gu authored
This test is currently flaky on Mac: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyTwsSBUZsYWtlIkRjaHJvbWl1bUBibGlua193ZWJfdGVzdHNAZmFzdC9jYW52YXMvY2FudmFzLWZpbHRlci1vcmlnaW4tY2xlYW4uaHRtbAw TBR=fs@opera.com Bug: 1041846 Change-Id: I4940f68657c834d525b5a8f24ce7dbfa5ae9ee22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027904Reviewed-by:
-
James Cook authored
SplitSettingsSync will allow the user to opt-out of browser sync. However, IdentityManager::GetPrimaryAccount() assumes the user has consented to browser sync. Switch to using the "unconsented" primary account, which exists whether or not the user has consented to browser sync. See go/cros-primary-account for details. Bug: 1042400 Test: updated existing unit_tests Test: cancelling ARC setup in OS settings still works Change-Id: I39ecf4f800071e79624bd624bcdf5272e6ad448b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023988 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Josh Horwich <jhorwich@chromium.org> Cr-Commit-Position: refs/heads/master@{#736473}
-
Michael Thiessen authored
In order to migrate java.net.URI to GURL the junit tests that rely on java.net.URI need to be moved to a test apk that supports the native library. This change moves the StatusMediatorUnitTest unittests from junit to unit_tests (Android only). These tests should be just as fast as they were as junit tests (and much faster than chrome_test_apk unit tests). Bug: 783819 Change-Id: I1f19eb766c627e1fe44c15775957e20ed7a75c07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015348 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#736472}
-
David Van Cleve authored
This CL eases interacting with string-to-proto tables via sqlite_proto by adding a new TableManager override, ProtoTableManager, which handles table initialization for the string-to-proto case. Now, clients just need to construct and initialize one pair of KeyValueTable<T>/ KeyValueData<T> per table. Bug: 1036494 Change-Id: I4e512cd328f21faaecb57d0ef6c70f00355f6213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997659 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#736471}
-
Nick Harper authored
Change-Id: Ic43d1ab8d2b3905b1771ed922cb30040b50dbdb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023508 Auto-Submit: Nick Harper <nharper@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#736470}
-
Avi Drissman authored
* Assume building with a macOS SDK newer than 10.8 * Assume C++11 strong enums This is a partial reland of https://crrev.com/c/2025988. Cronet for iOS uses base/ and they still support 32-bit iOS versions. Bug: 1044838 Change-Id: I7c16dfc96228b847a66e4c47de210e147261d52b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028208 Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#736469}
-
Vasiliy Telezhnikov authored
SkiaRenderer used PostDelayTask on GPU thread to check for CopyOutputRequests are complete. It's incompatible with WebView. This CL adds SkiaOutputSurfaceDependency::ScheduleDelayedTaskOnGPU to support this behaviour. For Chrome it still posts PostDelayTask as before. For WebView it adds tasks to TaskQueueWebView. Bug: 805739 Change-Id: I676c2fe1cc47f591d4b341b8d3ce7d4519507743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019324Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#736468}
-
Yi Gu authored
This test started to be flaky on CrOS. See bug for details. TBR=apotapchuk@chromium.org Bug: 1043887 Change-Id: I40772f0336e301bae8febca3f65e686106b06da9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028117Reviewed-by:
-
Eugene But authored
Breakpad imposes the limit to Breadcrumbs string, so the number of uploaded events is limited. This CL removes logs which are less useful to allow including more events. Notable changes: - Remove "UserAction: " prefix as it does not make log more useful - Remove milliseconds from timestamp (take extra 3 digits per event) - Remove WillDetachWebStateAt event (having WebStateDetachedAt is sufficient) - Remove TitleWasSet event which happens for all pageloads Bug: 1046231 Change-Id: I264b78942d4ad31c6790006e97a325dc9e04c366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026167 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#736466}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/05e08edf70d5..09d51a575493 git log 05e08edf70d5..09d51a575493 --date=short --first-parent --format='%ad %ae %s' 2020-01-29 spang@chromium.org Fuchsia: Skip PointSpriteAlternatingDrawTypes on ARM Fuchsia 2020-01-29 shrekshao@google.com SH_CLAMP_INDIRECT_ARRAY_BOUNDS logic update 2020-01-29 syoussefi@chromium.org Vulkan: Cleanup glslang wrapper 2020-01-29 courtneygo@google.com Vulkan: Simplify format table generation 2020-01-29 syoussefi@chromium.org Vulkan: Set varying location & xfb decorations in SPIR-V Created with: gclient setdep -r src/third_party/angle@09d51a575493 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1042252 Tbr: tobine@google.com Change-Id: I836ba789fb4d9fea96fb3050d66025e854985fc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028349Reviewed-by:
-
Sophie Chang authored
Change-Id: I6906bf97ca2ce09b09af82e965fc41f69dc36e47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025832 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#736464}
-
Karthikeyan Ramasubramanian authored
When the system firmware update includes MRC training update it can cause the system to boot slower after the update is applied. Also the graphics module is not available to notify the user about the MRC training. So notify the user about slow reboot beforehand. Here are the screenshots of the user notification with and without a slow boot user notification. With slow boot user notification: https://screenshot.googleplex.com/w5GJ3VYpnbP Without slow boot user notification: https://screenshot.googleplex.com/pv28UdisnXS Bug: b/129056373 Change-Id: I3c70007688ad8f4ab727721a696edfbe06535f7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831005 Commit-Queue: Karthikeyan Ramasubramanian <kramasub@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#736463}
-
John Budorick authored
Ran into this while investigating android_browsertests failures on android-pie-x86-fyi-rel. A failing test w/ a TypeParam was being incorrectly parsed as UNKNOWN despite clearly failing. This CL fixes that case. Change-Id: Iad47e1620b2f0b98348097302ca39a8342e1a116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028252 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#736462}
-
Akihiro Ota authored
This change implements the IsStructure() method, which returns true if a node's role is a subclass of the Structure abstract role. Please see the aria spec for more details: https://www.w3.org/TR/wai-aria-1.1/#structure To keep the code clean and organized, this change also implements a few helper methods for a couple other aria abstract roles, such as Landmark and Select. Change-Id: If8ff7d6d59f217af85c9b1bd5e853b00b4052e33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023194 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#736461}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2ee95beaf33d..a74b12c57c26 Created with: gclient setdep -r src-internal@a74b12c57c26 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I99ec9bf056b5cb8839334fe4fd4ea7e1205509b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028347Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736460}
-
Bence Béky authored
Change-Id: Ib9672cd539310a9712a886fc45f51749021922d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028175 Auto-Submit: Bence Béky <bnc@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#736459}
-
Clark DuVall authored
This hardcodes the package IDs of dynamic attributes to 0x2 and throws an error in WebLayer if the package ID does not end up being 0x2. This should not affect WebView, since WebView does not depend on any dynamic attributes. The *_pb2.py files were generated from the Resources.proto and Configuration.proto files in the Android frameworks/base repo. Bug: 1045262 Change-Id: Ic04c150c5c8709f59f738a84068c0b738f0c4643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018493Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#736458}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d960cc31b658..8354717302ce git log d960cc31b658..8354717302ce --date=short --first-parent --format='%ad %ae %s' 2020-01-29 egdaniel@google.com Remove asTextureProxyRef from SkSpecialImage. 2020-01-29 reed@google.com extract font from run Created with: gclient setdep -r src/third_party/skia@8354717302ce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: I6d013d9bc257f66abe54c8ac0160d24338b07fd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028017Reviewed-by:
-
Koji Ishii authored
This reverts commit f2520c7f. Reason for revert: The failures are only on "refs/branch-heads/3945", not on master branch. See crbug.com/1039506#c11 Original change's description: > Disable two failing tests in NGInlineCursorTest > > Failing on android-arm64-stable-tests: > NGInlineCursorTest/NGInlineCursorTest.CulledInlineWithAtomicInline/1 > NGInlineCursorTest/NGInlineCursorTest.CulledInlineWithFloat/1 > > BUG=1046338 > NOTRY=true > TBR=chouinard@chromium.org,kojii@chromium.org > > Change-Id: Ic4c94abe09498302c813bb4d48a47a28cc6a3bd4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023494 > Commit-Queue: Tim Volodine <timvolodine@chromium.org> > Reviewed-by: Tim Volodine <timvolodine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735851} TBR=timvolodine@chromium.org,kojii@chromium.org,chouinard@chromium.org Change-Id: Icf33bdc9750c93701206666e346110fe7ca228e7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1046338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025748Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Darin Fisher authored
Three changes: 1- Avoid returning a raw pointer to chrome::mojom::PrerenderCanceler from GetPrerenderCanceller helper functions in favor returning a mojo::PendingRemote<chrome::mojom::PrerenderCanceler>. This avoids the need to schedule a DeleteSoon (in the renderer case) to cleanup the memory associated with that object later. 2- By returning a mojo::PendingRemote<..> instead of a raw pointer to the interface, it is no longer necessary to manually PostTask before accessing that interface. A mojo::PendingRemote<..> can instead be bound to a mojo::Remote<..> that implicitly schedules function calls on the right thread. The PostTask is implicit. 3- Make PrerenderContents support having multiple bound cancelers. This makes the above possible. In the renderer, the canceler is acquired immediately instead of lazily, and that is extra cost (an extra IPC) in the case where a canceler is not needed. This only happens for a page being prerendered, and so that overhead should be relatively small and seems worth the benefit of simple code. Change-Id: If43a1f6fa607f07eded8511639898ea99a023cd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023358 Commit-Queue: Darin Fisher <darin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#736455}
-
Garrett Beaty authored
This reduces repetition from having to declare the CIPD package in every module and simplifies refactoring to move builder functions to a common location. Change-Id: Iffae18ace2a58682d6fbe5b61ec12f7fdc0e5d86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025883 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#736454}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/717f1ef10178..82c1b418e2fb git log 717f1ef10178..82c1b418e2fb --date=short --first-parent --format='%ad %ae %s' 2020-01-29 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-01-29 almuthanna@chromium.org Add JSON Summary coverage report Created with: gclient setdep -r src/third_party/devtools-frontend/src@82c1b418e2fb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I02effec2855d4490f29ed893870f86fdcb24c2a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028016Reviewed-by:
-
Yi Gu authored
This test may crash on Windows. See bug for details. TBR=mmenke@chromium.org Bug: 1035127 Change-Id: I7d476c95a6e3463b5fe9a38707263d44f7e4922c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028049Reviewed-by:
-
Demetrios Papadopoulos authored
Specifically, adding #cr_define_end comments in all files that use cr.define() as required by the auto-generation tools. The BUILD.gn targets that actually make use of these special comments will be added in a follow up CL. Eventually these special comments/metadata will be removed, when the Polymer 3 version of Settings is actually checked-in (and no longer auto-generated). Bug: 1026426 Change-Id: I02ee25d71928a103d397c070854fde1a78ebd1c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999281Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#736451}
-
Chromium WPT Sync authored
Using wpt-import in Chromium df3250dd. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I900a0a0c44f84de9cb312e05f0f2269e771dbe32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028407Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736450}
-
Christopher Thompson authored
This is a reland of cb98eddd This fixes a crash caused by a call to GetStringFUTF16() with a format string that didn’t have placeholders. Original change's description: > Add legacy TLS interstitial warning > > This adds a new interstitial page for the legacy TLS warning. It > generally follows the SSL interstitial, but with different strings and > a different icon (the (i) info icon). > > The test interstitial is available at chrome://interstitials/legacy-tls > > Screenshot: https://drive.google.com/file/d/1MkWCqWKtQwo7k-ybYjKotYJDjTzRwcd0/view > > This also refactors the legacy TLS browsertest classes slightly, basing > them on SSLUITest rather than CertVerifierBrowserTest, brings in the > mock cert verifier explicitly. It also adds a SetPolicy() method to > SSLUITestBase (to complement the EnablePolicy() method, but for policies > that take base::Value types, in this case for the SSLVersionMin policy). > Overall, this makes for a slightly simpler class structure and lets us > reuse all of the infrastructure setup by SSLUITest (since > CertVerifierBrowserTest is fairly simple in comparison). > > The new cert error is introduced in https://crrev.com/c/1894616. Support > for the control site list will be added in https://crrev.com/c/1906779. > > Bug: 896013, 1039756 > Change-Id: Ic3242178239ac8c68d02fe0a2a21a52638146580 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940707 > Commit-Queue: Christopher Thompson <cthomp@chromium.org> > Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736197} Bug: 896013, 1039756, 1046696 Change-Id: I35df3efb3f5e7fcc44211a9497724cb5a68d7d91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027890 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Auto-Submit: Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#736449}
-
John Budorick authored
Also adds the sandbox_linux_unittests filter file to the bot as a follow-up to crrev.com/c/2020615. Bug: 1034001, 1045623 Change-Id: I13970aaca28fb4fd71868301d4a82748d6889fb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027896 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/db1cab866afd..cd8060e73e83 git log db1cab866afd..cd8060e73e83 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 linxinan@chromium.org chromite: add owners for api/gen/test_platform 2020-01-28 bpastene@chromium.org cros_chrome_sdk: Remove support for optionally enabling clang. 2020-01-28 pprabhu@chromium.org config: Set quota account for synchronous bvt suite 2020-01-28 vapier@chromium.org qemu: fix race when installing binaries 2020-01-28 cjmcdonald@chromium.org Make toolchain changes directly imply a full source build 2020-01-28 mmortensen@google.com Fix goma_artifacts output proto update for stats/counterz. 2020-01-28 lamontjones@chromium.org api: call toolchain.BundleArtifacts endpoints. 2020-01-28 lamontjones@chromium.org toolchain_util: BundleChromeClangWarningsFile. 2020-01-28 lamontjones@chromium.org chroot_lib: add chroot_path method. 2020-01-28 saklein@chromium.org workon_helper: Minor cleanup. Created with: gclient setdep -r src/third_party/chromite@cd8060e73e83 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: Ie2f969f8f6936e029331ff6e79e24653b95fa33b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028007Reviewed-by:
-
Josh Nohle authored
Bug: 951969, 936273 Change-Id: I59a980ee3f7af519b8916d0831c738c1ada84f98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988838 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#736446}
-
