GitLab

Review URL: http://codereview.chromium.org/8549019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112242 0039d316-1c4b-4281-b951-d872f2087c98

BUG=97845
TEST=none


Review URL: http://codereview.chromium.org/8682029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112241 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=./generator.py --wnone --cgen --range=start,end  --out private/ppb_flash_fullscreen.idl


Review URL: http://codereview.chromium.org/8735013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112239 0039d316-1c4b-4281-b951-d872f2087c98

BUG=103351

Review URL: http://codereview.chromium.org/8750002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112238 0039d316-1c4b-4281-b951-d872f2087c98

My version of MSVC 2008 has a bug in ADL that prevents it from finding the
operators in the global namespace if the class in question is nested.  This
meant I was unable to compile the BrowsingDataQuotaHelperTest.FetchData test
because it tried to use std::set<QuotaInfo>.  Moving the operators into the
class itself solves the problem, and should work properly with all other
compilers as well.

TEST=BrowsingDataQuotaHelperTest
R=tzik@chromium.org

Review URL: http://codereview.chromium.org/8735001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112237 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105443
TEST=None


Review URL: http://codereview.chromium.org/8700013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112236 0039d316-1c4b-4281-b951-d872f2087c98

Alt-L (print layer tree)

Added name in RenderWidgetHostViewAura

Made Window::SetName update the layer name.

Review URL: http://codereview.chromium.org/8585007

TBR=pkotwicz@chromium.org
Review URL: http://codereview.chromium.org/8741018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112234 0039d316-1c4b-4281-b951-d872f2087c98

Change the way we are sending audio data to driver when using WaveOut API.
Before, we were "feeding" the driver in the callback when OS returned audio
buffer to us. MSDN disallows that, but We were avoiding deadlock when stopping
the stream by using some clever tricks. Unfortunately, exactly the same
deadlock happens when Windows were draining audio stream when switching
the device, and our tricks did not help, as we were not controlling exact timing.

Fix is to separate receiving freed buffer and "feeding" audio driver. Now we are
using CALLBACK_EVENT wave out mode in which Windows signal event when buffer runs
out of data, and using RegisterWaitForSingleObject() so our callback is called by
one of thread pool threads.

Stopping of playback became slower because now it is synchronous. If that ever
become a problem we can use singleton that keeps track of the playing audio
streams, than stopping can become instaneous, at a cost of more complex checks
in the callback.

Unfortunately, no automatic test, as there is no documented way to programmatically
switch default audio device on Windows. People were able to figure it out (see
http://www.daveamenta.com/2011-05/programmatically-or-command-line-change-the-default-sound-playback-device-in-windows-7/),
but there is no guarantee it will continue to work in Win8, or even in next Service Pack
for Win7.

BUG=41036

TEST=Play any HTML5 audio/video on Windows and change default audio device
TEST=using "Control Panel | Sound". There should be no hang, you should hear
TEST=audio from the newly chosen device.

Review URL: http://codereview.chromium.org/8591028

TBR=enal@chromium.org
Review URL: http://codereview.chromium.org/8753001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112233 0039d316-1c4b-4281-b951-d872f2087c98

Alt-L (print layer tree)

Added name in RenderWidgetHostViewAura

Made Window::SetName update the layer name.

Review URL: http://codereview.chromium.org/8585007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112232 0039d316-1c4b-4281-b951-d872f2087c98

This is follow-up from review http://codereview.chromium.org/8486020.
This eliminates down-cast of GLSurface in CLContextNSView::Initialize in favor of
GLSurfaceNSView::OnMakeCurrent implementation.  Also, allows offscreen path in USE_AURA
due to its usage in SharedResourcesCC.

BUG=104390
TEST=compositor_unittests --gtest_filter=LayerWithRealCompositorTest.*
R=apatrick@chromium.org

Review URL: http://codereview.chromium.org/8687016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112231 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bruening
Review URL: http://codereview.chromium.org/8748011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112230 0039d316-1c4b-4281-b951-d872f2087c98

Also remove and clean-up the remaining vestiges of NTP3 support (they were left n the code just for touch_ntp which was built against them).

BUG=105046
TEST=NTP4WebUITest.TestBrowsePages

Review URL: http://codereview.chromium.org/8689013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112229 0039d316-1c4b-4281-b951-d872f2087c98

BUG=63671
TBR=aa@chromium.org

Review URL: http://codereview.chromium.org/8747017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112228 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112227 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105667
TBR=atwilson@chromium.org

Review URL: http://codereview.chromium.org/8752001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112226 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8520009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112225 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:22841
TEST=


Review URL: http://codereview.chromium.org/8748006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112224 0039d316-1c4b-4281-b951-d872f2087c98

Probably should have just fixed the problem given the number of bad ones.

BUG=105864
TBR=sail@chromium.org
TEST=waterfall.sh match

Review URL: http://codereview.chromium.org/8742017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112223 0039d316-1c4b-4281-b951-d872f2087c98

The scores across different versions of the V8 benchmark are NOT comparable. So
this will change the raw score number and expectations will need to be reset.

BUG=None
TEST=out/Debug/performance_ui_tests --gtest_filter=V8BenchmarkTest.Perf --run-v8-benchmark
TBR=cmp

Review URL: http://codereview.chromium.org/8749001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112219 0039d316-1c4b-4281-b951-d872f2087c98

Most of keyboard layouts are not yet supported for the configuration.

BUG=chromium-os:23067
TEST=ran try


Review URL: http://codereview.chromium.org/8744009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112216 0039d316-1c4b-4281-b951-d872f2087c98

Also removed obsolete files to minimize security audit efforts.

BUG=chromium-os:23502
TEST=


Review URL: http://codereview.chromium.org/8727028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112215 0039d316-1c4b-4281-b951-d872f2087c98

We currently use client login to download GAIA info. Unfortunately the client login token expires after 24 hours.

To fix this we now use a OAuth2 refresh token to create a new access token each time we download GAIA info.

BUG=91241
TEST=


Review URL: http://codereview.chromium.org/8746002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112214 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:21994
TEST=Open a photo, click on Edit, click on Brightness, press Enter. The editor should continue to work normally.


Review URL: http://codereview.chromium.org/8747008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112210 0039d316-1c4b-4281-b951-d872f2087c98

Don't include "base/gtest_prod_util.h". It defines one macro and that is not used here. Include the needed testing header in two places instead.

BUG=105855


Review URL: http://codereview.chromium.org/8555003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112209 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104039
R=ben@chromium.org

Review URL: http://codereview.chromium.org/8735009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112208 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:23458
TEST=manual


Review URL: http://codereview.chromium.org/8746012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112207 0039d316-1c4b-4281-b951-d872f2087c98

Better handling for less common situations when there is no EXIF section
and the SOF section is far from the file start.

BUG=chromium-os:22838
TEST=Load the images attached to the bug into the Photo Editor, observe the thumbnails.


Review URL: http://codereview.chromium.org/8748004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112206 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105864
TBR=sail@chromium.org

Review URL: http://codereview.chromium.org/8743008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112205 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105547


Review URL: http://codereview.chromium.org/8726005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112204 0039d316-1c4b-4281-b951-d872f2087c98

BUG=100914
TBR=scherkus@chromium.org

Review URL: http://codereview.chromium.org/8747010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112203 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105864
TBR=sail@chromium.org

Review URL: http://codereview.chromium.org/8742010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112202 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105864
TBR=sail@chromium.org

Review URL: http://codereview.chromium.org/8746013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112201 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105855


Review URL: http://codereview.chromium.org/8440064

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112200 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8673011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112199 0039d316-1c4b-4281-b951-d872f2087c98

This is a hang that slows down the bot and the test looks very sensitive to
timing.  I'm not interested in fully investigating this failure, and I'd like
the bot to cycle faster sooner.

R=bruening@chromium.org
BUG=105762

Review URL: http://codereview.chromium.org/8735005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112198 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104535
TBR=viettrungluu@chromium.org

Review URL: http://codereview.chromium.org/8746011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112197 0039d316-1c4b-4281-b951-d872f2087c98

BUG=100914
TBR=scherkus@chromium.org

Review URL: http://codereview.chromium.org/8743006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112196 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:20789
TEST=manual


Review URL: http://codereview.chromium.org/8681029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112195 0039d316-1c4b-4281-b951-d872f2087c98

Re-application of CL originally reviewed here: http://codereview.chromium.org/8383036  That CL was wound back after test failures not caught by commitbot. Those test failures fixed here.

Adding parameter to GetStatusLabels to indicate if links are acceptable, as some platforms cannot handle links in all the places these messages are shown."

This reverts commit 8a7d864f.

BUG=N/A
TEST=N/A


Review URL: http://codereview.chromium.org/8634008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112194 0039d316-1c4b-4281-b951-d872f2087c98

This shouldn't have any effect on this test.

BUG=62897
TBR=polina

Review URL: http://codereview.chromium.org/8692020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112191 0039d316-1c4b-4281-b951-d872f2087c98