- 12 Jan, 2014 6 commits
-
-
danakj@chromium.org authored
This allows us to use real GL bindings but without drawing when we don't care about pixel output, allowing for faster execution. In particular this will allow us to use OSMesa instead of a completely fake GL implementation in the compositor for browser tests. We add a new kDisableGLDrawingForTests command line flag that can be set to prevent the GL draw calls from doing any work. We will be able to set this flag in the browser test environment for any tests that don't require real pixel output. R=piman, sievers BUG=270918 Review URL: https://codereview.chromium.org/132473009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244405 0039d316-1c4b-4281-b951-d872f2087c98
-
benjhayden@chromium.org authored
Change chrome.downloads.DownloadItem.{fileSize,bytesReceived,totalBytes} from longs to doubles for files > 2GB. Review URL: https://codereview.chromium.org/132353002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244404 0039d316-1c4b-4281-b951-d872f2087c98
-
msw@chromium.org authored
BUG=NONE TEST=Build cycles green. TBR=sky@chromium.org NOTRY=true NOTREECHECKS=true Review URL: https://codereview.chromium.org/135853002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244403 0039d316-1c4b-4281-b951-d872f2087c98
-
https://codereview.chromium.org/120503005/msw@chromium.org authored
Reason for revert: views_unittest failures... :-( TBR=sky@chromium.org NOTREECHECKS=true NOTRY=true BUG=131660 Review URL: https://codereview.chromium.org/135813002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244402 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244401 0039d316-1c4b-4281-b951-d872f2087c98
-
https://codereview.chromium.org/111953007/cmp@chromium.org authored
> Revert of https://codereview.chromium.org/111953007/ > Reason for revert: Broke Linux build in http://build.chromium.org/p/chromium/builders/Linux/builds/46507. > > TBR=thakis@chromium.org,ajwong@chromium.org,brettw@chromium.org,phajdan.jr@chromium.org,nick@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=240309 > > Review URL: https://codereview.chromium.org/135773002 The original patch didn't set props correctly. thakis landed a separate change to fix that. The revert of this revert in Rietveld failed at https://codereview.chromium.org/135773003/. TBR=cmp@chromium.org Review URL: https://codereview.chromium.org/135793002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244400 0039d316-1c4b-4281-b951-d872f2087c98
-
- 11 Jan, 2014 34 commits
-
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244399 0039d316-1c4b-4281-b951-d872f2087c98
-
https://codereview.chromium.org/111953007/cmp@chromium.org authored
Reason for revert: Broke Linux build in http://build.chromium.org/p/chromium/builders/Linux/builds/46507. TBR=thakis@chromium.org,ajwong@chromium.org,brettw@chromium.org,phajdan.jr@chromium.org,nick@chromium.org NOTREECHECKS=true NOTRY=true BUG=240309 Review URL: https://codereview.chromium.org/135773002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244398 0039d316-1c4b-4281-b951-d872f2087c98
-
xhwang@chromium.org authored
TBR=sky@chromium.org BUG=232969 Review URL: https://codereview.chromium.org/132293004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244397 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244396 0039d316-1c4b-4281-b951-d872f2087c98
-
mallinath@chromium.org authored
Update includes following CLs: https://codereview.chromium.org/131323007/ TBR=rsleevi@chromium.org BUG=none TEST=none Review URL: https://codereview.chromium.org/131973006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244395 0039d316-1c4b-4281-b951-d872f2087c98
-
jochen@chromium.org authored
BUG=297480 R=jam@chromium.org Review URL: https://codereview.chromium.org/131573003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244394 0039d316-1c4b-4281-b951-d872f2087c98
-
tzik@chromium.org authored
* Pass platform file path instead of virtual path to fileapis::QuotaReservation. * This should fix the quota leak regression. BUG=333150 Review URL: https://codereview.chromium.org/131043002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244393 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
Hopefully fixes check_perms on http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Full/builds/30915/steps/check_perms/logs/stdio BUG=240309 TBR=nick@chromium.org Review URL: https://codereview.chromium.org/135123003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244392 0039d316-1c4b-4281-b951-d872f2087c98
-
avi@chromium.org authored
BUG=170921 TEST=everything still works, bug 100806 doesn't regress Review URL: https://codereview.chromium.org/133013002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244391 0039d316-1c4b-4281-b951-d872f2087c98
-
qyearsley@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/130613002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244390 0039d316-1c4b-4281-b951-d872f2087c98
-
rtoy@google.com authored
After many months, there hasn't been anything bad reported about unknown WAVE chunks, so disable this message. BUG=290737 Review URL: https://codereview.chromium.org/131833006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244389 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
NOTRY=true Review URL: https://codereview.chromium.org/134783002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244388 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
BUG=333572 TBR=eae@chromium.org Review URL: https://codereview.chromium.org/135763003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244387 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
This is necessitated by our building of base for tools. In particular if I set OS_ANDROID and USE_AURA then the host is built with OS_LINUX and USE_AURA, but none of the other flags we normally set if USE_AURA is set for OS_LINUX. And yes, I really need to spend time and refactor messageloop. It is such a mess of ifdefs right now. BUG=none TEST=none R=darin@chromium.org Review URL: https://codereview.chromium.org/129873003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244386 0039d316-1c4b-4281-b951-d872f2087c98
-
scheib@chromium.org authored
Particualarly for apps documentation, a developer who first encounters chrome.events may be slightly confused about all the documentation without the context that it is all in support of other APIs. BUG=325011 NOTRY=true Review URL: https://codereview.chromium.org/135083002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244385 0039d316-1c4b-4281-b951-d872f2087c98
-
tonyg@chromium.org authored
1. zIndex is case sensitive. Page contents were bleeding through on some pages. 2. With android screen capture compression artifacts, a slightly higher tolerance was needed. 3. The assert was wrong. We need to make sure the whole bounding box is filled. It doesn't matter what percent of the overall video is the bounding box. BUG=323813 Review URL: https://codereview.chromium.org/127373003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244384 0039d316-1c4b-4281-b951-d872f2087c98
-
jamesr@chromium.org authored
Some cc::ContextProvider instances will also need to provide WebGraphicsContext3D* interfaces to the underlying GL context, but not all. This adds a subclass of ContextProvider in content:: to use for these users. The compositor itself doesn't need the WGC3D accessor so it just uses the base class. BUG=181120 Review URL: https://codereview.chromium.org/126093010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244383 0039d316-1c4b-4281-b951-d872f2087c98
-
enne@chromium.org authored
These have been replaced by Telemetry tests and are not being run anywhere. BUG=332167, 333357 Review URL: https://codereview.chromium.org/124393006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244382 0039d316-1c4b-4281-b951-d872f2087c98
-
haitaol@chromium.org authored
Support GU retry command in sync engine. The command specifies a delay after which syncer should issue a GU to pick up updates missed by last GU. BUG= Review URL: https://codereview.chromium.org/124083002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244381 0039d316-1c4b-4281-b951-d872f2087c98
-
jdduke@chromium.org authored
Provide touch and gesture events with the appropriate INPUT_EVENT_LATENCY_ORIGINAL_COMPONENT LatencyInfo timestamp. This timestamp is that generated by the kernel, and is useful for tracking end-to-end event latency. BUG=333370 Review URL: https://codereview.chromium.org/134683003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244380 0039d316-1c4b-4281-b951-d872f2087c98
-
acolwell@chromium.org authored
BUG=b/12218009 TEST=TrackRunIteratorTest. MissingStssMakesAllSamplesKeyframes Review URL: https://codereview.chromium.org/134873002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244379 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
Trying to get the cros asan bot green (crbug.com/333571) > Include external touchscreen vid/pid in UMA hardware profile > > Previously we looked at including the touchscreen name in the UMA > hardware profile: https://codereview.chromium.org/23619085/. > > As that posed a privacy concern, this patch includes the vid/pid > instead. > > BUG=248910 > > Review URL: https://codereview.chromium.org/103893005 TBR=tdresser@chromium.org Review URL: https://codereview.chromium.org/135763002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244378 0039d316-1c4b-4281-b951-d872f2087c98
-
msw@chromium.org authored
Consolidate the split textfield code into Textfield. No behavior changes (except STYLE_LOWERCASE GetText nit). Use the underlying model's text and font_list storage. Remove unused code; rename TextfieldViewsModel::text(). Revise gesture and command handling. Skip NotifyAccessibilityEvent native behavior without widget. (No HWND for Views not yet added to view hierarchy) Make TouchEditable::GetNativeView const; avoids conflict. Fix includes, forward decls, Font[List] usage, tests. Ideas for followup cleanup and refactoring: -Cleanup View overrides decl/def order. -Refactor RemoveBorder, SetHorizontalMargins, etc. -Try to use composition instead of inheritance. -Remove textfield style ctor; refactor style code. -Remove STYLE_LOWERCASE functionality (one user). -Replace placeholder DrawStringRect with a Label view. -Cleanup CreateTouchSelectionControllerAndNotifyIt, etc. -Cleanup SetColor/SetTextColor, etc. BUG=131660 TEST=No textfield behavior/appearance regressions. R=sky@chromium.org Review URL: https://codereview.chromium.org/120503005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244377 0039d316-1c4b-4281-b951-d872f2087c98
-
boliu@chromium.org authored
Remove these extensions that do not guard any new gl functions: GL_CHROMIUM_front_buffer_cached GL_CHROMIUM_fast_NPOT_MO8_textures BUG=285390 NOTRY=true Review URL: https://codereview.chromium.org/112343010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244376 0039d316-1c4b-4281-b951-d872f2087c98
-
pkotwicz@chromium.org authored
BUG=333160 TEST=Manual, see bug Review URL: https://codereview.chromium.org/133333002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244375 0039d316-1c4b-4281-b951-d872f2087c98
-
elham@chromium.org authored
Adding a test case to webrtc contect_browser test: - Test case will verify that we can setup a call with an SDP offer that includes B=AS:xx BUG=316459 Review URL: https://codereview.chromium.org/113383002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244374 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244373 0039d316-1c4b-4281-b951-d872f2087c98
-
nick@chromium.org authored
The binaries are hosted in Google storage, and pulled in via a runhook. Each included binary is roughly 1.1MB. The binaries referenced here were built from clang at revision 198831. On the wiki, I've started instructions for how to update the binaries in the future: https://code.google.com/p/chromium/wiki/UpdatingClangFormatBinaries Note that clang_format/scripts are copied here only as an expedience; once we have a proper mirror set up, we'll pull these via DEPS BUG=240309 TBR=brettw,phajdan.jr Review URL: https://codereview.chromium.org/111953007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244372 0039d316-1c4b-4281-b951-d872f2087c98
-
ajwong@chromium.org authored
This is part of relanding https://chromiumcodereview.appspot.com/12546016 Unifying the Cookiecreation interface makes the cookie store creation more consistent. Having a config struct also enables the next refactor where we move the cookie store creation enitrely into the content layer (the embedder will only responsible for providing the correct configuration). This also changes the lifetime of CookieCryptoDelegate so one object can be shared amongst multiple cookie stores. Allows for easier lifetime semantics in the CookieStoreConfig and also is slightly less wasteful of memory. TBR=jam BUG=159193 Review URL: https://codereview.chromium.org/110883017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244371 0039d316-1c4b-4281-b951-d872f2087c98
-
blois@google.com authored
Support for following symlinks was added with https://chromiumcodereview.appspot.com/10387035/ but it's been broken for script resources because the proper flags were not being propagated. This only allows following symlinks if the extension was an unpacked extension. BUG=27185 Review URL: https://codereview.chromium.org/106533003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244370 0039d316-1c4b-4281-b951-d872f2087c98
-
cmumford@chromium.org authored
First implementation contained a memory leak in the test due to a missing scoped_ptr. BUG=259564 Review URL: https://codereview.chromium.org/93873017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244369 0039d316-1c4b-4281-b951-d872f2087c98
-
cmp@chromium.org authored
BUG=333125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244368 0039d316-1c4b-4281-b951-d872f2087c98
-
cmp@chromium.org authored
BUG=333125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244367 0039d316-1c4b-4281-b951-d872f2087c98
-
cmp@chromium.org authored
BUG=333125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244366 0039d316-1c4b-4281-b951-d872f2087c98
-