- 16 Oct, 2019 40 commits
-
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/ebe5dcf0d9ad..01cc61ab9c9c git log ebe5dcf0d9ad..01cc61ab9c9c --date=short --no-merges --format='%ad %ae %s' 2019-10-16 natsu@google.com Remove hardcoded sdk_versions in third_party Created with: gclient setdep -r src/third_party/swiftshader@01cc61ab9c9c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/138239233,chromium:b/142276229 Change-Id: I1f5e6634593845c93d94c18b430328556ad32459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865037Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706588}
-
Kevin McNee authored
We test that methods for history manipulation work inside a portal context and that their behaviour is the same as in a non-portal context. We also test the new behaviour introduced with portals where a portal and its host do not form a joint session history. So unlike iframes, any session history change within a portal is done independently of its host. Bug: 914108 Change-Id: Ib1cdbe3e8d1c0e009eea1f05af28ef2971e8b353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807773Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#706587}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a14555a7928f..9a334fdadf3f git log a14555a7928f..9a334fdadf3f --date=short --no-merges --format='%ad %ae %s' 2019-10-16 jmadill@chromium.org Delete README.angle from googletest. 2019-10-16 timvp@google.com Vulkan: Mark destination buffers dirty after a copy Created with: gclient setdep -r src/third_party/angle@9a334fdadf3f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@google.com Bug: None Change-Id: I1753a2b13d9540e2002e195a310a98d685499be9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865440Reviewed-by:
-
Hiroshige Hayashizaki authored
To test import maps without built-in module support. In import-maps-without-builtin-modules virtual tests, we skip wpt/import-maps/builtin-support/ tests because all of them are about built-in modules, but still run wpt/import-maps/imported/ tests because they still contain subtests that can pass without built-in modules/fallbacks. Bug: 1010751 Change-Id: I9ca8b9d2d40a699819ff38f6d652b7dc4be1b079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841813 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#706585}
-
Oystein Eftevaag authored
https://chromium-review.googlesource.com/c/chromium/src/+/1834576 broke the legacy JSON upload of Slow Reports due to the data being truncated as data() has different semantics between RefCountedString and std::string, and the latter resulted in an unintended std::string constructor being implicitly invoked and the data being treated as a null-terminated string. R=ssid@chromium.org Bug: 1014589 Change-Id: If4d11ceb86106cf9cbee89735692dc83c1f7c35e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863855Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#706584}
-
Morten Stenshorne authored
Now that we support spanner margins, we need to make sure that we only apply the block-start margin before the first fragment generated from the spanner node. Bug: 829028 Change-Id: I76cc5c290009ad2c08ab78c6d780ef930f9b8641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865170 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#706583}
-
shyam authored
Change-Id: Icf7368771f79d7c4e42c5845fb3a1fc6914a0469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864384 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Shyamsundar Parthasarathy <shyamsundarp@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#706582}
-
Andrew Xu authored
The wrong radius was set by the culprit CL (crrev.com/c/1806015). This CL fixes such an issue. Bug: 1011013 Change-Id: I10659f593914fa3bdea0ca8b0f6f8bbb141c000f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865480 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#706581}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0882b0ee. With Chromium commits locally applied on WPT: 6386d9d8 "Update service_worker_unregister_and_register()" f399b336 "Fetch Metadata: Add a test for `<embed>` navigated after loading." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I6accdaa09b7e5796792599bec37fd80a7628f549 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864877Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706580}
-
Christopher Thompson authored
This refactors how Page Info handles showing the organization details for sites with EV certificates by moving creation of the subtitle text into the PageInfoBubbleView directly, since this is only used there. This fixes an issue where we were over-using the site_details_details_ member to track both EV details and Safe Browsing details, causing the certificate button subtitle to get filled with the wrong text for sites that have an EV certificate *and* trigger SB warnings. As part of this, tracking the organization name in PageInfo is no longer necessary, so this also removes that entirely. This change also includes two new tests: a unit test for checking that the certificate button subtitle text is correctly set for sites with EV certificates, and a regression browser test for sites that have an EV cert and trigger SB warnings. Bug: 1014240 Change-Id: I414cb07097fb5781c4b3a22ac7cca6e52bf14365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863643Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#706579}
-
Andrey Kosyakov authored
network_service_connection_error_handler_holder_ is used to update loader factories in page upon network service failure, so it should not be cleared upon navigation. Change-Id: I2103d633e47525ee8d8b33aa91324cb6c11ce9c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863857Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#706578}
-
Owen Min authored
Change MachineLevelUserCloudPolicyRegisterWatcher to ChromeBrowserCloudManagementRegisterWatcher Bug: 1010704 Change-Id: I864d3427b7e4f79ba180706755c489049922e8b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854225 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#706577}
-
Alex Cooper authored
This feature is intended to ship in 79, so the flag should be enabled by default. Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/Nvll21RaKwM/fTn8qUaNBwAJ Bug: 1013739 Change-Id: I195c07cd61c2058533c2fa6640263567be248a40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857008 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#706576}
-
Saman Sami authored
Instead of OverlayCheck_Params and OverlayCheckReturn_Params, use OverlaySurfaceCandidate and OverlayStatus respectively. The IPC structs are going away in the long term with the switch to mojo and they prevent us from adding more fields that may not be serializable (e.g. NativePixmap). Bug: 756454 Change-Id: I8fc8c975cd1f67706329c8ea9a38503e196068a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850537 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#706575}
-
Chris Harrelson authored
When a locked element becomes unlocked, it will compare its size before locking with the one after unlocking. Bug:964055 Change-Id: Ic9c32a68411e2ad5d7c9aaec4aeeb424cace044f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860597 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#706574}
-
Christopher Grant authored
Some Android versions decode (some) symbols directly in Logcat output, even if a library lives uncompressed within an APK. Oddly, even for symbols within the same library, it may decode some and not others. Decoded symbols have the symbol name trailing the library offset, as follows: ...apk (offset 0x158a000) (logging::LogMessage::~LogMessage()+598) Currently, these lines are ignored by the decoder, which actually removes the information Android supplied. This change fixes the parsing to decode offset properly, and treat these lines the same as those without a decoded symbol. In the future, we ought to simply print the platform-decoded symbol names if present. R=agrieve Bug: 986622 Change-Id: Iec2b5968fe5e709f0dd37132a74d7f5c54957ae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865203Reviewed-by:
-
Matt Mueller authored
Bug: 973650 Change-Id: I87468a94853789b2cc30fbc70d3bba20d89634b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853908 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#706572}
-
Garrett Beaty authored
Fix misspelling of coverage in docstring. Add section comments that I intended to add in https://crrev.com/c/1837196, but must have changed it on the wrong local branch. Bug: 1011908 Change-Id: I2cd0bea4d157dcd4e4c5b9a34f9d5dd0b64e4967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865534 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#706571}
-
Etienne Pierre-doray authored
Change-Id: I3b4c51879cef4b97c777715f5d190cb33decbd77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834897 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#706570}
-
Jae Hoon Kim authored
Once the dependent CQ is uprev'ed, the DBus errors will be correctly handled and logged in a clearer fashion. The parsing logic is not required since the errors are individual accessible within the ErrorResponse itself. Bug: none Test: # with CrOS changes + manual testing Change-Id: Id95362c8a2acbb63bc45f11e60313724e558d461 Cq-Depend: chromium:1848202, chromium:1865202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848577 Commit-Queue: Jae Hoon Kim <kimjae@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#706569}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2f8a97068d48..f73d91573493 git log 2f8a97068d48..f73d91573493 --date=short --no-merges --format='%ad %ae %s' 2019-10-16 fmayer@google.com Merge "Ingest roots from profile." 2019-10-16 fmayer@google.com Merge "Change HeapGraphObject.root_type to an enum." 2019-10-16 fmayer@google.com Merge "Assert HeapGraph contains roots." Created with: gclient setdep -r src/third_party/perfetto@f73d91573493 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Id412281f92c54b8b9c3b5556345a185518e10ae8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865036Reviewed-by:
-
Jae Hoon Kim authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/61297bd64bfd..1fd712f839e2 $ git log 61297bd64..1fd712f83 --date=short --no-merges --format='%ad %ae %s' 2019-10-08 kimjae dlcservice: DBus Error correction 2019-10-10 paulhsia system_api: add enable_audio_capture option to StartVmRequest 2019-10-01 louiscollard attestation: Certify NV using a certified key 2019-10-01 louiscollard system_api: Rename U2F interface.proto 2019-10-07 efoo Add "# COMPONENT" to system_api OWNERS file 2019-10-08 khegde power: Add model_name and charge to proto 2019-09-25 allenwebb system_api: Add rust D-Bus bindings generation. 2019-09-30 alainmichaud system_api: Convert const to constexpr for BT dbus constants 2019-09-26 okalitova system_api: Remove Crostini app repository search in the launcher Created with: roll-dep src/third_party/cros_system_api Bug: none Change-Id: I5c1a147dbd1caf9933ba7bc96a456e81935d9f68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865202Reviewed-by:
Mike Frysinger <vapier@chromium.org> Commit-Queue: Jae Hoon Kim <kimjae@chromium.org> Cr-Commit-Position: refs/heads/master@{#706567}
-
Robert Liao authored
All uses have been removed in favor of Microsoft::WRL::RuntimeClass. Fixed:1014283 TBR=gab@chromium.org Trivial //base/BUILD.gn change. Change-Id: Id31e464c30d59958a7ac5524217ac9b685f4b077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863110 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#706566}
-
Jack Lynch authored
This change makes the event listeners pane navigable by keyboard and accessible to screen readers. Standard treeoutline keyboard focus is the only visible change: https://gyazo.com/0098dd06216f58575468fcf7c5902cbc Keyboard navigation video: https://i.imgur.com/Hq73jum.mp4 Bug: 963183 Change-Id: Ia32451e29b16a63e20de0a1e6c351e38568c13ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649732Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Commit-Queue: Jack Lynch <jalyn@microsoft.com> Cr-Commit-Position: refs/heads/master@{#706565}
-
Chris Hamilton authored
This creates the root of the frame priority voting hierarchy, a VoteConsumer that takes incoming votes and applies them on nodes in the graph. Further CLs will introduce Page and Process priority decorators that aggregate results from related Frames. BUG=971272 Change-Id: I3870f28641c67699bed14f7ab293f20ecbfecc59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856758 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#706564}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a0568178808d..0cb3e4bf7d70 git log a0568178808d..0cb3e4bf7d70 --date=short --no-merges --format='%ad %ae %s' 2019-10-16 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-16 jmadill@chromium.org git-cl: Add diff lines of context setting. Created with: gclient setdep -r src/third_party/depot_tools@0cb3e4bf7d70 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: Ia953ac975fa6838b6cbecd9caaa9af4320c73f15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865034Reviewed-by:
-
Ahmed Fakhry authored
Apparently the view could be destroyed before a tracked unparented transient child gets parented BUG=1014543 Change-Id: I75a5643ae3bac2032a022b3171618c36f30c7eb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864383Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#706562}
-
Michael Crouse authored
Change-Id: Ieb00baef4bf96b3cb4b7d5191f0437ae2051f9a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864713 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#706561}
-
Jack Lynch authored
This PR enables keyboard navigation of the event listeners tree view and adds a more descriptive aria-label for the refresh button. Keyboard navigation gif: https://i.imgur.com/QlKjnEf.mp4 Empty pane focused screenshot: https://gyazo.com/d494f4ab0b2f9d550192f9920838b6a0 Bug: 963183 Change-Id: I6f7c1fa304606238c1bf23d7a663560cc2c75718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665298Reviewed-by:
-
Erik Jensen authored
Apparently older versions of GTK require IDs for all objects. Change-Id: I01063d543623e4ae676616dc527a368252c080d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865477 Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Auto-Submit: Erik Jensen <rkjnsn@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#706559}
-
Alan Cutter authored
Bug: 1014863 Change-Id: I6896cee115e56d33a691c7ac796c42b77efe0afa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864506 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#706558}
-
John Budorick authored
main_thread_metrics_helper.cc includes renderer_resource_coordinator.h, which in turn imports a mojo generated header from //components as of https://chromium-review.googlesource.com/c/chromium/src/+/1845966. scheduler's lack of dependency on instrumentation meant that this was a build race; scheduler could be built before the header got generated. This resulted in a tree-closing build flake in https://ci.chromium.org/p/chromium/builders/ci/win32-archive-rel/6131 This CL should fix that build flake. No-Tree-Checks: true Tbr: siggi@chromium.org,skyostil@chromium.org Change-Id: I8d648128d3507e7cc3bdb91c58553b6483a5c32e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864382 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#706557}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a737564bd5b5..d8b52989fe6b git log a737564bd5b5..d8b52989fe6b --date=short --no-merges --format='%ad %ae %s' 2019-10-16 vapier@chromium.org cros_build_lib: port to python 3 Created with: gclient setdep -r src/third_party/chromite@d8b52989fe6b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I2a6a6d18cd22ffe71e66aced42c0135cbf062ae8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864513Reviewed-by:
-
Dirk Pranke authored
When we added support for running on Mac 10.14 in https://crrev.com/c/1333567 and 10.15 in https://crrev.com/c/1776218, we didn't update the global list of supported test configurations in blinkpy/web_tests/port/base.py, which means that a test expectation would have been ignored on those machines *unless* you happened to be running on a Retina machine (like a Macbook Pro), which is treated as the "mac-retina" port and not "mac-10.14". 10.14 and 10.15 are still not fully supported, as we don't support separate baselines for them and don't support 10.14 or 10.15-specific expectations. This CL just means that the tests will run and 'Mac' expectations will work correctly. Bug: 1014785 Change-Id: I43521c752ceee92f21ed4335ebe055c486cc8427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864002 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#706555}
-
Jasper Chapman-Black authored
Bug: 1011921 Change-Id: Ic8ed94149f624620679d67a6d0f33cf28bd3634e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856839 Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Reviewed-by:
-
Parastoo Geranmayeh authored
TBR=sky@chromium.org Bug: 1015020 Change-Id: Ia71d6f25a54198b2210d706e7bfc9e8d663f0eb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864717 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#706553}
-
Yves Gerey authored
This is a reland of 9db0a32a Reason for reland: The problematic part (misconfigured test suite) has been removed. A proper test suite will be added in a follow-up CL. Original change's description: > Add builder for opus test in prevision of rolls. > > This CL introduces an ad-hoc builder for roll of opus into chromium. > 1/ Used as pres-submit validation. > 2/ Runs dedicated tests and benchmarks for a fixed Android model. > > The point 2/ shall be completed in follow-up CLs. > > Bug: chromium:1002973 > Change-Id: Idb5c8b46ab68d8a9d63a864594396ac021a22746 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816555 > Commit-Queue: Yves Gerey <yvesg@google.com> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#704847} Bug: chromium:1002973 Change-Id: Idd7f8d79350b622180b0c5d212712ac4e64a40bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860020Reviewed-by:
-
Brandon Goddard authored
This change addresses an issue in Datagrids where pressing the context menu key while the data grid has focus does brings up actions for whatever node is in the center of the grid instead of whichever node is currently selected. Notice how in the before clip, the center rows with primary keys 14-16 get deleted, but in the after clip, the selected rows get deleted as expected: Before: https://imgur.com/pcijlqq After: https://imgur.com/TBLokOy Longer Explanation: Since the data grid itself retains focus, it uses CSS classes to indicate the currently selected item in the grid. When using a mouse right-click to bring up the context menu, the event.target in the context menu handler points to whatever cell was clicked on, and the data grid can determine the corresponding node from the target. However, when the context menu key is pressed, the event.target refers to whichever cell is directly in the visible center of the grid, which is often not the "selected" row. This causes the unexpected behavior of performing actions on the center row instead of the selected row. The fix uses event.button to detect the case where the context menu handler was reached but no mouse buttons where used (either the context menu key or Shift+F10) and then grabs the currently selected node instead of the node from the event.target https://developer.mozilla.org/en-US/docs/Web/API/MouseEvent/button Bug: 963183 Change-Id: Ib501178f0075b0ccf536b20d12f602fc174f325c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729554Reviewed-by:
Jeff Fisher <jeffish@microsoft.com> Commit-Queue: Brandon Goddard <brgoddar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#706551}
-
Garrett Beaty authored
Bug: 1011908 Change-Id: I0199693b03d5f6db82f5805e9b5047b80e0ba79c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862247 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
-
Mirko Bonadei authored
In component build mode, static_libraries do not guarantee that all the exported symbols will be present in the shared library while source_sets pass all the objects file to the linker. Bug: webrtc:9419 Change-Id: I2091ec607bf8848825f18a748e10bcd939d55bd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865215Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#706549}
-
