GitLab

This removes the base version that takes const char*, and replace it by the one that takes const std::string&. Consolidating this code in one place and having a single function, instead of two with the same name in two different places.

This is a redo of a patch that started in
https://codereview.chromium.org/269943004/

and of another try that was made in
https://codereview.chromium.org/834183005/.

BUG=None
TEST=base_unittests, ui_base_unittests and chrome.
R=sky@chromium.org,thakis@chromium.org

Review URL: https://codereview.chromium.org/846373002

Cr-Commit-Position: refs/heads/master@{#311781}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0b09228..0db94e2

TBR=yutak@chromium.org,morrita@chromium.org

Review URL: https://codereview.chromium.org/818543004

Cr-Commit-Position: refs/heads/master@{#311780}

Consumers of this API would crash since Init wasn't getting called.
Also the incorrect dbus object was getting called.

BUG=441765

Review URL: https://codereview.chromium.org/847313003

Cr-Commit-Position: refs/heads/master@{#311779}

Android generates alternate resources when dependent on a higher sdk version then the minsdkversion.
This is conflicts with Playstore rules that only permit one resource for App Restrictions.
I have now qualified the resource to apply only for sdk > 21 where the App Restriction API was exposed.

BUG=448829
BUG=446795

TBR=bartfab@chromium.org

Review URL: https://codereview.chromium.org/838263005

Cr-Commit-Position: refs/heads/master@{#311778}

Two fixes for accessibility of out-of-process iframes and guest frames
(e.g. <webview>):

1. BrowserAccessibilityManager::GetFocus should return the focused node
   from a child frame.
2. BrowserAccessibilityManager::GetLocalBoundsRect and
   BrowserAccessibilityCocoa::pointInScreen need to correctly take
   child frames into account.

This is sufficient for correct spoken feedback and UI element bounding
rects in VoiceOver when tabbing into and out of an out-of-process iframe
or <webview> guest frame. There may be other bugs, but simple examples
work in VoiceOver now.

BUG=330307,368298

Review URL: https://codereview.chromium.org/849143003

Cr-Commit-Position: refs/heads/master@{#311777}

BUG=440818
TEST=None

Review URL: https://codereview.chromium.org/855503002

Cr-Commit-Position: refs/heads/master@{#311776}

The new left-nav wasn't showing up for the top-level parents. This is because there's a dependency between the selected item, and showing the selected item's child elements in the navigation.

Adding redirects is a quick solution. But we should tweak the logic for rendering the navigation to do this better. Created a bug to make this happen: https://code.google.com/p/chromium/issues/detail?id=449272

I also added the nativeMessaging article to chrome_sidenav.json so it's not an orphan page (and so it gets a left-side navigation).

BUG=447853

Review URL: https://codereview.chromium.org/849303003

Cr-Commit-Position: refs/heads/master@{#311775}

These are briefly broken because location is disabled on test devices,
and the mechanism for mocking out system location settings was broken.
To be fixed shortly.

BUG=449341
NOTRY=true

Review URL: https://codereview.chromium.org/849363002

Cr-Commit-Position: refs/heads/master@{#311774}

This is a follow-up clean up to
https://chromiumcodereview.appspot.com/842493004/
so we can:
- Use the appropriate constant to detect autocomplete="off".
- Add test case for autocomplete="off" (returns key code rather than 229).

Review URL: https://codereview.chromium.org/848223003

Cr-Commit-Position: refs/heads/master@{#311773}

I see it often not completing in time.

BUG=448877

Review URL: https://codereview.chromium.org/829303005

Cr-Commit-Position: refs/heads/master@{#311772}

Previously, this used a thread, but this did not work within a PID
namespace because /proc/<tid> can refer to a completely different
process.

BUG=312380

Review URL: https://codereview.chromium.org/853583002

Cr-Commit-Position: refs/heads/master@{#311771}

Note that class templates are currently ignored by all Chromium checkers; see crbug.com/441916.

BUG=303818

Review URL: https://codereview.chromium.org/803603003

Cr-Commit-Position: refs/heads/master@{#311770}

Revert of Revert of cc: Remove tile rasterize on demand for GPU rasterization (patchset #1 id:1 of https://codereview.chromium.org/832353004/)

Reason for revert:
this will conflict with vmpstr's change :(

Original issue's description:
> Revert of cc: Remove tile rasterize on demand for GPU rasterization (patchset #2 id:20001 of https://codereview.chromium.org/842483003/)
>
> Reason for revert:
> Speculative revert for https://code.google.com/p/chromium/issues/detail?id=449288
>
> Original issue's description:
> > cc: Remove tile rasterize on demand for GPU rasterization
> >
> > This code was recently added and isn't needed because it signals to the tile
> > that it should raster on demand (checkerboard), but this will happen anyway with
> > the delgated renderer.
> >
> > I've also removed a test that was breaking due to the change.
> >
> > The test wasn't really testing what we thought, because we wouldn't end up
> > rasterizing anything with GPU, even though force was on.
> >
> > Committed: https://crrev.com/01a4b8027c2e9e678cd6afd0a97bf83807d55f5a
> > Cr-Commit-Position: refs/heads/master@{#311109}
>
> TBR=vmpstr@chromium.org,danakj@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://crrev.com/6bf7f22dd46c31ffcf72e48397edf3ec08533ad5
> Cr-Commit-Position: refs/heads/master@{#311764}

TBR=vmpstr@chromium.org,danakj@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/855583002

Cr-Commit-Position: refs/heads/master@{#311769}

Revert of mac: Implement custom AppKit Enter Fullscreen transition. (patchset #6 id:240001 of https://codereview.chromium.org/846443004/)

Reason for revert:
Trying to track down a sizes failure.  Speculatively reverting.  Will re-apply if not the cause.

Original issue's description:
> mac: Implement custom AppKit Enter Fullscreen transition.
>
> AppKit's default Fullscreen transition cross-fades between two static images: a
> snapshot of the window before the transition began, and a snapshot of the
> window resized to the full size of the screen. This has the problem that
> frequently, when AppKit takes the snapshot of the final state of the window,
> the web contents view has not yet drawn any content in the new size. The
> animation itself looks weird, and then there's a flash when the animation
> finishes where the snapshot of the old web content is replaced by the new web
> content.
>
> This custom fullscreen transition is very similar, except instead of taking a
> snapshot of the window in its final state, the transition uses a live version
> of the window in its final state. See the associated bug for more details about
> the implementation.
>
> BUG=414527
>
> Committed: https://crrev.com/a48cbbba0075b7a7c135605ab576bad2cfa5a1b3
> Cr-Commit-Position: refs/heads/master@{#311717}

TBR=andresantoso@chromium.org,rsesek@chromium.org,mark@chromium.org,erikchen@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=414527

Review URL: https://codereview.chromium.org/848153005

Cr-Commit-Position: refs/heads/master@{#311768}

Previously, the generator could only ignore changes in the:
// From FILENAME.idl modified DAY MON DATE TIME YEAR.
line if it was not wrapped or wrapped in a specific place. (Note this line
would otherwise change every time you generate).

This CL makes it a little better, in that it will ignore timestamp changes
regardless of where the "modified" output is wrapped. Otherwise, the generator
wants to update a few thunk files because it's now 2015. See:
https://codereview.chromium.org/849473003/
for context.

BUG=
R=bbudge@chromium.org

Review URL: https://codereview.chromium.org/849283003

Cr-Commit-Position: refs/heads/master@{#311767}

The second call to WebView::SetWebContents(..) that replaces an existing
WebContents firsts calls NativeViewHost::Detach() to remove the old
WebContents. This calls NativeViewHost::ClearFocus(), which ensures the
FocusManager knows that the WebContents (and any children) are being
removed.

For Mac the problem was that, unlike Aura, the WebContents can not own
child Widgets. GetAllChildWidgets(foo) should return |foo| and all its
children, but on Mac it was including |foo|'s parent. Since |foo|'s
parent Contain()s the WebView which has focus, FocusManager was clearing
focus. Instead, the WebView should keep focus, because its only a
(native) child of the WebView that's getting removed.

This CL adds a check to Mac's NativeWidgetPrivate::GetAllChildWidgets()
to ensure only the Widget that directly corresponds to |native_view|
(and its children) are included.

On Mac, the test also needs to ensure active status is updated so that
the TextInputClient is set.

BUG=402679

Review URL: https://codereview.chromium.org/853453002

Cr-Commit-Position: refs/heads/master@{#311766}

Fixes compile of views_examples_with_content_exe and app_list_demo on
Mac with toolkit_views.

BUG=417463

Review URL: https://codereview.chromium.org/855453003

Cr-Commit-Position: refs/heads/master@{#311765}

Revert of cc: Remove tile rasterize on demand for GPU rasterization (patchset #2 id:20001 of https://codereview.chromium.org/842483003/)

Reason for revert:
Speculative revert for https://code.google.com/p/chromium/issues/detail?id=449288

Original issue's description:
> cc: Remove tile rasterize on demand for GPU rasterization
>
> This code was recently added and isn't needed because it signals to the tile
> that it should raster on demand (checkerboard), but this will happen anyway with
> the delgated renderer.
>
> I've also removed a test that was breaking due to the change.
>
> The test wasn't really testing what we thought, because we wouldn't end up
> rasterizing anything with GPU, even though force was on.
>
> Committed: https://crrev.com/01a4b8027c2e9e678cd6afd0a97bf83807d55f5a
> Cr-Commit-Position: refs/heads/master@{#311109}

TBR=vmpstr@chromium.org,danakj@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/832353004

Cr-Commit-Position: refs/heads/master@{#311764}

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with a ChromeOS build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/854043002

Cr-Commit-Position: refs/heads/master@{#311763}

Magic Mouse gestures don't cause -touches*WithEvent: events to be sent down the
responder chain. As such, all state related to Magic Mouse gestures needs to be
reset during -beginGestureWithEvent:.

BUG=317161

Review URL: https://codereview.chromium.org/821173003

Cr-Commit-Position: refs/heads/master@{#311762}

Review URL: https://codereview.chromium.org/849103005

Cr-Commit-Position: refs/heads/master@{#311761}

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with a ChromeOS build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463
R=xiyuan@chromium.org

Review URL: https://codereview.chromium.org/826743003

Cr-Commit-Position: refs/heads/master@{#311760}

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with a ChromeOS build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463
R=avi@chromium.org

Review URL: https://codereview.chromium.org/853073002

Cr-Commit-Position: refs/heads/master@{#311759}

For Non-SFI plugins, NaCl executables retrieved via the "fast path" are no
longer registered, and file tokens are no longer generated. This prevents
unnecessary work from happening in the browser, and prevents tokens from being
exposed to Non-SFI plugins.

An earlier change was attempted that prevented using the "fast path" in the
case of non-sfi plugins, but a performance regression was observed on ARC.

BUG=394130

Review URL: https://codereview.chromium.org/840103003

Cr-Commit-Position: refs/heads/master@{#311758}

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with a ChromeOS build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463
R=jhawkins@chromium.org

Review URL: https://codereview.chromium.org/854053002

Cr-Commit-Position: refs/heads/master@{#311757}

BUG=448877

Review URL: https://codereview.chromium.org/851013002

Cr-Commit-Position: refs/heads/master@{#311756}

BUG=448877

Review URL: https://codereview.chromium.org/848173004

Cr-Commit-Position: refs/heads/master@{#311755}

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with a ChromeOS build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/849273002

Cr-Commit-Position: refs/heads/master@{#311754}

This feature was inadvertently removed in r311100.

BUG=449005
BUG=418072

Review URL: https://codereview.chromium.org/852053003

Cr-Commit-Position: refs/heads/master@{#311753}

TBR=finnur
BUG=448956

Review URL: https://codereview.chromium.org/855563002

Cr-Commit-Position: refs/heads/master@{#311752}

BUG=447788
TBR=jyasskin@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/853673006

Cr-Commit-Position: refs/heads/master@{#311751}

This CL will allow mouse scroll-wheel zoom events to be passed from the
guest back to the embedder for handling.

BUG=447943

Review URL: https://codereview.chromium.org/849253003

Cr-Commit-Position: refs/heads/master@{#311750}

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with a ChromeOS build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463
R=tbarzic@chromium.org

Review URL: https://codereview.chromium.org/818633004

Cr-Commit-Position: refs/heads/master@{#311749}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/848153003

Cr-Commit-Position: refs/heads/master@{#311748}

BUG=448445

Review URL: https://codereview.chromium.org/821643005

Cr-Commit-Position: refs/heads/master@{#311747}

This test is flaky on the bots.

BUG=387045

Review URL: https://codereview.chromium.org/843043004

Cr-Commit-Position: refs/heads/master@{#311746}

Revert of CQ: enable win_chromium_compile_dbg_ng (patchset #1 id:1 of https://codereview.chromium.org/853933003/)

Reason for revert:
There are pending jobs (10 right now).

I just noticed that win_chromium_compile_dbg_ng uses a small number of win VMs as its pool, while win_chromium_compile_dbg uses the standard windows one.

Original issue's description:
> CQ: enable win_chromium_compile_dbg_ng
>
> BUG=380709
> R=sergiyb@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/b668bc884d5ce5812a48b68e6f737ecaaea8bc5b

TBR=sergiyb@chromium.org,phajdan.jr@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=380709

Review URL: https://codereview.chromium.org/819643007

Cr-Commit-Position: refs/heads/master@{#311745}

Accessing the keychain is really slow. Telemetry tests use a mock keychain,
which is abnormally fast. This CL exposes the number of times the mock keychain
is accessed via a local histogram, and 4 telemetry measurements record that
number as a metric.
Those tests are:
 - speedometer
 - page_cycler
 - startup
 - tab_switching

Once this metric is collected, alerts will be added to the Telemetry dashboard
to help catch regressions to the number of times the keychain gets accessed.

BUG=

Review URL: https://codereview.chromium.org/714273004

Cr-Commit-Position: refs/heads/master@{#311744}

The previous script update broke the closure compilation for some apps (like
files.app). This fixes the problem by correcting the values passed into
run_js_check.

The problems can be repro'ed by running:
  GYP_GENERATORS=ninja tools/gyp/gyp --depth . ui/file_manager/file_manager/*/js/compiled_resources.gyp && ninja -C out/Default;

After this cl, the above command returns only a single (valid!) error.

BUG=

Review URL: https://codereview.chromium.org/853983002

Cr-Commit-Position: refs/heads/master@{#311743}

DevToolsEventForwarder::VirtualKeyCodeWithoutLocation() and
content::GetWindowsKeyCodeWithoutLocation() do the same thing
as ui::LocatedToNonLocatedKeyboardCode().

Review URL: https://codereview.chromium.org/854483002

Cr-Commit-Position: refs/heads/master@{#311742}