GitLab

https://chromium.googlesource.com/chromiumos/chromite.git/+log/f9da224859f3..908f8fb5026a


git log f9da224859f3..908f8fb5026a --date=short --no-merges --format='%ad %ae %s'
2018-10-12 vapier@chromium.org paygen: paygen_build_lib: convert to gs.LS
2018-10-12 gmx@chromium.org minnie: enable new tcmalloc


Created with:
  gclient setdep -r src/third_party/chromite@908f8fb5026a

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ifb6398b0ccdbc291936a10949c55c649ad69d9d1
Reviewed-on: https://chromium-review.googlesource.com/c/1279088Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599370}

This CL updates the UI to show a badge icon in the app menu icon
whenever the user is running Chrome on a currently unsupported Android
version.  This badge in the app menu is only displayed once, until the
user taps the app menu icon. If the user does in fact get a new version,
the badge state is reset, and will be shown again. The current behavior
for out of date users stays the same as before (once per cold start).

In addition, a new menu item is displayed at the top of the menu that
explains that Chrome is unable to update. Nothing happens when you tap
the menu item in the case of an unsupported OS version.

The new menu item and the new warning message in About Chrome will
always be displayed when the user is in this state, regardless of
whether the app menu has already been tapped (which removes the badge).

This CL also updates the UI in Settings - About Chrome to show a new
message and a warning icon when the user is running Chrome on an
unsupported version of the Android OS.

By default, Jelly Bean is considered unsupported after this CL, but this
can be overridden from the variations framework.

It is possible to use command line flags or chrome://flags for
testing the different states, though that does not impact the
About Chrome screen.

Binary-Size: This CL adds new assets and the minimal code required.
Bug: 847940
Change-Id: If128e1692b66c5804928183718000aaf1e2ffaa6
Reviewed-on: https://chromium-review.googlesource.com/c/1243167
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599369}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4bc3c99c2672..5f31aded4251


Created with:
  gclient setdep -r src-internal@5f31aded4251

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ifa96df39ee76b855b8b35e23d3874070d86b61b2
Reviewed-on: https://chromium-review.googlesource.com/c/1279073Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599368}

Bug: 894622
Change-Id: I26e56c110a35ec21ba34ddc3064a2832184c9c96
Reviewed-on: https://chromium-review.googlesource.com/c/1277690Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599367}

This is a mechanical change.

It introduces ProtocolParser and ProtocolSerializer abstract classes
to allow different protocols in the future. Only the XML implementation
of these classes is provided in this changelist.

Bug: 848505
Change-Id: I4bda0f92f5b676f0f0eaca7dc841c8dca9c282ad
Reviewed-on: https://chromium-review.googlesource.com/c/1278476
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599366}

No change in behavior, just making it explicit how CQ is treating
this builder.

R=ehmaldonado, jbudorick

Bug: 893955
Change-Id: I367748688d5eefa69e582c04089191ea9710a842
Reviewed-on: https://chromium-review.googlesource.com/c/1279168Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599365}

Bug: 828031
Change-Id: I1d4bdb235ad9d93df0653215c7c5928c471b6c16
Reviewed-on: https://chromium-review.googlesource.com/c/1277693Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599364}

This has not been used for a long time and App Store regulations no
longer approves of the use of this type of app rating requests.

Bug: 863559
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I3aa5eb6a190d0577ff202b527c58566702a9ff18
Reviewed-on: https://chromium-review.googlesource.com/c/1278532Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599363}

Previously, the HTTP Auth Cache was implemented as a list of auth
entries, which was searched linearly for a matching entry upon lookup.
This change converts the cache to a multimap keyed on the origin, which
is expected to provide faster lookups in cases where there are no
matching entries for a given origin (which is the majority of cases).
This will also allow for a higher cache size limit without a linear
increase in lookup time, hence the cache size limit is raised from 10 to
20. This is expected to lower the rate of evictions upon adding entries.
Obsolete histograms which no longer apply to the new implementation are
also removed.

Bug: 757116, 614108
Change-Id: Iabd2104b2d1c38d474450978a712039819b038e6
Reviewed-on: https://chromium-review.googlesource.com/c/1273820
Commit-Queue: Lily Chen <chlily@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599362}

ios12-beta-simulator.json
ios12-sdk-device.json
ios12-sdk-simulator.json

CIPD packages:
  infra_internal/ios/xcode/mac  10o35n
  infra_internal/ios/xcode/ios  10o35n

Bug: 894202
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I3ef7bd7221911e0759c754f67d5764e66442ca7d
Reviewed-on: https://chromium-review.googlesource.com/c/1273822
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599361}

This is a reland of a12ef847

The reland has the following two fixes:
1- In the added tests, we wait for the ack of the GSB from the parent view to make
sure that GFS is processed after GSB has been bubbled to avoid the flakiness.
2- Early return in BubbleScrollEvent to avoid crbug.com/828422

Original change's description:
> Fling bubbles from OOPIF properly.
>
> While we are bubbling a scroll sequence GFS is sent to the fling controllers
> of both the oopif and the bubbling target. The fling controller of the oopif
> calls progressFling and generates a GSU with inertial phase, the GSU gets acked
> immediately before getting sent to the renderer since we are in bubbling mode.
> Then the oopif's fling controller receives the unconsumed GSU ack and generates
> a GSE to complete the scrolling sequence on the oopif. The bubbling target's
> fling controller receives and processes the GFS and generates GSUs which are
> sent to the target's renderer.
>
> If the GSE generated by the oopif's fling controller gets bubbled before
> the GFS, the bubbling target gets reset and the target does not receive the
> GFS. This cl fixes the issue by making sure that the events generated by the
> oopif's fling controller are not bubbled to the target. Also in case of
> GFS bubbling, the GFC should also get sent to the bubbling target to make
> sure that the fling controller in charge of flinging receives the GFC.
>
>
> Bug: 884728, 249063
> Test: BrowserSideFlingBrowserTest.[Touchpad|Touchscreen]FlingBubblesFromOOPIF
> Change-Id: I064944f125bebcb746f329af4cfb117f3be94ff0
> Reviewed-on: https://chromium-review.googlesource.com/c/1274193
> Reviewed-by: Kevin McNee <mcnee@chromium.org>
> Reviewed-by: Charlie Reis <creis@chromium.org>
> Commit-Queue: Charlie Reis <creis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599001}

Bug: 884728, 249063
Change-Id: I1528d904e84ff85f7828392c2b0178a42869d529
Reviewed-on: https://chromium-review.googlesource.com/c/1278963Reviewed-by: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599360}

GpuCrash_GPUProcessCrashesExactlyOncePerVisitToAboutGpuCrash

TBR: kbr@chromium.org
Bug: 878258
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I5ffe0fc31010f48838288a09b434235aedccb49b
Reviewed-on: https://chromium-review.googlesource.com/c/1278812Reviewed-by: James Darpinian <jdarpinian@chromium.org>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599359}

https://chromium.googlesource.com/angle/angle.git/+log/c97e3f6684c7..79b914075cc5


git log c97e3f6684c7..79b914075cc5 --date=short --no-merges --format='%ad %ae %s'
2018-10-12 geofflang@chromium.org Add an extension for querying esimated GPU memory size of resources.


Created with:
  gclient setdep -r src/third_party/angle@79b914075cc5

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:892288
TBR=fjhenigman@chromium.org

Change-Id: Ie496f14e30e485e0989a6c16cd6be3563606d8c7
Reviewed-on: https://chromium-review.googlesource.com/c/1279093Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599358}

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I177e442e2ff39995e10d494b1a99894a5724609e
Reviewed-on: https://chromium-review.googlesource.com/c/1278544Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599357}

Bug: 879643
Change-Id: I5f61315dc5172d329f9dc94f851d34800ee5f76f
Reviewed-on: https://chromium-review.googlesource.com/c/1278062Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599356}

The experimental feature is dead code that is recently being cleaned up.

Effectively, this patch reverts commit
0b0d3249 and follows up with further
cleanup given that it's the last user of disabling dynamic registration
for sessions invalidations.

Bug: 649880
Change-Id: I8a10c15a71353fd1c9c4bf670719f4a03e7f7a51
Reviewed-on: https://chromium-review.googlesource.com/c/1275847Reviewed-by: Nicolas Zea <zea@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599355}

I suspect https://chromium-review.googlesource.com/c/1264642 adding load:news:cnn:2018
has made we run out of test timing budget on CQ (16 minutes per shard), and
causing failure of telemetry_perf_unittest

Since 'load:news:cnn:2018' is to replace 'load:news:cnn', remove smoke testing
'load:news:cnn' to reduce test load

TBR=ulan@chromium.org
NOTRY=true # CQ flake

Bug: 893615
Change-Id: I8488aecf97cb25ff8ec9832c79bce7b10bc93c8d
Reviewed-on: https://chromium-review.googlesource.com/c/1277692
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#599354}

- Adds a message to provide users with a more detailed error message
  when SMB mounting to a file server that doesn't support SMBv2 or later.

Bug: chromium:887127
Change-Id: I9e2ff3c278bb014c5538082ddcba42c8556ba8f2
Reviewed-on: https://chromium-review.googlesource.com/c/1274608Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599353}

This CL make the following changes:
- Fixes a potential null-dereference crash when multiple rules couldn't be
  parsed.
- Instead of showing only a single install warning for multiple unparsed rules,
  show individual warnings. Limit the count to 5 warnings.
- The rule count exceeded warning doesn't override the rule unparsed warning
  now.

BUG=894275

Change-Id: Iac8db1cf927a9302ec9295501f84616efafeca4e
Reviewed-on: https://chromium-review.googlesource.com/c/1274838
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599352}

If root_ was destroyed while MenuPreTargetHandlerAura exists, then
MenuPreTargetHandlerAura would set root_ to null. This would result
in the pre-target-handler being removed from the wrong env.

I don't think this is the result of the bug referenced, but I came across
this in looking for bad pre-target handlers.

BUG=867035
TEST=none

Change-Id: Ic549cf306441e31dcd750665992e41f06416f295
Reviewed-on: https://chromium-review.googlesource.com/c/1279147Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599351}

Bug: 894362, 845079
Test: The back button works as history back when ARC IME doesn't show up.
Change-Id: Ibffbf39f02f9bc3c75c42b4091dce442046d48e2
Reviewed-on: https://chromium-review.googlesource.com/c/1278511
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599350}

I've never been able to repro, but to me this looks like long
clicking while we're in the middle of tearing down the activity somehow.

The quick bandaid fix is to catch the BadToken exception, but hopefully
we'll be able to do something more graceful with the MVC refactor.

This moves the logic to the Coordinator to avoid the 3 delegate calls
and minimize it to one (and reduces the business logic in the view).

NOPRESUBMIT=true
BUG=881074

Change-Id: I611648abcfa9ba87c2fe0ecd63e212f1985e1834
Reviewed-on: https://chromium-review.googlesource.com/c/1278957
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599349}

There seems to be a regression on M70 head that get AccountInfo using
identity_manager->GetPrimaryAccountInfo() always return empty
hosted_domain field. Using signin_manager->GetAuthenticatedAccountInfo()
seems to be a more stable way.

Bug: b/116746192
Test: Local build
Change-Id: I8369787b4f8d33e63d4029705d9f3f02c1a0376d
Reviewed-on: https://chromium-review.googlesource.com/c/1278526Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599348}

Previously, the SQL query included site icons that were NULL or empty,
resulting in category tiles often having less than 4 site icons present.
This fix skips the empty icons, and grabs the next non-empty ones.

Change-Id: I314c78f1797769e598640d06162811e1672c2449
Reviewed-on: https://chromium-review.googlesource.com/c/1279155Reviewed-by: Peter Williamson <petewil@chromium.org>
Commit-Queue: Jonathan Freed <freedjm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599347}

Tbr: ellyjones@chromium.org
Bug: 828031
Change-Id: I3f492d5ed53aa30f3ce518464a5fcc96109c1e13
Reviewed-on: https://chromium-review.googlesource.com/c/1279205
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599346}

This is a refactor that simplifies using voice interaction observer

Bug: 870515
Test: locally compile and run
Change-Id: I60368068c1124e9f8d0a6901fff23c1eb5b05717
Reviewed-on: https://chromium-review.googlesource.com/c/1278862Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599345}

simple spelling/grammar fixes
renamed some functions

Bug: N/A
Change-Id: Ia753e830bbc06632e24a5812c970efda82110c5b
Reviewed-on: https://chromium-review.googlesource.com/c/1278286
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599344}

This reverts commit c43eba93.

Reason for revert: This broke http/tests/devtools/service-workers/service-workers-navigation-preload.js on the mojo bots:
Mojo Windows: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mojo%20Windows/18554
Mojo Linux: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mojo%20Linux/20553

Original change's description:
> Make DataPipeBytesConsumer support ReadableStream loading better.
> 
> This CL fixes some edge condition interactions when being loaded as
> a ReadableStream.  In particular, it:
> 
> 1. Properly distinguishes between the end of the DataPipe and a closed
>    DataPipe with bytes left to be read.  A ReadableStream that is not
>    actively draining the pipe could get closed too early.
> 2. Responses must support explicit completion in order to handle error
>    conditions properly.  This CL makes DataPipeBytesConsumer wait
>    for an explicit signal before closing.
> 3. Service worker navigation preload is updated to provide the explicit
>    completion signals.
> 
> Bug: 894815
> Change-Id: I8cff3de94aa2dcbc8deb4a9601a95c13b8ab94d9
> Reviewed-on: https://chromium-review.googlesource.com/c/1272715
> Commit-Queue: Ben Kelly <wanderview@chromium.org>
> Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599192}

TBR=kinuko@chromium.org,mek@chromium.org,yhirano@chromium.org,wanderview@chromium.org

Change-Id: Iddb6b2121a0b014b4b08c6ec64fc534820474010
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 894815
Reviewed-on: https://chromium-review.googlesource.com/c/1279194Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599343}

Fixing the next available field and adding comments,
to be synced with the server code.

Change-Id: I52d91d5ccbd1c79d61cb537e6f81a879a74d2a0b
Reviewed-on: https://chromium-review.googlesource.com/c/1277697Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Cr-Commit-Position: refs/heads/master@{#599342}

The keychain was re-authorized to support Chrome's new signing
certificate 18+ months ago. At this point, users who haven't re-launch
Chrome in 18 months are unlikely to do so, or need the keychain. This
removes the re-authorization code.

Bug: 893729
Change-Id: I75b5a40407d196adfa5c31996024b9bb278221a1
Reviewed-on: https://chromium-review.googlesource.com/c/1271935Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599341}

Only query it if the extension is enabled.

Bug: 894049
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I5c2be0c41c2361ef06381a7e73c2025baa63e191
Reviewed-on: https://chromium-review.googlesource.com/c/1275299Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599340}

Bug: 894927,867488
Change-Id: I8c92aa6b3561aed2efd6332a0b1cd3ecde8cdb9b
Reviewed-on: https://chromium-review.googlesource.com/c/1277695Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599339}

R=rch@chromium.org

Change-Id: Ie45a70cecf865edefa565bff8b8af1d51e0b0705
Reviewed-on: https://chromium-review.googlesource.com/c/1277582Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Victor Vasiliev <vasilvv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599338}

Bug: 890912
Change-Id: Idc11767c37580c540cbb741a4cce5cabc3a0f29f
Reviewed-on: https://chromium-review.googlesource.com/c/1277989
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599337}

Removes the explicit hard timeout on VR tests on Nougat. This makes it
instead use the default of 1 hour, which is the same as the Oreo bot and
should make the tests stop timing out after the recent addition of lots
of tests.

Change-Id: Icb290a23732977b305d6d0a779c69909e401f806
Reviewed-on: https://chromium-review.googlesource.com/c/1277884Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599336}

Cut-and-paste these classes into separate files, because their current
location is getting crowded.

Bug: 859152
Change-Id: I9bc9fe8225589f91ba1cbc9daaccfbe58288197f
Reviewed-on: https://chromium-review.googlesource.com/c/1277581Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599335}

This reverts commit 9846f362.

Reason for revert: Compile failure on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/GPU%20Linux%20Builder/134994

Original change's description:
> [Autofill] Save form submission button's title for FormData
> 
> Save a button title into FormData for crowdsourcing.
> 
> Title is inferred in two ways:
> Type 1) Value attribute of an <input type="submit">.
> Type 2) Text content of <button>
> 
> If there are several labels within a <form>, all labels are concatenated to collect more data. A delimiter depends on the type of <button>/<input>:
> $ <input type="submit">
> # <input type="button">
> & <button type="submit">
> % <button type="button">
> 
> The value is truncated if the length is more than 200. The same value is used for labels.
> 
> TODO: introduce title inference when there is no <form> tag.
> TODO: consider other types of elements as submit button (e.g. <input type="image">, <a>, <div>/<span>)
> 
> Bug: 850606
> Change-Id: I54783cfdd0134b3aec52e9404740a3e1495a8176
> Reviewed-on: https://chromium-review.googlesource.com/c/1272356
> Reviewed-by: Mike West <mkwst@chromium.org>
> Reviewed-by: Roger McFarlane <rogerm@chromium.org>
> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599333}

TBR=rogerm@chromium.org,kolos@chromium.org,mkwst@chromium.org

Change-Id: I5f72413c856b359045df86a532db24ad69922e0a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 850606
Reviewed-on: https://chromium-review.googlesource.com/c/1279163Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599334}

Save a button title into FormData for crowdsourcing.

Title is inferred in two ways:
Type 1) Value attribute of an <input type="submit">.
Type 2) Text content of <button>

If there are several labels within a <form>, all labels are concatenated to collect more data. A delimiter depends on the type of <button>/<input>:
$ <input type="submit">
# <input type="button">
& <button type="submit">
% <button type="button">

The value is truncated if the length is more than 200. The same value is used for labels.

TODO: introduce title inference when there is no <form> tag.
TODO: consider other types of elements as submit button (e.g. <input type="image">, <a>, <div>/<span>)

Bug: 850606
Change-Id: I54783cfdd0134b3aec52e9404740a3e1495a8176
Reviewed-on: https://chromium-review.googlesource.com/c/1272356Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599333}

We were submitting UMA every time we recorded a update time measurement,
but some metric, particularly ForcedStyleAndLayout, may run multiple
times per frame. In such cases we want the per lifecycle time, to make
it comparable to UKM data and to avoid considering lots of small updates
to be less bad than one big update.

R=vmpstr@chromium.org
BUG=869966

Only report UMA once per lifecycle update

Change-Id: If4eebd782b4d109b18a608ece2a351226bb74732
Reviewed-on: https://chromium-review.googlesource.com/c/1277549
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599332}

Various places that use the JNI functions for accessing array elements
directly either forgot to release the array elements afterward, or are
doing something that can be done with one of the array helpers in base.
Fix them up to behave properly.

Change-Id: Iab3fe07949c67c884d60f7ffaaf0bd0faf0f13dc
Reviewed-on: https://chromium-review.googlesource.com/c/1279005Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599331}