- 26 Jun, 2018 40 commits
-
-
Michael Spang authored
This shouldn't be needed as VulkanSwapChain is handling synchronization internally. And remove a missing calling to Destroy(). Bug: none Test: ozone_demo --enable-vulkan on X11 Change-Id: I8f4be6dcefef9757ca6e51d5d85b1ede99c8ff35 Reviewed-on: https://chromium-review.googlesource.com/1115731Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#570565}
-
Bailey Forrest authored
If a client wants to enable BLE scanning, it should take a ScanHandle. When all ScanHandles are destroyed, scanning will be disabled. This is to avoid clients from fighting with each other to determine if BLE scanning should be enabled or not. Bug: b/110432359 Test: cast_bluetooth_unittests, device_unittests, manual. Change-Id: I23dbded8a5e1bd2f687b70d5d594140b4a23df8e Reviewed-on: https://chromium-review.googlesource.com/1112585 Commit-Queue: Bailey Forrest <bcf@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#570564}
-
dpapad authored
Specifically fixing: CrSettingsCertificateManagerTest.All CrSettingsLanguagesPageTest.Spellcheck CrSettingsLanguagesPageTest.InputMethods CrSettingsLanguagesPageTest.LanguageMenu Bug: 738611 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ie79c53113577172fe6f55cecda9a22562606c9a5 Reviewed-on: https://chromium-review.googlesource.com/1114283 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#570563}
-
Vadim Shtayura authored
The new version understands CIPD_PROTOCOL=v2 env var which will be used to verify the new protocol works for everything before it becomes default. R=iannucci@chromium.org, dpranke@chromium.org, bsheedy@chromium.org BUG=801423 Change-Id: Ic169831f427d0d718c15dde8481d689e71776a68 Reviewed-on: https://chromium-review.googlesource.com/1115468Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Cr-Commit-Position: refs/heads/master@{#570562}
-
Peter Boström authored
Highlights the ToolbarButton inkdrop on platforms where focus rings are not used. Before this change toolbar buttons were not highlighted to reflect their focused state (outside of Mac where focus rings are used). Bug: chromium:856505 Change-Id: Iab3578ff75a12477afa11ce34a09836acc3514d9 Reviewed-on: https://chromium-review.googlesource.com/1115737Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#570561}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fb8e7ef84262..e58bd8a02b9c git log fb8e7ef84262..e58bd8a02b9c --date=short --no-merges --format='%ad %ae %s' 2018-06-26 devicentepena@webrtc.org AEC3: Reverb modeling: Including the freq shape of the tails when modeling the reverberation Created with: gclient setdep -r src/third_party/webrtc@e58bd8a02b9c The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:856636 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I6932ca0b3df1c430be9b54e9442bcdeaf8dec30d Reviewed-on: https://chromium-review.googlesource.com/1115409Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570560}
-
John Rummell authored
As there are only a few crashes from this CHECK, removing it. It appears that the crash happens due to the SharedBufferHandle not being able to be mapped into the current address space. Since this happens so infrequently, simply return a NULL frame and let upstream handle the error. BUG=829443 TEST=media_mojo_unittests pass Change-Id: I645839d1975e9ec0629fe4ff29b91db8c52bf44b Reviewed-on: https://chromium-review.googlesource.com/1114346Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#570559}
-
Kenneth Russell authored
LUCI-deployed trybots show up automatically in the Gerrit UI at this point. Bug: 855660 Tbr: ynovikov@chromium.org Change-Id: I51b3ae05e30905fb03d5034098e79409043431ed Reviewed-on: https://chromium-review.googlesource.com/1115808Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#570558}
-
danakj authored
Fishing for mis-use of DisplayResourceProvider causing a crash in DeclareUsedResourcesFromChild(). It seems that the DisplayResourceProvider has a resource in the child_to_parent_map that it doesn't have in its resource set. This means it was already deleted or the child id is wrong or something. From reading the code this points to misuse of the DisplayResourceProvider for me, but to help narrow down, adding some DCHECKs to deal with invalid child ids. R=piman@chromium.org Bug: 855785 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I8ab0d6e6f6651f710b57d5848225a92eab3409cf Reviewed-on: https://chromium-review.googlesource.com/1115366Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#570557}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7269fa01fb54..38bc56124fb4 Created with: gclient setdep -r src-internal@38bc56124fb4 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie70eb9dd83b8e002ebc7ac239afb04665a64a947 Reviewed-on: https://chromium-review.googlesource.com/1115678Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570556}
-
wutao authored
This cl adds two missing navigation shortcuts to the shortcuts viewer. Bug: 845578 Test: manual. Change-Id: I7c645fc8d5252eeed9bd16890c6ba3cfc37f19aa Reviewed-on: https://chromium-review.googlesource.com/1115761Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#570555}
-
Matt Wolenetz authored
Renames this method, and renames its |type| parameter to |content_type|. Similarly renames ChunkDemuxer::AddId, ChangeType, and static helper methods' |type| parameter to |content_type|. BUG=605134 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I8b94452732a39157b5ddeba9e563f69aee033690 Reviewed-on: https://chromium-review.googlesource.com/1115704Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#570554}
-
Daniel Murphy authored
R=pwnall@chromium.org Bug: 781955 Change-Id: Ia39eabba795cd4afec8bfec7cb49e763ce9bbb72 Reviewed-on: https://chromium-review.googlesource.com/1114312Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#570553}
-
Pete Williamson authored
Bug: 842801 Change-Id: I69b9942765d7fb534e549872ce86abbe2f45a577 Reviewed-on: https://chromium-review.googlesource.com/1108478 Commit-Queue: Peter Williamson <petewil@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#570552}
-
Mike Wittman authored
Flakily times out on Chromium OS ASan and Windows. Bug: 512431 Change-Id: I358abf93cd6225a44477e1a83e1814ed4eb3b1da Reviewed-on: https://chromium-review.googlesource.com/1113916Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#570551}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/0a6dbeffbc61..c4dce690f433 git log 0a6dbeffbc61..c4dce690f433 --date=short --no-merges --format='%ad %ae %s' 2018-06-26 tsepez@chromium.org Use pdfium::span<> in cpdf_fontglobals.h 2018-06-26 hnakashima@chromium.org Assert that tab width assumption holds in CFX_RTFBreak. Created with: gclient setdep -r src/third_party/pdfium@c4dce690f433 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:844367 TBR=dsinclair@chromium.org Change-Id: I6ac929ade18a91057a923cfaa74a1f046f472b1b Reviewed-on: https://chromium-review.googlesource.com/1115411Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570550}
-
Varun Khaneja authored
R=jialiul Bug: 855202 Change-Id: I100381590c3d87b5aeae8711abe2a38c8a28d8a5 Reviewed-on: https://chromium-review.googlesource.com/1110949 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#570549}
-
kylechar authored
Remove code for creating a RootCompositorFrameSinkImpl from FrameSinkManagerImpl. FrameSinkManagerImpl is already a complicated class and it just needs to be manage CompositorFrameSinks that have been created. The complexity of creating a RootCompositorFrameSinkImpl is now contained in the class itself. Add a static RootCompositorFrameSinkImpl::Create() that handles creating the BeginFrameSource, Display and RootCompositorFrameSinkImpl. Move all BeginFrameSource creation into this one function. Also split the intialization of RootCompositorFrameSinkImpl so it can be created before a Display exists. Bug: 856705 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I5b24658232c40d5f4c7801cf6562611eb4a2c996 Reviewed-on: https://chromium-review.googlesource.com/1115340 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#570548}
-
Zhongyi Shi authored
Finch config for "migrate_sessions_on_network_change"(used by QUIC Connection Migration V1) is removed in https://chromium-review.googlesource.com/c/chromium/src/+/1060285. This change also removes unused methods. Bug: 843299 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Icc4642112a82158411078893e6780e77123e2cc2 Reviewed-on: https://chromium-review.googlesource.com/1114085 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#570547}
-
David Tseng authored
- capital personality was tuned for Google tts some years ago. It is too high for the current engine - re-do precedence logic. Do not set speech props if they were supplied by callers. Bug: 855257 Change-Id: I541021fa456c5283e943ecb71183e99c547a4f8a Reviewed-on: https://chromium-review.googlesource.com/1115517Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#570546}
-
Bin Wu authored
If a QuicConnection is writer blocked, always add it to the write blocked list. Protected by --quic_reloadable_flag_quic_add_to_blocked_list_if_writer_blocked. If --quic_reloadable_flag_quic_add_to_blocked_list_if_writer_blocked is true, QuicConnection::ProcessPacket will also add the connection to write blocked list if it is write blocked, and will not attempt to write before the writer unblocks. Merge internal change: 201524024 R=rch@chromium.org Bug: 848178 Change-Id: I2e7087ccb6fe11d575ceb7bea57fbaa9b1aeb68c Reviewed-on: https://chromium-review.googlesource.com/1114923Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Bin Wu <wub@chromium.org> Cr-Commit-Position: refs/heads/master@{#570545}
-
Manu Cornet authored
* Add close buttons * Wire up events for previews and close buttons * Introduce a WindowPreview class and observer interface * Add base methods so that the tooltip manager can delegate some event handling to individual tooltips. The "default" type of tooltip remains simple and non-interactive (no change in behavior). Bug: 834392 Change-Id: I174c166fc1c3f50580448420af7bb1a71ab6a65d Reviewed-on: https://chromium-review.googlesource.com/1090852 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#570544}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/83a57e01cd02..7ccf2f0c21b3 git log 83a57e01cd02..7ccf2f0c21b3 --date=short --no-merges --format='%ad %ae %s' 2018-06-26 ehmaldonado@chromium.org gclient: Report what dependencies were not processed. Created with: gclient setdep -r src/third_party/depot_tools@7ccf2f0c21b3 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:853010 TBR=agable@chromium.org Change-Id: I2114a967bdc99da371523385f2b019141c4575dd Reviewed-on: https://chromium-review.googlesource.com/1115414Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570543}
-
Christian Fremerey authored
[Video Capture Service, ChromeOS] Separate startup of CameraHalDispatcher from instantiation of VideoCaptureDeviceFactory Separate startup of CameraHalDispatcher from instantiation of VideoCaptureDeviceFactory by extracting the startup calls from VideoCaptureDeviceFactoryChromeOS to MediaStreamManager (which is where VideoCaptureDeviceFactoryChromeOS gets instantiated in case the video capture service is not enabled). For ChromeOS builds that use the cros_camera_service for video capture, the CameraHalDispatcher must be started as part of Chrome startup. This startup has for now been tied to the instantiation of VideoCaptureDeviceFactoryChromeOS. With the move to the VideoCaptureService, the instantiation of VideoCaptureDeviceFactoryChromeOS no longer happens on Chrome startup, but instead happens on-demand and potentially more than once. Design Doc: https://docs.google.com/document/d/169LS3U0DD7hHpqZSli0gpCaCqE1eWN4QXFSIGoruPwQ/edit?usp=sharing Test: See test plan section in design doc. Bug: 820608 Change-Id: I257a9eaa6368144fd252e532d211dfa716e8c242 Reviewed-on: https://chromium-review.googlesource.com/1107008Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#570542}
-
Aaron Leventhal authored
The ax_dump_events tool is crashing when IA2 not supported on an object. This checks that the queryInterface succeeded and that we hold a non-null IA2 pointer, before trying to use the IA2 pointer. Bug: None Change-Id: I4e2e2b469b0d891eac920fac1273436d28702f85 Reviewed-on: https://chromium-review.googlesource.com/1115561 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#570541}
-
Parastoo Geranmayeh authored
When showing titles we check to see if it's the right form. While checking to see if two forms are identical, it's not a good idea to check for the actions, they may not be updated. Instead, we use the number of the fields in that form to make sure it's the right one. (Names are not unique.) Fixes: bbc, avon, northface, etc. Bug: 856739, 850292, 850251, 850248 Change-Id: Ia434715e54a30406872f1ff5aeee39c67b2948c5 Reviewed-on: https://chromium-review.googlesource.com/1115423 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#570540}
-
Nicolas Pena authored
This CL adds a UseCounter that tracks the two ways to use EventTiming explicitly: * getEntriesByType or getEntriesByName with event/firstInput. * Having PerformanceObservers of event/firstInput. Bug: 851484 Change-Id: I8c2af71d089dbbf7db87b94b8b5d9f56e1699998 Reviewed-on: https://chromium-review.googlesource.com/1115511Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#570539}
-
Sunny Sachanandani authored
Describes generation, verification, waiting, completion, and correctness of sync tokens. TBR=piman BUG=826541 Change-Id: Id087134081af41264140d640c90ea96843bdf678 Reviewed-on: https://chromium-review.googlesource.com/1114387Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#570538}
-
Kyle Horimoto authored
This class provides all RemoteDeviceRefs on the user's account which are eligible to become MultiDevice hosts. Bug: 824568 Change-Id: I32936f40c5fdcc8f9a9a0264a4f8d6d02da73341 Reviewed-on: https://chromium-review.googlesource.com/1115458Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#570537}
-
Evan Stade authored
Test: chrome --enable-features=Mash --ash-enable-v1-app-back-button Bug: 854704 Change-Id: I37217f18900c9f93c94ea7148de900f3d14564d5 Reviewed-on: https://chromium-review.googlesource.com/1114202Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#570536}
-
Tiger Oakes authored
Continuation of work in bug 646094. This CL was uploaded by git cl split. R=pavely@chromium.org Bug: 846456 Change-Id: I2d3ca825f9e312a9b4bb5c0addda69a1159b8de6 Reviewed-on: https://chromium-review.googlesource.com/1095990 Commit-Queue: Tiger Oakes <tigero@google.com> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#570535}
-
Eric Stevenson authored
We switched to D8 in 2e3db781, but it turns out that D8 doesn't support Java asserts. This CL updates D8 with a fix to allow our assertion-enabling code to work again. Bug: 856575 Change-Id: I8f0f239c40de503445bc6a24ad54449a6b5de18c Reviewed-on: https://chromium-review.googlesource.com/1115424Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#570534}
-
Tao Bai authored
This patch parses forms in AutofillHandler::OnFormsSeen(), so the code could be shared between chrome and WebView autofill. The parse is disabled in WebView autofill now. Bug: 849913 Change-Id: I25260fa87eb59c2cc2d9060a1d92acbca0254e84 Reviewed-on: https://chromium-review.googlesource.com/1108921Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#570533}
-
Khushal authored
The PaintCanvas API for drawing SkBitmaps has 2 short-comings when used with a recording canvas: 1) It re-generates a PaintImage with a new key for potentially same bitmaps. 2) It creates an internal SkImage wrapping this bitmap, which may incur a copy of the pixels if the bitmap is not marked immutable. Both of the above are also non-obvious from the API. Remove it and switch callers to use PaintImages instead. The main user of this is ui/, which already caches bitmaps for reuse in ImageSkiaRep. Also cache a PaintImage with it to ensure we use a stable key for the bitmap. R=danakj@chromium.org Bug: 851282 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0ef7e8db798778b52b74a96dbf1a143fbead2ba9 Reviewed-on: https://chromium-review.googlesource.com/1110950Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#570532}
-
Devlin Cronin authored
Add SecurityPolicy::RemoveAllOriginAccessWhitelistEntriesForOrigin() to remove all entries associated with a given origin. This simplifies the extensions code and is faaaar more efficient, since we don't have to construct <n> different origin entries and iterate over the list of possible matches. Instead, we just remove the entry from the map in its entirety. No behavior change is expected. TBR=slan@chromium.org Bug: None Change-Id: Ibb05221898d4a2539e1a687941526e7ecf09c72a Reviewed-on: https://chromium-review.googlesource.com/1105287 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#570531}
-
Robert Sesek authored
This could occur if a detached code signature file is shorter than its typical prologue. Bug: 826761 Test: unit_tests --gtest_filter=DMGAnalyzerTest.InvalidDetachedCodeSignature Change-Id: Ic11b12eb9ce7d7b787b7668af43e2c6ddb3abd52 Reviewed-on: https://chromium-review.googlesource.com/1114925 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#570530}
-
Michael Mitasev authored
Bug:848978 Change-Id: I71dcd04531b9d48d292e3bc3de879be8cf9b6b63 Reviewed-on: https://chromium-review.googlesource.com/1109583 Commit-Queue: Michael Mitasev <mitasev@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#570529}
-
Miguel Casas authored
This reverts commit 4db64ed1. Reason for revert: broke some bots (e.g. Mac FYI Experimental ... Intel) , see: https://bugs.chromium.org/p/chromium/issues/detail?id=848182#c3 Original change's description: > ShapeDetection: Start the minimum implementation of mojom::BarcodeDetection > > The new implementation is based on Mac OS Vision Framework[1] which recognizes > more barcode symbologies, then use the @available(macOS 10.13, *) in the barcode > detection provider to choose different implementation. > > Split original large CL[2] up in smaller subpatches including this CL. > > [1] https://developer.apple.com/documentation/vision > [2] https://chromium-review.googlesource.com/c/chromium/src/+/1088466 > > BUG=848182 > > Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win10_chromium_x64_rel_ng > Change-Id: I5cb8634240a35e52b3c0b696c1ccab9c24cd023e > Reviewed-on: https://chromium-review.googlesource.com/1107493 > Commit-Queue: Junwei Fu <junwei.fu@intel.com> > Reviewed-by: Miguel Casas <mcasas@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570336} TBR=reillyg@chromium.org,mcasas@chromium.org,junwei.fu@intel.com Change-Id: Ibde8b37fea960671a85bbaf8a4bae59614b50eef No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 848182 Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win10_chromium_x64_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1115638Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#570528}
-
Oriol Brufau authored
Unlike 'width' and 'height', 'inline-size' and 'block-size' were not considered to be layout dependent, and thus getComputedStyle could provide a wrong value. BUG=849855 TEST=external/wpt/css/css-logical/logical-box-size.html The test still has some failures because sideways writing modes have not been implemented yet (http://crbug.com/680331). Change-Id: I4ee8ed8b2cd575fb3ddd5226b23c6a4bb843b81f Reviewed-on: https://chromium-review.googlesource.com/1114966 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#570527}
-
Caleb Rouleau authored
When you send --remote-debugging-port=0 to Chrome, devtools chooses its own port and writes it to chrome::DIR_USER_DATA as a file named "DevToolsActivePort". Cast doesn't have a user data dir, so this CL writes the file to chromecast::DIR_CAST_HOME. The ability to specify a 0 as the port is needed to avoid the race condition of some other process binding to a port that you choose before Chrome gets a chance to bind to it. ChromeDriver switched to using DevToolsActivePort to fix a race condition: https://bugs.chromium.org/p/chromedriver/issues/detail?id=2161 ChromeDriver does not natively work with cast_shell, but you can pass a shell script as the chrome binary to ChromeDriver and then have the shell script write a symbolic link from DevToolsActivePort in the user-data-dir flag value that ChromeDriver provides to the DIR_CAST_HOME directory. Therefore, this change allows cast_shell to work with ChromeDriver again. Note that the "Devtools started: port=X" log is not needed since DevTools code logs something like "DevTools listening on ws://0.0.0.0:45447/devtools/browser/665edec7-dbee-4547-816e-1d5e0c4a5dd3" already. Bug: 854864, chromedriver:2161 Change-Id: I55c20881607d581f628840cdf906569807f541ca Reviewed-on: https://chromium-review.googlesource.com/1114378 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#570526}
-