- 02 Nov, 2019 21 commits
-
-
Toni Barzic authored
Inset app list main view bounds horixontally by shelf size when displaying app list with side shelf (to ensure app list content does not overlap with shelf). BUG=1020534 Change-Id: I2cbec885ad2c7c0095f77d1909f9f219020ac63f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895782 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#711957}
-
Julie Jeongeun Kim authored
This CL converts VideoEncodeAccelerator to new Mojo types using PendingReceiver, PendingRemote, Remote and SelfOwnedReceiver. Bug: 955171 Change-Id: I2b8acd2c1e9e2f033679d5574a183a3067e0ae8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886281Reviewed-by:
Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#711956}
-
Ken Rockot authored
This converts remaining users to the new DataDecoder API which does not depend on Service Manager. Bug: 977637 Change-Id: Iaaa102f28ff63256a4c2090b6d6837085bb56103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892125 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#711955}
-
Yun Liu authored
Bug: 985581 Change-Id: I51700b131ff79f33dfc8ba5b19abe798d7bd6139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895884Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#711954}
-
Gyuyoung Kim authored
This CL converts remained old Mojo types of InterfaceFactory interface to new Mojo types. Major changes are as below, - Convert mojom::InterfaceFactoryPtr to mojo::PendingRemote|Remote<mojom::InterfaceFactory> - Convert mojo::InterfaceFactoryRequest to mojo::PendingReceiver<mojom::InterfaceFactory> - Convert mojo::Binding to mojo::Receiver Bug: 955171 Change-Id: I76bc67227ce76897ae321e23dd58932f0e2f88c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893600 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#711953}
-
Peter Boström authored
These strings aren't necessarily final but are probably closer to what we want. Putting these in so that we can get a better feel for them. Bug: chromium:943702 Change-Id: I2a003a8f85c87d3e3c3a15e1283be7cc9ea5ad7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894769 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#711952}
-
Sinan Sahin authored
On Android L, the tint we set to the EditText's background (line under the text field) wouldn't get cleared after leaving the activity. Turns out this is a known issue. So, we used a workaround found in Android TextInputLayout code. The workaround above also fixes an issue on KitKat where tinting the background wouldn't work at all. Bug: 1020077 Change-Id: I6fe5886ff5959a983dae43851ffcdca29b0d50a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895073 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#711951}
-
Daniel Hosseinian authored
The tests that validate the 'getPrinters' and 'getPrinterCapabilities' Web UI calls contain lines of code that can be used again once more tests are added. Remove some deprecated base::ListValue from tests. Bug: 487875 Change-Id: Ic49fc6b62ba44b3a548f026d68162446a852998e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893974 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#711950}
-
Ian Struiksma authored
In captured sites tests, we inject some javascript via WPR to check for element readiness on the page. After crrev.com/c/1884815, one password test (sign_up_fill/dreambox) has a page with unrelated javascript errors which caused frame.remove() to fail, so switching the frame destruction to use document.body.removeChild(frame) instead. Reran rest of test suite and verified passes for all password tests this way. Bug: 984664 Change-Id: I420427dc898affb62a0a200e59c72e470064dc92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895882 Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#711949}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/029ba5a777d6..e05bb7d9638b Created with: gclient setdep -r src-internal@e05bb7d9638b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I94cbb2e24e01c6f7ea0d0ca01324e77f1ec33281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896137Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711948}
-
Nathan Parker authored
Left over from pre-Pver4 code. Change-Id: I4a5845c7a216e485b710479a027ce9f742a008ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895964Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#711947}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ie42dec58aa302c1d97372e9117d202400da95eac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895891Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711946}
-
Matt Menke authored
Previously, it was only hooked up to the GPU process (Also the renderer process, though that doesn't use the same bindings). This was causing Features only read in the NetworkService process to not update corresponding FieldTrial state. Bug: 1018329 Change-Id: I94d2c15db86e0fb004c824f9cb66e0e6b6213942 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884823 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#711945}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f5eca592259a..5321943693c5 git log f5eca592259a..5321943693c5 --date=short --no-merges --format='%ad %ae %s' 2019-11-01 sky@chromium.org Disables enable_push_sync Created with: gclient setdep -r src/third_party/catapult@5321943693c5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: None Change-Id: I9dc2a51aa0d65e28b7ee21b643cc379032142743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895883Reviewed-by:
-
Ken Rockot authored
This adds new ParseXml() and ParseXmlIsolated() calls to the DataDecoder client API, which works without Service Manager. Media Router code and all other ParseXml clients are ported to use this API. MediaRouter is also moved off of SafeJsonParser. No net functional changes. Bug: 977637 Change-Id: I3a04a343d9f24747deeb9eac61df246d4e0129c2 Tbr: dmazzoni@chromium.org Tbr: tbarzic@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884593 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#711943}
-
Benjamin Beaudry authored
This change fills the font-family, font-size, font-weight, italic, bold and color attributes of the AXNode with exposed values from the PDFium APIs. I've also added a PDF accessibility tree dump test using the filter properties to dump those attributes in the expected file. The test file is "text-style.pdf". Somehow, I added in a previous change text-format-expected-blink.txt. This file should have never been committed. I removed it in this CL. Bug: 985604 Change-Id: I70a4729269aea69e184e61710d7977425b431704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755412Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Ian Prest <iapres@microsoft.com> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#711942}
-
Frank Tang authored
https://chromium.googlesource.com/chromium/deps/icu.git/+log/481b5ca7b..88ea42af73 88ea42a Sort variants in locale code. Bug: v8:9741 Change-Id: Iccd5d661d439babaae59f358059bd6c1bb1f0606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896236Reviewed-by:
Jungshik Shin <jshin@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#711941}
-
Eric Willigers authored
We define a new 'app.display_mode' key to record the display from the web app manifest. https://w3c.github.io/manifest/#display-modes Back and Reload buttons are only shown when a bookmark app is opened in a window, and 'display' in the web app manifest is minimal-ui or browser (or omitted). Equivalent functionality was recently implemented for BMO web_apps, after the design discussion summarized in https://docs.google.com/document/d/11E_gSSeJlECwvFqO_Tf-urmpYbx4c5MowHDC53xj0Ig/edit?usp=sharing TBR=ellyjones@chromium.org Bug: 1014346 Change-Id: I7dab174905e43f829a1b13bbe714d716ed8aeda1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888611Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#711940}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9faf2ee6c3b6..4d17287a4eae git log 9faf2ee6c3b6..4d17287a4eae --date=short --no-merges --format='%ad %ae %s' 2019-11-01 gbiv@google.com build_stages: remove a broken test assertion Created with: gclient setdep -r src/third_party/chromite@4d17287a4eae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I2405cb35380048aead051c09acc889eac298f4f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895890Reviewed-by:
-
Gary Kacmarcik authored
Add 2 command line options, one each to query the current state of the Accessibility and Screen Recording permissions. MacOS-only. Change-Id: Ic5a6323f71509327b4af00c56db15e8beb2bba8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874504Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Auto-Submit: Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#711938}
-
Peter Boström authored
Uses explicit deletion instead, removes use of base/macros.h. Bug: chromium:1010217 Change-Id: I907f74658c7667794d5c0ef7555104d5fb7cccbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895082 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#711937}
-
- 01 Nov, 2019 19 commits
-
-
Vladimir Levin authored
This patch implements intrinsic-size to work with a grid container. The general strategy is to treat intrinsic-size, if specified in a direction, as size containment in that direction while overriding the correct size. Adds tests for the both intrinsic dimensions specified, as well as only one specified and the other left as legacy to ensure that the correct override is picked in the code. R=rego@igalia.com, chrishtr@chromium.org Bug: 991096 Change-Id: I1eefda7ae5288442716eb19cf945770cba2f1dca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893734Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#711936}
-
Christopher Cameron authored
Change interfaces to use cc::PaintCanvas and SkIRect. Immediately convert back to gfx types. Touch up colors so that the diffs in layout tests will be minimized. Add code to paint the corner. Share this with the track painting code, and split the track painting code into helper functions for this purpose. Bug: 961835 Change-Id: I451f16711afce8e4a0bff5e963f1dc3e06f22410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896044Reviewed-by:
-
Xinghui Lu authored
Since some Android devices are more sensitive on network and data usage, we want to enable real time url lookup on high end devices first. Whether a device is high end or not is based on its system memory size. The memory size threshold is controlled by an experiment parameter. Bug: 1014202 Change-Id: I2dd399e71b35694b08ae0024140918d5e0d390ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893989 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#711934}
-
Alex Newcomer authored
In the future we will animate when the hotseat state changes. Ensure that the bounds are set before the state changes, so that the animations know where to animate to. Change-Id: Icad9b0d1024bbe5d10d00fc369439b2418c16963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896082Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Auto-Submit: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#711933}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/dd9ef1c0d58f..c3a91730e33e git log dd9ef1c0d58f..c3a91730e33e --date=short --no-merges --format='%ad %ae %s' 2019-11-01 tsepez@chromium.org Make CPDFSDK_Pageview observable across mouse move callbacks 2019-11-01 dhoss@chromium.org Remove jumbo usage in GN files throughout PDFium 2019-11-01 tsepez@chromium.org Run another embedder test with javascript disabled. Created with: gclient setdep -r src/third_party/pdfium@c3a91730e33e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: chromium:1017494 Change-Id: Ib0f25d57b2868bbec3fc46b5825d6085611dc284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896139Reviewed-by:
-
Jinsuk Kim authored
This CL handles the following issues on intestitial pages 1 - The links for privacy, support etc will be open in a CCT. This is accomplished by any time there is a request to open in new tab, we will use CCT. 2 - The link Back to Safety will go to the previous page. If there is no previous page, i.e. previous page is NTP, the preview tab will be closed. Bug: 1014689 Change-Id: I469fd4597800796bc1eaa47569012d9e937082c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868094 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#711931}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6751f171c662..8e083eee8ece git log 6751f171c662..8e083eee8ece --date=short --no-merges --format='%ad %ae %s' 2019-11-01 robertphillips@google.com Tighten up min and max vertex indices passed to GrTextureOp's meshes 2019-11-01 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-01 michaelludwig@google.com Progress towards consolidating aa mask and edge distances 2019-11-01 ethannicholas@google.com Revert "Implement sample mask and sample locations support in Vulkan" 2019-11-01 ethannicholas@google.com Implement sample mask and sample locations support in Vulkan 2019-11-01 kjlubick@google.com [canvaskit] Add relative SkPath operators 2019-11-01 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-01 robertphillips@google.com Revert "Reduce max # of AA Quads that can be merged or chained into a single GrTextureOp" 2019-11-01 borenet@google.com Revert "[recipes] Assert that Git is obtained from CIPD" 2019-11-01 senorblanco@chromium.org Dawn: update to recent texture proxy changes. Created with: gclient setdep -r src/third_party/skia@8e083eee8ece If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Bug: chromium:b/143572065 Change-Id: Id9323154e625a1afb52244869e82e64559905ded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896136Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c39a77883d7b..79d9e4b8508d git log c39a77883d7b..79d9e4b8508d --date=short --no-merges --format='%ad %ae %s' 2019-11-01 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@79d9e4b8508d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I1b2c3524e105cdcf69e20ce5a1bed7d4c1517e21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896138Reviewed-by:
-
shrekshao authored
Besides the implementation, there's little refactor happending for DisallowedFeatures struct as we triggered the complex class/struct explict out-of-line constructor conditions. Bug: 455150 Change-Id: I84e52c4818a8a95aa3c8cb08e5e08d0e6f75ac72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881482Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#711928}
-
Jonathan Freed authored
Bug: 1020661 Change-Id: I720511c79c6a161352223c8a7b610806af0f177f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895169Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Jonathan Freed <freedjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#711927}
-
Tim Judkins authored
Updates UserScriptListener which was using the Notification System to instead use UserScriptLoader::Observer. Also updates associated UserScriptListener tests. Bug: 268984 Change-Id: I5f686352be13d6223a5b6271047fc966c3486a9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874819 Commit-Queue: Tim Judkins <tjudkins@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#711926}
-
kylechar authored
Both gpu/shared-images/* and gpu/shared_images/* are used as the memory dump name for shared images. Other GPU code uses an underscore in dump names so use gpu/shared_images. Bug: none Change-Id: I03466b6ca43cd4d35e5227804d7de1125b3ac865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894465 Auto-Submit: kylechar <kylechar@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#711925}
-
Roberto Carrillo authored
The issue is that os.path uses backslashes when run on Windows, and makes it fail unittests. This change should make it so that it always uses forward slashes. R=sajjadm,martiniss,joenotcharles Bug: 1020240 Change-Id: Ie8637a23f6799d2d353971b7ce31c306edfaffa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894328Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#711924}
-
David Jean authored
This is a reland of 34445e49 CoreFoundations APIs usage was preserved since Cronet still requires 32-bit support. Original change's description: > [ios] Use posix TimeExploded > > With 32 bits build gone, iOS can use the posix implementation of > TimeExploded, which is faster. > > Bug: 985061 > Change-Id: Ic1d42ebddfa2d0bb0d37bb7b2086683914aa87a5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763679 > Commit-Queue: David Jean <djean@chromium.org> > Reviewed-by: Mark Cogan <marq@chromium.org> > Reviewed-by: Yuri Wiitala <miu@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: kylechar <kylechar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#691094} Bug: 985061 Change-Id: I42ee2b64a3ed7b6c3c98d1593cd4d762377f7b33 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856961 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
David Jean <djean@chromium.org> Reviewed-by:
-
Ben Pastene authored
The bot's served its purpose. Bug: 989314 Change-Id: Ia4a961453cb9e993ef54da2048129b4ba472b8a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896116 Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by:
-
Aleks Totic authored
CellPreceding and CellAbove were only used to determine if this was the first cell in the table. Bug: 958381 Change-Id: I372331b7a9534200ae7f060a5b67d91d9bd7ec49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896036 Auto-Submit: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#711921}
-
Daniel Rubery authored
This CL extends the following metrics: SBDownloadFeedback.UploadResult SBDownloadFeedback.SizeSuccess SBDownloadFeedback.ActiveFeedbacks SBDownloadFeedback.SizeFailure There is planned work to make uploads more reliable, which will be tracked by improvements in these metrics. Bug: 988669 Change-Id: Ifb49101e348e95ce09a9fed8e54c6b193e0d903b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895388Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#711920}
-
Jinsuk Kim authored
This CL restores the missing scrim when there is a single entry on the navigation sheet. The repro step is unique in that it's the only situation where the sheet with a single entry "Show full history" is displayed. All the others show at least 2. The scrim didn't appear since BottomSheet didn't trigger the event |onSheetOpened|. The minimum swipable state is set to peek(https://crrev.com/c/1880495), but the sheet height with a single entry is smaller than that of the peek state (1.5 x entry height), therefore didn't meet the condition that fires the event. To address the issue, following changes were made: 1) BottomSheetContent disables peek/half state for this occasion so that the sheet can go straight to full state. 2) Skip calling |expandSheet| but used BottomSheetContent state info to have the same effect. The explicit call to the API, when combined with the above change, causes the same state transition (full -> full), which cancels the animation effect. Bug: 1020408 Change-Id: I2b9d3d2f495a167dd844be82b9796bfeeb2fda81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893129Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#711919}
-
Joey Arhar authored
Form submission stopped working after crrev.com/c/1850358 when using event.preventDefault() and form.submit() in a click event handler for a <button type=submit> when the button has child elements and the click was made on one of the child elements. Bug: 1020086 Change-Id: I8976298ac56a64ff7033cb2f7b46ee5116229464 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896050Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#711918}
-
