GitLab

We want to show extension message bubbles on multiple platforms;
the first step towards this is to make the bubble factory
platform-abstract. Do so, and also add a handful of tests for the
process of showing the bubble.

BUG=474092
TBR=sky@chromium.org (no relevant changes since original land)

Review URL: https://codereview.chromium.org/1087713002

Cr-Commit-Position: refs/heads/master@{#325269}

Revert of Revert of Small refactor around futex.h. (patchset #1 id:1 of https://codereview.chromium.org/1084173003/)

Reason for revert:
Sorry, mistake on my part, this CL isn't the cause.

Original issue's description:
> Revert of Small refactor around futex.h. (patchset #1 id:20001 of https://codereview.chromium.org/1076213002/)
>
> Reason for revert:
> Breaks ChromeOS veyron_jerry boot.
>
> BUG=477352
>
> Original issue's description:
> > Small refactor around futex.h.
> >
> > This is the preparation of seccomp-bpf implementation
> > for nacl_helper_nonsfi.
> > PNaCl toolchain does not provides linux/futex.h.
> > This CL is the preparation to reuse android_futex.h
> > for PNaCl toolchain, too.
> >
> > TEST=Ran bots.
> > BUG=358465
> >
> > Committed: https://crrev.com/3b996212fa3c92af3233246ae54af728eb7c3591
> > Cr-Commit-Position: refs/heads/master@{#324996}
>
> TBR=mdempsky@chromium.org,hidehiko@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=358465
>
> Committed: https://crrev.com/4c05c94295ee26adffe966678719085f02b15f2f
> Cr-Commit-Position: refs/heads/master@{#325265}

TBR=mdempsky@chromium.org,hidehiko@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=477352

Review URL: https://codereview.chromium.org/1088253002

Cr-Commit-Position: refs/heads/master@{#325268}

Toggling the bookmarks bar changes the height of the browser window
when viewing a regular web page but does not change its height when
viewing a NTP. As a result, it is possible for the browser window to
creep taller or shorter with the right sequence of steps. When the
browser window gets shorter, it's possible to decrease its height to
0.

This change does not address the difference in behavior between NTPs
and regular web pages with the bookmarks bar, but it prevents the
browser window from programmatically dropping below its min height.

Added a unit test, and also had to adjust a unit test that created browser
windows with a height < 200 (min height for a browser window is 272).

BUG=230400
TEST=Create a browser window, confirm that View -> Always Show Bookmarks
Bar is checked, navigate to www.google.com, resize the window to its
minimum height, choose View -> Always Show Bookmarks Bar - the browser
window's bookmarks bar should disappear, but the browser window's height
should not change.

Review URL: https://codereview.chromium.org/1052123006

Cr-Commit-Position: refs/heads/master@{#325267}

Prevent the software encoder to accept odd sized video frames by
reusing the same constraints applied to frames allocated by
media::VideoFrame.

BUG=455409

Review URL: https://codereview.chromium.org/1085003002

Cr-Commit-Position: refs/heads/master@{#325266}

Revert of Small refactor around futex.h. (patchset #1 id:20001 of https://codereview.chromium.org/1076213002/)

Reason for revert:
Breaks ChromeOS veyron_jerry boot.

BUG=477352

Original issue's description:
> Small refactor around futex.h.
>
> This is the preparation of seccomp-bpf implementation
> for nacl_helper_nonsfi.
> PNaCl toolchain does not provides linux/futex.h.
> This CL is the preparation to reuse android_futex.h
> for PNaCl toolchain, too.
>
> TEST=Ran bots.
> BUG=358465
>
> Committed: https://crrev.com/3b996212fa3c92af3233246ae54af728eb7c3591
> Cr-Commit-Position: refs/heads/master@{#324996}

TBR=mdempsky@chromium.org,hidehiko@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=358465

Review URL: https://codereview.chromium.org/1084173003

Cr-Commit-Position: refs/heads/master@{#325265}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/f91e676..ddb714b

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review URL: https://codereview.chromium.org/1068483003

Cr-Commit-Position: refs/heads/master@{#325264}

[PATCH 1] : This Patch
[PATCH 2] : https://codereview.chromium.org/908483002/

BUG=223927

Review URL: https://codereview.chromium.org/1036823003

Cr-Commit-Position: refs/heads/master@{#325263}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5778f6a..4127337

TBR=mlamouri@chromium.org,dcheng@chromium.org

Review URL: https://codereview.chromium.org/1088183002

Cr-Commit-Position: refs/heads/master@{#325262}

UMA shows StartWorker fails more than expected, but most errors are just
the generic START_WORKER_FAILED. Use a more specific error when appropriate.

This has some user-visible behavior change in the error message that register()
rejects with. For example, a syntax error used to fail with "ServiceWorker failed
to install"; now it fails with "ServiceWorker script evaluation failed".

A Blink layout test is added for error messages, which didn't have test
coverage previously.

BUG=448003
TEST=https://codereview.chromium.org/1058323004

Review URL: https://codereview.chromium.org/1063823005

Cr-Commit-Position: refs/heads/master@{#325261}

The tab on the left side should be selected when scrolling to left and vice versa.

BUG=365501
TEST=Prepare a mouse with horizontal-scrolling feature, open multiple tabs, place cursor over tab strip and try to switch tabs.

Review URL: https://codereview.chromium.org/1084903002

Cr-Commit-Position: refs/heads/master@{#325260}

1) Window A belongs to user1 and is shown for user1. Minimizes window A.
Switch to user2, window A can not be activated by user2.

2) Window A belongs to user1 and is shown for user2. Then windowA can be activated
by user2 but cannot be activated by user1.

Also add unit tests for these two cases.

BUG=471858
TEST=manually tested

Review URL: https://codereview.chromium.org/1053013007

Cr-Commit-Position: refs/heads/master@{#325259}

SeparateHandler has been added to handle delete and undo commands when search box is active or focused.

BUG=462861

Review URL: https://codereview.chromium.org/1089163002

Cr-Commit-Position: refs/heads/master@{#325258}

BUG=454815

Review URL: https://codereview.chromium.org/1084223002

Cr-Commit-Position: refs/heads/master@{#325257}

BUG=477311
TEST=Open the find bar with Cmd-F.  The "Edit -> Paste and Match Style" menu item should not be greyed out and should paste properly when chosen.

Review URL: https://codereview.chromium.org/1048323003

Cr-Commit-Position: refs/heads/master@{#325256}

Touch events from evdev have a slot identifier to represent which
fingers are touched. Prior to this change this slot identifier was used
as the TouchEvent::touch_id_. However this breaks with multiple
touchscreens as the range for the slots will be the same.

This CL resolves that by using a SequentialIDGenerator to map a unique
device and slot id to an unused touch id in the sequence.

The touch id is released when the touch is released or cancelled.

BUG=472308
TEST=Manual testing on link_freon with uncommitted VLOG messages.

Review URL: https://codereview.chromium.org/1048333005

Cr-Commit-Position: refs/heads/master@{#325255}

This also adds filtering to AdbWrapper.GetDevices().

BUG=267773

Review URL: https://codereview.chromium.org/1088793002

Cr-Commit-Position: refs/heads/master@{#325254}

BUG=463546

Review URL: https://codereview.chromium.org/1045433002

Cr-Commit-Position: refs/heads/master@{#325253}

Cr-Commit-Position: refs/heads/master@{#325252}

There is no need in it because we have 'chromium_strings.h" already.

Please take a look at following topic https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/a2XQpRBrKNw

R=pkasting@chromium.org

Review URL: https://codereview.chromium.org/1085613002

Cr-Commit-Position: refs/heads/master@{#325251}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/c3c5990..f91e676

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review URL: https://codereview.chromium.org/1088433005

Cr-Commit-Position: refs/heads/master@{#325250}

The original code used 50 buckets for 100 count, so it wasn't possible
to know which index was being logged. This change switches to logging
the module index as if it were an enum, and labels the enum values for
friendlier analysis.

BUG=none
R=anthonyvd@chromium.org,asvitkine@chromium.org

Review URL: https://codereview.chromium.org/1083713002

Cr-Commit-Position: refs/heads/master@{#325249}

top_25_smooth (https://codereview.chromium.org/1052493004)
top_7_stress (https://codereview.chromium.org/1082363003)
tough_pinch_zoom_cases(https://codereview.chromium.org/1088003002)

(the links are trybot links of benchmarks that use the page set)

BUG=475090

Review URL: https://codereview.chromium.org/1058013005

Cr-Commit-Position: refs/heads/master@{#325248}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2f6bb82..5778f6a

TBR=mlamouri@chromium.org

Review URL: https://codereview.chromium.org/1066663004

Cr-Commit-Position: refs/heads/master@{#325247}

Official builds don't include strings for CHECKs, so don't check for text.
Right now, the test is failing like so when doing an official build:

..\..\google_apis\drive\drive_api_requests_unittest.cc(2000): error: Death test: request->Commit()
    Result: died but not with expected error.
  Expected: Check failed
Actual msg:

BUG=467929
TBR=hirono@chromium.org

Review URL: https://codereview.chromium.org/1052553004

Cr-Commit-Position: refs/heads/master@{#325246}

Chromium's has not built fts2 for a few weeks with no problems reported,
seems safe to remove the patches for M-44.

SQLITE_CORE was only needed to compile the fts2 files independently from
the amalgamation.

The README.chromium changes were leftovers from the big import that I'm
arbitrarily dropping here.

BUG=455817

Review URL: https://codereview.chromium.org/1073293002

Cr-Commit-Position: refs/heads/master@{#325245}

TEST=compile

Review URL: https://codereview.chromium.org/1085293002

Cr-Commit-Position: refs/heads/master@{#325244}

This re-sets the cursor after every mode change. It will ensure we
restore the cursor after returning from frecon.

BUG=471097
TEST=Ctrl-Alt-Forward in developer mode to activate frecon, then
  Ctrl-Alt-Back to return to chrome. Cursor is shown.

Review URL: https://codereview.chromium.org/1085123002

Cr-Commit-Position: refs/heads/master@{#325243}

Any time we destroy a HardwareDisplayController, we have to be careful
to dissociate it from any DrmWindow objects. Make a new RemoveController
funtion to handle this.

BUG=477129
TEST=Unplug HDMI display from panther on login screen. No crash.

Review URL: https://codereview.chromium.org/1072383003

Cr-Commit-Position: refs/heads/master@{#325242}

BUG=472144

Review URL: https://codereview.chromium.org/1077173002

Cr-Commit-Position: refs/heads/master@{#325241}

* Call GetSpdySessionKey in HttpStreamFactoryImpl::Job::DoCreateStream;
* minor refactor in HttpStreamFactoryImpl::Job::DoInitConnection;
* change HttpStreamFactoryImpl::Job::GetSpdySessionKey to not use
privacy_mode for proxy (DoCreateStream already behaved this way).

BUG=474217

Review URL: https://codereview.chromium.org/1063873003

Cr-Commit-Position: refs/heads/master@{#325240}

Updated the <webview> loadabort documentatin with the actual "reason" strings that are currently used.

BUG=470479

Review URL: https://codereview.chromium.org/1065873004

Cr-Commit-Position: refs/heads/master@{#325239}

Property IDs are not indexes, so we need to iterate over the properties
to find the correct one.

BUG=442317

Review URL: https://codereview.chromium.org/1035523004

Cr-Commit-Position: refs/heads/master@{#325238}

0x0 window sizes can be invalid and may cause GL errors.

BUG=471550

Review URL: https://codereview.chromium.org/1057013002

Cr-Commit-Position: refs/heads/master@{#325237}

CompilerInstance::createOutputFile started returning a
raw_pwrite_ostream, which is a super-class of raw_fd_ostream.
We don't really care about the flavour of raw_ostream in JSonWriter,
so just use the base class.

BUG=476343
NOTRY=true

Review URL: https://codereview.chromium.org/1085233002

Cr-Commit-Position: refs/heads/master@{#325236}

Isolate TaskQueueManager inside SchedulerHelper so that classes that
embed SchedulerHelper don't end up adding dependencies to
TaskQueueManager in a uncontrolled way.

No functional changes.

Review URL: https://codereview.chromium.org/1059323003

Cr-Commit-Position: refs/heads/master@{#325235}

WebRTC 8999:9005
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/b74b769..c49056d

Libjingle 8994:9001
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/2a568fa..1d4447b

TBR=tommi
BUG=

Review URL: https://codereview.chromium.org/1089543003

Cr-Commit-Position: refs/heads/master@{#325234}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/33c31b1..2f6bb82

TBR=mlamouri@chromium.org

Review URL: https://codereview.chromium.org/1089463004

Cr-Commit-Position: refs/heads/master@{#325233}

This patch actually integrates the Web Notification database with the
existing code paths, which means that it will be used for any persistent
notification being shown from this patch forward.

The database is completely tested with a series of unit tests, whereas
all existing browser tests, layout tests and instrumentation tests will
continue to exercise the full flows.

Please mind that this is the first part in a series. I realize that
there's a fair amount of TODOs in the code. Resolving these takes larger
refactorings (in case of reducing PlatformNotificationService
knowledge) or three-sided patches (in case of the Blink API). These
will be addressed in follow-ups.

Design document:
  http://goo.gl/TciXVp

BUG=447628

Review URL: https://codereview.chromium.org/1026853002

Cr-Commit-Position: refs/heads/master@{#325232}

BUG=425698

Review URL: https://codereview.chromium.org/1068223002

Cr-Commit-Position: refs/heads/master@{#325231}

The chrome profiler opens file without utf-8 encoding, so the html
trace file was not getting generated. This CL changes the file opening
to have utf-8 encoding.

BUG=477295

Review URL: https://codereview.chromium.org/1068693003

Cr-Commit-Position: refs/heads/master@{#325230}