- 19 Jun, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/72e8dbac26a8..b76d781b4f8f 2020-06-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iaa8013143f22dc5b8fcdba5fc25375130e55a51e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253228Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780171}
-
Lachlan Ford authored
On Windows Core OS systems, the character limit for the app container name is 50 characters. Chromium currently supplies app container names > 50 characters. This change shortens the sandbox process names. Change-Id: Id64d511bd2eefeceeb89c52dbf6fde87ce7f82fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234995Reviewed-by:
James Forshaw <forshaw@chromium.org> Commit-Queue: Lachlan Ford <laford@microsoft.com> Cr-Commit-Position: refs/heads/master@{#780170}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I15704fa86d635972d483ef1b681b083c7ea4f6dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253462Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592513989-cb1b2e433544322a6e074399b2bf791e5b9da4e7.profdata to chrome-win32-master-1592528104-1ddf0a60ec7fe7a5cf7de6fddb41394c2841acdd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ic8653584b1b0117fac0aace1396c62719972b3d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253008Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2410c8498c0b..42bed4306e2e 2020-06-19 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-06-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-06-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-06-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ifc0e8e4fa0ad391f1e66c739dc2b6a243b9ec36a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253009Reviewed-by:
-
Alan Cutter authored
This is a simple rename in preparation to reuse EnqueueInstallAppFromSync for BMO sync install: https://chromium-review.googlesource.com/c/chromium/src/+/2251563 Bug: 1090227 Change-Id: I748dfe0c07803777924cdea0a841816c2e65249b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251558Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#780166}
-
Bo Majewski authored
Adds basic scaffolding for local file thumbnail generation: - Moves GetThumbnail function from private_api_drive to private_api_misc - Adds code that directs the flow of thumbnail generation based on file system type - Adds a place holder for local thumbnail generation. Bug: 903742 Change-Id: I4b4326d9b28b81a5b46266a7ee03dede5878119e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246209 Commit-Queue: Bo Majewski <majewski@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#780165}
-
Gang Wu authored
Bug: 948235 Change-Id: Ie2893e5a299ee22e62d2bfd3059dc1bd66d7774e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242655 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Ender <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#780164}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592517558-a22b1521d7c950615c0a9ff92ae71c12468f78b5.profdata to chrome-win64-master-1592524547-1d6c7cf94491bfcfe03077087e03362dbc4dc51a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I3dd857ea5ab81fe152c18c32fdf7f4800594dce4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253007Reviewed-by:
-
Austin Tankiang authored
Bug: 1096355 Change-Id: Ic9d65b748decae5e68882e1d78a66dd6702fb876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251559Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#780162}
-
Chris Cunningham authored
This CL allows multiple mojo requests to bind to the same InterfaceFactoryProxy. This is needed by WebCodecs VideoDecoder, which makes the request from blink/ anytime a decoder is instantiated from JavaScript. Historically MediaFactory has made the sole request for this interface and shared the binding between <video> tags. Change-Id: I058777803eded7e12fc4049332ae5073c4d7e839 Bug: 1094103 Change-Id: I058777803eded7e12fc4049332ae5073c4d7e839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246797 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#780161}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I343ae179c39d302627717311c89e200772a362d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253518Reviewed-by:
-
Alexander Surkov authored
Bug: 1096512 Change-Id: Ied51950e1c623b35b469318e2e4063e83e1644f3 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252601 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#780159}
-
nancylingwang@google.com authored
TODO: Modify IconCompression to IconType. Because IconCompression is used anywhere, so modify the enum name with a separate CL, so that we can use the new kStandard anywhere, hidden with the flag in that new separate CL. BUG=1083331 Change-Id: I74132ddcfbd2da976e76ec018c9fecf57424d90b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250143 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#780158}
-
Andrew Grieve authored
This is easier to follow then deriving it in the templates. Also changes webview expectations apk->bundle Bug: 1095654 Change-Id: I5952ee9a660e4f32b22ef4100fea2f231d9eb96d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245880 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#780157}
-
Chris Hall authored
Written collaboratively with Aboxhall and Meredithl. Change-Id: I9940811bf6f1d7517cefcb0d07cf410f6dba47ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228249 Commit-Queue: Chris Hall <chrishall@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#780156}
-
calamity authored
This reverts commit 8e4ff348. Reason for revert: Causing failures for VaryingFileSize/StorageQueueTest.WriteAndRepeatedlyImmediateUploadWithConfirmations/0 VaryingFileSize/StorageQueueTest.WriteAndRepeatedlyUploadWithConfirmations/1 VaryingFileSize/StorageQueueTest.WriteIntoNewStorageQueueAndUpload/2 See https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/83037 Original change's description: > Avoid running TLS destructors at background priority > > This CL is adding a ScopedThreadPriority that save the current > thread priority and restore it when leaving the scope. This is > required since it is possible to run code outside of the Run(...) > scope with Background priority. > > On Windows, this is causing shutdown hangs because the LoaderLock > can be held by a background thread while doing TLS destruction. > > > Without this fix, the DCHECK in the code run with Background priority > and fails: > > [9888:28656:0617/210735.064:FATAL:thread_local_storage.cc(331)] Check failed: PlatformThread::GetCurrentThreadPriority() != ThreadPriority::BACKGROUND (0 vs. 0) > Backtrace: > base::debug::CollectStackTrace [0x00007FF92445E7D2+18] (C:\src\chromium\src\base\debug\stack_trace_win.cc:284) > base::debug::StackTrace::StackTrace [0x00007FF9243668F2+18] (C:\src\chromium\src\base\debug\stack_trace.cc:203) > logging::LogMessage::~LogMessage [0x00007FF92437F094+148] (C:\src\chromium\src\base\logging.cc:605) > logging::LogMessage::~LogMessage [0x00007FF92437FE40+16] (C:\src\chromium\src\base\logging.cc:598) > base::internal::PlatformThreadLocalStorage::OnThreadExit [0x00007FF9244425FA+170] (C:\src\chromium\src\base\threading\thread_local_storage.cc:333) > RtlActivateActivationContextUnsafeFast [0x00007FF96440B583+291] > RtlActivateActivationContextUnsafeFast [0x00007FF96440B67F+543] > LdrShutdownThread [0x00007FF964408B8C+348] > RtlExitUserThread [0x00007FF9644436FE+62] > BaseThreadInitThunk [0x00007FF96240403C+28] > RtlUserThreadStart [0x00007FF964443691+33] > > Bug: 1096203 > Change-Id: Ibc011ac370dde4b6a872da6ac81938f52965a5a6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251199 > Commit-Queue: Etienne Bergeron <etienneb@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779932} TBR=gab@chromium.org,fdoray@chromium.org,etienneb@chromium.org Change-Id: I7b26100abe6bc5fc53a74d056a530175695d0378 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1096203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251570Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#780155}
-
Chih-Hsuan Kuo authored
Some internal code, e.g. unit tests, doesn't need to depend on the full browser implementation. simple_browser could be useful for them. Bug: internal b/159122768 Test: Build Change-Id: I0d9033753cbacc610f98b888b19a3dbcfd2ef5ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241392 Auto-Submit: Chih-Hsuan Kuo <chkuo@google.com> Commit-Queue: Chih-Hsuan Kuo <chkuo@google.com> Reviewed-by:
Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#780154}
-
Joao Victor Almeida authored
This CL clamps the scrolling deltas for percent-based scrolling. It is important for 2 cases: - Small scrollers can have too small deltas, making scroll be exaustingly slow. A minimum of 16 pixels can be set, as it is a commonly used value for default font size in many browsers and could match in many cases the text content inside the subscroller. - Large scrollers can have excessively large scroll deltas, so it will be limited by 12.5% of the viewport, that is the root scroller's expected scroll delta. For OOPIFs content, the viewport dimensions will be the iframe's. This is done as a part of the effort to port and enhance Edge-style scrolling into Chromium. Bug: 1039047, 1074066 Change-Id: Ia4e0849eef3820fa3dc32b71c20257e63451ed4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138493Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Commit-Queue: João Victor Almeida de Aguiar <joalmei@microsoft.com> Cr-Commit-Position: refs/heads/master@{#780153}
-
Matt Falkenhagen authored
* http/tests/loading/pdf-commit-load-callbacks.html * http/tests/history/client-redirect-after-push-state.html NOTRY=true Bug: 1093445, 1093497 Change-Id: If698f97577a7dfe781eb53753a973a367c092f5e Tbr: japhet@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251569Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#780152}
-
Ken Rockot authored
This is a reland of 002e0444 No changes other than disabling the test under MSan where it is broken and probably not worth fixing. Original change's description: > Support dynamic Mojo Core on Linux > > This introduces a new --mojo-core-library-path Content switch which > instructs Content to initialize each process with an implementation > of Mojo Core found in the referenced shared library rather than using > the version linked into the main binary. > > This allows for IPC interoperability between a Content embedder and > another application which provides its own copy of Mojo Core. > > Fixed: 1082473 > Change-Id: I1e50c505e91a53e60056a4b8c691d91728f7a5ea > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229664 > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#778002} Tbr: avi@chromium.org Change-Id: I6a2270c87c294455907fb369640b3be0819b2431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247166 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#780151}
-
Miyoung Shin authored
This CL moves PrerenderMode to prerender_types.mojom to pass it to Mojo interfaces This is a precursor CL to mojofy PrerenderMsg_SetIsPrerendering. Bug: 798712 Change-Id: Iaf37df449c0d9af2078934ab1a6d527c54b4611c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245992Reviewed-by:
Darin Fisher <darin@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#780150}
-
Alexey Baskakov authored
This is ok now: Sometimes we call FinalizeUpdate even if the shadow bookmark app doesn't exist. void WebAppInstallFinalizer::FinalizeUpdate( const WebApplicationInfo& web_app_info, InstallFinalizedCallback callback) { ... if (legacy_finalizer_ && is_synced) legacy_finalizer_->FinalizeUpdate(web_app_info, base::DoNothing()); } Note DoNothing(). Bug: 1096219 Change-Id: Ie9ea8dface8528e12d568505b6c66e09742167a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251865 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#780149}
-
Louis Collard authored
Also, transfer ownership as I am leaving Google soon. Bug: 1089295 Change-Id: I817c0f266065d099a98da26d14f5dfaeb0d41e50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241054 Commit-Queue: Louis Collard <louiscollard@chromium.org> Auto-Submit: Louis Collard <louiscollard@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#780148}
-
Lingqi Chi authored
IgnoreErrorsCertVerifier Code outside /services/network/ directly depends on |IgnoreErrorsCertVerifier|, which is non-public code. Since |IgnoreErrorsCertVerifier::MakeWhitelist()| and |IgnoreErrorsCertVerifier::SPKIHashSet| are all they need, split these two members from the original class and make them public. This CL also renames "MakeWhitelist" as "CreateSPKIHashSet" to meet the no whitelist rule. Bug: 1049894 Change-Id: Ifc5e9a117b726a0c4875a5137d0eb9b504ad9005 Tbr: blundell@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245420Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Lingqi Chi <lingqi@chromium.org> Cr-Commit-Position: refs/heads/master@{#780147}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=bindusuvarna@chromium.org Change-Id: I9f6936661c5e7e1f2b5f932f7455c18c7f385a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252742Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780146}
-
Alexander Surkov authored
Support dictionaries like {loc: 1, len: 1} in property filters, for example, SelectedText({loc: 1, len: 1})=*. Bug: 1096512 Change-Id: Ie4a73fca0bea8ba7e2a91b6e5105922ad8cae0be AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252458 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by: -
Yoshifumi Inoue authored
PaintControllerPaintTest.FullDocumentPaintingWithCaret This patch changes |PaintControllerPaintTest.FullDocumentPaintingWithCaret| to use |NGInlineCursor| to handle both |NGFragmentItem| and |NGPaintFragment| for preparation of enabling EditingNG. This patch is similar to the CL[1]. [1] http://crrev.com/c/2108423: [NGFragmentItem] Utilize NGInlineCursor in PaintControllerPaintTest.InlineRelayout Bug: 707656 Change-Id: I01dd91bcab0f59f23eb6770853ff37406199a231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251521 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#780144}
-
Olivier Li authored
The goal of this metric is to evaluate how fast batteries discharge for clients running Chrome from battery on macOS. This can be useful to look for regressions or to try to compare the power impact of a finch trial. Bug: 1093475 Change-Id: I9b4ad072b7ffd27fdf05a58844d90700ec9814fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240061 Commit-Queue: Oliver Li <olivierli@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#780143}
-
Collin Baker authored
This shows the in-product help promo for creating a new tab group when possible. Bug: 1022943 Change-Id: I3cb8fdc05d16a42bdc4c45c51e7e18874bdfb285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250788 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#780142}
-
Ahmed Fakhry authored
OverviewController used to handle OnAttemptToReactivateWindow() by treating the window "requested" for activation as if it's the window that gained activation (while actually activation didn't change). This lead to overview closing when the requested window for activation is a context menu (which is not activateable in the first place). It seems that OverviewController doesn't need to handle this event at all, so removing. BUG=1056541 Change-Id: Ic7d395bf448ca547b9173d5b153e55b90e3e5210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249125Reviewed-by:
Mitsuru Oshima (slow:gardening) <oshima@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#780141}
-
Fergal Daly authored
RenderFrameHostManagerTest.CrashFrameReloadAndCheckProxy currently fails and is set to return early when we have kSubframe. Bug: 1064944 Change-Id: I0c79f696548acaa11310dc9c49ad0a9d1221d480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249291 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#780140}
-
Yu Su authored
Change-Id: I655a83718ce87dc3583b5602eecd44861f2b1914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240069 Commit-Queue: Yu Su <yusuyoutube@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#780139}
-
Chih-Hsuan Kuo authored
//chromecast/browser should include //media/mojo/mojom:remoting to allow cast_browser_interface_binder.cc to include remoting.mojom.h. Bug: internal b/159302715 Test: Build Change-Id: I86d61bcf1ee38dd4f0cf47431653ad6b0bfe62f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249418Reviewed-by:
-
Yuwei Huang authored
Previously the bitrates are set from host experiment configs, which can only be set once before the session is connected, so any changes to the bitrates require restarting the session. This CL introduces a new control message for the client to alter bitrates after the session is connected. Bug: 1096197 Change-Id: I03eeb3a7951a1cc15a0e994ea995b6f7bc82511c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253241Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#780137}
-
Linkun Chen authored
Bug: None Change-Id: I8e3ebef733f47530f99916d7d4d9f48fcb05d326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249584Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Linkun Chen <lkchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#780136}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1592481559-9b531f50abff54ae1c92c78422a2cf2d21554f30.profdata to chrome-mac-master-1592524547-91f52ddd745cbca9c170dfb725dd8a14e0e7d1c6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I106bf80058f00606cba83cab1c47eb7a11a87e61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253005Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/974cfa9fbbdb..eb6824408d08 2020-06-18 capn@google.com Assert reserved binding entries aren't accessed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ifab1613e6d8b00ab79dd8f3e7173890a04f8c3ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252536Reviewed-by:
-
Lei Zhang authored
Avoid manually doing bitwise operation, now that base::IsAligned() exists. Also fix lint errors and some nits in modified files. Change-Id: I6836367a9af03295c61b6273752fb51bef46bd33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245690Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#780133}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/28c801fc37b8..d64d998b9f1f 2020-06-18 chiur@google.com Merge "Add vulkan render_subpass_index_mask to GpuRenderStageEvent" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Id0347872b152b34a055effe5ef6b7b18ac0afeb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253132Reviewed-by:
-
