GitLab

Put MultipartResponseDelegate into content namespace while at it.

BUG=338338
TEST=content_unittests
R=jam@chromium.org
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/384273003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283427 0039d316-1c4b-4281-b951-d872f2087c98

BUG=389369
R=darin@chromium.org

Review URL: https://codereview.chromium.org/393983004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283426 0039d316-1c4b-4281-b951-d872f2087c98

Also rearrange parameter order of Parameter.__init__ to match other
definitions (name comes first; I figure the ordinal should be second
also).

R=davemoore@chromium.org

Review URL: https://codereview.chromium.org/391003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283424 0039d316-1c4b-4281-b951-d872f2087c98

This was a regression caused by crrev.com/279513

BUG=393388
R=jamiewalch@chromium.org

Review URL: https://codereview.chromium.org/394093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283423 0039d316-1c4b-4281-b951-d872f2087c98

Maintain naming consistency with Blink wherein selection start and end indicate
proper and consistent ordering in the document.

BUG=279489

Review URL: https://codereview.chromium.org/379473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283421 0039d316-1c4b-4281-b951-d872f2087c98

Move the register preferences code for the demo mode detector to the correct location.

Need owners reviews for c/b/prefs and c/b/ui/webui/login.

R=merkulova@chromium.org, mnissler@chromium.org, nkostylev@chromium.org
BUG=None.

Review URL: https://codereview.chromium.org/381833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283420 0039d316-1c4b-4281-b951-d872f2087c98

TBR=marja, stevenjb, yosin
BUG=none

Review URL: https://codereview.chromium.org/382153006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283419 0039d316-1c4b-4281-b951-d872f2087c98

BUG=353936

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281292

Review URL: https://codereview.chromium.org/369833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283417 0039d316-1c4b-4281-b951-d872f2087c98

R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/393193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283416 0039d316-1c4b-4281-b951-d872f2087c98

Minor fixes to ash.gyp: remove tabs, convert sources/ excludes to sources!.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/390983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283415 0039d316-1c4b-4281-b951-d872f2087c98

BUG=377319
TBR=sgabriel
TEST=none

Review URL: https://codereview.chromium.org/392373003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283414 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jam@chromium.org
BUG=394368

Review URL: https://codereview.chromium.org/398053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283408 0039d316-1c4b-4281-b951-d872f2087c98

With this change the following mojom input
enum Shape {
  CIRCLE,
};

will generate the following C++:
enum Shape {
  SHAPE_CIRCLE,
};

instead of
enum Shape {
  CIRCLE,
};

This also changes expressions of the form Shape.SHAPE_CIRCLE to
Shape.CIRCLE in the Java and JS bindings.

BUG=343981

Review URL: https://codereview.chromium.org/389613007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283407 0039d316-1c4b-4281-b951-d872f2087c98

Some PDF tests have been crashing on windows in skpicturerecord.

https://code.google.com/p/chromium/issues/detail?id=394267

Seeing if this fixes it. If not, we try the skia roll.

> content: Enable impl-side painting on Windows.
> 
> BUG=169282
> 
> Review URL: https://codereview.chromium.org/392623003

TBR=reveman@chromium.org

Review URL: https://codereview.chromium.org/392333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283406 0039d316-1c4b-4281-b951-d872f2087c98

Shortly after launch, the system hotkeys are loaded and parsed. If a hotkey is
reserved by the system, it is not passed to the renderer. This allows system
hotkeys like (cmd + `) to work even if a flash plugin is selected.

Add a histogram to ensure that the system hotkey plist is being correctly
loaded and parsed.

BUG=383558
TEST=Open 2 Chrome windows. Navigate one to www.twitch.tv. The site should
include a flash plugin that automatically starts playing a video. Select the
flash plugin. The hotkey combination (cmd + `) should switch between the open
windows. The hotkey combination (cmd + L) should have no effect (it is a Chrome
hotkey, not a browser hotkey).

Review URL: https://codereview.chromium.org/370293004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283405 0039d316-1c4b-4281-b951-d872f2087c98

This moves classes and apis which are not associated with Resource
to their caller.  We invoke the GL methods directly instead of
wrapping them, and we move the ScopedGpuRaster class out of
ResourceProvider to its own file.

BUG=391190

Review URL: https://codereview.chromium.org/375303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283404 0039d316-1c4b-4281-b951-d872f2087c98

This CL makes the app list return to the previously displayed page when the
search box query is cleared.

BUG=349727

Review URL: https://codereview.chromium.org/377783006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283403 0039d316-1c4b-4281-b951-d872f2087c98

These are basically the longest generated names, and the trybots appear
to have shorter overall names than the buildbots, because try jobs pass
and then the builders break.

R=jvoung@chromium.org
TBR=binji@chromium.org, teravest@chromium.org
BUG= https://code.google.com/p/nativeclient/issues/detail?id=3846

Review URL: https://codereview.chromium.org/399523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283402 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283399 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Update SourceBufferStream and its unit tests to always expect valid durations. (https://codereview.chromium.org/379693002/)

Reason for revert:
This seems to have broken several layout tests:

event-attributes.html 
media-controller-time-clamp.html 
video-currentTime-delay.html 
video-currentTime-set.html 
video-duration-known-after-eos.html 
video-loop.html 
video-playbackrate.html 
video-played-collapse.html 
video-seek-past-end-paused.html 
video-seek-past-end-playing.html 
video-seek-to-duration-with-playbackrate-zero.html 

See for example this build:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6%20(dbg)/builds/16392

Original issue's description:
> Update SourceBufferStream and its unit tests to always expect valid durations.
> 
> This change fixes the SourceBufferStream unit tests so that they always
> provide valid durations for buffers that it passes to SourceBufferStream.
> I've also added code to SoureBufferStream to verify that it always gets
> buffers with valid durations.
> 
> Minor tweaks to test expectations were needed to compensate for the
> SourceBufferStream behaving differently when it got actual durations instead
> of using the durations it made up. In most cases I just used the duration
> the SourceBufferStream was ultimately using. In a few cases the duration
> the SourceBufferStream was generating didn't make any sense so I simply
> changed the expectations to match the new behavior.
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283365

TBR=wolenetz@chromium.org,dalecurtis@chromium.org,acolwell@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/392193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283390 0039d316-1c4b-4281-b951-d872f2087c98

In order to let RenderPass control allocation of DrawQuads, public DQ
constructors, and make all use of DQ::Create function to make_scoped_ptr
of public constructors.

Similar to 271683004, and follow 380893004.

BUG=344962

Review URL: https://codereview.chromium.org/398533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283389 0039d316-1c4b-4281-b951-d872f2087c98

Add a command line flag for activating this option page.

Design doc and mocks: https://docs.google.com/a/chromium.org/document/d/1oQwmj3AU4QYhTyGrYEGr6zaZhHUfx-wqUgEcQGbUU-U/edit

BUG=372607
TEST=Enable chrome://flags/#enable-website-settings and go to chrome://settings and click the the "Manage sites..." button under the "Web content" category (click Show advanced settings...). Verify that the list of sites are those granted for a given permission and that the list is searchable.

Review URL: https://codereview.chromium.org/380893005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283388 0039d316-1c4b-4281-b951-d872f2087c98

BUG=392693

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282555

Review URL: https://codereview.chromium.org/376383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283387 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/396023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283386 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=gfx_unittests --gtest_filter="PNGCodec*"

Review URL: https://codereview.chromium.org/397673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283385 0039d316-1c4b-4281-b951-d872f2087c98

R=viettrungluu@chromium.org
BUG=386893

Review URL: https://codereview.chromium.org/394763007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283384 0039d316-1c4b-4281-b951-d872f2087c98

This adds a full credential selection whenever a username element is clicked. Previously, if a username element was filled by either the user or the password manager, the user would have to erase the entire field to see the full list of credentials the user has. Now the user can click on the field at any point to get a full list of accounts. However, if the user starts typing again, then inline autocomplete takes over.

BUG=341474

Review URL: https://codereview.chromium.org/166043006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283383 0039d316-1c4b-4281-b951-d872f2087c98

BUG=384633
R=sky@chromium.org, darin@chromium.org, viettrungluu@chromium.org
TEST=RunLoopTest.NestedRun

Review URL: https://codereview.chromium.org/392063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283382 0039d316-1c4b-4281-b951-d872f2087c98

views::Widget::InitParams::parent is a NativeView, so these "parent"
types should match. Otherwise it only works on aura where they are both
aura::Windows.

BUG=390755

Review URL: https://codereview.chromium.org/365243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283381 0039d316-1c4b-4281-b951-d872f2087c98

This was previously reviewed in
https://codereview.chromium.org/381883002/

The original patch was reverted because it broke LSAN builder.
There were some undefined LSAN related symbols and linker
started complaining as we added -Wl,--no-undefined.

Now we do not set -fsanitize=* flags so we do not use sanitizer
tools in libc_free.nexe.

The original description:

There were two issues with clang:

- Clang emits .data.rel.ro.local for local struct values with
an initializer, which lets the linker to emit a few
relocation info.
- In debug build, clang uses memcpy to copy a structure with
five members. Neither -fno-builtin nor -ffreestanding did
not prevent this issue.
- In release build, clang translates for-loop based zero copy
to memset.

This patch initializes all structures without initializers
or copy. This patch works with GYP_DEFINES=clang=0.

To make sure we will not add memcpy or something in future,
we will build libc_free.nexe with -Wl,--no-undefined.

This also reverts

https://codereview.chromium.org/386543002

to enable the disabled tests.

BUG=392768
TEST=./out/Debug/browser_tests --gtest_filter='*NonSfi*Messaging*'

Review URL: https://codereview.chromium.org/391563003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283380 0039d316-1c4b-4281-b951-d872f2087c98

The window manager now handles root node resize by resizing its (two) toplevel nodes to match the initial layout. This is just an intermediate step towards generalizing window manager layout a little.

BUGi=393244

Review URL: https://codereview.chromium.org/383123006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283379 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283378 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Add domain-specific language for BPF policies (https://codereview.chromium.org/299743002/)

Reason for revert:
Suspected for sandbox_linux_unittests failures on Linux Tests (dbg)(2)(32) at http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29%2832%29/builds/14560

errors in
BPFDSL.MoreBooleanLogic
Actual test failure: ../../sandbox/linux/bpf_dsl/bpf_dsl_unittest.cc:117:(11) == ((*__errno_location ()))
BPFDSL.MaskTest
Actual test failure: ../../sandbox/linux/bpf_dsl/bpf_dsl_unittest.cc:206:(expect_errno) == ((*__errno_location ()))
BPFDSL.ElseIfTest
Actual test failure: ../../sandbox/linux/bpf_dsl/bpf_dsl_unittest.cc:235:(0) == (setuid(0))

output like
Value of: subprocess_exit_status
Actual: 1
Expected: kExpectedValue
Which is: 42

Original issue's description:
> Add domain-specific language for BPF policies
> 
> This CL adds basic support for equality testing of system call
> arguments, and conjunctive and disjunctive combinations of tests.
> 
> BUG=375497
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283350

TBR=mdempsky@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/391043003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283377 0039d316-1c4b-4281-b951-d872f2087c98

This is incompatible with the way xpc_dictionary_create_reply() works, which
may only be called once per message. This would inhibit forwarding messages,
since the receiver of the forwarded XPC message would not be able to reply.
Instead, replies now must be created explicitly via MessageServer::CreateReply().

BUG=382931
R=mark@chromium.org

Review URL: https://codereview.chromium.org/398563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283376 0039d316-1c4b-4281-b951-d872f2087c98

adb get-state is broken in Android L. Add a temporary workaround
so we can keep using managed_install while it is getting fixed.

Internal bug b/15881946
BUG=394042

Review URL: https://codereview.chromium.org/392983003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283375 0039d316-1c4b-4281-b951-d872f2087c98

This is a semi-revert of https://codereview.chromium.org/235753002/.

Since it seems that we are not using the ability of TilingData to
have a non-zero origin, having a Rect is not needed and less clear
what is going on.

R=ernstm@chromium.org
BUG=362668,386998

Review URL: https://codereview.chromium.org/389973004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283374 0039d316-1c4b-4281-b951-d872f2087c98

Currently there's a view/window type mismatch that Aura excuses because
they are the same type (aura::Window*). This doesn't work on MacViews.

For toolkit-views, CreateBrowserModalDialogViews(..) actually takes a
gfx::NativeWindow. However, for Cocoa, the confirm bubble is added as a
subview of the render view.

This changes chrome::ShowConfirmBubble() to accept both a NativeView and
a NativeWindow. Views ignores the view and Cocoa ignores the window but
it allows a toolkit-views build on Mac to call the Cocoa implementation
which is what we need to get started.

BUG=390755

Review URL: https://codereview.chromium.org/393763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283373 0039d316-1c4b-4281-b951-d872f2087c98

This way they can be used by the compositor or another consumer.

BUG=365454

Review URL: https://codereview.chromium.org/362863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283372 0039d316-1c4b-4281-b951-d872f2087c98

In an effort to see what percentage of the population has exceedingly large pref files.

BUG=355722

Review URL: https://codereview.chromium.org/391893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283371 0039d316-1c4b-4281-b951-d872f2087c98

Every resource takes an FD, so we want to limit this to avoid running out.

BUG=384654

Review URL: https://codereview.chromium.org/357423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283370 0039d316-1c4b-4281-b951-d872f2087c98