GitLab

Now that the event wait time has been increased, this test should be less flaky. Re-enable it accordingly.

Bug: 1124978
Change-Id: I221ea9cb96106801d9266e94447660c323ecdd97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567110Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Andrew Comminos <acomminos@fb.com>
Cr-Commit-Position: refs/heads/master@{#832622}

BUG=1154181

Change-Id: I8d8c056db57fc79ce8c5d11b7d8499b665a2fe84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567485
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832621}

This CL uses video.requestVideoFrameCallback to make sure a frame is
displayed before ending the test. It's possible this test might
still flake if the overflow menu doesn't show up on screen in time.

Bug: 1145491
Change-Id: Ic402b396cf49d9c2e6853a039e44f739bb2cc014
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567571
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Auto-Submit: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832620}

Currently in tablet mode, hotseat is shown by default when spoken
feedback is enabled. This behavior has caused an issue of blocking apps
content. This fix contains:
- Change the API in ShelfWidget for ForceToShowHotseat() to accommodate multiple calls. Also changed its name to ForceShowHotseatInTabletMode() since it only works in tablet mode.
- Not showing hotseat by default when spoken feedback is enabled.
- Make the drag handle become a button to show/hide hotseat (only when
spoken feedback is enabled).
- Add observer to the drag handle to observe changes in hotseat state.
- Apply the changes for ScrollableShelfView and use set_manually_extended() in HandleAccessibleActionScrollToMakeVisible() to avoid conflicts.

Fixed: 1136151
Change-Id: I1d9c12645978b14c8f13e062e145cf9006bc600d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541923
Commit-Queue: Andre Le <leandre@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832619}

This removes a usage of WidgetBaseClient from outside of WidgetBase,
by passing the main thread implementation of the mojom interface
FrameWidgetInputHandler through WidgetBase to the WidgetInputHandler
classes, and on to the FrameWidgetInputHandlerImpl. Then that class
can access the WebFrameWidgetImpl's version of the mojom interface
through the pointer.

R=dtapuska@chromium.org

Change-Id: I26286cab13cad88bcb906f4ec879834be676db32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563080
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832618}

A number of Android crashes have a non-detached LocalFrame but GetPage()
returns null. This CL adds a few CHECKs in IsProvisional(), which is one
place where this crash has been observed. It also adds a few CHECKs in
the FrameLifecycle state machine to make sure state isn't somehow being
rewound.

Bug: 1154141
Change-Id: I5b767ed3b7476a47a88831e40de1fceebb73e557
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567633
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832617}

The performance of the decoder with the intel hybrid driver [1]
is worse than a sw decoder especially when multiple decoders run
simultaneously. For instance, a video call app (e.g. Meet) likely
requires us to decode more than 10 smaller resolution videos.
The user experience is better by using sw decoders than the hw
decoder in these cases.
This CL selects sw decoder for QVGA and smaller resolutions by
setting the minimum supported resolution of the hw decoder to
321x241. This dimension is selected from the fact that the
resolutions of videos in tile layout in Google Meet are QVGA.

[1] https://github.com/intel/intel-hybrid-driver

Bug: b:171041334
Test: tast run webrtc.*
Test: SW decoder is used in https://appr.tc/?vsc=vp9&vrc=vp9&video=minWidth=320,maxWidth=320,minHeight=240,maxHeight=240
Change-Id: I9b19878aae57587bab921481d7dca5087d7f538b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494521
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832616}

Remove the reference to util.isFilesNg() to make easier to generate the
JS module because we're removing the support of running non FilesNg
version.

Add is_polymer3 option for js_test_gen_html.gni() to be able to closure
compile the unittest for Polymer elements.

Bug: 1133186,1152668
Change-Id: I6067d205ea962bc1fb1f1ee191eed356fc3bfd6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557886Reviewed-by: Jeremie Boulic <jboulic@chromium.org>
Commit-Queue: Jeremie Boulic <jboulic@chromium.org>
Auto-Submit: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832615}

https://webrtc.googlesource.com/src.git/+log/58678a0eb7a3..449a78b1e20e

2020-12-01 auorion@microsoft.com Prevent window enumeration deadlock and add unit tests.
2020-12-01 perkj@webrtc.org Add class InterArrivalDelta to goog_cc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1152841
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I4623c206190a22f417dcfd05632e23479bc87c24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566973Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#832614}

Pointer Capture was being rejected by chrome when an app came into
focus using keyboard shortcuts (Alt-Tab), but was working as intended
when an app came into focus using the mouse or touchscreen. It was being
rejected because the capture_surface was the sub-surface of the current
focused surface.

Since the client is responsible for providing the capture surface
through the wayland pointer constraints protocol, it is possible
for the client to request capture on a sub-surface of the current
active surface. Requesting capture on a sub-surface is a valid request
for capture. Rather than ensuring that the capture surface is focused
(used for directing key events), we verify that the active window
contains the window of the capture surface in its hierarchy before we
allow the pointer to be constrained to the surface.

This also allows the client to change the cursor while the client has
capture, even when the mouse cursor is not currently over a client
window.

BUG=b:153973515
TEST=manual: request pointer capture, leave app, return to app using
Alt+Tab, verify app has pointer capture.
TEST=exo_unittests

Change-Id: I56e76469f35ea43100748ebe27966464e32805fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559255Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Prabir Pradhan <prabirmsp@chromium.org>
Auto-Submit: Prabir Pradhan <prabirmsp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832613}

This helps Dawn create a dawn adapter using the given IDXGIAdapter
instead of loading every single backend and adapter available.

Bug: chromium:1036711
Change-Id: I67ef16b64393aa3521bbf188af7d9f5121480e7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296011
Commit-Queue: Natasha Lee <natlee@microsoft.com>
Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com>
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832612}

This was found by running the check from http://crrev.com/c/2567476.

Bug: 1154061
Change-Id: Ibcbdd2e8f2005b82cb784a2b16d34cbfc53bcb94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568223
Auto-Submit: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832611}

The secondary GPU was not populated with information taken from GL
strings after a GPU switch. This CL addresses this by re-querying
this information each time the GPU is switched.
The active GPU in dual-GPU systems is now computed in the GPU
process and communicated back to the browser process. The
heuristic GpuDataManagerImpl::UpdateActiveGpu has been removed.

Bug: chromium:1152212
Change-Id: Ie54dd5dc06c3d0a1c5f0445cc0f313adc8fa24cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560552Reviewed-by: Jonathan Backer <backer@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Cr-Commit-Position: refs/heads/master@{#832610}

VaapiWrapper reports the supported min and max resolutions by
VaapiWrapper::GetSupportedDec/EncodeProfiles(). They might be
different from the min and max resolutions supported by a
hardware and driver for some reason. For instance, we set
the minimum encoder resolution to 321x241 and the webrtc encoder
enforces the resolution per kWebRtcUseMinMaxVEADimensions
(e.g. crbug.com/1008491).
Clients of VaapiWrapper were expected to respect the supported
resolutions, but could still request values outside of that
range, thus using hardware codecs unintentionally. This CL
enforces the supported range in VaapiWrapper::CreateContext().
This also introduces a feature,
VaapiEnforceVideoMinMaxResolution, to disable this check for
testing.

Bug: b:171041334
Test: video.Play.vp9_hw on atlas and cyan
Test: video_decode_accelerator_tests on atlas and cyan
Test: video_encode_accelerator_tests on atlas and cyan
Test: appr.tc/?vsc=h264&vrc=h264&debug=loopback on atlas and cyan
Change-Id: Ide589ee4d1456553e400a271cb8b3383b472b4d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549161
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Auto-Submit: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832609}

This CL makes DCLayerTree to keep a Map for video processor which is
separated by SDR/HDR mode. The purpose is to prevent causing hardware
error when change VP from dealing HDR content to SDR content in some
Intel platform.

This CL also changes the place where setting colorspace of VP to
SwapChainPresenter::VideoProcessorBlt().

Bug: 1121061
Change-Id: I4a669750cb88d68d8655cb2d777c555b43ac3f5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539559Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: Richard Li <richard.li@intel.com>
Cr-Commit-Position: refs/heads/master@{#832608}

Autotest checks for gtest files to better determine if a give file is
actually a test file or not. However, because many files don't actually
include what they use, many test files don't directly include gtest.h,
gmock.h, or a test_utils.h file. Instead, they may include those via
something like sim_test.h, resulting in the script ignoring those files
right now.

This change improves that by still looking for files that include a
gtest file, but until it has found at least one file that does, it
will also collect files that match the test file name regex and do not
match the gtest include regex. Then, if no files are found with the
gtest includes, it will move forward under the assumption that the
file it found without the gtest include was the correct test file.

It will still prefer files with gtest includes, but has a fallback in
case none exist, providing a best effort chance at building and
running the tests.

Also includes a small improvement to outputting the file names that
it finds after a recursive file search.

Change-Id: Ia56792426b55cb17a43ffe2545b4deefb5dba0dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568710
Commit-Queue: Mario Bianucci <mabian@microsoft.com>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832607}

This CL implements LocalSearchServiceProxy and
LocalSearchServiceProxyFactory. It also fixes typos and pref names.

Design doc: go/lss-sandboxing
Implementation plan: go/lss-sandboxing-impl

Bug: 1137560
Change-Id: I115a801a52fd0ed398485dd9ea9caf089fddd789
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559477Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Jia Meng <jiameng@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Thanh Nguyen <thanhdng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832606}

We are deprecating TpmInitStatus signal by cryptohome.

BUG=b:172748724
TEST=unit_tests.
TEST=browser_tests.
TEST=tast run $DUTIP *RequiredClientCertificateForDevice*

Change-Id: Iebd2516e912433aa52ab4775a1e361801989a590
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563431Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Leo Lai <cylai@google.com>
Cr-Commit-Position: refs/heads/master@{#832605}

4 small fixes left over from previous code reviews.

Bug: 958381
Change-Id: Ie0718f273ab6656b01eca5af1930bd8111c2436f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566307
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832604}

This CL renames RecyclerViews which set
RecyclerView#setHasFixedSize(true) to suppress the
InvalidSetHasFixedSize lint error.

The lint error is thrown because the lint check gets confused when
multiple RecyclerViews have the same id. I have looked and it does
not seem possible to write a 100% accurate lint check or errorprone
check.

The lint check should be enabled because it caught a real bug
https://chromium-review.googlesource.com/c/chromium/src/+/2559556

BUG=1064277

Change-Id: I38420437ca81bd5b127bd8d456b67612be3ff713
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563866
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832603}

The data member is never read. This CL simplifies the code by removing
the member and the now-unused IsParamsForPwaCheck() function.

Bug: 976033
Change-Id: Idf1f4a1fc17ba5b36854940741d4162bd034a44e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567498
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832602}

LSSharedFileListItemCopyResolvedURL can operate with nullptr as its
CFErrorRef* argument. We can just check if it returned a non-null
CFURLRef, and simplify this code.

Tested: Manually on MacOS 11.0
 - Install extension from chrome/test/data/extensions/background_app/
 - Chromium should be set to run at login for user
 - Remove extension - chromium should no longer be set to run at login

Bug: 897302
Change-Id: If673ec9a53e99fcebe910e34ec50d88594debd39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561032
Commit-Queue: Mike Jackson <mjackson@microsoft.com>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832601}

File loading and app initialization are interleaved. Because
the test Exif file is small, the codepath taken when file loading
"wins" is taken in about 10% of test runs. RAW files need a delegate
to extract an image preview, and this wasn't being set on this codepath
until app initialization. This could cause the test to attempt to load
the RAW file as a JPEG, resulting in a "decode" error.

To fix, ensure a delegate is set along with the file list to load during
app initialization when that codepath is taken.

Bug: 1152318
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Change-Id: I12b37c3f6b6228c621fdb36f975200c74da5d227
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562921Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832600}

If the only reference to a ReadableStreamDefaultReader is from
javascript code that is used as fulfillment handler for its "read"
promise the reader can get garbage collected, resulting in the promise
never resolving. This fixes that issue by making
ReadableStreamDefaultReader implement HasPendingActivity to return true
if there are any pending read promises.

Bug: 1092048
Change-Id: Iccf2d6db453c6a27c82542af7a1dc1a2d792c3ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561043Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832599}

https://chromium.googlesource.com/infra/luci/client-py.git/+log/d46ea7635f29..1a072711d438

$ git log d46ea7635..1a072711d --date=short --no-merges --format='%ad %ae %s'
2020-11-30 tikuta client: update go clients
2020-11-26 yekuang client: update go clients
2020-11-25 tikuta Revert "client: update go clients"
2020-11-25 yekuang client: update go clients
2020-11-19 yekuang client: update go clients
2020-11-18 yiwzhang [logdog-client] Remove the trace of gevent
2020-11-16 yiwzhang [subprocess42] Poll process in short intervals when waiting on windows
2020-11-12 jwata [client] skip tests failing on windows
2020-11-09 yekuang client: update go clients
2020-11-05 yiwzhang [logdog-client] Replace FileObjectThread with FileObjectPosix
2020-11-02 tikuta [client] remove code handling command from run_isolated
2020-11-02 tikuta [client] remove raw-cmd usage for run_isolated.py
2020-10-30 tikuta client: update go clients
2020-10-30 tikuta [client] remove command from run_isolated_smoke_test.py
2020-10-28 tikuta [client] remove extra args from run_isolated.py
2020-10-22 tikuta client: update go clients
2020-10-21 yekuang [swarming] Remove --shards
2020-10-21 tikuta [client] run trim always
2020-10-21 tikuta [client] use bavail instead of bfree
2020-10-21 jwata [client] remove read_only from isolated format
2020-10-20 tikuta [client] apply cache trim with hint
2020-10-16 yekuang [client] Include initial isolated cache stats
2020-10-14 tikuta [client] remove unused files
2020-10-13 tikuta [client] handle digest for empty dir separately
2020-10-09 tikuta client: update go clients
2020-10-09 tikuta Copybara Service Migration Initialization.
2020-10-09 tikuta client: update go clients
2020-10-09 yekuang client: update go clients
2020-10-08 leilei Update collect to handle non-ascii character in task output.

Created with:
  roll-dep src/tools/swarming_client

Bug: 1142713
Change-Id: I09eb267c5939ebb3dccddad015c06a61fd5941a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567083Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832598}

Re-enable previously flaky tests that were fixed in crbug 1148061 with
CL: https://chromium-review.googlesource.com/c/chromium/src/+/2538150

Bug: 1152287
Change-Id: Icce97515a7c8a113aae8f91102db74a6c79cb071
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567504Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Commit-Queue: Roman Arora <romanarora@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832597}

This patch gets rid of |enum SelectionType| because most of usage can be
replaced with |IsRange()| to simplify source code for improving code
health.

Change-Id: Ibe73e8a6b98767191e3dcc25beea9a02311a3dc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566317
Commit-Queue: Kent Tamura <tkent@chromium.org>
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832596}

Currently, some key combinations, such as CTRL+V, is sent twice
from exo to wayland client via wl_keyboard::key and text_input::keysym.
Because, currently Lacros converts both to KeyEvent, so in Lacros
the KeyEvent is dispatched twice, which is unexpected behavior.

The long term solution is not to dispatch KeyEvent converted from
text_input::keysym in Lacros, and instead, call
TextInputClient::InsertChar directly.
However, this approach hits another issue. Currently, exo does
not send wl_keyboard::key event, if the delivered KeyEvent is
being consumed by IME. This is the workaround for ARC, and planned
to be removed in the near future.

So, to workaround consumed-by-ime filtering for the short term,
this CL introduces another filtering into text_input::keysym with
the reversed condition, so that, KeyEvent dispatching in Lacros
will become once.

BUG=1149371
TEST=Ran on DUT. Ran exo_unittests.

Change-Id: I64314dda4838ae611e3643dc0e16eace9cc6fcd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567283Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832595}

This reverts commit 72367c7a.

Reason for revert: Caused test failures: crbug.com/1154484

Original change's description:
> Fix frame generation timing
>
> Bug: 1150492
>
> Change-Id: Ifd8e735f5682ffc6f09ebcddc22f43cbcd5300ce
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562158
> Reviewed-by: Robert Flack <flackr@chromium.org>
> Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#832534}

TBR=flackr@chromium.org,oshima@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: Ib7281c1c6f0230beb68dfbc596622d263d7841b5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1150492
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567020Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832594}

Bug: 1142520
Change-Id: Ie584b49f19820c19f91a7b566f86fe6d3e1278f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566093Reviewed-by: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Tanya Gupta <tgupta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832593}

Add metrics to measure how long the context menu has shown before the
usre close it.

Bug: b/173809124
Test: None
Change-Id: Ieb28c43078ff7ea81f2d51823d84c0d5414eb38f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567634
Commit-Queue: Yue Li <updowndota@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832592}

When Blink renders a JPEG that has EXIF orientation via new Image() it
now reports the image width / height with the EXIF orientation applied
for some JPEG images [1].

The FilesApp file list also examines the JPEG image metadata and works
out it has EXIF orientation, and requests that EXIF orientation in the
thumbnail request it sends to the image loader. That combined with the
Blink change causes the image loader cropping/resizing code to produce
an output image that has the EXIF orientation applied twice.

Fix this: override the image loader request's orientation during image
processing operations of JPEG images to use EXIF orientation 1 so that
the image orientation is applied by Blink alone. Restore the request's
orientation after the processing operations.

[1] Observation in testing: not every JPEG the image loader deals with
is affected. The bug seems to depend on how the JPEG image is served:

 • Load the JPEG image from a file-system URL (normal files app case)
   or from a window.createObjectURL (piex-wasm) and the bug occurs.
 • Load the JPEG image from dataURL and the bug does not occur so the
   must apply the request orientation in that case.

Bug: 1152084
Change-Id: I478dcf756846bf9e67ee37fe2009319c2af3b79b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567071Reviewed-by: Alex Danilo <adanilo@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832591}

Opacity fade in when expand view is shown.
0 - 100% opacity 100ms linear curve.

Bug: 1148692
Change-Id: Ib4477a7219e5a9823f476ce98de5caa1e5ce0c99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557942
Commit-Queue: Melissa Zhang <melzhang@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832590}

Refactors NGGridLayoutAlgorithm to reduce member variable usage.
This change should not have any functional changes.
The helpers used in NGGridLayoutAlgorithm::Layout need to be used
to help compute the min/max sizes, to do this they must be static
or const. This refactor has an emphasis on moving data from the
class to the stack whenever possible.
This change also removes the state machine, as the added complexity
was determined to not be needed.

Bug: 1045599
Change-Id: I6af79bc2e3093ccfd33d8c6cb5cc6d46c2ed3698
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542766
Commit-Queue: Jacques Newman <janewman@microsoft.com>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832589}

https://skia.googlesource.com/skia.git/+log/0c2cc2356170..986c7fb8caea

2020-12-01 johnstiles@google.com Fix codegen errors with Metal return statements.
2020-12-01 brianosman@google.com Add ByteCode output to skslc
2020-12-01 johnstiles@google.com Enforce layout(location=...) on Metal out variables.
2020-12-01 herb@google.com remove use of initial matrix
2020-12-01 johnstiles@google.com Disallow global variables containing arrays of opaque types.
2020-12-01 ethannicholas@google.com Created SKSL_USE_THREAD_LOCAL define

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC westont@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: westont@google.com
Change-Id: Ie10d6a9a6a150ac30a1bfa5c5b58962d9437301b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566789Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#832588}

This mojom struct was used to provide both a legacy InterfaceProvider as
well as a BrowserInterfaceBroker to renderers. All renderer-side
consumers of InterfaceProvider have been migrated to
BrowserInterfaceBroker and DocumentScopedInterfaceBundle is now merely a
wrapper around a BrowserInterfaceBroker endpoint.

This CL removes it.

Bug: 977637
Change-Id: I748243f2b0975e30dd7ee9272c2ebcaa2815c0d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568163Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#832587}

Bug: 1149606
Change-Id: I1e1c675a9098e2c11bbeb8fca9d3558a6da8f8eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568361Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Stephanie Kim <kimstephanie@google.com>
Cr-Commit-Position: refs/heads/master@{#832586}

When isolated splits are enabled the default Context won't find the
class inside the module. It's possible to use a different class loader
but since this View needs custom setup anyway, it's easier to just
handle it in code.

This is currently moot because isolated splits are disabled for the
cablev2_authenticator module, but will matter when that changes.

BUG=1002262

Change-Id: I86477e9f980a3754f3bb2cf9e3ff360e4abaf293
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555584
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#832585}

Future mojoms should use BitmapN32, and we will convert existing users
of BitmapWithArbitraryBpp over to BitmapN32 wherever possible - the
difficulty of switching comes primarily due to the use of "Stable" on
the skia.mojom.Bitmap mojom and the gfx.mojom.Image mojom. We will
likely need to split off a non-stable Image type as well for non-
ChromeOS-API uses.

This suggests perhaps that all "Stable" mojoms should be independent
from the non-stable mojoms used throughout Chromium.

R=dcheng@chromium.org

Bug: 1144462
Change-Id: I110139960fc231e8ad2f6b0864fbc6200079cb29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560398
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Darin Fisher <darin@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832584}

BUG=1110772

Change-Id: I9c960eb923612a97b9e5b65ba45c7dc4ba26bddf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554741Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Keith Lee <keithlee@chromium.org>
Commit-Queue: John Palmer <jopalmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832583}