GitLab

Bug: 1088873, 1089525
Change-Id: I88b0164eca4a5554f59fb588ce0a9f88d60545ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340676
Commit-Queue: Carlos IL <carlosil@chromium.org>
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Auto-Submit: Carlos IL <carlosil@chromium.org>
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795702}

Bug: 1046523
Change-Id: I18856d4cd56847f4778bdd3d5b1b5ec68e54824d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340268
Commit-Queue: Angela Yoeurng <yoangela@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795701}

https://skia.googlesource.com/skia.git/+log/19c3850508fd..2c4a07d925cc

2020-08-06 nifong@google.com allow external files in canvas_perf.js tests
2020-08-06 robertphillips@google.com Fix parameter evaluation order bug in DDLPromiseImageHelper
2020-08-06 johnstiles@google.com Update the DitherEffect @test to ensure non-zero dithering.
2020-08-06 jvanverth@google.com Fix unaligned pointer warning on iOS.
2020-08-06 johnstiles@google.com Implement matrix casting in Metal.
2020-08-06 ethannicholas@google.com simplified SkSL REHYDRATE=0
2020-08-06 johnstiles@google.com Enable ClangTidy check llvm-namespace-comment.
2020-08-06 brianosman@google.com SkRuntimeEffect: Apply uniform transforms in color filters, too

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC herb@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: herb@google.com
Change-Id: I531ff3557e4fed430161fc54970bc4d3d741c87a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341698Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#795700}

Add an API on LayerTreeHost to enable the embedder to dynamically
control when the compositor's rendering can be throttled for power/CPU
efficiency.

Enabling this mode is currently limited to the use-case of synchronizing
multiple videos in the display compositor, so currently cc allows
throttling up to 24fps to match the video content.

R=chrishtr@chromium.org

Bug: 976583
Change-Id: Ie9c7ccd631c453cd7db6d0d96885ea686646ff67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341392Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795699}

Bug: 1098545
Change-Id: Ic9aaf0b95b412198d9db3ce8f1ce805ac42f77b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339641
Commit-Queue: John Lee <johntlee@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795698}

Change-Id: Id271d849ef802e92537f60e3362343f1e05d7c6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321216
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795697}

TBR=sullivan
NOTRY=true

Bug: 1113921
Change-Id: I4d19e804cdcd040f3b35be151ccd0c91c6b52c42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340875Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795696}

Rather than resolving a mojo Blob to a BlobDataHandle, just forward the
request to the Blob and let the blob create the URL Loader. This way we
decouple BlobURLLoaderFactory from any blob internals, paving the way
for further separating out the blob URL registry from the rest of the
blob system, making it easier to change where parts of the blob system
live (for example moving Blob URLs to be per storage partition, or in
the future perhaps per agent cluster).

This does increase binary size significantly because the added mojom
method results in java bindings being generated for a lot of interfaces
and structs that were previously not generated. In the future this
increase can be eliminated by making it possible to tag methods in
mojom files with what languages they should create bindings for, or by
rewriting BlobURLLoader itself to operate on a mojo Blob, rather than
forward the entire URLRequest to the mojo blob (https://crbug.com/1111835).

Bug: 1106890
Binary-Size: Size increase is unavoidable (see above).
Change-Id: I4fa3c6a5ddf6f8be5ce299e9d1fd95eaef75ec5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330311Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795695}

Bug: 942499
Change-Id: I21c4f5dd3e03419f3d272f3ffe6c38d764bd3328
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333063Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795694}

Splits histograms.xml into smaller files by prefix so resulting files
can be indexed and searched. Splits at given depth and aggregate
threshold.

Change-Id: Ia368af468c8229428b7079ce3a32ecd7d69f4ff1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327990Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Wenhan (Han) Zhang <zwenhan@google.com>
Cr-Commit-Position: refs/heads/master@{#795693}

Better encapsulate network-summary by preventing InternetPage from
directly accessing its DOM. Adds getNetworkRow public getter method
and uses it in InternetPage.

Change-Id: I8a42c5e13db9476b2bc600e3b6e0d97be3390c6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341757Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Daniel Classon <dclasson@google.com>
Cr-Commit-Position: refs/heads/master@{#795692}

This CL calls RecordMetrics() on query tile selection, so that
Chrome will send the OmniboxEventProto to the backend.

BUG=1112961

Change-Id: Ia7d220c129c7f1624eb3462e467cbd0e98f4f60a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336309
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Tomasz Wiszkowski <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#795691}

This is a reland of 853e0dd9

The original CL was reverted due to a data race. The race was fixed
in crrev.com/c/2340297

Original change's description:
> service worker: Use mojo version of GetUserDataForAllRegistrations
>
> This CL starts using mojo version of
> GetUserDataForAllRegistrations{,ByKeyPrefix}().
>
> The type of the return value of these methods is also changed from
> map<registration_id, value> to array<ServiceWorkerUserData>,
> and ServiceWorkerUserData now has registration_id.
> These changes are required to handle a situation where a
> registration_id is associated with multiple values. Some features like
> payments could associate multiple values for a registration_id.
>
> Bug: 1055677
> Change-Id: I29e9ae7c1722316b2ac2f163cfc5b50fe7590d54
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331376
> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
> Reviewed-by: Matt Falkenhagen <falken@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#794447}

Bug: 1055677
Change-Id: I9f9ea4f6deb9953c4b18af941e6e8b70b66afb66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340417Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795690}

CastAudioManagerAndroid now becomes a subclass of AudioManagerAndroid,
instead of CastAudioManager. Some of the logics are moved into
CastAudioManagerAndroid to keep the behavior unchanged:
1. Move MakeLinear/LowLatencyOutputStream into CAMA, to return CAOS.
2. Move some getter into CastAudioManagerHelper (new), so that CAOS can
be created from both CAM and CAMA.

This will make switch to chromium audio output easier.

Bug: internal b/160753974
Test: Build, cast, cast_media_unittests
Change-Id: I99249c0c15bd7b5e9cf04b7ee10eb3b8850ee22e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340104
Commit-Queue: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795689}

Bug: 1044139
Change-Id: Ieb32cc74c2e6bc18efd8520fb8794a3e44d38ed5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341832
Auto-Submit: Dan H <harringtond@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795688}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2399aa25d56e..beb677bfc877

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC reillyg@google.com,ftirelo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1001667
Tbr: reillyg@google.com,ftirelo@google.com
Change-Id: I470a17defdeeaaeb738b403a98a00b4e68691f33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341697Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#795687}

Print the native logs JSON string on the internals page to aid in
debugging.

Bug: 687380
Change-Id: I864ff7dbdaa32a2b13cab85b1c554e04ed14e53a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324969Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795686}

This is used to fetch a previously downloaded favicon. For
consistency this returns the same image as that returned
from FaviconFetcher.

BUG=1076463
TEST=none

Change-Id: Icdd01286d1d564c7cb5b62847ffb1d888d9d70fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340796Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795685}

This prevents triggering a NOTREACHED() for internal projects that have
a very large number of variations.

Bug: b:162438420
Change-Id: I171062c0d462e56f70cc6eb7ebeb279169279333
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332571Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795684}

There is a bunch more work to be done here, but this makes the
code match that of the names in history.

BUG=1104873
TEST=none

Change-Id: Ib11d1a2335e1c8ee6643b1f5e58d5807dd66a788
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340547Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795683}

Inbound and outbound depths must be >= 0. Previously, users could select
values less than 0, this is no longer the case.

Bug: 1102546
Change-Id: I479984448987a30d0b699bcae55336de840aff8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340364
Commit-Queue: James Long <yjlong@google.com>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795682}

After we finish the scroll unification, the scrolls happens mainly on
the compositor thread, and the scroll code in the main thread will be
removed. eventSender sends the scroll events to main thread, so it
would not work after the scroll unification. We should replace
eventSender.continuousMouseScrollBy with
gpuBenchmarking.smoothScrollByXY in
fast/events/mouse-wheel-main-frame-event.html.

Bug: 1047176
Change-Id: I5746dc6504e15984862957c670c458979afe5b4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332327Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795681}

Last attempt just moved the flake to the next line that times out while
waiting for fullscreen state. Now make the whole rest of the test into a
retry loop and see if things improve.

Bug: 1107954
Change-Id: I1a358a28a4b22904db23e0b4ee0400b90292c59e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340672
Commit-Queue: Bo <boliu@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795680}

The current caBLEv2 handshake has the desktop speak first. We expect the
network-based design to have the phone speak first, thus this change
turns the handshake “around” to accommodate that. Also, the current v2
handshake includes pairing information in the response but, if the phone
speaks first, the response is coming from the wrong place to include
pairing information and the first message has insufficient protection to
include it. Thus that is removed. Instead, a getInfo message can be
included in the phone's first message because it'll be needed anyway and
it's generic and thus doesn't require forward security.

BUG=1002262

Change-Id: If2fb27b2a56ef21c0b21a454ff498f65ce62e81f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340062
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#795679}

We'll soon be adding another Finch group that indicates to the client
that we should defer to the BlinkOptimizationGuide (being implemented in
[1]) for the delay async script execution milestone, as opposed to
relying on the field trial param value being set by Finch.

This CL adds the kOptimizationGuide value as an option for the
kDelayAsyncScriptExecutionDelayParam field trial parameter. When the
BlinkOptimizationGuide is implemented [1], there will be a follow-up to
this CL that actually uses the OptimizationGuide hint once it is
plumbed to Blink.

[1]: https://crrev.com/c/2337050

R=falken@chromium.org, kinuko@chromium.org, nhiroki@chromium.org

Bug: 1086227
Change-Id: I8b8419b03b2a52399971cd32262ba003f2750ab4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337767Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795678}

The problem with xor is it's a commutative operator, so the relative
ordering of operations won't be captured in the digest calculated.

This is problematic, as drawing an oval and then a rectangle can produce
visually-different results than drawing the rectangle and then the oval.

Instead, we can use the IdentifiableTokenBuilder library, which was
designed to preserve such ordering.

Bug: 973801
Change-Id: I45baf54418263a1984bc3446233fd5a7d0a6ebc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311059
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795677}

Since only Android versions P and above are supported, settings page
toggle should not be visible if O or lower.

Bug: 949269
Change-Id: Idefda09cd2210843578abc58ae4a11b79b711eac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338726Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Manas Verma <manasverma@google.com>
Cr-Commit-Position: refs/heads/master@{#795676}

The spec does not permit undefined values to be resolved:

https://w3c.github.io/ServiceWorker/#cache-storage-open

Since this only triggers for rare error conditions that are difficult
to trigger there is no test for this change.

Bug: 1113829
Change-Id: I7e015fdb51e42e7560510fac37ea0071624f95c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341395Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795675}

TBR=govind@chromium.org

Change-Id: I5ac6cd8c3f011ea5c75df1749c0d4c94a86432d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340671
Commit-Queue: Ben Mason <benmason@chromium.org>
Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795674}

This is intended to replace the UsbDetachableWhitelist policy.
The old policy will still be used in the absence of the new one for at
least a few releases of Chrome.

BUG=chromium:1103813

Change-Id: Ibc22d67893984f2644d3ce50cb281d5eeff9981c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333038
Commit-Queue: Brian Malcolm <bmalcolm@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795673}

This test appears to flaky on Chrome OS.

TBR=sammiequon@chromium.org

Bug: 1113901
Change-Id: Ia6e4b0954ec47549e4f69796a096545a9051c332
No-Presubmit: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341174Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795672}

(And to measure the entropy if so).

Or rather, to measure if it could be used for it, since we can't actually tell if the page observes the side effects.

Bug: 1103288
Change-Id: Ia94184d373d84ca9d4ce00d41dd5e67136a6936f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330002
Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795671}

Tests marked as experimental in the lacros bot (crrev.com/c/2341931),
so we they don't need to be disabled.

TBR=svenzheng@chromium.org

Bug: 1113695
Change-Id: Idaf81bf6b03fbd45a509b7d51588f2cbf0f6e244
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341159
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Sven Zheng <svenzheng@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795670}

https://android.googlesource.com/platform/external/perfetto.git/+log/dc68e3248ed9..e69d5b2de943

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I49b9bf2effd3391579871679863a12058baedb8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340554Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#795669}

Bug: 1113695
Change-Id: I498b1a6a10a7dfa0f34c36df1dda45417698a13c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341931Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795668}

Bug: 1100991
Change-Id: I4051534404e0160a6b4415c137c2537849b047e5
AX-Relnotes: n/a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339207
Commit-Queue: Alexander Surkov <asurkov@igalia.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795667}

Change-Id: I14c30dd135dc2f4fe813c4cee927ba911d33f28e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305672Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Cammie Smith Barnes <cammie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795666}

As part of a larger effort to migrate fields in Tab to UserData objects
so Tab doesn't become large and unwieldy.

Bug: 1112364
Change-Id: I838e0542a43d4f8a87685eaa679745cff77ebb28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337576Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: David Maunder <davidjm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795665}

Default ACL on the password item only allows the owner application to
read the content. We analyze the ACL and recreate the item in case it
won't allow Lean Native Helper or Chrome to access it. Access is limited
to application sharing same team id which is taken from the signing
certificate.

This CL matches secure connector native host behavior. Original CL id:
300399914.

Bug: 1062382

Change-Id: Ica4d8852b544318b06692ecfb02f62628f0b5bfb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144195Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795664}

This is UI review request to replace the previous open display settings
on context menu. This adds a notification that disappears after 6s
(notifications API default). The notification is shown when a display is
added, all other display related notifications remain hidden if the flag
is off.

Test: manual
Bug: 1111479
Change-Id: Ib3cf08f5a3a6a129a3457605e0b5aefc21063dbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340265
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795663}