- 03 Feb, 2020 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c809e8bd6289..f2be3eff26fd git log c809e8bd6289..f2be3eff26fd --date=short --first-parent --format='%ad %ae %s' 2020-02-03 eshr@google.com Move initial frame drop to overuse module Created with: gclient setdep -r src/third_party/webrtc@f2be3eff26fd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Iaf6df3967b0ddbc03264e1ea1852630f3dd52cd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035833Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737787}
-
Roman Sorokin authored
Fixed: 910529, 947161 Change-Id: I2f6ff33350102c4bf6eaf32a19e065f6bdb68b91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033157Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#737786}
-
Anton Bikineev authored
Apple-clang complains about missing initializer in union. This fixes it. Original change's description: > [base] Use dummy class to avoid superfluous initialization in Optional > > The initialization of "char empty_" union-member in Optional is > redundant and causes the compiler to generate extra code to ensure > zero-initialization. Using an empty Dummy class for the union member is > more optimal, since it guarantees that no code for its initialization is > generated. > > Explicitly touching this char member in the constructor also causes a > problem for conservative GC. Compiler is free to split shared and not > shared parts of the union in separate memory locations on stack (or keep > them in different registers). If a conservative GC is triggered at this > moment, stack scanning may not find the correct object (this is exactly > what happened in the bug 1044331). > > This can be tested in a minimized example: https://godbolt.org/z/t5q5ry. > > Bug: 1046776 > > Change-Id: Idab1a0acf7d7d4f45dc9435a611b23f64e3c3c79 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027948 > Commit-Queue: Anton Bikineev <bikineev@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737494} Bug: 1046776 Change-Id: I751878a515647e244059d0ad1ba7bc6542fd1f37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033357Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#737785}
-
Olivier Robin authored
Initialize Audio can take a long time and causes freeze on the main thread during |UIApplication didFinishLaunching:|. Use a simplified WKWebView instead. Bug: 1043879 Change-Id: I5c42f1ecd9bf320fc39728f665b60ce5dab413f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010794 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#737784}
-
Manoj Gupta authored
Fix for crosh not loading on ARM64 Chrome OS. Bug: 1047517 Test: crosh works. Change-Id: Ifce8c65e9e9bd49980204175b990cb304cbf0a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031757Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Mike Frysinger <vapier@chromium.org> Commit-Queue: Manoj Gupta <manojgupta@chromium.org> Auto-Submit: Manoj Gupta <manojgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#737783}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9e8d8c4830c1..d4f68317fe3a git log 9e8d8c4830c1..d4f68317fe3a --date=short --first-parent --format='%ad %ae %s' 2020-02-03 robertphillips@google.com Add SW decode of ETC1 and a GM Created with: gclient setdep -r src/third_party/skia@d4f68317fe3a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: scroggo@google.com Change-Id: I7bccf5ff8a846cff2b5edda46d71a63b6820bb04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035609Reviewed-by:
-
Eric Robinson authored
This adds metrics that compute both the total time (post initialization) that a RenderProcessHost is alive, as well as the time that host spends in the background (as computed by RenderProcessHostImpl::UpdateProcessPriority). There's also a small change to the testing infrastructure to consolidate functionality under RenderProcessHostFramePriorityTest. Bug: 1026606 Change-Id: I36863e87fb6606685cac23e6d1a9ab3a4807d8ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994000 Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#737781}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ie29857750932e744f21ce62295c00f9332f63559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035111Reviewed-by:
-
Miyoung Shin authored
This CL cleans up exposed InterfaceProvider interfaces of Blink. Bug: 990845 Change-Id: I6001b814b0212d658811c35f8312b615ff076007 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963600Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#737779}
-
Daniel McArdle authored
This adds fuzzer coverage for wav_audio_handler.cc. Fuzzer coverage report: https://chromium-coverage.appspot.com/reports/737219_fuzzers_only/linux/chromium/src/media/audio/wav_audio_handler.cc.html Change-Id: I60176aba90301bcab648029511a27c16c93ef736 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033443Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#737778}
-
Peng Huang authored
With AMD GL driver, glSignalSemaphoreEXT() doesn't flush the gl context, and AMD DRM kernel driver checks every semaphores which are waited on with vkQueueSubmit() call, to make sure the works to signal those semaphores are submitted to DRM kernel driver. Otherwise the vkQueueSubmit() will fail. So we need to call glFlush() explicitly after calling glSignalSemaphoreEXT(). Bug: 1046462 Change-Id: I7d0967ab33953a2571376314f9aac238b86759fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034621 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#737777}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/674dea0bd489..1418552cad29 git log 674dea0bd489..1418552cad29 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 tvanderlippe@chromium.org Remove bundled Runtime.js 2020-02-03 janscheffler@chromium.org Roll upstream changes. 2020-02-03 tvanderlippe@chromium.org Make audits_worker a worker with module scope 2020-02-03 tvanderlippe@chromium.org Migrate extensions/ to import cross-module Created with: gclient setdep -r src/third_party/devtools-frontend/src@1418552cad29 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1046596 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iaa863207381d7f59e76aa67fb5e958d763f26331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035830Reviewed-by:
-
Adam Ettenberger authored
Roles that allow NameFrom::kContents were not adding the text of descendants with Role::kStrong or Role::kEmphasis. This could cause screen readers read a portion of a word in some cases. Bug: 1047549 Change-Id: Iaacd8e485684b61ee0977c44d31479f6aa3d108a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032514 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#737775}
-
Ali Juma authored
This builds SafeBrowsingUrlCheckerImpl on iOS as part of components_unittests. The remaining content/ dependencies in SafeBrowsingUrlCheckerImpl are all in methods related to real-time checks. This CL moves the implementations of these content-dependent methods to a content-specific file, and defines stubs for these methods on iOS, where real-time checks won't be initially supported. Change-Id: I5f83e99b586ff4c62876248d8933b2671c1eceb8 Bug: 1028755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033332Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#737774}
-
Side Yilmaz authored
|getMainProfile| function is renamed to have the similar name in Java and C++, and to reduce the usage complexity of the function on matching platforms. This change only contains Java side changes, but there will be a following change for C++ side. Note: This change is only code clean-up, does not change any behavior. Bug: 1041781 Change-Id: I3d4aa6bfe4739c440ea3b7f40c2deb070561e865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027811Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#737773}
-
Francois Doray authored
This is a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1990990 Startup histograms are useful to diagnose regressions to Startup.FirstWebContents.NonEmptyPaint2. All those that we used in past investigations are marked as never expires. Others are removed. Fixed: 1039324, 1037319, 1037317, 1037316, 1037315, 1037314 Bug: 1039324, 1037319, 1037317, 1037316, 1037315, 1037314 Change-Id: I6ff7c26c46a29936b35da37ef4a70187d38d5098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002762 Auto-Submit: François Doray <fdoray@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#737772}
-
Egor Pasko authored
Remove the retry logic in library loading because there are no samples seen from ChromiumAndroidLinker.LoadLibraryStatus on Stable. Also remove the histogram recording, as I imagine it will be easier and cleaner to introduce the new histogram for upcoming changes in the linker, as opposed to carrying this legacy of "first attempt". Bug: 1021156 Change-Id: Ib32ea7af3c9ebee5a08f78fe957bcda636b58007 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032122Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#737771}
-
Michael van Ouwerkerk authored
Bug: 1046344 Change-Id: I8e70bf00e30bcc6c873397e4dfa0d72e82cd315c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023554 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#737770}
-
Ravi Mistry authored
Bug: chromium:1048153 Change-Id: Ic1e42177b10af8b66fecc254697daf1ccb9a917b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033372Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Ravi Mistry <rmistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#737769}
-
Stepan Khapugin authored
Makes view-level APIs vend NSStrings instead of base::strings, and updates some syntax to dot syntax. Bug: none Change-Id: I6031f363868fb402b70e23804d9493f2f473ad20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019247 Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#737768}
-
Mihai Sardarescu authored
Sign-in tests have experienced quite some flakiness lately. This CL is extracting them to their own test suite to make sure they are run independently and not affected by flake from other tests. This CL also re-enables all sign-in tests. Bug: 1045478 Change-Id: I23bef73c1fbcdba71a413309f231fc3f2fbfa56f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033252 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#737767}
-
Javier Fernandez authored
The patch landed in r699290 tried to avoid errors when computing the the used value of relative margins or padding due old/outdated item's override size. The solution was to clear the both the inline and block override size whenever an item had an intrinsic or auto size, or a relative margin or padding. However, the change mentioned above caused a performance regression, as described in the bug. The root cause is an excessive number of relayouts of the items that had to clear their override-size. This CL tries to solve the performance issue by reducing the cases where the override-size has to be cleared. It's not necessary to reset the inline override-size unless the item has relative margin or padding. Bug: 1046310 Change-Id: I988ab05e0552af75bf57f5d82dc73714f377ca0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033507Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#737766}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c1a0ada7d208..6dc622fec32c Created with: gclient setdep -r src-internal@6dc622fec32c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I6edf534955d05e79b04d0372b40407ae5a7f564b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035602Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737765}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/09a9f1ba72d5..c809e8bd6289 git log 09a9f1ba72d5..c809e8bd6289 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 eshr@google.com Move quality scaling frame drop logic to adaptation module 2020-02-03 danilchap@webrtc.org in RtpFrameReferenceFinder VP9 case validate number of references in gof Created with: gclient setdep -r src/third_party/webrtc@c809e8bd6289 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1048013 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I15d3479007c1bf9802badde5123d0349b8879f32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035603Reviewed-by:
-
Finnur Thorarinsson authored
FindInPageControllerTest.FindMovesOnTabClose_Issue1343052 FindInPageControllerTest.FindMovesWhenObscuring This CL effectively reverts two CLs: https://chromium-review.googlesource.com/c/chromium/src/+/2031539 https://chromium-review.googlesource.com/c/chromium/src/+/2028737 If the test fails as a result of this CL then the view.cc changes are not to blame for and this CL should be reverted. TBR: kylixrd Bug: 1041614, 1047427 Change-Id: I66191af28e988ded2a304fa14e2254c1248257be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035372Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#737763}
-
Matt Falkenhagen authored
"Mojo Linux" was really about running browser tests with the Network Service in different configurations: in-process and web request proxy. We don't want these to regress and have been watching the FYI bot, but this isn't sustainable. We considered putting the tests on the CQ but these tests are expensive so it would significantly increase CQ time. Move the tests to a new waterfall bot. This is step 2) and 3) from comment #5 on the bug: 2) Add an entry for the new builder to mb_config.pyl and to various files in buildbot/ 3) Add an entry for the new builder to ci.star (Doing both steps in the same CL seemed needed to pass presubmit.) Bug: 1040384 Change-Id: Ic77927dcca52a556729e1d6b1174fc87c77ed656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029395Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#737762}
-
Jan Krcal authored
This reverts commit 7231941c. Reason for revert: It is indeed flaky, this provided some insights, reverting. Original change's description: > [User events] Re-enable a previously flaky test > > This CL re-enables a previously flaky test. If still flaky, the goal is > to gather failure logs to understand the root cause (logging has > improved substantially since this test got disabled). > > Bug: 1006155 > Change-Id: I384bbb3cf83068a6d1297592b9400a8ffe23ff73 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031035 > Auto-Submit: Jan Krcal <jkrcal@chromium.org> > Commit-Queue: Marc Treib <treib@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737266} TBR=treib@chromium.org,jkrcal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1006155 Change-Id: Ib59c61ffd0feae55d6db156e79c06f283c4ca41c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035413Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#737761}
-
Marc Treib authored
TBR=lukasza@chromium.org Bug: 1048148 Change-Id: I7393ce564ea09535810cf2b77c7854b05af1e1f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033770Reviewed-by:
-
Marc Treib authored
This reverts commit a05d328d. Reason for revert: Flakiness should have been fixed by https://crrev.com/c/2035374 Original change's description: > Disable flaky AccessibilityActionBrowserTest.ImgElementGetImage on Mac > > TBR=yaoxia@chromium.org > > Bug: 1047921 > Change-Id: I5883ab91335fb7faa0a7ee45d93b5535b2cca794 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033513 > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737708} TBR=treib@chromium.org,yaoxia@chromium.org Change-Id: Iafb9d0713816f66bb6f73ad20521b642dab7df97 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1047921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033451Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium cb77d7d5. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-writing-modes NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Ia596759a815b38ab80af5fdc6752035122673157 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032308Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737758}
-
Greg Thompson authored
This CL introduces a new model for the state of the build and controllers to drive it for desktop Chrome and Chrome OS. In its introduction here, the model holds whether or not an update is available, its version, the "critical" version (if set), and whether or not the new version is a rollback. This CL does not activate the new model or controllers in the browser. A subsequent CL will give the browser a process-wide BuildState instance, a single controller to update the BuildState when an update is available, and make UpgradeDetector an observer of the process's BuildState. BUG=1043624 Change-Id: I50be6b313ee152f2351e823fbd8637aac0c5c52a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017520 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#737757}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2b9bdb1d..352de2b8 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7f6ffd28c0f213cdb7cd3ae6acf51e0a7c3eac07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035690Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737756}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b6b755afe678..674dea0bd489 git log b6b755afe678..674dea0bd489 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-02-03 yangguo@chromium.org Fix NodeURL test on Windows 2020-02-03 tvanderlippe@chromium.org Migrate js_main/ to import cross-module 2020-02-03 tvanderlippe@chromium.org Migrate inspector_main/ to import cross-module 2020-02-03 bmeurer@chromium.org Move .editorconfig file to top level. Created with: gclient setdep -r src/third_party/devtools-frontend/src@674dea0bd489 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I36f105d95be42ca3c84287b45d10daf55c7abe2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035600Reviewed-by:
-
Marc Treib authored
This reverts commit 53b4c802. Reason for revert: Suspected of breaking various accessibility browser tests, see linked bugs. Manual changes to the revert: *Not* reverting web_feature.mojom or enums.xml (which are harmless but conflict-ey). Original change's description: > Implement overlay-interstitial-ad detection > > Why: We’d like to learn where and how often they are used. > > How: In LocalFrameView::RunIntersectionObserverSteps, fire a hit test > event in the center of the main frame with a 1 second interval. We check > the style of the returned element and its container elements, to see > whether it is immobile to scrolling and if it can overlay with other > contents in the page. > > Bug: 1032681 > Change-Id: I18acd22a7972a1e4ca361a7c466aa20705844dbb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993140 > Commit-Queue: Yao Xiao <yaoxia@chromium.org> > Reviewed-by: Bryan McQuade <bmcquade@chromium.org> > Reviewed-by: Stefan Zager <szager@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737529} TBR=szager@chromium.org,bmcquade@chromium.org,ikilpatrick@chromium.org,yaoxia@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1032681, 1048137, 1047921 Change-Id: I3db5bb7ebf146e35b90e2cfff203337f82567435 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035374 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: I198903c06bc630bbcf6f9c2586cb060c3bc340f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033985Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737753}
-
Luca Hunkeler authored
In a follow-up cl a new section will be added that requires storing types other than strings. In this cl we change strings into ValueProto to accommodate that. Other minor modifications: -Collect user data will now only return additional values that were set by the action itself. -Keys with empty strings will also be added to the additional values (they were ignored before) Change-Id: I379c1061f7381dc75b68650602583e75ec5db7cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027550 Commit-Queue: Luca Hunkeler <hluca@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#737752}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/f3c7e4750501..1ccc65258d95 git log f3c7e4750501..1ccc65258d95 --date=short --first-parent --format='%ad %ae %s' 2020-02-02 jophba@chromium.org Add notes/warning to README.md 2020-01-31 rwkeane@google.com mDNS: Add support for publishing multiple PTR records Created with: gclient setdep -r src/third_party/openscreen/src@1ccc65258d95 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Ic1bcb6674918b83029306bd619b188f128c67c9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035597Reviewed-by:
-
Henrique Ferreiro authored
Use pointers instead of references for blink::WebCursorInfo output parameters, as recommended by the Google C++ style guide: https://google.github.io/styleguide/cppguide.html#Reference_Arguments. Bug: 1040499 Change-Id: I32a38b71c5bffaa9b76cb91a67df57ff20c71edf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035411Reviewed-by:
-
Markus Handell authored
This change updates the OnVideoFrame and OnEncodedVideoFrame mock methods to provide the received timestamp. Bug: 1048140 Change-Id: I89c4090050b59b03c57d9062d949bc34cc3351ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034522 Commit-Queue: Markus Handell <handellm@google.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#737749}
-
Simon Zünd authored
This reverts commit 459e299a. Reason for revert: Still causes test to become flaky on debug builds: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=http%2Ftests%2Fdevtools%2Fsources%2Fdebugger%2Fsource-frame-breakpoint-decorations.js Original change's description: > Prepare breakpoint web tests for source map asyncification (4/5) > > This CL re-writes a breakpoint web test using a new SourcesTestRunner > helper introduced in https://crrev.com/c/2027427. > > This should not only prepare the test for the upcoming source map > asyncification but also reduce the overall flakiness of breakpoint > web tests. > > This CL superseeds the current in-flight CL https://crrev.com/c/2022642 > which will be abandoned. > > R=sigurds@chromium.org > > Bug: chromium:1032016 > Change-Id: Id5bcd9d3913a2f83c029f52da33e484c61f0c9db > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030464 > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Commit-Queue: Simon Zünd <szuend@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737714} TBR=sigurds@chromium.org,szuend@chromium.org Change-Id: I771b2c18d94c6c3b7d124a206531806157404cac No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1032016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030917Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#737748}
-
