- 22 Jan, 2020 40 commits
-
-
Bence Béky authored
https://quiche.googlesource.com/quiche.git/+log/57425e34e9f5..dfabdfb6884b $ git log 57425e34e..dfabdfb68 --date=short --no-merges --format='%ad %ae %s' 2020-01-17 bnc Add HTTP/3 error codes, use them in HttpDecoder and for unexpected frames in QuicSpdyStream and QuicReceiveControlStream. 2020-01-17 dschinazi Bring back the ParsedQuicVersionIsValid DCHECK 2020-01-17 wub gfe-relnote: (n/a) For test BbrSenderTest.SimpleTransfer2RTTAggregationBytes, relax the expectation on sender-measured min_rtt. Test only. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Also update flag values and remove deprecated flags. Change-Id: Idff4cc42eef7af45d338e5272a02751b5e2f1a7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010929 Auto-Submit: Bence Béky <bnc@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#733951}
-
Hitoshi Yoshida authored
Bug: 839389 Change-Id: If742316b3acfca5e36268ff0ceeb6eeee6aa5d83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012376Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#733950}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/06df1e1c4655..402379f1f35c git log 06df1e1c4655..402379f1f35c --date=short --first-parent --format='%ad %ae %s' 2020-01-22 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3f2a66df..c565cfe6 (733758:733868) 2020-01-21 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9a18a2d9..3f2a66df (733613:733758) Created with: gclient setdep -r src/third_party/webrtc@402379f1f35c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I8a74d44d8e342b0af696f5c074c718f1261555f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014307Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733949}
-
Ewann authored
user actions: -Adds MobileDownloadFolderUIShownFromDownloadManager -Adds MobileDownloadFolderUIShownFromToolsMenu Bug: 1013572 Change-Id: Iee1697a330b37c0ca5501928f01a25ca17062140 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970993Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#733948}
-
Hitoshi Yoshida authored
Bug: 839389 Change-Id: I916e7fa8ec6e39a3637090aaef3a24b4c45dcf57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012361Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#733947}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/323a81fc5e30..ab7ac60f14ae git log 323a81fc5e30..ab7ac60f14ae --date=short --first-parent --format='%ad %ae %s' 2020-01-21 afdx@google.com spirv-fuzz: Refactoring and type-related fixes (#3144) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@ab7ac60f14ae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,timvp@google.com Change-Id: Iaf7af4793353a44c9d771844c31799f373637206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013831Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8c396a9cc4a8..1eb0ddb4d0c3 git log 8c396a9cc4a8..1eb0ddb4d0c3 --date=short --first-parent --format='%ad %ae %s' 2020-01-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 323a81fc5e30..ab7ac60f14ae (1 commits) Created with: gclient setdep -r src/third_party/angle@1eb0ddb4d0c3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: timvp@google.com Change-Id: I8c101c4cfe45debc0a55a33e11b6c91785732eaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013832Reviewed-by:
-
henrika authored
We would really like to keep this histogram since it is used on a regular basis when tracking down audio issues in WebRTC-based real-time clients. Bug: 1037591 Change-Id: I9b2ca5a9f5c3eeda972d11bc1e1e2c8c7b47ddad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010990Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Henrik Andreasson <henrika@chromium.org> Cr-Commit-Position: refs/heads/master@{#733944}
-
Mike West authored
After https://chromium-review.googlesource.com/c/chromium/src/+/1982549, we treat cookies with neither names nor values as invalid. This patch adjusts `ParsedCookie::SetName()` and `ParsedCookie::SetValue()` to ensure that a `ParsedCookie` can't be modified into an invalid cookie. It also applies the rule to `CanonicalCookie::CreateSanitizedCookie` to ensure that code path has the same restrictions. Bug: 1040296 Change-Id: I1e57c3ee8a4f6dc222c35d6e9844928c1ba7fb06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993962 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#733943}
-
Kinuko Yasuda authored
This was moved from services/network but fixing namespace was put off for a follow-up (and forgotten) Bug: 934009 Change-Id: I33ebbf2c4b38a1ee43dd33b25f24784b2fc6e794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012372Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#733942}
-
Himanshu Jaju authored
Integrates network traversal API to fetch stun and turn servers for webrtc p2p connection. Handles API failure by returning a list of public Google stun servers as a fallback. Bug: 1031156 Change-Id: I60b5d6ccdb749ce9375bcb3333dc2cbdab62aa18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994295 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#733941}
-
Tomasz Dobrowolski authored
Set SSO credential error as general error instead of credential error, which displays error under username/password and is invisible in SSO. Reset error state after changing authentication method. Bug: 1038896 Change-Id: I27fcd9b3eb4e045f2e37de9c76ae932a59b7305c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978687 Commit-Queue: Tomasz Dobrowolski <tomdobro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Anand Mistry <amistry@chromium.org> Auto-Submit: Tomasz Dobrowolski <tomdobro@chromium.org> Cr-Commit-Position: refs/heads/master@{#733940}
-
Yoshifumi Inoue authored
This patch changes |NGFragmentItem::DebugName()| to return as |NGPaintFragment::DebugName()| to get identical output for paint invalidation test (|internals.layerTreeAsText()|) for ease of managing flag specific test expectations, e.g. reducing rebaseline. Following 9 tests are passed: * paint/invalidation/selection/invalidation-rect-includes-newline-for-rtl.html * paint/invalidation/selection/invalidation-rect-includes-newline-for-vertical-lr.html * paint/invalidation/selection/invalidation-rect-includes-newline-for-vertical-rl.html * paint/invalidation/selection/invalidation-rect-includes-newline.html * paint/invalidation/selection/japanese-rl-selection-clear.html * paint/invalidation/selection/selection-partial-invalidation-between-blocks.html * paint/invalidation/selection/selection-rl.html * paint/invalidation/selection/selection-within-composited-scroller.html * paint/invalidation/selection/text-selection-rect-in-overflow.html Bug: 982194 Change-Id: Ib35d1e6e8f944209a5752a5f7c7ded5151bdf752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014353 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#733939}
-
Anqing Zhao authored
The DeviceStatusReportRequest need be extended to include additional information about crash reports. Bug: 1040078 Change-Id: Id02c768805e23477a8ee7f05c15acd790855f723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991483 Commit-Queue: Anqing Zhao <anqing@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#733938}
-
Tobias Sargeant authored
This has the combined effect of breaking out the core uploading code in MinidumpUploadCallable into MinidumpUploader, which can be used separately. Management of file renaming still remains split over multiple classes. MinidumpUploadCallable tests are split to reflect the new code organization. Bug: 1029724 Test: run_chrome_public_test_apk \ Test: -f 'org.chromium.components.minidump_uploader.*#*' Test: run_chrome_public_test_apk \ Test: -f 'org.chromium.chrome.browser.crash.*#*' Test: run_webview_instrumentation_test_apk \ Test: -f 'org.chromium.android_webview.test.services.MinidumpUploadJobTest#*' Change-Id: I0a8d7f8ad330d0127f7ce8559bd8090da6d44abe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975918Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#733937}
-
Clemens Backes authored
IndexedDB support for WebAssembly is removed since a long time, but there are still flags and helpers related to that. This CL removes them. R=haraken@chromium.org Bug: v8:10146 Change-Id: I4a6f2f0896ba370af3807a6225b25c6b11c7e12b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013046Reviewed-by:
-
Fredrik Söderquist authored
For the cases where an Image has already been extracted from the ImageResourceContent, call Image::Size(...) directly rather than calling ImageResourceContent::IntrinsicSize since the latter only adds a null- check. De-duplicate ImageElementBase::DefaultDestinationSize() since it is identical to ImageElementBase::ElementSize(). In ImageResourceContent::GetCompressionFormat(), there's no need to use the Image::Size overload that takes a RespectImageOrientationEnum since we only need to compute the area of the image - which is the same regardless of orientation. Bug: 773272 Change-Id: I9395ce9304827917d97d6e3cab209f09b4645b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010776Reviewed-by:
-
Eriko Kurimoto authored
This CL only changes the comment. script_type_ is not used for fetching the top-level worker script. Only credentials_mode_ parameter is used for it. Bug: n/a TBR: falken@ Change-Id: Iefa3f09496ceb88d36a6a209e90203bbd653222d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012374 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
-
Pâris MEULEMAN authored
[1] was flaky given sporadic timeouts occurring on Win7. This test is slow as it needs to reach the call stack size limit and then execute some code in each call frame. This marks the test as Slow which should give the test enough time to always complete. Bug: 937546 Change-Id: I450003c435c1a6856c0461c11995ff63f9988de9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012946 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#733933}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 57093a57. With Chromium commits locally applied on WPT: 0f8fd66b "[WPT/common/security-features] Support sub projects and split referrer-policy 4K tests" 1d0a2056 "Remove error.message in SharedWorker WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mkwst@chromium.org: external/wpt/cookies NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I1f18b5d7902c45956bcdba23ea7dbe6de042fa75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014460Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733932}
-
Anatoliy Potapchuk authored
During profile initialization, we have do a early exit for all kiosk types. Every kiosk separately inits CrOS prefs and keyboardcontroller, but ArcKiosk. This CL fixes that. Bug: 1040742, 1040744 Change-Id: Ic140d76fd12182dccd6decc239787e812abd1686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011100Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#733931}
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=jianli@chromium.org Bug: 1042208 Change-Id: Iacbce9f831abd0f470636ce16fd153e8e669f5c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007584 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#733930}
-
Mario Sanchez Prada authored
Add a new method to blink::mojom::LocalFrameHost interface, to be implemented right from RFHI, which will allow us to remove the WebLocalFrameClient::DispatchLoad() API plus the related bits under //content/renderer. Bug: 1008432 Change-Id: I047cc905c52d9f6a91414190b91c61a83bb48d4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000708Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Wez authored
This reverts commit df2b8586. Reason for revert: Broke various suites on the Fuchsia x64 bot. See https://crbug.com/1044377 Original change's description: > Roll Fuchsia SDK from 889098631016 to 889067175961 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll > Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast > Tbr: cr-fuchsia+bot@chromium.org > Change-Id: If6c2262c9f82b56d7ad11dd6d5295088a00da6da > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011862 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#733666} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,cr-fuchsia+bot@chromium.org Change-Id: Ideaddfadfbf47040312937cdc07ecdc1594f5a55 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1044377 Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012949Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#733928}
-
Fabian Sommer authored
Change icon, size and position of the back button according to newest UI specs. Bug: 1001288 Change-Id: Icf56180255b9d38e7b6f60a87f323ac07ce62c95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007714Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Fabian Sommer <fabiansommer@google.com> Cr-Commit-Position: refs/heads/master@{#733927}
-
Olga Sharonova authored
This reverts commit a5afd47a. Reason for revert: BUG:1044528 Original change's description: > DevTools: Block SIGPROF during CPU throttling > > The V8 CPU profiler schedules SIGPROF signals. It is very likely that > the signal handler for these will run while the throttling signal > handler is already running. V8 can't properly read the stack when > there is already a signal handler present. > > Fix this by using sa_mask to block V8's SIGPROFs while the > throttling handler is running. This makes more sense overall as well. > Our CPU samples would be skewed by whichever stacks we encounter > during throttling pauses. > > Bug: 1027242 > Change-Id: I80e856ce1e7b4744a9af7e36c2022b6d8610cf60 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012280 > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Commit-Queue: Peter Marshall <petermarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#733592} TBR=skyostil@chromium.org,sigurds@chromium.org,petermarshall@chromium.org Change-Id: Ic4c9d8c8616fd506bb34b006d27334cba3c96cf4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1027242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012963Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#733926}
-
Johannes Henkel authored
Upstream Review: "Remove writeJSON / toJSONString from generated protocol types." https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/2013082 In addition, remove no longer used method builderAppendQuotedString from v8_inspector_string.{h,cc}. New Rev: 6361d066985aafcb5c7d7b4066da0a0ecaa5866d Change-Id: I975ffa795b01cd44e16f9d8e42127a3c23528213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013314Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#733925}
-
Koji Ishii authored
Following bot results are included. 1062 1064 1069 1071 1072 1073 1074 1075 1077 1078 1079 1080 1081 1082 1083 45 lines were removed and 6 lines were deflaked by consecutive results since 1061. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: Iabe36ca8cee09897b6e815c9892cf47017d1b09e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010750Reviewed-by:
-
Sean Harrison authored
Also rename any function only used in tests as ...ForTesting() Bug: 1007223 Change-Id: Icba435869d4d78d48f021c989c2c340852bd122c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004989Reviewed-by:
-
Olga Sharonova authored
Failing TBR=vitaliii@chromium.org Bug: 1044514 Change-Id: I698c4527a69a6e689e4be99e145b1bbf7bef327b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013047Reviewed-by:
-
Andy Paicu authored
As a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/2003320 Added a test for the new logic and fixed the test that was broken. Bug: 1042611 Change-Id: I26f29d782879f28272fc5d544c0a783b7dc948de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010789 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Auto-Submit: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#733921}
-
Olga Sharonova authored
This reverts commit 9ff29d67. Reason for revert: <INSERT REASONING HERE> Original change's description: > Roll src/third_party/devtools-frontend/src 564dcf4c071b..28a405e6e578 (1 commits) > > https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/564dcf4c071b..28a405e6e578 > > git log 564dcf4c071b..28a405e6e578 --date=short --first-parent --format='%ad %ae %s' > 2020-01-22 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. > > Created with: > gclient setdep -r src/third_party/devtools-frontend/src@28a405e6e578 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/devtools-frontend-chromium > Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > Bug: None > Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com > Change-Id: I5bb1aadf2b46e6a7722af2fd200c0118ae1cbe16 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014154 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#733886} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I725c77303c6a5a2d4fb76b8b24320e0a4eedbf54 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014443Reviewed-by:
-
Olga Sharonova authored
This reverts commit aaab30e7. Reason for revert: BUG:1044520 Original change's description: > Local NTP: make past search matches change realbox icon to clock > > R=mahmadi@chromium.org > > Fixed: 1043335 > Change-Id: I98b1fbcc0a5b5e0d48334e8eb33a31c66f07a4fe > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008614 > Auto-Submit: Dan Beam <dbeam@chromium.org> > Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> > Commit-Queue: Dan Beam <dbeam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#733854} TBR=dbeam@chromium.org,mahmadi@chromium.org Change-Id: I2b2371de6ae0e3144a3bd827539526864859c570 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013245Reviewed-by:
-
Naoki Fukino authored
When ImageLoader get requests to process image files, it checks message sender's id to disallow requests from unknown clients. However, sender's id is currently not trustworthy (issue 982361). We should use sender's origin instead as a short-term fix. Bug: 10321587 Test: Manual test on Files/Gallery to show thumbnails from ImageLoader. Change-Id: Idb61850795828a63b37aa43b66d4875ad7abbfc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989728 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#733918}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/c3e55aa23f88..a216865467dd git log c3e55aa23f88..a216865467dd --date=short --first-parent --format='%ad %ae %s' 2020-01-21 tsepez@chromium.org Add doubleclick event handling to pdfium_test_event_helper.cc 2020-01-21 thestig@chromium.org Fix some nits in CPDF_TextPage code. Created with: gclient setdep -r src/third_party/pdfium@a216865467dd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1043510 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I9254e43b033930e1573eccc14e5d5a0e9f8bc9d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013907Reviewed-by:
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=mahmadi@chromium.org Bug: 1042208 Change-Id: Ia971578b2b012398b81c4a14d206732411f384b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007581Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#733916}
-
Yutaka Hirano authored
This is enabled only when Out-of-Renderer CORS is enabled. Bug: 835821, 724929, 876678, 876670, 876669, 876668, 876666, 848275 Change-Id: Ia6a3553797007f9bb905de8b84d39ec7b2370d1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011786 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#733915}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/material-foundation/material-roboto-font-loader-ios/+log/4aa51e906e56..bc63eabbbd1e git log 4aa51e906e56..bc63eabbbd1e --date=short --first-parent --format='%ad %ae %s' 2019-04-10 rsmoore@google.com Revert "Remove unneeded fonts and unhint others. (#17)" (#19) 2019-04-10 rsmoore@google.com Revert "Remove extra `self = [super init]`. (#15)" (#18) 2019-04-10 dmaclach@gmail.com Remove unneeded fonts and unhint others. (#17) 2019-04-10 ccrazy88@users.noreply.github.com Remove extra `self = [super init]`. (#15) Created with: gclient setdep -r src/ios/third_party/material_roboto_font_loader_ios/src@bc63eabbbd1e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/material-roboto-font-loader-ios-chromium Please CC bling-p10-rolls@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:ios-internal-mdc Bug: None Tbr: bling-p10-rolls@google.com Change-Id: I86df0fb78be3e2361d85316ad293d926a4194c37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013203Reviewed-by:
-
Sean Harrison authored
This reverts commit 0bfc424a. Reason for revert: Found cause of revert and fixed Original change's description: > [Sheriff]: Revert "More Settings Page Interaction UMA" > > This reverts commit 561bf1af. > > Reason for revert: > Strongly suspect this is causing failures on the debug builders: > [29058:775:0117/070736.663833:ERROR:CONSOLE(49)] "Mocha test failed: PersonalizationOptionsTests_AllBuilds signinAllowedToggle > Error: Uncaught TypeError: Cannot read property 'PRIVACY_CHROME_SIGN_IN' of undefined (chrome://settings/privacy_page/personalization_options.js:102) > > r732804 was reverted earlier for the same reasons, but there are still failures coming from the settings code, albeit less > > Original change's description: > > More Settings Page Interaction UMA > > > > Move the settings enum and the call to uma to a separate browser proxy. > > > > Add UMA to all site settings subpage interactions and new toggles moved to the main settings card > > > > Bug: 1032584 > > Change-Id: Icadd71d4511fa1f604f2d3acbda92c0e84700173 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967651 > > Commit-Queue: Sean Harrison <harrisonsean@chromium.org> > > Reviewed-by: Dan Beam <dbeam@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#732785} > > TBR=dbeam@chromium.org,harrisonsean@chromium.org > > Change-Id: Id4ee78d89487ecf7e6d1935088d02b29de89c7c8 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1032584 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007829 > Reviewed-by: Leonard Grey <lgrey@chromium.org> > Commit-Queue: Leonard Grey <lgrey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732870} Change-Id: Id60aa270741ac9305effac5a13587eb1a1d89102 Bug: 1032584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007716Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#733913}
-
Colin Blundell authored
SSLErrorHandler is on course to being componentized for sharing with WebLayer. It currently internally triggers extension events when security interstitials are shown. As this is //chrome-level behavior that cannot be componentized, this CL gives SSLErrorHandler an API via which the client can set a callback that is triggered on showing of security interstitials. Bug: 1030692 Change-Id: Ic3846d62c598af55ae64d880b229b37f1a12390c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010943Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#733912}
-
