- 12 Sep, 2016 40 commits
-
-
wangxianzhu authored
- Move back svg/hixie/perf/00?.xml tests; - Remove entries in enable-slimming-paint-v2 referencing moved tests; TBR=wangxianzhu@chromium.org Review-Url: https://codereview.chromium.org/2329413003 Cr-Commit-Position: refs/heads/master@{#417966}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/32f19b159dd6..9d32403a467f $ git log 32f19b159..9d32403a4 --date=short --no-merges --format='%ad %ae %s' 2016-09-12 rnephew [BattOr] Fix error in catching BattOr exception. BUG=645106 TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2335543003 Cr-Commit-Position: refs/heads/master@{#417965}
-
qiangchen authored
We set border color for source item to indicate it is selected. But the color is just light grey on Windows and ChromeOS, and thus hardly visible. We changed to use kColorId_FocusedBorderColor, which looks good on all platforms. BUG=643292 Review-Url: https://codereview.chromium.org/2323913002 Cr-Commit-Position: refs/heads/master@{#417964}
-
jdonnelly authored
This is no longer in use as of https://chromereviews.googleplex.com/494267014/. BUG=602666 Review-Url: https://codereview.chromium.org/2333483002 Cr-Commit-Position: refs/heads/master@{#417963}
-
miimnk authored
BUG=604452 R=dimu,prasadv@chromium.org Review-Url: https://codereview.chromium.org/2236703003 Cr-Commit-Position: refs/heads/master@{#417962}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1e7f076a..63168824 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2336633002 Cr-Commit-Position: refs/heads/master@{#417961}
-
joedow authored
This change moves the confirmation dialog prompt used in It2Me from the beginning of the connection flow to the point where we know the client JID. This change allows the user to have more control over who connects to their session (they can effectively 'see who is calling' and reject it if it isn't an address they recognize). BUG=645540 Review-Url: https://codereview.chromium.org/2310303002 Cr-Commit-Position: refs/heads/master@{#417960}
-
ehmaldonado authored
BUG=497757 Review-Url: https://codereview.chromium.org/2331993002 Cr-Commit-Position: refs/heads/master@{#417959}
-
kozyatinskiy authored
BUG=642496 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2318853002 Cr-Commit-Position: refs/heads/master@{#417958}
-
rbyers authored
Adds a new UMA histogram "WebCore.UseCounter_TEST" which fixes the issue with data loss on fast shutdown while temporarily preseving the original semantics in the legacy "WebCore.FeatureObserver" histogram. Also overhauls the tests to look directly at the histograms. Note that the semantics of the new UseCounter are still under flux and being validated, hence the '_TEST' suffix in the histogram name. Once validated it'll be renamed to simply WebCore.UseCounter and we will expect to never change the semantics of the histogram again (without rename). BUG=597963 Review-Url: https://codereview.chromium.org/2290733002 Cr-Commit-Position: refs/heads/master@{#417957}
-
estade authored
Adjusts layout for the badges (they extend past the edge of the signal icon). The old raster badges are still used rather than vectorized assets. BUG=617301 Review-Url: https://codereview.chromium.org/2321153002 Cr-Commit-Position: refs/heads/master@{#417956}
-
rdevlin.cronin authored
Fix the invalid border-bottom css in detail_view. BUG=529395 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2327833003 Cr-Commit-Position: refs/heads/master@{#417955}
-
lukasza authored
The rename is needed to avoid a naming collision after changing from Blink to Chromium naming style. Right now we have a |BlobRegistry| type and a |blobRegistry| function (differing only by case of the first character); after a naive rename by the rewrite_to_chrome_style tool we would end up with |BlobRegistry| being the name of both the type and the function (with both living in the same namespace). Prepending a "get" prefix to the name of the accessor method is the workaround that fits into the guidance on the recommended post-Blink-to-Chromium-rename style suggested by esprehn@ in https://crbug.com/582312#c17: - Getters favor not using "Get", ex. FirstChild() - Unless the type name conflicts, in which case you can either rename the type if it's easy and makes sense, or add "Get", ex. GetContext(). BUG=582312 Review-Url: https://codereview.chromium.org/2329683002 Cr-Commit-Position: refs/heads/master@{#417954}
-
reed authored
future CL: https://codereview.chromium.org/2333713002/#ps60001 Deprecate SkData* copyToData() and replace with sk_sp<SkData> asData / snapshotAsData / detachAsData () BUG= NOTRY=True Review-Url: https://codereview.chromium.org/2336443004 Cr-Commit-Position: refs/heads/master@{#417953}
-
geofflang authored
Supress new failures from this roll: https://codereview.chromium.org/2331823002 TBR=zmo@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2337493002 Cr-Commit-Position: refs/heads/master@{#417952}
-
xlai authored
In my previous patch (https://codereview.chromium.org/2294963002/) I had some primitive ideas about disallowing resizing on OffscreenCanvas. This CL makes it more assertive by throwing exception (not just causing no effect) to alert users. BUG=563852 Review-Url: https://codereview.chromium.org/2330553002 Cr-Commit-Position: refs/heads/master@{#417951}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/2a78fca05416..d99858ad46ca $ git log 2a78fca05..d99858ad4 --date=short --no-merges --format='%ad %ae %s' 2016-09-12 jvanverth Update SampleAndroidShadows to use algorithm closer to Android OpenGL CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=djsollen@google.com Review-Url: https://codereview.chromium.org/2333763002 Cr-Commit-Position: refs/heads/master@{#417950}
-
arthursonzogni authored
With enable-browser-side-navigation, ResourceRequests were not upgraded in case of a navigation. Request upgrade is now made few line above, just before being intercepted by shouldContinueForNavigationPolicy. BUG=576270 Review-Url: https://codereview.chromium.org/2284683002 Cr-Commit-Position: refs/heads/master@{#417949}
-
sdy authored
…for now. BUG=642155 Review-Url: https://codereview.chromium.org/2325313002 Cr-Commit-Position: refs/heads/master@{#417948}
-
danzh authored
lazy allocation and early release memory in QuicStreamSequencerBuffer. Protected by --quic_reduce_sequencer_buffer_memory_life_time. Postpone the instantiation of the underlying buffer in QuicStreamSequencerBuffer till receiving first data frame, this will make GET request cheaper. And release the memory as soon as the stream is read closed. Merge internal change: 131985218 and 132338729 R=rch@chromium.org BUG=635041 Review-Url: https://codereview.chromium.org/2328633004 Cr-Commit-Position: refs/heads/master@{#417947}
-
dtapuska authored
BUG=642368 Review-Url: https://codereview.chromium.org/2324803005 Cr-Commit-Position: refs/heads/master@{#417946}
-
jam authored
When a redirect between HTTPS URLs occurs, the default policy will check that the referrer is only set if it's allowed (i.e. both URLs are secure). However for the PlzNavigate stream request occurs, the destination will be a blob:https scheme and net/ will treat it as insecure and remove the referrer (see URLRequestJob::ComputeReferrerForRedirect). Then URLRequest::StartJob will find a referrer mismatch and cancel the request. The fix is to not tell the net layer about the referrer for the PlzNavigate stream requests; it's not needed by the stream request job in content/, and it's already been checked/used for the http request earlier. This fixes: SSLUITest.ClientRedirectFromMixedContentSSLState SSLUITest.ClientRedirectToMixedContentSSLState SSLUITest.TestBadFrameNavigation SSLUITest.TestUnsafeContents BUG=504347 Review-Url: https://codereview.chromium.org/2333513002 Cr-Commit-Position: refs/heads/master@{#417945}
-
rnk authored
The test increments 256 bytes of code starting from the beginning of the DLL, and if we don't pad out DummyExport, it will modify DllMain, which can run when a thread starts. R=grt@chromium.org,thakis@chromium.org BUG=645544 Review-Url: https://codereview.chromium.org/2327193002 Cr-Commit-Position: refs/heads/master@{#417944}
-
hs1217.lee authored
Return the result of invoking create a matrix of type DOMMatrixReadOnly or DOMMatrix as appropriate, with a sequence of numbers taking the values from Float32Array or Float64Array in the provided order. If array has 6 elements, Return a 2d matrix. If array has 16 elements, Return a 3d matrix. Otherwise, Throw a TypeError exception. spec list: https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-fromfloat32array https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-fromfloat64array https://drafts.fxtf.org/geometry/#dom-dommatrix-fromfloat32array https://drafts.fxtf.org/geometry/#dom-dommatrix-fromfloat64array BUG=388780 Review-Url: https://codereview.chromium.org/2309013002 Cr-Commit-Position: refs/heads/master@{#417943}
-
agrieve authored
Previously reverted in: https://codereview.chromium.org/2333593002/ Reason for reland: Removed offending import for real this time. BUG=622855 Review-Url: https://codereview.chromium.org/2335663002 Cr-Commit-Position: refs/heads/master@{#417942}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5b10f96b..1e7f076a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2330863005 Cr-Commit-Position: refs/heads/master@{#417941}
-
foolip authored
https://w3c.github.io/mediacapture-main/#device-info BUG=645903 R=guidou@chromium.org,rbyers@chromium.org Review-Url: https://codereview.chromium.org/2335553003 Cr-Commit-Position: refs/heads/master@{#417940}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/46f2d0ad0d0e..2a78fca05416 $ git log 46f2d0ad0..2a78fca05 --date=short --no-merges --format='%ad %ae %s' 2016-09-12 reed helper to SkRect to create from SkISize 2016-09-12 reed check for identity in translate 2016-09-12 reed fix code behind SK_SUPPORT_LEGACY_MINOR_EFFECT_PTR CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=djsollen@google.com Review-Url: https://codereview.chromium.org/2335653002 Cr-Commit-Position: refs/heads/master@{#417939}
-
Nico Weber authored
https://codereview.chromium.org/2317123004 switched the Android bits of the script to the new .py script. That script needs an explicit --force flag to clobber old Android toolchains, else it errors out with Running make_standalone_toolchain.py --api=21 --install-dir=... --stl=stlport --arch=arm64 Installation directory already exists. Use --force. Failed. if the --install-dir already exists (for example, from a previous build). BUG=644977 TBR=hans@chromium.org Review URL: https://codereview.chromium.org/2336463003 . Cr-Commit-Position: refs/heads/master@{#417938}
-
pilgrim authored
Direct access to LayoutPart is deprecated and being removed soon. The replacement is LayoutPartItem, which routes methods through the new block layout API. (See linked crbug for details.) This means the ownerLayoutObject() method is also deprecated, to be replaced with ownerLayoutItem(). There are no functional changes. BUG=499321 TBR=eae@chromium.org Review-Url: https://codereview.chromium.org/2326883003 Cr-Commit-Position: refs/heads/master@{#417937}
-
agrieve authored
Review-Url: https://codereview.chromium.org/2322253003 Cr-Commit-Position: refs/heads/master@{#417936}
-
peria authored
After this change, we maybe able to skip needless compiles based on redundant dependencies. (issue 388172) Plus, it is expected to compile those files in parallel. This CL is same with http://crrev.com/2318933002/ with a fix. The fix is to aggregate them only on Windows Official build, where we need to preserve symbol table. BUG=634231, 388172 Review-Url: https://codereview.chromium.org/2325973002 Cr-Commit-Position: refs/heads/master@{#417935}
-
hanxi authored
This is a follow up CL to address the remaining comments on CL (https://codereview.chromium.org/2290603005/). BUG=627250 Review-Url: https://codereview.chromium.org/2324263002 Cr-Commit-Position: refs/heads/master@{#417934}
-
tnakamura authored
BUG=None Review-Url: https://codereview.chromium.org/2327143002 Cr-Commit-Position: refs/heads/master@{#417933}
-
krb authored
Return a reference to the contained ImageView (the padlock) instead of the parent LocationIconView. The latter is quite wide when we fill in the label half of it, which we now do with site security level in some cases. The bubble (in the bug that is in the wrong place) anchors to the middle of whatever View you return to it, so we really want to give it the padlock here. BUG=644222 Review-Url: https://codereview.chromium.org/2328983002 Cr-Commit-Position: refs/heads/master@{#417932}
-
alexclarke authored
base::Closure recently got an IsCancelled method. Taking advantage of that the scheduler can short circuit a bunch of logic for cancelled tasks and avoid running them and the rest of the task selection machinery. On the new TimerPerfTest benchmark this makes running 10000 cancelled tasks aprox 50x - 60x faster (measured on Android and Linux). Note this patch reverts many of the changes made in https://codereview.chromium.org/2258713004 in favor of WeakPtr based cancellation as favored by the base owners. NOTE it's possible this might break https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20ASAN I was not able to reproduce the ASAN failure locally however I suspect it's due to the Timer getting swept away which should be fixed by the change in the latest patchset. BUG=605718, 638542, 645876 Committed: https://crrev.com/e4e5868c5f32b015bf0d07a6eeace892d6a789a1 Review-Url: https://codereview.chromium.org/2319053004 Cr-Original-Commit-Position: refs/heads/master@{#417621} Cr-Commit-Position: refs/heads/master@{#417931}
-
cwallez authored
Revert of GPU driver bug list: remove the use program after link workaround (patchset #2 id:20001 of https://codereview.chromium.org/2326713002/ ) Reason for revert: Potential regression https://bugs.chromium.org/p/chromium/issues/detail?id=645498 Original issue's description: > GPU driver bug list: remove the use program after link workaround > > The origins of this workaround go waaaaay in the past and seem to > contradict themselves (only OSX, vs. not OSX) > > BUG=590870 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Committed: https://crrev.com/5d79fa21a0e1536b439584a8bce1f17fbc0c22b6 > Cr-Commit-Position: refs/heads/master@{#417397} TBR=zmo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=590870 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2326553004 Cr-Commit-Position: refs/heads/master@{#417930}
-
Rebaseline Bot authored
https://chromium.googlesource.com/chromium/src/+/c9f6b3de9 BUG=601247 TBR=kdsilva@google.com Review URL: https://codereview.chromium.org/2332773002 . Cr-Commit-Position: refs/heads/master@{#417929}
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/4dc30eb1033346466a9ecbb66a30490d92b95c80 WebRTC: Fix GYP iOS bots. (ehmaldonado@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG=webrtc:5949 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2329293003 Cr-Commit-Position: refs/heads/master@{#417928}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bf0a419b..5b10f96b Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2336563002 Cr-Commit-Position: refs/heads/master@{#417927}
-