- 03 Jun, 2019 40 commits
-
-
Austin Eng authored
Bug: dawn:7 Change-Id: I54979b37d1277a716a55d08120bcc9e42574c1c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637193 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#665564}
-
Patrick Meenan authored
Lower the priority of late-body stylesheets to match late-body blocking scripts (to Medium from VeryHigh). Now that in-body stylesheets no longer block render they should be loaded like late-body scripts. This will prevent them from being considered "render blocking" for loading from the network perspective and will cause them to load in-order with scripts (which is the desired behavior). Bug: 945841 Change-Id: Ib3578d0b900ef25080f2340ff0fd133e0e8117c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638900Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Patrick Meenan <pmeenan@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Patrick Meenan <pmeenan@chromium.org> Cr-Commit-Position: refs/heads/master@{#665563}
-
Nico Weber authored
No behavior change. Bug: none Change-Id: Icd4a8f7cfece1cb1d07902adda3e78ad872c84d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639153 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#665562}
-
Aga Wronska authored
Shelf should not be visible on Kiosk Next home screen. Starting drag gesture during transition to home screen can cause shelf remaining stuck and visible. To prevent that cancel drag gesture when home screen animation is finished. Bug: 968635 Change-Id: I89cfaebbfc9eed0e8ef916b382fdb88f470399f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638917 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#665561}
-
Anton Bikineev authored
Bug: 968707, 967258 Change-Id: Ib84a62f3484e0444d555d48c5f8fa5b28fc47389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638528Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#665560}
-
Sebastien Marchand authored
The cache is the equivalent of the LocalSiteCharacteristicsDataStore, there'll be one per profile. Bug: 961336 Change-Id: I1c55ac7283dea6e20ea853025c64c801fe9e9740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627661 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#665559}
-
kylechar authored
Remove some usage of deprecated callback types in ui/ozone/*. Where possible convert to the corresponding once type, otherwise replace with the repeating type. Also update PRESUBMIT so that deprecated callback types are banned in ui/ozone/*. Bug: 714018 Change-Id: Ida5c8c028435a220344981d09e508f3e0dd711b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637399 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#665558}
-
Stephane Zermatten authored
happen. Before this change, ConfigureBottomSheetAction would return immediately after asking for the viewport to be resized. Depending on how quickly that happened, a Focus action following ConfigureBottomSheetAction might see the window height before the resize and not be able to focus. The current workaround for that is to wait after resizing the viewport before focusing on an element, but the time it takes varies a lot. With this change, ConfigureBottomSheetAction waits until the viewport resize has been seen from the Javascript side, so we don't wait longer than strictly necessary. A maximum wait time avoids scripts getting stuck in this action. Bug: b/133665079 Change-Id: Ia37076710634542bb4f15c77f30275c234383cb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640408 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#665557}
-
Colin Blundell authored
DeviceOAuth2TokenServiceDelegate currently overrides OAuth2TokenServiceDelegate::RefreshTokenIsAvailable() but doesn't override OAuth2TokenServiceDelegate::GetAccounts(). The latter has a default implementation that returns an empty set of accounts. We have a goal of implementing OAuth2TokenService::RefreshTokenIsAvailable() on top of OAuth2TokenService::GetAccounts() as a means of enforcing semantic invariants around the relationship between these two methods (see bug for details). As a step toward enabling this enforcement, this CL changes DeviceOAuth2TokenServiceDelegate to implement GetAccounts() and implement RefreshTokenIsAvailable() in terms of GetAccounts(). As O2TSDelegate::RefreshTokenIsAvailable() is marked const but O2TSDelegate::GetAccounts() is not, this requires a bit of tap-dancing in the implementation. This tap-dancing will go away in the followup, which will change OAuth2TokenService to implement RefreshTokenIsAvailable() directly rather than via the delegates. This CL should have no behavioral impact, as an analysis done for separate reasons showed that GetAccounts() is never invoked on DeviceOAuth2TokenService: https://docs.google.com/document/d/1IeaTv_BQZfpYDgEeenozB-8W65vW2cpZsTeADeXt8RU/edit#heading=h.pukrhlvsi449 Bug: 919793 Change-Id: I628fbc6eded0fee8b460006a746b59ceeecac4ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640978Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#665556}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/eca66b32fdb9..fec9b902a626 git log eca66b32fdb9..fec9b902a626 --date=short --no-merges --format='%ad %ae %s' 2019-06-03 mtklein@google.com add unit scaling mode to benchmark/nanobench 2019-06-03 borenet@google.com [infra] Stop isolating the Android NDK 2019-06-03 jcgregorio@google.com Add 'modules' to doxygen generation. 2019-06-03 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (nontrivial). 2019-06-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 0a56f0e3d22d..98f2167125a8 (8 commits) 2019-06-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader c0d7ee45d45f..bb575d48d5f9 (3 commits) 2019-06-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 8e522297..f75363e4 (402 commits) Created with: gclient setdep -r src/third_party/skia@fec9b902a626 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Change-Id: Ie75fc529cdc951b659d9c9b7f6f11e018fccb865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641210Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665555}
-
Ella Ge authored
When mouse events are captured, we use the capturing element instead of doing hit test. The local_point is computed by AbsoluteToLocalPoint, but we didn't apply transfroms. This is wrong and causes selection incorrect when there is transform. This CL removes the incorrect kIgnoreTransforms. Bug: 969695 Change-Id: Icfcaf627f58999f037b793feeb3fe712a827ca8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634719 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#665554}
-
Scott Violet authored
This code was necessary to avoid forcing a remote client to be visible until occlusion tracking was enabled. Now that mash is no more, there are no remote clients and this can be removed. BUG=961763 TEST=none Change-Id: I05d9603b82a14a1b394287540747e6b84269cb28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635292 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#665553}
-
Ryan Sturm authored
Change-Id: I4830739df4bf4458d9299cc9cc860f69bb4553c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636571Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#665552}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=sdefresne@chromium.org Change-Id: I6981ec15a6730394d64090021a8c58ce88f7ec3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636191Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#665551}
-
Henrique Ferreiro authored
This is a step in eliminating the inheritance relationship between SigninManager and SigninManagerBase, as motivated in this design doc: https://docs.google.com/document/d/15y-Db27BV08vrIyelHB-3CwiAfDYh-FigNKGXrqSWto/edit#heading=h.8jjdy95t6p7x and described concretely here: https://docs.google.com/document/d/15y-Db27BV08vrIyelHB-3CwiAfDYh-FigNKGXrqSWto/edit#heading=h.mbkrv9nkb93w The functionality is ifdef-d out on ChromeOS, as it is currently not used on that platform. However, in the near term we will enable it on ChromeOS as part of unifying the flow of setting the primary account between ChromeOS and desktop. Bug: 952766 Change-Id: I4b408b0a9ead28367ef07fb06f7950609be4b369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565315 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#665550}
-
Jordan Demeulenaere authored
* Before: https://screenshot.googleplex.com/a7bmH8ZzaVL.png * After: https://screenshot.googleplex.com/3speSGf6PEA.png Screenshots: Change-Id: I60cd9b7b700af31ef571ce3f7e204b61126444d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639391Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#665549}
-
Chris Hamilton authored
This moves the per-node type observers to the public interface, and adds support for registering observers of this type to GraphImpl. This allows reimplementing all existing GraphObserver implementations using the public interface. BUG=910288 Change-Id: Ie712de6301562f13b32f1fef10765f1d48aecd94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632097 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#665548}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4cd1c6a3db4c..1df841d446eb git log 4cd1c6a3db4c..1df841d446eb --date=short --no-merges --format='%ad %ae %s' 2019-06-03 sakal@webrtc.org Target SDK level 29 in AppRTCMobile. 2019-06-03 eladalon@webrtc.org Buffer RTCP feedback messages in RtpVideoStreamReceiver Created with: gclient setdep -r src/third_party/webrtc@1df841d446eb The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I45661d2131a6a9b260f99ec23a22c52be1c37d64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640915Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665547}
-
Rune Lillesveen authored
Change-Id: I199db5d33a571a07e5bc9cc41ea4ac29a3295890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637560Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#665546}
-
Rune Lillesveen authored
The Scoped* helpers will reset the modified runtime flag back for other tests. Change-Id: Ia8e0e914122393cc8e38101412fe3f88ce74fa3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637561Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#665545}
-
Henrique Ferreiro authored
TBR=jochen@chromium.org Bug: 967643 Change-Id: Ief655352c6b95489b3a13605f7721057d529c587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636197 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#665544}
-
Mark Mentovai authored
This reverts commit 28c84c16. Reason for revert: https://crbug.com/969587 Original change's description: > [Mac] Preserve symbolic links in the copy_bundle_data tool > > This is a reland of 6a008993, which was reverted in 235d842a. > (Thus, this is a revert of that revert.) > > Since the last attempt, the structure of the keystone_registration > bundle_data rule in third_party/googlemac (via src-internal DEPS) has > changed to avoid the dangling symbolic link problem previously > encountered. > > The description from 6a008993: > > The copy_bundle_data tool is implemented in terms of pax for directories > and ln hard links for files. The pax command does preserve symbolic > links within the tree that is being copied. But with the way that pax is > invoked by the tool, cd-ing into the source, if the source is itself > a symbolic link to a directory, the tree will be logically copied rather > than just as a symbolic link. > > A similar issue exists with the non-directory symbolic link source case, > where a hard link will be produced instead of a symbolic link. > > Fix both of these cases by specifically testing if the source is a > symbolic link and then re-creating it if so. > > Bug: 955936 > Change-Id: Ia13ddf743603e98337c3523e9101e7627e1c31d0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637673 > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Mark Mentovai <mark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#665203} TBR=thakis@chromium.org,mark@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 955936 Change-Id: I4de6596c29598961ac15fbd24acc54b1f763735a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639152Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#665543}
-
François Beaufort authored
This CL makes sure GPUVertexInputDescriptor indexFormat defaults to uint32 as spec'ed in https://github.com/gpuweb/gpuweb/pull/270 Bug: 877147 Change-Id: I625298abd78794a172d9296a511747b4363dbbe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641263 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#665542}
-
Mohammad Refaat authored
Bug: 911350 Change-Id: I3bc67c92eb9936fc72f6046a952dbc24a517599c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638680 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#665541}
-
Roman Sorokin authored
* Don't shrink SAML window - it hosts oobe-dialog anyway (which has fixed size) * Remove outdated css rules - it caused buttons be white on white (so not visible but active) * Stop showing back button on top at all - the screen has bottom back butotn now * Fix glitch with refresh button - it was shown for a second when isManualEnrollment_ was not yet defined. Bug: 965392 Change-Id: I680d7471a53a4e8c17aae4c37433633e120c11a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640643Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#665540}
-
Yutaka Hirano authored
Use blink::UseCounter instead. This CL keeps CountUsage and CountDeprecation on BaseFetchContext (and subclasses). They may also be replaced by the use counter in the future. Bug: 914739 Change-Id: Ic8d00d8d47ad06e4d60d28cfee7fe88162c49cad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636666 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#665539}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: If81534f6f4987a3b3ed236efa06a90a024db8116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640910Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665538}
-
Yutaka Hirano authored
Bug: 963306 Change-Id: If948bfa3c49f819d8c908b3f4d179882c441427a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640919 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#665537}
-
Stephane Zermatten authored
viewport height. This change fixes issues with the event filter of the overlay not adapting to viewport height changes. With this change, the position of highlighted elements are reported as CSS pixels, relative to the page, instead of coordinates relative to the viewport size. The viewport size and position within the page is tracked and reported separately. When displaying or comparing against filter coordinates, CSS pixels are converted into physical pixels using the viewport width, which allows adapting to zoom. This change also simplifies the display of the highlighted area by ignoring the offset reported to the onScroll methods as it was causing issues. This allows the model to cache the element position and the visual viewport position independently; when scrolling, unless the element position is absolute, element position normally stay the same and only the viewport changes. Bug: b/133669408 Bug: b/129050125 Change-Id: I745584b496d960a2d73231238dd2006afb3f7eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634737Reviewed-by:
Jordan Demeulenaere <jdemeulenaere@chromium.org> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#665536}
-
Jan Krcal authored
This CL extends the range of the E2E latency metrics from 1 hour to 1 week. Bug: 966375 Change-Id: I4346b0538fed3d60480e8ccd7c4cfda5b87a8654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626596 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#665535}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ddbb5499..0ec93e04 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I722b0102bbd8a7bd5ed0d1562b6c7bc09f1566a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640775Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665534}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/114e8bb7a68f..4cd1c6a3db4c git log 114e8bb7a68f..4cd1c6a3db4c --date=short --no-merges --format='%ad %ae %s' 2019-06-03 gustaf@webrtc.org Lockless SwapQueue 2019-06-03 barrerap@webrtc.org Allow neteq_quality_test to read a complete file 2019-06-03 fhernqvist@webrtc.org Add fhernqvist to watchlist. 2019-06-03 barrerap@webrtc.org Expose audio decoder factory in neteq_quality_test 2019-06-03 nisse@webrtc.org Delete deprecated StartRtcEventLog override with PlatformFile 2019-06-03 hta@webrtc.org A threading explanation 2019-06-02 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 97b44755..aaa0f87a (665322:665423) Created with: gclient setdep -r src/third_party/webrtc@4cd1c6a3db4c The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I9628971678d606b61a485819c8e65364999ef3a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640909Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665533}
-
Morten Stenshorne authored
We cannot safely assume, based on display type, that a DETAILS or SUMMARY element is going to establish a new formatting context, since they may ignore the display type and just create a regular block container (which doesn't necessarily establish a new formatting context). Bug: 969619 Change-Id: Ie59fe7301f8706cd4d39b3312fe6748c4ffb17e6 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640410Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#665532}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/98f2167125a8..12a524231f53 git log 98f2167125a8..12a524231f53 --date=short --no-merges --format='%ad %ae %s' 2019-06-03 aleino@nvidia.com Sharpen GL test skip condition for NVIDIA 2019-06-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src 6d88284607d2..a549bb817523 (2 commits) 2019-06-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 209ff0ce90ce..699e167d78ee (3 commits) 2019-06-03 jiajia.qin@intel.com Fix needStructMapping Created with: gclient setdep -r src/third_party/angle@12a524231f53 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Change-Id: I82aeba86cc8a306b8b603db831db01e5ecd53f9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640911Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665531}
-
Mohammad Refaat authored
Replace usage of TabModelObserver's didChangeTab with WebStateObserver's didStartNavigation. Bug: 911350 Change-Id: I35125a96a053e2ed4f27bfadfcb5a732d33d807a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630231Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#665530}
-
Tim Volodine authored
When the network service is disabled the Android WebView's DownloadListener.onDownloadStart() callback gets executed twice for the same url. This is due to the new code path (via AwDownloadManagerDelegate) which is intended to be executed when the network service is enabled is also run when it is disabled. This patch ensures that the new code path only runs when the network service is enabled. BUG=961264,841556 Change-Id: Ieec4a330d9d04173cf12ba23c90d9c37df08af47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638526Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#665529}
-
Findit authored
This reverts commit 0fdf975b. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 665506 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMGZkZjk3NWI3MDRjMTI5MDdlMThhYzA1NTQ1N2YwZDQ0M2E3ODMwNgw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.12%20Tests/23593 Sample Failed Step: webkit_layout_tests on Intel GPU on Mac on Mac-10.12.6 Sample Flaky Test: virtual/blink-cors/http/tests/security/mixedContent/insecure-css-resources.html Original change's description: > OOR-CORS: Setup virtual layout tests for non OOR-CORS mode > > Now the OOR-CORS is enabled by default at m76, but we want to > run some of layout tests w/o OOR-CORS for the potential risk > to postpone the launch beyond the m76. Legacy code path should > work well until then. > > Bug: 905971 > Change-Id: Ife79c90a031c9b729c629509da83e1ff2ac2a2c4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635081 > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#665506} Change-Id: Ia6e60951a4f08bbc4372600be6d37d1dab465e9f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 905971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640150 Cr-Commit-Position: refs/heads/master@{#665528}
-
Robert Ma authored
The new exception is added in preparation of: https://github.com/web-platform-tests/wpt/pull/16864 Also remove the unnecessary slashes from the regexes: '\' does not need to be escaped again in Python raw strings. Change-Id: I3453468b138f40e2adf1c7aaffa0076fbdb5f649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636390 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#665527}
-
Friedrich Horschig authored
Before this CL, we would occasionally crash when refreshing suggestions for a field right after it was unfocused. To prevent this, we now check that the focus is set and if it isn't, we use an opaque origin for which we can never have suggestions since it is a unique Nonce element. Bug: 957549 Change-Id: I4118b5ea9b7d44416f2f5b3d652cba348487c2df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635570 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#665526}
-
Vladislav Kuzkokov authored
Updating code w.r.t. coding conventions: https://chromium.googlesource.com/chromium/src/+/lkgr/styleguide/c++/c++.md#object-ownership-and-calling-conventions Bug: 968109 Change-Id: Ib6aef90f69bfc10e7fe792502456427fce82a0e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639217Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#665525}
-