- 12 Apr, 2019 40 commits
-
-
Becca Hughes authored
Add about flags entry for the media session notifications on Chrome OS and another for the ARC blocking feature. BUG=897836 Change-Id: Ia2faeabae8f31438b984656871a9e4c3b72767d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555240 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#650410}
-
Jamie Madill authored
This removes mac_angle_rel_ng and linux_angle_rel_ng from various config files. These configs are replaced with mac-angle-rel and linux-angle-rel. Bug: 822310 Tbr: jbudorick@chromium.org Change-Id: Id533c874106947517cfd93fb5bcbc92e2b31c4c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565246 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#650409}
-
Devlin Cronin authored
Add some basic unit tests for parsing all extension action types ("browser_action", "page_action", and "action") in the manifest. Bug: 893373 Change-Id: I8484377858ca5c837eb649a16c473ed0f0f91140 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562615 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#650408}
-
Scott Violet authored
Calling SetProperty() with the same value notifies the server. Some properties we change quite often, even to the existing value. There is no reason to notify the server in this case as it results in unnecessary messages. I originally wanted to early out in SetPropertyInternal(), and not notify observers as well, but it turns out there is some code relying on current behavior. I filed a bug on that. BUG=951015 TEST=covered by test Change-Id: I36f33976ba044afe872347314dc44305b7a224a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565505Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#650407}
-
Matt Menke authored
Previously, the HttpStreamFactoryJob would tell the HttpStreamFactoryJobController to have the SpdySessionPool to inform the HttpStreamRequest when an appropriate SpdySession was created. When that happened, the HttpStreamRequest would then pass the resulting stream to the JobController, which would then destroy the original job. This CL simplifies that by having the Job watch the SpdySessionPool directly, though it still informs the JobController when it gets the SpdySession, and the JobController then immediately deletes the Job. Bug: 912727 Change-Id: I9585f037e2028159a24064111d670faddfe2bdba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551562 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#650406}
-
Yann Dago authored
Visual: http://screen/f95xLi88ybU Bug: 951066 Change-Id: I31ddebbd8b41a291b668b24c47cc4a1e9db33c44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558686Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#650405}
-
Guohui Deng authored
ApplicationSessionIdManager must be extended to provide more media related information associated with application. Therefore replace it with ApplicationMediaInfoManager. No behavior change. Bug: internal b/110233576 Test: Manual cast and Internal CQ. Change-Id: I0b8a37f000d55933f740ca737ca1f88f21db5cc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555355 Commit-Queue: Guohui Deng <guohuideng@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#650404}
-
Matt Menke authored
Instead of taking an HttpStreamRequest, SpdySessionPool::AddRequestToSpdySessionRequestMap() now takes a new delegate interface. It returns an object that can be deleted to cancel the request, instead of taking the HttpStreamRequest against to cancel. Instead of relying on the HttpStreamRequest to track what SpdySessionKey is being watched, the SpdySessionPool now handles that itself. Finally, the new delegate interface takes the SpdySession itself when a matching SpdySession is creating, and then makes the appropriate stream type on top of it, instead of requiring the SpdySessionPool to make a stream of the correct type. The new behavior more closely matches the common case where HttpStreamFactory::Job makes the streams. Bug: 912727 Change-Id: Icb1138e2f7438459019e9ed6f04e38aecf408c94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549900 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Paul Irish authored
Bug: 915945 Change-Id: I0301216c32a1792a7a23af49f530bd937137439b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566211 Auto-Submit: Paul Irish <paulirish@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#650402}
-
Mugdha Lakhani authored
This uses the discrete engagement level to potentially increase the interval between two periodic sync events. If the engagement with the site has fallen to zero/none, the registration is suspended. If it's more than that, the penalty is inversely proportional to the engagement score. The site engagement levels are set through Finch. The default values are: (code: https://cs.chromium.org/chromium/src/chrome/browser/engagement/ site_engagement_score.cc?rcl=9bb60bfa&l=85) MEDIUM_ENGAGEMENT_BOUNDARY = 15; HIGH_ENGAGEMENT_BOUNDARY = 50; According to this + logic in code, then, (Score is non-negative) Score == 0.0 --> NONE Score < 1.0 --> MINIMAL Score < 15.0 --> LOW 15.0 < Score < 50.0 --> MEDIUM 50.0 <= Score < 100 --> HIGH Else --> MAX. Bug: 925297 Change-Id: I64ca103722e7b6bdef4d9a7a0952d5edeb0cb0bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546094 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#650401}
-
Donn Denman authored
Updates some of the Contextual Searchcolors for Dark Mode. Changes: 1) Divider line separator on the right side of the Bar gets it's own color setting. 2) Progress Bar background needs to be drawn with a Dark-compatible color. 3) Theres a few lines above the promo that were not covered by anything, now we're piping through the promo background color so we can fill that. BUG=942638 Change-Id: I1a224ed9a86bcea9b68b6dfd6d8e0135c1b39843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553903 Commit-Queue: Donn Denman <donnd@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#650400}
-
Erik Chen authored
This reverts commit 8eec7f4c. Reason for revert: Rolling back change, as I don't intend to follow through with the remaining config changes, and I don't want to leave the iOS configs in a half-migrated state. Original change's description: > Remove custom iOS logic from mb. > > The public ios master/builders now have appropriate entries in mb_config.pyl > > Bug: 951182 > Change-Id: I500a3c00d47b7d5652654d14be2090c59214ed6f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561846 > Commit-Queue: Erik Chen <erikchen@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#649914} TBR=dpranke@chromium.org,erikchen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 951182 Change-Id: I816efd0db4d13c8003af496d146483610c6c688a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566230Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#650399}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ef3496095d1d..249b32178539 git log ef3496095d1d..249b32178539 --date=short --no-merges --format='%ad %ae %s' 2019-04-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5d453e25..f1e8910d (650211:650313) 2019-04-12 jeroendb@webrtc.org Revert "Make negotiationneeded processing in PeerConnection spec compliant." Created with: gclient setdep -r src/third_party/webrtc@249b32178539 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:740501 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I6f3237a9f8cbfa2b8ad04d2f45d0ef8416958866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566134Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#650398}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/9a9b83751995..0c227e21d110 git log 9a9b83751995..0c227e21d110 --date=short --no-merges --format='%ad %ae %s' 2019-04-12 yunchao.he@intel.com baseVertex in drawIndexed() should be int32, not uint32 2019-04-11 yunchao.he@intel.com Implement rasterization state for render pipeline - Part 1 2019-04-11 cwallez@chromium.org PushConstantsTest: Don't use additive blending Created with: gclient setdep -r src/third_party/dawn@0c227e21d110 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@chromium.org Change-Id: Id8238be449e53cf3114c61b93f49170c8c43dd76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566133Reviewed-by:
-
Robert Ma authored
Follow-up to https://crrev.com/c/1555413 Change-Id: I34e094eca9a1795d069d93ba58e97349896b3c4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565186Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#650396}
-
Jared Saul authored
Bug: 920385 Change-Id: I59c7a8230cbcc632b1c2725e24f6cd082f84deb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566092 Auto-Submit: Jared Saul <jsaul@google.com> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#650395}
-
Dan Beam authored
Global: * change all font-size: ##px to rem to scale to font size changes Headers: * remove useless h1 styles cuz there were no h1s * change h2 to h1 for a11y purposes, change h2 -> h1 styles * remove fluffy top margin from title (stale h1 code did this) Toolbar: * drop badly working --toolbar-height in favor of defined px value (based on height of #header in x-small and x-large font sizes) * change margin -> padding for taking up header space Search: * fix magnifying glass icon color with /dark/ path * fix (X) clear search icon with -webkit-mask Media queries/mobile: * remove stale media query for top padding for smallish screens * make warning 1 line (block + bottom margin) on smallish screens * make version number look better for smallish screens * remove stale media query for top padding for really short screens Promos: * remove bottom padding from #promos * make .promo -> #promos (cuz it's a 1 instance class...) * hide #promos when both dev/beta promos aren't showing (extra space) * start #promos as hidden to avoid flicker R=dpapad@chromium.org Bug: 951284 Change-Id: Idc12db3afbcfb5313d9988fadabfbf95556fcaec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565531Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#650394}
-
Becca Hughes authored
The media notification should derive its foreground color from its artwork and background color. This ports an algorithm from Android. Also breaks out some of CalculateProminentColors so we can use it without recomputing swatches. BUG=944598 Change-Id: Ib4964a6668f8895da361eaf1243c29de570eed6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543929Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
-
chrome://offline-internalsIan Wells authored
OfflineInternalsUIMessageHandler::HandleScheduleNwake passes its first JS argument |callback_id| along to ScheduleNwakeWithGCMToken as a base::Value pointer whose target is destroyed before ScheduleNwakeWithGCMToken runs. This CL retrieves |callback_id| as a std::string which we can ensure still exists when passed to ResolveJavascriptCallback. Bug: 952047 Change-Id: If9267e894ab21947d29798094d3129108e2964c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565533 Commit-Queue: Ian Wells <iwells@chromium.org> Reviewed-by:
Dan H <harringtond@google.com> Cr-Commit-Position: refs/heads/master@{#650392}
-
Guohui Deng authored
Rename application_session_id_manager.h/cc/mojom to application_media_info_manager.h/cc/mojom. We plan to extend ApplicationSessionIdManager service, to not only provide |application_session_id|,but also a flag indicating if a feature MIXER_AUDIO is enabled on an application. Therefore, this service is better renamed to ApplicationMediaInfoManager. Bug: internal b/110233576 Test: None. Change-Id: I5d48e455ad8425f91c63b6a463d77326e7ac4d68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553829 Commit-Queue: Guohui Deng <guohuideng@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8b16114cd927..157a60421da8 Created with: gclient setdep -r src-internal@157a60421da8 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@chromium.org,andypaicu@chromium.org,aboxhall@chromium.org,caseq@chromium.org Change-Id: Ia36d4c875a309b35dec5295512c8b5f4fb677558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565429Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#650390}
-
Abhishek Arya authored
R=mmoroz@chromium.org,metzman@chromium.org TBR=maxmorin@chromium.org Change-Id: I3929bc2a22537cc0f83aec69693e99b8ae10223a Bug: 952036 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565241 Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#650389}
-
Alexandre Frechette authored
Bug: 949163 Change-Id: Id6199a2101c1507944c40c3cad8d2e993e9cafe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551120Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Alexandre Frechette <frechette@chromium.org> Cr-Commit-Position: refs/heads/master@{#650388}
-
Sammie Quon authored
Also fix some issues with the no windows indicator with spltiview. 1. The indicator did not move with the divider. 2. The indicator did not show up if we were in single screen splitview and closes the last overview item. Test: added tests Bug: b/123305266 Change-Id: I27070abb6522798a07c87c65e49a07b38153a24b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565243Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#650387}
-
John Budorick authored
This CL: - updates isolate command ordering s.t. generated_scripts take precedence over android-specific logic. - updates how resource_sizes initializes devil - updates resource_sizes's data dependencies in GN Bug: 807273 Change-Id: Iec18b856db14e0ee15720ca75f94c312f24139be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565245Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#650386}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/25071cc52b4b..bb85b8b3f306 git log 25071cc52b4b..bb85b8b3f306 --date=short --no-merges --format='%ad %ae %s' 2019-04-12 reed@google.com remove dead code from old factories, enum 2019-04-12 mtklein@google.com replace Sk4px with SkVx in SkBlitter_ARGB32 2019-04-12 brianosman@google.com GLSL editing in Viewer 2019-04-12 michaelludwig@google.com Make sure local rects are sorted post-clipping Created with: gclient setdep -r src/third_party/skia@bb85b8b3f306 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:946338 TBR=egdaniel@chromium.org Change-Id: Id1a8d25de7c7e6f07f6b74beaace4ae6dbc9140c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566131Reviewed-by:
-
Daniel Cheng authored
Bug: 842296 Change-Id: Icd829ed8d1f60d05fed1b73fecf4b4b587091ecd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566153 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#650384}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e473fe19..485dd5e5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id5b74bab838941812f368d6b8d161770c1e1ca67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565185Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#650383}
-
Theresa authored
Nothing uses DrawerLayout in these widgets anymore. Remove dependency to try to reduce binary size and simplify API/code. BUG=952026 Change-Id: I051e41f09f9ee6315f6b07259a99872391d5a963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565305Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3771ffb1. With Chromium commits locally applied on WPT: 0a8f3ffa "Use testdriver Action API in WPT pointerevent touch tests - Part 2" adc34f41 "Fix web_test pointerevent_coordinates_when_locked on wpt" e525003f "Do not resume a suspended BaseAudioContext when AudioWorklet starts" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-flexbox foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I67c2fd09b0a8d6ce1bc705cf05e27aad82ca8d21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566041Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#650381}
-
Natalie Chouinard authored
leveldb_proto databases will soon be migrated from unique LevelDB instances to a single shared underlying database. Because of this, we need to migrate to the new API to construct and initialize the database. Also removes some unnecessary logging and redundant metrics. Bug: 941794 Change-Id: I2327708d434175b85c2a1801dd498b06057ab2aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559753Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#650380}
-
Edin Kadric authored
This works well, except it still shows an arrow that can display a single menu item. Instead we may want to just make it a Textfield when there is only one option. Bug: 947187 Change-Id: I7639b115d7f443979dbd8962d1f3b7a315264081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559879 Commit-Queue: Edin Kadric <edinkadric@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#650379}
-
Mei Liang authored
This CL adds the following histogram for tabgroup: * TabGroups.SessionsPerGroup In addition, this CL updates TabStrip.TabCountOnPageLoad histogram to record 1 instead of 0 if the tab strip is shown. This is because the tab strip behavior change recently. Bug: 949850 Change-Id: Ide0142f72ff42b83ea8e6b14875c33d2e6d1c2cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553875Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#650378}
-
Scott Violet authored
Specifically Ash.SplitViewResize.PresentationTime.MaxLatency should be listed for SplitViewResizeModes too. BUG=923159 TEST=none Change-Id: I0471d21a133f9c0e13d43cc457db5f0d50c09f30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564872 Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
-
Henrique Ferreiro authored
As advised in [1], this CL ports calls to Foo::Create() factory functions to use MakeGarbageCollected<Foo> from classes in //third_party/blink/renderer/core/svg. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: I87d6150944e4e72e473dd5d1a549a2934404f798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564153 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#650376}
-
Sigurdur Asgeirsson authored
It appears that it's rarely possible for the TabHelper to observe deletion notifications for frames it newer observed as creatd. The hypothesis is that this will happen when the frame's associated process has died by the time the TabHelper attaches. This change simply ignores notifications for frames that haven't been observed, but the the longer term fix is to add an explicit accessor for the creation flag to WebContents. Bug: 948088 Change-Id: I178fdf49de99133e9524e30257d62e536b77b30e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565237 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#650375}
-
Peter E Conn authored
This change is apart of a larger sequence of CLs for implementing notification delegation auto-enrolment. See https://crbug.com/945258. Bug: 945276 Change-Id: I31fa51f75d4fc0f9463746da017f184af2c6a039 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550440 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Anne Lim authored
In the GetDetailsForSaveCardResponse proto, |supported_card_bin_ranges_string| is now received instead of |supported_card_bin_ranges|. The string is then parsed, to create a list of pair of numbers representing ranges of supported card bins. Bug: 944317 Change-Id: Ifd46d90674782c28e6adb31959fd868c47ec4aed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565495 Commit-Queue: Anne Lim <annelim@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#650373}
-
Xianzhu Wang authored
This is a speculative fix. I can't reproduce the bug locally, but the crash stack shows that we were invalidating caret in a LayoutBlock that is an SVG child but not a LayoutSVGText. The LayoutBlock seems a LayoutSVGForeignObject. To avoid this DCHECK and anything like that, now loosen the DCHECK to tolerate all SVG children derived from non-SVG layout objects. Bug: 952180 Change-Id: I1b27d2af2aa232d5bea8c6facc8400b03cb5b053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565049Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#650372}
-
Joshua Pawlicki authored
Bug: 881076 Change-Id: Id23c8d573e8e6450640e355cbe49d104bba4ae50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564551 Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
