- 09 Nov, 2020 40 commits
-
-
James Cook authored
Follow up to sky's comment on https://chromium-review.googlesource.com/c/chromium/src/+/2521691 Bug: none Change-Id: I045f4fc2828b76688af5d51b9f8a4e573c1a1390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522126 Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#825355}
-
Sami Kyöstilä authored
This reverts commit 0a590424. Reason for revert: Breaks Kaleidoscope builds on waterfall: https://bugs.chromium.org/p/chromium/issues/detail?id=1146958 Original change's description: > Don't include utils.js in builds anymore > > It is not used anymore since the test refactor. > > Change-Id: Ic8a5d95665f15f5d3498e4c29d8ffd7af6d82c5a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481684 > Auto-Submit: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825083} TBR=beccahughes@chromium.org,steimel@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I47771e29d137453129e50178b5865d0b62e272c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526089Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#825354}
-
dpapad authored
These references were missed before removing PathToUgilfy at r814758. Replacing with PathToTerser. Bug: 1087970 Change-Id: Ie0cd65940e0a9307d76c48306c5dc94bb1ed481e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526260 Commit-Queue: Roman Arora <romanarora@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Roman Arora <romanarora@chromium.org> Cr-Commit-Position: refs/heads/master@{#825353}
-
Sami Kyostila authored
NOTRY=true TBR=masonfreed@chromium.org Bug: 1147058 Change-Id: Ica80747af140f1c1eddff795fd14c709314647ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526069Reviewed-by:
-
Thiemo Nagel authored
I consider this histogram relevant for the foreseeable future, thus extending by 1 year. Bug: 1140039 Change-Id: I00c25bb7ddb39ca2ad7b3ef441da635396cc8e6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526343 Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Thiemo Nagel <tnagel@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#825351}
-
Egor Pasko authored
When RELROs from different processes come out not completely identical, the LegacyLinker has functionality to share only the identical subrange. This is because at least on some old devices it happened frequently. The ModernLinker does not have this functionality. Record a histogram to tell how often the ModernLinker fails sharing on RELRO mismatches. Later this histogram can be extended to more linkers and failure modes. Bug: 979638 Change-Id: I5430dd3fd31f01b9909de3ac758d6ab151d26877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523182Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#825350}
-
Ewann authored
This CL fixes the dismissal animation of most visited tiles. Most Visited tile appears blank for a moment switching from incognito to normal tab after opening the link in a new incognito tab from context menu because there was no preview configured. To fix this, the view of the ContentSuggestionsViewController is used as a preview. see: https://drive.google.com/drive/folders/1EZFa-TvlJRsqVp6mwMBz0H7e6EZL0c7e?usp=sharing Bug: 1117487 Change-Id: I1d80592e566c92cdd3b9846e74a4af53d697ee47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526086Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#825349}
-
Dave Tapuska authored
http://crrev.com/5e816e7d removed the only test case that used this method. There are also alternate ways to do this via RenderProcessHost::ForceCrash. BUG=1146489 Change-Id: I7ae2f81bbaffd88b799a463b34fd78f4c61145d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521243Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#825348}
-
spdonghao authored
Please see doc: https://docs.google.com/document/d/1t5KUt_CnivUO4YKhViXcS_NEa56bBI9WoYqVM1XdsoU/edit# Bug: 1083428 Change-Id: Ie4b4d43f64e7d95c5d2695a8c24365f4d1e4722b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349985Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Hao Dong <spdonghao@chromium.org> Cr-Commit-Position: refs/heads/master@{#825347}
-
Kent Tamura authored
* Use GetPaintLayerByElementId() as much as possible to remove the usage of ToLayoutBoxModelObject(). * Remove PaintControllerPaintTest::GetPaintLayerByElementId(). It's redundant. RendringTest, which a a super class of PaintControllerPaintTest, has the same function. * Add RenderingTest::GetLayoutBoxByElementId() to reduce the usage of ToLayoutBox(). * Use Element::GetLayoutBox() instead of Element::GetLayoutObject() to reduce the usage of ToLayoutBox(). This CL has no behavior changes. Bug: 891908 Change-Id: Iec659fdc61cfdd7027e61de5c91f4b55fbccdb28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524817 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#825346}
-
Xi Han authored
This bug is caused by the StartSurfaceMediator registers an observer to the empty tab model before the TabModel is initialized. In this CL, we register an observer to the TabModeSelector first and registers an normal TabModel observer after the TabModel is initialized. Bug: 1126914, 1138162 Change-Id: I653aeac99c58ed032e9a604b4001a389832d3452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517623 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#825345}
-
Kent Tamura authored
This CL converts DEFINE_LAYOUT_OBJECT_TYPE_CASTS() to DowncastTraits<> for: - LayoutDetailsMarker - LayoutFileUploadControl - LayoutProgress - LayoutNGBlockFlow This CL has no behavior changes. Bug: 891908 Change-Id: I5da5b3c7a406b0e4d62256f571192d12f975f10b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525881 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Pâris MEULEMAN authored
[1] and related tests were triggering navigations and other actions synchronously during the RenderFrameHostChanged event, which happens before the new render frame host is properly committed. This could lead to issues as the one encountered in another CL's test [2], where the navigation triggered by test [1] would be seeded with an incomplete RenderFrameHost. This could be one source of the test flackiness on Android. This solves the issue by executing the script asynchronously. I had to leave the tests using postMessage with the synchronous behavior though, as the test would fail otherwise. [1] ProactivelySwapBrowsingInstancesSameSiteTest.NavigationAfterPagehideHistogram [2] https://ci.chromium.org/p/chromium/builders/try/linux-rel/525214? Change-Id: I7261ead90e46374a7787e4131e37bd3770141450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517359 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#825343}
-
Nohemi Fernandez authored
Use kSigninNotificationInfobarUsernameInTitle experimental flag to allow switching between "Signed in as [username]" and "Signed in to Chrome" titles in the sign-in notification infobar. Bug: 1145592 Change-Id: I31a7b98137f1006f826ff18ee3168d9f87b65431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526420Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#825342}
-
Stephen McGruer authored
TBR=aluo@chromium.org Bug: 1142821 Change-Id: I24d4c52296abd4aa9b148ca4ef6ca9f6f32b4ba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521100Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#825341}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0e30faf062f7..9eff30af501c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iabcd8f8f844f347654132403267a9250e68c30c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526505Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825340}
-
Tanmoy Mollik authored
The sign in API uses CoreAccountInfo. So in the long run its better to use CoreAccountInfo for helper methods that interact with sign in API. This cl refactors SyncTestRule so that the methods to add account and toggle sync states return CoreAccountInfo. Bug: 1135510, 1117006 Change-Id: I333f9dd87b093d781311a7ee286c04f274ee13ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523112 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#825339}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9eff30af501c..0bec1380d03d 2020-11-09 taylori@google.com Merge "perfetto-ui: Keep slice selection on marking" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I9d8513906420fe39cc95f155b6234a2f9867a153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526724Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/46f5f4386f7c..40c5e53e7bba 2020-11-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 612ded0654a0 to 4ed9d3498dcf (2 revisions) 2020-11-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Headers from 87451c55aa8b to 670ffea9d61b (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: I1eb8377811385e944baa215c84f67a70694dbe22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526368Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f2eb30ce3c37..ec45b51785af 2020-11-09 aerotwist@chromium.org Prevent resizing of Vitals lane 2020-11-09 janscheffler@chromium.org [WebAuthn] Fix focus on Authenticator name 2020-11-09 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-11-09 sigurds@chromium.org Also remember empty field in Application > Storage 2020-11-09 szuend@chromium.org TypeScript-ify profiler/ProfilesPanel.js 2020-11-09 changhaohan@chromium.org Avoid re-defining custom elements: CSSAngleEditor, CSSAngleSwatch 2020-11-09 sigurds@chromium.org Allow extra text in FrameDetailsView to get wrapped If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1057090,chromium:1146936,chromium:1146985 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9f8422c69abc9b1e6965ad7e8a29af812e9046f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526721Reviewed-by:
-
Dominique Fauteux-Chapleau authored
This adds the ruleId field in triggered rules for DLP events, which seems to have been omitted by mistake. Change-Id: I468704163e49c1853ea4ba8b7f5432ddc53f933f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521244Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#825335}
-
Gyuyoung Kim authored
This CL replaces all uses of blink::Manifest::ShareTarget::Enctype with blink::mojom::ManifestShareTarget_Enctype in order to reduce type conversion between them. Bug: 919392 Change-Id: Ifc173da74d8679f00cf4bb39e4c05ef5b1103fdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522832 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#825334}
-
Colin Blundell authored
This patch extends WebLayer to package and index the subresource filter's unindexed ruleset data that is currently pulled into the tree at gclient sync. To do so it does the following: - Packages that data and its manifest as compressed resources in the app - Has WebLayer kick off indexing as part of startup, using the subresource filter component's recently-added ability to read the unindexed ruleset data from a resource in the ResourceBundle and obtaining the version of the data from the manifest We note the following: - The compressed unindexed data is ~70 KB. The uncompressed data is ~300 KB. Both of these will slowly grow over time. - RulesetService short-circuits out of indexing the data if the content version has not changed from that of the last-indexed version (saved in prefs), so this operation will have an impact on startup only when the unindexed ruleset data changes (which will happen at maximum only once with every weblayer app update, and in practice presumably less often than that). Nonetheless, to limit impact on startup in that case we post the indexing as a BEST_EFFORT task from the startup flow. BEST_EFFORT tasks are guaranteed to executee in a reasonable delay assuming that the app isn't closed. At this point in time Chrome is continuing to use the component updater; using of the in-tree subresource filter data is done *only* by WebLayer. Bug: 1116095 Binary-Size: 40K increase due to packaging compressed ruleset data Change-Id: Ifeffd6d8fcd223a9783020a97e246dafc69c4276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469562Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Nick Diego Yamane authored
This CL extracts the drag icon surface class from DragDropOperation. It can be null and there is no need to create a SurfaceTreeHost for it in such case. This is not possible currently, because DragDropOperation inherits from SurfaceTreeHost. This CL extracts it into an internal class and uses composition (instead of inheritance) to create the IconSurface only when needed. This patch does not cause behavioral changes. Bug: 1102946 Change-Id: If7497cbe436ef8bdb5fb3a80a184c5ac136732db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311127 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#825332}
-
arthursonzogni authored
This struct was content/public exposed and included by many. This was unused, so it shouldn't be exposed at all. I also need to mojoify DidCommitProvisionalLoadParams and this was its parent struct. Squashing it into its unique child struct helps. R=nasko@chromium.org,blundell@chromium.org Bug: 1145888 Change-Id: I1d6d7035389b25b22bf8393a1e8b87b5773919ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522079Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b01fdf67..63061fa2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib1d0fe861b818daa62fec93421d07f06b3cd2491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526502Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825330}
-
Guido Urdaneta authored
This reverts commit 8bd07a6c. Reason for revert: This revert was incorrect and breaks the build. Original change's description: > Revert "Move base/test/bind_test_util.h to base/test/bind.h" > > This reverts commit a4493a6f. > > Reason for revert: This CL breaks internal builds (e.g. /chrome/browser/media/kaleidoscope/internal/kaleidoscope_browsertest.cc). > > Original change's description: > > Move base/test/bind_test_util.h to base/test/bind.h > > > > Stop relying on us to remember arcane file names when writing tests, > > and repeating the directory hierarchy into the file name. > > > > R=dcheng@chromium.org > > TBR= > > NOPRESUBMIT=true > > > > Change-Id: I49c951162939c7dcef44883bee740f94b2f49e09 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523099 > > Commit-Queue: danakj <danakj@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#825145} > > TBR=danakj@chromium.org,dcheng@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Change-Id: If165b8443662baa564895e994ea0d772348e6da6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526102 > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825328} TBR=danakj@chromium.org,dcheng@chromium.org,antrim@chromium.org # Not skipping CQ checks because this is a reland. NOPRESUBMIT=true NOTREECHECK=true No-Try: True Change-Id: I6a8c0c8bbb1c8f87cc7f2df7a8b3388971292975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526683 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#825329}
-
Denis Kuznetsov [CET] authored
This reverts commit a4493a6f. Reason for revert: This CL breaks internal builds (e.g. /chrome/browser/media/kaleidoscope/internal/kaleidoscope_browsertest.cc). Original change's description: > Move base/test/bind_test_util.h to base/test/bind.h > > Stop relying on us to remember arcane file names when writing tests, > and repeating the directory hierarchy into the file name. > > R=dcheng@chromium.org > TBR= > NOPRESUBMIT=true > > Change-Id: I49c951162939c7dcef44883bee740f94b2f49e09 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523099 > Commit-Queue: danakj <danakj@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825145} TBR=danakj@chromium.org,dcheng@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: If165b8443662baa564895e994ea0d772348e6da6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526102Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#825328}
-
Fabian Sommer authored
Users who log in with a security token (smart card) can be required to keep their smart card inserted at all times. If they remove their smart card, they are logged out or the session will be locked. This behavior is controlled by two policies SecurityTokenSessionBehavior and SecurityTokenSessionNotificationSeconds. This CL adds UI for this: A notification that informs the user they are about to be logged out unless they re-insert their smart card. The UI will be wired up with the controller for this behavior in a follow-up CL. Bug: 1131450 Change-Id: Ifc16c5720ab8da4b5a1678db6d06ed8ce321dc57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480082Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Fabian Sommer <fabiansommer@chromium.org> Cr-Commit-Position: refs/heads/master@{#825327}
-
Rakina Zata Amni authored
We should queue all the data read from bytes_consumer_ and send them later when the ResponseBodyLoader resumes. This is needed to support handling network requests while a page is in the back-forward cache. Note that other sources of data (that will call DidReceiveData) are out of scope and will trigger bfcache eviction. See doc: https://docs.google.com/document/d/1KmiwSOD3Kr3Etjrl8xqMra3QrL7s4Rl7EQJ5s1Wxc0Y/edit# Bug: 1137682 Change-Id: Iaef4bdea95392bf8ef0a8885bc6774c3e85d4fdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519347 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#825326}
-
Danila Kuzmin authored
When the weak PIN is allowed, we don't need to show the warning message to user. But when the policy is unset we still show it. Bug: b/168498866 Change-Id: I56571851ca43144b2e05f31978814d0b9c384b64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490040Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Danila Kuzmin <dkuzmin@google.com> Cr-Commit-Position: refs/heads/master@{#825325}
-
Matt Jones authored
Bug: 1070281 Change-Id: I19100a2ab284f430ce50247bb62e85352fb8343f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521283 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#825324}
-
Wojciech Dzierżanowski authored
Follow up on https://chromium-review.googlesource.com/c/chromium/src/+/2470525 by moving the remaining fullscreen tests to PictureInPictureContentBrowserTest. The focus is on the video element state transitions rather than the PiP UI. This also improves testing stability: Even though these tests are not marked as flaky, they do fail from time to time when run locally. Last but not least, fullscreen as implemented in Content Shell is less obtrusive than Chrome's full-fledged fullscreen when running tests, so this improves the developer's experience. Bug: 1138168 Change-Id: I51adf3541f8a8ab74ac0f7259e29efaa024b14ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511252 Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#825323}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9290b6b5. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I1311638bdd29b180595a3493d199a0065cfc639f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526201Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825322}
-
Jan Wilken Dörrie authored
This change adds a PasswordGenerationType parameter to PasswordManagerClient::GeneratePassword(). This allows to track the type of the generation more precisely and fixes a bug in metrics recording where automatic generation was logged as manual instead when existing credentials were present. TBR=dcheng Bug: 846694, 918846 Change-Id: I06a065926a1f4dc94fd72b3b96199c799587a9b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520998 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#825321}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0e30faf062f7..9eff30af501c 2020-11-09 lalitm@google.com Merge "Handle erroneous cases in Frame lifecycle phases" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ib3912dbb84822c043ce9090d17ce10f3323c634c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526374Reviewed-by:
-
Denis Kuznetsov authored
This CL removes supervised users-specific Authenticator and UserFlow classes, to simplify further work on refining LoginDisplayHost APIs. TBR=treib@chromium.org Bug: 866790 Change-Id: I151e2d273ba57fac989b1fcd87923d30f9851cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517440Reviewed-by:
Toby Huang <tobyhuang@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e42e853638c4..f2eb30ce3c37 2020-11-09 karntino.c.areros@gmail.com Prevent auto-adding 'px' within CSS calc() 2020-11-09 changhaohan@chromium.org Refactor CSSAngle for more modularity 2020-11-09 jacktfranklin@chromium.org Change component custom events to kebab case 2020-11-09 aerotwist@chromium.org [unit test] Import more of front_end/sources 2020-11-09 sigurds@chromium.org Remove enclosingNodeOrSelfWithNodeName from Node's prototype 2020-11-09 alexrudenko@chromium.org Add align-items: center icon 2020-11-09 sigurds@chromium.org Expose COEP info for dedicated workers in frame tree 2020-11-09 sigurds@chromium.org Display description in console.table if preview is not available. 2020-11-09 szuend@chromium.org Convert MarkdownIssueDescription.js to TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1051466,chromium:1057090,chromium:1126178,chromium:1139945,chromium:1145972 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9815fd5b03e658909f378868737f25cd1793d15b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526366Reviewed-by:
-
Nohemi Fernandez authored
This patch gives us the ability to switch between infobar titles, either with "Sign in as [fullname]" or "Sign in to Chrome", depending on final UX decisions. Bug: 1145592 Change-Id: Ifba41e4aa025ec51d80e76ec79015ace375be103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526061 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
-
Ilya Nikolaevskiy authored
This CL makes all the relevant tracks/capturers to return a feedback callback upon connection to the source or starting the capture. The call chain results in VideoCaptureImpl method being plumbed to the client as a callback. This is the first step for removing VideoFrameFeedback from the media::VideoFrame. Follow-up CLs will introduce the callbacks to mirroring service (which is a second user of feedback mechanism) and would remove VideoFrameFeedback member from media::VideoFrame. Bug: chromium:1134073 Change-Id: I61dfc8449e69ad53f3fc6610d8cfbf4cdb6e4441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489644 Commit-Queue: Ilya Nikolaevskiy <ilnik@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
![Denis Kuznetsov [CET]'s avatar](https://secure.gravatar.com/avatar/5f7cd698fd5c443bb2b535de3d3765b3?s=80&d=identicon "Denis Kuznetsov [CET]")
