GitLab

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ac15544d..07a0ee92

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ie6e6d5676b43dcda141cc4d0b8aad6fd9f173f78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063453Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#742681}

Currently, there are a few kiosk tests which are failing when we most
probably get to STATUS_ERROR of KioskAppData. Let's add a log line
which will indicate whether it's a fake cws issue.

Bug: 1044417
Change-Id: I685d10c7cab773d3b7ee5a9f2d426ef2eea8da59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062444Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742680}

Allow an optional RepeatingCallback<std::string()> to be supplied to
ScopedRunLoopTimeout, to provide an additional message string in case of
timeout.

Update base::test::TaskEnvironment to have DescribeAllPendingTasks'
output appending to the timeout message.

Bug: 1021777
Change-Id: I32ff686924aea50cc56b6f103696bdbde7e8d8fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062984
Auto-Submit: Wez <wez@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742679}

Bug: 710376
Change-Id: I0c28c2cfbc6a034bbe41d68b6b1e021408365ff7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062339Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742678}

This wipes out obsolete references to Service Manager in service-related
documentation and replaces it with simpler docs reflecting the new
service model.

Bug: None
Change-Id: Iab5662bcc48b34954a9003532cd407058e470282
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063773
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742677}

This CL gets rid of InputHandlerProxy::RouteToTypeSpecificHandler
and instead, uses InputHandlerProxy::HandleInputEventWithLatencyInfo
so that events get injected at an interface level.

Bug: 1041898
Change-Id: Id371e9fb544ea5906bd09fe4b66e3d2a261adc8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001288Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Rahul Arakeri <arakeri@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#742676}

With the recent ArrayBuffer refactoring, the backing store memory is
announced to the GC when it gets wrapped by a JSArrayBuffer object. The
assumption is that backing store memory is always wrapped by a
JSArrayBuffer object. However, the bug report shows one example where
this is not the case. When an ArrayBuffer is post-messsaged to a Worker
but the Worker never takes the ArrayBuffer out of the message, then
the backing store memory becomes dead before it ever gets wrapped by a
JSArrayBuffer object. Therefore the GC does not know about the memory
used by the backing store and does not trigger garbage collection.

With this CL the MessageEvent now announces the backing store memory to
the GC. With that, garbage collection is triggered, and the backing
store memory is collected as expected.

R=haraken@chromium.org

Bug: chromium:1049005
Change-Id: I517f65a4cb1546ae469be29514183314f62e3d42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044272
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742675}

This reverts commit f9a31275.

Reason for revert: users must have migrated to prefs after 9 months.
Clients that haven't migrated meanwhile will incur in additional data
downloaded from sync servers, and may worst-case run into undeletions if
they were unlikely enough to have pending local deletions.

Previous patch was reverted earlier due to running into sync protocol
violations. This patch also introduces cleaning up of Directory on GUID
mismatch.

Original change's description:
> Reland "Reintroduce sync cache GUID migration logic from directory to prefs"
>
> This reverts commit 631967a6.
>
> Reason for revert: suspect of running into sync protocol violations and the corresponding DCHECK failures.
>
> Original change's description:
> > Revert "Reintroduce sync cache GUID migration logic from directory to prefs"
> >
> > This reverts commit 37ca67ee with
> > various non-trivial updates to the patch due to git conflicts as well
> > as logic having evolved meanwhile.
> >
> > Reason for revert: users must have migrated to prefs after 9 months.
> > Clients that haven't migrated meanwhile will incur in additional data
> > downloaded from sync servers, and may worst-case run into undeletions if
> > they were unlikely enough to have pending local deletions.
> >
> > Original change's description:
> > > Reintroduce sync cache GUID migration logic from directory to prefs
> > >
> > > After some back and forth, we've concluded that there's too much risk
> > > involved in assuming most clients have already migrated to prefs, i.e.
> > > cache GUID and birthday populated.
> > >
> > > As middle ground, we keep considering the values in prefs the
> > > authoritative ones, but if empty, we populate them from the sync
> > > directory. This adds some complexity, but allows us to defer the more
> > > aggressive turndown (disable migration), which in addition can now be
> > > guarded behind a feature toggle.
> > >
> > > Bug: 923285
> > > Change-Id: I11c4814dae1810c34c1473af36ace9a1b517067f
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609242
> > > Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> > > Reviewed-by: Marc Treib <treib@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#659030}
> >
> > Bug: 923285
> > Change-Id: I35cad35fdd398db08ee3a5cea82eaee5ebd9e980
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022787
> > Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> > Reviewed-by: Marc Treib <treib@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#735486}
>
> TBR=treib@chromium.org,mastiz@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 923285, 1048771
> Change-Id: Ie19c4d300428d59358921e55800337fbf10f0f64
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042617
> Commit-Queue: Rushan Suleymanov <rushans@google.com>
> Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#739375}


Bug: 923285, 1048771
Change-Id: I900235b66fd0186aece1d05eb1e99da70f2548b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061751
Commit-Queue: Rushan Suleymanov <rushans@google.com>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742674}

This change implements obtaining the list of saved passwords in
SavedPasswordsPresenter and makes it listen to appropriate events and
notifying its observers.

Bug: 1047726
Change-Id: Ic859e4f1aca19be36d6df8ef525564dc023191ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063129Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742673}

This change adds performance metrics previously used in the
SMS Receiver API to the credential manager. It uses the same histograms
to provide continuity with previous iterations of the API. It adds
the following metrics.

1. Blink.Sms.Receive.TimeSuccess
Time from when the API has been called to when it returns a successful
outcome.

2. Blink.Sms.Receive.TimeCancel
Time from when the API has been called to when the user dismisses the
infobar and returns a cancelled outcome.

Bug: 1045231
Change-Id: I36736e1d8c7919541cb91e23154d142e957d9975
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055891Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742672}

Using wpt-import in Chromium 3d601f27.
With Chromium commits locally applied on WPT:
ec83d167 "Update performance.measureMemory to the latest proposal"
d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching"
48b21f05 "Remove `tentative` flag from Fetch Metadata tests."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
mkwst@chromium.org, andypaicu@chromium.org:
  external/wpt/content-security-policy

NOAUTOREVERT=true
TBR=lpz

No-Export: true
Change-Id: I14b91a1dc5a26e6cdffd3d78f12cbcbf305cf61b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063073Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#742671}

Video playback is broken in Ozone/Wayland whenever Wayland compositor
announces that R_8 buffer is supported and sends supported format
modifiers for that buffer type.

Then, when video is played, GbmPixmapWayland is created with format
modifiers supplied by Wayland compositor. However, this result in a video
playback that is garbled.

The reason to this is that the buffer is requested to be linear, which
means no format modifiers should be supplied. I believe it could be
the gbm handling that, but it turns out that messes up and we have
weird behaviour.

Thus, do not use format modifiers if the buffer usage is linear.

Bug: 1050364
Change-Id: I980c462f857b3a462f95677810e3ff2aaaf340c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049978Reviewed-by: Michael Spang <spang@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#742670}

This is a minimal change adding a struct representing a Trust Tokens
key commitment registry's contents [1], with some slight variations
described in the Trust Tokens design doc (currently internal-only;
working to release a public version).

This is a common ancestor CL of trust token issuance, redemption,
and key commitment fetching and parsing.

[1]:
https://github.com/alxdavids/draft-privacy-pass/blob/master/draft-privacy-pass.md#key-registration-registry

Bug: 1042962
Change-Id: Ic0a20cb266c8133bb3545821b975e813bfb59c50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062674
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742669}

This CL allows the update_client to persist some component
metadata in prefs during Component::StateUpdated.

New functions were added to update_client::PersistedData to provide
access to these persisted members.

The persisted data is not used in any Chrome component updater
execution flows but the data is going be used by //chrome/updater to
query the version of CRXs installed by update client.

Bug: 1052164
Change-Id: I48c62e9dea12ec8a68d7ad003d3651b90df7b26e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063148Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742668}

BUG=1023913

Change-Id: I218a549768b8c9929d8857be6356ed09fcfecfaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032078
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742667}

Pointing at the other bug was confusing, because it's
state was unclear about next steps.

Bug: 1053702
Change-Id: Ia885dc21f028aabe150d55e74d927f3a37c8a371
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063331
Auto-Submit: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742666}

https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/8bece5273c7d..c22aa6b47ff6

$ git log 8bece5273..c22aa6b47 --date=short --no-merges --format='%ad %ae %s'
2020-01-23 alexlau vm_tools: concierge: vm suspend/resume via D-Bus messages
2020-02-07 garrick system_api: Fix patchpanel cid types

Created with:
  roll-dep src/third_party/cros_system_api

Bug: b:140083246
Change-Id: I6d6463ead4d715548cfc565ef116cfbf23fa8cda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063566
Auto-Submit: Alex Lau <alexlau@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742665}

When posting tasks with base::PostDelayedTask(), explicitly specify whether the
tasks should run on the thread pool on a specific named thread. This is in
preparation for making it always mandatory to specify the destination for posted
tasks.

This patch has no functional changes (aside from ui_controller_android.cc).

This CL was uploaded by git cl split.

Bug: 968047
Change-Id: If74592ccdd999f3271b3228ab1f784d0c606b5a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062414
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742664}

Clear the animating scroll snap targets in LayerTreeHostImpl whenever
we update the animation target. This ensures that we attempt to snap to
an actual snap position once the animation finishes.

Bug: 1035953
Change-Id: Ieb2b8d04d6a6f795124770a599373a21c9d61989
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976826
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742663}

This applies to frame and subresource requests from the CCT tab. It'll also apply to tabs created from it, e.g. using target="_blank". It is not applied for requests from service or shared workers, since these aren't per tab.

Bug: 1040143
Change-Id: Ia06e24e2dff5ad6c5c36f5382fc87a4403890e4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2046526
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Auto-Submit: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742662}

This reverts commit f0990340.

Reason for revert: the added test is flaky

Original change's description:
> [ExpandablePaymentHandler] Add tests: request.abort()
>
> Context:
> This CL adds a test for payment abortion. The test calls request.abort()
> from the merchant side.
>
> Expectation:
> The test expects that the request.show() promise would be rejected with
> the reason written in the exception message.
>
> Bug: 1042892
>
> Change-Id: Ib764ad689a6b114a45e86d8351086c9a4519fbfe
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040440
> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
> Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#741551}

TBR=rouslan@chromium.org,maxlg@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1042892, 1053877
Change-Id: I4332ba329a13f54aad5b36096b21971df523e95b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063664
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742661}

Add a WidgetBase which will eventually be the owner of the compositing
machinery. For now it holds onto objects passed in from RenderWidget.

There was indirection of going via the WebWidgetClient to LayerTreeHost
indirectly. blink depends on cc and can call APIs on LayerTreeHost
so do just that.

See design doc:
https://docs.google.com/document/d/10uBnSWBaitGsaROOYO155Wb83rjOPtrgrGTrQ_pcssY/edit?ts=5e3b26f7

Change-Id: I1cd4119fc3275cfcfcf8c5806d82c1745efa4c14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015784
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742660}

Wanted to minimize the amount of manual change in the clang-format
patch itself.

Bug: 1053845
Change-Id: I893c61571967f50d2d8a141caf72ac953000d1d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063899
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742659}

This CL introduces
ToolbarColors#canUseIncognitoToolbarThemeColorInOverview() which
determines whether the incognito theme color can be used in overview
mode. The purpose is to share code between
AppThemeColorProvider#updateTheme() and
StatusBarColorController#calculateBaseStatusBarColor()

BUG=None

Change-Id: I671a40084f670655a39395fa365bb1b64d8fec52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063872Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742658}

This is a precursor CL to replace ExternalPopupMenu class by a
mojo connection, and replace blink::WebTextDirection with
base::i18n::TextDirection.

Bug: 1044268
Change-Id: Ie6bc0879b7afde81cb565afa513eacb270dab169
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060208
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742657}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/1c25d4b5c206..8e303f0eba46

git log 1c25d4b5c206..8e303f0eba46 --date=short --first-parent --format='%ad %ae %s'
2020-02-19 vapier@chromium.org scripts: convert more random programs to python3
2020-02-19 woodychow@google.com Retire eve-arcvm
2020-02-19 vapier@chromium.org scripts: convert a few scripts to python3 only
2020-02-18 vapier@chromium.org run_tests: detect more stale symlinks
2020-02-18 vapier@chromium.org Revert "cros_env_whitelist: relax Python 3 warning temporarily"
2020-02-18 ruiu@google.com Copy ARM32/ARM64 master images to gs://chromeos-arc-images/builds
2020-02-18 vapier@chromium.org cros lint: catch misuse of Params over Args
2020-02-18 vapier@chromium.org cbuildbot: delete old cbuildbot program
2020-02-18 morg@google.com Add eve-arc-r overlay to build config

Created with:
  gclient setdep -r src/third_party/chromite@8e303f0eba46

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel
Bug: None
Tbr: chrome-os-gardeners@google.com
Change-Id: I2f5623df9414c3bbae826ea802815162917cc7ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063682Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#742656}

Code in //base/profiler is the primary driver of feature requirements
for ModuleCache, and ModuleCache needs to be further updated to allow
removing modules to support profiler use of the new V8 async unwinder
API. So move the code into that directory and have the sampling heap
profiler use it from there.

TBR=thestig@chromium.org,petermarshall@chromium.org,ssid@chromium.org

Bug: 1035855
Change-Id: I0151939fb1f193759c4beda3d3d336ee4df7fca9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057157Reviewed-by: Mike Wittman <wittman@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742655}

And fix or suppress a few issues that the msan bot found.

The components/download change is a real bug fix: If we compared N
bytes but the file is only M < N bytes long, we used to read M
bytes and then compare N - M bytes of uninit memory, and if we were
unlucky we could've had a false positive. (Unlikely, but possible.)

Bug: 523428
Change-Id: I01b4c9bf312160eceb81980c731ab301a927341b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062290
Auto-Submit: Nico Weber <thakis@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742654}

This ensures that adding fields to Mojo structs which are not defined
within the struct's definition causes a compiler error.

Fixed: 1031385
Change-Id: I56cc509a192be882227763f47cec05ef6a8c5ad5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006413
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#742653}

Right now, only the zoom in/out buttons adjust based on whether zooming
in or out would change anything. The reset button should adjust the
same way.

Bug: 1053977
Change-Id: I83903b4a55953e4984a61f9ba6b7eaa8858d95fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063134
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742652}

This reverts commit 0b25b17e.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 742520 as the
culprit for flakes in the build cycles as shown on:
https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMGIyNWIxN2VkYThlMWY0YjRiN2MxMDI0ZmRjZWQ2Mjg0Nzc5Y2RlYQw

Sample Failed Build: https://ci.chromium.org/b/8888021964038070960

Sample Failed Step: content_browsertests

Sample Flaky Test: All/DumpAccessibilityTreeTest.DisplayLockingViewportActivation/blink

Original change's description:
> Reland "DL: Don't include skip-viewport-activation subtrees in the AX tree"
> 
> This is a reland of c08274e9
> 
> The CL was previously reverted because the viewport activation test is
> flaky, probably due to uncertain timing of near-the-viewport activation.
> I've updated the test to only test for in-the-viewport activation,
> I'll investigate further on why it's flaky for near-the-viewport
> (manual testing shows activation happens consistently).
> 
> SHERIFFS: please don't revert this CL if it introduces a new flaky test.
> Instead, please disable them and I'll investigate.
> 
> Original change's description:
> > DL: Don't include skip-viewport-activation subtrees in the AX tree
> >
> > Now both render-subtree: skip-viewport-activation and skip-activation
> > subtrees are not in the AX subtree at all, as discussed in
> > https://github.com/WICG/display-locking/issues/102#issuecomment-564205445
> >
> > Now only render-subtree:invisible subtrees are in the AX tree, and they
> > are automatically marked as offscreen because the nodes are activated
> > when they are on screen.
> >
> > Bug: 1001930
> > Change-Id: I1de511672f60078a02b3ddf3d989f2da1c44ae9d
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028883
> > Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
> > Reviewed-by: vmpstr <vmpstr@chromium.org>
> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> > Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#740531}
> 
> Bug: 1001930
> Change-Id: Icdf43cff86ade7e7e8f2aee76933dfc51e3f022c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054649
> Reviewed-by: vmpstr <vmpstr@chromium.org>
> Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
> Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#742520}


Change-Id: I9258a82fa5a36921963dda0d12ce6efde1895e4b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1001930
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063667
Cr-Commit-Position: refs/heads/master@{#742651}

This CL renames the class to allow creating a service with
the name PlatformKeysService from
chrome/browser/chromeos/platform_keys/platform_keys* files.
That will allow to mock functions from there and write unit
tests for a code that depends on them.

Bug: 1045895
Change-Id: I179c75aa1efc19acf5d6f10a06cf6ea62a11bf30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064211
Commit-Queue: Michael Ershov <miersh@google.com>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742650}

This reduces the byte size of TextureDrawQuad using 1 bit for booleans
members and 2 bits for an enum with 4 values.

Since QuadList uses the size of the biggest DrawQuad to allocate any
quad, this CL will reduce the memory used by QuadList, even if
TextureDrawQuads are not used.

Bug: None

Change-Id: Ic89e932a582c1a25e530d838e7d5a9f3c68d6462
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058835Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742649}

https://skia.googlesource.com/skia.git/+log/2e941d00c837..86b4388fdcb4

git log 2e941d00c837..86b4388fdcb4 --date=short --first-parent --format='%ad %ae %s'
2020-02-19 reed@google.com Revert "Support adding attributes to PDF document structure nodes."
2020-02-19 reed@google.com allow client to pass null if there are no uniforms
2020-02-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 c8676d4ba37d..fa9eff37c38a (11 commits)
2020-02-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 0bbf7ba9f909..8def9063c4fd (2 commits)
2020-02-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 0f78b586..f5ddd865 (448 commits)
2020-02-19 reed@google.com Use careful_memcpy in case one of the args is null
2020-02-19 herb@google.com Move memory usage calculation to SkStrikeCache::Strike
2020-02-19 bsalomon@google.com GrBicubicEffect uses GrTextureEffect.
2020-02-18 mtklein@google.com remove -Wno-bad-function-cast
2020-02-18 mtklein@google.com turn on -Wreturn-std-move-in-c++11
2020-02-18 herb@google.com Have SkScalerCache return memory used
2020-02-18 brianosman@google.com Revert "allow client to pass null if there are no uniforms"
2020-02-18 brianosman@google.com Fix path to GN on Windows when running presubmit hooks
2020-02-18 robertphillips@google.com Store ProgramDesc on DDLs alongside the GrProgramInfo
2020-02-18 reed@google.com allow client to pass null if there are no uniforms
2020-02-18 robertphillips@google.com Make GrGLGpu's program cache be held as a unique_ptr
2020-02-18 jvanverth@google.com Start adding D3D backend
2020-02-18 brianosman@google.com Roll SPIRV-Cross to latest (2020-02-14)
2020-02-18 brianosman@google.com Revert "Move runtime shader/colorfilter into SkRuntimeEffect.cpp"
2020-02-18 brianosman@google.com Move runtime shader/colorfilter into SkRuntimeEffect.cpp
2020-02-18 reed@google.com add skotties to cube demo
2020-02-18 dmazzoni@chromium.org Support adding attributes to PDF document structure nodes.

Created with:
  gclient setdep -r src/third_party/skia@86b4388fdcb4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1039816
Tbr: lovisolo@google.com
Change-Id: Ic2cb56e97a0426243854c6ce4b8c8935be2e0064
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063681Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#742648}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1b1227d53e69..2d44550a1bd9


Created with:
  gclient setdep -r src-internal@2d44550a1bd9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: I6b796057d57046b7b3ab357625999350b0a386ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063679Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#742647}

If WindowAndroid* is null when trying to display or update the bounds
of the popup, then there is no way/no reason to do it. Thus, the
display attempt is abandoned.

Bug: 1051031
Change-Id: I95f90b7240393d9f09de14e50917095694e8471b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061810Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742646}

ChromeFeatureList moved out of chrome/android. Now we can remove the dep.

Bug: 1022172
Change-Id: Ia107a48832bdf4784229d576a46c341090ae7b07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063774Reviewed-by: Kyle Milka <kmilka@chromium.org>
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742645}

As IndexedDBContext is going to go away, remove this call.  This will
help move IndexedDB to storage service.  There's still some callers of
this in RenderProcessHostImpl and in StoragePartitionImpl, but these
will be removed only once IndexedDB is moved to the storage service
proper.

Bug: 1015214
Change-Id: If0ea7c7ab616a2ad86eed37bd66413e563bed1f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055847
Commit-Queue: Ken Rockot <rockot@google.com>
Auto-Submit: enne <enne@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742644}

This reverts commit e8f078f3.

Reason for revert:
BeginWriteSkia() call is moved out of critical path. This change is not
necessary anymore. For code health revert it. 

Original change's description:
> Import GLFence in EndOverlayAccess for AHB
> 
> When using SurfaceControl after surface has been returned we need to
> wait until fence provided by system will be signaled. When using GL
> for compositing, this is implemented as importing provided file
> descriptor as egl fence and issue ServerWait().
> 
> GLRenderer does it when we get surface back. With SkiaRenderer it
> happens on next BeginWrite for the SharedImage. Import is expensive
> operation and BeginWrite is on critical path.
> 
> This CL moves import to EndOverlayAccess as we will do it anyway.
> Then at BeginWrite time we only issue ServerWait().
> 
> In local tests with scrolling simple page it saves 200us in
> DrawToSwapUs metric.
> 
> Change-Id: I6efb2783d0e287dc5e4fbb5707c507328e75a32f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019607
> Reviewed-by: Jonathan Backer <backer@chromium.org>
> Reviewed-by: Ken Buchanan <kenrb@chromium.org>
> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#735577}

TBR=backer@chromium.org,kenrb@chromium.org,vasilyt@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I20831d283c657d2f3245a454ed26b5a7529788ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057044Reviewed-by: Peng Huang <penghuang@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742643}

Sample run:
https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN/4415

TBR=kyleju@chromium.org

No-Try: true
Bug: 856601
Change-Id: I84c5d046c4e925810aeef5774fe93a3efc6b08bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062284Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742642}