GitLab

data, rather than the localized name.


BUG=123214
TEST=none


Review URL: http://codereview.chromium.org/10086019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132543 0039d316-1c4b-4281-b951-d872f2087c98

Now that Inspect Element on the popup works, this command is no longer
needed.

BUG=53518
TEST=Tested on windows, linux and mac


Review URL: http://codereview.chromium.org/9968076

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132542 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/10096009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132541 0039d316-1c4b-4281-b951-d872f2087c98

R=estade@chromium.org
BUG=123136
TEST=chrome://plugins details +/- button works.


Review URL: http://codereview.chromium.org/10103018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132540 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123224
TEST=none


Review URL: http://codereview.chromium.org/10105018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132539 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:16557
TEST=chromeos_unittests --gtest_filter="FlimflamDeviceClientTest.*"


Review URL: http://codereview.chromium.org/10095004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132538 0039d316-1c4b-4281-b951-d872f2087c98

As requested in http://codereview.chromium.org/10073024/, I've created
templates for these two actions. I've also applied them to base.


Review URL: http://codereview.chromium.org/10081035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132537 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132536 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10108007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132535 0039d316-1c4b-4281-b951-d872f2087c98

TBR=toyoshim@chromium.org, scheib@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9969187

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132534 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/10103016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132533 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/10106014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132532 0039d316-1c4b-4281-b951-d872f2087c98

Original CL:
==========
Assert we do not leak requests for the system and safe browsing contexts.

It's possible this will catch some leaks when deployed live. We should be able to analyze the crash dumps and fix the culprits.
==========

This time, I'll only assert we do not leak requests for the system
request context, since I've confirmed that we are leaking requests for
the safe browsing context.

BUG=90971
TEST=None
TBR=eroman


Review URL: http://codereview.chromium.org/10096017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132531 0039d316-1c4b-4281-b951-d872f2087c98

Revert 131704 - Use ExitCleanly to exit intead of AttemptUserExit.
When the idle logout dialog exits, it needs to completely just exit the browser and not get blocked by any existing windows waiting to close; hence use ExitCleanly instead of AttemptUserExit when ending the session from the idle logout dialog.

R=tbarzic@chromium.org
BUG=chromium-os:29176
TEST=Tested that we logout instead of getting stuck.

Review URL: https://chromiumcodereview.appspot.com/10014036

TBR=rkc@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10103023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132530 0039d316-1c4b-4281-b951-d872f2087c98

Currently all 1x art files are repacked into chrome.pak files.

This is a problem on Windows where we want to choose which pak file to load based on metro and DPI scale.

As a first step this CL does the following:
 - add a new enable_hidpi build flag. This allows us to test HiDPI mode on Windows Chrome.
 - stop packing theme_resources_standard.pak and ui_resources_standard.pak into chrome.pak
 - update the Mac and Windows installer code to package the extra pak files.

Note, I'll be updating the Linux installer script in a separate CL. I'm still looking into the ChromeOS situation.

BUG=114311
TEST=Ran on Windows, and Mac and Linux.

Review URL: http://codereview.chromium.org/10024050

TBR=sail@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10103022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132529 0039d316-1c4b-4281-b951-d872f2087c98

BUG=TBD
TEST=no


Review URL: http://codereview.chromium.org/9416060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132527 0039d316-1c4b-4281-b951-d872f2087c98

This cleans up another instance of renderer code directly invoking page/author script. When all instances are fixed, we can land https://bugs.webkit.org/show_bug.cgi?id=84094

BUG=
TEST=

Review URL: http://codereview.chromium.org/9969191

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132526 0039d316-1c4b-4281-b951-d872f2087c98

BUG=109308
TEST=views_unittest --gtest_filter="NativeTextfieldViews*"


Review URL: http://codereview.chromium.org/9358049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132525 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132522 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r8266: (bsy) add interval sets.  add memory interval interlocks to prevent race.
r8267: (bsy) changed dprintf definition to NaCl_dprintf.
r8268: (bsy) coverage abort status vs normal abort status
r8269: (bsy) needed trusted_env instead of env.
r8270: (jvoung) Revert "add interval sets.  add memory interval interlocks to prevent race."
r8271: (bradnelson) Adding a startup regression test.
r8272: (bbudge) Update Chrome revision in NaCl DEPS.
r8274: (robertm) Update deps for gold as final pnacl linker
r8275: (mseaborn) Exception handling: Windows: Attach debug exception handler on demand

BUG=none
TEST=nacl_integration

Review URL: https://chromiumcodereview.appspot.com/10108006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132521 0039d316-1c4b-4281-b951-d872f2087c98

I used "Wi-Fi" rather than "wireless" because in some other
messages "wireless" means "Wi-Fi or mobile data".


BUG=122244,122725,122726,122905
TEST=none


Review URL: http://codereview.chromium.org/9956160

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132519 0039d316-1c4b-4281-b951-d872f2087c98

discarded tab we don't tell the FindBarController of the new
TabContentsWrapper and the FindBar is left referencing the wrong and
possibly deleted TabContentsWrapper.

BUG=123671
TEST=none
R=jamescook@chromium.org


Review URL: http://codereview.chromium.org/10106011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132518 0039d316-1c4b-4281-b951-d872f2087c98

Currently all 1x art files are repacked into chrome.pak files.

This is a problem on Windows where we want to choose which pak file to load based on metro and DPI scale.

As a first step this CL does the following:
 - add a new enable_hidpi build flag. This allows us to test HiDPI mode on Windows Chrome.
 - stop packing theme_resources_standard.pak and ui_resources_standard.pak into chrome.pak
 - update the Mac and Windows installer code to package the extra pak files.

Note, I'll be updating the Linux installer script in a separate CL. I'm still looking into the ChromeOS situation.

BUG=114311
TEST=Ran on Windows, and Mac and Linux.

Review URL: http://codereview.chromium.org/10024050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132517 0039d316-1c4b-4281-b951-d872f2087c98

R=pkasting@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9956157

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132516 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/10105013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132515 0039d316-1c4b-4281-b951-d872f2087c98

rather than at the model level. This gives us automatic nocompile of all
properties; previously not all were supported.


TEST=tools/json_schema_compiler/json_schema_test.py, unit_tests --gtest_filter=JsonSchemaCompiler*

Review URL: http://codereview.chromium.org/10108005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132514 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:16557
TEST=chromeos_unittests --gtest_filter="FlimflamProfileClientTest.*"

Review URL: https://chromiumcodereview.appspot.com/10038011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132513 0039d316-1c4b-4281-b951-d872f2087c98

- Changed the data structure being passed around in the socket API from a string to an array of longs. This is a stepping stone to get us to ArrayBuffers.

- Changed "message" key to "data" for consistency.

BUG=120567
TEST=no new ones, but existing, as updated, still pass.

Review URL: http://codereview.chromium.org/10095020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132512 0039d316-1c4b-4281-b951-d872f2087c98

Fix a crash when trying to input phone number in the autofill settings page while running as guest mode.

BUG=123346
TEST=Login as guest mode, open chrome://setting/autofillEditAddress, input some number in the Phone input field, hit tab, check that didn't cause a crash.


Review URL: http://codereview.chromium.org/10081023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132511 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/10107006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132510 0039d316-1c4b-4281-b951-d872f2087c98

The memory widget was removed in crrev.com/131801 as part of the uber-tray status area update.  This removes the obsolete about:flags switch that used to turn it on.

BUG=123700
TEST=none


Review URL: http://codereview.chromium.org/10103013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132508 0039d316-1c4b-4281-b951-d872f2087c98

Currently behind a flag "-Xclang -plugin-arg-find-bad-constructs -Xclang skip-virtuals-in-implementations"

BUG=115047
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10076002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132507 0039d316-1c4b-4281-b951-d872f2087c98

Added a new PyAuto method WaitForDomNode() which allows tests to block until a specified node exists in the DOM.


BUG=None
TEST=functional/apptest.py


Review URL: http://codereview.chromium.org/10095018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132506 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=ran the browser test.

Review URL: https://chromiumcodereview.appspot.com/10080002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132505 0039d316-1c4b-4281-b951-d872f2087c98

- delete old in_process_webkit sources (hooray)
- rename the new sources to no longer have the _new suffix
- fix up the includes
- remove the ENABLE_NEW_DOM_STORAGE_BACKEND flag since old stuff is now gone
Review URL: https://chromiumcodereview.appspot.com/10086018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132504 0039d316-1c4b-4281-b951-d872f2087c98

Fixed bug where the ExecuteJavascript() family of PyAuto hooks ignored the automation id of messages from DomAutomationController.

This had the effect of hooks returning on the next message from
DomAutomationController regardless of whether that message actually
indicated completion of the injected javascript.

BUG=120769
TEST=functional/execute_javascript.py


Review URL: http://codereview.chromium.org/9950098

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132503 0039d316-1c4b-4281-b951-d872f2087c98

Change FlimflamProfileClient's interface to deal with multiple profile objects
Change FlimflamProfileClient's interface to send an entry's path as a string, not an ObjectPath
Add non-Libcros implementations of CrosDeleteServiceFromProfile, CrosRequestNetworkProfileProperties and CrosRequestNetworkProfileEntryProperties
Add EnableNonLibcrosNetworkFunctions
Add --enable-non-libcros-network-functions commandline option
Rename existing CrosNetworkFunctionsTest to CrosNetworkFunctionsLibcrosTest
Add new CrosNetworkFunctionsTest which tests the non Libcros implementation

BUG=chromium-os:16557
TEST=unit_tests --gtest_filter="CrosNetworkFunctions*"

Review URL: https://chromiumcodereview.appspot.com/9958045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132502 0039d316-1c4b-4281-b951-d872f2087c98

I'll send out a separate mail about the shmat() situation -- for now, a
shipping seccomp filter sandbox is better than no filtering.
Review URL: https://chromiumcodereview.appspot.com/10105009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132501 0039d316-1c4b-4281-b951-d872f2087c98

Check and warn if public destructors are found on types that derive from base::RefCounted or base::RefCountedThreadSafe.

Having public destructors is dangerous, as it allows the ref-counted object to be stack allocated and have references that attempt to outlive the stack, or to allow callers to explicitly delete it while references are still held. Both patterns result in use-after-free, hence their prohibition.

In doing so, update the Chromium plugin to be able to scan both headers and implementation files, and enable the public destructor check for both types with an optional flag ( -Xclang -plugin-arg-find-bad-constructs -Xclang skip-refcounted-dtors )

BUG=123295
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10005022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132500 0039d316-1c4b-4281-b951-d872f2087c98

Some notification clients expect URLs while others expect URLRows but in some cases the URLRows were not being provided. Eliminated the duplication of data structures by removing the set of URLs and relying only on the vector of URLRows.

NOTE: This CL is identical to previously reviewed 10031028 except that a leak was fixed in in_memory_url_index_unittest.cc.

tim@ for OWNERS review of sync/...

BUG=122740
TEST=Added unit test.
TBR=tim@chromium.org

Previously reviewed as: https://chromiumcodereview.appspot.com/10031028
Review URL: https://chromiumcodereview.appspot.com/10096015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132499 0039d316-1c4b-4281-b951-d872f2087c98