- 24 Jan, 2019 40 commits
-
-
Travis Skare authored
Bug: 923611 Change-Id: Ia99b06a381c955ebad0cb7b9fd5b104549c61fc2 Reviewed-on: https://chromium-review.googlesource.com/c/1423740 Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#625823}
-
Lei Zhang authored
BUG=890417 Change-Id: I06ace304b02803f49a0eda89a4ff711f564d78fb Reviewed-on: https://chromium-review.googlesource.com/c/1435538Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#625822}
-
kylechar authored
There is more investigation necessary here so extend the histogram expiry to M75. Bug: 874797, 915884 Change-Id: I6ed365ab33e0335aa45e29466f61c4970d21afe4 Reviewed-on: https://chromium-review.googlesource.com/c/1431476Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#625821}
-
Sam Maier authored
Binary-Size: no longer class merging, this is expected Bug: 908988 Change-Id: I4fd1c9ffde68a06cc0b38de613d53e554ea3cfea Reviewed-on: https://chromium-review.googlesource.com/c/1409603 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#625820}
-
Elly Fong-Jones authored
This flag just serves to prevent access to chrome://sys-internals, which is otherwise complete. This change deletes the flag and renders chrome://sys-internals always accessible. Bug: 752002 Change-Id: Idab39d63a48e11df7e31187263ceb6435f1f5008 Reviewed-on: https://chromium-review.googlesource.com/c/1434799 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#625819}
-
David Trainor authored
Add the new update states for inline updates and add the menu UI based on those states. This also adds the ability to use chrome://flags to force the UI to show those particular new states as well. BUG=922711 Change-Id: Ie7303fe2244f62d067e3412f049d2b2bb10db3a8 Reviewed-on: https://chromium-review.googlesource.com/c/1417350 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#625818}
-
Vikas Soni authored
Refactor ScopedHardwareBuffer to move it to base::android. Add a function to take ownership of underlying buffer handle. Bug: 900963 Change-Id: I765fa9cf893aee281a98638f1dc55deca1361118 Reviewed-on: https://chromium-review.googlesource.com/c/1415295Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
-
Juan Antonio Navarro Perez authored
These are no longer used, and depend on legacy Telemetry features due to be deprecated. Bug: 642742 Bug: 921000 Change-Id: I1478e212de510516f01066d0898ccb7397c15031 Reviewed-on: https://chromium-review.googlesource.com/c/1434317Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#625816}
-
Matthew Jones authored
This patch adds user actions for the icons in the edit-url suggestion (copy, edit, and share) as well as actions for the omnibox long-press menu. Bug: 881292 Change-Id: I24db676134df34bb7cdf197bb2fc93c84dc86dcd Reviewed-on: https://chromium-review.googlesource.com/c/1419339Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
John Lee authored
Bug: 887150 Change-Id: I2124e395ed163cf46bca498743634d85c02e5866 Reviewed-on: https://chromium-review.googlesource.com/c/1418397 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Dan Beam (slow until 1/29) <dbeam@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#625814}
-
Jeffrey Cohen authored
Bug: 921125 Change-Id: Ibfb27630267389cfdd1d135417fb9633ad9d0445 Reviewed-on: https://chromium-review.googlesource.com/c/1422664 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Mohammad Refaat authored
- Create a public headers directory for the framework style include and only add files that are needed by Chromium code. Bug: 924071 Change-Id: Ia70a1f1a2eff2888c8cbf9c8a2c3ed2fff85e71b Reviewed-on: https://chromium-review.googlesource.com/c/1432153 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#625812}
-
Jon Kunkee authored
ChromeOS used to be the only ARM target to get a high-bit-depth-capable VP9 codec. With the introduction of ARM64 Windows, there is a second such target. This change renames the config files and source lists for their contents rather than their purpose so they can be easily reused. This change also includes a mkdir invocation that makes adding configurations easier. Bug: 893460 Change-Id: I0cc7faa0c9330046e63ea7dc412c9c6e6a8a2ff5 Reviewed-on: https://chromium-review.googlesource.com/c/1429520 Commit-Queue: Johann Koenig <johannkoenig@google.com> Reviewed-by:
Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#625811}
-
Nicolas Ouellet-payeur authored
Bug: 924832 Change-Id: I6e06e81aea864594caf4ae359064032ad8d22f42 Reviewed-on: https://chromium-review.googlesource.com/c/1434075Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#625810}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bb3f9060c4ea..406f8a00f9f0 Created with: gclient setdep -r src-internal@406f8a00f9f0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I4e864218575a76c93cbe2cd1eeadde686eca12d9 Reviewed-on: https://chromium-review.googlesource.com/c/1435234Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625809}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/13a5f9e46a5d..c30b0a434de9 git log 13a5f9e46a5d..c30b0a434de9 --date=short --no-merges --format='%ad %ae %s' 2019-01-24 tsepez@chromium.org Release before reallocation in cfx_memorystream.cpp Created with: gclient setdep -r src/third_party/pdfium@c30b0a434de9 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:924928 TBR=dsinclair@chromium.org Change-Id: I7e08bb3fe79200b3d1e12bf0680beffaf25b52cc Reviewed-on: https://chromium-review.googlesource.com/c/1435354Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#625808}
-
Xiaohan Wang authored
- Remove the origin trial - Mark the status as "stable" Blink intent-to-ship approval at https://groups.google.com/a/chromium.org/d/msg/blink-dev/w0jNaAhyTV0/3oDkR_ASAQAJ TBR=timvolodine Bug: 709348 Test: Manually tested to make sure the API is available by default. Change-Id: I84306dc0e17f104043fa2205529e650e255e7175 Reviewed-on: https://chromium-review.googlesource.com/c/1423090 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#625807}
-
John Rummell authored
When debugging it is nice to knwo the reason that requestMediaKeySystemAccess() failed. BUG=924991 Change-Id: I352beb27f9a0c2fb82444ae92a4d740a886fa8e0 Reviewed-on: https://chromium-review.googlesource.com/c/1435219Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#625806}
-
Nate Fischer authored
No change to production logic, only to an FYI bot's filter. Although WebView does not intend to support OOP NetworkService, we do intend to support in-process NetworkService even when WebView runs an OOP renderer (on Android O & above). The test filter currently filters out OOP-renderer tests, but cites OOP NetworkService as the reason, so this is probably a mistake. R=jam@chromium.org Bug: 841556 Test: see bot Change-Id: Id81637c879d205e65595d0a9999c1ea5b809865e Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo Reviewed-on: https://chromium-review.googlesource.com/c/1423115 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#625805}
-
Wei Li authored
Some accessibility unit tests were accidently removed from BUILD file on r5da1d21f, so they can not be tested. This CL adds them back so we can still check on the results from these tests. BUG=none Change-Id: I1b495cc614b4402c4a360cd1c29dd3b174db61d8 Reviewed-on: https://chromium-review.googlesource.com/c/1432833Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#625804}
-
Min Qin authored
on M and L, detaching a notification from foreground service is not supported. As a result, the current implementation just put the notification in a sharedPreference and persist it across service restarts. However, the recent introduction of stopSelf() will remove the notification, and service will not restart. The logic for M and L really complicates the implementation, and the only side effect it tries to save is the notification flicker when pausing a download. This CL removes the notification persisting logic for L and M. When stopping the foreground service, we simply kill the existing notification, and launch a new one. BUG=919026 Change-Id: Ie9df5d17714d7ff9c54eed8f9b3ca1ddfaaf3199 Reviewed-on: https://chromium-review.googlesource.com/c/1432875Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#625803}
-
Tim Volodine authored
Match the threading of AndroidStreamReaderURLLoader (NS code path) to that of AndroidStreamReaderURLRequestJob (current code path). In particular make sure to open the input stream on a background worker thread. The input stream can be provided by the embedding app, so it's important to respect the original thread model. The AndroidStreamReaderURLLoader is also used for loading android assets, android resources and content scheme urls. Add ThreadChecker same thread DCHECKs in AndroidStreamReaderURLLoader. Add OnInputStreamOpenFailed delegate method to be called on the IO thread with the necessary restart logic. Add threading checks for OpenInputStream and OnInputStreamOpenFailed in the unittest. BUG=913524,841556 Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo Change-Id: I23da72265ab0db8f0236bc1760d09826102317ef Reviewed-on: https://chromium-review.googlesource.com/c/1422698 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
-
Becca Hughes authored
We should use url formatter for source title now the overshadowing issue has been fixed as this is the recommended way for displaying origins in the UI. BUG=923078 Change-Id: I36d57e38a82295ffd0308a7e8d15260305e10f60 Reviewed-on: https://chromium-review.googlesource.com/c/1432712Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#625801}
-
Weiyong Yao authored
When to change source during a tab sharing session, the new picker will only be available on the tab which starts the session. If that tab is not on the front, user may probably miss the picker. This cl is to bring the tab up to front before showing the picker for easy notice. If use selects to cancel the source changing, this cl will activate the previous shared tab to continue the sharing session. Bug: 892201 Change-Id: I51c6436095df37f3afb3d28aebbfb9e4bb03f3a5 Reviewed-on: https://chromium-review.googlesource.com/c/1423700Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Weiyong Yao <braveyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#625800}
-
siyua authored
Server side config https://critique.corp.google.com/#review/230617773 Bug: 897998 Change-Id: I1cd43e99351cae54e63dea14280bd973e3caf2fd Reviewed-on: https://chromium-review.googlesource.com/c/1434176Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#625799}
-
Nicolas Ouellet-payeur authored
With the new managed UI rolling out, the duplicate 'managed by' messages were confusing. Bug: 925026 Change-Id: If75ab103f41c67730aa27b4dca71e3dfb26f2054 Reviewed-on: https://chromium-review.googlesource.com/c/1434082Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#625798}
-
chrome://historyNicolas Ouellet-payeur authored
The icon was "error-outline", but the mocks use "info-outline". Bug: 924933 Change-Id: I12c8a7c455e19e1a0adc2e68e32cdd7363a243d1 Reviewed-on: https://chromium-review.googlesource.com/c/1434216Reviewed-by:
-
Andrew Grieve authored
Change-Id: Ia16fce0879a5a1005c0273f9959b475dfde69cf6 Reviewed-on: https://chromium-review.googlesource.com/c/1434434 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#625796}
-
Greg Kerr authored
This CL adds access to system resources that are showing up in crash reports for the V2 GPU Sandbox. Bug: 915934 Change-Id: Ie1b9faa0fd5cacaf6fbd74f0c5a9500a55bede1f Reviewed-on: https://chromium-review.googlesource.com/c/1434920Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Auto-Submit: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#625795}
-
Leonard Grey authored
No specific bugs, this is from pairing with namratakannan@ - Update background color for autofill footer - Fix a button in the profile menu sign in UI Change-Id: Iafdddd6d6703cbb97bc633dca9b43e232d0a9028 Reviewed-on: https://chromium-review.googlesource.com/c/1434895Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#625794}
-
Dan Beam authored
Screenshots: https://imgur.com/a/cjIHN3N R=dpapad@chromium.org BUG=924387 Change-Id: Iaebbe018941ef26392cf12e3ea28447865db5b45 Reviewed-on: https://chromium-review.googlesource.com/c/1433499Reviewed-by:
-
Elly Fong-Jones authored
Bug: None Change-Id: I9893f16efc9a61fb8c75c606a593fcff8bb1c537 Reviewed-on: https://chromium-review.googlesource.com/c/1434800 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#625792}
-
Nate Fischer authored
This adds miscellaneous tips for working with the emulator: * Explain which image to choose, and what "Google APIs" really means (this especially matters for WebView development) * Tips for running from CLI (headless, writable system) * Change install instructions for `virtualgl`, point Googlers toward relevant documentation. * Formatting, restructuring docs R=agrieve@chromium.org Bug: 918221 Test: Upload to gerrit > open file > click "gitiles" Change-Id: Ie634516d1a19f9653e21a2e0586410618b7eefb7 Reviewed-on: https://chromium-review.googlesource.com/c/1432837Reviewed-by:
-
Jérôme Lebel authored
Screenshot: https://screenshot.googleplex.com/7Bp9z54Le5s Bug: 914059 Change-Id: I12ed57a7b2e456f542c14647b959396617ea61c4 Reviewed-on: https://chromium-review.googlesource.com/c/1416144 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#625790}
-
Siddhartha authored
The assets were not added since we checked "can_unwind_with_cfi_table" value, which depends on "build_secondary_abi" build arg. So, explicitly add the asset for 64-bit monochrome apk, which contains 32 bit library. BUG=924842 Change-Id: I6488d5c4e5a80787735c5b09134b013a87b5c553 Reviewed-on: https://chromium-review.googlesource.com/c/1432836 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
-
Tanja Gornak authored
Currently, there is no metric, which surfaces the problems in token retrieval. This Cl adds such metric. Bug: 801985 Change-Id: Iafcf1d5179798e3032eb8e5dcbeeab8644a8e385 Reviewed-on: https://chromium-review.googlesource.com/c/1433625Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#625788}
-
Mikel Astiz authored
Minor refactoring to inject more narrow dependencies and adopt const pointers which is otherwise non-trivial. Bug: 922971 Change-Id: I4e7068cb042bae8b23052d0318ca86ea4358990c Reviewed-on: https://chromium-review.googlesource.com/c/1433234 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#625787}
-
Kyle Milka authored
This is a reland of 5d52425f Initialize the int memebers of SearchSuggestData to 0. The uninitialized values were causing separate failures than the previously flaky test. Original change's description: > Reland "[NTP] Cap search suggestion impressions" > > This is a reland of 41e54be1 > > One of the checks is converting the times from ms->s. In practice > seconds is plenty precise but in the test 800ms ended up being 0, > so increase it to 1000ms (similar to ImpressionCountResetsAfterTimeout > which was not flaky). > > Original change's description: > > [NTP] Cap search suggestion impressions > > > > The parameters for capping suggestions impressions are provided as part > > of the update proto. Read and update the local pref on each fetch. Use > > these prefs to determine if the impression cap has been reach or if > > fetching is frozen due to an empty response. > > > > Bug: 904565 > > Change-Id: Ib5539a99f18e9da2ac1223ecc7aff65cb909bca8 > > Reviewed-on: https://chromium-review.googlesource.com/c/1395188 > > Commit-Queue: Kyle Milka <kmilka@chromium.org> > > Reviewed-by: Kristi Park <kristipark@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#624994} > > Bug: 904565 > Change-Id: I424cb51d2a9c1738c0e5168f58ef52b73ed4b223 > Reviewed-on: https://chromium-review.googlesource.com/c/1431472 > Reviewed-by: Kristi Park <kristipark@chromium.org> > Commit-Queue: Kyle Milka <kmilka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#625437} Bug: 904565 Change-Id: I01e2c868d36ce1ab5d7ffd91b86e40d8573f121e Reviewed-on: https://chromium-review.googlesource.com/c/1434081Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#625786}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b2bab1fee534..13a5f9e46a5d git log b2bab1fee534..13a5f9e46a5d --date=short --no-merges --format='%ad %ae %s' 2019-01-24 tsepez@chromium.org Remove ampersands from element_attributes.inc function name entries Created with: gclient setdep -r src/third_party/pdfium@13a5f9e46a5d The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ia1183044c29b9e489a762dbf86e442208657dd45 Reviewed-on: https://chromium-review.googlesource.com/c/1434874Reviewed-by:
-
khmel@chromium.org authored
This unifies using user type filtering for extension based and web default apps via json file declaration. DD: https://goto.google.com/web_app_default webapp support was added here: crrev.com/c/1401508 crrev.com/i/784837 - update default app list for all boards. These are only apps that has child_users in external_extensions.json and no managed_users are used currently in external_extensions.json crrev.com/c/1407458 - update script that generates default extensions. TEST=Locally, set of apps as expected on nocturne for different user types. Unit test added BUG=921121 Change-Id: I655c1e3bf1e9974aed52e0b74d544a7d41450214 Reviewed-on: https://chromium-review.googlesource.com/c/1407498Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#625784}
-
