- 31 Oct, 2018 40 commits
-
-
Xiaohan Wang authored
When using BEST_EFFORT, the CDM is registered pretty late that browser tests are failing, and if we specify a site playing encrypted media on command line, the site will find Widevine not supproted (because it's not registered yet). This CL changes the task priority to be USER_VISIBLE to solve this issue. Bug: 900169 Test: Failing tests are passing now. Change-Id: I8530048a07d804f5d99637745a8b7db0851ff221 Reviewed-on: https://chromium-review.googlesource.com/c/1308974 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#604285}
-
Daniel Bratell authored
In jumbo builds many cc files compile together in the same translation unit and then they share the same anonymous namespace. That means that within a (jumbo) build target, also symbols in anonymous namespaces need (build target) unique names. In a recent patch, two GetPromoStringSpecifier functions appeared. They are almost identical but not quite, so this patch just gives them unique names to make all jumbo build configurations happy again. Most jumbo build configurations were already happy because the relevant files did not easily end up in the same jumbo chunk. See https://chromium-review.googlesource.com/c/1298394 TBR=collinbaker@chromium.org,bsep@chromium.org,nyquist@chromium.org,robliao@chromium.org Change-Id: I5f244fc6a4e5b2047f2fdb443d0e40565c8bc103 Reviewed-on: https://chromium-review.googlesource.com/c/1309739Reviewed-by:
Daniel Bratell <bratell@opera.com> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#604284}
-
Lukasz Suder authored
Bug: 806868 Change-Id: Ibb115c06bd38f4f5749d15a292d93206dba13d32 Reviewed-on: https://chromium-review.googlesource.com/c/1307410Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Lukasz Suder <lsuder@google.com> Cr-Commit-Position: refs/heads/master@{#604283}
-
Justin Cohen authored
justincohen@ is an author of all code in ios/chrome/browser/ntp Change-Id: I5888fc83e7fa5aabc3187d2c12456adce9ab1da8 Reviewed-on: https://chromium-review.googlesource.com/c/1308994Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#604282}
-
Ken Rockot authored
Gets rid of ForwardingService since it's no longer necessary. Instead, relevant uses of ServiceContext -- whose use necessitated ForwardingService -- have been replaced with the more flexible ServiceBinding. Bug: 891780 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I86011161234afa7395a7bc1240d360bcf97fa851 Reviewed-on: https://chromium-review.googlesource.com/c/1259487Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#604281}
-
Dave Tapuska authored
Mozilla has requested changes to the IDL and either format is identical for Chrome (after we've shipped). They weren't when it was optional. BUG=899734 Change-Id: I85dc7e27c4dc77f5f6443e6ba212f4835ba30e77 Reviewed-on: https://chromium-review.googlesource.com/c/1304615Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#604280}
-
Jared Saul authored
This is a redo of https://chromium-review.googlesource.com/c/chromium/src/+/1300794. That CL was reverted because there were still internal Android dependencies that I originally missed, which I resolved earlier today. Bug: 881343 Change-Id: I99b87e859c0fc147f1c8343f5170d93cad066f7d Reviewed-on: https://chromium-review.googlesource.com/c/1308607Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#604279}
-
Tim Zheng authored
The default Crostini terminal app is crosh in a Chrome window and the display density toggle doesn't apply. BUG=chromium:839242;chromium:900032 TEST=Manually tested on an eve device Change-Id: I5d7007009803b63590864e107ece80082f9cfb9b Reviewed-on: https://chromium-review.googlesource.com/c/1308416Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Tim Zheng <timzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#604278}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2e039e9c4069..ab0e8a3d06fc Created with: gclient setdep -r src-internal@ab0e8a3d06fc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I06799bea43c3f66d2fde2a7745996ba68ba1f5fb Reviewed-on: https://chromium-review.googlesource.com/c/1309548Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604277}
-
Fredrik Söderquist authored
Per: "A value of zero for either width or height disables rendering of the element and its embedded content." (https://svgwg.org/svg2-draft/embedded.html#Placement) and: "For each descendant graphics element child of parent: * If child is not rendered then continue to the next descendant graphics element." (https://svgwg.org/svg2-draft/coords.html#BoundingBoxes) <foreignObject> / <image> with 'width' or 'height' zero should not contribute to an ancestor container's bounding box. Bug: 643493 Change-Id: I097d9d28faaa52fc793dab251f22bc7b2610d6ad Reviewed-on: https://chromium-review.googlesource.com/c/1309773Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#604276}
-
Morten Stenshorne authored
When an inline object has a block child, we need to split the inline into two "continuations", wrap them inside separate anonymous blocks, and put the actual block child(ren) between those anonymous blocks, also wrapped inside a designated anonymous block. If we later on remove that block child, we don't tear down the continuation chain completely. We get rid of all the anononymous blocks, but keep the two split inlines, that will suddenly become adjacent siblings. They should ideally be joined back into one layout object, but we don't do that. And this fix isn't about that (because I really wish to do other things than just causing and fixing fuzzer crashers for the rest of this year and half of the next). Instead, make sure that we cope with bogus continuation chains. The problem was when an inline that had a bogus continuation chain became relatively positioned, and we ended up marking a subsequent anonymous block as relatively-positioned, although none of its children were DOM children of the inline. This in turn caused trouble for absolute positioning, after https://chromium-review.googlesource.com/c/1301457 , which expects that there be relatively positioned inlines in the vicinity if an anonymous container with block children is relatively positioned. Bug: 900451 Change-Id: Ibde930b12201c10cdf508733d4d182d731e11ecb Reviewed-on: https://chromium-review.googlesource.com/c/1309777 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#604275}
-
Mason Freed authored
This fixes several clusterfuzz issues, which are caused by frames being freed in between calls to CompositeWithRaster(). With this CL, a fresh list of frames is requested and checked for the next one, to avoid using deleted frames. Note that with this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1252141 those calls are asynchronous. Also note that this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1213864 caused this code to get called much more frequently, for all layout tests. Here are the clusterfuzz issues: https://clusterfuzz.com/v2/testcase-detail/5701500434907136 https://clusterfuzz.com/v2/testcase-detail/4929420383748096 https://clusterfuzz.com/v2/testcase-detail/4996950557196288 Bug: 900087, 899465, 899450 Change-Id: I70fc7c723b2118f4796289fe9b7272c42b6e50e5 Reviewed-on: https://chromium-review.googlesource.com/c/1308038Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#604274}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/83d923f38664..73329c8df9d5 git log 83d923f38664..73329c8df9d5 --date=short --no-merges --format='%ad %ae %s' 2018-10-31 reed@google.com remove alignenum flag -- rely on clients to add it as needed Created with: gclient setdep -r src/third_party/skia@73329c8df9d5 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: I8df114a6bad35b88ecc37ff2a62e656701eead31 Reviewed-on: https://chromium-review.googlesource.com/c/1309549Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604273}
-
James Hawkins authored
The EasyUnlock V1 setup flow is being removed, so this caching mechanism is not necessary at the moment and helps break up the removal change. R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: I7a15a78d95edf5585636dc398f708fa12a7e0bc7 Reviewed-on: https://chromium-review.googlesource.com/c/1306348 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#604272}
-
James Hawkins authored
Since is the last method on EasyUnlockServiceObserver, that interface is also removed. Bug: 899324 Test: none Change-Id: Idf4c4136ec97431a5ceaa6d9a3c69a5a782b7882 Reviewed-on: https://chromium-review.googlesource.com/c/1307068 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#604271}
-
Nikita Podguzov authored
Bug: 899193 Change-Id: I282a91ea90d5cebe4353a223960712c3b3be9c73 Reviewed-on: https://chromium-review.googlesource.com/c/1308715Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
-
Tim Volodine authored
Make sure the Accept-Language HTTP request header works in Android WebView and fix the corresponding tests. In this patch: - make sure to update the network context using SetAcceptLanguage when the WebView Accept-Language setting changes. - fix tests This patch fixes: - org.chromium.android_webview.test.AcceptLanguageTest#testAcceptLanguage - org.chromium.android_webview.test.AcceptLanguageTest#testAcceptLanguagesWithenUS BUG=893561,841556 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ibd745513484466541dffbf9d24b65c1e702dc9b0 Reviewed-on: https://chromium-review.googlesource.com/c/1280857 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#604269}
-
Robert Sesek authored
Bug: 891697 Change-Id: I49eb77963515637df739c9d2ce83530d4e21cf15 Reviewed-on: https://chromium-review.googlesource.com/c/1308771Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#604268}
-
sczs authored
- Adds message parameter support for TestInfobarDelegate. - Adds Infobar eg test cases for stacked Infobars. Bug: 892376 Change-Id: I9f1f8b16d84ab0bf19111fa50e790319414a9a2d Reviewed-on: https://chromium-review.googlesource.com/c/1308900Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#604267}
-
Collin Baker authored
This will allow the per-profile instance to be fetched from any code that has a Profile*. Bug: 887991 Change-Id: I8394c07033b8e2940cf2a76bb6a697ca09ada452 Reviewed-on: https://chromium-review.googlesource.com/c/1306788 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#604266}
-
Peng Huang authored
Since GLContextVirtual::Initialize() will set GLStateRestorer, so RasterCommandBufferStub and InProcessCommandBuffer don't set it. Bug: None Change-Id: I29f517b03170ce6d5d1bd7182f036aedef090507 Reviewed-on: https://chromium-review.googlesource.com/c/1309881Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#604265}
-
henrika authored
Summary: - getUserMedia({audio: {echoCancellation: {exact: false}}}) => - Adds support for "clean mode" without using any input effects on Android - Avoid switching to COMM mode - Removes usage of AEC white list for Android - Removes spam log messages - Extends logging of audio parameters in audio streams Bug: 866390 Tbr: dalecurtis@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I45beca7e37c380826cff15ff917233e8379986cb Reviewed-on: https://chromium-review.googlesource.com/c/1304516 Commit-Queue: Henrik Andreasson <henrika@chromium.org> Reviewed-by:Oskar Sundbom <ossu@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#604264}
-
Francois Doray authored
WorkingSetTrimmer empties the working set of processes in which all frames are frozen. We want to do this to: 1. Track working set growth rate (we empty the working set and record its size x minutes after). 2. Assess impact on global performance. Bug: 885293 Change-Id: I371cc17836b6de5cc749dfb6488b7734a6bf870c Reviewed-on: https://chromium-review.googlesource.com/c/1238819 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#604263}
-
Owen Min authored
Disable this test on Mac10.12 and Win7 because the test is flaky. Bug: 900326 Change-Id: Iaed7c8a54ec98aedddc7c9584556c202d368294c Tbr: dgozman@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1310013Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#604262}
-
Owen Min authored
Bug: 899893 Change-Id: I627404e1ab4344da015b593f46ad751404ae3d4f Tbr: raymes@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1309117Reviewed-by:
-
Xida Chen authored
This variable was added to test whether the touch start / end can be acked and released out of order or not. From the reading of the code, I don't think is true. This CL removes this variable, we will monitor crash reports to ensure this doesn't cause regression. To ensure the same behavior, we need a new variable, which is named |touch_sequence_in_progress_| in this CL. This is specifically for this scenario: we have received touch event ack for touch start, and then JS removes / adds touch event listener, which triggers a OnHasTouchEventHandlers call. In this case, we should not reset touch action if the |touch_sequence_in_pgoress_| is true. We have the unit test OnHasTouchEventHandlersReceivedAfterTouchStart to ensure this behavior. Bug: 900195 Change-Id: I53c3141905b4e2a49ab6e62ea43335c4cee17c15 Reviewed-on: https://chromium-review.googlesource.com/c/1307250 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#604260}
-
Dan Harrington authored
When AutoFetchOnNetErrorPage is enabled, the dino page will schedule fetching the page in the background. The UI changes associated with this feature will come in a subsequent CL. Bug: 883486 Change-Id: I308fc93026cf8a126a68b3aa035cf37df39f7871 Reviewed-on: https://chromium-review.googlesource.com/c/1289705 Commit-Queue: Dan H <harringtond@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#604259}
-
Mostyn Bramley-Moore authored
This change should allow cache hits with goma and ccache. Change-Id: Ie9f1566d6f76a3de5fba5d039ff1a7f5b6f3b2ac Reviewed-on: https://chromium-review.googlesource.com/c/1309778 Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#604258}
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/22caec62055a..46155299edb9 $ git log 22caec620..46155299e --date=short --no-merges --format='%ad %ae %s' 2018-10-31 junyer Don't log/crash when PrefilterTree::KeepNode() sees Prefilter::NONE. Created with: roll-dep src/third_party/re2/src R=mmoroz@chromium.org Bug: 900558 Change-Id: Ic497e7019b2b072a91b0ea3710c138efa6d1ef7a Reviewed-on: https://chromium-review.googlesource.com/c/1309878Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#604257}
-
Ehsan Karamad authored
Feature-Policy does not quite make sense in a view-source document; such documents are not actually rendering "the" WebPage. This CL makes sure feature policy takes the default values for a view-source document. TBR=iclelland@chromium.org Bug: 898688 Change-Id: I4f8667f8539da977d0cf0281f4e8ee99fe9b23e9 Reviewed-on: https://chromium-review.googlesource.com/c/1305248 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#604256}
-
Francois Doray authored
We want to experiment with scheduling features that can increase the completion time of BEST_EFFORT tasks a lot. Before we do this, we want to make sure that BEST_EFFORT tasks are not required to complete important user actions (navigation, scrolling, omnibox). Bug: 831835 Change-Id: I5b935172e0349b7f74fd6120109e1e50cb8d1653 Reviewed-on: https://chromium-review.googlesource.com/c/1307834 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#604255}
-
Charlie Harrison authored
We aren't actually using anything intrinsic to the class, so there is no point. Note: This CL also removes a TODO to add _more_ framebust logic to TabSpecificContentSettings. Since there are multiple UIs that interact with the POPUP setting, it seems best to have a separate class deal with that state, and eventually move popup stuff out of there. Bug: 895555 Change-Id: Ifc1de176525c30972a4a00ac2c90b2c44f339f0b Reviewed-on: https://chromium-review.googlesource.com/c/1283411 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
-
Sandra Sun authored
As CSSScrollSnap is shipped in M69, this patch removes the runtime flag. Bug: 889523 Change-Id: I600f21d04318d4abf375ea441de1bbc287532975 Reviewed-on: https://chromium-review.googlesource.com/c/1307117Reviewed-by:
-
Sam Zackrisson authored
Related deprecation PSA: https://groups.google.com/d/msg/discuss-webrtc/NgqEPvkNuDE/7HtwnMmADgAJ Bug: webrtc:9947 Change-Id: I392a9c27641a1b37170c27c9f42721bdae353615 Reviewed-on: https://chromium-review.googlesource.com/c/1309785Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/6647884a130d..fb996dce7525 git log 6647884a130d..fb996dce7525 --date=short --no-merges --format='%ad %ae %s' 2018-10-31 jbolz@nvidia.com Add /Zm flag as a workaround for VS2013 build (#2023) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@fb996dce7525 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Idb43e8c39a3c73adac2a583f8a666236a316b3c7 Reviewed-on: https://chromium-review.googlesource.com/c/1309545Reviewed-by:
-
Sigurdur Asgeirsson authored
All the presentation changes needed to get the tab to display correctly and to track with size changes, but the tab itself is blank. Bug: 891310 Change-Id: Ic0e6cafed3237b459d1b76b1997029c3a4cd580c Reviewed-on: https://chromium-review.googlesource.com/c/1305874Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#604250}
-
Corentin Wallez authored
This will allow us to run Dawn's GPU tests on the Chromium GPU FYI waterfall and GPU trybots. BUG=chromium:870747 Change-Id: I026cd1851aadbf1dae2446c539901bf4a755dfd8 Reviewed-on: https://chromium-review.googlesource.com/c/1299089Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#604249}
-
chrome://discardsSigurdur Asgeirsson authored
This is to support rendering the Resource Coordinator graph using D3.js in a future CL. Bug: 891310 Change-Id: Ie58ab6e8e49b2e897eabecf79b202172c50bf5ef Reviewed-on: https://chromium-review.googlesource.com/c/1305204 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#604248}
-
Olivier Robin authored
Registering NSURLProtocol will cancel the NSURLSession in progress. Documentation state that NSURLProtocol must be registered before sending NSURLSession, but sending NSURLSession just after setting a protocol will also fail (at least synchronously in the application didFinishLaunching runloop). This CL adds an experiment to disable the breakpad upload enabling in this runloop. Upload will be triggered on the initialization of the settings observer during the deferred initialization (about 4 seconds later). Random notes: - recovery mode does not initialize ChromeNetworkStack, so is not affected by the issue. - There may be other NSURLsession triggered in this runloop that are affected. Bug: 898474 Change-Id: I4c9fddd4fef70d770b200d7264bf729b2f025d28 Reviewed-on: https://chromium-review.googlesource.com/c/1307501Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#604247}
-
Kurt Horimoto authored
On iOS 10, UITableView will attempt to reload the deleted row's section after the animation, regardless of whether it's been removed from the UITableViewDataSource. This CL prevents that from occurring by performing a full reload when sections are deleted for swipe gestures on iOS 10. Bug: 898841 Change-Id: Ib35089be7982d040ad4e71a4b1759495dd7b8345 Reviewed-on: https://chromium-review.googlesource.com/c/1300106 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#604246}
-
