GitLab

Design doc: https://docs.google.com/document/d/1qdlgaC277SnnmQv7hoNFTGp-OCvokEc4mA2NmAzOyBU/edit?usp=sharing

BUG=550967
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/1991273003
Cr-Commit-Position: refs/heads/master@{#403176}

Jim is no longer working on Chromium (much?), and does not typically respond to
metrics code reviews. Avoid delaying contributors by removing him from the list
of OWNERS.

BUG=none
R=asvitkine@chromium.org

Review-Url: https://codereview.chromium.org/2114483002
Cr-Commit-Position: refs/heads/master@{#403175}

BUG=443781,568175
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq

Review-Url: https://codereview.chromium.org/2098613005
Cr-Commit-Position: refs/heads/master@{#403174}

Reason for revert:
Now tested with webview-related downstream gn args enabled.

TBR=brettw
BUG=620034

Review-Url: https://codereview.chromium.org/2109293003
Cr-Commit-Position: refs/heads/master@{#403173}

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

BUG=616447
R=zelidrag@chromium.org

Review-Url: https://codereview.chromium.org/2083493004
Cr-Commit-Position: refs/heads/master@{#403172}

This CL updates the test filters for the FYI bot LinuxBrowserSideNavigation.
This follows the change for ServiceWorker support where we removed our first
implementation that was only partially working.
Making this NOTRY since there are no code changes and this is for an FYI bot.

BUG=504347, 576261
TBR=carlosk@chromium.org
NOTRY=TRUE

Review-Url: https://codereview.chromium.org/2110263003
Cr-Commit-Position: refs/heads/master@{#403171}

zoom, translate, passwords) and content settings icon.

This doesn't do anything for other icon label bubble views (like the
location icon). Some of the code in ContentSettingImageView should
probably be moved into IconLabelBubbleView for that. Also, there's no
hover or focus effect when the label is showing (e.g. when Chrome first
blocks a popup and there's text next to the icon). Since it remains
unclear to me how the hover and press effects should look in this
scenario, limit the ink drop to when only the icon is visible.

BUG=591140

Review-Url: https://codereview.chromium.org/2098643002
Cr-Commit-Position: refs/heads/master@{#403170}

Multiple parts of the code need to access the "ln="
field, if any, in the second line text fields of a
SuggestionAnswer. Move the parse and access method
to a central place, and fix up the callers.

BUG=

Review-Url: https://codereview.chromium.org/2091473003
Cr-Commit-Position: refs/heads/master@{#403169}

Covers:
rtc_video_decoder.cc
rtc_video_decoder_factory.cc
rtc_video_decoder_factory.h
rtc_video_decoder.h
rtc_video_decoder_unittest.cc
rtc_video_encoder.cc
rtc_video_encoder_factory.cc
rtc_video_encoder_factory.h
rtc_video_encoder.h

The above files have been moved to content/renderer/media/gpu.

BUG=None
TEST=Build Chrome on ChromeOS

Review-Url: https://codereview.chromium.org/2095393002
Cr-Commit-Position: refs/heads/master@{#403168}

BUG=624503

Review-Url: https://codereview.chromium.org/2102883005
Cr-Commit-Position: refs/heads/master@{#403167}

-[NSWindow isVisible].

After restoring from a miniaturize, child windows are currently reattached too
early. This is because AppKit draws the window before updating the result of
-[NSWindow isVisible], and we need to participate in that draw. But updating
child window relationships at this time causes layering issues when the window
has finished restoring.

BUG=620266

Review-Url: https://codereview.chromium.org/2069103004
Cr-Commit-Position: refs/heads/master@{#403166}

Also change all remaining invocations of the copy constructor or copy assignment
operator to move or explicit copy.

This CL lands server change 126070406 by bnc.

BUG=488484, 621905

Review-Url: https://codereview.chromium.org/2102253003
Cr-Commit-Position: refs/heads/master@{#403165}

Previous CL on authorization timeout decrease is being reverted https://codereview.chromium.org/2106373002/, this one should be landed instead.

The reason is we hit authorization timeout on platforms other than Windows (https://uma.googleplex.com/p/chrome/timeline_v2?sid=74e6fc3b3d0ef041f64f37272402ebb1), but the goal was to address windows driver hangs only.

BUG=615589

Review-Url: https://codereview.chromium.org/2116443002
Cr-Commit-Position: refs/heads/master@{#403164}

BUG=615382

Review-Url: https://codereview.chromium.org/2110653002
Cr-Commit-Position: refs/heads/master@{#403163}

Refactored using Seb's method ;)

BUG=None
TEST=AutofillFieldTest

Review-Url: https://codereview.chromium.org/2113453002
Cr-Commit-Position: refs/heads/master@{#403162}

This is a roll-back to 5.3.332.1. This is the most stable candidate out of the latest Canaries.

If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back.

When in doubt please try to contact the committer and reviewers of this CL before reverting it.

TBR=machenbach@chromium.org

Review-Url: https://codereview.chromium.org/2117443003
Cr-Commit-Position: refs/heads/master@{#403161}

Record only one poll action if the same field is queried for suggestions multiple times consecutively.

BUG=624753

Review-Url: https://codereview.chromium.org/2111863002
Cr-Commit-Position: refs/heads/master@{#403160}

This target was overlooked and will be used by refactoring of
ios_chrome_unittests.

BUG=624450

Review-Url: https://codereview.chromium.org/2119433002
Cr-Commit-Position: refs/heads/master@{#403159}

https://chromium.googlesource.com/skia.git/+log/fc5b70a8e427..df4f47b8ff63

$ git log fc5b70a8e..df4f47b8f --date=short --no-merges --format='%ad %ae %s'
2016-06-30 benjaminwagner Revert of Better encapsulate oval/rrect batchs. (patchset #4 id:60001 of https://codereview.chromium.org/2104423003/ )
2016-06-29 bsalomon Hide more GrBatch Geometry structs. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2110903002
2016-06-29 bsalomon Better encapsulate oval/rrect batchs. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2104423003

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel;master.tryserver.chromium.android:android_arm64_dbg_recipe
TBR=benjaminwagner@google.com

Review-Url: https://codereview.chromium.org/2111893002
Cr-Commit-Position: refs/heads/master@{#403158}

BUG=619741

Review-Url: https://codereview.chromium.org/2108873004
Cr-Commit-Position: refs/heads/master@{#403157}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/11d23802de36..ead31d8dd552

$ git log 11d23802d..ead31d8dd --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2112493004
Cr-Commit-Position: refs/heads/master@{#403156}

* Add remote-shell interface to control system modality
* Add shell-mode event to notify the shell mode switch
* Shadow underlay should be deleted when shadow is turned off

In new patch
* updated system modal test in shell_surface_unittests to match new api.

BUG=b/29625835, b/29229887
TBR=reveman@chromium.org

Review-Url: https://codereview.chromium.org/2109303003
Cr-Commit-Position: refs/heads/master@{#403155}

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/b665ea9..7f4673c

TBR=

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_archive_rel_ng;tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=
NOTRY=true
(using notry due to failing archive bot)

Review-Url: https://codereview.chromium.org/2114603002
Cr-Commit-Position: refs/heads/master@{#403154}

Add StyleBuilderConverter::convertClipPath and use it for computing
the ClipPathOperation.

BUG=610854

Review-Url: https://codereview.chromium.org/2105383002
Cr-Commit-Position: refs/heads/master@{#403153}

Migrate the one-time notice about other forms of browsing history
(introduced in https://codereview.chromium.org/1813023002/) to the
MD settings.

The C++ side is migrated more or less verbatim from ClearBrowserDataHandler.
The JS side adds a new 'settings-other-forms-of-browsing-history-notice'.

We add a test to verify that the one-time notice is shown, and that closing
it will close its parent CBD dialog.

BUG=595580
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2098633002
Cr-Commit-Position: refs/heads/master@{#403152}

BUG=624687

Review-Url: https://codereview.chromium.org/2117443002
Cr-Commit-Position: refs/heads/master@{#403151}

experiment settings

Prerequisite for landing is https://codereview.chromium.org/2067863003

BUG=560378, 622773

Review-Url: https://codereview.chromium.org/2108673004
Cr-Commit-Position: refs/heads/master@{#403150}

setTintList() is an API 21 method. setColorFilter() with the right
parameters does the same thing.

BUG=624690
TBR=finnur@chromium.org

Review-Url: https://codereview.chromium.org/2114623002
Cr-Commit-Position: refs/heads/master@{#403149}

This is partial revert of
https://codereview.chromium.org/1915113005.

The modifications in MemoryCache are reverted before going to beta because it
might be not so stable, while other field-trial related changes are kept
because I'm planning further experiment in the next milestone.

BUG=603462

Review-Url: https://codereview.chromium.org/2110823003
Cr-Commit-Position: refs/heads/master@{#403148}

Revert of AudioOutputDevice authorization timeout decreased (patchset #2 id:40001 of https://codereview.chromium.org/2083633002/ )

Reason for revert:
Needs to be restricted to windows-only

Original issue's description:
> AudioOutputDevice authorization timeout decreased
>
> BUG=615589
>
> Committed: https://crrev.com/70d5e74e6225e01dc2ade9b89a7c30f5bdb356e1
> Cr-Commit-Position: refs/heads/master@{#402467}

TBR=dalecurtis@chromium.org,tommi@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=615589

Review-Url: https://codereview.chromium.org/2106373002
Cr-Commit-Position: refs/heads/master@{#403147}

Re-enabling flaky MediaSessionVisibilityBrowserTests with more logging
to diagnose the issue.

BUG=619096

Review-Url: https://codereview.chromium.org/2108783003
Cr-Commit-Position: refs/heads/master@{#403146}

BUG=620113

Review-Url: https://codereview.chromium.org/2105743003
Cr-Commit-Position: refs/heads/master@{#403145}

This greatly reduces the regions where the Cards New Tab Page snaps to scroll.
- Scrolling will snap to ensure the page does not come to rest in the middle
  of either the fakebox or peeking card transition.
- Scrolling will snap back if only the top of the peeking card is visible,
  making it properly peek.

In addition, it disables the search logo fading out on scroll.

Because the scrolling behaviour has changed, the following user actions are obsolete:
- MobileNTP.Snippets.ScrolledAboveTheFold
- MobileNTP.Snippets.ScrolledBelowTheFold

BUG=623930

Review-Url: https://codereview.chromium.org/2106753002
Cr-Commit-Position: refs/heads/master@{#403144}

This is not the case anymore as of commit
e2452b1f: "Removed unused include of winsock.h/inet.h from
sys_byteorder.h.".

BUG=None
R=thestig@chromium.org

Review-Url: https://codereview.chromium.org/2117433002
Cr-Commit-Position: refs/heads/master@{#403143}

Cleaning up video-controls* tests in media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956

Review-Url: https://codereview.chromium.org/2108993003
Cr-Commit-Position: refs/heads/master@{#403142}

This patch adds support of large mouse cursor on Exosphere. If the large cursor set is selected, exosphere enlarges the cursor.

BUG=b/29169901
TEST=Run unit_tests, and test manualy

Review-Url: https://codereview.chromium.org/2071553002
Cr-Commit-Position: refs/heads/master@{#403141}

Revert of 🎊 Reland of Have build_config targets depend only on other build_config targets (patchset #2 id:130001 of https://codereview.chromium.org/2109593005/ )

Reason for revert:
breaks downstream rollers' gn gen

Original issue's description:
> Reland of Have build_config targets depend only on other build_config targets
>
> Reason for revert:
> Added missing dep for andriod_assets. Testing clean builds.
>
> TBR=brettw
> BUG=620034
>
> Committed: https://crrev.com/3df1aa821cb0298158b788bb37087460a19e52ea
> Cr-Commit-Position: refs/heads/master@{#403054}

TBR=brettw@chromium.org,petewil@chromium.org,agrieve@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=620034

Review-Url: https://codereview.chromium.org/2115543002
Cr-Commit-Position: refs/heads/master@{#403140}

Revert of Roll src/third_party/skia/ fc5b70a8e..f17030906 (2 commits). (patchset #1 id:1 of https://codereview.chromium.org/2109413002/ )

Reason for revert:
Seems to have broken the Android Arm64 Builder:

Bot Log: http://build.chromium.org/p/chromium.linux/builders/Android%20Arm64%20Builder%20%28dbg%29/builds/35938/steps/compile/logs/stdio
Build error: http://pastebin.com/EhNU4K2r

Original issue's description:
> Roll src/third_party/skia/ fc5b70a8e..f17030906 (2 commits).
>
> https://chromium.googlesource.com/skia.git/+log/fc5b70a8e427..f17030906dde
>
> $ git log fc5b70a8e..f17030906 --date=short --no-merges --format='%ad %ae %s'
> 2016-06-29 bsalomon Hide more GrBatch Geometry structs. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2110903002
> 2016-06-29 bsalomon Better encapsulate oval/rrect batchs. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2104423003
>
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
> TBR=benjaminwagner@google.com
>
> Committed: https://crrev.com/322d968dbb49dfc02f2c18fd6ac91964a6e0e21f
> Cr-Commit-Position: refs/heads/master@{#403136}

TBR=benjaminwagner@google.com,skia-deps-roller@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2112683003
Cr-Commit-Position: refs/heads/master@{#403139}

BUG=624712
TBR=sadrul@chromium.org

Review-Url: https://codereview.chromium.org/2112833002
Cr-Commit-Position: refs/heads/master@{#403138}

BUG=624709
TBR=noel@chromium.org

Review-Url: https://codereview.chromium.org/2104373003
Cr-Commit-Position: refs/heads/master@{#403137}