GitLab

2009-04-16  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=25241
        Remove superfluous NotImplemented.h includes.

        * html/CanvasRenderingContext2D.cpp:
        * html/CanvasStyle.cpp:
        * page/AccessibilityRenderObject.cpp:
        * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
        * platform/graphics/GraphicsContext.cpp:
        * platform/graphics/cairo/ImageBufferCairo.cpp:
        * platform/graphics/cairo/PathCairo.cpp:
        * platform/graphics/chromium/SimpleFontDataLinux.cpp:
        * platform/graphics/gtk/FontGtk.cpp:
        * platform/graphics/gtk/IconGtk.cpp:
        * platform/graphics/qt/IconQt.cpp:
        * platform/graphics/qt/ImageQt.cpp:
        * platform/graphics/qt/ImageSourceQt.cpp:
        * platform/graphics/skia/ImageBufferSkia.cpp:
        * platform/graphics/skia/ImageSkia.cpp:
        * platform/graphics/win/ColorSafari.cpp:
        * platform/graphics/win/FontWin.cpp:
        * platform/graphics/win/GraphicsContextCGWin.cpp:
        * platform/graphics/win/GraphicsContextCairoWin.cpp:
        * platform/graphics/win/SimpleFontDataCairoWin.cpp:
        * platform/graphics/wx/ImageWx.cpp:
        * platform/graphics/wx/TransformationMatrixWx.cpp:
        * platform/gtk/PlatformScreenGtk.cpp:
        * platform/gtk/PopupMenuGtk.cpp:
        * platform/gtk/ScrollViewGtk.cpp:
        * platform/gtk/ScrollbarGtk.cpp:
        * platform/network/cf/ResourceHandleCFNet.cpp:
        * platform/posix/FileSystemPOSIX.cpp:
        * platform/qt/DragDataQt.cpp:
        * platform/qt/FileSystemQt.cpp:
        * platform/qt/Localizations.cpp:
        * platform/qt/PopupMenuQt.cpp:
        * platform/win/EditorWin.cpp:
        * platform/win/PasteboardWin.cpp:
        * platform/wx/KeyboardEventWx.cpp:
        * platform/wx/PopupMenuWx.cpp:
        * platform/wx/SharedTimerWx.cpp:
        * plugins/gtk/PluginViewGtk.cpp:
        * plugins/mac/PluginPackageMac.cpp:
        * plugins/qt/PluginPackageQt.cpp:
        * plugins/win/PluginViewWin.cpp:
        * rendering/RenderThemeChromiumLinux.cpp:
        * svg/graphics/SVGImage.cpp:

WebKit/gtk:

2009-04-16  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=25241
        Remove superfluous NotImplemented.h includes.

        * webkit/webkitprivate.cpp:

WebKit/win:

2009-04-16  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=25241
        Remove superfluous NotImplemented.h includes

        * WebDownloadCFNet.cpp:
        * WebURLAuthenticationChallengeSender.cpp:
        * WebView.cpp:

git-svn-id: svn://svn.chromium.org/blink/trunk@42590 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Sam Weinig.

        More fix for https://bugs.webkit.org/show_bug.cgi?id=21260
        Unbounded memory growth when churning elements with anonymous event handler functions
        
        Some cleanup in event handling code.

        * bindings/js/JSDOMGlobalObject.cpp:
        * bindings/js/JSDOMGlobalObject.h: Removed findJSProtectedEventListener
        and findJSProtectedEventListener because they are now unused.

        * bindings/js/JSEventListener.cpp:
        * bindings/js/JSEventListener.h:
        (WebCore::JSEventListener::clearGlobalObject):
        * bindings/js/JSLazyEventListener.cpp:
        (WebCore::JSLazyEventListener::JSLazyEventListener):
        (WebCore::JSLazyEventListener::~JSLazyEventListener):
        (WebCore::JSLazyEventListener::globalObject):
        * bindings/js/JSLazyEventListener.h:
        (WebCore::JSLazyEventListener::clearGlobalObject): Nixed JSProtectedEventListener,
        and merged it with JSLazyEventListener, the only remaining event listener
        that still GC-protects its function and global object.

        * bindings/js/ScriptController.cpp:
        (WebCore::ScriptController::ScriptController):
        * bindings/js/ScriptController.h:
        (WebCore::ScriptController::setEventHandlerLineNumber):
        (WebCore::ScriptController::eventHandlerLineNumber): Renamed handlerLineno =>
        handlerLineNumber, because anything less would be uncivilized. Removed
        createInlineEventListener because it mostly did irrelevent work, so it
        just got in the way of understanding how event handler creation works.

        * dom/Document.cpp:
        (WebCore::Document::createEventListener):
        * dom/XMLTokenizerLibxml2.cpp:
        (WebCore::XMLTokenizer::startElementNs):
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::processToken): Ditto.



git-svn-id: svn://svn.chromium.org/blink/trunk@42589 bbb929c8-8fbe-4397-9dbb-9b2b20218538

git-svn-id: svn://svn.chromium.org/blink/trunk@42588 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Dave Hyatt.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=20765 Website 
        crashes on load due to messy HTML in search form
        -and corresponding-
        <rdar://problem/6210633>

        Before this patch, <form>s were allowed to sit inside tables 
        without being wrapped by anonymous table parts. There was also a 
        concept that such a form could be "demoted" and would not be 
        allowed to have any children. This patch has the HTML parser mark 
        form elements that have been demoted as such, and then the demoted 
        forms are not given renderers. I also removed the code that allowed 
        forms to sit in tables without anonymous table sections. So now any 
        forms that do manage to get a renderer inside a table will also be 
        wrapped with appropriate table parts.

        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::HTMLFormElement):
        (WebCore::HTMLFormElement::rendererIsNeeded):
        * html/HTMLFormElement.h:
        (WebCore::HTMLFormElement::setDemoted):
        (WebCore::HTMLFormElement::isDemoted):
        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::insertNode):
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::addChild):
        * rendering/RenderTableRow.cpp:
        (WebCore::RenderTableRow::addChild):
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::addChild):



git-svn-id: svn://svn.chromium.org/blink/trunk@42587 bbb929c8-8fbe-4397-9dbb-9b2b20218538

2009-04-16  Beth Dakin  <bdakin@apple.com>

        Reviewed by Dave Hyatt.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=20765 Website 
        crashes on load due to messy HTML in search form
        -and corresponding-
        <rdar://problem/6210633>

        Before this patch, <form>s were allowed to sit inside tables 
        without being wrapped by anonymous table parts. There was also a 
        concept that such a from could be "demoted" and would not be 
        allowed to have any children. This patch has the HTML parser mark 
        form elements that have been demoted as such, and then the demoted 
        forms are not given renderers. I also removed the code that allowed 
        forms to sit in tables without anonymous table sections. So now any 
        forms that do manage to get a renderer inside a table will also be 
        wrapped with appropriate table parts.

        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::HTMLFormElement):
        (WebCore::HTMLFormElement::rendererIsNeeded):
        * html/HTMLFormElement.h:
        (WebCore::HTMLFormElement::setDemoted):
        (WebCore::HTMLFormElement::isDemoted):
        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::insertNode):
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::addChild):
        * rendering/RenderTableRow.cpp:
        (WebCore::RenderTableRow::addChild):
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::addChild):

LayoutTests:

2009-04-16  Beth Dakin  <bdakin@apple.com>

        Reviewed by Dave Hyatt.

        Tests for https://bugs.webkit.org/show_bug.cgi?id=20765 Website 
        crashes on load due to messy HTML in search form
        -and corresponding-
        <rdar://problem/6210633>

        New tests:
        * fast/forms/form-added-to-table.html: Added.
        * fast/forms/form-in-malformed-markup.html: Added.
        * platform/mac/fast/forms/form-added-to-table-expected.checksum: Added.
        * platform/mac/fast/forms/form-added-to-table-expected.png: Added.
        * platform/mac/fast/forms/form-added-to-table-expected.txt: Added.
        * platform/mac/fast/forms/form-in-malformed-markup-expected.checksum: Added.
        * platform/mac/fast/forms/form-in-malformed-markup-expected.png: Added.
        * platform/mac/fast/forms/form-in-malformed-markup-expected.txt: Added.

        Tests with new results:
        * platform/mac/fast/forms/formmove3-expected.txt:
        * platform/mac/fast/forms/preserveFormDuringResidualStyle-expected.txt:
        * platform/mac/fast/invalid/table-residual-style-crash-expected.txt:
        * platform/mac/fast/table/fixed-table-non-cell-in-row-expected.txt:
        * platform/mac/fast/table/inline-form-assert-expected.txt:
        * platform/mac/fast/table/insert-cell-before-form-expected.txt:
        * platform/mac/fast/table/insert-row-before-form-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug2516-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug30559-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug32447-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug34538-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug78162-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug96334-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug96343-expected.txt:
        * platform/mac/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:



git-svn-id: svn://svn.chromium.org/blink/trunk@42586 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Simon Fraser.

        Fix https://bugs.webkit.org/show_bug.cgi?id=24527
        caret does not paint the first time you focus on a 0px right padding RTL div

        Test: fast/forms/caret-rtl.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::localCaretRect): When calculating x-axis if 
        alignment is alignRight, we need to subtract the caretWidth so that the
        caret at IntRect(x, y, caretWidth, height) is inside the block.



git-svn-id: svn://svn.chromium.org/blink/trunk@42585 bbb929c8-8fbe-4397-9dbb-9b2b20218538

git-svn-id: svn://svn.chromium.org/blink/trunk@42584 bbb929c8-8fbe-4397-9dbb-9b2b20218538

2009-04-16  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=25228
        SelectionController::absoluteCaretBounds returns an inflated caret (the caret repaint rect)
        
        Return the bounds of the transformed caret, not the transformed repaint rect for the caret (which is inflated).

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::localCaretRect):
        (WebCore::SelectionController::absoluteBoundsForLocalRect):
        (WebCore::SelectionController::caretRepaintRect):
        (WebCore::SelectionController::recomputeCaretRect):
        * editing/SelectionController.h:

LayoutTests:

2009-04-16  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Simon Fraser.
        
        https://bugs.webkit.org/show_bug.cgi?id=25228
        SelectionController::absoluteCaretBounds returns an inflated caret (the caret repaint rect)

        * editing/selection/25228.html: Added.
        * platform/mac/editing/selection/25228-expected.checksum: Added.
        * platform/mac/editing/selection/25228-expected.png: Added.
        * platform/mac/editing/selection/25228-expected.txt: Added.



git-svn-id: svn://svn.chromium.org/blink/trunk@42583 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Adam Roben.

        Compare test's response mime type and dump test as text properly.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (dump):

git-svn-id: svn://svn.chromium.org/blink/trunk@42582 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=25187
        Bug 25187: <video> may not be rendered upon certain racy conditions

        Always create the video renderer when the load state reaches QTMovieLoadStateLoaded 
        and the element is visible, not only when the movie has just been opened.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::updateStates): Make sure we do not make false
        assumption on the state changes order. Create the renderer if none is present,
        when movie is loaded instead.


git-svn-id: svn://svn.chromium.org/blink/trunk@42581 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Add filterBoundingBox() to RenderSVGModelObject to share a tiny bit of code

        RenderSVGModelObject has much more interesting code it can share,
        but I'm just trying to get the commits out of my local branch and into
        the repository in any order I can. :)  This one was small.

        This will be used by the unified RenderSVGModelObject
        clippedOverflowRectForRepaint patch coming soon.

        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::clippedOverflowRectForRepaint):
        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::clippedOverflowRectForRepaint):
        * rendering/RenderSVGModelObject.cpp:
        (WebCore::RenderSVGModelObject::filterBoundingBox):
        * rendering/RenderSVGModelObject.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@42580 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Eric Seidel and Adam Roben.

        More fix for https://bugs.webkit.org/show_bug.cgi?id=21260
        Unbounded memory growth when churning elements with anonymous event handler functions
        
        Simplified some EventHandler creation code.
        
        Removed a pile of code whose sole purpose was to allow SVG event handlers
        to supply a parameter named "evt" instead of the normal "event", and
        replaced it with a single parameter to JSLazyEventListener's constructor
        specifying the parameter name to use.

        * bindings/js/JSDOMWindowBase.h:
        * bindings/js/JSLazyEventListener.cpp:
        (WebCore::JSLazyEventListener::JSLazyEventListener):
        (WebCore::JSLazyEventListener::parseCode):
        * bindings/js/JSLazyEventListener.h:
        (WebCore::JSLazyEventListener::create):
        * bindings/js/ScriptController.cpp:
        (WebCore::ScriptController::createInlineEventListener):
        * bindings/js/ScriptController.h:
        * dom/Document.cpp:
        (WebCore::Document::createEventListener):



git-svn-id: svn://svn.chromium.org/blink/trunk@42579 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Split out objectBoundingBox and repaintRectInLocalCoordinates from relativeBBox
        in preparation for simplifying (and fixing) repaint logic in the SVG rendering tree.
        https://bugs.webkit.org/show_bug.cgi?id=25224

        objectBoundingBox() matches the SVG 1.1 concept of a "bounding box"

        repaintRectInLocalCoordinates() should return the a rect covering all painted content.
        However, repaintRectInLocalCoordinates() still only returns the "stroke bounding box"
        in this patch.  In a future patch, repaintRectInLocalCoordinates will be fixed to return
        a rect covering all painted content.  In order to avoid changing several hundred layout test results, I've left
        the behavior as-is for now.  The returned rect is used by various repaintRectInLocalCoordinates
        implementations and sometimes adjusted to include all painted content, but not always, and
        the places where the adjustments are made are sometimes wrong.  Again, will be fixed in
        an upcoming patch.

        This patch discovered a bug in Font::drawTextUsingSVGFont, which is probably causing
        bounding-box relative gradients on SVGFont glyphs to not paint correctly.
        I chose not to try and fix the bug in this patch and instead left a FIXME.

        This patch also discovered that at least tspan.getBBox() is broken.  This
        along with the foreignObject.getBBox() change will be tested (and fixed) in a
        later patch.  https://bugs.webkit.org/show_bug.cgi?id=25225

        No change in behavior (besides the above mentioned foreignObject.getBBox()), thus no tests.

        * rendering/RenderForeignObject.cpp:
        (WebCore::RenderForeignObject::objectBoundingBox): this is a behavior improvement for getBBox() test case coming in a later patch
        (WebCore::RenderForeignObject::repaintRectInLocalCoordinates): only really used for layout test results, might some day be used for repaint.
        * rendering/RenderForeignObject.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::objectBoundingBox): new methods, ASSERT if used but not implemented.
        (WebCore::RenderObject::repaintRectInLocalCoordinates):
        * rendering/RenderObject.h:
        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::objectBoundingBox):
        (WebCore::RenderPath::repaintRectInLocalCoordinates):
        (WebCore::RenderPath::clippedOverflowRectForRepaint):
        (WebCore::RenderPath::lineHeight):
        (WebCore::RenderPath::baselinePosition):
        (WebCore::RenderPath::paint):
        (WebCore::RenderPath::addFocusRingRects):
        * rendering/RenderPath.h:
        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::paint):
        (WebCore::RenderSVGContainer::objectBoundingBox):
        (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
        * rendering/RenderSVGContainer.h:
        * rendering/RenderSVGGradientStop.h:
        (WebCore::RenderSVGGradientStop::objectBoundingBox):
        (WebCore::RenderSVGGradientStop::repaintRectInLocalCoordinates):
        * rendering/RenderSVGHiddenContainer.cpp:
        (WebCore::RenderSVGHiddenContainer::objectBoundingBox):
        (WebCore::RenderSVGHiddenContainer::repaintRectInLocalCoordinates):
        * rendering/RenderSVGHiddenContainer.h:
        * rendering/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::objectBoundingBox):
        (WebCore::RenderSVGImage::repaintRectInLocalCoordinates):
        (WebCore::RenderSVGImage::calculateAbsoluteBounds):
        (WebCore::RenderSVGImage::addFocusRingRects):
        * rendering/RenderSVGImage.h:
        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::paint):
        (WebCore::RenderSVGRoot::objectBoundingBox):
        (WebCore::RenderSVGRoot::repaintRectInLocalCoordinates):
        * rendering/RenderSVGRoot.h:
        * rendering/RenderSVGTSpan.h:
        (WebCore::RenderSVGTSpan::objectBoundingBox):
        (WebCore::RenderSVGTSpan::repaintRectInLocalCoordinates):
        * rendering/RenderSVGText.cpp:
        (WebCore::RenderSVGText::clippedOverflowRectForRepaint):
        (WebCore::RenderSVGText::absoluteRects):
        (WebCore::RenderSVGText::absoluteQuads):
        (WebCore::RenderSVGText::objectBoundingBox):
        (WebCore::RenderSVGText::repaintRectInLocalCoordinates):
        * rendering/RenderSVGText.h:
        * rendering/RenderSVGViewportContainer.cpp:
        (WebCore::RenderSVGViewportContainer::viewportTransform):
        * rendering/SVGRenderSupport.cpp:
        (WebCore::computeContainerBoundingBox):
        * rendering/SVGRenderSupport.h:
        * rendering/SVGRenderTreeAsText.cpp:
        (WebCore::operator<<):
        * svg/SVGFont.cpp:
        (WebCore::Font::drawTextUsingSVGFont):
        * svg/SVGLocatable.cpp:
        (WebCore::SVGLocatable::getBBox):
        * svg/SVGPatternElement.cpp:
        (WebCore::SVGPatternElement::buildPattern):
        * svg/graphics/SVGPaintServerGradient.cpp:
        (WebCore::createMaskAndSwapContextForTextGradient):
        (WebCore::clipToTextMask):
        (WebCore::SVGPaintServerGradient::setup):
        * svg/graphics/SVGPaintServerPattern.cpp:
        (WebCore::SVGPaintServerPattern::setup):

git-svn-id: svn://svn.chromium.org/blink/trunk@42578 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Adler.

        - fix <rdar://problem/6032139> Table cell widths calculated
          incorrectly on table that uses table-layout:fixed, colspans, and a mix
          of percentage and pixel widths

        Test: fast/table/fixed-granular-cols.html

        The incorrect widths resulted from incorrect handling of the case where
        the <col> elements are more granular than the table cells.

        * rendering/FixedTableLayout.cpp:
        (WebCore::FixedTableLayout::calcWidthArray): When processing <col>
        elements, append effective columns or split existing effective columns
        as needed.

LayoutTests:

        Reviewed by Darin Adler.

        - test for <rdar://problem/6032139> Table cell widths calculated
          incorrectly on table that uses table-layout:fixed, colspans, and a mix
          of percentage and pixel widths

        * fast/table/fixed-granular-cols.html: Added.
        * platform/mac/fast/table/fixed-granular-cols-expected.checksum: Added.
        * platform/mac/fast/table/fixed-granular-cols-expected.png: Added.
        * platform/mac/fast/table/fixed-granular-cols-expected.txt: Added.



git-svn-id: svn://svn.chromium.org/blink/trunk@42577 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        See Bug 25160: Various ecma/Date tests sometimes fail on Windows (but
        not Mac)
        <https://bugs.webkit.org/show_bug.cgi?id=25160>

        * Scripts/run-javascriptcore-tests: Skip ecma/Date/15.9.2.2-6.js.

git-svn-id: svn://svn.chromium.org/blink/trunk@42576 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reviewed by Gavin Barraclough.

If we can statically find a property we are trying to resolve
the base of, the base is guaranteed to be the global object.


git-svn-id: svn://svn.chromium.org/blink/trunk@42575 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reviewed by Gavin Barraclough

Implement cross scope optimisation for read-write-modify
operators, to avoid unnecessary calls to property resolve
helper functions.


git-svn-id: svn://svn.chromium.org/blink/trunk@42574 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reviewed by Gavin Barraclough

Make use of function entry cache for remaining Array enumeration functions.


git-svn-id: svn://svn.chromium.org/blink/trunk@42573 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        <rdar://problem/6795285> Infinite recursion in ResourceHandle::receivedRequestToContinueWithoutCredential

        Rolled out <http://trac.webkit.org/projects/webkit/changeset/42536> - the two instances of
        authentication challenge are different, after all. Added a FIXME comment about a possible
        future improvement.

        * platform/network/ResourceHandle.cpp:
        (WebCore::ResourceHandle::clearAuthentication):
        * platform/network/ResourceHandleInternal.h:
        (WebCore::ResourceHandleInternal::ResourceHandleInternal):
        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
        (WebCore::ResourceHandle::receivedCredential):
        (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):
        (WebCore::ResourceHandle::receivedCancellation):
        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
        (WebCore::ResourceHandle::didCancelAuthenticationChallenge):
        (WebCore::ResourceHandle::receivedCredential):
        (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):
        (WebCore::ResourceHandle::receivedCancellation):



git-svn-id: svn://svn.chromium.org/blink/trunk@42572 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reviewed by Gavin Barraclough.

Cache the VM entry for Array.sort when using a JS comparison function.


git-svn-id: svn://svn.chromium.org/blink/trunk@42571 bbb929c8-8fbe-4397-9dbb-9b2b20218538

<https://bugs.webkit.org/show_bug.cgi?id=25229>

Reviewed by Gavin Barraclough.

Implement Array.reduceRight


git-svn-id: svn://svn.chromium.org/blink/trunk@42570 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Sam Weinig.
        
        More fix for https://bugs.webkit.org/show_bug.cgi?id=21260
        Unbounded memory growth when churning elements with anonymous event handler functions

        Also fixed <rdar://problem/6792909> WebInspector crashes when reloading
        a page with breakpoints set
        
        * bindings/js/JSEventListener.cpp:
        (WebCore::JSEventListener::clearJSFunctionInline):
        (WebCore::JSEventListener::markJSFunction):
        * bindings/js/JSEventListener.h: Actually clear our function and global
        object pointers when our client instructs us to. (Oops!) Also, mark
        our global object while we still intend to use it.

        * bindings/js/JSSVGElementInstanceCustom.cpp:
        (WebCore::JSSVGElementInstance::mark):
        (WebCore::toJS):
        * bindings/scripts/CodeGeneratorJS.pm:
        * svg/SVGElementInstance.idl: For every SVGElementInstance wrapper, ensure
        that the corresponding element also has a wrapper, to keep its event
        listeners alive.



git-svn-id: svn://svn.chromium.org/blink/trunk@42569 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=25201
        Add ScriptFunctionCall/ScriptObject for V8.

        * bindings/v8/ScriptFunctionCall.cpp: Added.
        * bindings/v8/ScriptFunctionCall.h: Added.
        * bindings/v8/ScriptObject.cpp: Added.
        * bindings/v8/ScriptObject.h: Added.
        * bindings/v8/ScriptObjectQuarantine.cpp: Added.
        * bindings/v8/ScriptObjectQuarantine.h: Added.
        * bindings/v8/ScriptScope.cpp: Added.
        * bindings/v8/ScriptScope.h: Added.
        * bindings/v8/ScriptState.h:
        (WebCore::ScriptState::ScriptState): Added new constructors.
        (WebCore::ScriptState::frame): Added Frame ptr accessor.
        * bindings/v8/ScriptString.h:
        (WebCore::ScriptString::ScriptString): Added default constructor.
        * bindings/v8/ScriptValue.h:
        (WebCore::ScriptValue::isEqual): Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@42568 bbb929c8-8fbe-4397-9dbb-9b2b20218538

<https://bugs.webkit.org/show_bug.cgi?id=25227>

Reviewed by Gavin Barraclough.

We correct this simply by making the fast array path fall back on the slow path if
we ever discover the fast access is unsafe.


git-svn-id: svn://svn.chromium.org/blink/trunk@42567 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Unreviewed build fix. Add RenderSVGModelObject.* to GTK+'s build.

        * GNUmakefile.am:

git-svn-id: svn://svn.chromium.org/blink/trunk@42566 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        * DumpRenderTree/win/DumpRenderTree.cpp:
        (sharedCFURLCache):



git-svn-id: svn://svn.chromium.org/blink/trunk@42565 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        * DumpRenderTree/win/DumpRenderTree.cpp:
        (sharedCFURLCache):
        (main):



git-svn-id: svn://svn.chromium.org/blink/trunk@42564 bbb929c8-8fbe-4397-9dbb-9b2b20218538

<https://bugs.webkit.org/show_bug.cgi?id=25159>

Reviewed by Gavin Barraclough

Implement Array.prototype.reduce


git-svn-id: svn://svn.chromium.org/blink/trunk@42563 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        
Implement support for wxWebViewNewWindowEvent.
        
https://bugs.webkit.org/show_bug.cgi?id=19043


git-svn-id: svn://svn.chromium.org/blink/trunk@42562 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Add minimal RenderSVGModelObject and make RenderPath and RenderSVGContainer use it.
        https://bugs.webkit.org/show_bug.cgi?id=25221

        RenderSVGModelObject is the base rendering class for things which live
        in the SVG rendering tree.  Not all SVG renders are RenderSVGModelObjects yet.

        More patches coming.  This is just adding the class, future patches
        will pull more logic out of RenderPath and RenderSVGContainer into RenderSVGModelObject.

        * WebCore.pro:
        * WebCore.scons:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::RenderPath):
        * rendering/RenderPath.h:
        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::RenderSVGContainer):
        * rendering/RenderSVGContainer.h:
        * rendering/RenderSVGModelObject.cpp: Added.
        (WebCore::RenderSVGModelObject::RenderSVGModelObject):
        * rendering/RenderSVGModelObject.h: Added.
        (WebCore::RenderSVGModelObject::requiresLayer):
        * rendering/RenderTreeAsText.cpp:
        * rendering/SVGRenderTreeAsText.cpp:

git-svn-id: svn://svn.chromium.org/blink/trunk@42561 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fixed an expected result and added a test to the Skipped list while I investigate why its expected results didn't change.



git-svn-id: svn://svn.chromium.org/blink/trunk@42560 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Adam Roben.

        * platform/network/ResourceRequestBase.cpp:
        * platform/network/cf/ResourceRequestCFNet.cpp:
        (WebCore::initializeMaximumHTTPConnectionCountPerHost):



git-svn-id: svn://svn.chromium.org/blink/trunk@42559 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Changes needed for <rdar://problem/6785760>

        * win/include/WebKitSystemInterface/WebKitSystemInterface.h:
        * win/lib/WebKitSystemInterface.lib:
        * win/lib/WebKitSystemInterface_debug.lib:



git-svn-id: svn://svn.chromium.org/blink/trunk@42558 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Mark Rowe.

        Add special casing to bindings generator so that custom functions
        starting with xml or xslt conform to WebKit style guidelines.

        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::xmlHttpRequest):
        (WebCore::JSDOMWindow::xsltProcessor):
        * bindings/scripts/CodeGenerator.pm:



git-svn-id: svn://svn.chromium.org/blink/trunk@42557 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        See Bug 25160: Various ecma/Date tests sometimes fail on Windows (but
        not Mac)
        <https://bugs.webkit.org/show_bug.cgi?id=25160>

        * Scripts/run-javascriptcore-tests: Skip ecma/Date/15.9.2.2-2.js (who
        didn't see it coming?).

git-svn-id: svn://svn.chromium.org/blink/trunk@42556 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Remove more dead code from RenderSVGHiddenContainer.

        lineHeight and baselinePosition used to be on RenderSVGContainer
        (of which this is a subclass) because RenderSVGContainer used
        to be a RenderBox and always the renderer for <svg>
        Now <svg> uses RenderSVGRoot when needing a RenderBox (inside HTML)
        and RenderSVGViewportContainer (when inside SVG content)
        so there is no need for RenderSVGHiddenContainer to have these HTML-specific methods.

        * rendering/RenderSVGHiddenContainer.cpp:
        * rendering/RenderSVGHiddenContainer.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@42555 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Remove unneeded (broken) code from SVG renderers
        https://bugs.webkit.org/show_bug.cgi?id=25214

        Mostly due to my historical confusions about the render tree
        and some methods not being removed after classes were split.

        RenderSVGRoot is an RenderBox and should just use all the
        standard RenderBox methods for inspector and repaint rects.

        RenderSVGContainer is *not* a RenderBox (any more) and thus
        doesn't need lineHeight or width/height or calcBounds.

        RenderSVGViewportContainer had some broken code which tried
        to see if the click was inside the container at all, but it
        was using width/height metrics based off of the containing
        block (from calcWidth) which is wrong (since its real
        width/height are from its containing viewport not containing block).

        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::RenderSVGContainer):
        (WebCore::RenderSVGContainer::layout):
        * rendering/RenderSVGContainer.h:
        * rendering/RenderSVGRoot.cpp:
        * rendering/RenderSVGRoot.h:
        * rendering/RenderSVGViewportContainer.cpp:
        (WebCore::RenderSVGViewportContainer::layout):
        (WebCore::RenderSVGViewportContainer::nodeAtPoint):

git-svn-id: svn://svn.chromium.org/blink/trunk@42554 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Updated expected result for a text dragging test that pastes text on Windows but not on Mac (which is expected).



git-svn-id: svn://svn.chromium.org/blink/trunk@42553 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        https://bugs.webkit.org/show_bug.cgi?id=25217
        Simplify nearestViewportElement and farthestViewportElement using isViewportElement and a for loop
        Add ASSERT(element) to all these functions since they should never be passed a null element.

        * svg/SVGLocatable.cpp:
        (WebCore::isViewportElement):
        (WebCore::SVGLocatable::nearestViewportElement):
        (WebCore::SVGLocatable::farthestViewportElement):
        (WebCore::SVGLocatable::getBBox):
        (WebCore::SVGLocatable::getCTM):
        (WebCore::SVGLocatable::getScreenCTM):

git-svn-id: svn://svn.chromium.org/blink/trunk@42552 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Anders Carlsson.

        Remove support for the ObjCIvar extended attribute from the Objective-C
        bindings generator.  It is not used anymore.

        * bindings/scripts/CodeGeneratorObjC.pm:



git-svn-id: svn://svn.chromium.org/blink/trunk@42551 bbb929c8-8fbe-4397-9dbb-9b2b20218538