GitLab

When clicking a link that can either be handled by the browser, or by an
external app, in incognito mode we now automatically choose the browser,
to keep the user within incognito mode as much as possible. Links that
can only be handled externally (e.g., intent:// and other system
schemes) are unchanged (prompt the user, then send an external intent).

Added a test that an intent:// URL in incognito mode will still prompt.

BUG=587306

Review-Url: https://codereview.chromium.org/2350933005
Cr-Commit-Position: refs/heads/master@{#419984}

BytesConsumer::read is rarely used, and it can be implemented on top of
two-phase read functions. Removing it allows endRead to return
Result::Done, which simplifies BytesConsumer implementations.

This CL also fixes a bug in BytesConsumerTestUtil.

BUG=610195

Review-Url: https://codereview.chromium.org/2356693002
Cr-Commit-Position: refs/heads/master@{#419983}

1) Ignore zero-height fragments during margin collapsing step.
See https://www.w3.org/TR/CSS2/box.html#collapsing-margins
2) Change the order of expected/actual for all EXPECT_EQ in ng_block_layout_algorithm_test
3) Add more test expectations for the collapsing margin logic.

BUG=635619

Review-Url: https://codereview.chromium.org/2350603002
Cr-Commit-Position: refs/heads/master@{#419982}

draft-ietf-tokbind-protocol-10:
- The TokenBinding.signature now closes over the token binding type.
- Public key serialization is length prefixed to support parsing unknown key types.
draft-ietf-tokbind-negotiation-05:
- Require Renegotiation Indication
draft-ietf-tokbind-https-06:
- Sec-Token-Binding header base64 shouldn't include pad characters.
- Include-Referred-Token-Binding-ID header's value is case insensitive.

This also updates the tls and quic code to indicate support for draft version 10.

BUG=467312

Review-Url: https://codereview.chromium.org/2337253004
Cr-Commit-Position: refs/heads/master@{#419981}

We are about to launch ImeThread (targeting M54), and in case we fail to
launch, we should be able to disable the feature safely.

BUG=648482

Review-Url: https://codereview.chromium.org/2349973008
Cr-Commit-Position: refs/heads/master@{#419980}

This makes the code much more readable and complies with the Chromium
style guide.

Review-Url: https://codereview.chromium.org/2357793002
Cr-Commit-Position: refs/heads/master@{#419979}

TEST=paint/invalidation/caret-color.html
BUG=646176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2354023002
Cr-Commit-Position: refs/heads/master@{#419978}

Currently, the Yank command on Mac and the selection clipboard on Linux can
reveal the text of an obscured/password Views::Textfield. This CL modifies
Textfield::UpdateSelectionClipboard() to ensure that the selection clipboard is
not modified for a password textfield. Textfield::ExecuteTextEditCommand(..) is
also modified to only update the yank kill buffer for a non-password textfield.
Unit tests which demonstrate the problem are also added.

BUG=648511, 648509

Review-Url: https://codereview.chromium.org/2358463002
Cr-Commit-Position: refs/heads/master@{#419977}

BUG=644649

Review-Url: https://codereview.chromium.org/2348843002
Cr-Commit-Position: refs/heads/master@{#419976}

BUG=None
TEST=try

Review-Url: https://codereview.chromium.org/2356953003
Cr-Commit-Position: refs/heads/master@{#419975}

This is a fix after r419951

BUG=610176
TBR=dcheng@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2357833002
Cr-Commit-Position: refs/heads/master@{#419974}

This CL moves all RefCountedThreadSafeBase methods in //base/ref_counted.cc
to the header as inline functions for smaller binary.

RefCountedThreadSafe methods in ref_counted.cc are too small to have
non-inlined function. Inlining them to the caller reduces the stripped
binary size of Chromium on Linux by 84kB, since the binary size the
function body are even smaller than the binary size of the function
call itself.

Review-Url: https://codereview.chromium.org/2345013003
Cr-Commit-Position: refs/heads/master@{#419973}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/2c1c32b86fc93210cff0450d29df4b47055643af Add goma_dir getter to recipe_module goma (tikuta@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=621828

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2353083004
Cr-Commit-Position: refs/heads/master@{#419972}

WebMediaPlayerAndroid (WMPA) used the EstablishSurfacePeer construct and
the BrowserMediaPlayerManager to send a SurfaceTexture from the GPU
process to a MediaPlayer in the BrowserProcess.

MediaPlayerRender does not use a BrowserMediaPlayerManager, but needs a
way to receive surface textures from the GPU. This change introduces the
ScopedSurfaceRequestManager and the ScopedSurfaceRequestConduit.

The Manager allows the registration of a callback in the Browser
process, which can receive a ScopedJavaSurface. Upon registration,
the manager creates a token that can be used at a later time to
fulfill the request.
The Conduit forwards surface texture to the Manager, using the
issued token to route the ScopedJavaSurface to the right request.
From the GPU process, surfaces are sent via the ChildProcessServices
and the IChildProcessCallback, the same way that EstablishSurfacePeer
currently does. In single process mode, the Manager directly implements
the Conduit interface.

Security recommended 128 bits as the token size. It is represented by
base::Nonce class, which supports serialization accross IPC and Mojo,
and is easy to send as two uint64_t through JNI and AIDL.

The CL that covers the integration within StreamTexture and
MediaPlayerRenderer is tracked by the same bug, and can be
found at https://codereview.chromium.org/2282633002/.

Adding palmer@ as TBR, since he is the only owner for aidl files, but
is unavailable ATM.

TBR=palmer
BUG=627658
TEST=Added UTs, manually verified that it worked in the prototype.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2285593002
Cr-Commit-Position: refs/heads/master@{#419971}

Have the Omnibox security chip honor the new flags. The new flags
say whether to animate the security chip, or display it at all.
For desktops except Mac.

BUG=647347

Review-Url: https://codereview.chromium.org/2351003003
Cr-Commit-Position: refs/heads/master@{#419970}

Before this CL, {CSS,XSL}StyleSheetResource::checkNotify didn't trigger markClientFinished as Resource::checkNotify did.
This CL aligns {CSS,XSL}StyleSheetResource::checkNotify to trigger it properly.

BUG=647151

Review-Url: https://codereview.chromium.org/2353903002
Cr-Commit-Position: refs/heads/master@{#419969}

BUG=647219

Review-Url: https://codereview.chromium.org/2353893002
Cr-Commit-Position: refs/heads/master@{#419968}

As shown at 15 on [1], "The user agents are encouraged to show a warning that
the event listeners must be added on the very first evaluation of the worker
script.". This patch adds warning messages for the events.

[1]: https://w3c.github.io/ServiceWorker/spec/service_worker/index.html#run-service-worker-algorithm

BUG=594160

Review-Url: https://codereview.chromium.org/2319563003
Cr-Commit-Position: refs/heads/master@{#419967}

WebMouseWheelEvents were converted based on Shift getting set. This should
not happen. Instead swap the X&Y before we goto generate the scroll
gesture.

BUG=646109

Review-Url: https://codereview.chromium.org/2359463002
Cr-Commit-Position: refs/heads/master@{#419966}

R=tsergeant@chromium.org
BUG=598017
NOTRY=true

Review-Url: https://codereview.chromium.org/2355883003
Cr-Commit-Position: refs/heads/master@{#419965}

Cr-Commit-Position: refs/heads/master@{#419964}

This means we can more thoroughly audit changes as well as update only
individual elements as needed.

R=dpapad@chromium.org
TBR=michaelpg@chromium.org
BUG=none
NOTRY=true

Review-Url: https://codereview.chromium.org/2354783005
Cr-Commit-Position: refs/heads/master@{#419963}

BUG=640559
TBR=brettw

Review-Url: https://codereview.chromium.org/2351613006
Cr-Commit-Position: refs/heads/master@{#419962}

This change adds SSLStatus flags to |content_status| for when the page
is detected to contain password or credit card fields over HTTP. Nothing
yet sets these SSLStatus flags.

When the flags are set (and the command-line switch), SecurityStateModel
downgrades the security level to HTTP_WARNING.

This is based on top of https://codereview.chromium.org/2346063002/

BUG=647558

Review-Url: https://codereview.chromium.org/2350273002
Cr-Commit-Position: refs/heads/master@{#419961}

This allows Monochrome.apk's .pak files to properly contain the
union of Chrome and WebView's .pak files. It also allows it to use
a target-specific resource whitelist.

This change applies to resources.pak and chrome_100_percent.pak. A
change to language .pak files will come as a follow-up.

BUG=641032,634358
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2354803002
Cr-Commit-Position: refs/heads/master@{#419960}

Currently, selection changes immediately before beginBatchEdit() may be
merged into batch edit selection update which happens at endBatchEdit().

The reason is that it takes round-trip time to get update from previous
operation and if we increment mNumNestedBatchEdits in beginBatchEdit()
before the update from renderer process arrives at browser process,
then the update from operation will be ignored because
mNumNestedBatchEdits > 0.

This can be prevented if we keep the batch edit information in renderer
and tag it to each text input state update.

Note that mNumNestedBatchEdits should still be kept in
ThreadedInputConnection to return the correct value in endBatchEdit().

BUG=644574, 643473, 643477

Review-Url: https://codereview.chromium.org/2309983002
Cr-Commit-Position: refs/heads/master@{#419959}

https://chromium.googlesource.com/chromium/src/+/b195fcd2e

BUG=640256
TBR=malaykeshav@chromium.org

Review URL: https://codereview.chromium.org/2353543004 .

Cr-Commit-Position: refs/heads/master@{#419958}

BUG=555865

Review-Url: https://codereview.chromium.org/2353053002
Cr-Commit-Position: refs/heads/master@{#419957}

This CL adds arrow-key navigation to the main history list and makes a
single history item tab-navigable by using cr.ui.FocusRow and
iron-list's tab index property.

BUG=623011
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2334553002
Cr-Commit-Position: refs/heads/master@{#419956}

De-virtualize ExtensionFunction::SendResponse() and contain all work in
a single SendResponseImpl()* method, which is private to
ExtensionFunction and can only be invoked through the Respond() methods.
This is a first step in isolating results_, error_, and the response
invocation in order to ensure consistent and clear results from
functions.

Update UIThreadExtensionFunction implementations that used SendResponse()
rather than Respond().

For compatibility, introduce SendResponse() methods on legacy
ExtensionFunction classes (ChromeUIThreadExtensionFunction and
AsyncExtensionFunction) which wrap around Respond(). As functions are
converted, this wrapper will go away.

Also remove the unused ExtensionFunction::OnRespondingLater().

*SendResponseImpl() instead of SendResponse() so that we don't have to
rename existing calls in legacy functions.

BUG=648275

Review-Url: https://codereview.chromium.org/2351823004
Cr-Commit-Position: refs/heads/master@{#419955}

Sticky position is a layout offset and should not be affected by transforms.

BUG=648683
TEST=LayoutBoxModelObjectTest.StickyPositionTransforms

Review-Url: https://codereview.chromium.org/2346383005
Cr-Commit-Position: refs/heads/master@{#419954}

Allows easy searching on the chrome://flags page.

BUG=647529

Review-Url: https://codereview.chromium.org/2335343010
Cr-Commit-Position: refs/heads/master@{#419953}

BUG=647371

Review-Url: https://codereview.chromium.org/2357023002
Cr-Commit-Position: refs/heads/master@{#419952}

This CL clears LifecycleObserver::m_context when LifecycleObserver::contextDestroyed gets called.
This means that LifecycleObserver::context() starts returning false after the context gets destroyed.

The new behavior makes a lot of more sense, but the problem is that some existing code is assuming that
LifecycleObserver::context() keeps returning the context even after the context gets destroyed.
This CL fixed the problematic code to make all layout tests pass, but I'm not sure if I've updated all of the problematic code
(because the coverage of the layout tests is not sufficient).
However, the worst thing that can happen is that code that had been assuming that LifecycleObserver::context()
returns a context even after the context gets destroyed will stop working (it may cause a null-deref crash).
I think the risk is low.

BUG=610176

Review-Url: https://codereview.chromium.org/2317483005
Cr-Commit-Position: refs/heads/master@{#419951}

This will allow us to use it for the computed CSSStylePropertyMap for CSS Typed OM.

BUG=545318

Review-Url: https://codereview.chromium.org/2349633002
Cr-Commit-Position: refs/heads/master@{#419950}

This CL prevents creating WebAPKs via the add-to-homescreen menu item:
- If the Web Manifest does not contain any icons
- If any URL in the Web Manifest contains a username and password

This makes the logic in add_to_homescreen_data_fetcher.cc match the logic in
app_banner_manager_android.cc

BUG=648491
TEST=None

Review-Url: https://codereview.chromium.org/2349263003
Cr-Commit-Position: refs/heads/master@{#419949}

This has been useful in my debugging, and could be useful to authors as well.

BUG=148757

Review-Url: https://codereview.chromium.org/2354873006
Cr-Commit-Position: refs/heads/master@{#419948}

SetCursor can crash in rare circumstances when no event has been
processed yet, but SetCursor is called by the client.
Adds line to initialize the cursor widget if it does not exist.

BUG=chromium:648724
TEST=none

Review-Url: https://codereview.chromium.org/2355953003
Cr-Commit-Position: refs/heads/master@{#419947}

This patch builds on [1] and adds position: sticky main thread scrolling
reasons to the blink and cc scroll property trees. Position: sticky
disables threaded scrolling because the compositor is not yet
able to update these.

Incremental updates are not yet possible but TODOs and tests have been
updated to ensure the main thread scroll reasons are recomputed.

[1] https://crrev.com/6da0810c8c2362fc73d911750400ccd5c33cd6ca
BUG=644514
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2353843002
Cr-Commit-Position: refs/heads/master@{#419946}

Updates Plugins => Flash in Options Content Settings.

Also updates the radio button text as:

HBD On
  Allow sites to run Flash
  Ask first before allowing sites to run Flash (recommended)
  Block sites from running Flash

HBD Off
  Allow sites to run Flash
  Detect and run only important Flash content (recommended)
  Block sites from running Flash

UI Approved. See bug.

BUG=622922
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2296073002
Cr-Commit-Position: refs/heads/master@{#419945}