- 30 Oct, 2020 40 commits
-
-
Paul Moy authored
Extend the existing CpuInfo mojom struct to include labels and temperature readings from the device's temperature channels. This provides another avenue for retrieving this data, separate from the Chrome APIs. The goal is not to remove the Chrome APIs, but rather provide an easier, unified way of getting this data for clients already using cros_healthd. Those clients now only need to integrate with one component as opposed to both cros_healthd and the Chrome APIs. Bug: chromium:1131602 Change-Id: Id531b2bab4b72ef60f272d21f4e92e0d321c44bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506451Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Paul Moy <pmoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#822516}
-
David Black authored
Contents are derived from the image for the associated holding space item. We crop and resize the holding space item's image as necessary to properly fit our icon item. Screenshot: https://screenshot.googleplex.com/uDkubRhHiiF6x9z Bug: 1142572 Change-Id: Iac13dbb71499d44657fe20da25759054e7cb6ba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508130 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#822515}
-
Sammie Quon authored
The crash reports say that the starting desk screenshot is not taken when ending a gesture. This CL adds handling for that case, along with handling for case if the ending desk screenshot is not taken. If the starting desk screenshot has not been taken yet, the user does not see the screenshot. This means from the user's point of view, they still only see the starting desk. In this case, we can just end the animation without animating, and make sure the delegate will activate the starting desk again. Test: manual & added test Bug: 1134390 Change-Id: I3ff2f5a04f46bea9fb4e6403a969b67afb972d65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506356 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#822514}
-
Kent Tamura authored
* Update the bug number for first-line-and-placeholder * mouse-relative-position.html is passing TBR=kojii@chromium.org Bug: 1040826, 1143621 Change-Id: Ic70f8b155c6b1686f677a9cf2492d2d0fdac1300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507323 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#822513}
-
Andrew Grieve authored
It was not handling secondary toolchains properly. Bug: 1122182 Change-Id: I9634b5cbc67efc53f8946fbc1084d3a8a9427cb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503570 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#822512}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a653a9badb55..646cf5b2dabd 2020-10-30 ynovikov@chromium.org Skip EXTMultisampleCompatibilityTest.DrawAndResolve on Mac Mini 8.1 2020-10-30 ynovikov@chromium.org Suppress 2 DepthStencilFormatsTest.DepthStencilReadback on MacMini8.1 2020-10-30 ynovikov@chromium.org Skip ReadPixelsTextureTest.*LayerAttachment*PBO on Mac Mini 8.1 2020-10-30 ynovikov@chromium.org Skip WebGLCompatibilityTest.EnablePixelBufferObjectExtensions 2020-10-30 dpranke@google.com Make sure commit position is a string. 2020-10-29 timvp@google.com Vulkan: Make DescriptorPoolHelper a Resource 2020-10-29 ynovikov@chromium.org Skip Instanced MultiDrawTest.MultiDrawArrays on Mac Mini 8.1 2020-10-29 jmadill@chromium.org Gold Tests: Include SHA1 files in trace inputs. 2020-10-29 m.maiya@samsung.com Vulkan: Add OES_shader_image_atomic support 2020-10-29 timvp@google.com Disable libcxx_abi_unstable in roll_aosp.sh 2020-10-29 jmadill@chromium.org Add newline when using OutputDebugStringA logging. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1112471,chromium:1143507 Tbr: geofflang@google.com Test: Test: Build on AOSP and launch CuttlefishTest: Test: VulkanMultithreadingTest::MultiContextDrawSmallDescriptorPools() Change-Id: Ieb90beb13889046bb4accb193429bfafa88bd2ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508419Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822511}
-
John Palmer authored
basically crrev.com/c/2483719 but with a private API instead. BUG=1138092, 1111135 Change-Id: Ifd651c3ba491cba738b48cd9ebe35b926c60bf51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501106 Commit-Queue: John Palmer <jopalmer@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#822510}
-
David Black authored
Holding space item count histograms were WAI except for the fact that they failed to record the *absence* of holding space items. Bug: 1131266 Change-Id: Id2fc9ce08c4e8f3537b1861878353afde083e257 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507337Reviewed-by:
-
Yulun Wu authored
Bug: 1131573 Change-Id: Idec1dc25f75ddbeb38bde8ecda816a1d7bdd614a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473677Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Auto-Submit: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#822508}
-
Klaus Weidner authored
This extends the WebXR API to add an "image-tracking" feature. The application supplies an array of image bitmaps in requestSession, and the system then reports world poses for these images if they are detected by the tracking camera. Discussions about the API shape are still ongoing, this code is based on a draft explainer: https://github.com/klausw/webxr-image-tracking/blob/main/explainer.md Bug: 1143447 Change-Id: I28163b59c000e5acfb67c6773d5c35c17bfc34d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270816Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#822507}
-
David Tseng authored
Strategy: - manually edit the Eslinter rule: third_party/node/node_modules/eslint/lib/rules/eqeqeq.js to allow for auto fixing; this was intentionally disabled upstream. - run tools/web_dev_style/eslint.py --fix and git cl format --js on the directory Test: assumed automated test coverage Change-Id: Iaa360dce02ae72967ab73cbd86ce7d6b7c9bb592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504093Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#822506}
-
Peter Kvitek authored
Also split headless_protocol_browsertest.cc exractng compositor related tests to headless_compositor_browsertest.cc Also implemented a way to pass parameters from C++ test harness down to the JS test body. Change-Id: Ia0505b9e846f5d202a180c6bb4f67004a453bff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490210 Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#822505}
-
Gavin Williams authored
This change uses the existing |title| parameter to set the title when creating select dialogs. If the |title| is left empty, get the title based on the select dialog type. Screenshot: http://screen/3MwL5RSCHVhVXN6 Bug: 1143994 Change-Id: I5b653f892e3e295180692ffa89428cc2472aa9ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508671 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#822504}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Iec430597f241b6859632c4e6fd47a8d71a702d61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508347Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822503}
-
Eugene Zemtsov authored
Bug: 1132057 Change-Id: Ie30034adb37fa9d105c98be78f01143da4608469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504736 Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#822502}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/af5f5d291abd..85b44b21edd6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC johannkoenig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1135551 Tbr: johannkoenig@google.com Change-Id: Id7139fe36cd68f9e2272c943226a94dcfc05b27e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509011Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822501}
-
Jérémie Boulic authored
Change to be consistent with the other build files and targets. Bug: 1133186 Change-Id: Ic1c6526fd330d1da284239ab77c7e85487f82202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507238Reviewed-by:
-
Xiyuan Xia authored
This reverts commit 197fd0a5. Reason for revert: Crash in OnFadeOutAnimationEnded when it runs with no | fade_out_animation_tracker_| instance. Original change's description: > Replace AnimationMetricsReporter in ShelfView > > ui::AnimationMetricsReporter is deprecating. Replace it with > ui::AnimationThroughputReporter for simple layer animations and > ui::ThroughputTracker for complicated ones. > > Bug: 11434673 > Change-Id: I96425e7626929f9d6381828c81dbe08dd58168e9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508793 > Reviewed-by: Andrew Xu <andrewxu@chromium.org> > Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#822425} TBR=xiyuan@chromium.org,andrewxu@chromium.org Change-Id: Ib675aac6a9a57a7603529827069fd316ae7166be No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 11434673 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508958Reviewed-by:
-
Minoru Chikamune authored
Previously, AssociatedInterfaceProvider was using per-thread task runners implicitly. This CL specifies per-Agent task runners. Bug: 1105403 Change-Id: I14adef7939c48916e1d239482dbeaa19e03e8c9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505258Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
Zach Trudo authored
RealtimeReportingJobConfiguration has several elements that need to be reusable. This refactor creates a ReportingJobConfigurationBase that extracts those elements and places them in a reusable base. Bug: chromium:1078512 Change-Id: I7b18f0d68abed0a12a38d553103450943a1c4c72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476584 Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#822497}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 66406229. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I76ac9bf91883f3c64ad33f526cef5db27118cb88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508280Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822496}
-
Austin Eng authored
Makes the following changes: - Adds the scoped fast call and deferred warning/logging mechanism to drawArrays and drawElements. This was previously missing - Removes [NoAllocDirectCall] from bindBuffer and bindTexture. These functions always produce the GL error "attempt to use deleted object". There is likely an issue with passing interface objects types with the FastCall API. - Inlines the definitions of the fast call wrapping bindings since they are small and we don't want extra jmp instructions in the hot path. Bug: 1101475 Change-Id: Ie5db3454a84ba6ec15f52383e1e518f3ffd811af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506518 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#822495}
-
Fergal Daly authored
The flag was on by default but was conditional on RenderDocument for crashed frames which was off by default, so I think I just missed updating these tests. Change-Id: Ia52595baaba1f7ae7aea21d47d9e103b392b73b0 Bug: 1072817 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491577 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/master@{#822494}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1603994501-4884bfb055ee21b78f8aa718ebee6855f0191a85.profdata to chrome-mac-master-1604015897-a1b8341d837100918c78553c7c6bd57ce99f9313.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2d27a1263723fc3a00782ff52d1117c92776bd90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508418Reviewed-by:
-
Andrey Kosyakov authored
Originally broken by https://chromium-review.googlesource.com/c/chromium/src/+/2422820 due to an unconditional dependency on //components/pwg_encoder which asserts enable_print_preview. Bug: 809738 Change-Id: I205c82a4dde46372b22dfa5e6d49b6c6022c0010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508876Reviewed-by:
Alan Screen <awscreen@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#822492}
-
Yu Su authored
Currently Cronet disables 0-RTT features for all POST requests, as they are not considered idempotent. But for Youtube /videoplayback request, we are POSTing client abr state information. We want to create an option in Cronet UrlRequestParams to specify enabling 0-RTT when creating idempotent requests. This cl only makes it available for iOS. Enabling 0-RTT for idempotent request in Android interface will be implemented in the next cl, since it requires a different env. Change-Id: Ib2c5184b37e0ebe795c3f99dd0250a0638decaf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508299Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Yu Su <yuyansu@google.com> Cr-Commit-Position: refs/heads/master@{#822491}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603994501-28d36cf57d6466dbb811553e28b04bff48def90b.profdata to chrome-linux-master-1604015897-cbf2d5639eb5b5579fe2658cc59cbce3c1075df1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3339b01f5e597367dd5f4086eeb2ec84f8779843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509010Reviewed-by:
-
Nico Weber authored
This reverts commit e977adb7. Reason for revert: Makes msan bot fail, see test failures on https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/26020 Original change's description: > PolicyService: Notify when policies from all providers are loaded > > Add a new PolicyService::Observer::OnFirstPoliciesLoaded function to > listen to first policies loaded on a policy domain. This allows > observers to be notified when all policies are loaded. This allows > services that rely on policies to wait for eventual cloud policies > before starting. This can take sometime if the cloud policies do not > have a local cache and need to fetch their policies over the network. > > Bug: 1129065 > Change-Id: I5b50b0b6a1737c818ea2277d905a64151f45c95e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409132 > Reviewed-by: Owen Min <zmin@chromium.org> > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Yann Dago <ydago@chromium.org> > Cr-Commit-Position: refs/heads/master@{#822342} TBR=treib@chromium.org,zmin@chromium.org,poromov@chromium.org,ydago@chromium.org Change-Id: Ia63dd6f80e46ebe225da48d1e0964a63401c85d5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1129065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508539Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#822489}
-
Minggang Wang authored
Currently, RequestExtraData and its base class blink::WebURLRequest::ExtraData are used to store extra data on every ResourceRequest. Because the RequestExtraData doesn't depend on content/ classes anymore, we could move it into blink as part of the Onion Soup work. This patch merges these two classes into one and move it to third_party/blink/public/platform/, thus we could use it in blink directly. Bug: 1110176 Change-Id: I8fe35ec020bfbb8040fc3d5d991abf2bf1658662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494662 Commit-Queue: Minggang Wang <minggang.wang@intel.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#822488}
-
Jiawei Li authored
This CL adds |public|, |mesage_port_fuchsia|, and |message_port_cast| to be used for specifying a implementation for platform agnostic testing. Bug: Internal b/168598365 Test: bindings_manager_cast_browwsertest, named_message_port_connector_fuchsia_browsertest Change-Id: I4abfbb6a5bcfc19dbddb7634543a72f5bd288fdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489024 Commit-Queue: Jiawei Li <lijiawei@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#822487}
-
Brian Sheedy authored
Fixes how //content/test/gpu runs PyLint during presubmit. Previously, it relied on lint_unittest.py to be picked up when running all the other tests in //content/test/gpu/gpu_tests, which has the downside of making PyLint not cover other directories in //content/test/gpu. Instead, we now use the canned check that pretty much all of Chromium uses. Also fixes all the PyLint issues that were found as a result of this switch. Bug: 1133587 Change-Id: Idd7ce9f5aad3e1d02c8d7dbcbd7eeb131fdff725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508952 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#822486}
-
Jérémie Boulic authored
Modules in base/js on which the Audio Player depends. mock_chrome.js and test_error_reporting.js are used by unittests that need to be converted. Bug: 1133186 Change-Id: Id580a741b03971474dd31b9fe9fe30c3ce5895cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507300Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/2d61ff8f6c11..415d1ec806bb 2020-10-29 tsepez@chromium.org Bring CmykEncode() into conformance with ArgbEncode() 2020-10-28 tsepez@chromium.org Avoid multiplying by 0x010101 for RGB value computation 2020-10-28 tsepez@chromium.org Provide better logging from CJS_PublicMethods's AlertIfPossible(). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I54064ff463ddb8f0e91a67c29e8f106452f63e2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508812Reviewed-by:
-
Vincent Boisselle authored
Bug: 1137913 Bug: 1143765 Change-Id: I41812e7c6f37e2267adeadbe8999eaed6bf4deb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468499Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Vincent Boisselle <vincb@google.com> Cr-Commit-Position: refs/heads/master@{#822483}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ic6ea2ad32ac53dafc9548cd9fd17b3d707b7590c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508811Reviewed-by:
-
Andrew Grieve authored
This reverts commit f9c1525d. Reason for reland: R8 updated to non-broken (hopefully) version Original change's description: > Revert "Android: Enable vertical class merging in R8" > > This reverts commit 69a6e031. > > Reason for revert: Producing bad dex (crbug.com/1122436) > > Original change's description: > > Android: Enable vertical class merging in R8 > > > > Bug: 1040534 > > Change-Id: Ic9873612462612e510b91d713c24c046e017cafb > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368510 > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Reviewed-by: Sam Maier <smaier@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#801359} > > TBR=agrieve@chromium.org,smaier@chromium.org > Bug: 1040534, 1122436 > > Change-Id: Ib4e204210ddcb0c41cb5ba9cdedca69036064fc6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380081 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802321} Bug: 1040534 Bug: 1122436 Change-Id: I2189b0c1bf9519a4732c600184ee61db09c251a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473585 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#822481}
-
Moe Ahmadi authored
Title alignment of NTP MV tiles was broken by crrev.com/2472957 which allows Repeatable Query tiles to utilize two lines of text if needed. before: screenshot/5BzjQ9YKvB9dBkX after: screenshot/B2QiRb5WAZtiaHb Fixed: 1143490, 1141748 Change-Id: I54ff08e837505b63af93061c4568f8493b4c14ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508857 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#822480}
-
Leo Zhang authored
Simplify the UIL/IME service dev/testing. TEST=simple chrome BUG=b/171846787 Change-Id: Ibeef37bc89b848cffd5a4a08d5619d41a5c35b33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507236Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#822479}
-
dpapad authored
This is in preparation of removing <include src="assert.js"> and flattenhtml="true" from js/util.js and js/cr/ui/array_data_model.js, which in turn is necessary to auto-generate grd entries for ui/webui/resources/js/. Bug: 1143194 Change-Id: Icd92d1763a10b287078b44a62b20d112914aaa2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507294 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#822478}
-
Jeffrey Young authored
Multi profile tests were previously passing because second user had ambient mode pref turned off. Set up test case better so that non-primary users are blocked from ambient mode during test. Move test_ambient_client to //ash/ambient/test BUG=none TEST=ash_unittests --gtest_filter=AmbientControllerTest* Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: Iee0766e036833e47b10294b7c60be28a89ffc631 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506068Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
-
