GitLab

Serialization of page state can be a cpu intensive process as the serializer
must recursively traverse a tree of iframes. One of the common cases for
serializing navigation entries is Sync, which does not actually use the
encoded page state information.

This CL adds a new SerializationOptions param and support for using it to
exclude the page state when serializing a NavigationEntry, allowing Sync's
tab delegate to bypass encoding the page state.

Bug: 738187
Change-Id: Ib758db83e3f688c7016044e16a9f2818062e1da0
Reviewed-on: https://chromium-review.googlesource.com/560696
Commit-Queue: Nicolas Zea <zea@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486125}

Bug: chromium:689306
Change-Id: I84dafbb5f54c90615f2422a59a1cd14f10394b34
Reviewed-on: https://chromium-review.googlesource.com/568844
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486124}

GeolocationConfig is designed to be used from the chrome/browser.
For now the only method is IsHighAccuracyLocationBeingCaptured, that
indicates if the location is captured with high_accuracy=enabled flag.

BUG=731758

Review-Url: https://codereview.chromium.org/2975683002
Cr-Commit-Position: refs/heads/master@{#486123}

BUG=NONE

Review-Url: https://codereview.chromium.org/2974393002
Cr-Commit-Position: refs/heads/master@{#486122}

Revert of Block redirects to renderer-debug urls. (patchset #11 id:420001 of https://codereview.chromium.org/2973433003/ )

Reason for revert:
Compile error.

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20%28dbg%29/builds/89468

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chromiumos%2FLinux_ChromiumOS_Builder__dbg_%2F89468%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout

FAILED: obj/content/test/content_browsertests/navigation_handle_impl_browsertest.o
/b/c/goma_client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/content/test/content_browsertests/navigation_handle_impl_browsertest.o.d -DHAS_OUT_OF_PROC_TEST_RUNNER -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_ASH=1 -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=\"307486-1\" -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DCOMPONENT_BUILD -DOS_CHROMEOS -D_DEBUG -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_GLIBCXX_DEBUG=1 -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_32 -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_26 -DGL_GLEXT_PROTOTYPES -DUSE_GLX -DUSE_EGL -DGTEST_API_= -DGTEST_HAS_POSIX_RE=0 -DGTEST_LANG_CXX11=1 -DTOOLKIT_VIEWS=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=uint16_t -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_HAS_PNG_LIBRARY -DSK_HAS_WEBP_LIBRARY -DSK_HAS_JPEG_LIBRARY -DSKIA_DLL -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_SUPPORT_GPU=1 -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DPROTOBUF_USE_DLLS -DBORINGSSL_SHARED_LIBRARY -DUSING_V8_SHARED -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -DWTF_USE_WEBAUDIO_FFMPEG=1 -DWTF_USE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSING_V8_SHARED -DUNIT_TEST -DLEVELDB_PLATFORM_CHROMIUM=1 -I../.. -Igen -I../../build/linux/debian_jessie_amd64-sysroot/usr/include/glib-2.0 -I../../build/linux/debian_jessie_amd64-sysroot/usr/lib/x86_64-linux-gnu/glib-2.0/include -I../../third_party/libwebp/src -I../../third_party/khronos -I../../gpu -I../../third_party/googletest/src/googletest/include -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/encode -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/third_party/vulkan -I../../third_party/skia/include/gpu -I../../third_party/skia/src/gpu -I../../third_party/skia/src/sksl -I../../third_party/mesa/src/include -I../../third_party/libwebm/source -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/protobuf/src -I../../third_party/boringssl/src/include -I../../build/linux/debian_jessie_amd64-sysroot/usr/include/nss -I../../build/linux/debian_jessie_amd64-sysroot/usr/include/nspr -Igen -I../../third_party/WebKit -Igen/third_party/WebKit -I../../v8/include -Igen/v8/include -I../../third_party/WebKit/Source -I../../third_party/WebKit -Igen/blink -Igen/third_party/WebKit -I../../third_party/libjpeg_turbo -I../../third_party/iccjpeg -I../../third_party/libpng -I../../third_party/zlib -I../../third_party/ots/include -I../../v8/include -Igen/v8/include -I../../third_party/googletest/custom -I../../third_party/googletest/src/googlemock/include -I../../third_party/leveldatabase -I../../third_party/leveldatabase/src -I../../third_party/leveldatabase/src/include -I../../build/linux/debian_jessie_amd64-sysroot/usr/include/dbus-1.0 -I../../build/linux/debian_jessie_amd64-sysroot/usr/lib/x86_64-linux-gnu/dbus-1.0/include -fno-strict-aliasing -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -pthread -fcolor-diagnostics -fdebug-prefix-map=/b/c/b/linux_chromeos/src=. -m64 -march=x86-64 -Wall -Werror -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -O0 -fno-omit-frame-pointer -g2 -gsplit-dwarf --sysroot=../../build/linux/debian_jessie_amd64-sysroot -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-auto-raw-pointer -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wno-header-guard -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libBlinkGCPlugin.so -Xclang -add-plugin -Xclang blink-gc-plugin -Xclang -plugin-arg-blink-gc-plugin -Xclang use-chromium-style-naming -Wno-undefined-bool-conversion -Wno-tautological-undefined-compare -std=gnu++11 -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -c ../../content/browser/frame_host/navigation_handle_impl_browsertest.cc -o obj/content/test/content_browsertests/navigation_handle_impl_browsertest.o
../../content/browser/frame_host/navigation_handle_impl_browsertest.cc:1562:23: error: chosen constructor is explicit in copy-initialization
    std::vector<GURL> redirected_navigation = {};
                      ^                       ~~
../../build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/debug/vector:79:7: note: explicit constructor declared here
      vector(const _Allocator& __a = _Allocator())
      ^
../../content/browser/frame_host/navigation_handle_impl_browsertest.cc:1565:5: error: no type named 'Compare' in the global namespace
    EXPECT_EQ(redirected_navigation, logger.redirected_navigation_urls());
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../third_party/googletest/src/googletest/include/gtest/gtest.h:1924:63: note: expanded from macro 'EXPECT_EQ'
                      EqHelper<GTEST_IS_NULL_LITERAL_(val1)>::Compare, \
                                                            ~~^
../../third_party/googletest/src/googletest/include/gtest/gtest_pred_impl.h:162:23: note: expanded from macro 'EXPECT_PRED_FORMAT2'
  GTEST_PRED_FORMAT2_(pred_format, v1, v2, GTEST_NONFATAL_FAILURE_)
                      ^~~~~~~~~~~
../../third_party/googletest/src/googletest/include/gtest/gtest_pred_impl.h:147:17: note: expanded from macro 'GTEST_PRED_FORMAT2_'
  GTEST_ASSERT_(pred_format(#v1, #v2, v1, v2), \
                ^~~~~~~~~~~
../../third_party/googletest/src/googletest/include/gtest/gtest_pred_impl.h:77:52: note: expanded from macro 'GTEST_ASSERT_'
  if (const ::testing::AssertionResult gtest_ar = (expression)) \
                                                   ^~~~~~~~~~
../../content/browser/frame_host/navigation_handle_impl_browsertest.cc:1565:5: error: expected ')'
../../third_party/googletest/src/googletest/include/gtest/gtest.h:1923:3: note: expanded from macro 'EXPECT_EQ'
  EXPECT_PRED_FORMAT2(::testing::internal:: \
  ^
../../third_party/googletest/src/googletest/include/gtest/gtest_pred_impl.h:162:3: note: expanded from macro 'EXPECT_PRED_FORMAT2'
  GTEST_PRED_FORMAT2_(pred_format, v1, v2, GTEST_NONFATAL_FAILURE_)
  ^
../../third_party/googletest/src/googletest/include/gtest/gtest_pred_impl.h:147:29: note: expanded from macro 'GTEST_PRED_FORMAT2_'
  GTEST_ASSERT_(pred_format(#v1, #v2, v1, v2), \
                            ^
<scratch space>:36:1: note: expanded from here
"redirected_navigation"
^
../../content/browser/frame_host/navigation_handle_impl_browsertest.cc:1565:5: note: to match this '('
../../third_party/googletest/src/googletest/include/gtest/gtest.h:1923:3: note: expanded from macro 'EXPECT_EQ'
  EXPECT_PRED_FORMAT2(::testing::internal:: \
  ^
../../third_party/googletest/src/googletest/include/gtest/gtest_pred_impl.h:162:3: note: expanded from macro 'EXPECT_PRED_FORMAT2'
  GTEST_PRED_FORMAT2_(pred_format, v1, v2, GTEST_NONFATAL_FAILURE_)
  ^
../../third_party/googletest/src/googletest/include/gtest/gtest_pred_impl.h:147:28: note: expanded from macro 'GTEST_PRED_FORMAT2_'
  GTEST_ASSERT_(pred_format(#v1, #v2, v1, v2), \
                           ^
3 errors generated.

Original issue's description:
> Block redirects to renderer-debug urls.
>
> Redirects toward renderer-debug urls (chrome://crash, javascript:[...],
> ...) were not expected to happen in the NavigationHandleImpl. It caused
> WebContentsObserver::DidFinishNavigation not being called and
> consequently, bugs in some WebContentsObservers.
>
> This CL blocks any redirects to renderer-debug urls. One test is added.
>
> The blocking of the URL was moved (and partially removed?) in:
> https://crrev.com/2436253002
> This CL tries to restore the previous behavior.
>
> BUG=728398
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.linux:linux_chromium_browser_side_navigation_rel
>
> Review-Url: https://codereview.chromium.org/2973433003
> Cr-Commit-Position: refs/heads/master@{#486091}
> Committed: https://chromium.googlesource.com/chromium/src/+/b980b4b5d4408bea7e83cbf1f70e7143edb41716

TBR=clamy@chromium.org,mmenke@chromium.org,creis@chromium.org,mkwst@chromium.org,csharrison@chromium.org,arthursonzogni@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=728398

Review-Url: https://codereview.chromium.org/2982623002
Cr-Commit-Position: refs/heads/master@{#486121}

This tracks the time from when UI is shown to user after sign in to
when the user activates first ARC app.

TEST=Manually on device
BUG=b/63276467

For minor changes in c/b/ui/app_list/
TBR=xiyuan@chromium.org

Change-Id: If77dbcba01e0d17dd702887c22e60706f7311928
Reviewed-on: https://chromium-review.googlesource.com/563479
Commit-Queue: Yury Khmel <khmel@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486120}

Mac's "Open in Preview" is treated as a local printer in the C++
handler. Always treat it as a local printer in print_preview.js as well
so that the "print" promise resolution correctly closes the dialog and
prompts Preview to open.

BUG=741341,741528

Change-Id: I831df003019274edecf73172ef1e06bd6ebc960e
Reviewed-on: https://chromium-review.googlesource.com/568239Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486119}

BUG=727616

Change-Id: I0d8843c34d82a99ef815cab090b0c08ff7065c7c
Reviewed-on: https://chromium-review.googlesource.com/564180Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486118}

HQP currently shares a FormatUrl call between the match.fill_into_edit
and match.contents calls.

This is no longer appropriate given that the path may be elided. Per
discussions with pkasting, none of the destructive elisions should
be applied to the match.fill_into_edit fields.

Bug: 732582
Change-Id: I91b1181edaa2d3b9f150a9313951bf6ff59103a4
Reviewed-on: https://chromium-review.googlesource.com/567236Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486117}

This is a reland of 7fa78bb0
Original change's description:
> Add memory UKMs for existing UMA metrics.
> 
> Bug: 730783, 728707
> Change-Id: I744c73d36ca76d97eff1e202fa20ba5d4a9adb7b
> Reviewed-on: https://chromium-review.googlesource.com/531804
> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
> Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> Reviewed-by: Erik Chen <erikchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#485159}

Bug: 730783, 728707
Change-Id: I314ecfa620bbd317e2cd4164279eb86a2248bbfb
Reviewed-on: https://chromium-review.googlesource.com/567220Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486116}

This is an old hack to preserve behavior of certain tests. These tests
have since been fixed to not rely on this. Get rid of it and just call
UpdateAnimationsAndScheduleFrameIfNeeded(...) instead to schedule the
first frame just like any other.

BUG=726362

Change-Id: I1ff2673a8d4b71ea237a2902f10599e08bcfb7d6
Reviewed-on: https://chromium-review.googlesource.com/564608Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#486115}

This also changes the timing with which startup metrics are recorded: Previously they were recorded ~45 seconds after startup; now they're recorded whenever the TaskScheduler schedules them to be.  This is not expected to change the values recorded to these metrics.

BUG=667892, 741816
TEST=none
R=asvitkine@chromium.org

Review-Url: https://codereview.chromium.org/2955063005
Cr-Commit-Position: refs/heads/master@{#486114}

In our current implementation, the histogram timer in the above function
doesn't account for the time that spends on decoding the source image.
That part of time can be significant for some image sources like SVG.

This CL fixes the timer to include the image source decoding time.

Bug: None
Change-Id: Ic7a09ed1ec5524870d2bb64d4cd01dbfd05a7dac
Reviewed-on: https://chromium-review.googlesource.com/563778Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486113}

Some try bots have been timed out on this test. Reduced the thread
count to avoid such failure. (2500 -> 1000)

Bug: 741699
Change-Id: Iec63bd67c991d43932803b734826d6d385e5cc03
Reviewed-on: https://chromium-review.googlesource.com/568586Reviewed-by: Raymond Toy <rtoy@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486112}

BUG=736375

Change-Id: I73c225fed86f536074f6886d22f9a65e43fcde3e
Reviewed-on: https://chromium-review.googlesource.com/567495
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486111}

See https://skia-review.googlesource.com/c/22721

NOTRY=True

Bug: Skia:6828
Change-Id: I7c98d62c3453a142a64a3e7fc31a814c4292142a
Reviewed-on: https://chromium-review.googlesource.com/568838
Commit-Queue: Mike Reed <reed@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486110}

On the NTP, the app menu button now remains visible. On regular new
tabs, the menu options are "New incognito tab", "Recent tabs",
"Settings", and "Help & feedback". On incognito new tabs, the menu
options are "New tab", "Settings", and "Help & feedback".

BUG=734123,695973

Change-Id: I38b3b4e8dbf5cc4a6a62f98bf6dfd6a5d2f4a905
Reviewed-on: https://chromium-review.googlesource.com/560538
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486109}

Names don't need to say net:: when already inside the namespace.

Bug: none
Change-Id: I11972d69236f22848a39bb86b2b1845c26a78a4c
Reviewed-on: https://chromium-review.googlesource.com/566065Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486108}

Currently, in passwords settings, haptic feedback is given during copying
password but not during copying any of the other less sensitive data (site
and username).

https://crbug.com/696634 hints at, and pinkerton@ confirmed, that the idea
for haptic feedback was to accompany all MD toasts in the UI. pschaffner@
confirmed on this CL that that's a good idea for the passwords settings
as well.

Therefore, this CL adds the haptic feedback to the site and username
copy toasts. Those copies always succeed, because there is no
reauthentication to be done, so the feedback is always a successful
one.

Bug: 740948
Change-Id: Ie282499eb5095cabeb4d8349f6231ae653f01f6a
Reviewed-on: https://chromium-review.googlesource.com/567152
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Mike Pinkerton <pinkerton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486107}

Bug: 
Change-Id: If61790974f5069871cbf908e98e43ec8dbc4198a
Reviewed-on: https://chromium-review.googlesource.com/568389Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486106}

Switch mechanism for delaying cookie reuqests until the appropriate
parts of the cookie database are loaded over to using callbacks instead
of home-grown classes.

BUG=None
R=mmenke@chromium.org

Review-Url: https://codereview.chromium.org/2971323002
Cr-Commit-Position: refs/heads/master@{#486105}

One letter fix: kNoteTypeAudioWorklet -> kNodeTypeAudioWorklet

Change-Id: I8b122dfd2c54ee888906f88bf3e1ee9cd9250d4a
Reviewed-on: https://chromium-review.googlesource.com/568464Reviewed-by: Raymond Toy <rtoy@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486104}

In the case of ui resource eviction on the impl thread, layers may not
be updated prior to a commit on the main thread.

Bug: 726423
Change-Id: Ia6874df31084b53619155959a5ed85694e23fdf5
Reviewed-on: https://chromium-review.googlesource.com/564159Reviewed-by: Weiliang Chen <weiliangc@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486103}

Once the user has accepted cleanup, the cleaner runs for a few minutes
and eventually terminates with exit codes 0 (success) or 15 (reboot
required).

If a reboot is required, we would like the user to reboot their machine
as soon as possible. However, opening a new foreground tab has issues
such as putting settings option where the user was clicking on their
original page. To be safe, we use a new background tab so the user can
eventually get to it.

We don't open a new tab if the current tab is chrome://settings since
most* users will be able to see the call to reboot.

*: Users who have scrolled down the page may not see the prompt if they
don't scroll back up. I don't think we want to refresh or scroll up the
page in case they were modifying another setting.

Known issue: users that had a settings tab opened prior to the transition
to kInfected and are on that old tab instead of a more recent settings
tab may not see the call to reboot.

BUG=690020

Review-Url: https://codereview.chromium.org/2973313002
Cr-Commit-Position: refs/heads/master@{#486102}

CancelableSyncSocket currently fails because shutdown() doesn't work
for sockets created using socketpair().

Bug: 741783
Change-Id: Id6506e26bf9add6bf57bf7f80ff2129b16b7df82
Reviewed-on: https://chromium-review.googlesource.com/568738Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486101}

This CL changes PaymentRequestItemList::Item from "creates-a" RowView to
"is-a" RowView. This was suggested as a good structural change, since
it allows the logic of Item to modify the RowView after create-time;
in particular, it is necessary now to make an a11y fix (also in this
CL).

Bug: 733684
Change-Id: I50b71059940208f0ab7146fd4595653cdb586e0a
Reviewed-on: https://chromium-review.googlesource.com/565329
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486100}

BUG=

Review-Url: https://codereview.chromium.org/2977833002
Cr-Commit-Position: refs/heads/master@{#486099}

These calls are no longer needed after r485461
(https://crrev.com/2478803003) which has made the
domAutomationController.setAutomationId call a no-op.

BUG=662543
This CL was uploaded by git cl split.

R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2979783002
Cr-Commit-Position: refs/heads/master@{#486098}

[CrOS Tether] Convert HostScanCache to an interface and add MasterHostScanCache as the concrete implementation.

This CL also creates a HostScanCacheEntry class which encapsulates data to be stored in the cache as well as adding a Builder pattern which makes creating cache entries easier. This will make it much easier to add new properties to the host scan cache without having to add new     parameters to every affected function prototype.

This is the first step of persisting host scan results so that we can recover from crashes. Steps listed below:
(1 - this CL) Create a HostScanCache interface and move the concrete implementation to MasterHostScanCache.
(2) Create a HostScanCache implementation which persists cache entries to user prefs.
(3) Move code which adds entries in the network stack to another HostScanCache implementation, and have MasterHostScanCache manage the other two HostScanCache implementations.

Bug: 672263, 737273
Change-Id: I42646de50d393e9b327371effbf974020083b12d
Reviewed-on: https://chromium-review.googlesource.com/567235
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486097}

Bug: 741220
Change-Id: Ia066158712e5980459af17d602795c4997a90b2f
Reviewed-on: https://chromium-review.googlesource.com/567799Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486096}

BUG=NONE

Review-Url: https://codereview.chromium.org/2953643002
Cr-Commit-Position: refs/heads/master@{#486095}

Add a time histogram to measure Android's delay between bindService and
onServiceConnected. Then add a boolean histogram that counts number of
times onServiceConnected times out, which should really be considered an
infinite bucket in the time measurement.

BUG=736066

Change-Id: Ia73926a04c01f52216dd24805051a077a500c2b7
Reviewed-on: https://chromium-review.googlesource.com/567369Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Bo Liu <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486094}

Currently "keyboard" is used for both the container window and the web
contents in it, which is confusing.
To avoid the confusion, this CL renames some "keyboard" to "contents"
or "Keyboard" to "Contents"

Bug: 739069
Test: try

Change-Id: I8d94626f4a25bca69e328e583cde2b3239dd9367
Reviewed-on: https://chromium-review.googlesource.com/558180
Commit-Queue: Keigo Oka <oka@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Keigo Oka <oka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486093}

BUG=732976
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2969473003
Cr-Commit-Position: refs/heads/master@{#486092}

Redirects toward renderer-debug urls (chrome://crash, javascript:[...],
...) were not expected to happen in the NavigationHandleImpl. It caused
WebContentsObserver::DidFinishNavigation not being called and
consequently, bugs in some WebContentsObservers.

This CL blocks any redirects to renderer-debug urls. One test is added.

The blocking of the URL was moved (and partially removed?) in:
https://crrev.com/2436253002
This CL tries to restore the previous behavior.

BUG=728398

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.linux:linux_chromium_browser_side_navigation_rel

Review-Url: https://codereview.chromium.org/2973433003
Cr-Commit-Position: refs/heads/master@{#486091}

When creating ImageBitmap from ImageData, if the intersection of source rect
and crop rect is empty, we should create and return an empty ImageBitmap with
the size of "normalized" crop rect.

Bug: 739818
Change-Id: Ia405732fc9f2d3f1d97783bcab1a203508cab4e8
Reviewed-on: https://chromium-review.googlesource.com/565053Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486090}

The original CL https://chromium-review.googlesource.com/567930 was reverted
because EG tests were not synchronised with the string change. The reverted CL
is patch set 1 here. The fix consists of updating the tests, those are all
subsequent patch sets here.

Original description:
---------------------
Most of setting headers in the passwords seciton on iOS already use Title Case,
except for the headers of the saved and blacklisted lists of passwords.

This CL fixes that by creating new strings for iOS settings inside
ios/chrome/app/strings/ios_strings.grd. Previously the code used shared strings
from the password_manager component (components/password_manager_strings.grdp).
That string was also used by the old (non-MD) desktop settings, which have
already been deprecated. The MD settings on desktop use the Title Case as iOS
should as well, but the MD settings strings are consistently saved in
chrome/app/settings_strings.grdp, where they cannot be shared with iOS.

The CL creates the new string instead of sharing the one from MD settings,
because sharing has no benefit (on no build both strings are included, so no
storage spared) and has the drawback of binding the style of both strings
forever together.

The CL does not remove the component string yet. The old desktop settings code
is still in the codebase, and the shared string (used only by the old settings)
should be deleted once those old settings are deleted.
---------------------

Bug: 740952
Change-Id: I1b166a4961235fdaa5a122795cc016d9b5438612
Reviewed-on: https://chromium-review.googlesource.com/568497
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Louis Romero <lpromero@chromium.org>
Reviewed-by: Louis Romero <lpromero@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486089}

This reverts commit a1037c1c.

Reason for revert: https://crbug.com/657959#c47

Original change's description:
> Change FrameSinkManager task runner.
> 
> On Mac there is a special task runner that runs when the main task
> runner is blocked on resize. The main task runner blocks until a
> CompositorFrame arrives, and we need HostFrameSinkManager and
> FrameSinkManagerImpl to continue processing messages during this time.
> 
> Bug: 657959
> Change-Id: I3d8bb8bb22b5a4d36d1fe83e1144d11bbe1fd59d
> Reviewed-on: https://chromium-review.googlesource.com/563860
> Commit-Queue: kylechar <kylechar@chromium.org>
> Reviewed-by: Saman Sami <samans@chromium.org>
> Reviewed-by: Fady Samuel <fsamuel@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#486070}

TBR=fsamuel@chromium.org,kylechar@chromium.org,piman@chromium.org,samans@chromium.org

Change-Id: I540b79a8fc55ec260268bf437903e05020dc398f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 657959
Reviewed-on: https://chromium-review.googlesource.com/568879Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486088}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/08d8c9f08602..6c40c273a7fe

$ git log 08d8c9f08..6c40c273a --date=short --no-merges --format='%ad %ae %s'
2017-07-12 dproy Fixes catapult vulcanizer inline script ordering
2017-07-12 xunjieli Roll wpr-go forward to 11be1ed696ba1029960ca3b55bb369222dff183a
2017-07-12 xunjieli [wpr-go] Make installroot.go as a separate step.
2017-07-12 charliea Update the version_in_cs for the BattOr firmware

Created with:
  roll-dep src/third_party/catapult
BUG=737176


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Iba91255958fd1b494dcf2188e2e20022811cc93c
Reviewed-on: https://chromium-review.googlesource.com/568590
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486087}

We previously DCHECKed that we could never register a new scrollbar
against a scroll layer that already has a scrollbar. i.e. We expected
that the old scrollbar would be unregistered prior to registering the
new one.

RootScroller can break this assumption on Android. On Android, the
global rootScroller (i.e. OuterViewport) is prevented from creating
its own scrollbars, instead inheriting the VisualViewport-created
scrollbars. In other words, the VisualViewport creates a pair of
scrollbars and they get re-assigned to whatever the current outer
viewport is.

This means that when we change the global rootScroller (for context see
core/page/scrolling/README.md), the previous rootScroller now creates
its own scrollbars and the VisualViewport scrollbars get registered to
the new rootScroller. This then creates a race between moving the
VisualViewport scrollbar registration and new scrollbar registration on
the old rootScroller.

Long-term, the outer viewport shouldn't own the scrollbars but for now
it doesn't hurt to just unregister the scrollbar if we notice the
scroller already has scrollbars registered.

Bug: 739738
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I99e8a95881e7dad19c0318a661da80f441b97b19
Reviewed-on: https://chromium-review.googlesource.com/562018Reviewed-by: Weiliang Chen <weiliangc@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486086}