- 11 Sep, 2020 40 commits
-
-
Avery Musbach authored
Overview exit animation histograms shall include when overview ends because you drag two windows from overview and snap on opposite sides. Test: All/SplitViewOverviewSessionInClamshellTest.BothSnappedOverviewExitAnimationHistogramTest/? Change-Id: I5a1e7d11a4e6d4e3aff49c32e489b9042aa5cf0e Fixed: 1124786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401941Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#806377}
-
Tim Song authored
BUG=1106937,1126208 Change-Id: I58ef9ad83bb18ee8193563820c3c0a223295e6a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400765 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#806376}
-
Matt Mueller authored
This reverts commit 629c4109. Reason for revert: regression on cronet_perf_tests, reverting to confirm if this CL was the cause: https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDIvO-0lgoM https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDI_IX5rwkM https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDI_Nq_rgsM https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDI_KezuwsM Original change's description: > Quiche merge for Sept 11, 2020. > > > Roll src/net/third_party/quiche/src/ 5c52ad843..0c20b03c8 (3 commits) > > https://quiche.googlesource.com/quiche.git/+log/5c52ad843f8a..0c20b03c83cc > > $ git log 5c52ad843..0c20b03c8 --date=short --no-merges --format='%ad %ae %s' > 2020-09-10 renjietang deprecate gfe2_reloadable_flag_quic_do_not_use_stream_map. > 2020-09-10 renjietang deprecate gfe2_reloadable_flag_quic_remove_streams_waiting_for_acks. > 2020-09-10 bnc Use IETF application error codes for STOP_SENDING frames. > > Created with: > roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src > > R=dschinazi@chromium.org > > Change-Id: Iba8427627fcbfd7417a0d619f80f8b139c153cf6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404718 > Auto-Submit: Ian Swett <ianswett@chromium.org> > Commit-Queue: David Schinazi <dschinazi@chromium.org> > Reviewed-by: David Schinazi <dschinazi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#806254} TBR=ianswett@chromium.org,dschinazi@chromium.org Change-Id: I178b3341725551de6012eec906ba6768089a309f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406391Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#806375}
-
Andrew Grieve authored
It's used only in a single file, so define it there (condition_variable_posix.cc). Bug: None Change-Id: Ia59b42486feee2920f77dbcbef40a0d801bd2b51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405416 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#806374}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/aeac9f88598d..ef8507d106ad 2020-09-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 55b6d728..86121ae2 (806095:806200) 2020-09-11 kwiberg@webrtc.org Proof of concept: Cancer Stick Castle, a sigslot replacement 2020-09-11 sprang@webrtc.org Updates rtcp::CompoundPacket to contain unique pointers to packets. 2020-09-11 lndmrk@webrtc.org Delete kHEVCCodecName 2020-09-11 jleconte@webrtc.org Change gtest name to allow filtering based on the story name. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ice4ec2b20d6865f978f9ef4606cb4e6b05efed51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406741Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806373}
-
Mei Liang authored
On rare occasions the fetcher returns a null bitmap before the ImageView finishes its measurement, which causes setMinimumHeight to 0 instead of the expected value. This CL fixes the “pill” shape tab in GTS and TabGridDialog by extending the RoundedCornerImageView and overriding the onMeasure to apply the aspect ratio to the height when the ImageView drawable is null or a ColorDrawable. Everything introduced in this CL is gated by Finch parameter "enable_launch_polish" under flag "enable-tab-grid-layout". Most of Java code is verified to be behind the gating function TabUiFeatureUtilities#isLaunchPolishEnabled by formal equivalence checking tool here: http://crrev.com/c/1934235. The following changes can't be verified by the tool, but it is expected and no-op without the flag: * The tab_grid_card_item.xml file * The newly added file TabGridThumbnailView Bug: 1121283 Change-Id: I29da57a72b2de6783b44ace6c1568d07c76c8663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392976 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#806372}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I67f3dce1cbb16a4e7e69862c7dcea37db3fc76ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406601Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806371}
-
Mustaq Ahmed authored
Bug: 1096189 Change-Id: Ie6d6bb110580d5b96751331483bac6ac46153f0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367991Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#806370}
-
Shengfa Lin authored
Differentiate passing host for new session and pass host instead of session id so that we can use it to construct WebSocketUrl potentially Bug: chromedriver:3588 Change-Id: Ib7a0dda3daf816b36ecf6220140dc906e2040487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391903Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#806369}
-
Ionel Popescu authored
This CL adds eye dropper support for pre-macOS 10.15 due to NSColorSampler not being supported. The pre-macOS 10.15 support is added by splitting the current aura specific implementation. Since the eye dropper can currently be opened from the color picker which is a popup[1], there is a need to add Mac specific support for: - moving the view to the front of the screen list within the popup level - event monitor since the popup had already installed one to be able to close when the user clicked outside of its bounds [1]: https://source.chromium.org/chromium/chromium/src/+/master:content/app_shim_remote_cocoa/popup_window_mac.mm Bug: 992297 Change-Id: I5de7b21845ef8a4e45243d257fa7a8a9af4a193f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405302 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#806368}
-
Orin Jaworski authored
If a Pedal attached to a suggestion that later became a duplicate of an entity suggestion, the Pedal was suppressed. This CL resolves such cases by waiting until after deduplication (done in SortAndCull) to attach. This ensures that only root-level suggestions are considered for Pedals. Bug: 1126572, 893183 Change-Id: I778ff524b7343304d3f14e79567195080760b298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401780Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#806367}
-
Prakhar authored
Observed rise in pending build times http://shortn/_wl495QJZSE Bug: 1024915 Change-Id: Ie15cbaf6e0a52f489d77189b020203b4db1dc279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405035 Auto-Submit: Prakhar Asthana <pasthana@google.com> Commit-Queue: Erik Staab <estaab@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#806366}
-
Dominic Mazzoni authored
This adds the toggle button for caret browsing to Chrome OS accessibility settings; previously it was only in browser accessibility settings which isn't used on Chrome OS. Also fixes the syntax for the accelerator on Chrome OS. The actual user-facing shortcut is Ctrl+Search+7, but the only way to achieve that in accelerator_table.cc is to use VKEY_F7. Manually tested on-device and confirmed that the correct shortcut Ctrl+Search+7 does work and that no permutation of modifier keys with F7 has any effect. Bug: 1120826 Change-Id: I89b4948a874f232e2c893f00611a927b3f45e44d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390876Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#806365}
-
David Black authored
Currently a screenshot is added to holding space when the user takes a screenshot using the ChromeScreenshotGrabber. The same should occur if the user takes a screenshot using the CaptureModeController. This CL wires that up and adds test coverage for both code paths. Bug: 1126643 Change-Id: I65f25392d4f3dc83b26156ba31827b76ded015a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404420 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
-
Chris Sharp authored
Change-Id: I09b384cba4b2c3947b8e0085b6c8949014bd386c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404629Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#806363}
-
Daniel Hosseinian authored
Bug: 652400 Change-Id: I7a08f0d58d5ca462fa5fe1a8dc4c06f0e8277151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402125 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#806362}
-
Morten Stenshorne authored
Do the same as in NGBlockLayoutAlgorithm instead. The tests that now pass suffered from intrinsic block-size being used blindly if computed block-size was auto - which is wrong for size containment. Had to update two unit tests, which had the wrong expectations, that even contradicted the comment in the tests ("Min-height has no effect on the columns, only on the multicol container."). The multicol containers in the tests are now correctly affected by min-height. Bug: 829028 Change-Id: I643c42fe20101738dead65b0950fbee1b7243915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404457Reviewed-by:Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#806361}
-
Yuheng Huang authored
Bug: 1099917 Change-Id: I1f2a25b7ffb96cd89fd5e316d15c332be5222a27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406678Reviewed-by:
-
Chris Lu authored
This flag will be used as a killswitch for the default browser fullscreen promo UI. Bug: 1107489 Change-Id: I47159e1a1e1d4a8466b598d4d8236b41e942c6c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405892 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#806359}
-
Sven Zheng authored
When build lacros on device with is_debug=true, it fails with: FAILED: libprotobuf_lite.so libprotobuf_lite.so.TOC /b/s/w/ir/cipd_bin_packages/cpython/bin/python "../../build/toolchain/gcc_solink_wrapper.py" --reade...(too long) lld.elf: error: corrupt input file: version need index 2 for symbol __deregister_frame_info is out of bounds >>> defined in ./libmirclient.so.9 That's because this additional deps is included. From https://codereview.chromium.org/2885223002, the mir project has been cancelled. So it's safe to remove the deps. For lacros, we have gn arg use_gtk=false, so mirclient will not be in deps. Bug: 1127103 Change-Id: Icf88d8c9a862b45e2d87818723dd700853027fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405743Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#806358}
-
Sky Malice authored
support. Bug: 1127068 Change-Id: I7d4a5191b41ce3435f033b988304c1134d239250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404114Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#806357}
-
Alexandr Rakov authored
This change adds auto restore canvas when should apply rounded corner. Bug: 1126813 Change-Id: I35f2fe8c71077a8083a33bdd90a2e2bc0039ace4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401036Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#806356}
-
Daniel Clark authored
I noticed while working on something else that AutofillAgent::ShowSuggestionsOptions's datalist_only is never referenced, and show_password_suggestions_only is referenced but never set. This change deletes both bits of dead code. These were initially added back in 2014 via https://codereview.chromium.org/753393004/diff/60001/components/autofill/content/renderer/autofill_agent.h Apparently the code has shifted since then to render them unused. Bug: 1127443 Change-Id: I52edd4864bc7441cdada2cd018073f5881b586db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406167Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#806355}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I20f0fa14914a7a9d3ebe87a35aa73e5d1291345f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406740Reviewed-by:
-
Matt Jones authored
This patch adds the concept of display priority to SceneOverlays but does not yet use them. The new method on the interface will determine the layering of the overlays, removing the need for the various case-specific "add overlay" methods. Bug: 1070281 Change-Id: I518f0324fb154a78bc47f01c6256d9fc3abd0c17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354529Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#806353}
-
Garrett Beaty authored
Bug: 1105234 Change-Id: I0b94e038a1d148ce306b2aa528855a3261166041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406333 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
-
Jan Wilken Dörrie authored
This change modifies zxcvbn's repeat_match to correctly detect repeated sequences of non-ASCII characters. Since std::regex does not natively understand UTF8 codepoints, and re2 does not support the required backreferences, this change updates the regex engine to use icu::Regex instead. Furthermore, since zxcvbn only intends to supports UTF8 strings, the fuzzers are modified to only produce valid UTF8. TBR=dpranke Fixed: 1111771 Change-Id: I4a9985997b6d6cd33558cf8607e195e61dac8109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377934 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#806351}
-
David Bienvenu authored
Change-Id: I4f58aa906bc7f8c1f82d06e56099ad6927cb4680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406533Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Jesse McKenna <jessemckenna@google.com> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#806350}
-
Caitlin Fischer authored
This is because Windows has a command line size limit and too many testing configs can result in the limit being hit. See comment 12 on the bug for details on why these studies are candidates for removal. Bug: 1126640 Change-Id: I15c07cc7335920e124bec41761c4affbc18abcce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404069Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#806349}
-
Jordan Bayles authored
This patch reenables the above test, as well as rewriting it to no longer depend on the removed cast.streaming extension APIs and moving it out of the extensions test folder path. The performance test now performs the offer answer exchange and sets up the receiver with the SSRC and AES key information from the OFFER. The video embedded in the test has been moved to being generated in JavaScript instead of native C++, fixing some playback issues. This patch also readds a missing ConsumeVideoFrame trace event. Note: to run the performance test use the following command: ./out/Default/browser_tests --gtest_filter="*CastV2PerformanceTest*" --full-performance-run --vmodule="*udp_transport_impl*=2,*performance_test.cc=2" Bug: 974427 Change-Id: I73c90d3005e0f2c0bc66453c3585f246651bab7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288636Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org> Cr-Commit-Position: refs/heads/master@{#806348}
-
Erik Chen authored
Change-Id: I5856d1b98ef0a143d4924c64d9eca279ffe6e8e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406541 Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#806347}
-
Anders Hartvoll Ruud authored
The spec changed a while ago to use CSSNumericValue/CSSKeywordish for specifying container-based offsets [1]. This CL makes that switch. [1] https://github.com/w3c/csswg-drafts/pull/5300 Bug: 1109769 Change-Id: I1d14d68008098e39035aecba940c0e02645f9d99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390740 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#806346}
-
Ken Rockot authored
This corresponds to Finch config changes in cl/330803332 Bug: 1079380,1079396 Change-Id: I3a390cc7e1b2c398ee5bed317fda8d7e8f569121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403590Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium edb67fe5. With Chromium commits locally applied on WPT: 6e83e02d "Reland "CookieStore: Remove matchType"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: Ia7847a062a23685de5ba1e489b716ebf0cb790c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404810Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806344}
-
Akihiro Ota authored
Remove repeated declarations of doCmd in the ChromeVox testing code by promoting it to ChromeVoxNextE2ETest. Bug: 1127449 Change-Id: I9d15640894a7f06e8ae3f78e06b50c6173df55c6 AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406379Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#806343}
-
Joe Downing authored
The Windows host is supposed to log events using the Windows event logging API so they can be viewed in Event Viewer. During a recent bugfix validation, we discovered that this was broken as no chromoting events were being logged. I tracked down the root cause and it was from a little of 3 years ago: https://chromium-review.googlesource.com/c/chromium/src/+/551035/ In that CL, the HostStatusMonitor functionality was pulled out of the DaemonProcess and put into its own class. The problem was that the observer list was not removed, so instead of using |status_monitor_| to notify listeners, the DaemonProcess continued to use |status_observers_| which is always empty. The fix is to remove the status_observers_ member and notify listeners using the observer list owned by status_monitor_. Bug: 1127439 Change-Id: I9ee00212e0e2c3646ced5711e594a60dfd2627e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406698Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Joe Downing <joedow@google.com> Cr-Commit-Position: refs/heads/master@{#806342}
-
Jinsuk Kim authored
TabGroupPopupUi-related classes are introduced for TabGroup and Duet. This CL deletes them as Duet was sunset. Bug: 1081343 Change-Id: I24cabbce1feb4b8aa87a8eed6f05b6e2812558c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404285Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
-
Maria Kazinova authored
code. Deleting kCredentialManager feature, because it was never launched and there is no plan to launch it in the future. Bug: 435048 Change-Id: I454fa87a98f62646af49298b98111c8982df06bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401138Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#806340}
-
gogerald authored
This makes the forced variation ids take effect immediately like others after cache initialization. Bug: 1121305 Change-Id: Id2edb803c2898b2e1f93ae3325f510b51fd0ec08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402168Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 1045266 Test: NetworkComponentsNetworkSelectTest* Change-Id: I3ed349337f3798aa3d1ee92063ed9c6a8d0ce3bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405643 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
-
