- 07 Oct, 2019 40 commits
-
-
Martin Robinson authored
Bug: 866336 Change-Id: I4e59974ee8f11cd789720b587d2954d7e3086168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1309654 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#703369}
-
Friedrich Horschig authored
This CL adds a few integration tests. They stop at the bridge since the execution of native code slows the tests down, introduces flakiness and most-likely doesn't work on Kitkat. Bug: 957532 Change-Id: I291c50ef7b8772198c89109bbe3acd885a43d054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845372 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#703368}
-
Lily Chen authored
This adds policy definitions for two policies that allow reverting to "legacy" SameSite cookie behavior, either by default or for a specific list of domains. As the policy implementation is not yet complete, these are tagged with 'future': True for now. Bug: 978172 Change-Id: Ieb95eec87b08b0c44a535ad8b1c7c90431d6a039 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837234 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#703367}
-
Andres Calderon Jaramillo authored
This CL modifies the JPEGImageDecoder to detect the YUV subsampling format correctly when not all the components are in the first scan. Prior to this change, the subsampling calculation was based on the information in the first scan. However, for some JPEGs (non-interleaved), this would produce YUV_UNKNOWN. This change makes the computation based on the information in the SOF which is global for the image and includes the information of all the scans. Bug: 900446 Test: Add a test to cover the non-interleaved case. Change-Id: If1d810f0d921cba3603cf82ac9fba19da02e8982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844094Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#703366}
-
Alex Cooper authored
Ensure that newly created sessions get the current XRVisibilityState, even if they were created after that visibility state may have changed. Bug: 1011566 Change-Id: I5eac2aac73f74a7e4b4426be3b5e6603097db39b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841246Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#703365}
-
Andrew Grieve authored
Change-Id: Ie638c6f3d05c548056a8f78a83ac7f243bff0472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841751 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#703364}
-
Jinho Bang authored
This is to match the spec change[1]. [1] https://github.com/gpuweb/gpuweb/pull/423/files#diff-599c3a4f36042dec5cdc606f3c30dc38R913 Bug: 877147 Change-Id: I3fcf6505fd69caa6b3932145f937bc1b523b9244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844526Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#703363}
-
Jinho Bang authored
This is to match the WebGPU's WebIDL[1]. [1] https://github.com/gpuweb/gpuweb/pull/359 Bug: 877147 Change-Id: Ia5fedae01348411f5e1c59faebe5c13a3dd85f91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843791Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#703362}
-
Elly Fong-Jones authored
Bug: 840435 Change-Id: I08726654201e5db65e79f86f52b19a18094c8146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842412Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#703361}
-
Justin Cohen authored
A delay of 3 seconds may not be long enough to act before restore finishes. Also, remove WKWebView cache to prevent any fast pageloads. Bug: 1011336 Change-Id: I69b2f0a3ab0b2e1c1a5c7d7a08dd71def48c90ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842035 Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#703360}
-
Robert Liao authored
Setting the label only needs to be done when either the width of the SelectedKeywordView changes or when the keyword changes. Layout does not need to play a part of this. BUG=1005568 TEST=interactive_ui_tests SelectedKeywordViewTest* Change-Id: I8e77635f23d05b17bda41c3286147fa612e45de9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838255Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#703359}
-
Lindsay Pasricha authored
ios-simulator-noncq will be used to stage tests that are EG2 but not yet ready to promote to CQ, and to help load balance the CQ bot full-configs. Bug: 1011526,1009566 Change-Id: I93af918ed7763b02c42b0b8595b857b88dd686bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841949Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Cr-Commit-Position: refs/heads/master@{#703358}
-
Sadrul Habib Chowdhury authored
Use RenderProcessHostObserver and RenderProcessHostCreationObserver APIs, to replace the usage of NotificationService. More details in the bug. Bug: 357627 Change-Id: I57d75492ac13b7da014833c24be52f8c37fe531b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842611Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#703357}
-
Richard Knoll authored
Android versions before M require a permission to read the call state which we use to get metrics for Click to Call. As we do not want to add permissions to the manifest, we won't try to log this metric on pre M devices. Bug: 1011767 Change-Id: I244295f57443c0831c488695b7ed2ea537e7c77c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845007Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#703356}
-
Charlene Yan authored
Implementation of proposed behavior #1: - When 2+ tabs are dragged, they immediately lose their original grouped status. - The grouped status of the dragged tabs updates together, based on the mouse position (i.e. treat the multiple dragged tabs like one giant tab, as far as grouped status is concerned). - If drag is canceled, all tabs go back to where they were taken from (existing behavior). Bug: 978609 Change-Id: Iab5ef1e66c50880d0fea433f712fcb10a825a769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833300 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#703355}
-
Mahmoud Gawad authored
Change the caption string field from "Enable power peak shift" to "Enable peak shift power management". Bug=b:141540468 Change-Id: I06795634e89a74b0c20bdc1d1d915c572cf80c21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845005Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Oleh Lamzin <lamzin@google.com> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Mahmoud Gawad <mgawad@google.com> Cr-Commit-Position: refs/heads/master@{#703354}
-
Jan Krcal authored
This CL makes the outline of highlighted ToolbarButton thicker and thus more visible if the highlight has no text. Highlight with no text is at the moment only used by the AvatarToolbarButton in state kHighlightAnimation. Without this change, that animation felt too subtle. Bug: 1008340 Change-Id: I64b4c3464957c34fc362fc350fb47595fa24285c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831801 Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#703353}
-
sangwoo.ko authored
When BrowserRootView is being destroyed, we shouldn't call callbacks from DropTarget. It might be already destroyed. Bug: 1001942 Change-Id: Iddecc9334d814f9154d44ff32473c5fa167b3b23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844001 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#703352}
-
Justin Miron authored
This reverts commit 7172c7f2. Reason for revert: Re-enabling to catch flaky run loop tasks with additional run loop debug information. New run loop timeout information added as part of crbug/1010061. Original change's description: > Disable SubresourceFilterSafeBrowsingActivationThrottleTest.NoConfigs > > TBR=hbos@chromium.org > NOTRY=true > > Bug: 1010020 > Change-Id: Ia15694adcd86238dd59b7775d9d6a25ee3d2cfcf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833118 > Reviewed-by: Xida Chen <xidachen@chromium.org> > Commit-Queue: Xida Chen <xidachen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#701548} TBR=hbos@chromium.org,xidachen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1010020 Change-Id: I09daf7f0ae76bacf6826334f250b10a2d1a4c3ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843913Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Justin Miron <justinmiron@google.com> Cr-Commit-Position: refs/heads/master@{#703351}
-
Justin Miron authored
This reverts commit b473f1d8. Reason for revert: Re-enabling tests to catch flaky run loop tasks with additional run loop debug information. New run loop timeout information added as part of crbug/1010061. Original change's description: > Disable SubframeNavigationFilteringThrottleTest.FilterOnRedirect > > TBR=hbos@chromium.org > NOTRY=true > > Bug: 1010020 > Change-Id: I6f78af68ae006d29e991b180adadc347170224a0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833116 > Reviewed-by: Xida Chen <xidachen@chromium.org> > Commit-Queue: Xida Chen <xidachen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#701544} TBR=hbos@chromium.org,xidachen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1010020 Change-Id: Ifeef268d208a2ff12bfd6c5dc5f8e95afa6bbf73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845153Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Justin Miron <justinmiron@google.com> Cr-Commit-Position: refs/heads/master@{#703350}
-
Ryan Daum authored
Makes 'NAVIGATE' be the '0', or potentially default, value. Bug: internal b/141853741 Test: none Change-Id: I6d5025e32396be7fe61035046c2b237f1645c504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844077Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#703349}
-
Reilly Grant authored
In addition to better readablility this replaces use of base::RunLoop().RunUntilIdle() with EvalJs's ability to wait for a Promise to resolve. This should hopefully de-flake the device add and remove tests. Bug: 999472, 999502 Change-Id: I766d28e8fcde19e84346b46cc6dafedd4c921a77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842616Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#703348}
-
Etienne Pierre-doray authored
Issue: Idle thread creation is not disallowed while JoinForTesting(). Fix: prevent thread creation in EnsureEnoughWorkersLockRequired with join_for_testing_started_. Bug: 1009536 Change-Id: I3f6f18efa5e950c69fef1f7d4458d703ca1d6056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834201 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#703347}
-
Lukasz Anforowicz authored
This CL moves processing of FrameHostMsg_DownloadUrl and FrameHostMsg_SaveImageFromDataURL from RenderFrameMessageFilter::OnMessageReceived (which runs on the IO thread) to RenderFrameHostImpl::OnMessageReceived (which runs on the UI thread). As part of the refactoring, the CL also removed no-longer-necessary |render_view_id| and |render_frame_id| fields from the IPC payloads. These fields are implied, when sending the IPC messages directly to a RenderFrameHostImpl. The CL had to modify some tests to account for the changes: - Apparently there was no coverage of RenderFrameHostImpl::SaveImageAt. The CL adds coverage in the form of DownloadContentTest.SaveImageAt. - The RenderViewHostTest.SaveImageFromDataURL unit test was very closely tied to a specific implementation and was basically verifying that RenderFrameMessageFilter::OnMessageReceived forwards the IPC to RenderFrameMessageFilter::OnDownloadUrl and then to the (test version of) RenderFrameMessageFilter::DownloadUrl. The CL removed the test - the end-to-end test coverage offered by the new DownloadContentTest.SaveImageAt should be more valuable. - The CL only needed to slightly tweak RenderFrameImplTest.SaveImageFromDataURL test to account for modified payload of the FrameHostMsg_SaveImageFromDataURL IPC. The CL also opportunistically fixed some |git cl lint| issues (IWYU, marking some constructors as explicit, whitespace formatting). Change-Id: I3cd6d9545b16ed8d5ebe51c05dd588fffc1ed17b Bug: 1008917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827949Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#703346}
-
Dave Tapuska authored
We are going to remove RevocableInterfacePtr and so change to use the mojo::Remote directly. BUG=978694 Change-Id: I08745b87773b4dc534a1e32652d4faf156259d00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842298Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Mario Sanchez Prada <mario@igalia.com> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#703345}
-
Sean Harrison authored
The pathvisited UMA was recording every typo as a different page, we only want to record valid pages, so now we check if it a valid settings page before recording. Bug: 869847 Change-Id: I53a7834f9d8544d9bc6bbdb3e2cca9887b2fb49e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819311Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#703344}
-
Seth Brenith authored
When running CopyStackContentsAndRewritePointers on ARM64, we need to include the stack pointer itself in the list of registers to update so that they point to the new copy of the stack data. Together with https://crrev.com/c/v8/v8/+/1845189 , this allows the unit test V8UnwinderTest.UnwindThroughV8Frames to pass on Windows ARM64. Change-Id: Ie08cb8d942d7ee29ee69aea3cc2d58407529027e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844276Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/master@{#703343}
-
Klaus Weidner authored
This CL makes the needed paint / compositing changes to make the DOM overlay element appear transparent. Split out from https://crrev.com/c/1741008 Bug: 991747 Change-Id: I6461c095becb5b2712942521b33338bdaf5ccfff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802674 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#703342}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5750cdd8..62fdbf47 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9a840d00be16a4d6ee4a369c6c48ebea84c5df56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844397Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703341}
-
Nina Satragno authored
Update WebAuthn command responses to match the spec: * AddVirtualAuthenticator should return `authenticatorId` instead of an object containing `authenticatorId`. * GetCredentials should return an array instead of an object containing an array of credentials. Bug: 922572 Change-Id: Id7fc36eca79ae7624c662d8674be0f62a7df72e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841239 Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#703340}
-
Evan Stade authored
Simplify lifetime by making BackgroundContentsService own BackgroundContents. Bug: 268984 Change-Id: I1ee30300849a4549e97cef7f461106dfe2576dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832681 Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Cr-Commit-Position: refs/heads/master@{#703339}
-
Patrik Höglund authored
They sometimes leak on ASAN. TBR: tommycli@chromium.org Bug: 1010691 Change-Id: I663cb4fa70974b35832edacf77e0fdb094631135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844958 Commit-Queue: Patrik Höglund <phoglund@chromium.org> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#703338}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/27399bbb1d0e..af16026220a0 Created with: gclient setdep -r src-internal@af16026220a0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ib5bb1d61e5d7f346721c5909fe40e944806e3b6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845184Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703337}
-
Evan Stade authored
LastDownloadFinder only cares about normal profiles, not OTR. It's ultimately owned by SafeBrowsingService which is itself destroyed before Profiles are destroyed during browser shutdown. Also remove NOTIFICATION_PROFILE_ADDED and replace it with ProfileManagerObserve::OnProfileAdded. Bug: 268984 Change-Id: Ie0ba25eca1262ebb26a71d712b338dd5a3d47e19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830291 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#703336}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7c745839a728..647c7a97d32d git log 7c745839a728..647c7a97d32d --date=short --no-merges --format='%ad %ae %s' 2019-10-07 brianosman@google.com Particles: New confetti effect, minor tweaks elsewhere Created with: gclient setdep -r src/third_party/skia@647c7a97d32d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: None Change-Id: I337d3da3017673759694a5049b31fbf075aaeaf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845185Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703335}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c4f83cee. With Chromium commits locally applied on WPT: c19433ef "Reland "[ChromeDriver] Stop using --ignore-certificate-errors"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ia9c027a10a70221c5e5fd2ff5c231c3b4f27a287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844398Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703334}
-
Peter Wen authored
Add monochrome smoke test for fake modules. Runs on CQ (M) and on waterfall (N, O, P). Bug: 1000749 Change-Id: I3598152b383b45c26adeec72a2038bfb1a09fcca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836375 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#703333}
-
Fred Mello authored
Related to: https://crrev.com/c/1841694 Bug: 1005802 Change-Id: I344c4e408730d8b4c0c70bb22162839ff4171053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842863 Commit-Queue: Fred Mello <fredmello@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#703332}
-
Nicolás Peña Moreno authored
Now that we've removed the ElementTiming flag, there is never a reason to delete the TextPaintTimingDetector member from PaintTimingDetector since it should be used to track elements annotated with elementtiming. This CL simplifies the logic within PaintTimingDetector to account for this fact. It also adds tests to ensure that visible objects are not deleted after user input or scroll, since right now they are needed for ElementTiming. Bug: 1011009 Change-Id: Icd58dae42dab3ca65493724b88ab0b939cca53d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838351 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#703331}
-
Thomas Tangl authored
- The implementation is changed to use SyncTest and ProfileSyncServiceHarness for the setup. - If the sync confirmation dialog is opened, it is manually dismissed to not cause any crashes during shutdown. Flakiness should be removed now. Bug: 995720 Change-Id: I66064e40040447ac5a97329f9e5063630c32eebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840171 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#703330}
-