- 17 May, 2019 40 commits
-
-
Oystein Eftevaag authored
R=ssid@chromium.org BUG=961609 Change-Id: Ic25d4eb36f90506c8d21abf3df35fb3f11474746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616447 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#660715}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a30f47ae. With Chromium commits locally applied on WPT: c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed" fec827fb "Added wpt tests for overscroll customization." c9077e39 "Restore original tail-processing for ScriptProcessor and AudioWorklet" d814fafc "Check for detached ArrayBuffers in Web Bluetooth writeValue functions" 64cbdf7a "Replace originOffset public member with getOffsetReferenceSpace method" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bokan@chromium.org: external/wpt/visual-viewport eae@chromium.org, szager@chromium.org: external/wpt/intersection-observer hbos@chromium.org, hta@chromium.org: external/wpt/webrtc kojii@chromium.org: external/wpt/css/css-scoping kojii@chromium.org, ksakamoto@chromium.org: external/wpt/css/css-font-loading mkwst@chromium.org: external/wpt/cookies mstensho@chromium.org: external/wpt/css/css-multicol NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I8b30a680d2870a061ad7d5c3be05cbb7d6e83433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616426Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660714}
-
Matthew Cary authored
Previously, the shared memory for the decode buffer was mapped read-only. However, after conversion to the new API which tracks the read-only status of shared memory more accurately, it turns out that the memory is not read-only. Bug: 849207 Change-Id: Ib87620aa9d9e279ce538dbe80e17afd770fbdb41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614178 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#660713}
-
tby authored
This makes each ranker test construct its own ranker, instead of using a member constructed in SetUp. This makes testing UMA error metrics easier, which will be a follow-up CL. Bug: 921444 Change-Id: I0dbd2f09796e5a9773318eda2a0533fbdc2d9bfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614643Reviewed-by:
Charles . <charleszhao@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#660712}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/57f13dec7309..5fc3c49fdd63 git log 57f13dec7309..5fc3c49fdd63 --date=short --no-merges --format='%ad %ae %s' 2019-05-17 llozano@google.com Temporarily increase allowed number of days for stale AFDO profiles. Created with: gclient setdep -r src/third_party/chromite@5fc3c49fdd63 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I8f23c84b9a2006456379a398fe2d1f8b1813462d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616641Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660711}
-
David Staessens authored
This CL makes the video player test framework send an EOS frame to the renderer upon reaching the end of a video stream. This functionality is required in the upcoming capped performance tests to correctly calculate the dropped frame count. TEST=ran new VDA perf tests on eve BUG=925714 Change-Id: Ib8b65e1c7324a9757d916c3941022c4a8298ec4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604385 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
-
Michael Giuffrida authored
R=dpapad@chromium.org Bug: 962114 Change-Id: I4d0bc5d735d2a9286b4c522aa51fd46dbfdbd51f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612127Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#660709}
-
Shu Chen authored
Bug: 963269 Change-Id: I698abef8d771239ce1840940fce2ed59a74ca7ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611425 Commit-Queue: Shu Chen <shuchen@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#660708}
-
Siddhartha S authored
Change-Id: Ie1634c14cb7249688e4482bff34c51dc04511ea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613590 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#660707}
-
Ehsan Karamad authored
This CL fixes the cros-process flag used in interactive MimeHandlerViewTests. TBR=wjmaclean@chromium.org Bug: 961786 Change-Id: I661b708b2c52fec981bea291464351d1840139df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616063Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#660706}
-
Alan Cutter authored
This CL adds a success metric for omnibox PWA installation promotion. Webapp.Install.InstallBounce is counted whenever the user uninstalls a PWA within an hour of installation and tracks the install source used for the initial installation. If this metric remains low that is an indication that users find PWA windowing useful and don't feel the need to reverse the effects of installation. Bug: 907351 Change-Id: I3a62009ff5a3ee650ba4522f1bff6d993e9db7fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591557 Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#660705}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/9f04be04a723..05c766a1f461 git log 9f04be04a723..05c766a1f461 --date=short --no-merges --format='%ad %ae %s' 2019-05-16 zoddicus@users.noreply.github.com Add flag to allow filtering tests cases being run (#625) Created with: gclient setdep -r src/third_party/shaderc/src@05c766a1f461 The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com Change-Id: I7436fad667f633ef8406a47b566550532804f87c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616444Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/99fe071354e3..5737f025b55d git log 99fe071354e3..5737f025b55d --date=short --no-merges --format='%ad %ae %s' 2019-05-17 ehmaldonado@chromium.org git-cl: Only display a detailed message when git-cl fails. Created with: gclient setdep -r src/third_party/depot_tools@5737f025b55d The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:961663,chromium:955206 TBR=agable@chromium.org Change-Id: Ib4251d8595bcb43845c6f39d0dba74edf3e4455c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616446Reviewed-by:
-
Fabrice de Gans-Riberi authored
GestureScrollDebounceTimerOverscroll and TouchGestureEndDispatchedAfterOverscrollComplete have shown signs of flakiness on Fuchsia and Linux tsan bots. Bug: 776424 Change-Id: I346753d25c4510e2e7ff9c8537962a36a79d89aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616448 Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#660702}
-
Fabrice de Gans-Riberi authored
Bug: 920920 Change-Id: If3d67f02111cced48e7483b8d952a4ef00c40037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614688 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#660701}
-
Jeevan Shikaram authored
This reverts commit 61600282. Reason for revert: Avoiding potential crashes due to mojom struct type update without version update. Original change's description: > [App Management] Add support to display managed badging for toggles. > > Add support to detect managed pinning and managed permissions > and display badges next to the toggles. > > Screenshot: > https://bugs.chromium.org/p/chromium/issues/detail?id=953580#c4 > > TBR: raymes@chromium.org > Bug: 953580 > Change-Id: Ia7f56f10243bfffe99c229e1255052c882c01262 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605442 > Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> > Reviewed-by: calamity <calamity@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#660344} TBR=calamity@chromium.org,dominickn@chromium.org,jshikaram@chromium.org,raymes@chromium.org Change-Id: Id79ea8f176c78d02454dede98ac064231a642258 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 953580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616761 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#660700}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4a8e975fb266..45aed26c5e06 Created with: gclient setdep -r src-internal@45aed26c5e06 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=beverloo@google.com,collinbaker@google.com,bcwhite@google.com,tasak@google.com Change-Id: If46ebe52449ca81492e2c517567df2c4b2558909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616443Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660699}
-
Caroline Rising authored
The anchor view is not updated until the slide animation is completed so this case previous would exit early when trying to switch tabs when the slide animation had not yet finished. Bug: 910739 Change-Id: Ia5b28301dbab6a7c678228c153a92281a396ca33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616006 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#660698}
-
tby authored
Bug: 921444 Change-Id: I07e7fd9ebd368639badb599c41bcb5ed8900e25d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614724 Commit-Queue: Charles . <charleszhao@chromium.org> Reviewed-by:
-
Anand K. Mistry authored
Kerberos requires a host name to be able to obtain a ticket. Using an IP address results in an authentication error. Detecting this case and giving the user a more detail error message is a better user experience. BUG=907207 Change-Id: I0369326a79501cefa2f2736d4a7933c79b740783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530282 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
-
Anne Lim authored
Set kAutofillSaveCreditCardUsesStrikeSystemV2 to default. Bug: 884817 Change-Id: Ic0ff1d87fc9773735cda00e92b8d204bc442b50b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615805 Commit-Queue: Anne Lim <annelim@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#660695}
-
Timothy Loh authored
This CL updates the Plugin VM launcher strings and sets them as translatable. Change-Id: I39fda7cae344279073692af91b10fb6a03c14b9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602196Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Auto-Submit: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#660694}
-
Kelvin Jiang authored
This change adds the ability to export the activity log history as JSON through an option in the 3 dots dropdown menu. The exported data is a list of extension activities as returned by GetExtensionActivities from the chrome.activityLogPrivate API (therefore the data might be different than what's seen in the UI itself) but sorted by timestamp in ascending order. Screenshot: https://imgur.com/a/YNpyFCd Bug: 832354 Change-Id: If891931bfa042e3f1eadecc6f6384198c4a2c6b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602074 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
-
Noel Gordon authored
Raw image preview requests contain the source file as a DOM fileSystem URL. Add a helper to resolve the fileEntry associated with the URL and read its content into an ArrayBuffer with the DOM fileSystem API. Add closure markup / comments, add externs/platform.js to BUILD.gn for the DOM fileSystem API declarations, and Closure compile the lot. Bug: 904630 Change-Id: I80d3f695dfce939b92d42932db666c3ab272ac69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611624Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#660692}
-
Darren Shen authored
We switch KeyboardControllerState to the new style according to [1]. This also gives us a benefit that we no longer have to handle the COUNT enum value with NOTREACHED. [1] https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/histograms/README.md#enum-histograms TBR=sky@chromium.org Bug: 845780 Change-Id: I84869a08e3f6187c767818643fd94db7dc590b08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611070Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#660691}
-
Jia authored
Bug: 881215 Change-Id: Ib39e29d773c5d94e23943929cce1572ac7cd619c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614769Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#660690}
-
Alexander Woolf authored
Creates a quarantine service to be used to perform file scanning / invoking attachment services. This change creates the service but does not implement the quarantine logic. A follow up change will move quarantine implementation from components/services/download to the service, and add the logic to call the service. Bug: 870998 Change-Id: I21a06a98bed59ce01774d4da5b8319c1dfe7b55d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595156Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Alexander Woolf <alewoolf@microsoft.com> Cr-Commit-Position: refs/heads/master@{#660689}
-
Alan Cutter authored
This CL makes "cancel" the initially focused button in PWA installation confirmation dialogs. This is to prevent accidental installations if the user holds down enter. The "install" button is still coloured blue as if it were the default action. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=391193&signed_aid=oHH2Y0KPtmjQ0oX90XEI4A==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=392968&signed_aid=sk4b6UZkAkZ9U6T9qqwovw==&inline=1 Change-Id: I05ac2d11aa15077395c617e5ba067025de6d98ca Bug: 957848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588070 Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#660688}
-
Nigel Tao authored
The App Service's apps::CrostiniApps class now listens for the preference that enables or disables Crostini, and shows or hides the Crostini Terminal app respectively. The App Service + App List UI integration code (the c/b/ui/app_list/app_service_* changes) also now hard-codes a Crostini app folder, the same as the existing behavior (with the App Service disabled), hard-coded into c/b/ui/app_list/crostini/*. This commit also makes further changes to CrostiniAppModelBuilderTest so that it works with the Mojo IPC based App Service. Together, this fixes `unit_tests --enable-features=AppServiceAsh --gtest_filter="CrostiniAppModelBuilderTest.*"`. It fails before and passes after this commit. Note that `unit_tests --gtest_filter="CrostiniAppModelBuilderTest.*"`, without AppServiceAsh enabled, passes both before and after this commit. BUG=826982 Change-Id: Id2bd1aa9d4de0389aa94eb5c1ce8211fe5997a11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598896 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
-
Peter K. Lee authored
ContentSuggestionsCoordinator creates an AuthenticationService object from BrowserState and passes it to NTPHomeMediator. NTPHomeMediator can use this AuthenticationService to determine if user is signed in or not and to fetch the user's avatar if user is signed in. Bug: 961120 Change-Id: I1935594130295926c76cfa1f469f8647e7dd4b49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612334 Commit-Queue: Peter Lee <pkl@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#660686}
-
Mike Wasserman authored
Chrome and Ash synchronized separate ShelfModel instances for Mash. This is no longer necessary, given the discontinuation of Mash. Remove Chrome's ShelfModel instance, use Ash's instance directly. Remove shelf.mojom, struct traits, RemoteShelfItemDelegate, etc. Cleanup ShelfController, ChromeLauncherController, ShelfItemDelegate. Move ShelfModel access from Shell to a static singleton accessor. Discontinue usage of menu.mojom for the Shelf; use SimpleMenuModel. Remove unused shelf_alignment_menu.cc. TBR=tsepez@chromium.org Bug: 958215, 958247 Test: Automated; no Chrome OS shelf regressions. Change-Id: Ib315c596bf1048e6aab3cfb754b9f6b402b93794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595553 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
-
David Black authored
This code is being restored after having been removed from: https://chromium-review.googlesource.com/c/chromium/src/+/1603743 Only change to restored code is to remove any |use_window_service| params/codepaths that were present in the originally removed version. This fixes a regression in Assistant which prevented Assistant Settings and cards (implemented using NavigableContents) from rendering to the user. Bug: b:132717712 Change-Id: I27f3595f8e25bcf91664ea27beec27bf39855a31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613723Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#660684}
-
dpapad authored
Bug: None Change-Id: I18128ec2dbd49db91fd31275614b3a958235bd34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613649 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#660683}
-
liberato@chromium.org authored
First, it adds (Base | Enhanced)UnweightedTree200 experiments, which are like the originals but with 200 training examples maximum instead of 100. Since we're focusing on unweighted regression, this CL removes: - BaseTable This didn't seem to be representative of real MediaCapabilities probably due to lack of data / no data persistence. Since we are focusing on unweighted anyway, BaseUnweightedTable or BaseUnweightedTree are better baselines. We can also compare those to the upcoming unweighted MediaCapabilities experiment. - BaseTree This was an okay stand-in for MediaCapabilities, but since we are focusing on unweighted tasks, it's unclear that it means much as a baseline anymore. BaseUnweightedTree is better to use as a baseline now. - EnhancedTree This didn't perform much differently than BaseTree, and was weighted anyway. - EnhancedUnweightedTree This didn't perform much differently than the unweighted tree, so no need to maintain it. The newly-added 200 variant has a larger training set maximum size (200(!)), so we can see if that lets us get some more value from the new features. To check the value of the features, compare the 200 variant to the BaseUnweightedTree200 instead. - BinarySmoothness This isn't a regression task. Change-Id: I18b5a8bd042d7e44ba0c2e7e3780fa4fbc31c6a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606596Reviewed-by:Ilya Sherman <isherman@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#660682}
-
Collin Baker authored
This reverts commit 8bb6bea4. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 660506 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzhiYjZiZWE0OGQ0MTMxMjQ4NDU1YmZkYjE1YTVjZDllODQxZThiMGIM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Tests/16868 Sample Failed Step: content_browsertests Sending to CQ since there were merge conflicts upon reverting Original change's description: > Refactor to remove RenderWidget::PageScaleFactorChanged(). > > This refactor moves the logic in RenderWidget::PageScaleFactorChanged() > to RenderWidget::SetPageScaleStateAndLimits(). This removes the need for > RenderViewImpl::PageScaleFactorChanged() to call GetWidget(). > > Bug: 924336 > Change-Id: Ia6a345f31b80fcfda9f9dcb0a2c2765aac7ff613 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614080 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: James MacLean <wjmaclean@chromium.org> > Cr-Commit-Position: refs/heads/master@{#660506} TBR=dcheng@chromium.org,wjmaclean@chromium.org Bug: 924336 Change-Id: Ic126ac8a219336fc60203c989230843225ac65b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614472 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#660681}
-
Alexei Filippov authored
Change-Id: Ieeb0e3f19358e5c204cbcb10d036010536d5da26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615596Reviewed-by:
Vlad Tsyrklevich <vtsyrklevich@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#660680}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/908d73f65ad9..c5202e607426 git log 908d73f65ad9..c5202e607426 --date=short --no-merges --format='%ad %ae %s' 2019-05-16 thestig@chromium.org Fix a typo in CPDF_ImageRenderer::StartRenderDIBBase(). 2019-05-16 thestig@chromium.org Revert "Temporarily disable EOL policy for .in files." 2019-05-16 thestig@chromium.org Tidy CPDF_StructElement. 2019-05-16 thestig@chromium.org Fix CRLF issues with bug_557223.in. Created with: gclient setdep -r src/third_party/pdfium@c5202e607426 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: Ib46a16be03f64b16264e7262ae5e0209f6bd92a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616202Reviewed-by:
-
Mitsuru Oshima authored
Bug: None Test: None Change-Id: I74576fdeef30b3672b6e58a967c97c51bde150c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615312Reviewed-by:
-
Min Qin authored
This will allow the download to happen in reduced mode. BUG=942770 Change-Id: Ic7a61e978e5212bb8163143a005726d86197fd8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610994 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#660677}
-
Caroline Rising authored
This change makes sure that the tab hover card is hidden and animation is stopped when a tab is deleted. Bug: 963913 Change-Id: Icac21962a9fa2720bd2e55dd3e72d4cd441bedfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615599 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
-
