- 30 Nov, 2018 40 commits
-
-
Joel Hockey authored
To be used in tast test: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/1351973 * Added chrome.fileManagerPrivate.unsharePathWithCrostini. This function complements the existing fileManagerPrivate.sharePathsWithCrostini. * Added util.getEntries which returns a Promise with an object of all entries of a provided volume keyed by fullPath. This is a handy wrapper over the existing util.readEntriesRecursively. Bug: 907231 Change-Id: Ieccdc76a6457fed44d85633e9a02c658424b967d Reviewed-on: https://chromium-review.googlesource.com/c/1354755Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#612555}
-
Scott Little authored
This CL adds support for restricting the lazy loading of frames and images separately by field trial parameters. For lazy image loading, to avoid the performance hit from repeatedly locking the mutex in NetworkStateNotifier, the value of NetworkStateNotifier::SaveDataEnabled() is queried once for each frame and used for all images in that frame. Bug: 901571 Change-Id: Ic08416ebe40b6377d5c383616b4f0ceff920637a Reviewed-on: https://chromium-review.googlesource.com/c/1354694 Commit-Queue: Scott Little <sclittle@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#612554}
-
Dominic Farolino authored
Remove ResourceResponse::{AppendRedirectResponses, RedirectResponses} and usages of them, because they are never called in the codebase. Change-Id: Id1c78939b8ab1fc5cdabc044f426fee09cecc1ba Reviewed-on: https://chromium-review.googlesource.com/c/1348738 Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Reviewed-by:Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#612553}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/f737d4bdb38d..75a486e0a03a git log f737d4bdb38d..75a486e0a03a --date=short --no-merges --format='%ad %ae %s' 2018-11-30 thestig@chromium.org Export defines to dependents of the "pdfium" target. 2018-11-29 thestig@chromium.org Bump up |kMaxObjectNumber|. 2018-11-29 thestig@chromium.org Make CBC_SymbolInfo::Lookup() return a const pointer. 2018-11-29 thestig@chromium.org Fix WideString() vs {} confusion in fxbarcode. Created with: gclient setdep -r src/third_party/pdfium@75a486e0a03a The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:910009,chromium:910198 TBR=dsinclair@chromium.org Change-Id: I84cd9d7ccecc0acb72b8e8fe91394b486affea8f Reviewed-on: https://chromium-review.googlesource.com/c/1356130Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612552}
-
Kent Tamura authored
Form-associated custom elements should support 'disabled' content attribute and <fieldset disabled> ancestors. It affects form submission, focusability, :disabled :enabled CSS selectors. Implementation: - HTMLElement::IsDisabledFormControl() is hooked to refer to ListedElement::IsActuallyDisabled(). This affects :disabled selector. - HTMLElement::MatchesEnabledPseudoClass() is hooked to support :enabled selector. - HTMLElement::AttributeChanged() handles 'disabled' attribute change. - HTMLElement::SupportsFocus() takes into account IsDisabledFormControl() - ElementInternals::AppendToFormData() aborts if IsDisabledFOrmControl(). - HTMLFieldSetElement should handle form-associated custom elements as well as HTMLFormControlElements. - Form-associated checks in ElementInternals is updated so that SetFormValue() and 'form' work in constructors. Note that 'disabledStateChangedCallback' will be implemented by a following CL. Bug: 905922 Bug: https://github.com/w3c/webcomponents/issues/187 Change-Id: If4a348b6f3fec5cd6faab6da04ac2de1c228caf7 Reviewed-on: https://chromium-review.googlesource.com/c/1354752Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#612551}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2913923e0dae..f7089e1b9227 Created with: gclient setdep -r src-internal@f7089e1b9227 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I7f9981d4589099b6e997c934720e4ee88514f964 Reviewed-on: https://chromium-review.googlesource.com/c/1356111Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612550}
-
Sam McNally authored
Bug: 909056 Change-Id: I6ed186ccb13a6373c8ed0ef559a30892cc89dd1c Reviewed-on: https://chromium-review.googlesource.com/c/1356169 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#612549}
-
Hayato Ito authored
While in working on the WIP CL, https://crrev.com/c/1350441, I've found that there is an edge case where fast flat tree traversal might return dirty result. So it would be safe to guard the feature of fast flat tree traversal by the runtime flag, and continue to develop under the flag. This CL is basically rewriting the following two CLs with runtime flag, - https://crrev.com/c/1337225 - https://crrev.com/c/1341744 and bring back old code which runs when the flag is disabled. BUG: 906494 Change-Id: I7a1940643925c1ef583cf55f1a79bfa0190ef40c Reviewed-on: https://chromium-review.googlesource.com/c/1356167Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#612548}
-
Pavel Feldman authored
Change-Id: I12c8ed2052b171ab91658fd9f734117f18fc826b Reviewed-on: https://chromium-review.googlesource.com/c/1354688Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#612547}
-
Meilin Wang authored
Add a new UMA histogram metrics to record the number of button clicks on Assistant UI (close, minimize, back, keyboard input toggle, voice input toggle, settings). Test: local compile and manually test. Change-Id: Ie3959d32b728f02aa6207740d56b3e21f87219c3 Reviewed-on: https://chromium-review.googlesource.com/c/1318837 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#612546}
-
Martin Kreichgauer authored
This is a refactoring followup to https://chromium-review.googlesource.com/c/chromium/src/+/1356223/. Change-Id: Ic92c73908914f49a38cae1192dcf054901018430 Reviewed-on: https://chromium-review.googlesource.com/c/1356134Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#612545}
-
Tom Anderson authored
R=thakis,dpranke Bug: 110002 Change-Id: I8da8e50930e973bd4bfac261571a66b7bad92778 Cq-Include-Trybots: luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng;luci.chromium.try:win_archive;luci.chromium.try:win_x64_archive;master.tryserver.chromium.android:android_archive_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/1351716 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#612544}
-
Matt Falkenhagen authored
A virtual test was already marked as flaky, but the root test itself is also flaky. Bug: 910452 Change-Id: I579264a4b6ef4bab235028d1bce46ceeded8481d TBR: mlamouri No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1355309Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#612543}
-
Maggie Chen authored
UMA GPU.DirectComposition.SwapChainCreationResult3 with different protected video types are created to record the pass/fail status for protected video swap chain creation. Bug: 906722 Change-Id: I558ec85ba75db030f86bd1a11c19410ff391d35c Reviewed-on: https://chromium-review.googlesource.com/c/1352053Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#612542}
-
Jan Wilken Dörrie authored
This change introduces a new Autofill section into the Chrome settings UI. This section contains "Passwords", "Payment Methods" and "Addresses and more", which prior to this change were part of the People section. In particular, this change: - Renames passwords_and_forms_page to autofill_page - Moves autofill entries from people_page.html to autofill_page.html - Adds a chrome://settings/autofill route for the new section, renaming the previously existing autofill route to chrome://settings/addresses - Removes the kAutofillHome feature flag and related conditionals - Removes a few now obsolete strings from settings_strings.grdp Bug: 907035, 854562 Change-Id: I479841db651c23813ab1ac1525f712d0ff9266c2 Reviewed-on: https://chromium-review.googlesource.com/c/1348039Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#612541}
-
Kent Tamura authored
Change-Id: Ib559e2a6cbc1e91c545f598050399bdd03053e19 Bug: 843412 Reviewed-on: https://chromium-review.googlesource.com/c/1354799 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#612540}
-
iOS Autoroller authored
TBR=smut Change-Id: Ie8510ff0de91ae4699d532e3657cfdfad4436de3 Reviewed-on: https://chromium-review.googlesource.com/c/1356031Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#612539}
-
Kurt Horimoto authored
FullscreenModel knows enough information to calculate these insets, so it makes sense for the calculation to occur there. Exposing the viewport insets in FullscreenController will allow chrome/ layer UI code to easily account for viewport adjustments. This API will be used to mask non-modal UIAlertController presentation. Bug: 674649 Change-Id: I469cb133ef5d27bffcd4de5070bd12820514740e Reviewed-on: https://chromium-review.googlesource.com/c/1339460 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#612538}
-
Sam McNally authored
Bug: 909056 Change-Id: If6daa91932bad99510e267ef91cc6808bceeccfa Reviewed-on: https://chromium-review.googlesource.com/c/1356162 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#612537}
-
Kent Tamura authored
TBR=hiroshige@chromium.org Bug: 910139 No-Try: true Change-Id: Id37fd777ff192446fd37a1eec58f298b82334ca8 Reviewed-on: https://chromium-review.googlesource.com/c/1356170 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#612536}
-
Sammie Quon authored
Overview will show all windows related by transient on the same thumbnail. Currently we will get blank spaces since the MRU list may contain two windows related by transient, and the transient ancestor or descendant of the most recent window will get transformed onto the transient related windows thumbnail, leaving a blank space. Introduce a function which removes all transient descendants from a given list if their transient root exists in the same list. First usage is overview but may need to extend to alt tab in future. Test: ash_unittests WindowUtilTest.RemoveTransientDescendants Bug: 844829 Change-Id: Ic2f9b476bc353b50a197be8fcf7bb3f2e3d44c49 Reviewed-on: https://chromium-review.googlesource.com/c/1355249 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#612535}
-
Klaus Weidner authored
BUG=809826 Change-Id: I41250680f22aacac2c1f193276d5d0e0beaa2a00 Reviewed-on: https://chromium-review.googlesource.com/c/1356228Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#612534}
-
Martin Kreichgauer authored
In [0], the U2F spec says to default the App ID to the originating site's Facet ID, which is (with some ambiguity) defined as the origin followed by a forward slash [1]. Firefox and cryptotoken, on the other hand, default the App ID to just the origin without any trailing path component. This change aligns Chrome's behavior for App IDs in WebAuthn with that of cryptotoken and Firefox. Also adds a check to ensure requests originating from cryptotoken do not have an empty App ID because they cannot be defaulted in any meaningful way. [0] https://fidoalliance.org/specs/fido-v2.0-id-20180227/fido-appid-and-facets-v2.0-id-20180227.html#determining-if-a-caller-s-facetid-is-authorized-for-an-appid [1] https://fidoalliance.org/specs/fido-v2.0-id-20180227/fido-appid-and-facets-v2.0-id-20180227.html#determining-the-facetid-of-a-calling-application Change-Id: Iab2c18f03fb92a150b00a56a1c39490e52188e0e Reviewed-on: https://chromium-review.googlesource.com/c/1356223 Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#612533}
-
Sam McNally authored
Bug: 909056 Change-Id: I0134351962bb3332f90f9430751241f0bf6c2eb5 Reviewed-on: https://chromium-review.googlesource.com/c/1355304Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#612532}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a8224556fcd5..2913923e0dae Created with: gclient setdep -r src-internal@2913923e0dae The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=mmoss@chromium.org Change-Id: Iceaec0eb03d97ed599a7d10e7cb91c00a15e71dd Reviewed-on: https://chromium-review.googlesource.com/c/1356127Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612531}
-
Sam McNally authored
Bug: 909056 Change-Id: Ic571f2d16d9d906bc176d34f539e53f57b2acbb3 Reviewed-on: https://chromium-review.googlesource.com/c/1355301Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#612530}
-
Giovanni Ortuño Urquidi authored
The ArrayTraits specialization for base::span with a specified size was considered to be missing. This caused accessors in mojom traits that returned a base::span with a specified size to fail to compile with: error: static_assert failed due to requirement 'internal::AlwaysFalse<span<const unsigned char, 6> >::value' "Cannot find the mojo::ArrayTraits specialization. Did you forget to include the corresponding header file?" Change-Id: I61ab07f2a1f74ea2eb5073b2776c995ce86b6255 Reviewed-on: https://chromium-review.googlesource.com/c/1356159 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#612529}
-
Noel Gordon authored
CL:1347648 removed google analytics from FilesApp so metrics_unittest, which was disabled on issue 842880, can now be deleted [1]. [1] The metrics_unittest test fixtures required a {analytics.Tracker}, which no longer exists in FilesApp. Bug: 847729, 860355 Change-Id: I0ec71ef837e747cd6647d7359546b9876d62dbc8 Reviewed-on: https://chromium-review.googlesource.com/c/1355303Reviewed-by:Stuart Langley <slangley@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#612528}
-
Robert Liao authored
From the available palette, this is the closest we can get to 4 without making the text actually look enabled. The contrast ratio of menus and textfields go from 2.61 to 3.68 and the contrast ratio of buttons go from 2.54 to 3.54. BUG=872524 TBR=pkasting@chromium.org Color change with accessibility approval. Change-Id: I3d5c917d5b4be193a78e950d021d97dceb4ab15d Reviewed-on: https://chromium-review.googlesource.com/c/1353947Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#612527}
-
Dale Curtis authored
This is part 4/4 CLs to move the <audio>/<video> elements off of a synchronous API that can lead to renderer hangs and premature audio renderer errors. This changes the AudioRendererMixerPool API to require an AudioRendererSink and OutputDeviceInfo when providing a mixer. AudioRendererMixerInputs are subsequently changed to use the new API. Likewise AudioRendererImpl also now uses the asynchronous API. To simplify the async process, AudioRendererMixerInputs will only setup correctly when OutputDeviceInfo has been requested ahead of time, since that's the pattern that AudioRendererImpl will use. This also moves the NullAudioSink setup from WebAudioSourceProvider over to the AudioRendererImpl. This causes WebAudio to be disconnected from the element, but if audio isn't work anyways, it shouldn't matter. BUG=905506 TEST=updated tests, compiles, runs. R=olka Change-Id: I4edf89bb1e20cc91191a6eb97a0e38b6aeba68f8 Reviewed-on: https://chromium-review.googlesource.com/c/1347795 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#612526}
-
Caleb Rouleau authored
This code doesn't do anything: The pageset_repeat option is used to set the default for the flag '--pageset-repeat'. The default is 1. If someone passes in --pageset-repeat=3 over the commandline then that will override this option either way. See https://goo.gl/JZ2yZQ. I am attempting to redesign this system a bit, and I noticed this code. Bug: 894254 Change-Id: I80da537180384f8b4b4ed25c87f9c9c8f814b2d5 Reviewed-on: https://chromium-review.googlesource.com/c/1356131Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#612525}
-
Sam McNally authored
Bug: 909056 Change-Id: I0ee41c828ba5c27c174dc51ade20d7b5fb6f0e80 Reviewed-on: https://chromium-review.googlesource.com/c/1351325Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#612524}
-
Giovanni Ortuño Urquidi authored
This reverts commit 92925c66. Reason for revert: WizardControllerDeviceState*Test timing out on linux-chromeos-dbg https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/9248 rowserTestBase received signal: Terminated. Backtrace: #0 0x7feb2e8b3fed base::debug::StackTrace::StackTrace() #1 0x7feb2e5addfa base::debug::StackTrace::StackTrace() #2 0x563fac6dc0f2 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7feafb349cb0 <unknown> #4 0x7feafb4116d3 epoll_wait #5 0x7feb2e96353f epoll_dispatch #6 0x7feb2e956cc5 event_base_loop #7 0x7feb2e9073c9 base::MessagePumpLibevent::Run() #8 0x7feb2e63fbe6 base::MessageLoopImpl::Run() #9 0x7feb2e6eb322 base::RunLoop::Run() #10 0x563fa6018304 chromeos::WizardControllerDeviceStateTest::WaitForAutoEnrollmentState() #11 0x563fa5ffeb8f chromeos::WizardControllerDeviceStateExplicitRequirementTest_ControlFlowForcedReEnrollment_Test::RunTestOnMainThread() Original change's description: > cros: Remove WizardInProcessBrowserTest > > The base class convoluted the inheritance structure and it is simpler to > directly derive from InProcessBrowserTest. > > Bug: 899777 > Change-Id: I04b8e4d48d0a28a8d4481891d5379456df32d0d6 > Reviewed-on: https://chromium-review.googlesource.com/c/1345244 > Commit-Queue: Jacob Dufault <jdufault@chromium.org> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612394} TBR=xiyuan@chromium.org,emaxx@chromium.org,jdufault@chromium.org Change-Id: I06cfea778c8246795a8bb8fdc9878812a1ab5d52 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 899777 Reviewed-on: https://chromium-review.googlesource.com/c/1356168Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#612523}
-
Luciano Pacheco authored
Fix |expandTreeItemInDirectoryTree| test helper function wait for folder to expand and set the focus on directory tree, this fixes the context menu tests that expects the focus in the directory tree to be able open context menu in the directory tree. Fix test |fileDisplayComputers| to pass the volume type because it was trying to expand Downloads volume and the wait for Downloads be expanded was failing, this test wants to expand Drive to be able to expand Computers within Drive. Change some selectors for Downloads to be compatible with MyFilesVolume flag enabled and disabled. Bug: 873539 Change-Id: I11ddd230746b8cc0804af818d9924146aa9b6da0 Reviewed-on: https://chromium-review.googlesource.com/c/1351977Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#612522}
-
Yoshifumi Inoue authored
This patch gets rid of unused function |PlainTextRangeTest::InsertHTMLElement()| for improving code health. Change-Id: I6f246b6a8f944acc3bfba119d08ad965edb5dd28 Reviewed-on: https://chromium-review.googlesource.com/c/1351320Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#612521}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 53095cfc. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I718561339218d07e74a35786d6d891194ccf654f Reviewed-on: https://chromium-review.googlesource.com/c/1356017 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612520}
-
Nate Fischer authored
This is necessary to remove downstream reflection which checks if the embedder is an instant app. We add the API upstream to avoid introducing another ApiHelperForO class downstream, since the base-layer one should be fine. R=paulmiller@chromium.org Bug: 910019 Test: None Change-Id: Ice29538bf15605e90bdff625fca4a85de2e4081e Reviewed-on: https://chromium-review.googlesource.com/c/1353997Reviewed-by:
Paul Miller <paulmiller@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#612519}
-
David Staessens authored
> This change splits up the test helpers target in separate encode, decode and > other helpers. Tests now only depend on what they actually need. This change > doesn't introduce any new code, but some things are moved to avoid weird > dependancies (such as encode helpers depending on frame mapper which depends on > decode helpers). > This change also moves code in the video_accelerator_unittest_helpers.h file > from the media to the media/test namespace. > > TEST=ran video/jpeg encode/decode tests on nocturne > > CQ-DEPEND=CL:1345670 > > BUG=879065,904337 > > Change-Id: I17704399c5724cbacc5611578e0dec22191e7a50 > Reviewed-on: https://chromium-review.googlesource.com/c/1345701 > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > Commit-Queue: David Staessens <dstaessens@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610757} BUG=879065 Change-Id: I3c478745acdecc7bcbea089a079603c0c2472cdd Reviewed-on: https://chromium-review.googlesource.com/c/1351193Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#612518}
-
Jesse McKenna authored
Bug: 889029 Change-Id: I87d82881660aaec994fab40543463bf6e61963ee Reviewed-on: https://chromium-review.googlesource.com/c/1354322 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#612517}
-
Giovanni Ortuño Urquidi authored
Use a array<uint8, 6> in the BluetoothSystem mojom and std::array<uint8_t, 6> in the C++ Bindings. Bug: 870192 Change-Id: I3467a770646b9ea2587a8cbc656c2ff510e0149c Reviewed-on: https://chromium-review.googlesource.com/c/1341291Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Ovidio Henriquez <odejesush@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#612516}
-