GitLab

The problem this fixes is, depending on the exact timing, a context would
receive a lost context callback (task 1), and would then post a task to recreate
the context (task 2). In parallel a task would be posted to signal the
GpuChannelHost that the channel is lost (task 3).

Because task 3 is posted from the IO thread, whereas task 2 is posted from
another thread (but they both are posted to the "main" thread), the race in
posting results in a race in execution, and task 2 may try to recreate a context
using a channel that doesn't know yet that it's non-functional, resulting in
failing to send the message and failing to create the context.

This patch changes the post order - task 3 is posted before task 1 - ensuring
task 2 is posted after task 3 (since task 2 is posted after task 1 executes).

BUG=129067


Review URL: https://chromiumcodereview.appspot.com/10837104

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149976 0039d316-1c4b-4281-b951-d872f2087c98

With this change, Chromoting will use chromoting-oauth.talkgadget.google.com
to talk to the talkgadget during the auth phase and will use
chromoting-client.talkgadget.google.com when the client is interacting with
the talkgadget.

Host interactions with the talkgadget will be controlled by policy and will be
handled in a separate cl.

BUG=132345
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10837106

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149975 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149974 0039d316-1c4b-4281-b951-d872f2087c98

Ensure proper locking around all uses of curr_input_buffer_ and input_buffers_.

TEST=by hand
BUG=none

Change-Id: I4cc92a1b0be47ce95bc0def580a88ac3a9f7deec


Review URL: https://chromiumcodereview.appspot.com/10853005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149973 0039d316-1c4b-4281-b951-d872f2087c98

TBR=

BUG=


Review URL: https://chromiumcodereview.appspot.com/10830169

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149972 0039d316-1c4b-4281-b951-d872f2087c98

touch.

BUG=128741
TEST=see bug
R=sadrul@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10823165

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149971 0039d316-1c4b-4281-b951-d872f2087c98

CID=104234,104664
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10824031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149970 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139401

Review URL: https://chromiumcodereview.appspot.com/10850036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149969 0039d316-1c4b-4281-b951-d872f2087c98

Also:
- The uninstall survey will use the metro Chrome local state if there is no desktop Chrome local state (although in the future we maybe want to aggregate them).
- Chrome inactivity for toast purposes is now based on the most-recently used of both desktop and metro Chrome.

BUG=125793
TEST=install chrome, make it the default, launch into metro at least once, quit, then uninstall and check the "also clear..." box.  Metro data dir should be gone.

Review URL: https://chromiumcodereview.appspot.com/10826144

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149968 0039d316-1c4b-4281-b951-d872f2087c98

Ensure that the leading headline text is shown on layout.
Selecting a [0,0] range moves the cursor to the leading text edge.
Textfield implementations then pan to show the cursor position.

Verified on local builds CrOS and Windows (with win/views textfields).

BUG=140273
TEST=Page info bubbles show the leading section text on Win and CrOS.

Review URL: https://chromiumcodereview.appspot.com/10826126

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149967 0039d316-1c4b-4281-b951-d872f2087c98

BUG=128816
TEST=


Review URL: https://chromiumcodereview.appspot.com/10792020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149965 0039d316-1c4b-4281-b951-d872f2087c98

Fixes chrome_page_zoom::Zoom(). First, correctly retrieves the default zoom level from the user Profile instead of from RendererPreferences. Second, correctly sets the default zoom level when content::PAGE_ZOOM_RESET is passed as the zoom parameter (previously, it just set the zoom to 100% no matter what the default zoom level was).

BUG=
TBR=jhawkins

Review URL: https://chromiumcodereview.appspot.com/10826136

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149964 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10830172

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149963 0039d316-1c4b-4281-b951-d872f2087c98

BUG=133109
R=robertshield
Review URL: https://chromiumcodereview.appspot.com/10823170

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149962 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139887


Review URL: https://chromiumcodereview.appspot.com/10836091

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149959 0039d316-1c4b-4281-b951-d872f2087c98

~GestureRecognizerImpl() was leaking memory.  Now it doesn't.  An unfortunate side effect of this leak was that GestureSequence objects hold a pointer to the GR's parent window (helper_) that is no longer valid after the dtor is called.  They also hold a callback timer, which fires for a long press...

This CL fixes the crash in issue 139420, but it doesn't fix the full bug.  Specifically, the popup menu is still not responding to touch.

BUG=139420

Review URL: https://chromiumcodereview.appspot.com/10826117

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149957 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=functional/browser.py
R=nirnimesh@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10852011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149956 0039d316-1c4b-4281-b951-d872f2087c98

Turned out the original design was not good, and the code won't be used.

BUG=140314
TEST=compile
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10828163

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149955 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/125937
TEST=existing
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149888
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149916
Review URL: https://chromiumcodereview.appspot.com/10831137

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149954 0039d316-1c4b-4281-b951-d872f2087c98

[UMA] Add " (Metro)" to the OS name for UMA uploads from Chrome running under Windows 8's Metro mode.

BUG=none


Review URL: https://chromiumcodereview.appspot.com/10834077

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149953 0039d316-1c4b-4281-b951-d872f2087c98

See related spec here: http://dvcs.w3.org/hg/html-media/raw-file/tip/encrypted-media/encrypted-media.html#algorithms-enrypted-block

If the AesDecryptor cannot find the decryption for the encrypted buffer, it returns a kNoKey.

In ProxyDecryptor, if the input cannot be decrypted due to kNoKey, the ProxyDecryptor will cache the encrypted buffers and callbacks and fire a needkey event. When some key is added (AddKey called) later, it will try to decrypt these buffers again. The callbacks will be fired on the same thread where Decrypt() was called originally.

BUG=125401, 125753
TEST=media_unittest, media layout_tests

Review URL: https://chromiumcodereview.appspot.com/10822026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149952 0039d316-1c4b-4281-b951-d872f2087c98

The biggest improvement here is that early termination of the callback series is accomplished by deleting the object.

BUG=138583

Review URL: https://chromiumcodereview.appspot.com/10830146

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149951 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140571
TEST=none
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10826155

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149950 0039d316-1c4b-4281-b951-d872f2087c98

This API is to clear all the local cache of Drive.

BUG=135197
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10837091

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149949 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140401


Review URL: https://chromiumcodereview.appspot.com/10827157

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149948 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139744


Review URL: https://chromiumcodereview.appspot.com/10825183

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149947 0039d316-1c4b-4281-b951-d872f2087c98

BUG=129499
TEST=see bug
Review URL: https://chromiumcodereview.appspot.com/10826108

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149941 0039d316-1c4b-4281-b951-d872f2087c98

Broke Win Aura compile

BUG=140336
TBR=jhawkins

Review URL: https://chromiumcodereview.appspot.com/10837089

TBR=bshe@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10829178

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149940 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140432

Review URL: https://chromiumcodereview.appspot.com/10853007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149937 0039d316-1c4b-4281-b951-d872f2087c98

Fixed unit test failures.

Original review CL: http://codereview.chromium.org/10843061

BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10830165

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149936 0039d316-1c4b-4281-b951-d872f2087c98

This is necessary to support the generation of the correct dblclick event sequence in WebKit.

Remove evil generic_x/generic_y from GestureEventDetails (some event types have data other than floats in that position of the union, this wasn't typesafe).

Adds missing double tap gesture recognizer unit tests.

This makes ET_GESTURE_DOUBLE_TAP pretty pointless now.  I've filed crbug.com/140382 to track removing it.

BUG=115486


Review URL: https://chromiumcodereview.appspot.com/10824158

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149935 0039d316-1c4b-4281-b951-d872f2087c98

Previously, 3 Chrome Endure tests would fail with buffer overrun errors
after several hours of runtime.  The problem was avoided by reducing the
runtime of the tests until the problem could be fixed.  Recent fixes to
pyauto's remote inspector module are likely to have fixed the problem,
so we no longer limit the runtime of the 3 Chrome Endure tests in question.

BUG=chromium-os:32357
TEST=Verified that the Gmail compose/discard test can run for the full 6
hours, even though it previously used to fail consistently after about
5 hours with a buffer overrun error.
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10825184

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149934 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149933 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r9342: (dschuff) Fix chrome integration bot and pnacl test bot for new download_toolchains usage
r9343: (mseaborn) Fix two register leaks in the trusted->untrusted context switch
r9344: (eaeltsin) download_toolchains.py: fix error in -c (calculate hashes) mode
r9345: (eaeltsin) Update x86 toolchains to 9338
r9346: (bradchen) Modify validator for better enuminst checking of call/jmp instructions.
r9347: (eaeltsin) Debug stub: enable single-thread GDB tests on Win
r9348: (eaeltsin) Debug stub: add port availability check to GDB tests
r9349: (jvoung) Update llvm rev to pull in bitcode linker change: http://codereview.chromium.org/10808021/
r9350: (binji) Add -idirafter flag to pnacl-driver.py
r9351: (bradnelson) Make defines work normally for untrusted.gypi
r9352: (halyavin) Make thread gdb test work on Windows.
r9353: (jvoung) Update pnacl toolchain to 9350.
r9354: (khim) Fix binutils enumeration test.
r9355: (khim) Add prefetch_modified instruction
r9356: (kschimpf) Fix the unconditional parse table for the ARM validator. Forbids generic
r9357: (jvoung) Turn on some ARM tests for var-arg + byval struct passing.
r9358: (kschimpf) Clean up code by removing unnecessary virtual destructors, and outlining
r9359: (robertm) Switch binutils in the pnacl TC to use shared libs as well.
r9360: (mcgrathr) Assume ARM hardware TLS in trusted code
r9361: (jvoung) Give the unpacked and CWS version of the pnacl extension an "all hosts"
r9362: (bradnelson) Exclude COMPONENT_BUILD from untrusted code.
r9363: (bradnelson) Fixing mismatch name for COMPONENT_BUILD define.
r9364: (robertm) Disable shared binutils build for pnacl toolchain on windows.
r9365: (bbudge) Update Chrome revision in NaCl DEPS.
r9367: (mseaborn) Thread suspension: Fix to report the correct return address from syscalls
r9368: (bbudge) Revert 9365 - Update Chrome revision in NaCl DEPS.
r9370: (jvoung) LOG an error if loading nexe with unsupported desc type

BUG=none
TEST=nacl_integration

Review URL: https://chromiumcodereview.appspot.com/10823160

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149932 0039d316-1c4b-4281-b951-d872f2087c98

This is necessary to write a unit test for https://bugs.webkit.org/show_bug.cgi?id=91685

BUG=none
TEST=none
R=tony
Review URL: https://chromiumcodereview.appspot.com/10821019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149931 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138673
Review URL: https://chromiumcodereview.appspot.com/10824157

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149930 0039d316-1c4b-4281-b951-d872f2087c98

**For now, gtest is marked experimental because the NaCl fix to gtest has not yet been upstreamed and DEPS'd into chrome**

* Test-only libraries and examples are build to the $(NACL_SDK_ROOT)testing/ directory.
* Added INCLUDES to .dsc file, platform-generic way to add an include directory.

BUG=none
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10824092

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149929 0039d316-1c4b-4281-b951-d872f2087c98

Currently, the DCHECK added by r148251 fires.

BUG=


Review URL: https://chromiumcodereview.appspot.com/10830164

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149928 0039d316-1c4b-4281-b951-d872f2087c98

TBR=lambroslambrou
BUG=
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10834163

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149927 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140571
TEST=CrOS official x-compiles pass.
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10831164

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149925 0039d316-1c4b-4281-b951-d872f2087c98