GitLab

Change-Id: I679eafa7719553792404d3c0549b5a7877d34c86
Reviewed-on: https://chromium-review.googlesource.com/791513Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520778}

For fragmentation, if we have a break token, the inline coordinate
may still be non-zero at the start of a next fragmentainer, if the
block we're fragmenting has an inline-start margin.
Furthermore, even the block coordinate may be non-zero, if
clearance has been applied.

R=cbiesinger@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I998eabbbc2434574aff2e63dc7114f942c3c92c3
Reviewed-on: https://chromium-review.googlesource.com/799970
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520777}

Bug: 
Change-Id: I73558b750b22f68f0048babd8e8960d851255753
Reviewed-on: https://chromium-review.googlesource.com/801661Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520776}

Previously SetSelection did DCHECK for null DataSrouce, which was wrong.
According to Wayland document, we should clears the clipboard when null
DataSource is passed.

Bug; 789831
Test: exo_unittests

Change-Id: I9bff52cb4259b2d02faeb6a6e32353d0e3da4f2c
Reviewed-on: https://chromium-review.googlesource.com/798815
Commit-Queue: Daichi Hirono <hirono@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520775}

https://pdfium.googlesource.com/pdfium.git/+log/fee910e6f81f..1980f10ff2b8

$ git log fee910e6f..1980f10ff --date=short --no-merges --format='%ad %ae %s'
2017-11-30 dsinclair Simplify XDP parsing code
2017-11-30 dsinclair Rename XFA_ATTRIBUTEENUM to XFA_AttributeEnum enum class
2017-11-30 dsinclair Move packet information into simple parser
2017-11-30 dsinclair Make parsers work off XFA_PacketType enum
2017-11-30 dsinclair A CXFA_Node can only be in one packet
2017-11-30 dsinclair Cleanup XFA packet code
2017-11-30 rharrison Rewrite lower level details of extracting text from page
2017-11-30 dsinclair Create CXFA_Node::NameToAttributeEnum
2017-11-30 dsinclair Move setting of XML content back to specific set methods
2017-11-30 dsinclair Rename GetAttributeEnumById to CXFA_Node::AttributeEnumToName
2017-11-30 dsinclair Remove the packets from attribute data.
2017-11-30 dsinclair Generate XFA node attribute information
2017-11-30 thestig Fix GBK2K-H CMap usage.
2017-11-30 thestig Use initializer list in CPDF_DataAvail ctor.
2017-11-30 thestig Relax checks in CFX_FaceCache::LoadGlyphPath().

Created with:
  roll-dep src/third_party/pdfium
BUG=654578,788864


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ic87fbd3ca5dbec12418aa60db84ae9e894431881
Reviewed-on: https://chromium-review.googlesource.com/802188
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520774}

It appears that on certain devices/variations of Android, the
implementation of Dialog.show() can end up with the same ViewRootImpl
being added to the WindowManager twice, resulting in a
BadTokenException.

This change adds a safer variant of shouldShowIncognitoIntent, the
aptly named shouldShowIncognitoIntentSafe, that returns a boolean to
indicate whether we successfully showed the alert dialog or not,
allowing us to log the error but handle the failure without crashing.

TBR=bshe@chromium.org

Bug: 782602
Change-Id: Iea5bd3b8f45c9824e34f581d208653a206b65c1e
Reviewed-on: https://chromium-review.googlesource.com/801257
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520773}

First, convert all enums and structs used by existing IPCs to mojo

Next CL will define the Host and Renderer interfaces.

Bug: 611938
Change-Id: I689b7399ad903197073ca15763d73d5bfff3207f
Reviewed-on: https://chromium-review.googlesource.com/790174Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520772}

This CL fixes two minor network config UI issues with
--network-settings-config:

* Adds "Connecting" to the dialog while connecting
* Sets 'AutoConnect' to true unless prohibited by policy
  (matches current UI behavior)

Bug: 380937
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5b58d9080f555431f23eba1ffa0c3806da2a8c63
Reviewed-on: https://chromium-review.googlesource.com/801917Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520771}

OPC pages seem to be expiring too early based on time-to-first-open
metric. It seems there's room for increasing its usefulness by
increasing the expiration time. This CL increases it to 30 days as this
longer time has been already considered safe while experiencing with
Prefetching of Offline Pages.

Bug: 740706
Change-Id: I954394c769e37ccb1afe3ed7dba2aa4cfa2c6864
Reviewed-on: https://chromium-review.googlesource.com/794750Reviewed-by: Dmitry Titov <dimich@chromium.org>
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520770}

This CL makes FirstRunFlowSequencer#checkIfFirstRunIsNecessary() return a
boolean instead of an intent. This is in preparation for making generating
the lightweight FRE intent be more expensive to generate.
FirstRunFlowSequencer#checkIfFirstRunIsNecessary() is called each time that
Chrome is launched and thus must be fast.

BUG=787939

Change-Id: I3dc0651d0796435475f18d3bbe93fce8613262ef
Reviewed-on: https://chromium-review.googlesource.com/798895Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520769}

Bug: internal b/68950223
Test: Build cast shell for android
Change-Id: Id4fcf1da324a7808158000532a1e0b48a05a6ad5
Reviewed-on: https://chromium-review.googlesource.com/789375Reviewed-by: Sergey Volk <servolk@chromium.org>
Commit-Queue: Sandeep Vijayasekar <sandv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520768}

Bug: None
Change-Id: I836fb3f2b238bc4d0e5cd1801452ee26027d4465
Reviewed-on: https://chromium-review.googlesource.com/800950Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520767}

Since https://chromium-review.googlesource.com/c/chromium/src/+/610080, if there is user input in form's fields, the fields without user input are ignored. It is not correct if the username is cached on page and the password typed by user.

In this CL, non-passwords field w/o user input are ignored iff there are non-password (!) fields with user input.

Bug: 784268
Change-Id: I4cdfc1af6d5d0823df95e5315934f3b4c25268fb
Reviewed-on: https://chromium-review.googlesource.com/797035
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520766}

Adds a feature that prevents Ranker from suppressing a tap gesture
that's considered a "second tap"; a tap near a previously suppressed
tap in both time and space.

Adds the ability for a heuristic to override ML suppression.

Also removes the old TapSuppression heuristic (which had some Second
Tap logic that was moved into the new SecondTapMlOverride class).
Obsoleted two histograms and a user action that are not longer needed.

Added an enum for ResultsSeen when passed as a boolean that uses the
expected ordering of 0=not seen, 1=seen.

BUG=789798

Change-Id: I6c58508b65b06712c9013731affeda6bb2f5a1c3
Reviewed-on: https://chromium-review.googlesource.com/798757Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520765}

Previously AudioOutputStreamFuchsia was setting PTS (presentation
timestamp) to 0 to indicate that PTS is not set. The media_client API
expects FUCHSIA_AUDIO_NO_TIMESTAMP (!= 0) in that case.

Bug: 737802
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I858d72044f283f5bce1d457f7358644d6b258aa3
Reviewed-on: https://chromium-review.googlesource.com/801481Reviewed-by: James Robinson <jamesr@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520764}

Add configuration for debug bots to chromium.webrtc.fyi JSON spec.

Bug: None
Change-Id: If8ec76c69c9ab365d42447520a8c02addbd2f6bf
Reviewed-on: https://chromium-review.googlesource.com/800177
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520763}

This is a desktop test, and it is disabled in https://codereview.chromium.org/1322033003
This test never runs on Android and IOS, so the added #if block is not used.

BUG=783576

Change-Id: I4c8e4ad0dd9b7dfaa0607a4961cbcabf16cc69cc
Reviewed-on: https://chromium-review.googlesource.com/801221Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520762}

The Blink Rename has made most uses of this-> unnecessary. The
relevant variable names no longer clash with the getters.

Bug: 789653
Change-Id: I039e502d4d46149a408be164671db2d45f214aae
Reviewed-on: https://chromium-review.googlesource.com/797455
Commit-Queue: Robert Hogan <robhogan@gmail.com>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520761}

This reverts commit 290a7939.

Reason for revert: Appears to be flaking on Windows, filed https://bugs.chromium.org/p/chromium/issues/detail?id=790806 for followup.

Original change's description:
> Convert UKM tests to express expectations over specific entries.
> 
> As part of the switch to using shared SourceIds, we will start
> associating the same URL with multiple SourceIds, and this will
> break all tests that currently use GetSourceForUrl and similar.
> 
> This avoids that by converting existing tests to use a new test
> recorder API which lets test express expectations over the entries
> they are recording.
> 
> Bug: 761524
> TBR=bmcquade
> 
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
> Change-Id: I43f0e09e026fa1373869ea5530427f88f6317a7a
> Reviewed-on: https://chromium-review.googlesource.com/774120
> Commit-Queue: Steven Holte <holte@chromium.org>
> Reviewed-by: Raymes Khoury <raymes@chromium.org>
> Reviewed-by: Erik Chen <erikchen@chromium.org>
> Reviewed-by: Peter Williamson <petewil@chromium.org>
> Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Mathieu Perreault <mathp@chromium.org>
> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
> Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Reviewed-by: vmpstr <vmpstr@chromium.org>
> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#520398}

TBR=avi@chromium.org,raymes@chromium.org,dalecurtis@chromium.org,vmpstr@chromium.org,petewil@chromium.org,vasilii@chromium.org,mathp@chromium.org,asvitkine@chromium.org,erikchen@chromium.org,hajimehoshi@chromium.org,mlamouri@chromium.org,tdresser@chromium.org,holte@chromium.org,bmcquade@chromium.org

Change-Id: I1b57d01ba3ff23637d3069e4e280f923fbc6f255
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 761524
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/802357Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520760}

This class handles the favicon, loading throbber, attention indicator,
and sad tab animations. The separation makes the Tab class cleaner and
allows this complex view to be re-used in the experimental tab class
in the future.

The network state enum was moved out from TabRendererData into its
own class. It was updated to an enum class with new-style naming.

Throbber stepping was moved to be entirely within the tab strip rather
than round-tripping through the TabStripController.

Change-Id: I063c0540e423ebbba3798a546ef58ef7616d629a
Reviewed-on: https://chromium-review.googlesource.com/792451Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520759}

path degrading

Bug: 774622
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I0c3841858a2f285414c0fc6cb8808ebea06a26b4
Reviewed-on: https://chromium-review.googlesource.com/794810
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520758}

Check if the context is still valid before creating a new API object
through the lazy accessor on the Chrome object.

Bug: 788088
Change-Id: If23e5648f2d240af0186a0289c14892268d271f2
Reviewed-on: https://chromium-review.googlesource.com/794015Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520757}

Scheduling these benchmarks on the perf waterfall. Turns out, even if
you know a benchmark won't be run on certain types of devices, you still
have to add them to the sharding map for those configurations.
Example: loading.mobile is sharded onto windows bots even though the tests are
specifically for mobile configurations. We should change the unscheduled benchmarks
check of perf_data_generator.py in the future. perf_data_generator seems to do the
right thing in not scheduling the benchmarks on configurations that don't run them.

BUG=chromium:789571

Change-Id: I1a7b785cc04f5b207d6a60d05b8177bc9e7df37c
Reviewed-on: https://chromium-review.googlesource.com/801580Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ashley Enstad <ashleymarie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520756}

Patch is removing keyword for void-returning function
and function returning primitive type

Bug: 
Change-Id: I4ad9df4c76aeea1e2c488facaa5f40e378f455d3
Reviewed-on: https://chromium-review.googlesource.com/802154
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520755}

Bug: 667560
Change-Id: Id865639bba4f220cbcd2b3f4cccbada75bd70f9a
Reviewed-on: https://chromium-review.googlesource.com/802091Reviewed-by: Will Chen <chenwilliam@chromium.org>
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520754}

The extra animation was introduced at crrev.com/c/619587, where at the time the
code was simulating a transition between the apps and extensions pages (which
were implemented as as a single page). This animation is no longer necessary and
in fact causes the problem when opening the in-page options dialog.

Bug: 776507
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ifd94b447b17673c04dfe227d1bd3d70bc87e3870
Reviewed-on: https://chromium-review.googlesource.com/802141Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520753}

This is a followup CL to https://crrev.com/c/799031
R=dpapad@chromium.org

Bug: NONE
Change-Id: Ief01ca527d7afd28c11c7bd07cdf527e175e1017
Reviewed-on: https://chromium-review.googlesource.com/801480
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520752}

This change is a targetted fix to send the VRViewerType metric from
multiple locations - both keeping the existing Android-only location
in VrShellGl, and adding a new location in OpenVRDevice.

The two metrics will trigger when we enter VR through the respective
platform-specific VR entry points. These two entrypoints will be
reconciled in a subsequent change that moves more VR metrics to a
cross-platform location.

BUG=782865

Change-Id: I17505eaa9bdefccb275dba0f5863a248c78c5968
Reviewed-on: https://chromium-review.googlesource.com/798028
Commit-Queue: Bill Orr <billorr@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520751}

Bug: 
Change-Id: I2a724e96e1fc180d1a17d358a3a3b0b602a9f154
Reviewed-on: https://chromium-review.googlesource.com/802139Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Joy Ming <jming@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520750}

https://chromium.googlesource.com/catapult.git/+log/c3fc7aa9c6bf..3ebc2fd9fe64

$ git log c3fc7aa9c..3ebc2fd9f --date=short --no-merges --format='%ad %ae %s'
2017-11-30 benjhayden Fix another bug in the simplified dropdown.
2017-11-30 eakuefner [Dashboard] Call DeduplicateDiagnostics in add_histograms

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I09c6a1080ef90586f7c3e25fabfb3aa813b7e9c4
Reviewed-on: https://chromium-review.googlesource.com/802088
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520749}

Users on a Captive Portal network without an internet connection may see
an error interstitial or experience timeouts. These metrics will help to
identify users in these scenarios.

Bug: 783315, 785548
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I911b6d9a57a017d2827ee0feeb07d8721acfa849
Reviewed-on: https://chromium-review.googlesource.com/783694
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520748}

Using wpt-import in Chromium 4e481ca7.

Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/6549

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
bjonesbe@adobe.com:
  external/wpt/css/css-shapes
jsbell@chromium.org:
  external/wpt/FileAPI

TBR=qyearsley

No-Export: true
Change-Id: Ib15a83ebc7c4ef9217fb6fbfa007edb0da20c6f6
Reviewed-on: https://chromium-review.googlesource.com/801454
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520747}

Bug: 729135
Change-Id: Ib8c512e675157d46c6009f53bc462c0d9511fbfe
Reviewed-on: https://chromium-review.googlesource.com/798641
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520746}

The previous code leaks the original handle.

BUG=788068

Change-Id: If6674b1b72b3a4b3e065e541c8ab2f4f20318298
Reviewed-on: https://chromium-review.googlesource.com/801234
Commit-Queue: Yuzhu Shen <yzshen@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520745}

This does not match the planned "VR." namespace structure, which won't
be fully defined in time for this release. Thus, use a name that is
consistent with the other existing histograms. All will be migrated soon
per https://crbug.com/790682.

This renames histograms added in https://crrev.com/c/795670.
Since they were just added so this should not affect data.

Change-Id: I60ec91ca7e6857653d9bee1d8029ea899169e56d
Reviewed-on: https://chromium-review.googlesource.com/801220
Commit-Queue: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Yash Malik <ymalik@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520744}

This was only flaky on iOS9 devices, but iOS9 is no longer supported.
I ran this test several hundred times locally on an iOS11 device with
no flake.

Bug: 780824
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I61b33e8cb3c0e4dab760b75361649fda56b4e6a1
Reviewed-on: https://chromium-review.googlesource.com/802082Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520743}

TBR: avi@chromium.org
Bug: 790751
Change-Id: Ic8f16dda831989e3d2af60a96da3b3fc4cb39974
Reviewed-on: https://chromium-review.googlesource.com/802177Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520742}

There were some base::File::Error values that had 1:1 equivalents
in net::Error which were not handled. Added more mappings.

Bug: None
Change-Id: I5487a3b02c1aa98427d35d34f2ea36ae772a09a3
Reviewed-on: https://chromium-review.googlesource.com/798052
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520741}

An edge case was recently introduced where a call into
NetworkStateHandler from NetworkConnectionStateChanged or
NetworkPropertiesUpdated might trigger EnsureCellularNetwork
which might delete the network passed to other observers.

We have also seen a handful of crashes in these observers
that may be caused by a different edge case.

This CL fixes the known issue and forces a crash for any
existing or future regressions.

Bug: 774430
Change-Id: I03ecf5ab46c572ee966be1f3c049c6d0906ac9e8
Reviewed-on: https://chromium-review.googlesource.com/798636Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520740}

This CL adds support for applying the [OriginTrialEnabled] attribute to
individual members of a dictionary in IDL. The resulting behaviour is
similar to the existing support for [RuntimeEnabled].

For [RuntimeEnabled], the existing behaviour is that a controlled member on a
dictionary will be ignored in the input to a method, unless the flag is enabled.
Specifically, the member value provided in JavaScript will not be copied to the
internal C++ data representation. This same behaviour has been implemented for
[OriginTrialEnabled].

The other change is to apply both [RuntimeEnabled] and [OriginTrialEnabled] to
dictionaries created internally, and output to JavaScript. Previously, all
dictionary members were returned, regardless if [RuntimeEnabled] was applied.
NOTE: This means that there could be some dictionary members that were always
visible to JavaScript, but will be no longer. e.g. MediaTrackSupportedConstraints:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/mediastream/MediaDevices.idl?type=cs&l=14

Bug: 788196
Change-Id: I110aa286fa4ff237b9716a6bce136093e25d9e4e
Reviewed-on: https://chromium-review.googlesource.com/794670Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Jason Chase <chasej@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520739}