- 09 Mar, 2018 40 commits
-
-
Christos Froussios authored
Focus should return to the item which caused the export modal dialog to be opened, once the dialog is done. Bug: 818619 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0e67519aef1821e751e7dd90bab42b4321408442 Reviewed-on: https://chromium-review.googlesource.com/950774Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#542097}
-
Kent Tamura authored
Bug: 770603 Change-Id: I6a161d1508353fe0fa2c17fb1580ce5385555353 Reviewed-on: https://chromium-review.googlesource.com/956655 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#542096}
-
Egor Pasko authored
This will make it easy to make a metric like request_start_time. I was going to make it based on netlog, but that appears more difficult (many events in netlog, etc). Also navigation events are generally useful for startup, and not very frequent. Bug: 760498 Change-Id: I7b9e9bb7efa0d4f2db729dafbb2b56e8ca1ec0ed Reviewed-on: https://chromium-review.googlesource.com/955632Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#542095}
-
Elly Fong-Jones authored
This change: 1) Factors out the scoped feature list pattern used in TestWithBrowserView to a separate helper class; 2) Changes TestWithBrowserView to use the new helper classe; 3) Makes BrowserViewTests use the helper class as well. Bug: 817408 Change-Id: I99c4ac591676d61936a75b38b0de22dbf27137da Reviewed-on: https://chromium-review.googlesource.com/955778Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#542094}
-
Yang Guo authored
Inline event handlers are compiled with v8::ScriptCompiler::CompileFunctionInContext. Previously, it compiles a wrapper script containing the event handler and executes this wrapper script to object the event handler function. This script execution is observable in debug stepping. An upcoming V8 change skips this wrapper script and creates the event handler function directly. This changes the debug stepping behavior. R=kozyatinskiy@chromium.org, machenbach@chromium.org Bug: v8:7172 Change-Id: I64ee3487f9ca893da305aa41dfc5d2e1e3da4ecc Reviewed-on: https://chromium-review.googlesource.com/955594Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#542093}
-
Daniel Bratell authored
PostMessage is a macro in Windows and depending on whether Windows headers have been included or not, PostMessage will either be treated as PostMessage or PostMessageW. We use a special header windows_types.h to ensure that the macro is always defined so that there will be no compilation or linking issues missing either PostMessage or PostMessageW objects. Bug: 772713,813749 TBR=leon.han@intel.com Change-Id: I0012774f347ef2e257bc87b4492f58c7be464f78 Reviewed-on: https://chromium-review.googlesource.com/957028Reviewed-by:
Daniel Bratell <bratell@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#542092}
-
Nico Weber authored
C++ disallows implicit conversion of function pointer types (such as returned by GetProcAddress()) to void*. MSVC allows it, and clang-cl allows it with a warning. This fixes said warning by adding an explicit cast. It seems conceptually nicer to have GetFunctionPointerFromNativeLibrary() return a fuction pointer type, but for now let's just suppress the warning. Bug: 550065 Change-Id: Ifc633ca5691c2c297db6c646c655b9a85815170a Reviewed-on: https://chromium-review.googlesource.com/955906 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#542091}
-
Balazs Engedy authored
This is to avoid duplicating the code in each unit test to implement a call back receiver for each combination of argument types. Bug: 785955 Change-Id: Ic4cd0502fafc666682c29a657e25cab91091db44 Reviewed-on: https://chromium-review.googlesource.com/955566 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#542090}
-
Michael Warres authored
Remove reference to headers and crypto stream from the public API of QuicWriteBlockedList in preparation for removing these from the implementation. Merge internal change: 187900607 https://chromium-review.googlesource.com/c/chromium/src/+/956023 Move logic for registering and unregistering QUIC streams with the write blocked list from QuicSpdyStream to QuicStream. Protected by FLAGS_quic_reloadable_flag_quic_register_streams_early Merge internal change: 187702688 https://chromium-review.googlesource.com/c/chromium/src/+/956022 Refactor the code submitted in cl/187642899. Protected by the same flag, FLAGS_quic_reloadable_flag_quic_fix_write_out_of_order_queued_packet_crash. Merge internal change: 187666679 https://chromium-review.googlesource.com/c/chromium/src/+/955724 In QuicConnection, Fixed a use-after-free when writing an out-of-order queued packet. Protected by FLAGS_quic_reloadable_flag_quic_fix_write_out_of_order_queued_packet_crash. Merge internal change: 187642899 https://chromium-review.googlesource.com/c/chromium/src/+/955779 In QUIC, enable fast path to QuicStreamSendBuffer::OnStreamDataAcked. Protected by FLAGS_quic_reloadable_flag_quic_fast_path_on_stream_data_acked. Merge internal change: 187609757 https://chromium-review.googlesource.com/c/chromium/src/+/955902 Make QuicConnection::MaxPacingRate() method virtual. Merge internal change: 187556600 https://chromium-review.googlesource.com/c/chromium/src/+/955777 Make QuicConnection::set_per_packet_options() and QuicClientEpollNetworkHelper::CleanUpUDPSocket() methods public. Merge internal change: 187536653 https://chromium-review.googlesource.com/c/chromium/src/+/955723 Add IETF Path Challenge/Response framer/deframer Merge internal change: 187484592 https://chromium-review.googlesource.com/c/chromium/src/+/954783 Change some vector::push_back into vector::emplace_back to save a temporary object. Not flag protected. Merge internal change: 187482582 https://chromium-review.googlesource.com/c/chromium/src/+/954842 Add a method to the QUIC crypto framer to allow processing truncated messages, which should only be used for debugging. Merge internal change: 187430236 https://chromium-review.googlesource.com/c/chromium/src/+/954724 Pass full QUIC version into the connection debug visitor. Merge internal change: 187423336 https://chromium-review.googlesource.com/c/chromium/src/+/954723 Remove an always-true if condition in QuicConnection::WritePacket. Not flag protected. Merge internal change: 187406845 https://chromium-review.googlesource.com/c/chromium/src/+/954722 Add IETF-Format QUIC Padding Frame support. Merge internal change: 187378942 https://chromium-review.googlesource.com/c/chromium/src/+/954123 Remove redundant get() call on smart pointer. Merge internal change: 187276945 https://chromium-review.googlesource.com/c/chromium/src/+/953306 Deprecate FLAGS_quic_reloadable_flag_quic_inspect_chlo_tags Merge internal change: 187172163 https://chromium-review.googlesource.com/c/chromium/src/+/953802 Add QuicSentPacketManager.initial_congestion_window() method. Merge internal change: 187108946 https://chromium-review.googlesource.com/c/chromium/src/+/953384 In QuicDispatcher, make client_address available in stateless rejector's callback(i.e. QuicDispatcher::OnStatelessRejectorProcessDone). Merge internal change: 187095181 https://chromium-review.googlesource.com/c/chromium/src/+/952487 Move various defintions of kDefaultPriority in QUIC code to QuicStream. Merge internal change: 187082280 https://chromium-review.googlesource.com/c/chromium/src/+/951760 Move priority handling from QuicSpdyStream to QuicStream and from QuicSpdySession to QuicSession. Merge internal change: 187047085 https://chromium-review.googlesource.com/c/chromium/src/+/952485 Fix stale comment. Merge internal change: 187027369 https://chromium-review.googlesource.com/c/chromium/src/+/951759 R=rch@chromium.org Change-Id: I3846cf618363b6e93aaa5aae1fde46fd4300f675 Reviewed-on: https://chromium-review.googlesource.com/956843Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Michael Warres <mpw@chromium.org> Cr-Commit-Position: refs/heads/master@{#542089}
-
https://chromium.googlesource.com/catapult.git/+log/78d89b42c293..8f3d6b77acab $ git log 78d89b42c..8f3d6b77a --date=short --no-merges --format='%ad %ae %s' 2018-03-07 perezju [Battor] Ignore battor/bin/{linux,mac,win} 2018-03-08 perezju [Telemetry] Add Android_Go disable condition Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I1a72fce14063a42886f6c85fde6a9ac0f2eede66 Reviewed-on: https://chromium-review.googlesource.com/956112 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542088}
-
Steve Kobes authored
Hiding browser controls can make the layout viewport larger than the document's layout overflow. Bottom-anchored fixed-position elements were incorrectly clipped with RLS, because the scrolling contents layer was sized to match the overflow rect. Bug: 817714 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I89c3488370e1bce02a7ed523e930ab9d634f60ac Reviewed-on: https://chromium-review.googlesource.com/954016Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#542087}
-
Florent Castelli authored
Add the getParameters() function forwarding all the values that are implemented in WebRTC to the Javascript layer. Other properties that exist will be loaded for future use, but not passed to the Javascript layer. Currently behind RuntimeEnabled=RTCRtpSenderParameters. Bug: 803494 Change-Id: Icd1c1ea58fd1ad3d50a46e97db3026837381c7b6 Reviewed-on: https://chromium-review.googlesource.com/919082Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/master@{#542086}
-
Friedrich Horschig authored
These are the first steps to port the http-state cookie tests from https://github.com/abarth/http-state/tree/master/tests to the external/wpt/ directory. Accessing <server>/cookies/http-state/all-tests.html will run all tests in cookies/http-state/resources/test-files/. This ensures that tests stay isolated, ignore set cookies and clean up cookies after themselves. By accessing the server directly, single tests can be debugged. e.g. to run test file 0005 in isolation, access this URL: <server>/cookies/http-state/resources/cookie-setter.py?debug=0005 Change-Id: I1fceccf0bc5d080d024998451abd027142d6a16a Reviewed-on: https://chromium-review.googlesource.com/807988 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#542085}
-
Vasilii Sukhanov authored
The code is executed once per profile. As it was introduced one year ago, it's reasonable to assume that most users don't need it anymore. It's a manual revert of https://codereview.chromium.org/2714543006/ Bug: 687968 Change-Id: Ic9ef109c27ccccadc8b3fd75d156dec818cfc83c Reviewed-on: https://chromium-review.googlesource.com/955568 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
Takashi Toyoshima authored
Since it looks working fine on local machines, and related code base may be changed day by day for loading and PlzNavigate efforts, let me just re-enable the test to see what happens. Bug: 798121 Change-Id: I07e88b163818019ec340b3aff508191852b7d440 TBR: maxmorin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/956830Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#542083}
-
Sylvain Defresne authored
The method is no longer called nor overridden, so it can safely be removed (it was deprecated). Bug: none Change-Id: I31770bfd26e33977a4007ae50cf423196c914ebe Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/951692 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#542082}
-
Gauthier Ambard authored
This CL changes the toolbar button used to access the stack view. The button used for the clean toolbar as some specific effects which don't work on the non-adaptive toolbar. Bug: 820096 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If0bdc61050eebd1d4cb3d5230aa828444076649c Reviewed-on: https://chromium-review.googlesource.com/955573Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#542081}
-
Morten Stenshorne authored
That might cause incorrect detection of overflow, since the height of the block isn't pixel-snapped. Bug: 818873 Change-Id: I864be9dfedf6f008fe19ce02088ac6488ec274d0 Reviewed-on: https://chromium-review.googlesource.com/954022Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#542080}
-
Thomas Tangl authored
This CL changes the run type in DiceAccountsMenu to use a native menu on Mac and removes the definition of the run type ALWAYS_VIEWS as it is not used anymore. Bug: 813805 Change-Id: Ia97cba48de31bf4ed74b71982cfe8e3383a909eb Reviewed-on: https://chromium-review.googlesource.com/956463Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#542079}
-
Ulan Degenbaev authored
The heap snapshot now uses the EmbedderGraph API. Bug: 749490 Change-Id: I9d18bdf623d8b2dd9ddee8799c61b08787592445 Reviewed-on: https://chromium-review.googlesource.com/948486 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 894211b4. With Chromium commits locally applied on WPT: 14350ac7 "[PE] Don't truncate table cell's padding" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13494 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: domenic@chromium.org, ricea@chromium.org: external/wpt/streams kojii@chromium.org: external/wpt/css/css-writing-modes TBR=qyearsley No-Export: true Change-Id: I703e0430b99222ba33803d24ad68ef87ef2477cb Reviewed-on: https://chromium-review.googlesource.com/956568 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#542077}
-
https://skia.googlesource.com/skia.git/+log/dc0b12ec7a2d..66abdf665896 $ git log dc0b12ec7..66abdf665 --date=short --no-merges --format='%ad %ae %s' 2018-03-09 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 80964f97e..e8a93c6ed (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I2956d1cbd79079d6194538f78f4b87441e32e2a9 Reviewed-on: https://chromium-review.googlesource.com/955972Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542076}
-
Fredrik Söderquist authored
In preparation for adding an SVGResource subclass for external resources this splits out a LocalSVGResource subclass from SVGResource and renames usages appropriately. This is mostly to eliminate "noise" from a follow- up CL. Bug: 769774 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I479ca0445e4eba5f0ba2b727460dfcda776347b8 Reviewed-on: https://chromium-review.googlesource.com/955463Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#542075}
-
Giovanni Ortuño Urquidi authored
Before this patch, tests were using the default EmbeddedTestServer, which only served HTTP pages. Desktop PWAs can only be HTTPS so tests should use HTTPS sites. Furthermore, Desktop PWAs will soon block mixed content, so test pages need to be served over HTTPS. Change-Id: I4af6850bdd851917fdeb2bf9d55fa62b6d3beff7 Reviewed-on: https://chromium-review.googlesource.com/926022 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#542074}
-
Zhuoyu Qian authored
This CL introduces canExecute() member function in |EditorInternalCommand| to replace |allowExecutionWhenDisabled|. |allowExecutionWhenDisabled| is for clipboard commands only. This CL is first step of [1], next step will replace CanExecuteWhenDisabled() with Can{Read/Write}Clipboard(). [1]: http://crrev.com/c/954773 Bug: Signed-off-by:Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: I696409a1496e6c3fc2b325879ec07c1932f062b0 Reviewed-on: https://chromium-review.googlesource.com/954562Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#542073}
-
Jose Dapena Paz authored
Bug: 819294 Change-Id: I8b7c0cc30161332e396a0a4ac142188cb5cf1ad1 Reviewed-on: https://chromium-review.googlesource.com/944411Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#542072}
-
tzik authored
This updates //printing to use base::OnceCallback instead of legacy base::Callback. No intended functional change is included. This reduces the number of 'base::Bind' in //printing from 2 to 0 as tracked at http://goo.gl/LUVhDj Bug: 714018 Change-Id: Ic5ba394447c20b444d238511473bbfc7abbc9669 Reviewed-on: https://chromium-review.googlesource.com/954883Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#542071}
-
Tetsui Ohkubo authored
According to UX spec, UnifiedSystemTray has a circular user avatar in the top shortcuts view. FYI, in UnifiedSystemTray, the features in UserView and TilesDefaultView (in old SystemTray) are combined into TopShortcutsView. Screenshot: http://screen/WB4k9Oinwde Design doc: go/cros-qs-restyling BUG=811660 Change-Id: I118162e0d202f040a586e256fa37747fbfb5a0c7 Reviewed-on: https://chromium-review.googlesource.com/942503 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#542070}
-
Gauthier Ambard authored
This CL changes the way the layout guides of the toolbar's buttons are constrained to the button, using the new API. Bug: none Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I132991628ce923ca9352b34d7631bd78d3e7dae5 Reviewed-on: https://chromium-review.googlesource.com/955203Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#542069}
-
Xiaohan Wang authored
Bug: 801245 TBR: dalecurtis@chromium.org Change-Id: I05658d14ca57daf24b012f047c3d3df13c3037a7 Reviewed-on: https://chromium-review.googlesource.com/954336 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#542068}
-
Tetsui Ohkubo authored
This CL adds a feature pod button for Bluetooth. By clicking on the button, it will show bluetooth detailed view of the existing SystemTray. This behavior is described as Development Stage 1 in the design doc: go/cros-qs-restyling TEST=manual BUG=813499 Change-Id: I130301b9a25d31a520b1a0bb8f78839aa4b91b73 Reviewed-on: https://chromium-review.googlesource.com/948164 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
-
Kent Tamura authored
Bug: 770603 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I6cb03bc3e58a38070def0fb8e927e2d7036484b5 Reviewed-on: https://chromium-review.googlesource.com/956792Reviewed-by:
-
Max Morin authored
This reverts commit a7c1c185. Reason for revert: Clusterfuzz reports... Original change's description: > Fix yet another AudioOutputDevice crash. > > Bug is identical to the last :/. No idea why it's much more frequent with mojo, > possibly a race is likely to happen when destroying a frame: |callback_| is > destroyed due to frame being destroyed, and authorization is failed for the > same reason. With the per process message filter, authorization wouldn't fail > due to the frame being destructed. > > Bug: 819277 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: Ic17dc96d2c83a08732b43094bac2f2c3fa7035ad > Reviewed-on: https://chromium-review.googlesource.com/951774 > Commit-Queue: Max Morin <maxmorin@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#541801} TBR=dalecurtis@chromium.org,maxmorin@chromium.org Change-Id: I9bf3d357bd09ebd1fa60b4324d204da44b23b72a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 819277,820276,820341 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/957042Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#542065}
-
arthursonzogni authored
The two tests following tests are potentially flaky: * WebViewTests/WebViewTest.Shim_TestNestedSubframes/* * WebViewTests/WebViewTest.Shim_TestNestedCrossOriginSubframes/* Why are they flaky? webview.onloadstop event handler is defined. Once called, it causes a new navigation to happens in the webview. The navigation causes the handler to be called again. This is a loop. It wasn't expected to behave that way. If the nested iframe navigation happens quickly enough, the two time nested iframe navigation might not complete quickly enough and the postMessage() may not happens. The race condition may be unfavourable several time in a row and causes a test timeout. FYI: 1) This test was disabled on Mac. Maybe this CL fixes the issue? It should be verified on a device with this OS. 2) This test is flakier after enabling NavigationMojoResponse and applying this CL: https://chromium-review.googlesource.com/c/chromium/src/+/951243/6 That's understandable, this patch allows navigation to commit faster. Bug: 674904, 705744 Change-Id: Icf2debd095519221ff085cb3bacbc058c1806e86 Reviewed-on: https://chromium-review.googlesource.com/955585Reviewed-by:Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#542064}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 770603 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I627aa5218ad008854012831ec49e484dfdf72920 Reviewed-on: https://chromium-review.googlesource.com/956902Reviewed-by:
-
Oleh Prypin authored
Instead build just the targets in chromium.webrtc. Bonus: remove obsolete tryjob definitions. Bug: chromium:820041, chromium:808111 TBR: machenbach@chromium.org No-Try: True Change-Id: I133593a4e51a5e1dac4d0e24d21601cd553784a0 Reviewed-on: https://chromium-review.googlesource.com/956043Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Oleh Prypin <oprypin@chromium.org> Cr-Commit-Position: refs/heads/master@{#542062}
-
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Idb76e054c5689db7fb83ee4c308f30e5b6eae136 Reviewed-on: https://chromium-review.googlesource.com/956963 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542061}
-
Emily Hanley authored
Also updating what tests run on each shard to help debug the failing tests. Bug: 758632 Change-Id: Ib0eb60f0b9ae7e3a2cd19ae8c1f8183d4d0b7d81 Reviewed-on: https://chromium-review.googlesource.com/955676Reviewed-by:
Ashley Enstad <ashleymarie@chromium.org> Commit-Queue: Ashley Enstad <ashleymarie@chromium.org> Cr-Commit-Position: refs/heads/master@{#542060}
-
Chih-Yu Huang authored
Originally, VEA calls the flush callback before notifying the client that the last frame buffer is ready. This CL changed the calling order to ensure all frames buffer are sent back to the client before VEA notifies the flush is completed. BUG=b:71882314 TEST=run video_encode_accelerator_unittest at device Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I235411734dff3200df3b36b1f14211fbd0d41c8f Reviewed-on: https://chromium-review.googlesource.com/956653Reviewed-by:
Pawel Osciak <posciak@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#542059}
-
Tatsuhisa Yamaguchi authored
Bug: 795167 Change-Id: I4223e26d23885c350337aefb8abd991427435a05 Reviewed-on: https://chromium-review.googlesource.com/828184 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#542058}
-
