GitLab

The console spec says that the %o specifier should produce
"optimally useful formatting" as opposed to the %O
"generic JavaScript object formatting". To make this distinction clearer
and align log() to %o and dir() to %O, this CL will format
arrays/objects with previews when using %o.

Please see crbug for screenshot.

Bug: 751850
Change-Id: I927e1c34667f1d11bc13e98a86d38419b7012940
Reviewed-on: https://chromium-review.googlesource.com/607576
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505333}

We generate data URL for ARC intent handler's icon in 16x16 pixel PNG format.
It is not good enough when the device scale factor is bigger than 1.
We should apply the scale factor when generating PNG data.
The source bitmap which is passed from Android system is big enough.
(48x48 pixels for 1x scale factor, and 96x96 pixels for 2x scale factor.)

Bug: 751362
Change-Id: I370bf32b2c0f4e9e19dc267b03965663546a03bf
Reviewed-on: https://chromium-review.googlesource.com/688524
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Kazuhiro Inaba <kinaba@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505332}

Instead it always selects angle, like if --use-gl=angle was set
which makes --use-gl=egl useless.

My understanding is that --use-gl=egl is supposed to select
the defaults libEGL.so.1/libGLESv2.so.2 available on the system.

Regression introduced by 06a905b5
"Fixed fallback to software for tests"
https://chromium-review.googlesource.com/517912

BUG=726075

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Idf3cfb1b5480a112f73b7e7c20f4d4ade1cc2a51
Reviewed-on: https://chromium-review.googlesource.com/690074Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Julien Isorce <julien.isorce@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505331}

https://skia.googlesource.com/skia.git/+log/8b059bd946d9..1ee6631ad3a8

$ git log 8b059bd94..1ee6631ad --date=short --no-merges --format='%ad %ae %s'
2017-09-29 angle-deps-roller Roll skia/third_party/externals/angle2/ db3422764..a9c60e9f9 (1 commit)
2017-09-28 angle-deps-roller Roll skia/third_party/externals/angle2/ c71ea661e..db3422764 (5 commits)

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=jvanverth@chromium.org

Change-Id: I32fcc84538d7fee8649c2200dcd66c903d8eec6b
Reviewed-on: https://chromium-review.googlesource.com/691440Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505330}

TBR=dpapad@chromium.org

Bug: 770047
Change-Id: Iced8b09b937f2a6b202bea47b99dcf6fbe137749
Reviewed-on: https://chromium-review.googlesource.com/691694Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505329}

This is a followup to https://chromium-
review.googlesource.com/c/chromium/src/+/601790. There I delete the
provider code from BUILD.gn as well as its tests, but did not delete the
provider files themselves.

This CL just deletes provider's .h and .cc. I've checked and everything
else seems to be deleted in the previous CL.

AFAIK this code was always behind a feature, which was not enabled in
M61. It was not used (removed from BUILD.gn) in M62.

Bug: 770059
Change-Id: I07939d75157200c0dbe0374bc18d36f4de4f7e49
Reviewed-on: https://chromium-review.googlesource.com/691657Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505328}

This reverts commit 206bdc85.

Reason for revert:

Several paint-related tests have begun crashing on "Linux Trusty (dbg)" after landing this patch, flakily hitting a CHECK in
`PaintController.cpp` (see the log in 
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Trusty__dbg_/5565/layout-test-results/paint/invalidation/video-mute-repaint-stderr.txt).
It looks like this kind of crash happened while landing the patch as
well, at least on https://storage.googleapis.com/chromium-layout-test-archives/linux_layout_tests_slimming_paint_v2/6682/layout-test-results/results.html).
I'll revert it.


Original change's description:
> Fix false-positives of under-invalidation checking in layout tests
> 
> In the following few cases we intentionally allow under-invalidations in
> cached subsequences:
> - offscreen image animation
> - media buffered range
> 
> We intentionally don't update each time the contents change to improve
> performance or avoid complex implementation of real time change
> notification.
> 
> Now allow cache skipping in cached subsequences.
> 
> Enable under-invalidation checking for tests that would have reported
> under-invalidation with the checking enabled.
> 
> This also helps clusterfuzz not to trigger under-invaldiation checking
> failures when it creates a test for the above cases.
> 
> Bug: 769729
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: I2149e9d2304dbad5d7486c822d5452c5dba237fe
> Reviewed-on: https://chromium-review.googlesource.com/690851
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#505281}

TBR=wangxianzhu@chromium.org,chrishtr@chromium.org

Change-Id: Id0ddbc90d9cf4436fe10dc81485d9f13edef6f1a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 769729, 769879
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/691814Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505327}

Change-Id: I8f8c232c5916da49dff2b2c1251f9c48f598a31a
Reviewed-on: https://chromium-review.googlesource.com/691157
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505326}

After fixed crbug.com/736697 , we have to record PWA's WPR again with
new perf benchmarks.
Suumo did not registered service worker in previons url, so also
Replaced it by top page to check service worker performance before
recording wpr-go.
Also removed some urls which are not used in loading.mobile .

Bug: 765058
Change-Id: Iaf7da788f7a57078ca9475b6283b338f3facb7a3
Reviewed-on: https://chromium-review.googlesource.com/688995
Commit-Queue: Yuki Yamada <yukiy@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505325}

This patch adds UseFirstLineStyle() to NGConstraintSpace, and
removes NGBaselineAlgorithmType::kAtomicInlineForFirstLine.

The distinction between kAtomicInline and kAtomicInlineForFirstLine
are not available in many cases, and these values are exclusive.
Having UseFirstLineStyle() in NGConstraintSpace is more reasonable.

Bug: 636993
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I19e4124e82b86ba87318f6a08aa47e958dbf53ad
Reviewed-on: https://chromium-review.googlesource.com/688259
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505324}

Per-site exceptions for Protected Content / Protected Media Identifier only
exists for CrOS / Android, but r503968 changed the Javascript internally so that
it was defined on all platforms, and updated Site Details to only use it on
CrOS.

This introduced a crash when Chrome tries to get the exceptions for protected
content on non-CrOS in All Sites, so fix by updating All Sites to check for CrOS
before using it.

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5c209cedfb6efbaee327a97d448ea9deab737b2d
Bug: 769242
Reviewed-on: https://chromium-review.googlesource.com/688914
Commit-Queue: Patti <patricialor@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505323}

Since permissions are only shown if they're non-factory-default, show them first
(over showing certificate and cookie information, which are always shown).

Bug: 535074, 718553
Change-Id: I842e684d43c1f7655f8952b07e590affcbc36a39
Reviewed-on: https://chromium-review.googlesource.com/686199
Commit-Queue: Patti <patricialor@chromium.org>
Reviewed-by: Lucas Garron <lgarron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505322}

This reverts commit 4981992a.

Reason for revert: 

It appears that this patch caused `browser_test` failures on 'Linux
ChromiumOS Tests (dbg)', starting at [build 30664][1]. The [errors][2]
read `[8882:8882:0928/213724.538975:ERROR:CONSOLE(48)] "Uncaught TypeError: Cannot read property '_createRipple' of undefined", source: chrome://resources/cr_elements/cr_link_row/cr_link_row.js (48)`, which
this patch alters.

[1]: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/30664
[2]: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chromiumos%2FLinux_ChromiumOS_Tests__dbg__1_%2F30664%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FPasswordsAndFormsBrowserTest.uiTests%2F0

Original change's description:
> MD Settings: Migrate settings-toggle-button to use cr-toggle.
> 
> Bug: 768073
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: If3efa3993d9ff75cce73eb48d583adb0ea5db543
> Reviewed-on: https://chromium-review.googlesource.com/686041
> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
> Reviewed-by: Scott Chen <scottchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#505269}

TBR=dpapad@chromium.org,scottchen@chromium.org

Change-Id: I6e7e68d3a2989898df9aac3364de489fd5b05cd3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 768073
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/691794Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505321}

They're using a condition now, which has same effect.

Bug: 570091
Change-Id: Ia47a6f55e3d757990a43ce15e7fd326f1f25e06b
Reviewed-on: https://chromium-review.googlesource.com/690346Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505320}

Bug: 759765
Change-Id: I9f5e3de6493d878e1913298f1b65a0b3ceac85ae
Reviewed-on: https://chromium-review.googlesource.com/647372Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505319}

 - Replacing base::MakeUnique|WTF::MakeUnique with std::make_unique
 - Replacing PtrUtil.h with <memory>

Bug: 755727
Change-Id: I7199bc382a3f9e81abaad7fc24b33d730d6c4909
Reviewed-on: https://chromium-review.googlesource.com/689816
Commit-Queue: Kent Tamura <tkent@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505318}

Synchronize two ShelfModels between Ash and Chrome by default.
Can be disabled for debugging/testing in classic ash:
  --ash-disable-shelf-model-synchronization
  "Disable shelf model synchronization" (in about:flags)

Bug: 557406
Test: No Chrome OS shelf behavior changes; please file any bugs!
Change-Id: I47c7c7b6c9d38f9aaa4ea89a1dc8ce333e49f8bd
Reviewed-on: https://chromium-review.googlesource.com/682340
Commit-Queue: Michael Wasserman <msw@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505317}

Add support for painting emphasis marks for LayoutNG.

Bug: 714962
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I0690bb284fa227408fa047adc3914e3c236ffc44
Reviewed-on: https://chromium-review.googlesource.com/691474Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505316}

This reverts commit 44bf467c.

Reason for revert: Asset issue.

Original change's description:
> Update lock screen submit button icon
> 
> Changed the asset size from 24 to 20. Others remain the same.
> 
> Bug: NONE
> Change-Id: I1da0b131ca29416089e657ac706a8100812ea644
> Reviewed-on: https://chromium-review.googlesource.com/688028
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#504894}

TBR=oshima@chromium.org,wzang@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: NONE
Change-Id: I63c08344f68e2403ae7e4e6e55dfc1a3738e2bfe
Reviewed-on: https://chromium-review.googlesource.com/691556Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505315}

Bug: chromium:763687
Change-Id: I06180bbdf66d837a6bafe800ce674cb8aaaf0ee9
Reviewed-on: https://chromium-review.googlesource.com/690155Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505314}

In order to testing PWAs with service worker, this CL make PWA story set
in loading.mobile use cahce_temperature state COLD, WARM and HOT.
Also this removes the following pages from test to reduce the total
execution time.
GuitarTuner
InboxAttack
Pokedex
2048
TrainedToThrill
TownWork

cache_temperature.HOT is added in https://crrev.com/3011263002/
Design doc of perf benchmark for PWA:
https://docs.google.com/document/d/1Nf97CVp1X7aSqvAspyJ7yOCDyr1osUNrnfrGwZ_Yuuo/edit?usp=sharing

Bug: 736697
Change-Id: Iecdbe28f59d3378f3c18619d058a527231a6cfc3
Reviewed-on: https://chromium-review.googlesource.com/684034
Commit-Queue: Yuki Yamada <yukiy@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505313}

https://chromium.googlesource.com/catapult.git/+log/4022e0e9056d..b6bab938e5ff

$ git log 4022e0e90..b6bab938e --date=short --no-merges --format='%ad %ae %s'
2017-09-28 benjhayden Remove CsvPivotTableOutputFormatter from telemetry.

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I1cdce9e6743fba7717267dc61ecd7d2e9e18e819
Reviewed-on: https://chromium-review.googlesource.com/691121
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505312}

BUG=None
TEST=Ran bots.

Change-Id: Ica33fca6c8e2d4e52f9f6ece39b5082cdba61dbf
Reviewed-on: https://chromium-review.googlesource.com/675024
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505311}

This reverts commit 300dbd0e.

Reason for revert: Timing out on MSAN:

https://luci-milo.appspot.com/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20MSAN/3438

Original change's description:
> Make passing mojo blobs over IndexedDB work.
> 
> Like other CLs this only adds a mojo blob handle for lifetime purposes,
> but browser-side code still uses the separately passed UUID to actually
> access the blob data.
> 
> Bug: 740744
> Change-Id: I880db368d033473d4b923083b5e84be54e8e1716
> Reviewed-on: https://chromium-review.googlesource.com/608744
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Daniel Murphy <dmurph@chromium.org>
> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#505159}

TBR=dcheng@chromium.org,dmurph@chromium.org,mek@chromium.org,haraken@chromium.org

Change-Id: I570eaf73fa9dc307c50a9593fe51faf61537d0a8
No-Tree-Checks: true
No-Try: true
Bug: 740744
Reviewed-on: https://chromium-review.googlesource.com/691396Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505310}

Code like:

    if (isFooElement(n)) {
      auto* foo = ToFooElement(n)
      ...

can be simplified by ToFooElementOrNull():

    if (auto* foo = ToFooElementOrNull(n)) {
      ...


Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I0113d96de08d09f849ed42683b04826eb3d8fdb2
Reviewed-on: https://chromium-review.googlesource.com/690556Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505309}

Our timing for delayed tasks is only accurate to about 15ms or so; the
min buffer time should be bigger than that so that underrun prevention
actually works.

Bug: 
Change-Id: I40cf658ea4d131cc8c6eaeeae5d3323575d0d798
Reviewed-on: https://chromium-review.googlesource.com/691302Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505308}

This reverts commit 9764561c.

Reason for revert: Need to revert https://chromium-review.googlesource.com/c/chromium/src/+/656597, which this patch depends on.

Original change's description:
> [Desktop Capture] Replace audio_share with an enum.
> 
> This is a followup change to
> https://chromium-review.googlesource.com/c/chromium/src/+/656597
> 
> Changes in DesktopMediaId:
> - Adds a Capture enum to indicate what is being captured
> - Type enum renamed to Source to distinguish it from Capture
> - type renamed to source_type
> - audio_share boolean replaced with capture_type enum
> - Adds methods to query/set capture type
> 
> Bug: 766728
> Change-Id: I95c6c8ec4b12a7c2e78b360843f91956b223dcfa
> Reviewed-on: https://chromium-review.googlesource.com/673093
> Commit-Queue: mark a. foltz <mfoltz@chromium.org>
> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
> Reviewed-by: Zijie He <zijiehe@chromium.org>
> Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#504590}

TBR=sky@chromium.org,mfoltz@chromium.org,sergeyu@chromium.org,guidou@chromium.org,jochen@chromium.org,zijiehe@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 766728
Change-Id: I844800849ec527c12ee7330b45bc90a25f12dc9e
Reviewed-on: https://chromium-review.googlesource.com/691107
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505307}

TBR=wangxianzhu@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I9df9206c57314109dfd9fb903b301d46b741d934
Reviewed-on: https://chromium-review.googlesource.com/691018
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505306}

This CL only enables the creation of exclusive VRSession objects. It
does not provide the ability to present to a headset, or many of the
functions of a VRSession. Those will be added in follow up CLs to allow
the more complicated logic to be reviewed independently.

Bug: 670510
Change-Id: Ic2b3b1801bf8f3ee4263d009daab8215b0b179d5
Reviewed-on: https://chromium-review.googlesource.com/685396
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505305}

crrev.com/c/604219 introduced ARC_SECURITY_OWNERS,
but it was applied only to files under components/arc/common.
This CL adds owners in the file for other components/arc
security reviews.

BUG=None
TEST=N/A

Change-Id: I76ceabc862deb910ac26d2fc5d89c0458d9d2c17
Reviewed-on: https://chromium-review.googlesource.com/691637Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505304}

Bug: 560525
Change-Id: I8ab96299a63d33830d7c779ed15c0bee0bcbc28f
Reviewed-on: https://chromium-review.googlesource.com/644626
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505303}

This CL removes RefPtr<>::Get() in order to rename it to get().

Bug: 763844
Change-Id: I90f05a57d9f9bdf493983656a731585a7fb15ed8
Reviewed-on: https://chromium-review.googlesource.com/686515Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505302}

Bug: None
Change-Id: I44961962ccc51fe4fdcb5e1df07b8fb9e876c868
Reviewed-on: https://chromium-review.googlesource.com/688036Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505301}

This test doesn't run on any trybot until we have one for Android O.


Bug: 717658
Change-Id: If775e7b6770d53cab12f32ed061590dc2a0530b1
Reviewed-on: https://chromium-review.googlesource.com/690753Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505300}

Also rearranges code so that WorkerThreadForTest can be defined in one
place instead of having to declare FakeWorkerGlobalScope in between. No
functional change is done here. Purley moving the code around.

Split from
https://chromium-review.googlesource.com/c/chromium/src/+/636684

Bug: 750311
Change-Id: Ic79600567401604651ad579542ee5aabbeb5fa5f
Reviewed-on: https://chromium-review.googlesource.com/691301
Commit-Queue: Alok Priyadarshi <alokp@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505299}

RefPtr<>::Get() is being renamed to get() for a preparation of the
unification of RefPtr and scoped_refptr.
This CL updates calles of Get() in core/animation/ to use get().

Bug: 763844
Change-Id: I784542c713551b8028a4f7690687b83a7c59d1ac
Reviewed-on: https://chromium-review.googlesource.com/688261Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505298}

Don't allow changing GSSAPI library name on Chrome OS (there's no
reason to). Note that the GSSAPILibraryName policy is not supported
on Chrome OS, which means that it already cannot be set through
policy. This CL is an additional security measure.

BUG=chromium:755153
TEST=Compiled, trybots

Change-Id: Ibc2eb7e0ce59ccc5e7f7c8fd66078bc0efb2e3a5
Reviewed-on: https://chromium-review.googlesource.com/685836Reviewed-by: Nicolas Zea <zea@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505297}

This CL contains:
 1. Remove unneeded WebAudioBusPrivate and casts from/to it.
 2. Avoid applying AdoptRef twice for single AudioBus.
 3. Use nullptr instead of 0 around WebAudioBus

The main part is (2). An upcoming change bans multiple invocation of
WTF::AdoptRef for a single object, and as its preparation, this CL
removes a failing case.

Bug: 763844
Tbr: rtoy@chromium.org
Change-Id: I362a83cd03d49b77ef9e4d81544bd5c7a9b2bc5e
Reviewed-on: https://chromium-review.googlesource.com/686088
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505296}

Since r503089 removed factory-default settings from the Page Info, there is now
room to always show page certificate information. This patch turns on the
--show-cert-link flag, which will do this, by default.

Bug: 718553
Change-Id: Ic293c720337d5638f6097b481cfa7bc341b6abdf
Reviewed-on: https://chromium-review.googlesource.com/686093
Commit-Queue: Patti <patricialor@chromium.org>
Reviewed-by: Lucas Garron <lgarron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505295}

Tbr: tzik@chromium.org
Change-Id: I961dd6a0775fbf6458e268cd332cc1fdb509e3a0
Reviewed-on: https://chromium-review.googlesource.com/691454Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505294}