- 06 Dec, 2019 40 commits
-
-
Daniel Murphy authored
Now that blobs from IndexedDB are backed & read by the IndexedDB system, they are no longer sent to the renderer as files. This means no content policy changes or grants are necessary. Tracking document: https://docs.google.com/document/d/18suNOOzuEJbqgRJF0MB2VqdTyYqS4cvI2PGaCpyPXSw/edit?ts=5de6dc30&pli=1#heading=h.tw2iw2qfgduj Bug: 1015212 Change-Id: If3d2fd80b3254f19a56ab16ed7fc39cf5f0cf684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955813Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#722617}
-
Devlin Cronin authored
Split apart some ExtensionActionViewController related unittests that were exercising multiple scenarios. Specifically: ExtensionActionWantsToRunAppearance -> ExtensionActionWantsToRunAppearance + OverflowedPageActionAppearance ExtensionActionBlockedActions -> BrowserActionBlockedActions + PageActionBlockedActions + PageActionBlockedActionsInOverflow This will help with adapting these to the ExtensionsMenu behavior, which will be done in a followup. This does not change any behavior in production. Bug: 984654 Change-Id: Iadd2374321ae8868a2b846049ad9886e4bf35e0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938307Reviewed-by:Peter Boström <pbos@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#722616}
-
Robbie McElrath authored
crrev.com/c/1954543 was missing an include rule in //aw/gpu/DEPS. TBR=torne@chromium.org Test: buildtools/checkdeps/checkdeps.py android_webview Bug: 1031659 Change-Id: I943106937f674cc6967a9f8b8f69d7711a3cfc33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956068Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#722615}
-
Jiawei Li authored
- Adds a CastWebContents::FromWebContents() method to retrieve corresponding CastWebContents that wrapped the content::CastWebContents. - Adds flags into CastWebContents::InitParams to determine whether enabling WebSQL database and mixer audio. Merge-With: eureka-internal/342751 Bug: internal b/144316145 Test: CQ Change-Id: I7768e9b2d903ea79dbb3e49ca82ffe389f98d19e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954447Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Jiawei Li <lijiawei@chromium.org> Cr-Commit-Position: refs/heads/master@{#722614}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/02a82546e547..f3883e32a739 git log 02a82546e547..f3883e32a739 --date=short --first-parent --format='%ad %ae %s' 2019-12-06 tsepez@chromium.org Fix typo in array name in HTMLSTR2Code() 2019-12-06 thestig@chromium.org Use more spans with CRYPT_ArcFour code. Created with: gclient setdep -r src/third_party/pdfium@f3883e32a739 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1030583,chromium:1031523 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I3b0cd04114424aba91d9f4baacc29eb16831a31f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955180Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722613}
-
Johannes Henkel authored
We'll be doing away with StringUtil::parseMessage(..., false) which invokes a JSON parser. So, in preparation, I'd like to convert the incoming traffic to CBOR. StringUtil::parseMessage(..., true) will then still make a protocol::Value but using a CBOR parser. Later on, we will be able to extract call_id / method with a shallow parse. So the plan is to have the raw messages be in CBOR format. I did a small amount of cleanup as well to make this easier to read (inlining the conversion, adding a method applying to both sending response and notification). Change-Id: I6659c46f8e59dc15442b08fbf9f9999a2b353986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954385Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#722612}
-
Mason Freed authored
======================== NOTE TO SHERIFFS: This CL may cause some flaky tests within the (new) virtual/web-components-v0-disabled suite. If so, please do not revert this CL; instead mark the flaky tests as SKIP in the section of TestExpectations marked with crbug.com/937746, and feel free to notify me or file a bug against me. Thanks! ======================== Because the Web Components v0 features are set to "test", they still run enabled for layout and WPT tests. This virtual test suite manually disables them for the DOM-related tests to make sure our tests are functional without WCv0 features. Bug: 937746 Change-Id: I3914a2d6614a4cfa0115e486ce5222d4c3539507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952088 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#722611}
-
Hector Carmona authored
Bug: 1031006 Change-Id: If119ab8748649e257385d88332a5037f3a4ab668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954266Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#722610}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/63c155195925..92183a268319 git log 63c155195925..92183a268319 --date=short --first-parent --format='%ad %ae %s' 2019-12-06 ianelliott@google.com Vulkan: Latest Intel driver fixes 2-sample standard positions 2019-12-06 ianelliott@google.com Fix multisample renderbuffer compliance (e.g. 3->4 samples) Created with: gclient setdep -r src/third_party/angle@92183a268319 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: geofflang@google.com Change-Id: Ia7c7877f214de833af3b31c17f0ea4f819c26589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955177Reviewed-by:
-
Adrienne Walker authored
These functions are unnecessary and make it more complicated to remove the use of BrowserThread::IO from idb code. In particular, the delegate can be owned by the callback rather than by the ChainedBlobWriter, and the flush policy can be accessed from the idb sequence instead. Change-Id: I8d73085a9aa374699305cd37457a2f075bb2a791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954524 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#722608}
-
Etienne Bergeron authored
This CL is removing the use of GraphemeIterator. The function IsValidCursorIndex(...) is moved from the RenderTextHarfBuzz to RenderText to be with the other grapheme-related functions. The main goal is to get rid of the GraphemeIterator. There are still some uses to be removed. Bug: 1025561 Change-Id: Ie8483dbc550aee95eb1cd64ca5d3f3e85855ea09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951445 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#722607}
-
Ken MacKay authored
Bug: internal b/145718333 Change-Id: Ie315ccc944536f8df034e0dd30ab39b599cca855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955027Reviewed-by:
-
John Z Wu authored
This will help with more accurate logging in //ios/web_view. Bug: 1031423 Change-Id: I2a87917bb9be50c8e802a33dff1e8de33d818e12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954457 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#722605}
-
siyua authored
https://docs.google.com/document/d/1vnf6YMLR6kTgru8yJXrFV7zqzphxz8ukQ_ecmq-B3S4/edit?disco=AAAAD_weQc4 https://docs.google.com/document/d/1s3Z1GGSBjYacpasCbLZhGCaxOHkfHQqdRdfRourZC7c/edit?disco=AAAAD_w_s8k Bug: 991037 Change-Id: I32e676d780d076955ad31f8ed37819a73cd2f937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955025Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#722604}
-
nancy authored
Add AppServiceAppWindowLauncherItemController to handle the special cases for Chrome apps, e.g. OnWindowTitleChanged, GetAppMenuItems, which is the current implementation in //src/chrome/browser/ui/ash/launcher/extension_app_window_launcher_item_controller.cc https://cs.chromium.org/chromium/src/chrome/browser/ui/ash/launcher/extension_app_window_launcher_item_controller.cc?sq=package:chromium&dr=CSs&g=0 BUG=1011235 Change-Id: I24052b7df167011ea5b042082950adae3026e5dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942892Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#722603}
-
Khushal authored
The feature has been enabled on Android since M77. This change does the clean up for removing the associated feature flags now. R=ericrk@chromium.org, boliu@chromium.org Change-Id: I4c40bcd27e6f690507e75c1807a14eefe74f41c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955856 Commit-Queue: Khushal <khushalsagar@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#722602}
-
Antonio Gomes authored
BUG=787254 R=guidou@chromium.org Change-Id: I708b0093e0f68612201907b0292c7805e2f37fc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953504 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#722601}
-
David Roger authored
Bug: 1028517 Change-Id: Ic302dfa4aa456f8747d328ab970b5e00238b7550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953714Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#722600}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/1d6250d01645..dc3317da6cd5 git log 1d6250d01645..dc3317da6cd5 --date=short --first-parent --format='%ad %ae %s' 2019-12-06 cwallez@chromium.org Namespace Log.h/cpp in dawn:: 2019-12-06 rharrison@chromium.org Refactor D3D12 pipeline creation to better propagate errors 2019-12-06 rharrison@chromium.org Use spvc API for calls in ShaderModuleD3D12 2019-12-06 cwallez@chromium.org Remove generation of proxy dawn.h and dawncpp.h 2019-12-05 yunchao.he@intel.com Readonly storage buffer - Vulkan backend 2019-12-05 rharrison@chromium.org Rolling 4 dependencies 2019-12-05 cwallez@chromium.org Vulkan: Choose D32S8 or D24S8 depending on availability 2019-12-05 cwallez@chromium.org Add links to, and format Toggles.cpp 2019-12-05 cwallez@chromium.org Add Log.h to replace all uses of iostream Created with: gclient setdep -r src/third_party/dawn@dc3317da6cd5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ibcc7d638c102876ae687241c666e053bdf2b9af0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955845Reviewed-by:
-
rbpotter authored
A document page count was being passed around in a bunch of places only to record it as a metric. Since this metric is now obsolete and no longer being recorded, remove this extra parameter where it isn't needed. Bug: None Change-Id: I2723b8af1786c4bf5fbfdad8f7c66b25959f7408 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937586Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#722598}
-
Elly Fong-Jones authored
This state machine exists to protect against two pathological cases: 1) An attempt to show a bubble via BubbleManager::ShowBubble *while* inside BubbleManager::~BubbleManager(). This is impossible in the absence of programmer error: if ~BubbleManager is being called, it is not possible to still reference the BubbleManager to create a new bubble. 2) An attempt to show (or close) a bubble while iterating the bubble list, as part of CloseAllBubbles or UpdateAllBubbleAnchors. In this case, neither of these methods call anything that should cause a new bubble to show. Much of the complexity here is in support of bubbles spawning a new bubble from their own destructor, which a) should not be allowed and b) is not done in the codebase in any case. This change also removes BubbleManager::FinalizePendingRequests, which was only called in one place - namely BubbleManager::~BubbleManager. All this method did was move into the "destroying" state and then close all bubbles, so with the removal of the states, the destructor can simply close all bubbles itself. Bug: 496955 Change-Id: I8839304b349ef9b839cdc882f071d6da0a5dbe98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953394Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#722597}
-
Erik Chen authored
The builder both builds and run tests, so it potentially needs more time. Bug: 1029936 Change-Id: I1e11437a81c1725287432ef5f919c5415f1be544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954541Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#722596}
-
Martin Kreichgauer authored
Screenreaders currently announce the chrome://... resource reference when focusing these icons. The dialog embedding this component already has labels that provide the semantic context. Bug: 974046 Change-Id: If0850187ab2bce95b8bc8756f3ab7693df7a27d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938256 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Auto-Submit: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#722595}
-
Natalie Chouinard authored
Move Notification settings and tests to subpackage, and rename according to go/clank-preferences-refactor naming conventions. Bug: 876376, 1030446 Change-Id: I050d854907d46a45e35e24ce3eadf14c8ecc9915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953607 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#722594}
-
Josh Nohle authored
In this CL, we do not consider a host verified until it has a public key and beacon seeds, data required for communication between the mult-device host and client. This CL should only be relevant after v1 DeviceSync is deprecated, when a public key and beacon seeds are not available until v2 DeviceSync host device data has been decrypted. When only v1 DeviceSync is running or when v1 and v2 DeviceSync are running in parallel, we guarantee that the eligible host devices always have a decrypted public key and beacon seeds, as long as that data was properly sent by the CryptAuth backend. See http://go/cros-devicesync-v2-remote-device-id for more details. Bug: 951969, 1019206 Change-Id: I454c79ddfae3cbf5f3bde602384e13d62ea1ffd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935229 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
-
Maksim Sisov authored
WaylandWindow handles too many things and confuses developers that are not familiar with it. To make things better, extract surface methods into WaylandSurface. This change does not bring any functional changes except removed is_active() method that was only used by tests. Instead, tests just rely on the PlatformWindowDelegate::OnActivationChanged calls. Test: ozone_unittests Bug: 1028919 Change-Id: Ia58577f86d8e31ec93b113d887b34166fbe19cf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954478 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#722592}
-
Karan Bhatia authored
This reverts commit 852ad1d0. Reason for revert: Suspected to break compile on mac-archive-rel Original change's description: > [DevUI DFM] Move 17 chrome:// pages to DFM, via new dev_ui_browser_resources.pak. > > This CL moves 83.5 kB of "long tail" resources to the Developer WebUI > Dynamic Feature Module (DevUI DFM), for 17 chrome:// pages whose > resources were in browser_resources.pak. These pages and their > associated resource prefixes are: > > accessibility (IDR_ACCESSIBILITY_*) > components (IDR_COMPONENTS_*) > device-log (IDR_DEVICE_LOG_UI_*) > domain-reliability-internals (IDR_DOMAIN_RELIABILITY_INTERNALS_*) > download-internals (IDR_DOWNLOAD_INTERNALS_*) > interventions-internals (IDR_INTERVENTIONS_INTERNALS_*) > local-state (IDR_LOCAL_STATE_*) > media-engagement (IDR_MEDIA_ENGAGEMENT_*) > memory-internals (IDR_MEMORY_INTERNALS_*) > notifications-internals (IDR_NOTIFICATIONS_INTERNALS_*) > predictors (IDR_PREDICTORS_*) > sandbox (IDR_SANDBOX_INTERNALS_*) > site-engagement (IDR_SITE_ENGAGEMENT_*) > snippets-internals (IDR_SNIPPETS_INTERNALS_* | IDR_FEED_INTERNALS_*) > supervised-user-internals (IDR_SUPERVISED_USER_INTERNALS_*) > translate-internals (IDR_TRANSLATE_INTERNALS_*) > ukm (IDR_UKM_INTERNALS_*) > > Note that chrome://snippets-internals has 2 prefixes, corresponding to > {SnippetsInternalsUI, FeedInternalsUI}. > > Also, some DevUI pages in browser_resources.pak are not moved, because > they are new and can be handled later (need IsWebUiHostInDevUiDfm() > change), or are not used by Android. > > These resources are moved to new file dev_ui_browser_resources.pak, > which then feeds into dev_ui_resources.pak. 18 WebUI .cc files have > their resource include headers updated. > > Bug: 927131 > Change-Id: Ideaf57e2997b4621d7ffdfea8c126bf78688c322 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954458 > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Samuel Huang <huangs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#722576} TBR=thakis@chromium.org,huangs@chromium.org,agrieve@chromium.org Change-Id: I93a24570c0be77d5fc1dad2342e83ea5d9bead25 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 927131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956013Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#722591}
-
Kurt Horimoto authored
This config will be used to trigger the display of the banner UI for the save passwords infobar. This CL also introduces CreateAuxilliaryData to the OverlayUserData template so that OverlayUserData can be shared amongst OverlayRequest configs. The SavePasswordsOverlayRequestConfig adds an InfobarOverlayData to its OverlayRequest exposing the InfoBar pointer. This can also be used by other infobar OverlayRequest configs so that their InfoBars can be accessed as request->GetConfig<InfobarOverlayData>()->infobar(). In addition, this CL also adds IOSChromeSavePasswordInfoBarDelegate:: FromInfobarDelegate(), which allows downcasting to the appropriate type. Bug: 1030357 Change-Id: I3b89d8516b8b25d8e32576aff200fa10d92a61f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951130Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#722590}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/981821ef9bd1..08b668ce35ac Created with: gclient setdep -r src-internal@08b668ce35ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I069cc3acb41d880f19fec977e13bece2143932d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955850Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722589}
-
Sadrul Habib Chowdhury authored
If a sequence does not have enough frames, then instead of discarding them completely, retain the throughput-data, and accumulate them with the throughput metrics of the subsequent sequences (of the same interaction-type) until there are enough frames to report the metric. Bug: 1031251 Change-Id: I4bbe1d0b024e04afd92677426a546699d9cc85d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952529Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#722588}
-
chromium-autoroll authored
Roll ChromeOS orderfile from 80-3945.24-1574073604-benchmark-80.0.3964.0-r2 to 80-3945.42-1575283012-benchmark-80.0.3964.0-r2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Id19c1aed8b648b688096ee333292498b47d44e60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955179Reviewed-by:
-
Maksim Sisov authored
To hide future different types of WaylandWindows (WaylandSurface, WaylandPopup and WaylandSubsurface), add a factory method, which will handle everything on its own. Also make unittests and OzonePlatformWayland use this factory. Bug: 1028919 Change-Id: I745f99024b6657be3686ee92b0baf4c93f08b9a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954470 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
-
Matthew Mourgos authored
Without this change the back button just instantly appears/disappears. Bug: 1031363 Change-Id: I731bfb62637215f18ea90c5c34b2b51d7be4c787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952423Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#722585}
-
Kevin McNee authored
We now have all listeners created before performing the action that will lead to the expected message being sent. Bug: None Change-Id: I7b300136dedee619842d4753cd6d291fd8205b4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954807Reviewed-by:
-
Brian Sheedy authored
Updates the golden images for the VR browser data URL emphasis test to account for a recent change to the security token icon from an "i" in a circle to a warning triangle. TBR=alcooper@chromium.org Change-Id: I05afeea881638cd971503cd692fc5e1db0ca793f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955846Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#722583}
-
Maksim Sisov authored
Just moving the translation helper method to utilities. Bug: 1028919 Change-Id: I6e60bcdf804e4aaff9cb39d437e4302af2ed3fd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953710 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
-
Tricia Crichton authored
Add sameSite to AddCookie command, but do not include in DevTools parameters if not set by user. Add sameSite to GetCookie commands. Bug: chromedriver:3264 Change-Id: Iefb02e131804bdf7235bdb98b5ebf38e7a886cfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955793 Commit-Queue: Tricia Crichton <triciac@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#722581}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fe18a43d590a..6b52dc21e166 git log fe18a43d590a..6b52dc21e166 --date=short --first-parent --format='%ad %ae %s' 2019-12-06 jyasskin@google.com Default to origin's default branch instead of always origin/master. Created with: gclient setdep -r src/third_party/depot_tools@6b52dc21e166 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1023031 Tbr: agable@chromium.org Change-Id: Id096878bf58f5cb701c4ceaaeec737eff415cee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955848Reviewed-by:
-
Brian Sheedy authored
Adds support for base::win::GetVersion() returning either 5 or 6 on Windows 10, which are valid return values but currently unhandled, which has been causing flaky test failures. Bug: 1007013 Change-Id: I40217ff610cb9071c2504352e8a99b234f3c1fa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954216 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#722579}
-
Antonio Gomes authored
As part of this CL: - WebRTCPeerConnectionHandler became RTCPeerConnectionHandlerPlatform - WebRTCPeerConnectionHandlerClient became RTCPeerConnectionHandlerClient - MockWebRTCPeerConnectionHandler became MockRTCPeerConnectionHandlerPlatform BUG=919392, 787254 Change-Id: Id5737142323fb611a177b3ca6d0a79c21bd91c39 R=guidou@chromium.org, haraken@chromium.org Change-Id: I1b26bf3946791df4fcac71594f2acb34a040774e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953383 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#722578}
-
