GitLab

It shouldn't be possible to have an infinite number of these bugs, so
I'll just keep fixing them and hope the Clusterfuzz reports come to an
end :).

Bug: 825679
Change-Id: I899c87b7849cdf7cefc50976b247bce4307b89d2
Reviewed-on: https://chromium-review.googlesource.com/979801Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545753}

Bug: 813477
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Idaaf4fbc6d0217b5e0e817f8953095ae5d45e707
Reviewed-on: https://chromium-review.googlesource.com/979744Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545752}

This is required to support building Microsoft's WinUWP store
application version of WebRTC.

vs_toolchain.py
- needed to perform environment variable expansion for "Program
Files(x86)" to correctly identify Visual Studio installation location

config/BUILD.gn
- remove delayimp.lib, kernel32.lib and ole32.lib from store
applications (instead requires dloadhelper.lib/WindowsApp.lib
must be used)

BUILDCONFIG.gn
- Do not use clang when compiling Windows UWP targets;
- Added declare_args for is_target_winuwp rather and stripped multi
defined variations of the host_os/current_os == "winrt_10", "winrt_81",
"winrt_81_phone" that heavily polluted the platform / target selections
(as the current targeting methodology is incorrect anyway). The
host_os/current_os is always be "win" and only the target should be
Windows UWP / store applications based on the target_os == "winuwp"
rather than all the flavors of UWP.
- Added filter for _winuwp source files (separate from just windows)
- Added default configs for desktop vs store applications to correctly set
the defines according to the desktop vs store targets

config/win/BUILD.gn
- The Windows UWP versioning assumes to be Windows 10 / store
app now although a updated GN allows for targeting older Windows UWP
versions/SDKs/device families. This allows the definitions for the
various application support versioning and application families required
for UWP to be set.
- The linker calls vsvarsall.bat to be executed via
toolchain/win/setup_toolchain.py in order to correctly identify the
correct linker library path information for Windows store SDK targets.
The hard coded and assumed library paths are fixed in all cases to be
discovered from the tooling for forward future platform support in all
cases.
- Added ARM linkage definitions for the Windows ARM CPU required for
properly targeting all three CPUs (x86, x64, arm) for universal store
binaries.
- Added the proper family C++/C defines required to target the various
Windows store application types currently offered for Windows UWP store
applications.

toolchain/win/BUILD.gn
- The name to support the storage of the environment variables now is
passed into the setup script to allow for easier extension of the
CPUs and target combinations (arm, x64, x86 in the desktop vs store
variations)
- "desktop" vs "store" is now specified the setup for the
correct toolchain targeting
- Sets true/false for is_target_winuwp is dependent on the toolchain
activated (so configurations will be set correctly when the toolchain is
specified for host tool targets required for build tools vs finalized
application targets)
- Cleaned up the Windows RT section to properly support Windows UWP
toolchains

toolchain/win/setup_toolchain.py
- the setup was missing the arm CPU for universal binaries required for
the UWP platform
- The calling of vcvarsall.bat was missing the "store" option for store
applications and all the CPU offered
- Added returning of linker paths by searching the library environments
for well-known library files expected in each of the 3 library paths
required "lib", "um" and "atlmfc"

R=phoglund@google.com

Bug: 812814
Change-Id: If1a6b1b1bc3ed940fc8e2ce726ac016e2491e61d
Reviewed-on: https://chromium-review.googlesource.com/923161
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545751}

This CL adds support for autoGainControl and noiseSuppression properties
to MediaStreamTrack.getCapabilities() and InputDeviceInfo.getCapabilities().

Bug: 823831, 817769
Change-Id: Ifdc0e560001e000b12c8d04634d3c52de0a34cc7
Reviewed-on: https://chromium-review.googlesource.com/977251Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Chandan Padhi <c.padhi@samsung.com>
Cr-Commit-Position: refs/heads/master@{#545750}

Looks like that scoped FeatureList object doesn't affect
ShellBrowserMainParts::SetupFieldTrials() execution and can be removed.

Change-Id: If6c7b3433492ffdde1b1a44762bfed28f5e95824
Reviewed-on: https://chromium-review.googlesource.com/978216Reviewed-by: Jianpeng Chao <chaopeng@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Andrey Kraynov <iceman@yandex-team.ru>
Cr-Commit-Position: refs/heads/master@{#545749}

This CL allows dynamic import() on DedicatedWorkerGlobalScope and adds WPT
tests. Note that ES Modules on DedicatedWorker is an experimental feature behind
the runtime flag.

Design doc:
https://docs.google.com/document/d/1IMGWAK7Wq37mLehwkbysNRBBnhQBo3z2MbYyMkViEnY/edit#heading=h.637avx8i5qtn

Bug: 680046
Change-Id: I1f8fed5c319aab634f96bcfabeb3c95f5dc7d9a7
Reviewed-on: https://chromium-review.googlesource.com/970127
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545748}

I was mostly looking for components/signin/-related things, but
discovered a bunch more stuff along the way, mostly in
ProfileSyncComponentsFactoryImpl.

Bug: 825190
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I1b17d00db3cbefa50a7fabaf0b3e55e7ea567610
Reviewed-on: https://chromium-review.googlesource.com/978211Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545747}

This CL introduces "InsertCommands.h", move the declarations of some
static functions related to insert commands to the header file. Make
EditorCommand simpler for improving code health.

Bug: 818552
Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Change-Id: I4fc744dc58da885071760ba691baa03e8015d63c
Reviewed-on: https://chromium-review.googlesource.com/977365Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545746}

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/72bfdd343136..a0f6142f5733

$ git log 72bfdd343..a0f6142f5 --date=short --no-merges --format='%ad %ae %s'
2018-03-20 dats Add constants for DriveFS D-Bus service.
2018-03-15 emaxx cryptohome: Constants for challenge-response methods
2018-03-15 ejcaruso cryptohome: remove MigrateToDircryptoEx constant

Created with:
  roll-dep src/third_party/cros_system_api
R=sammc@chromium.org

Bug: 823603
Change-Id: I718b17c6ddb00bdeca9a8fb11a097faaecb67500
Reviewed-on: https://chromium-review.googlesource.com/979740Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Sergei Datsenko <dats@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545745}

This converts the type of callback parameters on AsyncFileUtil methods
from const-ref to value, and adds std::move() around them for smaller
number of copies.

TBR=baileyberro@chromium.org

Change-Id: I07ef5fa991bcfb2e0d07ef739b4ecad4c89c39ff
Reviewed-on: https://chromium-review.googlesource.com/936345
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545744}

From an offline conversation.

Rationale: reflect the fact that this interface is:
- somewhat specific to navigations
- basically to intercept requests/responses

We plan to define content::URLLoaderRequestInterceptor in
//content/public separately, which only intercepts requests
(and not necessarily specific to navigations)

Note: This does NOT rename subclasses (e.g. FooRequestHandler).

R=jam@chromium.org,jianli@chromium.org

Change-Id: Ie6321d4e9ec8be626a505f242f3aace5d1c45eea
Reviewed-on: https://chromium-review.googlesource.com/977642
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545743}

Rename the last holdout that is using the old name.

Bug: 821215
Change-Id: I45cafaab27f7ef42eaef748088910d8d28f5260c
Reviewed-on: https://chromium-review.googlesource.com/979450Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545742}

This reverts commit d03adf5a.

Reason for revert:

This has caused some tests to fail flakily and reflect a crash that could happen in the wild. See http://crbug.com/825448

Original change's description:
> RDH:  Ensure there's at most one LoadInfoList in flight.
> 
> ResourceDispatcherHost pushes pending load state of all frames to the UI
> thread once every 250 milliseconds when there's a pending load.  This
> happens even when the UI thread is blocked.  Apparently it's causing an
> OOM when the UI thread is blocked.  Whatever is blocking the UI thread
> is another issue entirely, but we shouldn't use unbounded memory in the
> browser process.  This CL prevents load state updates from being sent
> until the previous set was ACKed by the UI thread.
> 
> Bug: 824869
> TBR: jam@chromium.org
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
> Change-Id: I3b68522c5281d477d3a621ac02e5df1f75153d99
> Reviewed-on: https://chromium-review.googlesource.com/978383
> Commit-Queue: Matt Menke <mmenke@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Charlie Harrison <csharrison@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#545616}

TBR=jam@chromium.org,mmenke@chromium.org,csharrison@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 824869
Change-Id: I350dd7b357c32ffc7fb85a2417afaf779552ff77
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/979674Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545741}

Added ClickBreadcrumbs user action for click in breadcrumb.

Fixed handling of MockFileSystem root to always include trailing slash.
The root dir is referenced in the breadcrumb and causes errors
in tests  with inconsistency of trailing slash.



Bug: 824607
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5ff72f4d2542c25f87fd495bdb088d0d3315424f
Reviewed-on: https://chromium-review.googlesource.com/977381
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545740}

The test fails flakily on Linux, Windows and ChromeOS.
See bug for details.

TBR=foolip@chromium.org, dmazzoni@chromium.org

Bug: 825735
Change-Id: I5953f23c9c87e7b4ab2b0a6b9fd9d604a1bf27c3
Reviewed-on: https://chromium-review.googlesource.com/979799Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545739}

When notification inline settings is opened from the top right gear icon
using by keyboard, it crashed as animation requires the event to be
LocatedEvent but it's not.

TEST=manual
BUG=823646

Change-Id: Ia683de86e042f010ac4bb0ee645fff170547b9fa
Reviewed-on: https://chromium-review.googlesource.com/974922
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545738}

Was trying to fix something in this code for an unrelated bug and came
across a few things that could be improved:
* There were too many stateful booleans making the code unnecessarily
complex.
* The type of event that initialized the drag should be in the
DragDescriptor, because it describes the drag and also has the same
life cycle.
* Flatten complicated if statements into chains of if/else's that only
use simple conditions.
* Use a switch statement for the event type.

Change-Id: I74712df2502960c6a98be0a705a5ced94a61ec75
Reviewed-on: https://chromium-review.googlesource.com/979378Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Blake O'Hare <blakeo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545737}

Fix MockFileSystem to delete entries rather than nulling them.
As null, the key is still iterable which causes errors.

Make root path consistent to always have trailing slash which
matches prod behaviour.

Set default size/date metadata for MockDirectoryEntry.

Put all test helper methods in 'test' namespace.

Replace waitUntil with repeatUntil/pending from
integration_tests/test_util.js which provides better error reporting.


Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie648388a7d6fe6c79951d5b4330234c378ffe2ee
Reviewed-on: https://chromium-review.googlesource.com/965722
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545736}

This patch introduces tests for hanling of "inline-block" and "float" of
|NGInlineNode::CollectInlines()| to avoid regression for improving code health.

This patch is a preparation the patch[1].

[1] http://crrev.com/c/737981 Simplify word granularity handling

Bug: 778507
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ifead65d6df83a19dbe2b82b509ef39427b56962c
Reviewed-on: https://chromium-review.googlesource.com/979751
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545735}

See bug for details.

TBR=hubbe@chromium.org,dalecurtis@chromium.org
notry=true

Bug: 754986
Change-Id: I33b05a30137c2c793d1704242dbb28d15c5aefe3
Reviewed-on: https://chromium-review.googlesource.com/979800Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545734}

Bug: 824566
Test: Manual
Change-Id: I58609375c31f9fc86e16ef2e214747ced8f24218
Reviewed-on: https://chromium-review.googlesource.com/974572
Commit-Queue: Yue Li <updowndota@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545733}

Accessibility fix for "Open With" dialog that wasn't being read by
Chromevox.

Change DefaultTaskDialog to set tabindex=-1 for dialog items, so they
can be navigated via JS focus() method, but not via TAB key.

Change cr.ui.List to issue an focus to the item when navigated via
keyboard arrow up/down.

Dialog items already have the correct text to be read, see bug for
screenshot.

Bug: 435010
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2abc1d2d3d6cb6e78a373ccc51c79e34a0b756bd
Reviewed-on: https://chromium-review.googlesource.com/968004Reviewed-by: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545732}

This CL is a follow-up on https://crrev.com/c/956383.

Bug: 817769
Change-Id: I83a87fc0ee5889e9efa2c6e7a86ae8f2c6c70b90
Reviewed-on: https://chromium-review.googlesource.com/978225Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Chandan Padhi <c.padhi@samsung.com>
Cr-Commit-Position: refs/heads/master@{#545731}

The media/color-profile-video-seek-filter.html fails flakily on Win7. See bug
for details.

notry=true
TBR=chcunningham@chromium.org

Bug: 825733
Change-Id: I42edc7907e4de80e2201689796de4ff5d10ff487
Reviewed-on: https://chromium-review.googlesource.com/979795Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545730}

When converting CSSCustomPropertyDeclaration to CSSUnparsedValues, we
used to assume that CSSCustomPropertyDeclaration will always have a
CSSVariableData, but it turns out that css-wide keywords are stored
as a CSSValueID instead of a CSSVariableData.

This patch handles css-wide keywords on CSSUnparsedValues correctly.

We added a unit test and not a WPT since this is likely a blink-only
implementation detail.

Bug: 824740
Change-Id: Iefbdca4abc736562b81f5c6a3f0332975b842961
Reviewed-on: https://chromium-review.googlesource.com/977141
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545729}

Previously network::WebSocket objects were stored as raw pointers
in a set and deleted manually. Use a set<unique_ptr<WebSocket>,
UniquePtrComparator> instead, making ownership explicit and reducing the
risk of leaking.

Change-Id: I0337551d8fd073341241723538cf9864eb206c87
Reviewed-on: https://chromium-review.googlesource.com/978282Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545728}

TBR=dmazzoni@chromium.org

Bug: 825429
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I677963581b6594c014f05a717330f4b5f827a372
Reviewed-on: https://chromium-review.googlesource.com/979745
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545727}

Bug: 788251
Change-Id: I328cb3c1c812fab565eafc4009e0210653e236c7
Reviewed-on: https://chromium-review.googlesource.com/958768Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545726}

This reverts commit d260e9cf.

Reason for revert: In Windows Canary versions since 67.0.3377.0, where this commit landed, IO thread hang reports have spiked dramatically. It is now the #1 browser crash report on Windows Canary at 33% of reports. I'm speculatively reverting this to see if the crash rate heals.

Original change's description:
> Refactor BrowserThreadImpl, BrowserProcessSubThread, and BrowserMainLoop
>
> This brings back the invariant that BrowserThread::IO isn't available
> before BrowserMainLoop::CreateThreads(). This was broken to fix issue
> 729596 to bring up the thread earlier for ServiceManager but it is
> important that code that posts to BrowserThread::IO statically have an
> happens-after relationship to BrowserMainLoop::CreateThreads(). Exposing
> it statically earlier put that invariant at risk.
>
> Thankfully fixing issue 815225 resulted in finally reaching the long
> sought goal of only having BrowserThread::UI/IO. Now that the IO thread
> is also kicked off before it's named statically, BrowserThreadImpl no
> longer needs to be a base::Thread, hence this refactoring.
>
> Before this CL:
>  * BrowserThreadImpl was a base::Thread
>    (could be a fake thread if SetMessageLoop was used)
>  * BrowserProcessSubThread was a BrowserThreadImpl
>    (performed a bit more initialization)
>  * BrowserProcessSubThread was only used in production (in
>    BrowserMainLoop)
>  * BrowserThreadImpl was used for fake threads (BrowserMainLoop for
>    BrowserThread::UI) and for testing (TestBrowserThread(Impl)).
>  * BrowserThreadImpl overrode Init/Run/CleanUp() from base::Thread to
>    perform some sanity checks as well as drive IOThread's Delegate (ref.
>    BrowserThread::SetIOThreadDelegate())
>  * BrowserProcessSubThread re-overrode Init/Run/CleanUp() to perform
>    per-thread //content initialization (tests missed out on that per
>    TestBrowserThread bypassing BrowserProcessSubThread by directly
>    subclassing BrowserThreadImpl).
>
> With this CL:
>  * BrowserThreadImpl is merely a scoped object that binds a provided
>    SingleThreadTaskRunner to a BrowserThread::ID.
>  * BrowserProcessSubThread is a base::Thread and performs all of the
>    initialization and cleanup specific to //content (this means it now
>    also manages BrowserThread::SetIOThreadDelegate())
>  * BrowserProcessSubThread can be brought up early before being bound to
>    a BrowserThread::ID (BrowserMainLoop handles that through
>    BrowserProcessSubThread ::RegisterAsBrowserThread())
>
> Unfortunate exceptions required for this CL:
>  * IOThread::Init() (invoked through BrowserThreadDelegate) perfoms
>    blocking operations this was previously performed before installed
>    the ThreadRestrictions on BrowserThread::IO. But now that //content
>    is initialized after bringing up the thread, a
>    base::ScopedAllowBlocking is required in scope of IOThread::Init().
>  * TestBrowserThread previously bypassing BrowserProcessSubThread by
>    directly subclassing BrowserThreadImpl meant it wasn't subject to
>    ThreadRestrictions (unfortunate becomes it denies allowance
>    verification to product code running in unit tests). Adding it back
>    causes DCHECKs, as such
>    BrowserProcessSubThread::AllowBlockingForTesting was added to allow
>    this CL to pass CQ.
>
> Of note:
>  * BrowserProcessSubThread is still written as though it supports many
>    BrowserThread::IDs but in practice it's mostly always
>    BrowserThread::IO (except in ThreadWatcherTest I think). This change
>    was big enough that I didn't bother also breaking that
>    generalization.
>  * BrowserThreadImpl's constructor was made private to ensure only
>    BrowserProcessSubThread and a few select callers get to drive it (to
>    avoid previous missed initialization issues)
>  * Atomics to manage BrowserThread::SetIOThreadDelegate were removed.
>    Restriction was instead added that this only be called before
>    initialization and after shutdown (this was already the case).
>
> Follow-ups to this CL:
>  * //ios duplicates this logic and will need to undergo the same change
>    as a follow-up
>  * Fixing ios will allow removal of base::Thread::SetMessageLoop hack :)
>  * Removing BrowserThreadGlobals::lock_ to address crbug.com/821034 will
>    be much easier
>  * BrowserThread post APIs should DCHECK rather than no-op if using a
>    BrowserThread::ID before it's registered.
>
> Bug: 815225, 821034, 729596
> Change-Id: If1038f23079df72203b1e95c7d26647f8824a726
> Reviewed-on: https://chromium-review.googlesource.com/969104
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Commit-Queue: Gabriel Charette <gab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#544440}

TBR=gab@chromium.org,jam@chromium.org
NOPRESUBMIT=true

# Not skipping CQ checks because original CL landed > 1 day ago.
# falken: Skipping presubmit to use deprecated ThreadResrictions::DisallowWaiting().

Bug: 815225, 821034, 729596
Change-Id: I2be97c5d8183497c005ab397c871f625b034d850
Reviewed-on: https://chromium-review.googlesource.com/979752
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545725}

Change a few DCHECKs to CHECKs to validate if some crashes are
resulting from using unlocked images, or incorrectly unlocking them
earlier.

R=enne@chromium.org, ericrk@chromium.org

Bug: 802976
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ibe0b9ef6ac52e6fafc9fd2670e20a9eefac17234
Reviewed-on: https://chromium-review.googlesource.com/979160
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545724}

Originally, the thread to update parameter
"V4L2_CID_MPEG_VIDEO_FORCE_KEY_FRAME" is different from QBUF the
frame, so we cannot make sure the parameter is updated right before
the key frame is QBUF. This CL queues the parameter |force_keyframe|
with the frame, and update the parameter before QBUF the frame.

BUG=b:74501913
TEST=pass GTS RtcVideoCodecTest#testRequestSyncFrameH264

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I1733f8ee474a0adeb8a31e6d196fdf27596a9f57
Reviewed-on: https://chromium-review.googlesource.com/958791
Commit-Queue: Chih-Yu Huang <akahuang@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545723}

This is an existing histogram logged for the Old Download Manager.
The histogram is already a part of histograms.xml file.

Bug: 791806
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I720221f6a5b395d947a96a99ce7e4d6fe7bee09e
Reviewed-on: https://chromium-review.googlesource.com/979267Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545722}

We try to support as many font properties as possible. However, several
font properties have not been implemented in Blink yet. Also, the
computed value for font-stretch is wrong (it should be as specified,
and no rounding should occur).

Spec: https://drafts.css-houdini.org/css-typed-om-1/#reify-stylevalue

Bug: 820299
Change-Id: I744d03a08856bd6d0df6bd07230ec80138e6e3b7
Reviewed-on: https://chromium-review.googlesource.com/977247Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545721}

In some (extreme) jumbo configurations on Mac two kBufferSize
constants ended up in the same translation unit and caused
a compilation error. This patch gives them unique names to
not cause any future problems.

Change-Id: I96d5e51024ff99fcb838346726aa1635127841eb
Reviewed-on: https://chromium-review.googlesource.com/978209
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545720}

Remove DeprecatedDataLogF() usage from platform/heap/.

Bug: 720442
Change-Id: Iac1a3ca91c932001ecb7f0e6beee3842108668c1
Reviewed-on: https://chromium-review.googlesource.com/977843Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545719}

There is a kLeftToRight in OSX's SDK and in WTF::Unicode. If
WTF::Unicode is imported into global scope those might clash and
this happens in some non-standard (extreme) jumbo configurations.

Since "using namespace" isn't allowed per the coding standard,
this just adds the WTF::Unicode namespace to those symbols
that need it.

Change-Id: I97c59e5ffed7d2bd0f8340f5d14b69dc532175d6
Reviewed-on: https://chromium-review.googlesource.com/978205
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545718}

There is both a ::testing namespace and a blink::testing namespace
and if you inside namespace blink says "testing", which one you
get depends on what the compiler knows. In jumbo builds compilers
often know about both namespaces and will assume you mean
::blink::testing.

To be sure to get ::testing, you need to prefix it with ::.

In the long run ::blink::testing should probably be renamed. Its
name violates the rule that no sub namespace should have the same
name as a common top level namespace.

Change-Id: I60857ebd08d4b35ce56212d03b4ed63045803402
Reviewed-on: https://chromium-review.googlesource.com/978004
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545717}

crrev.com/545269 added AdTracker to CoreProbes.json5, in which we don't
support snake_case source files yet.

Bug: 578345
Change-Id: I92e59040a7c413e56459b3c9f4faa02505d4738d
Reviewed-on: https://chromium-review.googlesource.com/977204Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545716}

We know these CLs won't pass presubmit checks.
We're going to land these CLs while the tree is closed.

Bug: 578345
Change-Id: I75549f683f61a1cd6cf8d5711c106bd49b32e8f7
Reviewed-on: https://chromium-review.googlesource.com/974670Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545715}

https://skia.googlesource.com/skia.git/+log/33477889c58b..9b67c565cc7b

$ git log 33477889c..9b67c565c --date=short --no-merges --format='%ad %ae %s'
2018-03-25 update-skps Update SKP version

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=mtklein@chromium.org

Change-Id: Ic12d58021e8c83d45abce9bdc5cc184ccf49e023
Reviewed-on: https://chromium-review.googlesource.com/979600Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#545714}