- 14 Apr, 2020 40 commits
-
-
Becca Hughes authored
Enhance the GetMediaFeeds API to sort results by audio+video watchtime percentile as well as limiting the number of results and having a minimum watchtime. This will be used for getting feeds to fetch and for display. BUG=1053599 Change-Id: If6015f57ba93a39ec07288fe8a3d1244c3bdb7ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145760Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#759062}
-
Sinan Sahin authored
This CL adds an OfflineIndicatorControllerV2 class that controls the status indicator widget for offline indicator specific purposes. This new class is owned by TabbedRootUiCoordinator like the status indicator widget itself. The old offline indicator snackbar is also disabled when V2 is enabled. Bug: 1068725 Change-Id: Ifa34779309f1229ca82d4a9ea7b1b9b49a43f4d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148217 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#759061}
-
Nigel Tao authored
Checking (result.error_code != JSON_NO_ERROR) is equivalent to checking result.value (which has a base::Optional type, convertible to bool). The error_code enum is really a private implementation detail. Callers don't care about it (other than it being an error or no error). Removing references (outside of //base/json) to that enum will let us more easily modify the //base/json implementation. Bug: 1070409 Change-Id: I54b8e787b5c1469efff77fda48d72a4d7251f7f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147401Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#759060}
-
Nigel Tao authored
Checking (result.error_code != JSON_NO_ERROR) is equivalent to checking result.value (which has a base::Optional type, convertible to bool). The error_code enum is really a private implementation detail. Callers don't care about it (other than it being an error or no error). Removing references (outside of //base/json) to that enum will let us more easily modify the //base/json implementation. Bug: 1070409 Change-Id: I2e67c7815fa8ce3e9ad784e85e236cf33558e8d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147440Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#759059}
-
Nigel Tao authored
Checking (result.error_code != JSON_NO_ERROR) is equivalent to checking result.value (which has a base::Optional type, convertible to bool). The error_code enum is really a private implementation detail. Callers don't care about it (other than it being an error or no error). Removing references (outside of //base/json) to that enum will let us more easily modify the //base/json implementation. Bug: 1070409 Change-Id: I0fe1f6d5debb837b6e7abab6fdfa0fd6a8a22e02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143190Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#759058}
-
Nigel Tao authored
Checking (result.error_code != JSON_NO_ERROR) is equivalent to checking result.value (which has a base::Optional type, convertible to bool). The error_code enum is really a private implementation detail. Callers don't care about it (other than it being an error or no error). Removing references (outside of //base/json) to that enum will let us more easily modify the //base/json implementation. Bug: 1070409 Change-Id: Ifffa60fa05d5dd2f52fabe0a2d6794db187e0f1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147400Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Vincent Boisselle <vincb@google.com> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#759057}
-
Nigel Tao authored
Checking (result.error_code != JSON_NO_ERROR) is equivalent to checking result.value (which has a base::Optional type, convertible to bool). The error_code enum is really a private implementation detail. Callers don't care about it (other than it being an error or no error). Removing references (outside of //base/json) to that enum will let us more easily modify the //base/json implementation. Bug: 1070409 Change-Id: I1e026b4b8e1544823b07ce2c6da9f5bd56f6c708 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145750Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#759056}
-
Alex Danilo authored
Selector specificity due to selector lengths for files-ng caused the selector for check-select 'Open' button color to be overridden. Change the non files-ng selector 'Open' button color case to not be applied when check-select mode is active. Bug: 1068556 Change-Id: I5fd36169941bcb4a1fad111d090b6ef728761aff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147138 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#759055}
-
Taylor Bergquist authored
This obviates the need for the work described in go/chrome-nonpredictive-tabstrip-animations. One known issue: with stacked tabs enabled, resize a window to trigger a transition into the stacked layout. The tabs will animate into the new layout, and while this is taking place, they will ignore any further changes to the tabstrip's bounds. Further work: Continue removing now-dead code from the new animation system. Bug: 958173 Change-Id: I977b3836ad87647fa17e431a1215ebd1ce81727c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055544Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#759054}
-
Robbie McElrath authored
This CL creates a NotificationSettingsClient in site_settings that contains embedder-specific logic needed to render the Site Settings UI. These 4 methods are mostly needed to support TrustedWebActivities, which are a Chrome-specific feature. They were put into their own client interface to keep SiteSettingsClient more organized. Bug: 1058597 Change-Id: Iceeeabc1476c39d079f8eb8aeade142dd5d4e05e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146141 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#759053}
-
Kevin McNee authored
Per the style guide, we should use proper test assertions to report failures gracefully. Bug: None Change-Id: I84be462364d6f310c08c591785d7f781a92251b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149376Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#759052}
-
David Bokan authored
Clusterfuzz found that using EventSender::DoDragDrop from a remote frame causes a crash. EventSender doesn't support remote frames in this case and this is a crash in test-only code so not severe but this CL will silence the fuzzer. Bug: 1070137 Change-Id: Ib64b677a792af2311cd7ace745755c2b9055219e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149282 Auto-Submit: David Bokan <bokan@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#759051}
-
David Black authored
The Assistant search provider will be used to provide a single search result from its internal cache of conversation starters. This will be surfaced as a suggestion chip in the launcher. This CL simply stubs in the provider (along with a single hardcoded result) so as to unblock development of the logic which will allocate Assistant a dedicated chip slot. Changes are gated behind a new feature flag: AssistantLauncherChipIntegration Bug: b:146673437, b:153165833 Change-Id: I54159c3ee17110c8fad46bbb3cea4a88b3250df9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134651 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#759050}
-
Mohamed Amir Yosef authored
This method decides for a given user and username, whether moving to the account store should be offerred or not. Bug: 1032992 Change-Id: Ie57a2d4f4bafe309ac114f2060270ca3d85c0a6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135612 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#759049}
-
Russell Davis authored
This bug happened in two cases when using Find: 1) On macOS, always 2) On all platforms, when text is selected This change fixes both cases, while also unifying macOS behavior with other platforms. (I think the previous exclusion of macOS from the find-from-selection behavior may have been due to a misunderstanding of some mac-specific code/comments.) Now, when doing a find-from-selection, the initial result is the same selected text, rather than the next occurrence. So it's a no-op (as it should be) in terms of the selection and the document scroll position. Bug: 1043550 Change-Id: I78a27b74324f74b1e3c7528fc91badf85f65d22f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145247 Auto-Submit: Russell Davis <russell.davis@gmail.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Jeff Fisher <jeffish@microsoft.com> Commit-Queue: Jeff Fisher <jeffish@microsoft.com> Cr-Commit-Position: refs/heads/master@{#759048}
-
Xiang Ji authored
The update inculdes windows 2019 server support and bring back nested vm support. Change-Id: I83c30ab71da31120d69c9559f10cb04f10a1a54c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147885Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Xiang Ji <jxiang@google.com> Cr-Commit-Position: refs/heads/master@{#759047}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fea8b94591c3..2136b569eb2e git log fea8b94591c3..2136b569eb2e --date=short --first-parent --format='%ad %ae %s' 2020-04-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 304e175c..72d0f390 (758795:758913) 2020-04-14 mbonadei@webrtc.org Remove AudioProcessing::UpdateHistogramsOnCallEnd. 2020-04-14 mbonadei@webrtc.org Remove NetEq::InsertPacket deprecated method. 2020-04-14 mbonadei@webrtc.org Remove the version of Port::AddrAddress without a URL parameter. 2020-04-14 philipp.hancke@googlemail.com insertable streams: include rtp_timestamp offset for audio Created with: gclient setdep -r src/third_party/webrtc@2136b569eb2e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1069278 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I782a927b88f3bf00d68d031ace8ed78866532baa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149807Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759046}
-
Wan-Teh Chang authored
Remove the two special cases (|index| is equal to decoder_->imageIndex or decoder_->imageIndex + 1) for the avifDecoderNthImage() call because avifDecoderNthImage() already handles these special cases internally. Also remove the !decoder_->image check because decoder_->image cannot be NULL after avifDecoderParse() has been called successfully. Bug: 960620 Change-Id: I222187d0619c33cb557b3c17b80af10a7c0e704c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149749Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#759045}
-
Brian Geffon authored
This adds a Swap File interface which is a generic interface which contains operations to write to, read from, and drop contents from a swap file. We also add three different swap file implementations on top of the standard swap file, which include a compressed, encrypted, and compressed + encrypted swap file. The compressed swap file implementation is a standard gzip implementation. The encrypted swap file uses AES 256 GCM SIV mode with a 256bit ephemeral key which is randomly generated and a randomly generated nonce. All swap files will write to /mnt/stateful_partition/unencrypted/swap if it exists otherwise swap file creation will fail. The key never leaves the internal EncryptedSwapFile implementation. The swap files are created as O_TMPFILE | O_EXCL meaning they do not actually link and O_EXCL prevents them being linked to the file system, so all space is reclaimed when the file descriptor is closed. Disk space can be incrementally reclaimed after memory has been read out of the swap file using the DropFromSwap API. It uses fallocate(2) with FALLOC_FL_PUNCH_HOLE. Bug: 1067833 Change-Id: Ifeacec0ed5571507f80add2cf43fdd4063478459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142474Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Commit-Queue: Brian Geffon <bgeffon@chromium.org> Cr-Commit-Position: refs/heads/master@{#759044}
-
Rachel Carpenter authored
We use this information to decide whether to show the Getting Started module in the app, and which cards in the module to show. Bug: b/151575693,b/151573827 Change-Id: I4f067a4c8b748e3e49804be650c5a7815e962379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147164Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@google.com> Cr-Commit-Position: refs/heads/master@{#759043}
-
Sammie Quon authored
Adds an optional if restore bounds exist to PersistentWindowInfo. On re-adding display update the restore bounds to what it was before display got removed. Test: manual, ash_unittests PersistentWindowControllerTest.RestoreBounds Bug: 1068458 Change-Id: I72e9b118759e99842a51c2293e496097ca739df5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147690Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#759042}
-
Thomas Guilbert authored
The video.requestAnimationFrame() API was renamed to the video.requestVideoFrameCallback API. This CL updates WPTs to use the new API name. Bug: 1012063 Change-Id: I065d26131367f43a534249622c7e2ef9a328d9f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145965 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#759041}
-
Peng Huang authored
Creating SkSurface is not cost free, so cache SkSurface in ExternalVkImageSkiaRepresentation and reuse it for all write access. Bug: None Change-Id: Ie055731effedb7ab95fff0d8ad734f507d1dea07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146232 Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#759040}
-
Charlie Hu authored
This CL adds use counters to record document policy usage. Details can be found on https://docs.google.com/document/d/1KV--4Btc2hKbCjUTAEl4vTlLAgM9W9qoPWbYAqC49xg/edit?usp=sharing Bug: 1066620 Change-Id: I530e42613929a78184b489a33d6fae67022b1dfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119662 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#759039}
-
Shakti Sahu authored
This is a reland of 011b4cb3 Note : Downstream CL will be landed immediately https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/2883534 Original change's description: > Query Tiles: Submit query on last level tile click > > This CL adds : > 1 - Submit query and show SRP on the last level tile click > 2 - Shorten most visited tile section to 1 row for smaller screens > > Bug: 1068308 > Change-Id: Icae29ad8bcc563ca6cfa3bfd35d18fa90ff65b7f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147041 > Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Cr-Commit-Position: refs/heads/master@{#758724} TBR=dtrainor@chromium.org Bug: 1068308 Change-Id: I69b53e5fc89e5982dcffbf927d21a355f7d507cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148826Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#759038}
-
Dale Curtis authored
https://chromium.googlesource.com/chromium/deps/nasm.git/+log/21eb59531974..4fa54ca5f7fc $ git log 21eb59531..4fa54ca5f --date=short --no-merges --format='%ad %ae %s' 2020-04-14 dalecurtis Disable sanitizers everywhere except msan. 2020-04-13 dalecurtis Disable sanitizers for nasm in all build types. 2020-04-13 dalecurtis Disable sanitizers for nasm like we do for yasm. 2019-10-07 efoo Add "# COMPONENT" to nasm OWNERS file Created with: roll-dep src/third_party/nasm TBR=davidben Bug: 766721 Change-Id: I86327ca55472650591f52b901ecb8a508cad30a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148027Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#759037}
-
Rohit Rao authored
These tests are attempting to load an invalid URL that happen to no longer be invalid. TBR=justincohen@chromium.org BUG=1070790 Change-Id: I03df3f99989b70013e4a047c3636f7e0b5d45fc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148029Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#759036}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/efca5651464d..9418b511c73b git log efca5651464d..9418b511c73b --date=short --first-parent --format='%ad %ae %s' 2020-04-14 amaiorano@google.com CMake: split out Vulkan sources into separate CMakeLists Created with: gclient setdep -r src/third_party/swiftshader@9418b511c73b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I032dfcd41294589e02b267b414bb6fd2a2b1c477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149614Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759035}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/83678e516e5f..1b30886d6dd3 git log 83678e516e5f..1b30886d6dd3 --date=short --first-parent --format='%ad %ae %s' 2020-04-14 tobine@google.com doc: Add note on Vulkan-Headers repo 2020-04-14 xinyi.he@arm.com Enable perFrameWindowSizeQuery by default on Mali Created with: gclient setdep -r src/third_party/angle@1b30886d6dd3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I470258b154854e73628d4cdf3117d4d72fd02918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149612Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759034}
-
Kevin Marshall authored
Collects histograms from child processes (GPU, renderer, etc.) before sending metrics over the fuchsia.legacymetrics.MetricsRecorder interface. Implement upload batching, to break up large report calls into smaller chunks that fit within the FIDL message limit. Make the AdditionalMetricsCallback interface asynchronous, so that async data collection may take place. Bug: 1060768 Change-Id: I4d4ae5f168ecbeb65a8d9745e940fb05f68e2399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147683 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#759033}
-
Theresa authored
This reverts commit 6b78be80. Reason for revert: Broke web search from text selection popup Original change's description: > Android: Fix a bug of text selection not working in SERP > > ChromeActionModeHandler adds an observer for init-web-contents event > of TabWebContentsObserver for each tab in order to register > ChromeActionModeCallback to its WebContents, therefore enabling > floating/toolbar action mode menu. > > For newly created tab, there was a bug this registration of the callback > not working (ok for the tab already created and swapping into > foreground). It's because init-web-contents event occurs before > adding an observer(mInitWebContentsObserver) to TabWebContentsObserver, > missing the chance to register the callback. > > This CL manually triggers the mInitWebContentsObserver for all the newly > created tab to fix the bug. Previously it was applied to only the very > first tab being added, but now extended to all those the newly created > and added. > > Bug: 1067524 > Change-Id: I511f15363e1e77f13347c5358aaf6eb3874a1a7b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136569 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#758641} TBR=dtrainor@chromium.org,twellington@chromium.org,jinsukkim@chromium.org Change-Id: I39041b67d4d145f1b287ec1c221e3bd5293b637b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1067524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149752Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#759032}
-
Navid Zolghadr authored
Remove the document-passive-wheel-event-listeners flag as it has been enabled by default for about a year. Change-Id: I6cbf3e3d305967f1ff7a96d033ec34f7df83db7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144265Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#759031}
-
Charlie Harrison authored
The feature is in development, so we should not expose any mojo endpoints. Bug: 1014604 Change-Id: Ia4998d3bc8a44fa7e6f12a32a253fffdbbbf34ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148220Reviewed-by:
John Delaney <johnidel@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#759030}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/75144cbad183..4a4e82967f41 git log 75144cbad183..4a4e82967f41 --date=short --first-parent --format='%ad %ae %s' 2020-04-14 jalyn@microsoft.com Revert buggy ListWidget changes Created with: gclient setdep -r src/third_party/devtools-frontend/src@4a4e82967f41 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1068065,chromium:1069471 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I14f8f178856ade927deb9e10ad8af6c498e4a3de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149618Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759029}
-
haozhe authored
For two animations with the same owning element (including the pseudo-element selector), this patch sorts animation1 and animation2 based on their position in the computed value of "animation-name" property. The spec: https://drafts.csswg.org/css-animations-2/#animation-composite-order We will have another patch to sort the CSSTransition align with the spec. Bug: 1045835 Change-Id: Iee379aa0d57fca387f96f24939623b35069d3019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137480 Commit-Queue: Hao Sheng <haozhes@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#759028}
-
Akihiro Ota authored
This change reworks the relationship between Output and LocaleOutputHelper. Instead of passing a callback to LocaleOutputHelper (which leaks state), LocaleOutputHelper computes and returns info to Output, which then calls its own append function. Change-Id: I92c7d08bec866db2922403297b2585054c8c6914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145685Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#759027}
-
Ben Joyce authored
Below CL can land after. https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/2880018 After this has landed, we can remove third_party/jsr from the temp target and from upstream. Need to do in two steps to prevent javax/<class> from being defined twice. Bug: 1070424, 1054152 Change-Id: I3bd29807347a08cc662038e29bec92a38d65521d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149689 Commit-Queue: benjamin joyce <bjoyce@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#759026}
-
Scott Violet authored
This makes it slightly easier to not need a new NavigationObserver per test. BUG=none TEST=none Change-Id: I7b8761f7cfabfcc775152ff30a309dddb37f0c8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149691Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#759025}
-
Nina Satragno authored
Add a dialog sheet to webauthn that will be used for inline biometric enrollment. The sheet contains an image of a fingerprint and a circle that fills progressively as the user taps the fingerprint scanner. This is based on the existing UI in the settings page but implemented in C++. The strings for the sheet are taken directly from the settings page. This UI is not connected to anything at the moment, but it can be tried by running the following command: browser_tests --gtest_filter=BrowserUiTest.Invoke \ --test-launcher-interactive \ --ui=AuthenticatorDialogTest.InvokeUi_inline_bio_enrollment Tbr'ing cpu@ as per chrome/app/OWNERS. Tbr: cpu@chromium.org Bug: 1056317 Change-Id: Ib18290c2eefedfa8a1b80a240153d8e881e3402b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140832 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#759024}
-
Xiaohui Chen authored
Bug: 1069659 Change-Id: I9b1e88b975544136d2f1827ac222874091f9b65b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144626 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#759023}
-