Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 17 Nov, 2017 25 commits
  3. 16 Nov, 2017 15 commits
    • Yuke Liao's avatar
      Revert "DownloadTaskImpl implementation for //ios/web Download API." · 499acc80
      Yuke Liao authored 
      This reverts commit cef83520.

Reason for revert: DownloadTaskImplTest.* tests fail on iOS 11 devices, both iPhone and iPad.

Original change's description:
> DownloadTaskImpl implementation for //ios/web Download API.
> 
> This CL implements DownloadTask public interface.
> 
> DownloadControllerImpl CL: crrev.com/c/758525
> Design doc: http://go/ios-web-download-api
> 
> Bug: 780646
> Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
> Change-Id: I2c508e77f3e529223499d6f2791b28011589fe90
> Reviewed-on: https://chromium-review.googlesource.com/758506
> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
> Reviewed-by: Gregory Chatzinoff <gchatz@chromium.org>
> Commit-Queue: Eugene But <eugenebut@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#517176}

TBR=sdefresne@chromium.org,eugenebut@chromium.org,gchatz@chromium.org

Change-Id: I14f0c37aa92330b0a665bf59bb665f010ee1209d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 780646
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/776067Reviewed-by: default avatarYuke Liao <liaoyuke@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517225}
      499acc80
    • Vlad Tsyrklevich's avatar
      Revert "[cfi-icall] Use ProtectedMemory for GetProcAddress" · 5c3c4ac8
      Vlad Tsyrklevich authored 
      This reverts commit d2cc1555.

Reason for revert: speculative revert, this might cause hangs on Linux component builds due to linker symbol resolution issues.

Original change's description:
> [cfi-icall] Use ProtectedMemory for GetProcAddress
> 
> Control Flow Integrity [1] indirect call (cfi-icall) checking can not
> verify that dynamically resolved function pointers call their intended
> function. Instead we place the pointer for GLGetProcAddress in
> ProtectedMemory, a wrapper for keeping variables in read-only memory
> except for when they are initialized.  After setting the pointer in
> protected memory we can use the UnsanitizedCfiCall wrapper to disable
> cfi-icall checking when calling it since we know it can not be tampered
> with.
> 
> [1] https://www.chromium.org/developers/testing/control-flow-integrity
> 
> Bug: 771365
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: Ia79c1cfab8e00f88bcc437c34cbb3012537c015a
> Reviewed-on: https://chromium-review.googlesource.com/769654
> Commit-Queue: Peter Collingbourne <pcc@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Reviewed-by: Peter Collingbourne <pcc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#517208}

TBR=kbr@chromium.org,pcc@chromium.org,vtsyrklevich@chromium.org

Change-Id: Ia474d99619795f9b2c40422858caf2a02461e462
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 771365
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/775596Reviewed-by: default avatarPeter Collingbourne <pcc@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517224}
      5c3c4ac8
    • Vlad Tsyrklevich's avatar
      Revert "[CFI] Use ProtectedMemory in CertVerifyProcNSS" · 63e4d43d
      Vlad Tsyrklevich authored 
      This reverts commit d0de1771.

Reason for revert: speculative revert, this might cause hangs on Linux component builds due to linker symbol resolution issues.

Original change's description:
> [CFI] Use ProtectedMemory in CertVerifyProcNSS
> 
> Because CertVerifyProcNSS dynamically resolves a pointer to the function
> CERT_CacheOCSPResponseFromSideChannel(), Control Flow Integrity [1]
> indirect call (cfi-icall) checking can not verify that it is the
> intended target for that function pointer call site.
> 
> Since we can not use cfi-icall to check the function pointer, instead we
> place the pointer in ProtectedMemory, a wrapper for keeping variables in
> read-only memory except for when they are initialized. After setting the
> pointer in protected memory we can use the UnsanitizedCfiCall wrapper to
> disable cfi-icall checking when calling it since we know it can not be
> tampered with.
> 
> [1] https://www.chromium.org/developers/testing/control-flow-integrity
> 
> Bug: 771365
> Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: I5d65b3591681f3daa917b6516eec1e5e47513d12
> Reviewed-on: https://chromium-review.googlesource.com/765098
> Reviewed-by: Peter Collingbourne <pcc@chromium.org>
> Reviewed-by: Eric Roman <eroman@chromium.org>
> Commit-Queue: Peter Collingbourne <pcc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#517169}

TBR=eroman@chromium.org,pcc@chromium.org,vtsyrklevich@chromium.org

Change-Id: I2d9a65fd6284c2cf954b46588d70fd1fa6292014
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 771365
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/775595Reviewed-by: default avatarPeter Collingbourne <pcc@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517223}
      63e4d43d
    • Tom Anderson's avatar
      Add check for missing sysroot libraries · 22c1deb1
      Tom Anderson authored 
      Linking on arm64 can fail when dependent libraries are missing.
That is, when linking against liba which depends on libb, linking
will fail when only libb is missing.

This CL adds a check to prevent these types of missing libraries.

BUG=webrtc:8535
R=thestig@chromium.org

Change-Id: I14e15ce534bd8ac5602f84dedcaab2db041656fb
Reviewed-on: https://chromium-review.googlesource.com/773200Reviewed-by: default avatarLei Zhang <thestig@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517222}
      22c1deb1
    • Joel Einbinder's avatar
      DevTools: Add context menu item to focus a node · 04a86be7
      Joel Einbinder authored 
      Brings the inspected page to front and focuses it

Change-Id: I0e6b18b079091fe2b0dfccbc69829470dcfaeeec
Reviewed-on: https://chromium-review.googlesource.com/761057Reviewed-by: default avatarDmitry Gozman <dgozman@chromium.org>
Reviewed-by: default avatarAlice Boxhall <aboxhall@chromium.org>
Reviewed-by: default avatarAndrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517221}
      04a86be7
    • Ian Kilpatrick's avatar
      [LayoutNG] Properly handle block-end borders. · c5d3db64
      Ian Kilpatrick authored 
      We previously didn't correctly handle block-end borders.

This fixes a couple of subtle bugs:
 - We don't grow the block-size of a fragment if it doesn't have
   any content.
 - We expand to encapsulate floats first, then grow to encapsulate
   the border.

Bug: 	635619
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I7770a1d23a9c25fcab51e2e681e00e4b4d3e9d08
Reviewed-on: https://chromium-review.googlesource.com/770645
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: default avatarChristian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517220}
      c5d3db64
    • dpapad's avatar
      Print preview new: Fix scrolling in sidebar. · eaa3cf0b
      dpapad authored 
      The lower part of the sidebar was incorrectly sized, causing the scrollbar
to appear after part of the content was already hidden.

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I50458546e67af9dfcd5416bdc81f6dfa7ca6e5b6
Reviewed-on: https://chromium-review.googlesource.com/775554Reviewed-by: default avatarRebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517219}
      eaa3cf0b
    • Vlad Tsyrklevich's avatar
      Revert "[cfi-icall] Use ProtectedMemory for localtime ptrs" · 1130da30
      Vlad Tsyrklevich authored 
      This reverts commit e77256b1.

Reason for revert: Reverting while I investigate failures causing recursive calls to hang.

Original change's description:
> [cfi-icall] Use ProtectedMemory for localtime ptrs
> 
> Control Flow Integrity [1] indirect call (cfi-icall) checking can not
> verify that dynamically resolved function pointers call their intended
> function. Instead we place the LibcFunctions pointers in
> ProtectedMemory, a wrapper for keeping variables in read-only memory
> except for when they are initialized.  After setting the pointers in
> protected memory we can use the UnsanitizedCfiCall wrapper to disable
> cfi-icall checking when calling them since we know they can not be
> tampered with.
> 
> [1] https://www.chromium.org/developers/testing/control-flow-integrity
> 
> Bug: 771365
> Change-Id: Ib74faff066e1107293b67d11f2a1a054bbff08b5
> Reviewed-on: https://chromium-review.googlesource.com/769853
> Reviewed-by: Chris Palmer <palmer@chromium.org>
> Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
> Reviewed-by: Peter Collingbourne <pcc@chromium.org>
> Commit-Queue: Peter Collingbourne <pcc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#517152}

TBR=jorgelo@chromium.org,palmer@chromium.org,pcc@chromium.org,vtsyrklevich@chromium.org

Change-Id: I77e142638d73bd53de4b6fc1b9db2ffc819f6459
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 771365
Reviewed-on: https://chromium-review.googlesource.com/775594Reviewed-by: default avatarPeter Collingbourne <pcc@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517218}
      1130da30
    • Emircan Uysaler's avatar
      Reland "Use async GPU readbacks in canvas.captureStream()" · f75ae2ad
      Emircan Uysaler authored 
      This is a reland of cff667d9
Original change's description:
> Use async GPU readbacks in canvas.captureStream()
>
> This CL replaces the existing blocking call to SkImage::readPixels() with
> GLHelper::ReadbackTextureAsync() and GLHelper::CreateReadbackPipelineYUV()
> callbacks for texture backed images.
> In order to use for these calls, a GLHelper instance is lazily created and
> owned by blink::WebGraphicsContext3DProvider.
>
> Bug: 727385
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: Iad8561183afddff0794038213ee22cec3e04ed76
> Reviewed-on: https://chromium-review.googlesource.com/756474
> Commit-Queue: Emircan Uysaler <emircan@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Yuri Wiitala <miu@chromium.org>
> Reviewed-by: Justin Novosad <junov@chromium.org>
> Reviewed-by: danakj <danakj@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#516979}

TBR=danakj@chromium.org,miu@chromium.org,kbr@chromium.org,haraken@chromium.org,junov@chromium.org

Bug: 727385
Change-Id: Ic939674cf678a239a9a68bfb6211198fa33441c9
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/775593Reviewed-by: default avatarEmircan Uysaler <emircan@chromium.org>
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517217}
      f75ae2ad
    • Scott Violet's avatar
      Removes "Linux ChromiumOS Tests (1)" · 7b2fb8a4
      Scott Violet authored 
      We're not using it anymore.

BUG=none
TEST=none

Change-Id: I029f967a98acc26ada4fbeebae4739acc9695d2f
Reviewed-on: https://chromium-review.googlesource.com/775178Reviewed-by: default avatarDirk Pranke <dpranke@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517216}
      7b2fb8a4
    • Andrew Grieve's avatar
      junit_binary(): Fix resource IDs for dependent libararies · 630e7db4
      Andrew Grieve authored 
      Robolectric assumes that all R.java files that define a resource define
it with the same ID. This is true for android_apk() targets because they
run a final process_resources() step. However, junit_binary() targets
currently just pull in the intermediary R.java files, which define different
values for same resources.

This change makes junit_binary act more like android_apk, in that it
adds a dedicated call to process_resources() in order to generate
consistent R.java files.

Bug: 785618
Change-Id: I62f8c3d30a626ec63ad22f9759adb9ad66f94b88
Reviewed-on: https://chromium-review.googlesource.com/773978Reviewed-by: default avatarJohn Budorick <jbudorick@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517215}
      630e7db4
    • v8-autoroll's avatar
      Update V8 to version 6.4.309. · 55849d8e
      v8-autoroll authored 
      Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/2db9c912..06577269

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: Ibcb3154e662ea26c346a8d67e8711f6ade564e36
Reviewed-on: https://chromium-review.googlesource.com/774758Reviewed-by: default avatarv8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517214}
      55849d8e
    • Trent Apted's avatar
      Mac: Don't shrink the omnibox when it has focus. · 7fb113ed
      Trent Apted authored 
      Also make the focus ring rounded corners properly rounded. Currently
the focus ring is drawn with a rounded-rectangle _stroke_. That gives
the "middle" of the stroke the correct correct corner radius, but it's
the outside edge of the stroke that matters. To make nice rounded
rectangles, it's necessary to draw a fill rather than a stroke.
Currently the focus ring on non-retina appears to take a "shortcut"
around the corners. Fix the border stroke as well as the focus ring
so that everything is symmetric and aligns nicely.

The shrinking is a problem for aligning bubbles. Fix it by, uh, not
shrinking when the omnibox has focus.

Animated before/after screenshots:
non-retina - https://bugs.chromium.org/p/chromium/issues/attachment?aid=312541&inline=1
    retina - https://bugs.chromium.org/p/chromium/issues/attachment?aid=312539&inline=1

Bug: 761701
Change-Id: I4d3e4dd15175c6d9454b633fa693cadeba39588f
Reviewed-on: https://chromium-review.googlesource.com/773718Reviewed-by: default avatarElly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517213}
      7fb113ed
    • liberato@chromium.org's avatar
      Enable overlays and FrameMetrics in MCVD. · a488ff94
      liberato@chromium.org authored 
      This CL incorporates SurfaceChooserHelper to handle promotion hints
from CodecImage.  It also requests promotion hints in
VideoFrameFactoryImpl.  This adds support for both player-fs and
div-fullscreen cases for overlays to MCVD.

Bug: 781875
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I8063a562676af9a0a5532b8434f9fe7fee20b005
Reviewed-on: https://chromium-review.googlesource.com/762061
Commit-Queue: Frank Liberato <liberato@chromium.org>
Reviewed-by: default avatarChris Watkins <watk@chromium.org>
Reviewed-by: default avatarThomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517212}
      a488ff94
    • Lucas Garron's avatar
      Take a command enum value instead of a string for SSLUITest::SendInterstitialCommand(). · 9c2daf8b
      Lucas Garron authored 
      Bug: 
Change-Id: I1f9c87102672de1c60c6e505ba183220e7b7689f
Reviewed-on: https://chromium-review.googlesource.com/774121
Commit-Queue: Lucas Garron <lgarron@chromium.org>
Reviewed-by: default avatarMustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517211}
      9c2daf8b