- 03 Apr, 2018 40 commits
-
-
Robert Ogden authored
Adds an experimental param on the connection robustness mechanism to disable proxy bypass when the via header is missing. Bug: 724704 Change-Id: I56286a06485b70c0c746850de14d79b2da755366 Reviewed-on: https://chromium-review.googlesource.com/990775 Commit-Queue: Robert Ogden <robertogden@google.com> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#547793}
-
https://pdfium.googlesource.com/pdfium.git/+log/75304f915c5c..232b918d1f0f $ git log 75304f915..232b918d1 --date=short --no-merges --format='%ad %ae %s' 2018-04-03 tsepez Re-arrange so inline vectors come last in structs. 2018-04-03 thestig Roll pdfium/third_party/freetype/src/ 713d68ee9..7109495c5 (21 commits) 2018-04-03 tsepez Off-by-one in CPDF_StreamParser::ParseNextElement() Created with: roll-dep src/third_party/pdfium BUG=chromium:828049 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I2892003f57e749fed8957a758722ec702d166bfd Reviewed-on: https://chromium-review.googlesource.com/992888 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547792}
-
Becca Hughes authored
If the media starts playing whilst the loading panel is either showing or cooling down we should hide it immediately as we are obscuring the video. BUG=827482 Change-Id: Ie0fb8159469fcc6740f624d052ac4b176f4f6876 Reviewed-on: https://chromium-review.googlesource.com/990192 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#547791}
-
David Tseng authored
On further scrutiny of the Android codebase, the following constraints get used to identify |IsAccessibilityFocusable|, which gets used to decide whether a node contributes to the computed bounds of a node or not. Any of these conditions makes a node "accessibility focusable", used here to mean "should use its rect" when sorting for child ordering - actionable nodes - top level scrollables with text In ARC++, we cannot seem to rely entirely upon replicating the exact logic, but keep the spirit of what is meant. To that end, we want to sort nodes by layout. This change gets much closer to what we want by: - allowing computed bounds to be empty (meaning it has no meaningful content). In these cases, we simply rely upon tree ordering - be very conservative when using a node's bounds. Only actionable nodes should matter. This potentially misses non-focusable nodes with text, or non-clickable nodes with text. However, mis-sorting a node is much much worse. This change does not consider virtual hierarchies, which should likely not trigger reodering, since an author has explicit contorl over child ordering in those cases. Change-Id: Iacffc5f2d88b6d52b732dadda8a01fd735665018 Reviewed-on: https://chromium-review.googlesource.com/989657 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#547790}
-
Wez authored
Reorganizes the logic to make clearer when the Profile will be deleted immediately, and when deletion can be deferred. Preconditions are separated into separate DCHECKs to make the failing conditions more visible, and basic information (e.g. RenderProcessHost counts) are copied to the stack and base::Alias()ed, to appear in crash dumps. Bug: 720078 Change-Id: I2138b14d27a157883bc62aab3cccf6920891aa9f Reviewed-on: https://chromium-review.googlesource.com/989120 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#547789}
-
Pavel Feldman authored
Change-Id: Ide6c3d4b2d9927dceb7b548200926c6933e9036e Reviewed-on: https://chromium-review.googlesource.com/991396 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#547788}
-
John Abd-El-Malek authored
Bug: 825242 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I21ab64e7570f7600031dbf566fc46214051bbc67 Reviewed-on: https://chromium-review.googlesource.com/989034Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#547787}
-
Min Qin authored
Just move the files and resolve all the includes, no functional change. BUG=803135 Change-Id: Ib5a9d7958639526da697ba6556b0d9433d544cee Reviewed-on: https://chromium-review.googlesource.com/991076Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#547786}
-
Jacob Dufault authored
Adding a key to cryptohome requires the associated UserContext. This adds an AuthToken to quick_unlock which stores the UserContext instance. The AuthToken automatically expires after a delay. Bug: 623344 Change-Id: Ife3373599fb560dfe9f9055fcda54a9f001c6ac7 Reviewed-on: https://chromium-review.googlesource.com/980738 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#547785}
-
John Budorick authored
Bug: 776495 Change-Id: Idfc2a6f82fa6bf6934e304c51eb2333659ce6f01 Reviewed-on: https://chromium-review.googlesource.com/993273Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#547784}
-
Nicolas Dossou-gbete authored
Bug: None Change-Id: I0d3f7a1228c935df57cb28cbcc5efc7dad4ea6f5 Reviewed-on: https://chromium-review.googlesource.com/989251Reviewed-by:
-
Emily Hanley authored
NOTRY=true Bug: 792780 Change-Id: I15c79b19873ea531c28d8b76105bf250bf112959 Reviewed-on: https://chromium-review.googlesource.com/992815 Commit-Queue: Emily Hanley <eyaich@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#547782}
-
Min Chen authored
new spec: https://drive.google.com/file/d/1JNH0ZDknXSvV00C7TeT4xT_rFx48OdZd/view Except this, UX asked to move icons 8px up and text 3px up. Bug: 826064 Change-Id: Iad0b2df7e396f5563c3f8d6f9858750920561c8a Reviewed-on: https://chromium-review.googlesource.com/990676 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Qiang Xu <warx@google.com> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#547781}
-
Adrienne Walker authored
https://chromium-review.googlesource.com/c/chromium/src/+/883944 restricted how often we would use shaders that clamped tex coords. However, this confusingly regressed perf a little bit on Android, which implies that program switching is expensive. This patch changes GLRenderer to always texture clamp these quads which reduces the number of shaders we use. Bug: 806836,806826 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2b2e71b362d6a12f17758abe2edddf1759536016 Reviewed-on: https://chromium-review.googlesource.com/972546Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#547780}
-
Lei Zhang authored
Make sure there is no text output when converting from PDF to PS for text with size 0. BUG=767343,827748 Change-Id: Id788b1f936d4f97b2201b7171a756a7ec2892bf1 Reviewed-on: https://chromium-review.googlesource.com/989299 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#547779}
-
Ken Rockot authored
We probably already have enough crash reports from this that it won't be useful to keep around, and there are good reasons not to keep uses of dump-without-crashing around for too long. Bug: 824024 Change-Id: Id02cd3eb11f436559b409df484ec204bfe6312aa Reviewed-on: https://chromium-review.googlesource.com/991464Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#547778}
-
Tim Zheng authored
This is to keep up to date with the logic change that the DBus service uses. The logic has changed to use hard coded release version and channel due to a bug in Finch. BUG=chromium:800120 TESTED=manually tested. Change-Id: Ic5c33d97c2100592732df4a0a14ab744197ec377 Reviewed-on: https://chromium-review.googlesource.com/987100Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Tim Zheng <timzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#547777}
-
Devlin Cronin authored
Add a developerPrivate API function to install a file that was dragged and dropped on the calling web contents, and add tests for the same. This will allow us to move the MD extensions page away from using chrome.send for this functionality. Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id2b4f5417a94c330c516d4eb1432c59c89c31e32 Reviewed-on: https://chromium-review.googlesource.com/981119Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#547776}
-
Andrew Grieve authored
Recent regression from 1796079a Bug: 827844 Change-Id: Ia29d752c0144d60e5e0fe74d6170671412375f0d Reviewed-on: https://chromium-review.googlesource.com/991409Reviewed-by:
Joy Ming <jming@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#547775}
-
Robert Ogden authored
bustamanate@ reports occasional hanging on tests that use the emulation server. This CL adds a timeout to ensure that a test run doesn't totally hang because of a flake here. Bug: 823776 Change-Id: I28bc040be9f9ae606f6b75481d2bf8dc21cc6957 Reviewed-on: https://chromium-review.googlesource.com/993272 Commit-Queue: Robert Ogden <robertogden@google.com> Reviewed-by:
Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#547774}
-
Lei Zhang authored
BUG=827329 Change-Id: I3ae863360df1b0374e367c094ca2c0d724c615c9 Reviewed-on: https://chromium-review.googlesource.com/986740Reviewed-by:
dsinclair <dsinclair@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: dsinclair <dsinclair@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#547773}
-
Dave Schuyler authored
This Cl annotates parameters to the SearchResult ctor. It only adds comments. There's no logic changes. Bug: None Change-Id: Icb625ce10e6fb61216250c96e62057e1d7c9091b Reviewed-on: https://chromium-review.googlesource.com/991397Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#547772}
-
Dave Tapuska authored
Allow extended mouse buttons to be injected via the automation code. BUG=680741 Change-Id: I2a9936e813abf9e5d0d5d3ee6dc98d44477f47f5 Reviewed-on: https://chromium-review.googlesource.com/986469 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#547771}
-
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/df968af49923..5e34303e0ea1 $ git log df968af49..5e34303e0 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib5275c5feee22740503048f4459e9ec282dd0145 Reviewed-on: https://chromium-review.googlesource.com/992882Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547770}
-
Francois Doray authored
This CL previously landed as https://chromium-review.googlesource.com/c/chromium/src/+/842306 It was reverted because TabLifecycleUnits were not always destroyed when tabs were closed, which caused invalid memory accesses. This was solved by https://chromium-review.googlesource.com/c/chromium/src/+/980587 TabManager discards tabs, but also ARC processes. LifecycleUnit is an abstraction to help us having one code path for all discards. TBR=chrisha@chromium.org,thestig@chromium.org Bug: 775644 Change-Id: Ib7f3dfd8b7e9b43ad75020c65e12d94229ba1a07 Reviewed-on: https://chromium-review.googlesource.com/980742Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#547769}
-
Erik Luo authored
This CL adds extra space above the search controls to make vertical padding symmetric. Screenshot: https://imgur.com/a/Txjbq Bug: nonw Change-Id: I1d8151a8320897c40b621f32d8c6960dab8d977b Reviewed-on: https://chromium-review.googlesource.com/981174Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#547768}
-
Morten Stenshorne authored
Change-Id: Idc2861dd0880697c385bf5b13cd48fd04f995a49 Reviewed-on: https://chromium-review.googlesource.com/982617 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#547767}
-
Kurt Horimoto authored
The origin view location is now communicated via NamedGuides. This is patch 1 of a 3-way patch. Bug: 805123 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I44c595341907b27f81a58b02895746c6cf284250 Reviewed-on: https://chromium-review.googlesource.com/981777 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#547766}
-
Daniel Park authored
Bug: 800033 Change-Id: I53c2b05a204f30b187efa4b703525c76a5a9dfb9 Reviewed-on: https://chromium-review.googlesource.com/940331 Commit-Queue: Daniel Park <danielpark@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#547765}
-
Benjamin Pastene authored
Its pool's got 30 bots. Should hopefully be enough for 50% of a compile-only bot. Bug: 731962 Change-Id: I7d27a8edf66170442ec6fcc66575e83ee355f9c4 Reviewed-on: https://chromium-review.googlesource.com/993154Reviewed-by:
-
Mustafa Emre Acer authored
This is the first translation screenshot to be used by http://go/chrome-translation-screenshots. This CL adds the SHA1 hash of the actual image which is stored in the Google Cloud Storage bucket at gs://chromium-translation-screenshots The screenshot can be downloaded using the gsutil tool like so: gsutil cp gs://chromium-translation-screenshots/378650e81625e476126a1a3d4b6ff559df54ef7c ~/translation.png Bug: 814897 Change-Id: I95bff8b6ac41be48a13212ad2bc9b4dcd5c4518b Reviewed-on: https://chromium-review.googlesource.com/976950Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#547763}
-
Xiaocheng Hu authored
The |if| statement's condition is always false, since |level| is set to |inline_box->BidiLevel()| in L165. Note: The code was originally introduced in crrev.com/edfe20, which already contains this redundant branching. Bug: 771398 Change-Id: If83f178b8ab91f15fcc7176e429541e69a681b15 Reviewed-on: https://chromium-review.googlesource.com/991604Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Lei Zhang authored
https://chromium.googlesource.com/breakpad/breakpad.git/+log/ac4a549e29fb..adcc90ddb8c9 $ git log ac4a549e2..adcc90ddb --date=short --no-merges --format='%ad %ae %s' 2018-04-02 thestig Linux: Write out si_code for SIGBUS exceptions. 2018-03-27 tikuta Add missing header for free function 2018-03-09 ted Allow minidump_dump to print module lists that would normally be rejected for being too long. 2018-02-23 bratell Fixing incorrect include guard (missing #define) 2018-01-31 lv Fix Travis build by running tests as root 2018-02-02 adamharrison Fix crash when an NSException is thrown. Created with: roll-dep src/third_party/breakpad/breakpad Change-Id: I22af38b45e0526afc5539a05d67d2795589535ec Reviewed-on: https://chromium-review.googlesource.com/992995Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#547761}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 02de1dcf. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15340 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: domenic@chromium.org, ricea@chromium.org: external/wpt/streams TBR=ajuma No-Export: true Change-Id: I77a008c5077e22979fc93d487960dd93cbe8d0e6 Reviewed-on: https://chromium-review.googlesource.com/992692 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#547760}
-
Julie Hockett authored
Updates the gn args --list command with an additional --json flag, which emits the same information as the normal --list command but in json format. Intended to be used to generate structured documentation for GN build arguments. The --markdown output is nice, but we want to do more processing than that to get it into good shape to integrate with our docs. Also updates the GetContextForValue function to get the file and the line number separately, rather than as one string, and updates the callsites with the new parameters. Change-Id: Id1240c37f835a18a12a6e4f5be58b9f8c7a663d1 Reviewed-on: https://chromium-review.googlesource.com/978423 Commit-Queue: Julie Hockett <juliehockett@google.com> Reviewed-by:
Roland McGrath <mcgrathr@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#547759}
-
John Abd-El-Malek authored
The problem was the constructor was posting a task to a different thread, which could execute before the constructor returns and a reference is held. This was seen in https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_ASan_LSan_Tests__1_%2F44439%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FMSE_ExternalClearKey__x2f_EncryptedMediaTest.Playback_VP9Video_WebM_Subsample__x2f_0%2F0 Bug: 825242 Change-Id: Ib851536adc57bfab14748e1f7324b143aff55033 Reviewed-on: https://chromium-review.googlesource.com/992876Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#547758}
-
Raphael Kubo da Costa authored
Instead of doing an assignment within one of the expressions, just use the constant being assigned to. This also fixes a warning produced by GCC: ../../chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.cc: In function ‘void {anonymous}::RecordTokenChanged(const string&, const string&)’: ../../chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.cc:95:16: warning: operation on ‘transition’ may be undefined [-Wsequence-point] transition = ~~~~~~~~~~~^ (new_token == ~~~~~~~~~~~~~ MutableProfileOAuth2TokenServiceDelegate::kInvalidRefreshToken) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ? TokenStateTransition::kRegularToInvalid ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ : transition = TokenStateTransition::kRegularToRegular; ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Change-Id: I8ea1dbd6ca499f3ba13a36dce41e152dc8263917 Reviewed-on: https://chromium-review.googlesource.com/992323Reviewed-by:David Roger <droger@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#547757}
-
Yuta Kitamura authored
Scheduler classes are being renamed as part of scheduler architecture refactoring. Bug: 826203 Change-Id: I1f59849cdb83bbc861cc3110b87d4f0bec901761 Reviewed-on: https://chromium-review.googlesource.com/989528Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#547756}
-
Robert Liao authored
Before this change, when the user clicks on the button to dismiss the Extension Popup, the popup would dismiss and destroy. Next, the incoming mouse-up would note that the popup is already gone and show the popup. We want the popup to stay closed if it was dismissed by clicking the action button. The Views Browser doesn't have this problem because MenuButton tracks the last time the locked state was released and suppresses any activation if it occurs too soon. This change simply carries similar logic from Views MenuButton to Cocoa BrowserActionButton. BUG=825866 Change-Id: I089f0ab8658277ae8cbf71e2813e62aeb3c5505f Reviewed-on: https://chromium-review.googlesource.com/991596Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#547755}
-
Henrik Boström authored
MediaStreams added to an RTCPeerConnection using the legacy addStream() API is wired up such that the RTCPeerConnection is informed when tracks are added or removed from the MediaStream so that the corresponding sender can be added/removed from the PC. OnStreamAddTrack/OnStreamRemoveTrack was wired up to call addTrack() and removeTrack(), the crash occurred if these operations were to throw an exception even though we just want to suppress any exceptions thrown. The ExceptionState is updated to allow an exception to be thrown before being cleared. This fixes the referenced bug. Bug: 814139 Change-Id: I7798d7cf43bb71d42b7b8108f40ffba36dc95946 Reviewed-on: https://chromium-review.googlesource.com/992321Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#547754}
-
