GitLab

Some cases are simple enough that a search and replace is sufficient. At the
same time, the fewer patches we have, the less time will be spent rebasing them.

BUG=414189
TBR=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/618013002

Cr-Commit-Position: refs/heads/master@{#297474}

They need base.isolate to bring in the VS runtime DLLs.

BUG=414808
R=maruel@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/ae092e2a50702e43fc8165eaadd84c7f64977945

Review URL: https://codereview.chromium.org/617983002

Cr-Commit-Position: refs/heads/master@{#297473}

It was possible for us to send it before.

BUG=none
TEST=none
R=ben@chromium.org, darin@chromium.org

Review URL: https://codereview.chromium.org/617513003

Cr-Commit-Position: refs/heads/master@{#297472}

Causing compile failures on Linux GN trybots.

> - Update _api_features.json and _permissions.json to allow the following features in extensions:
>  - declarativeWebrequest,
>  - events
>  - webRequest
>  - webViewRequest
>
> - Move web_view_request_custom_bindings.js and web_view_request.json to extensions.
>
> - Remove ExtensionsAPIClient::GetRuleRegistry() since RuleRegisteryService has been moved to extension.
>
> - Clean up extensions/extensions.gyp.
>
> TBR=sky@chromium.org
> BUG=352293

NOTREECHECKS=true
NOTRY=true
TBR=fsamuel@chromium.org,rockot@chromium.org,sky@chromium.org

Review URL: https://codereview.chromium.org/620623002

Cr-Commit-Position: refs/heads/master@{#297471}

BUG=418859

Review URL: https://codereview.chromium.org/615803002

Cr-Commit-Position: refs/heads/master@{#297470}

The CookieManager startup path needs access to the CommandLine
before initialization.

BUG=331424

Review URL: https://codereview.chromium.org/617883003

Cr-Commit-Position: refs/heads/master@{#297469}

BUG=chromedriver:815

Review URL: https://codereview.chromium.org/594383005

Cr-Commit-Position: refs/heads/master@{#297468}

Instead of going through the Chromium's script 'run_webkit_tests.py'
that lives in webkit/tools/layout_tests and it is just a wrapper around
'run-webkit-tests', call the later directly from
third_party/WebKit/Tools/Scripts/.

As we are removing webkit/ directory, this change is also necessary.

BUG=338338
TEST=None
R=dpranke@chromium.org,bruening@chromium.org

Review URL: https://codereview.chromium.org/608593007

Cr-Commit-Position: refs/heads/master@{#297467}

Revert of Fix swarming of browser_tests and sync_integration_tests on debug windows. (patchset #1 id:1 of https://codereview.chromium.org/617983002/)

Reason for revert:
failure: http://build.chromium.org/p/chromium.linux/builders/Android%20Builder/builds/38020/steps/runhooks/logs/stdio

Error: Command /usr/bin/python src/build/gyp_chromium returned non-zero exit status 1 in /mnt/data/b/build/slave/Android_Builder/build
Updating projects from gyp files...
gyp: Key 'includes' repeated at level 1 with key path '' while reading /mnt/data/b/build/slave/Android_Builder/build/src/chrome/browser_tests.isolate while reading includes of /mnt/data/b/build/slave/Android_Builder/build/src/chrome/tab_capture_end2end_tests.isolate while reading includes of /mnt/data/b/build/slave/Android_Builder/build/src/chrome/chrome_tests.gypi while reading includes of /mnt/data/b/build/slave/Android_Builder/build/src/chrome/chrome.gyp

Original issue's description:
> Fix swarming of browser_tests and sync_integration_tests on debug windows.
>
> They need base.isolate to bring in the VS runtime DLLs.
>
> BUG=414808
> R=maruel@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/ae092e2a50702e43fc8165eaadd84c7f64977945

TBR=maruel@chromium.org,jam@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=414808

Review URL: https://codereview.chromium.org/620603002

Cr-Commit-Position: refs/heads/master@{#297466}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9b220aa..07d889d

TBR=zmo@chromium.org,eustas@chromium.org
BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/620493003

Cr-Commit-Position: refs/heads/master@{#297465}

Some of the problems found by this code can be attributed to activity on
DLLs that are not being monitored.

BUG=362176
R=cpu@chromium.org

Review URL: https://codereview.chromium.org/587923002

Cr-Commit-Position: refs/heads/master@{#297464}

Start printing out the command used to run findbugs to allow for easier
debugging why findbugs might be failing.

BUG=None

Review URL: https://codereview.chromium.org/612883006

Cr-Commit-Position: refs/heads/master@{#297463}

android:permission puts a restriction on launching the activity such
that the launching context must have INTERNET permission. This is
not true launching via "am" on non-rooted devices, and makes no sense
for the public CastShellApk.

R=byungchul@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/615923003

Cr-Commit-Position: refs/heads/master@{#297462}

R=dbeam@chromium.org
BUG=393873
TEST=GYP_GENERATORS=ninja gyp --depth . chrome/browser/resources/options/compiled_resources.gyp && ninja -C out/Default | grep ERROR | wc -l

Review URL: https://codereview.chromium.org/566063002

Cr-Commit-Position: refs/heads/master@{#297461}

I moved all tests to Win Tests (dbg)(1) in preparation for removing 2, 3, 4, 5, & and Interactive Tests (dbg).

BUG=414808
R=maruel@chromium.org
NOTRY=true

Committed: https://chromium.googlesource.com/chromium/src/+/5f7ee2f338c9d7c5616c18e594ec8ef834d718c6

Review URL: https://codereview.chromium.org/618533002

Cr-Commit-Position: refs/heads/master@{#297460}

Dependency on these entries was removed in https://codereview.chromium.org/382313003/

BUG=412890

Review URL: https://codereview.chromium.org/600503002

Cr-Commit-Position: refs/heads/master@{#297459}

R=lcwu@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/615113002

Cr-Commit-Position: refs/heads/master@{#297458}

Also, restoring ttest constants to original values in ttest_test.

BUG=404088

Review URL: https://codereview.chromium.org/616903003

Cr-Commit-Position: refs/heads/master@{#297457}

They need base.isolate to bring in the VS runtime DLLs.

BUG=414808
R=maruel@chromium.org

Review URL: https://codereview.chromium.org/617983002

Cr-Commit-Position: refs/heads/master@{#297456}

When we enter overview the shelf is revealed which causes a workspace bounds
change. Normally the maximize mode window manager would update all active
windows to have the new bounds but this effectively undoes the transformation
applied to the window to show it in overview. As such, we defer updating the
bounds until we exit overview mode.

BUG=401664
TEST=WindowSelectorTest.FullscreenWindowMaximizeMode, WindowAnimationsTest.CrossFadeToBoundsFromTransform
TEST=Repro steps in http://crbug.com/401664

Review URL: https://codereview.chromium.org/588193003

Cr-Commit-Position: refs/heads/master@{#297455}

R=lcwu@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/616943002

Cr-Commit-Position: refs/heads/master@{#297454}

BUG=418590
NOTRY=true

Review URL: https://codereview.chromium.org/615563003

Cr-Commit-Position: refs/heads/master@{#297453}

+ Fix clipped button highlight
+ Tweaked the text sprite to correct the poor font rendering.
+ Fix to prevent keyboard 'details' link to cause activation.

BUG=418075,417956,418494

Review URL: https://codereview.chromium.org/609853002

Cr-Commit-Position: refs/heads/master@{#297452}

Also increase the sharding level. I missed that the testers were bare metal machines, and that's why tests ran so fast there.

BUG=414808
R=maruel@chromium.org

Review URL: https://codereview.chromium.org/618683003

Cr-Commit-Position: refs/heads/master@{#297451}

The final step in switching the angle gyp file will be to remove
the temporary angle_gyp variable.

BUG=415983

Review URL: https://codereview.chromium.org/614053003

Cr-Commit-Position: refs/heads/master@{#297450}

BUG=none
TEST=gn gen.

Review URL: https://codereview.chromium.org/609293004

Cr-Commit-Position: refs/heads/master@{#297449}

We no longer use this class, so we should remove it.

Note: this depends on https://codereview.chromium.org/603683006

R=danakj, junov

Review URL: https://codereview.chromium.org/610743002

Cr-Commit-Position: refs/heads/master@{#297448}

BUG=416722
R=cpu@chromium.org

Review URL: https://codereview.chromium.org/618523002

Cr-Commit-Position: refs/heads/master@{#297447}

BUG=414189
TBR=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/613303002

Cr-Commit-Position: refs/heads/master@{#297446}

VideoEncodeAccelerator::GetSupportedProfiles now runs in GPU
process because the profiles were added to GPUInfo. Add
kEnableWebRtcHWVp8Encoding to GPU process to fix the missing
encode profile.

BUG=418762
TEST=Run apprtc loopback and check the histogram.

Review URL: https://codereview.chromium.org/618633002

Cr-Commit-Position: refs/heads/master@{#297445}

BUG=415792

Review URL: https://codereview.chromium.org/615633003

Cr-Commit-Position: refs/heads/master@{#297444}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ea6d13f..9b220aa

TBR=zmo@chromium.org,eustas@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/616903002

Cr-Commit-Position: refs/heads/master@{#297443}

R=miguelg@chromium.org
BUG=none
TEST=cr info -o out_<foo>/Debug prints the configuration from the
     specified output directory instead of the currently selected
     target.
NOTRY=true

Review URL: https://codereview.chromium.org/597553003

Cr-Commit-Position: refs/heads/master@{#297442}

BUG=none
R=
TEST=none
NOTRY=true
(documentation only change)

Review URL: https://codereview.chromium.org/587753003

Cr-Commit-Position: refs/heads/master@{#297441}

R=vitalyp@chromium.org,tbreisacher@chromium.org
BUG=393873

Review URL: https://codereview.chromium.org/615733002

Cr-Commit-Position: refs/heads/master@{#297440}

With this change setting 'load_library_from_zip_file' to 1 will now
construct the APK with a new tool chain. The purpose of this change is
to contruct the APK in such a way that the page alignment is not broken
by the chrome signing process. To achieve this the tool is written in
Java so it shares the same underlying JarOutputStream implementation.
The key things that we depend on are that the filenames are output in
lexographical order with the META_INF files at the end of the file.
That zipalign adds 4 byte alignment to STORED files and this is done by
adding padding to the zip extra field.

BUG=390618

Review URL: https://codereview.chromium.org/595933003

Cr-Commit-Position: refs/heads/master@{#297439}

This is failing due to blink side CL. This will be fixed
with chromium side CL.

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/616003002

Cr-Commit-Position: refs/heads/master@{#297438}

The Win 7 x64 testers had twice as many cores as the 32 bit ones, and I didn't notice that when picking the sharding level earlier. Now that they're all going to the same swarming slaves, which are almost all 4-core, increase the sharding level.

BUG=414808
R=maruel@chromium.org

Review URL: https://codereview.chromium.org/619673003

Cr-Commit-Position: refs/heads/master@{#297437}

This fixed the build of lua and bullet which was
broken by the recent change in PNaCl toolchain
layout.

Review URL: https://codereview.chromium.org/613233002

Cr-Commit-Position: refs/heads/master@{#297436}

(As a drive-by, also convert some OVERRIDE -> override.)

R=tim@chromium.org
TBR=scherkus@chromium.org

Review URL: https://codereview.chromium.org/616513004

Cr-Commit-Position: refs/heads/master@{#297435}