- 20 Sep, 2018 39 commits
-
-
Caleb Rouleau authored
Bug: 886965 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I84c96f5d3399a20b83a98ec68f1157eac2d67685 Reviewed-on: https://chromium-review.googlesource.com/1235281 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#592653}
-
Ryan Hansberry authored
Update the MultiDevice and Tether watchlists with up-to-date file paths and current team members. Create new SmartLock watchlist. Change-Id: Iba7fdcefea847f0f6bf426ad485a47a76df71fd0 Reviewed-on: https://chromium-review.googlesource.com/1235309 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#592652}
-
Nigel Tao authored
This uninstalls (on log in) those web apps that were previously automatically installed due to being listed in an external .json file, but are no longer listed. This does for default-installed web apps what https://chromium-review.googlesource.com/1195293 "policy: Uninstall apps that are no longer forced installed" does for policy-installed web apps. Bug: 855281 Change-Id: I4125e60f4a6b9c6033d78ca54d0005be45d06e82 Reviewed-on: https://chromium-review.googlesource.com/1198644Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
-
Weilun Shi authored
Dynamically determine the first n tiles get loaded based on the window size. Bug: 876814 Change-Id: I7830faff7d090c8b33c7726ca3faa3439fe52dda Reviewed-on: https://chromium-review.googlesource.com/1232686 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#592650}
-
Xiaohan Wang authored
Integration test of playing encrypted AV1 using ClearKeyCdm requires more refactoring and will be landed in a later CL. TBR=jrummell@chromium.org Bug: 884898 Change-Id: I17e113a0d384e12a3e2590866a86c2f168b9ab9a Reviewed-on: https://chromium-review.googlesource.com/1229299Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#592649}
-
David Black authored
When refactoring, I accidentally assumed main thread. Bug: b:113731926 Change-Id: Ie989980c9f4796fb413b310a2254baaf36730f95 Reviewed-on: https://chromium-review.googlesource.com/1235211 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#592648}
-
Luciano Pacheco authored
Rendering this table in Gitiles requires a table header. I've checked rendering using "gitiles" link in: https://chromium-review.googlesource.com/c/chromium/src/+/1223347/9/docs/test_descriptions.md https://chromium.googlesource.com/chromium/src/+/refs/changes/47/1223347/5/docs/test_descriptions.md Add more information for WebUI tests. Bug: 880688 Change-Id: If19bada962b67899676ebd2e4d8fa19b9fcec381 Reviewed-on: https://chromium-review.googlesource.com/1223347Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#592647}
-
Stephen Martinis authored
This CL enforces swarming dimensions for the mac testers on chromium.mac using swarming_mixins. Bug: 880973 Change-Id: I3982de0c6704ceaa2f8e3ab5b9909c5c01319aa6 Reviewed-on: https://chromium-review.googlesource.com/1223027 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#592646}
-
Min Qin authored
This CL makes OfflineItemModel inherit from DownloadUIModel Bug: 881499 Change-Id: I63270a79917bae87fdb4ae3531f9088f7900509e Reviewed-on: https://chromium-review.googlesource.com/1225888 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#592645}
-
yusukes authored
The Arc.IntentHandler* metrics have been replaced with ChromeOS.Apps.IntentPicker* months ago. BUG=824598 TEST=try Change-Id: I4d86f17c4a1f5529e6bf063837b75a48564bc378 Reviewed-on: https://chromium-review.googlesource.com/1234860 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
-
Jordy Greenblatt authored
The existing menu item was a relic of an old design and was in the wrong place and had a different SVG from the 'Connected Devices' Settings UI page. Bug: 877166 Change-Id: Id71107ca97965965e213d12a94d1184424259fe6 Reviewed-on: https://chromium-review.googlesource.com/1235275Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#592643}
-
Chris Harrelson authored
This improves BGPT testing, and makes GraphicsLayer a bit smaller. Bug: 883949 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I97a09fd97085e6a157251348dfbadc175fa76a59 Reviewed-on: https://chromium-review.googlesource.com/1227680 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#592642}
-
David Staessens authored
The VAAPI JPEG decoder on some platforms won't convert the decoded images to the I420 format, but will return the decoded images in the JPEG's pixel format. This change adapts the VaapiJpegDecodeAcceleratorTest to work correctly when no conversion is done. Additional cleanup: * Made a few member functions const. TEST=ran JDA tests on eve and grunt Bug: 828119 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I715c5e88b8fa3c3d4db7a69a4e195d2ef3f79d8a Reviewed-on: https://chromium-review.googlesource.com/1218486 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#592641}
-
Josh Nohle authored
Before the CryptAuthClient attempts to make an API call, it fetches an OAuth2 access token. However, currently the client does not wait for the access token to become available before proceeding. This can lead to empty access token strings and errors such as [ERROR:cryptauth_device_manager_impl.cc(666)] GetMyDevices API failed: [authentication error] and [WARNING:cryptauth_enroller_impl.cc(139)] SetupEnrollment API failed with error: [authentication error]. Here, we change PrimaryAccountAccessTokenFetcher's mode from |kImmediate| to |kWaitUntilAvailable|. From PrimaryAccountAccessTokenFetcher's header file: |kImmediate|: Makes one-shot immediate request. |kWaitUntilAvailable|: Waits for the primary account to be available before making the request. In particular, "available" is defined as the moment when (a) there is a primary account and (b) that account has a refresh token. Bug: 887136 Change-Id: I745e0bb3f3ef1bc3226e46147fcb699c101d12dd Tested: Manual Reviewed-on: https://chromium-review.googlesource.com/1235284Reviewed-by:
-
Carlos Knippschild authored
Bug: 852872 Change-Id: I15f0b52900531ee987001ff4897f6c175470dcd3 Reviewed-on: https://chromium-review.googlesource.com/1234318Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#592639}
-
Aseem Garg authored
These were missed in an earlier CL. R=adamk@chromium.org BUG=v8:8186 Change-Id: I75e506098f2e2d4d7b507ce4f8a8b9a6c8d84b9c Reviewed-on: https://chromium-review.googlesource.com/1235315Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Cr-Commit-Position: refs/heads/master@{#592638}
-
Joel Einbinder authored
Keypress events have a different keycode, so the wrong events were being captured and sent to DevTools from extension panels. But keypress is deprecated and we don't need these events anywhere in DevTools. So we can just remove the event listener. Bug: 882422 Change-Id: I9d286f581aa77ff208463a2edbb4eea093fa98ee Reviewed-on: https://chromium-review.googlesource.com/1232853Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#592637}
-
Weidong Guo authored
Bug: 884765 Change-Id: Iab02be967ed5c39b03eab1eb82086e405a82bd17 Reviewed-on: https://chromium-review.googlesource.com/1235292 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#592636}
-
Zach Helfinstein authored
Bug: 885325 Change-Id: Ifc4253dff4334d85597fb14412248c02fcc41c2a Reviewed-on: https://chromium-review.googlesource.com/1231896 Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#592635}
-
dpapad authored
Specifically: - SettingsA11yManagePasswords - SettingsAccessibilityTest - TtsAccessibilityTest Bug: 875452 Change-Id: Ia9d5d6d12be9802ab4dece199c46d60c2d2b8867 Reviewed-on: https://chromium-review.googlesource.com/1235198Reviewed-by:
-
Artur Khachatryan authored
We updated Selenium latest binaries where a bug was fixed. Enabling ClickScrollingTest.testClickingOnAnchorScrollsPage test execution due to a Selenium bug fix with commit 1d85e230366fbc275877065b4b60f29ae052deaa at https://github.com/SeleniumHQ/selenium Change-Id: I84a916e5e138116c11a24e217597a81645d64b9e Bug: chromedriver:2480 Reviewed-on: https://chromium-review.googlesource.com/1235288Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#592633}
-
Byoungkown authored
The spec[1] states that XRCoordinateSystem inherits EventTarget. This patch implements the inheritance. [1]: https://immersive-web.github.io/webxr/#xrcoordinatesystem-interface Bug: None Change-Id: I509ff04c8bbe76a499655fa48a726ac10f444716 Reviewed-on: https://chromium-review.googlesource.com/1189503 Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#592632}
-
rbpotter authored
Ensure scale and copies have aria-labels (aria-labelledby no longer works when using cr-input instead of input). Add an aria-label for the custom pages radio button. Bug: None Change-Id: I564a31a0e9501becd2200c7c881d526772f731c6 Reviewed-on: https://chromium-review.googlesource.com/1233119 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Xiaohan Wang authored
These includes are already removed on desktop platforms. Also remove it on Android. This is in preparation for replacing WIDEVINE_CDM_AVAILABLE with a buildflag. TBR=jrummell@chromium.org Bug: 349182 Test: No functionality change Change-Id: I7f873247a3c986549caf4864fcb2efcc82918bc5 Reviewed-on: https://chromium-review.googlesource.com/1231925Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#592630}
-
rbpotter authored
(1) Make errors expand/contract rather than pre-allocating space (2) Adjust padding so that padding is always 16px regardless of error state (3) Fix an issue with pages error not appearing when radio button is reselected (4) Make error line-height correct. (5) Other changes to ensure labels stay correctly aligned with controls regardless of control height. (6) No hand pointer on error text. Bug: 884752, 884729, 884603, 884640, 885039 Change-Id: I9ff4e0bbc536b0890687b678cf52640c01e5a2ef Reviewed-on: https://chromium-review.googlesource.com/1229618 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#592629}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7f2ef8dd8ad7..0086f7aa8400 git log 7f2ef8dd8ad7..0086f7aa8400 --date=short --no-merges --format='%ad %ae %s' 2018-09-19 tbrindus@chromium.org cros_generate_stateful_update_payload: Convert to chromite 2018-09-19 zamorzaev@chromium.org test_stages: use chromite VM script instead of ctest for VMTest 2018-09-19 vapier@chromium.org cros_set_lsb_release: write out new CHROMEOS_RELEASE_KEYSET field 2018-09-19 dgarrett@google.com commands: Remove overlay args to UprevPackages and UprevPush. 2018-09-19 dgarrett@google.com PublishUprevChangesStage: Use overlay_type for UprevPush. 2018-09-19 chrome-bot@chromium.org Update config settings by config-updater. 2018-09-19 bhthompson@google.com Promote more build only paladins to non-experimental Created with: gclient setdep -r src/third_party/chromite@0086f7aa8400 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ief9c03bd4c6368acb4e9ab2ca561e1eb09aed530 Reviewed-on: https://chromium-review.googlesource.com/1235239Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592628}
-
Wenzhao Zang authored
The DM color extracted from wallpaper may be transparent, or invalid in cases that the color calculation fails or is disabled. Use a backup color in such cases. Bug: 884315 Change-Id: I76724a9bb9f19dff2fd70a563d79fb82533b0bfa Reviewed-on: https://chromium-review.googlesource.com/1232516Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#592627}
-
Will Harris authored
../../chrome/chrome_cleaner/zip_archiver/test_zip_archiver_util.cc(114,69): warning: implicit conversion loses integer precision: 'std::vector<char, std::allocator<char> >::size_type' (aka 'unsigned long long') to 'Cr_z_uLong' (aka 'unsigned long') [-Wshorten-64-to-32] unzip_object, &file_info, filename.data(), filename.size(), ~~~~~~~~~^~~~~~ ../../third_party/googletest/src/googletest/include\gtest/gtest.h(1961,23): note: expanded from macro 'EXPECT_EQ' val1, val2) ^~~~ ../../third_party/googletest/src/googletest/include\gtest/gtest_pred_impl.h(161,36): note: expanded from macro 'EXPECT_PRED_FORMAT2' GTEST_PRED_FORMAT2_(pred_format, v1, v2, GTEST_NONFATAL_FAILURE_) ^~ ../../third_party/googletest/src/googletest/include\gtest/gtest_pred_impl.h(146,39): note: expanded from macro 'GTEST_PRED_FORMAT2_' GTEST_ASSERT_(pred_format(#v1, #v2, v1, v2), \ ^~ ../../third_party/googletest/src/googletest/include\gtest/gtest_pred_impl.h(76,52): note: expanded from macro 'GTEST_ASSERT_' if (const ::testing::AssertionResult gtest_ar = (expression)) \ ^~~~~~~~~~ ../../chrome/chrome_cleaner/test/test_service_main.cc(27,44): warning: implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'DWORD' (aka 'unsigned long') [-Wshorten-64-to-32] TestTimeouts::action_max_timeout().InMilliseconds(); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~ ../../chrome/chrome_cleaner/http/http_agent_impl.cc(465,50): warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long long') to 'DWORD' (aka 'unsigned long') [-Wshorten-64-to-32] if (!::WinHttpReadData(request_.Get(), buffer, *count, &size_read)) { ~~ ^~~~~~ In file included from ../../chrome/chrome_cleaner/chrome_utils/extensions_util.cc:5: In file included from ../..\chrome/chrome_cleaner/chrome_utils/extensions_util.h:14: In file included from ../..\chrome/chrome_cleaner/json_parser/json_parser_api.h:8: In file included from ../..\base/callback.h:14: In file included from ../..\base/callback_internal.h:14: In file included from ../..\base/memory/ref_counted.h:18: ../..\base/memory/scoped_refptr.h(91,18): warning: implicit conversion loses integer precision: 'unsigned long long' to 'int' [-Wshorten-64-to-32] T* obj = new T(std::forward<Args>(args)...); ~ ^~~~~~~~~~~~~~~~~~~~~~~~ ../../chrome/chrome_cleaner/chrome_utils/extensions_util.cc(307,13): note: in instantiation of function template specialization 'base::MakeRefCounted<chrome_cleaner::(anonymous namespace)::ParseTasksRemainingCounter, unsigned long long, base::WaitableEvent *&>' requested here base::MakeRefCounted<ParseTasksRemainingCounter>(files_read.size(), done); ^ ../../chrome/chrome_cleaner/zip_archiver/target/zip_archiver_impl.cc(56,32): warning: implicit conversion loses integer precision: 'const long long' to 'int' [-Wshorten-64-to-32] offset, buffer.data(), std::min(length - offset, kReadBufferSize)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../chrome/chrome_cleaner/zip_archiver/target/zip_archiver_impl.cc(165,23): warning: implicit conversion loses integer precision: 'const long long' to 'int' [-Wshorten-64-to-32] std::min(src_length - src_offset, kReadBufferSize)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ BUG=879657 Change-Id: I80fbce280cd8a7e281d6f6ad58918aaab91514dd Reviewed-on: https://chromium-review.googlesource.com/1214050 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#592626}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d89e81168423..6c1a7f2c78db git log d89e81168423..6c1a7f2c78db --date=short --no-merges --format='%ad %ae %s' 2018-09-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 5c72f28d1a3f..d511948b9f82 (6 commits) Created with: gclient setdep -r src/third_party/skia@6c1a7f2c78db The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: Ic3174c7d52a9b781da9030d87a0f170cf0c68e1c Reviewed-on: https://chromium-review.googlesource.com/1235238Reviewed-by:
-
jchen10 authored
Use std::min instead. BUG=849576 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I7e6e76dd6c66e0b52d5c13bf87b1ca1785154654 Reviewed-on: https://chromium-review.googlesource.com/1233185 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
-
Tommy Steimel authored
This CL makes some visual tweaks to the media controls to match new specs. Bug: 884945 Change-Id: Ifdff1c51b6a2bd37555a7d018679dd77fc8781cc Reviewed-on: https://chromium-review.googlesource.com/1229696Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#592623}
-
Dale Curtis authored
Renderers are core to our entire pipeline, yet trace events are missing! So lets add a few that allow useful diagnosis when looking at trace reports. Specifically this adds traces for the following: - (AudioRenderer|VideoRenderer|RendererImpl)::Initialize() [async] - (AudioRenderer|VideoRenderer|RendererImpl)::Flush() [async] - DecoderSelector::SelectDecoder() [async] - RendererImpl::SetCdm - RendererImpl::StartPlayingFrom - RendererImpl::SetPlaybackRate - RendererImpl::OnBufferingStateChange - RendererImpl::StartPlayback - RendererImpl::PausePlayback - RendererImpl::OnRendererEnded - RendererImpl::OnError - RendererImpl::OnSelectedVideoTracksChanged - RendererImpl::OnEnabledAudioTracksChanged This also removes usage of ".is_null()" on callbacks in favor of the more modern built in boolean test. BUG=879970 TEST=none R=xhwang Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I79792d93b6369cfe4fe32f322f176b68acc92ee8 Reviewed-on: https://chromium-review.googlesource.com/1232688 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
Scott Violet authored
If it's not a WindowMus. This is an issue now that single-process-mash allows both WindowPortLocal and WindowPortMus at the same time. And updates WindowTreeClient::IsWindowKnown() not to assume a WindowMus. BUG=none TEST=none Change-Id: Ia4d1834b2a910707bae077dd14e4a9e46481fce0 Reviewed-on: https://chromium-review.googlesource.com/1235115 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#592621}
-
Steven Bennetts authored
Currently the code is triggering a crash indesktopui_MashLogin: http://ubercautotest.corp.google.com/tko/retrieve_logs.cgi?job=/results/239691238-chromeos-test/chromeos4-row2-rack3-host12/debug/ Bug: 843332 For extensions change: TBR=benwells@chromium.org Change-Id: I51d94a6924407fffbb49994ff4cb02718b517866 Reviewed-on: https://chromium-review.googlesource.com/1235206 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#592620}
-
John Budorick authored
Bug: 886926 Change-Id: Ifa80aa14b9684bfd3d54b944c40ebfa0d249ca71 Reviewed-on: https://chromium-review.googlesource.com/1234235Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#592619}
-
Doug Turner authored
Bug: 873219 Change-Id: I485848a2ddeb7187d51cf4a9b574942650bc6875 Reviewed-on: https://chromium-review.googlesource.com/1232887Reviewed-by:
Sarah Chan <spqchan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Doug Turner <dougt@chromium.org> Cr-Commit-Position: refs/heads/master@{#592618}
-
Chong Zhang authored
Chrome OS browser tests uses |ChromeNetworkDelegate::IsAccessAllowed| but |g_access_to_all_files_enabled| was not hooked in. This patch moved |g_access_to_all_files_enabled| to |IsAccessAllowedInternal| to make sure it's always checked. Bug: 884773 Change-Id: I5183f3250e13af151a987561bdf5f93a6f0200be Reviewed-on: https://chromium-review.googlesource.com/1235122 Commit-Queue: Chong Zhang <chongz@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#592617}
-
rbpotter authored
Note that title is to be changed to weight 400 rather than 500 per offline discussion (it was previously 500, not 700 as stated on the bug). Bug: 884896, 885109 Change-Id: I09aad405eaa07bcb7031b71e6bc91fb0c286b3e2 Reviewed-on: https://chromium-review.googlesource.com/1234995Reviewed-by:
-
Etienne Bergeron authored
On windows, the symbolisation (with crash server) requires the pdb name. The pdb name is often similar to the basename, but there is no real convention. ntdll.dll -> ntdll.pdb chrome.dll -> chrome.dll.pdb chrome1.exe -> chrome.exe.pdb R=wittman@chromium.org Change-Id: If69b2f4da24d88e9d260e8ee5024352250fbea43 Reviewed-on: https://chromium-review.googlesource.com/1234013 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#592615}
-
- 19 Sep, 2018 1 commit
-
-
rbpotter authored
Fixes some padding and focus issues in and around the link-container. (1) Correct padding above and below link-container (2) Make icon focusable rather than the entire row (3) Restore shortcut in system dialog string (4) Make icon not focusable when disabled (5) Correct padding in other-options-settings Bug: 884729, 885102, 884605 Change-Id: I0c8e1ac700ef93a4c6e247329d66285386af9f9f Reviewed-on: https://chromium-review.googlesource.com/1231826 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
