- 15 Aug, 2018 40 commits
-
-
Robert Sesek authored
This helper can be used in bpf_dsl::Policy::EvaluateSyscall() to make it easier to craft BPF policies that trap to the broker process. Change-Id: I8588b0a934343d7d0009c0d07bf259a085451ece Reviewed-on: https://chromium-review.googlesource.com/1175934 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#583407}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I3f3868d6dbb44d0e74b88d512f67386d3c0ba35b Reviewed-on: https://chromium-review.googlesource.com/1176362Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583406}
-
Min Chen authored
1. Added IndicatorType kDragAreaLeft, kCannotSnapLeft to show only left/top drag indicator, kDragAreaRight, kCannotSnapRight to show only right/bottom drag indicator, only kDragAreRight and kCannotSnapRight are used in this change, but still added kDragAreLeft and kCannotSnapLeft to keep consistence. 2. Move the logic to update the opacity of highlight view and label view from SplitViewDragIndicators to SplitViewHighligtView and RotatedImageLabelView instead. see recorded video: https://drive.google.com/file/d/0B5I0jFeLxqIiOGV3c0puTkJpTElBNUFSUlZpNEp6TElKUHJZ/view?usp=sharing Bug: 871607 Test: SplitViewTabDraggingTest.DragIndicatorsInPortraitOrientationTest Change-Id: I64f76766cd14dd2bca686be3f13d274993f24639 Reviewed-on: https://chromium-review.googlesource.com/1167998Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#583405}
-
Alexey Kozyatinskiy authored
Removed couple public methods and simplified map of map of map. R=lushnikov@chromium.org Bug: none Change-Id: Iac8b88478f9b7b7c4b722c2f65b723b7094559e4 Reviewed-on: https://chromium-review.googlesource.com/1176291Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#583404}
-
Peter Boström authored
Moves c/b/ui/views/harmony/ content into c/b/ui/views/. Also renames HarmonyTypographyProvider ChromeTypographyProvider to match the ChromeLayoutProvider. Bug: chromium:867557 Change-Id: I50a7c27c495187ef59893d417c6047a36499ffb6 Reviewed-on: https://chromium-review.googlesource.com/1175102 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#583403}
-
rajendrant authored
Bug: 836029 Change-Id: Ia0f2a3608eb9be51b652b2519365737276e4f2c6 Reviewed-on: https://chromium-review.googlesource.com/1175558Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#583402}
-
Robert Ogden authored
Renames it to be the UI helper, instead of specifically Infobar. No behavioral changes are done in this CL, just the renaming. Bug: 874523 Change-Id: I3e5a0c992af0a2c2b9c2ee03a9b45d337355abf8 Reviewed-on: https://chromium-review.googlesource.com/1176235Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#583401}
-
Marijn Kruisselbrink authored
This adds a WritableFiles RuntimeEnabledFeature, as well as a new FileSystemWriter interface (exact name TBD) and a mojo interface the implementation uses. Bug: 872460 Change-Id: I830a44d5df75fbfb5fbb1c97048a589a4facedc5 Reviewed-on: https://chromium-review.googlesource.com/1169773 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#583400}
-
Yue Cen authored
Bug: 835029 Change-Id: Ic37a08411a15be5b5fce1b727dbf6ed5e4a22c65 Reviewed-on: https://chromium-review.googlesource.com/1174980Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Cr-Commit-Position: refs/heads/master@{#583399}
-
David Bokan authored
This CL implements the "viewport bounds delta" for position: fixed elements. When the URL bar is hidden, the renderer is only resized when the user finishes scrolling. This means that while the scroll is on-going and the URL bar is hiding, the renderer is actually smaller than the visible area - we're revealing new content outside the renderer's bounds. Since position: fixed elements are positioned relative to the top- left corner of a layer, a bottom-fixed element would appear to detach from the bottom of the screen and move upwards as the URL bar hides. CC uses some slight-of-hand to prevent this by adding a "viewport bounds delta" to the scrolling and clipping bounds of the viewport layers. This allows the newly revealed content to be seen and keeps bottom-fixed elements static until the renderer itself is resized and the bounds delta can be cleared. This CL does the following things: 1) Update Blink to set the correct paint property tree state on bottom-fixed objects so that the bounds delta is correctly applied to them. 2) Modify the compositor to apply the bounds delta to the property trees directly, rather than using layers which may no longer exist in BGPT mode 3) Explicitly clamp the scroll offset on pending tree activation. LayerTreeHostImplTest, ClampingAfterActivation was failing after the early return was added to UpdateViewportContainerSizes. We were relying on the viewport scroll anchor to clamp the scroll offsets. Better to do this explicitly. The marked test is currently crashing but tests this behavior. I've confirmed that ignoring the crash causes the test to fail as expected and applying this patch fixes it. TEST=virtual/android/url-bar/bottom-fixed-adjusted-when-showing-url-bar.html Bug: 850135 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3a2da2648b47c2ccc0baf2876da12c228213dbe6 Reviewed-on: https://chromium-review.googlesource.com/1173441 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#583398}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 22fb8788. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22764 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: Ic0975f34aac3befbd2d98a41c366dd22ab1beef7 Reviewed-on: https://chromium-review.googlesource.com/1176184 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#583397}
-
Charlie Harrison authored
|opener| is DCHECKed to be non-nullptr earlier in this function, and is dereferenced a bunch of times. Bug: None Change-Id: Ia071bfb4159cbf7fb28765e21437d2af4817320b Reviewed-on: https://chromium-review.googlesource.com/1175938Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#583396}
-
Wei-Yin Chen (陳威尹) authored
For those subfolders of //chrome/browser without violations, add them to gn check targets. Otherwise, add number of errors in comments. Bug: 367595 Change-Id: Ifa21ab2023fc15b9740bf1ccce8ff5fa20909048 Reviewed-on: https://chromium-review.googlesource.com/1175236Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#583395}
-
Koji Ishii authored
This patch implements dom-snapshot inspector protocol for LayoutNG. The offset is not implemented yet in this patch, and thus 2 more tests do not pass yet. Bug: 636993 Change-Id: I0b57685cc6777ab8d06fbce8b5c8d935aed2648c Reviewed-on: https://chromium-review.googlesource.com/1175758 Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#583394}
-
Mike Dougherty authored
Bug: 862323 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ida6501b7c176b227be691c1120298eb563fd71bd Reviewed-on: https://chromium-review.googlesource.com/1176116 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#583393}
-
Lei Zhang authored
Print Preview needs the PDF plugin to work, but plugin loading happens asynchronously at startup. So querying the PluginService with GetPluginInfoByPath() may fail because the plugins have not been loaded yet. However, since the PDF plugin is a built-in PPAPI plugin, it does not need to be loaded from disk asynchronously. Since it is already registered, call GetRegisteredPpapiPluginInfo() instead. BUG=857074 Change-Id: I729b40329f1de92da6789efbbbae7e2c09ab8b51 Reviewed-on: https://chromium-review.googlesource.com/1175553 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#583392}
-
Nektarios Paisios authored
R=dmazzoni@chromium.org Change-Id: Icecff9eece2167e4678dca0aba1f0d0e08a457b0 Reviewed-on: https://chromium-review.googlesource.com/1175032Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#583391}
-
Hidy Han authored
Change-Id: I3d3113cb89a03b35a36a97fc38e156272729da77 Reviewed-on: https://chromium-review.googlesource.com/1176105 Commit-Queue: Hidy Han <hidyhan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#583390}
-
Chris Lu authored
Test covers the crash in bug 871769. That was fixed with CommandDispatcher forwarding BrowsingDataCommands protocol methods. ApplicationCommands conforms to BrowsingDataCommands, but tabgrid coordinator needs to explicitly dispatch both. Change-Id: I484f37864f2620eaa85c44e3a20c6d4aebd2f072 Reviewed-on: https://chromium-review.googlesource.com/1171796 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#583389}
-
Clark DuVall authored
This also prevents any crashes if we remove the legacy URLRequestContext getter in the network service. Bug: 855621 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ie14b64b803c8563ecae355dc220c9e56d11b4e7b Reviewed-on: https://chromium-review.googlesource.com/1176117Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#583388}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/af03ae194f78..ba883cb5ed14 git log af03ae194f78..ba883cb5ed14 --date=short --no-merges --format='%ad %ae %s' 2018-08-15 jbudorick@chromium.org bot_update: only fetch explicit refs for the main solution. Created with: gclient setdep -r src/third_party/depot_tools@ba883cb5ed14 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:865882 TBR=agable@chromium.org Change-Id: I2b06e973f53af5783f5335e77b068d9e38b0e2a5 Reviewed-on: https://chromium-review.googlesource.com/1174809Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583387}
-
Fernando Serboncini authored
The old function assumed that a async mojo calls between two sync calls would happen in sequence. This is not true at all. Bug: 872076 Change-Id: I9b7f78be76352c6133638665c60b156902fff1eb Reviewed-on: https://chromium-review.googlesource.com/1176078 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#583386}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c97a339cd601..b631742f0bff git log c97a339cd601..b631742f0bff --date=short --no-merges --format='%ad %ae %s' 2018-08-15 reed@google.com return this from maker calls, so we can chain the calls 2018-08-15 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@b631742f0bff The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: I593256e797055d3f20f997abf298cfb3534da231 Reviewed-on: https://chromium-review.googlesource.com/1176141Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583385}
-
Jeffrey Cohen authored
Bug: 864612 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5781f919f5903b78f5e922ad9774f9734513de97 Reviewed-on: https://chromium-review.googlesource.com/1173154Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#583384}
-
Christopher Cameron authored
Move these from BridgedNativeWidget to BridgedNativeWidgetHostImpl. Also move window BridgedNativeWidget::OnWindowWillClose callbacks from directly referencing NativeWidgetHost to going through the BridgedNativeWidgetHost interface (since they are responsible for removing BridgedNativeWidgetHostImpl as an observer now). Separate out the interface that to BridgedNativeWidget that will be turned into a mojo interface and name it BridgedNativeWidgetPublic. These will be renamed to BridgedNativeWidgetImpl and BridgedNativeWidget in a search-and-replace patch soon. Change-Id: I523aa8b3670b9432bde434af77ffd0e18a50f00e Reviewed-on: https://chromium-review.googlesource.com/1175238 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#583383}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/21a68ae8e5fa..70284b596877 git log 21a68ae8e5fa..70284b596877 --date=short --no-merges --format='%ad %ae %s' 2018-08-15 vapier@chromium.org cbuildbot: drop plaso boards Created with: gclient setdep -r src/third_party/chromite@70284b596877 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I4cc093d84f5547df122b41b60a6b4fb021301feb Reviewed-on: https://chromium-review.googlesource.com/1176142Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583382}
-
Mike Dougherty authored
Bug: 862323 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I54d310772edb6b2aaeb0f45dec831be170fd82e9 Reviewed-on: https://chromium-review.googlesource.com/1176111 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#583381}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/55ccb526913d..48ae3075a5c8 git log 55ccb526913d..48ae3075a5c8 --date=short --no-merges --format='%ad %ae %s' 2018-08-15 thestig@chromium.org Make CFX_MemoryStream always consecutive. Created with: gclient setdep -r src/third_party/pdfium@48ae3075a5c8 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I62f7ce66ae0020d50ef367868510df299ef1d588 Reviewed-on: https://chromium-review.googlesource.com/1176143Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583380}
-
Muyuan Li authored
Bug: b/112321739 Test: ash_unittests --gtest_fiter=AssistantContainerViewTest.TabletModeAnchoring. Change-Id: I283000679241bf33f4c0411632090d0cb3799aac Reviewed-on: https://chromium-review.googlesource.com/1175131 Commit-Queue: Muyuan Li <muyuanli@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#583379}
-
Lukasz Anforowicz authored
This is a reland of r580945 that is possible, because https://crbug.com/872803 is fixed now. Original CL description follows below... The newly introduced commit timeout defaults to 10 seconds. In addition to adding a content_browsertest, I've also manually tested the changes using steps from https://crbug.com/810633#c14. Note that after this CL a "hang renderer dialog" will appear if a navigation cannot commit because it tries to reuse a hung renderer. This is definitely an improvement. But also note that after using the dialog to kill the renderer, the navigation spinner will keep spinning - there is additional work needed to fix this (see https://crrev.com/c/1164466). Bug: 848821 Change-Id: I85ec7042e2dfe782e7f925dcede0ed81be633709 Tbr: Avi Drissman <avi@chromium.org> Tbr: Charlie Reis <creis@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1171381 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#583378}
-
Max Rebuschatis authored
Rename transformationMatrixToFloat32Array to transformationMatrixToDOMFloat32Array to more accurately reflect the type it returns. Bug: 845296 Change-Id: Iedea31c7b8335795657bf582215ed566861b4127 Reviewed-on: https://chromium-review.googlesource.com/1171830Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Max Rebuschatis <lincolnfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#583377}
-
Alex Moshchuk authored
This param was only being used to check for --single-process mode, which can be done via a static function on RenderProcessHost instead. This CL will simplify some of the plumbing in a later CL for locking hosted apps to an origin (https://crrev.com/c/959346). Bug: 791796 Change-Id: I0ef1e8f3a4a00f80e74f1109a092b795f3c63722 Reviewed-on: https://chromium-review.googlesource.com/1176216Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#583376}
-
Xida Chen authored
TBR=wjmaclean@chromium.org NOTRY=true Bug: 874567 Change-Id: Id6dab355e3886e839a90817bfcfd986dd2cbfde1 Reviewed-on: https://chromium-review.googlesource.com/1176352Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#583375}
-
Etienne Bergeron authored
This CL is adding the system performance counters on Windows. A way to compute the system IO activity is to sum IO counters for every processes. On windows, the GetIoCounters(...) call returns counters by process. Using this technique has two drawbacks 1) an expensive processes enumeration is required 2) processes may disappear during the sample slice, which is leading to inaccurate metric. We are proposing to call a ntdll API which returns system wide counters. The operating system is keeping system wide counters for IO accesses through ZwReadFile and ZwWriteFile. see: https://docs.microsoft.com/en-us/windows/desktop/api/winternl/nf-winternl-ntquerysysteminformation "Returns an opaque SYSTEM_PERFORMANCE_INFORMATION structure that can be used to generate an unpredictable seed for a random number generator. " Layout: https://cs.chromium.org/chromium/src/third_party/perl/c/i686-w64-mingw32/include/winternl.h?type=cs&l=609 https://processhacker.sourceforge.io/doc/struct___s_y_s_t_e_m___p_e_r_f_o_r_m_a_n_c_e___i_n_f_o_r_m_a_t_i_o_n.html To see these metrics, you can activate "system_stats" category and grab a trace. A sample is collected every two seconds and will be displayed in the tracing UI. Next step is to modify catapult to convert these tracing tracks as rate instead than raw counters. see: catapult/tracing/tracing/ui/extras/system_stats/system_stats_instance_track.html Change-Id: I45b6b04192c78dd5a0dc95eca0c2d357e74ca285 R=fdoray, gab Bug: 872900 Change-Id: I45b6b04192c78dd5a0dc95eca0c2d357e74ca285 Reviewed-on: https://chromium-review.googlesource.com/1169871Reviewed-by:Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#583374}
-
Randy Rossi authored
The 'wakeup device' tap gesture should happen on double tap while in screen reader mode, not single tap. Bug: None Test: Manual Change-Id: I683f2d8859d1b2ab127cfa57883246bdda844e68 Reviewed-on: https://chromium-review.googlesource.com/1176214Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#583373}
-
Eric Karl authored
Fixes two issues which were leading to failures in content_shell_test_apk: 1) We weren't correctly linking in the Android external begin frame source java code into content shell, leading to crashes due to class resolution failure. 2) Scroll tests assume that the browser is notified of every scroll offset change, whether or not it impacts the UI. As an optimization, SurfaceSync/Viz doesn't send this data unless needed. Adds a test only hook to always send data allowing for test inspeciton. Note that this addresses all but one remaining failure in: org.chromium.content.browser.VSyncPausedTest#testPauseVSync Bug: 871774, 871772 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I031d6616bcef11d302b6ecd43ee75586fbae8d71 Reviewed-on: https://chromium-review.googlesource.com/1173736Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#583372}
-
Xida Chen authored
TBR=wjmaclean@chromium.org NOTRY=true Bug: 874556 Change-Id: I3118312936415efcdbf4c5054f96d8a7a04b236c Reviewed-on: https://chromium-review.googlesource.com/1176341Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#583371}
-
Etienne Bergeron authored
This CL is adding trace events under the tracing category "safe_browsing" to determine whether or not chrome cleanup tool is running. This is useful to determine if the cleanup tool scanning/cleaning is affecting chrome by looking to the slow-reports. We currently can't determine whether or not the tool is running. R=csharp@chromium.org CC=etienneb@chromium.org Bug: 874448 Change-Id: I4b54ea470caab6ce63542bedd1169ab667aac008 Reviewed-on: https://chromium-review.googlesource.com/1176137Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#583370}
-
Xida Chen authored
The MaybeSendSyntheticTapGesture can be called in PreProcessMouseEvent, in which case the TouchActionFilter::allowed_touch_action_ has no value and will result in a crash. This CL set the allowed_touch_action_ to auto to fix the issue. A browser test is added. Bug: 873211 Change-Id: If776a93fe2c8f7a311a10bc0fec42cda15d0ae9a Reviewed-on: https://chromium-review.googlesource.com/1169585 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#583369}
-
Eric Orth authored
This allows a passable interface separate from NetworkContext that can be passed to places where NetworkContext is not easily available. The old NetworkContext::ResolveHost still exists as a shortcut as it is trivially implemented using an internal HostResolver. Implementation mostly consisted of moving the ResolveHost code from NetworkContext to the new class and adding a bit of code in NetworkContext to manage ownership of the HostResolver objects. Bug: 821021 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I2cbb675bc584783a4add17ad7d8a6701dbaf9098 Reviewed-on: https://chromium-review.googlesource.com/1158618Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#583368}
-