GitLab

strlen returns size_t which can be 64 bits yet all of the WTF strings
use 32 storage lengths. Add a helper function string_unsigned which
returns the strlen with a SafeCast to unsigned. Place it in an
implementation file to avoid increase in binary size due to inlining.

BUG=588506

Change-Id: I3b5025c1fee9b1eda9cd017af6bdfc66d808e802
Reviewed-on: https://chromium-review.googlesource.com/1096133Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566415}

Added tests that currently fail on ToT.

Change-Id: Ibb8720bdf54cc8f37c3cb0019c8d821ba3592cf6
Reviewed-on: https://chromium-review.googlesource.com/1097155
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566414}

If a CCT is active at the time the browser app itself is closed, the
shutdown transition from having a tabbed window (prior to the browser
being closed) to not having one (when only the CCT remains) is
problematic. Unless the scenario has special treatment, sync code
sees how tabs disappear one by one (they become null) and proceeds as if
the tabs were closed.

Instead, let's be strict about when a window is considered syncable, and
prevent updates as soon as at least one tab is null.

Bug: 639009
Change-Id: Iec64b31addc29a8c41e39b9f7aad8cd6fdfcd601
Reviewed-on: https://chromium-review.googlesource.com/1096235
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566413}

The CSS WG resolved [1] that Content Alignment should account to the
track sizing algorithm.

The sizing algorithm has been modified so that two new steps (1.5
and 2.5) were added to compute the Content Alignment offsets after
resolving the columns' and rows' sizes respectively.

This change decouples the Content Alignment logic from the tracks
position, so that we can use it as part of the track sizing algorithm.

I also had to store the whole ContentAlignmentData structure in two
class attributes. We need both, position and distribution offsets, to
be used in different parts of the layout logic.

Finally, since the ContentAlignmentData is now used as persistent
memory, we had to remove the STACK_ALLOCATED flag; hence, I think
using DISALLOW_COPY_AND_ASSIGN and let the functions update the
structure's internal field is a more efficient approach to commit
this change.

[1] https://github.com/w3c/csswg-drafts/issues/2557

Added WPT
  * grid-content-distribution-must-account-for-track-sizing-001.html
  * grid-content-distribution-must-account-for-track-sizing-002.html

Bug: 844744
Change-Id: I90019a96b148d3713467e35fde9482d0d39b1ced
Reviewed-on: https://chromium-review.googlesource.com/1067918
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#566412}

When an out of process iframe is deleted from the DOM, the player does
not notify the the browser process that it should leave the
Picture-in-Picture mode.

This is also fixing a TODO and updates a DCHECK. The TODO is because of
a refactor and the DCHECK was failing on a test that was just added.

Bug: 848044
Change-Id: I53ce77879cc08b70566449a705cdfb6723b4b013
Reviewed-on: https://chromium-review.googlesource.com/1095838Reviewed-by: apacible <apacible@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566411}

Mark http/tests/devtools/tracing/timeline-style/timeline-style-recalc-all-invalidator-types.js as flaky on MSAN.

Move it to the right expectations file as the flakiness is gone from the
other builders since crbug/850892 got fixed.

Bug: 851497
Change-Id: I15fb5f7444c743e5a2ec193736c3f9efc4696c98
Reviewed-on: https://chromium-review.googlesource.com/1096762Reviewed-by: Tim Schumann <tschumann@chromium.org>
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Commit-Queue: Tim Schumann <tschumann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566410}

 Fix `FilterBar::_update` to pass `false` for disabled items and not
 `undefined` as `classList.toggle` treats them differently.

Bug: 850641
Change-Id: I964c528ad6da495e2fd4078cde415e7cc250a13f
Reviewed-on: https://chromium-review.googlesource.com/1091312
Commit-Queue: Ingvar Stepanyan <ingvar@cloudflare.com>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566409}

A common use case (*the* common use case) for clients of
PrimaryAccountAccessTokenFetcher is for these clients to want to
destroy the fetcher when they receive the callback that the access
token request completed. However, PrimaryAccountAccessTokenFetcher
passes the arguments of that callback as const references, meaning
that it's not safe for clients to destroy the fetcher until the
callback completes. Clients currently go through a moderately
complicated dance to ensure that this flow occurs safely.

This CL changes that callback to take its parameters by value, making
it safe for clients to simply destroy the fetcher from within the
invocation of the callback. This CL also goes through the clients,
simplifying any that can now be simplified.

TBR=jochen@chromium.org

Bug: 796544
Change-Id: Iaaf151a5025be3e455a129c6334fb1ec6170901a
Reviewed-on: https://chromium-review.googlesource.com/1090710
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566408}

When MobileRenderingSharedState is used, the blogspot_pinch test fails
because pages in this page set are meant for mobile desktop sites.
To prevent this, make the tough_pinch_zoom page set desktop-only and set
the target_scale_factor based on platform instead of shared_page_state.

Bug: 851499
Change-Id: I9001784c37612a7da689fa8af3bcf3f0121dafec
Reviewed-on: https://chromium-review.googlesource.com/1096154
Commit-Queue: Amy Qiu <amyqiu@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#566407}

A final bg write wasn't being waited for, leading to flaky failures when
trying to read the metadata file.

Also fixed some incorrect use of ASSERT_* macros in helper functions.

BUG=845811
R=proberge@chromium.org

Change-Id: Ie1021ceafc03501180324195fe3a1da4dc312890
Reviewed-on: https://chromium-review.googlesource.com/1097076Reviewed-by: proberge <proberge@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566406}

As promised on
https://chromium-review.googlesource.com/c/chromium/src/+/1092575.

Change-Id: Ibd9946dda44bc9ec2a8f2594cbc1a27930f1bbb7
Reviewed-on: https://chromium-review.googlesource.com/1097084Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566405}

Change-Id: If63c916d8d405efb2f84794ec85dae110a20400a
Reviewed-on: https://chromium-review.googlesource.com/1096339Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566404}

This adds (as a drive-by) logging when unknown values are
used in UMA-from-webrtc, since this indicates an incomplete change.

Bug: chromium:718508
Change-Id: Ic21551e677a58f34d8e2418c17d1bf3256928cdb
Reviewed-on: https://chromium-review.googlesource.com/1082476Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566403}

BUG=829933

Change-Id: I40610c73441837327b827480cadddd325ac27fbf
Reviewed-on: https://chromium-review.googlesource.com/1096312Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566402}

This CL performs a one-off clean-up in the typed_url_sync_metadata table
in the history DB. A previous bug in the code (from M64 Stable) caused
that metadata for expired URLs stayed in the table. This CL removes such
orphanaged metadata.

Bug: 827111
Change-Id: If200517752298b889b79fbfe2b5371c4489b4773
Reviewed-on: https://chromium-review.googlesource.com/1078227
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566401}

Disable IncompatibleApplicationsBrowserTest.InjectIncompatibleDLL in viz_browser_tests in official builds

Bug: 850517
Change-Id: If948bf58245436ea071b63935f611c879c914307
Reviewed-on: https://chromium-review.googlesource.com/1096773Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566400}

Bug: 846694
Change-Id: Iecf328d8a43c96dd6772b48d0f0f80760a8a51e1
Reviewed-on: https://chromium-review.googlesource.com/1093096
Commit-Queue: Dominic Battré <battre@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566399}

Continuation of work in bug 646094.

This CL was uploaded by git cl split.

R=jianli@chromium.org

Bug: 846456
Change-Id: Ife19a981980ee18798721000d8d12d8730231e12
Reviewed-on: https://chromium-review.googlesource.com/1095991Reviewed-by: Jian Li <jianli@chromium.org>
Commit-Queue: Tiger Oakes <tigero@google.com>
Cr-Commit-Position: refs/heads/master@{#566398}

Removed context#getApplicationContext calls from /chrome/android/java/src/org/chromium/chrome/browser/firstrun

Continuation of work in bug 646094.

This CL was uploaded by git cl split.

R=bsazonov@chromium.org

Bug: 846456
Change-Id: Iabb1d50cbdce25c3b4c96c749d8853c48da619f2
Reviewed-on: https://chromium-review.googlesource.com/1095992Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Tiger Oakes <tigero@google.com>
Cr-Commit-Position: refs/heads/master@{#566397}

Removed context#getApplicationContext calls from /chrome/android/java/src/org/chromium/chrome/browser/media

Continuation of work in bug 646094.

This CL was uploaded by git cl split.

R=mlamouri@chromium.org

Bug: 846456
Change-Id: Ie0c0102c78325c15650ffc577b48cf77981a01ac
Reviewed-on: https://chromium-review.googlesource.com/1096007Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Tiger Oakes <tigero@google.com>
Cr-Commit-Position: refs/heads/master@{#566396}

Bug: 847420
Change-Id: I0e0441c339b53e12eb87735de2eb5ab978eecea4
Reviewed-on: https://chromium-review.googlesource.com/1095174Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566395}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=amineer@chromium.org

Change-Id: I9b1371d303248dd7f4cd2f201a6be7869574b897
Reviewed-on: https://chromium-review.googlesource.com/1096603Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566394}

Similar to https://crrev.com/c/1079608, this CL replaces uses of the
viewport scroll layers with the equivalent scroll node from the property
tree. This prepares for enabling blink-generated-property-trees since we
wont create the viewport scroll layers in that case, only the property
tree nodes.

This patch makes call sites use an accessor method which grabs the
scroll node from the viewport layer. A follow up patch will change this
helper to use the property tree directly if we're in BGPT mode. Some
more involved uses of the viewport layers remain and will have to be
fixed in future CLs but this is enough to enable basic scale-and-scroll
funcionality.

Note: while we did convert some uses of the outer viewport layer here,
we're mainly concerned with the inner viewport. That's because the
outer viewport is a scroller that generates content (like other
scrollers) and will continue to create and use a layer in BGPT. The
inner viewport layer is conceptual and will thus not generate a layer.

This CL should have no functional changes.

Bug: 836910
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ifa83fed2fa9b1847729ffafe75846da08e204237
Reviewed-on: https://chromium-review.googlesource.com/1085639
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566393}

IdentityTestEnvironment (and identity_test_utils.h) have an API for
setting a refresh token for a given account. However, this API has a
hidden gotcha: IdentityManager assumes that when a refresh token is
updated, AccountTrackerService knows about the account. This assumption
is valid in production, but IdentityTestEnvironment doesn't make any
attempt to ensure it in this testing context. The only reason that this
gotcha hasn't yet been tripped is because all uses of this API are
currently for the primary account, which AccountTrackerService *does*
already know about.

This CL sharpens this API to be just about setting a refresh token for
the primary account, with the constraint that the primary account must
itself already be set. A followup CL will add an API for adding an
account, as this will shortly be needed for porting
PrimaryAccountAccessTokenFetcher unittests.

Bug: 798699
Change-Id: Id734e582eb9841b3150b380486556b046212269c
Reviewed-on: https://chromium-review.googlesource.com/1095108Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566392}

This prepares for a future CL that will ensure the set of PAK
files extracted by this class match the UI language used by the
Android framework to display localized strings.

BUG=846633
R=agrieve@chromium.org, astevenson@chromium.org

Change-Id: I316dc53b23f3fc9139af845c1f9fad7e5b4138a6
Reviewed-on: https://chromium-review.googlesource.com/1091310Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: David Turner <digit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566391}

username

A generated password and a captured username should be presaved once a
user accepts a password generated by Chrome. If there is an entry with
the captured usernmae in the store, then Chrome presaves only password
(the username is empty).
Before this CL, Chrome always presaved only password.

This CL also ensures that a presaved entry is updated when the username
value has been changed by user.

Bug: 809019
Change-Id: I1f36f23d8ba12f09617b89791ce10a467f8dfa23
Reviewed-on: https://chromium-review.googlesource.com/1092745
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566390}

Bug: 714018
Change-Id: I024f77e3642a225302f748595430cb478de75fe9
Reviewed-on: https://chromium-review.googlesource.com/1093052Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566389}

This CL extends the browser-side FormData parser in password manager to
use server predictions to determine roles of input fields.

This support is incomplete and does not handle well partial predictions
yet, e.g., if only the USERNAME is predicted. It also does not handle
the "NOT_PASSWORD" prediction. Those will get addressed in separate CLs.

Bug: 845426
Change-Id: If8e444fb865c2c8358b122fed875386a9aa05ec8
Reviewed-on: https://chromium-review.googlesource.com/1087066
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566388}

https://skia.googlesource.com/skia.git/+log/8c6b49718210..0e2608e84fe5


git log 8c6b49718210..0e2608e84fe5 --date=short --no-merges --format='%ad %ae %s'
2018-06-12 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files


Created with:
  gclient setdep -r src/third_party/skia@0e2608e84fe5

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=csmartdalton@chromium.org

Change-Id: I9718923a5d3260226083d1d33cdbd995462ef35f
Reviewed-on: https://chromium-review.googlesource.com/1096705Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#566387}

These properties provide the author with the ability to control paddings
through logical, rather than physical, direction and dimension mappings.

Intent to Implement and Ship:
CSS flow-relative margins, paddings and borders
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/tkN-r119eNc

Spec: https://drafts.csswg.org/css-logical/#padding-properties

BUG=850000

TEST=external/wpt/css/css-logical/logical-box-padding.html

The test still has some failures because sideways writing modes have not
been implemented yet (http://crbug.com/680331).

Change-Id: Ic76da56385f2ef8c9638f90c9a358e4874d7c338
Reviewed-on: https://chromium-review.googlesource.com/1091313Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#566386}

SVG images are hosted from their own Page object which has its own
VisualViewport. Currently, we don't set the size on the VisualViewport
in this configuration which breaks some functaionality in the class, for
example, the maximum scroll offset is wrong since the size is empty but
the FrameView's (the visual viewport's scrollable contents) isn't.

This doesn't cause issues at the moment because the visual viewport
isn't consulted in painting the SVG. However, with
blink-gen-property-trees turned on, the visual viewport will add its own
paint property nodes which can cause problems if the viewport's state is
inconsistent.

Bug: 840017
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: If62c0e18fa9a6eb9cfe7f059ff5604f262af82fd
Reviewed-on: https://chromium-review.googlesource.com/1096010
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566385}

The goal is to remove the need for a pseudo style cache for pseudo
elements which have a PseudoElement on which we store a ComputedStyle
and a LayoutObject.

This CL removes an extra call to PseudoStyle() which would access the
pseudo style cache to re-retrieve the ComputedStyle(). Instead use
GetNonAttachedStyle() which would be set by the RecalcStyle() call for
re-attachment, or to null if the PseudoElement is no longer needed.

Bug: 836126
Change-Id: Ide807be656843fcbfad35fce7b2f3ed1c858a0f6
Reviewed-on: https://chromium-review.googlesource.com/1096761Reviewed-by: Anders Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566384}

Use AddScaled instead of custom aggregating logic in scheduler task
duration histograms and switch scale from seconds to milliseconds.

Bump versions for the affected histograms.

BUG=809668

Change-Id: Ie138671956108c0d0ea45a34209020737c9f25a1
Reviewed-on: https://chromium-review.googlesource.com/966903
Commit-Queue: Farah Charab <farahcharab@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566383}

Assigning the HitTestResult used for the PaintLayer will corrupt (reset)
any result acquired previously. So results from the foreground phase
would be erased by any later phase(s). Use HitTestResult::Append
instead if we're performing a list-based hit-test.

Bug: 849617
Change-Id: I5f53cad7e8396377815af51bd52db924b3fe6d5a
Reviewed-on: https://chromium-review.googlesource.com/1095182
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566382}

TBR=guidou@chromium.org
NOTRY=True

Bug: 777617
Change-Id: Ia6e81728d3dfac35c9b1724252e7539b3aae181a
Reviewed-on: https://chromium-review.googlesource.com/1096944Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566381}

As pointed out in a chromium-dev discussion [1], PasswordHashData is the
only piece of the password_manager component used in //chromeos.
However, it is part of a target which ultimately depends on a big chunk
of components.

This CL therefore isolates the struct to a separate target with no
dependencies other than base and crypto. It also ensures that the struct
is always initialized and const methods marked as such. Finally, it also
moves the older and related SyncPasswordData struct and some helper
functions into the new target, to avoid reintroducing the large
dependencies through HashPasswordManager.

[1] https://groups.google.com/a/chromium.org/d/msg/chromium-dev/nX63vp-75_U/h7H19i9dAQAJ

Bug: 850931
Change-Id: I0733f46bbc924bf63c43ff3cf25b148c2baef8e8
Reviewed-on: https://chromium-review.googlesource.com/1092863
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566380}

Remove debug data from traffic annotation FYI tests.
Change the script to be not sensitive to error text and fail only if the
test returns non-zero error code.

Bug: 844014
Change-Id: If48630e5730d391aef86ce68bbc513bed796cdbb
TBR: georgesak@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1096769Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566379}

One motivation for this, is to avoid the last log captured on
a business day from expiring over the weekend, before it has
a chance to be uploaded.

Bug: 775415
Change-Id: I2f750b6c558e49f6a179f32f4a708fb5b997dbf2
Reviewed-on: https://chromium-review.googlesource.com/1096760Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Elad Alon <eladalon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566378}

In jumbo build experiments, one obstacle for using jumbo for
chrome/ui is that there are too many kIconSize is the global
anonymous namespace. This patch renames them according to their
use, but other options are available (and are used) such as
moving the constants into the functions where they are used or
into a less global namespace.

Bug: 773275
Change-Id: I62db42da677cffc53087aede879deaf5245b3640
Reviewed-on: https://chromium-review.googlesource.com/1076237Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#566377}

With the removal of Chrome Home code, this code is now dead.

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Id8a1613c4119707418b2ff2fa3582c368072c71e
Reviewed-on: https://chromium-review.googlesource.com/1087270Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566376}